Repository navigation
[backport core/1.58] FE-1908 feat(billing): hand off to an open checkout instead of closing the dialog - #21409
Conversation
…g the Add credits dialog (#21395) ## Summary **Why:** after the hosted checkout opened, the workspace Add credits dialog closed at once. The customer lost the context of the purchase and had no way back to the checkout if they closed its tab. Product decision: show a hand-off screen instead (Figma: https://www.figma.com/design/C1fxz3akrW7Pl22zM2b301/?node-id=2100-10022, same as DES-1251 step 4). **Root cause:** `watchCheckoutCompletion` ended by closing the dialog. Nothing in the dialog represented an open checkout. **How:** both opening paths now land on the "Checkout opened in a new tab" screen: "Continue to checkout" opening its tab, and following the "Open checkout" link on "Checkout didn't open" (added in PR #21388). Body copy and button layout follow the Figma frame. - The pending top-up marker and the balance/status watch start as before. The dialog now closes itself when that watch sees the balance rise. - **Close** (and the header close icon) closes the dialog and keeps the pending top-up and the watch running, as before. - **Reopen checkout** reserves a tab during the click and POSTs `/api/billing/topup/checkout` again, so every click gets a fresh session. If that tab is blocked, the dialog goes back to "Checkout didn't open", linking to the new session's URL. If the session can't be created, the dialog stays on the hand-off and shows the existing "The payment page couldn't open" message. - Ported only the screen, the copy keys (`checkoutOpenedTitle`, `checkoutOpenedBody`, `reopenCheckout`) and the reopen behaviour from PR #21366. One-click Pay, "Set a default card" and its "Payment page didn't open" link are unchanged. The shared open path is `openCheckoutInReservedTab`, which returns `opened`, `blocked`, `failed` or `abandoned`. - No new client-derived facts. The dialog only reuses the checkout URL the server returned and the balance it already re-reads. **Feature flag / routing:** no new flag. `useBillingDialogs` shows `TopUpCreditsDialogContentWorkspace` when `useBillingRouting().type` is not `legacy`, which excludes personal workspaces on the legacy billing rail, and only when `canTopUp` is true. The checkout path is reached on a `NO_PAYMENT_METHOD` top-up refusal. Decision: https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1792450756887599 ## AS IS / TO BE | Path | AS IS (main) | TO BE (this PR) | | --- | --- | --- | | "Continue to checkout" opens its tab | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/as-is-checkout-opened.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/to-be-checkout-opened.png" width="360"> | | "Open checkout" link on "Checkout didn't open" | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/as-is-checkout-link-followed.png" width="420"> | <img src="https://gist.githubusercontent.com/dante01yoon/113bf168664254037d9c9479f926add1/raw/to-be-checkout-link-followed.png" width="360"> | AS IS: the dialog closes and the canvas shows no toast. Captured on testcloud in a team workspace on workspace billing routing with `canTopUp`. The top-up (`NO_PAYMENT_METHOD`) and checkout requests were mocked, and the checkout tab was a stub or a blank page. ## Verification - `pnpm exec vitest run src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`: 97 passed. The tests cover: - both opening paths landing on the hand-off (table-driven); - Reopen checkout sending a second checkout request and opening a new tab; - a blocked reopen linking to the new URL; - a failed reopen staying on the hand-off with the error; - the hand-off closing itself once the balance rises; - Close and the header icon each keeping the watch and the pending marker (table-driven). - I checked that the close-on-balance and keep-watch tests fail when that behaviour is removed. - `oxlint --type-aware`, `oxfmt` and `eslint` pass on the touched files. `pnpm typecheck:app` and `pnpm typecheck:browser` pass. - `topUpNoPaymentMethod.spec.ts` now expects the hand-off screen after checkout opens, then closes it with Close. The `TopUpCreditsDialog` fixture also matches the hand-off and blocked-screen headings. I did not run E2E locally. (cherry picked from commit 0b0ffbe)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-20T01:43:37.599Z",
"gitSha": "ca19f469c1e887d3ce44afa2a081243715dc1784",
"branch": "backport-21395-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.01199999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.6030000000000002,
"layouts": 10,
"layoutDurationMs": 1.547,
"taskDurationMs": 391.027,
"heapDeltaBytes": 6390988,
"heapUsedBytes": 94270432,
"domNodes": -180,
"jsHeapTotalBytes": -2715648,
"scriptDurationMs": 6.725,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2027.1710000000098,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.303,
"layouts": 11,
"layoutDurationMs": 2.1279999999999997,
"taskDurationMs": 330.454,
"heapDeltaBytes": -11959772,
"heapUsedBytes": 92263704,
"domNodes": -200,
"jsHeapTotalBytes": 2002944,
"scriptDurationMs": 8.498000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.9160000000056,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.622,
"layouts": 10,
"layoutDurationMs": 1.519,
"taskDurationMs": 564.311,
"heapDeltaBytes": -2382356,
"heapUsedBytes": 95955140,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 92.92599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1713.1400000000099,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.012,
"layouts": 10,
"layoutDurationMs": 1.74,
"taskDurationMs": 649.6379999999999,
"heapDeltaBytes": -5228232,
"heapUsedBytes": 93532808,
"domNodes": -181,
"jsHeapTotalBytes": 6197248,
"scriptDurationMs": 98.277,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.0340000000074,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.5869999999999997,
"layouts": 12,
"layoutDurationMs": 2.0559999999999996,
"taskDurationMs": 269.233,
"heapDeltaBytes": 1846780,
"heapUsedBytes": 105958588,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7.809,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.0929999999817,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.625,
"layouts": 13,
"layoutDurationMs": 2.336,
"taskDurationMs": 230.40699999999998,
"heapDeltaBytes": 1744440,
"heapUsedBytes": 105722456,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 10.024000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 532.9190000000494,
"styleRecalcs": 14,
"styleRecalcDurationMs": 1.777,
"layouts": 10,
"layoutDurationMs": 1.5830000000000002,
"taskDurationMs": 334.34,
"heapDeltaBytes": 6801828,
"heapUsedBytes": 111073344,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 106.811,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 534.1579999999908,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.2100000000000004,
"layouts": 10,
"layoutDurationMs": 1.764,
"taskDurationMs": 340.01,
"heapDeltaBytes": 6865828,
"heapUsedBytes": 111100964,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 109.84,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1002.8880000000129,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.2350000000001,
"heapDeltaBytes": -9085068,
"heapUsedBytes": 102056684,
"domNodes": -220,
"jsHeapTotalBytes": 10661888,
"scriptDurationMs": 39.087,
"eventListeners": -168,
"totalBlockingTimeMs": 332,
"frameDurationMs": 27.777777777777764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 956.9650000000252,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.2339999999999,
"heapDeltaBytes": -9297216,
"heapUsedBytes": 101361400,
"domNodes": -230,
"jsHeapTotalBytes": 9613312,
"scriptDurationMs": 38.39399999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 329,
"frameDurationMs": 27.617142857142866,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 714.1949999999895,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.40300000000013,
"heapDeltaBytes": -3032208,
"heapUsedBytes": 97163400,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.90799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 105,
"frameDurationMs": 21.076470588235278,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 717.3179999999775,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.5709999999998,
"heapDeltaBytes": -3519616,
"heapUsedBytes": 96599652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 92.111,
"eventListeners": 0,
"totalBlockingTimeMs": 99,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7212.8629999999985,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7749999999999997,
"layouts": 3,
"layoutDurationMs": 0.5939999999999999,
"taskDurationMs": 6378.794,
"heapDeltaBytes": 7538488,
"heapUsedBytes": 128987328,
"domNodes": -276,
"jsHeapTotalBytes": 32149504,
"scriptDurationMs": 4751.241999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 106,
"frameDurationMs": 24.462372881355932,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6580.546999999968,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.732,
"layouts": 3,
"layoutDurationMs": 0.702,
"taskDurationMs": 5531.091,
"heapDeltaBytes": 27659348,
"heapUsedBytes": 148885656,
"domNodes": -276,
"jsHeapTotalBytes": 27693056,
"scriptDurationMs": 4154.021,
"eventListeners": -126,
"totalBlockingTimeMs": 79,
"frameDurationMs": 21.09967948717949,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6423.467999999985,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7629999999999998,
"layouts": 3,
"layoutDurationMs": 0.7769999999999999,
"taskDurationMs": 5445.8679999999995,
"heapDeltaBytes": -2467768,
"heapUsedBytes": 119100852,
"domNodes": -276,
"jsHeapTotalBytes": 19841024,
"scriptDurationMs": 4036.118,
"eventListeners": -130,
"totalBlockingTimeMs": 92,
"frameDurationMs": 21.443666666666665,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6558.186999999975,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6090000000000002,
"layouts": 3,
"layoutDurationMs": 0.5419999999999999,
"taskDurationMs": 5666.334,
"heapDeltaBytes": 26557488,
"heapUsedBytes": 147781976,
"domNodes": -276,
"jsHeapTotalBytes": 26382336,
"scriptDurationMs": 4172.7970000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 39,
"frameDurationMs": 22.277891156462587,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 147.72399999998242,
"styleRecalcs": 20,
"styleRecalcDurationMs": 10.546,
"layouts": 11,
"layoutDurationMs": 2.2779999999999996,
"taskDurationMs": 99.998,
"heapDeltaBytes": 13163980,
"heapUsedBytes": 118360224,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.281000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 149.03299999997444,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.760000000000002,
"layouts": 12,
"layoutDurationMs": 2.616,
"taskDurationMs": 101.16900000000001,
"heapDeltaBytes": 13221772,
"heapUsedBytes": 118525020,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.842,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.23333333333335,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2024.7400000000084,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.3820000000000003,
"layouts": 8,
"layoutDurationMs": 1.4329999999999998,
"taskDurationMs": 446.4509999999999,
"heapDeltaBytes": 279148,
"heapUsedBytes": 102377440,
"domNodes": -296,
"jsHeapTotalBytes": -6123520,
"scriptDurationMs": 24.3,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.413000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5630000000000002,
"layouts": 9,
"layoutDurationMs": 1.5399999999999998,
"taskDurationMs": 466.825,
"heapDeltaBytes": 4696612,
"heapUsedBytes": 106866164,
"domNodes": -276,
"jsHeapTotalBytes": -4812800,
"scriptDurationMs": 28.599,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2126.3000000000147,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.2909999999999995,
"layouts": 8,
"layoutDurationMs": 1.3110000000000002,
"taskDurationMs": 950.124,
"heapDeltaBytes": -2295836,
"heapUsedBytes": 99509348,
"domNodes": -297,
"jsHeapTotalBytes": -1703936,
"scriptDurationMs": 475.50899999999996,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666929133858268,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2180.4329999999936,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.444,
"layouts": 8,
"layoutDurationMs": 1.41,
"taskDurationMs": 1221.761,
"heapDeltaBytes": -7537744,
"heapUsedBytes": 108313320,
"domNodes": -276,
"jsHeapTotalBytes": -28672,
"scriptDurationMs": 534.872,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3239.6549999999706,
"styleRecalcs": 73,
"styleRecalcDurationMs": 8.184000000000001,
"layouts": 67,
"layoutDurationMs": 9.405999999999999,
"taskDurationMs": 1296.0079999999998,
"heapDeltaBytes": -9823672,
"heapUsedBytes": 95671020,
"domNodes": -272,
"jsHeapTotalBytes": -581632,
"scriptDurationMs": 524.0369999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665979381443297,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3172.0809999999915,
"styleRecalcs": 73,
"styleRecalcDurationMs": 9.889,
"layouts": 67,
"layoutDurationMs": 10.641000000000002,
"taskDurationMs": 1342.735,
"heapDeltaBytes": -23634328,
"heapUsedBytes": 90496440,
"domNodes": -273,
"jsHeapTotalBytes": -946176,
"scriptDurationMs": 550.91,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2119.3179999999643,
"styleRecalcs": 46,
"styleRecalcDurationMs": 3.229,
"layouts": 6,
"layoutDurationMs": 0.9460000000000001,
"taskDurationMs": 1113.018,
"heapDeltaBytes": 15927816,
"heapUsedBytes": 122253864,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 575.7719999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283464,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2297.588000000019,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.708,
"layouts": 8,
"layoutDurationMs": 1.429,
"taskDurationMs": 1335.542,
"heapDeltaBytes": 17545268,
"heapUsedBytes": 124139368,
"domNodes": 0,
"jsHeapTotalBytes": 6713344,
"scriptDurationMs": 622.283,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.786861313868613,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2020.2320000000213,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5410000000000004,
"layouts": 9,
"layoutDurationMs": 1.542,
"taskDurationMs": 436.09,
"heapDeltaBytes": -2729868,
"heapUsedBytes": 101182876,
"domNodes": -276,
"jsHeapTotalBytes": -2871296,
"scriptDurationMs": 19.060999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.016999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.5299999999999991,
"layouts": 9,
"layoutDurationMs": 1.4659999999999997,
"taskDurationMs": 355.31800000000004,
"heapDeltaBytes": 8902652,
"heapUsedBytes": 111738200,
"domNodes": -276,
"jsHeapTotalBytes": -5337088,
"scriptDurationMs": 29.302000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 415.4309999999555,
"styleRecalcs": 48,
"styleRecalcDurationMs": 3.416,
"layouts": 11,
"layoutDurationMs": 1.574,
"taskDurationMs": 260.22499999999997,
"heapDeltaBytes": 2588020,
"heapUsedBytes": 108814660,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 88.81299999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 448.5490000000141,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.9459999999999997,
"layouts": 10,
"layoutDurationMs": 2.06,
"taskDurationMs": 290.76800000000003,
"heapDeltaBytes": 3760164,
"heapUsedBytes": 104231108,
"domNodes": 0,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 102.94300000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.874999999989,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.033,
"layouts": 12,
"layoutDurationMs": 2.321,
"taskDurationMs": 422.72999999999996,
"heapDeltaBytes": -14014924,
"heapUsedBytes": 91935732,
"domNodes": -204,
"jsHeapTotalBytes": 2002944,
"scriptDurationMs": 6.569999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.6929999999938,
"styleRecalcs": 11,
"styleRecalcDurationMs": 1.9919999999999998,
"layouts": 11,
"layoutDurationMs": 2.1510000000000002,
"taskDurationMs": 423.303,
"heapDeltaBytes": -8198748,
"heapUsedBytes": 97577844,
"domNodes": -198,
"jsHeapTotalBytes": 2527232,
"scriptDurationMs": 7.939000000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.7840000000074,
"styleRecalcs": 75,
"styleRecalcDurationMs": 9.143,
"layouts": 11,
"layoutDurationMs": 1.752,
"taskDurationMs": 538.387,
"heapDeltaBytes": -6478464,
"heapUsedBytes": 94440320,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 64.621,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.9859999999758,
"styleRecalcs": 75,
"styleRecalcDurationMs": 10.667,
"layouts": 10,
"layoutDurationMs": 1.7830000000000001,
"taskDurationMs": 601.742,
"heapDeltaBytes": 20862976,
"heapUsedBytes": 113531820,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 73.15999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 870.474999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.404000000000003,
"layouts": 5,
"layoutDurationMs": 9.456000000000001,
"taskDurationMs": 675.114,
"heapDeltaBytes": 16204288,
"heapUsedBytes": 137330832,
"domNodes": 15950,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 17.640000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 96,
"frameDurationMs": 20.075000000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8152.506000000017,
"styleRecalcs": 251,
"styleRecalcDurationMs": 18.631999999999998,
"layouts": 10,
"layoutDurationMs": 1.7129999999999999,
"taskDurationMs": 3273.2760000000003,
"heapDeltaBytes": 5884680,
"heapUsedBytes": 108006088,
"domNodes": -296,
"jsHeapTotalBytes": 131072,
"scriptDurationMs": 1610.074,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8206.28800000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.747,
"layouts": 8,
"layoutDurationMs": 1.398,
"taskDurationMs": 4159.619,
"heapDeltaBytes": 3317204,
"heapUsedBytes": 105091392,
"domNodes": -276,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 1813.745,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12778.859000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11908.06,
"heapDeltaBytes": -21744464,
"heapUsedBytes": 279251492,
"domNodes": -3337,
"jsHeapTotalBytes": 24104960,
"scriptDurationMs": 152.62699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.491919191919195,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 11896.44499999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10808.348,
"heapDeltaBytes": -20951904,
"heapUsedBytes": 285289224,
"domNodes": -3337,
"jsHeapTotalBytes": 25415680,
"scriptDurationMs": 181.255,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.99932773109244,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 17634.97100000001,
"styleRecalcs": 144,
"styleRecalcDurationMs": 16.787999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17162.454999999998,
"heapDeltaBytes": -3724744,
"heapUsedBytes": 308824772,
"domNodes": -3337,
"jsHeapTotalBytes": 16695296,
"scriptDurationMs": 671.5540000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.572808586762076,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "vue-large-graph-pan",
"durationMs": 18418.74999999993,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.320000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17975.79,
"heapDeltaBytes": -8604620,
"heapUsedBytes": 302260732,
"domNodes": -3337,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 756.759,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.915535714285724,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5191.859999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 45.34199999999999,
"layouts": 20,
"layoutDurationMs": 21.088999999999995,
"taskDurationMs": 5052.696,
"heapDeltaBytes": -18840328,
"heapUsedBytes": 285997632,
"domNodes": -3337,
"jsHeapTotalBytes": 26464256,
"scriptDurationMs": 78.611,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.056647398843925,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 5207.0059999999785,
"styleRecalcs": 20,
"styleRecalcDurationMs": 42.991999999999976,
"layouts": 20,
"layoutDurationMs": 22.025000000000002,
"taskDurationMs": 5070.9929999999995,
"heapDeltaBytes": -19722356,
"heapUsedBytes": 280745528,
"domNodes": -3337,
"jsHeapTotalBytes": 26202112,
"scriptDurationMs": 68.435,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.888333333333332,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7368.923999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7056.853999999999,
"heapDeltaBytes": 10260928,
"heapUsedBytes": 288195352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 80.43299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.8026936026936,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7441.253999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7049.280000000002,
"heapDeltaBytes": 2568756,
"heapUsedBytes": 275333436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 91.27200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.94295302013423,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 462.9669999999919,
"styleRecalcs": 20,
"styleRecalcDurationMs": 7.579,
"layouts": 11,
"layoutDurationMs": 2.6879999999999997,
"taskDurationMs": 122.05999999999999,
"heapDeltaBytes": -8485188,
"heapUsedBytes": 92563720,
"domNodes": 126,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 11.125,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 94.43799999996827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.106000000000001,
"layouts": 7,
"layoutDurationMs": 1.806,
"taskDurationMs": 55.30099999999999,
"heapDeltaBytes": 4654548,
"heapUsedBytes": 106586024,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.201,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 240.37799999996423,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.723,
"layouts": 76,
"layoutDurationMs": 11.084999999999999,
"taskDurationMs": 201.054,
"heapDeltaBytes": 9784352,
"heapUsedBytes": 97255504,
"domNodes": 4,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 84.62,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.673333333333357,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 242.42400000002817,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.608,
"layouts": 76,
"layoutDurationMs": 10.918000000000001,
"taskDurationMs": 203.186,
"heapDeltaBytes": 9823380,
"heapUsedBytes": 96853000,
"domNodes": 4,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 87.112,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 289.26799999999275,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.488,
"layouts": 76,
"layoutDurationMs": 11.197000000000001,
"taskDurationMs": 236.76799999999997,
"heapDeltaBytes": -6541968,
"heapUsedBytes": 103639120,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.16199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 275.5100000000539,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.459,
"layouts": 76,
"layoutDurationMs": 10.947000000000001,
"taskDurationMs": 242.18900000000002,
"heapDeltaBytes": -6515552,
"heapUsedBytes": 109577864,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 82.092,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 63.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2949 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5912f1dd0bd54e8e342455b9b0aa465e579c3ad5
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.58 #21409 +/- ##
==========================================
Coverage 87.03% 87.04%
==========================================
Files 2726 2726
Lines 151413 151434 +21
Branches 39154 39165 +11
==========================================
+ Hits 131788 131815 +27
+ Misses 19235 19229 -6
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. This backport matches the merged PR's added and removed lines and changes the same five files. All 133 checks settled without failure, and there are no review threads.
Full context for agent readers
No package manifest changed, so there is no export surface to reconcile. The reviewed commit is 4c64deae8a33e6653eb054cd0571fb0aa9b68c58 on core/1.58.
Why
Backport of #21395 to
core/1.58(git cherry-pick -x 0b0ffbe9ca6257c560c02cf65c4b8862c62439ae): after the hosted checkout opens, the workspace Add credits dialog shows a "Checkout opened in a new tab" hand-off with Close / Reopen checkout instead of closing at once.How
core/1.58as [backport core/1.58] FE-1908 fix(billing): open blocked checkout and card pages from a real link #21393.core/1.58yet. With it merged the cherry-pick applies cleanly, and every hunk is identical to the original (only line offsets differ). No adaptation or extra main-only code.pnpm exec vitest run src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts(98 passed);oxlint --type-aware,oxfmt --checkandeslinton the touched files clean.AS IS / TO BE
Same behaviour change as #21395; see its screenshots.