Skip to content

[backport cloud/1.58] FE-1908 fix(billing): open blocked checkout and card pages from a real link - #21394

Merged
comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21388-to-cloud-1.58
Oct 20, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.58from
backport-21388-to-cloud-1.58

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #21388 to cloud/1.58

Automatically created by backport workflow.

…l link (#21388)

## Summary

**Why:** people who block pop-ups get stuck in the workspace Add credits
dialog. When the hosted-checkout tab (no default card) or the "Set a
default card" portal tab is blocked, the retry is another `window.open`,
which the blocker refuses too. For the portal, the dialog only showed a
toast asking the user to allow pop-ups and try again.

**Root cause:** both retries are scripted opens, and pop-up blockers
refuse those. A clicked link is a navigation, not a pop-up, so blockers
allow it.

**How:**
- "Checkout didn't open": "Open checkout" is now `Button as="a"` with
`target="_blank"` and `rel="noopener"`. Its `href` is the checkout URL
of the session created when the screen appeared. Clicking it starts the
same pending top-up and balance watch as a successful open, then closes
the dialog. It creates no new session and calls no `window.open`.
- "Set a default card": when the reserved tab is blocked, the dialog
still creates the portal session (`payment_method_update`). It then
shows a new "Payment page didn't open" screen whose "Open payment page"
button links to that portal URL. Following the link goes back to Confirm
and registers the same refresh-on-return as a successful open. A failed
or empty portal response shows the existing "Couldn't open card
settings" toast.
- New strings: `defaultCardBlockedTitle`, `defaultCardBlockedBody`,
`openPaymentPage`. The old "Allow pop-ups and try again" toast is no
longer used here.
- No new client-derived facts. The links only reuse URLs the server
returned.

**Feature flag / routing:** no new flag. The dialog is
`TopUpCreditsDialogContentWorkspace`, which `useBillingDialogs` picks
when `useBillingRouting().type` is not `legacy`. Personal workspaces on
the legacy billing rail still get the legacy dialog unless
`legacyBillingMigrationEnabled` is on. The dialog also requires
`canTopUp`. The no-default-card path is reached on a `NO_PAYMENT_METHOD`
top-up refusal.

**Overlap:** PR #21366
also turns the blocked checkout into a link, as part of a larger rework,
and removes "Set a default card". This PR is the small fix for main and
the 1.58 branches. Whichever PR lands second resolves the conflict.

Decision:
https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1792446469557019?thread_ts=1792446135.151939

## AS IS / TO BE

| Screen | AS IS (main) | TO BE (this PR) |
| --- | --- | --- |
| Checkout didn't open | <img
src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/as-is-checkout-blocked.png"
width="360"> | <img
src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/to-be-checkout-blocked.png?v=2"
width="360"> |
| Set a default card, tab blocked | <img
src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/as-is-default-card-blocked.png"
width="360"> | <img
src="https://gist.githubusercontent.com/dante01yoon/ac41345acd89867b2aed3b273b5f7ef3/raw/to-be-default-card-blocked.png?v=2"
width="360"> |

Captured on testcloud in a team workspace on workspace billing routing
with `canTopUp`. Pop-ups were blocked, and the top-up
(`NO_PAYMENT_METHOD`), checkout and portal requests were mocked.

## Verification

- `pnpm exec vitest run
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`:
90 passed. One table-driven test covers both blocked screens and checks
that each renders a link with the session URL, `target="_blank"` and
`rel="noopener"`, and that clicking it makes no second session request
and no second `window.open`. Other tests cover the checkout follow-up
(pending top-up and dialog close), the portal follow-up (back to Pay
once a default card exists on return), and portal failures while
blocked.
- `oxlint --type-aware`, `oxfmt` and `eslint` pass on the touched files,
and the pre-commit typecheck passes.
- No Playwright spec covers these blocked screens, so no E2E changes.
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 19, 2026
@comfy-pr-bot
comfy-pr-bot requested review from a team and dante01yoon as code owners October 19, 2026 23:06
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Oct 19, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) October 19, 2026 23:06
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 6 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.9 MB heap
dom-widget-order-dense-n200-w200-i120: · 34.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 393ms TBT · 97.3 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 46.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 111ms TBT · 92.5 MB heap
extension-clean-combined-draw: · 41.1 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 80ms TBT · 153.4 MB heap
extension-rgthree-prototype-draw: · 40.6 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 53ms TBT · 133.2 MB heap
large-combo-open: · 46.7 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 112.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
legacy-node-drag: · 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 118.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 95.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 90.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.0 MB heap
subgraph-transition-enter: · 50.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 109ms TBT · 126.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.5 MB heap
vue-large-graph-idle: · 57.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 270.9 MB heap
vue-large-graph-pan: · 47.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 67ms TBT · 281.3 MB heap
vue-node-resize-workload: · 39.9 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 262.0 MB heap
vue-zoom-out-idle: · 48.9 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 0ms TBT · 268.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.3 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.8 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 104.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 2ms
canvas-idle: style recalc duration 2ms
canvas-idle: layout count 11
canvas-idle: style recalc count 11
canvas-idle: task duration 413ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 87.2 MB
canvas-idle: DOM nodes -200
canvas-idle: event listeners -130
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 2ms
canvas-mouse-sweep: style recalc duration 8ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 71
canvas-mouse-sweep: task duration 580ms
canvas-mouse-sweep: script duration 104ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 86.5 MB
canvas-mouse-sweep: DOM nodes -200
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 4ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 309ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 101.1 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 2ms
dom-widget-clipping: style recalc duration 2ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 374ms
dom-widget-clipping: script duration 126ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 105.9 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 29ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 717ms
dom-widget-order-dense-n200-w200-i120: script duration 45ms
dom-widget-order-dense-n200-w200-i120: TBT 393ms
dom-widget-order-dense-n200-w200-i120: heap used 97.3 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -210
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 22ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 325ms
dom-widget-order-sparse-n1000-w20-i120: script duration 92ms
dom-widget-order-sparse-n1000-w20-i120: TBT 111ms
dom-widget-order-sparse-n1000-w20-i120: heap used 92.5 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 24ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 1ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 4
extension-clean-combined-draw: style recalc count 4
extension-clean-combined-draw: task duration 5782ms
extension-clean-combined-draw: script duration 4535ms
extension-clean-combined-draw: TBT 80ms
extension-clean-combined-draw: heap used 153.4 MB
extension-clean-combined-draw: DOM nodes -276
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 25ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 3
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 5644ms
extension-rgthree-prototype-draw: script duration 4428ms
extension-rgthree-prototype-draw: TBT 53ms
extension-rgthree-prototype-draw: heap used 133.2 MB
extension-rgthree-prototype-draw: DOM nodes -286
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 21ms
large-combo-open: p95 frame time 42ms
large-combo-open: layout duration 2ms
large-combo-open: style recalc duration 10ms
large-combo-open: layout count 12
large-combo-open: style recalc count 21
large-combo-open: task duration 103ms
large-combo-open: script duration 6ms
large-combo-open: TBT 0ms
large-combo-open: heap used 112.4 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 1ms
large-graph-idle: style recalc duration 1ms
large-graph-idle: layout count 8
large-graph-idle: style recalc count 9
large-graph-idle: task duration 506ms
large-graph-idle: script duration 23ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 99.2 MB
large-graph-idle: DOM nodes -286
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 1ms
large-graph-pan: style recalc duration 5ms
large-graph-pan: layout count 8
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1210ms
large-graph-pan: script duration 543ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 96.9 MB
large-graph-pan: DOM nodes -296
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 6ms
large-graph-zoom: layout count 66
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1215ms
large-graph-zoom: script duration 522ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 85.4 MB
large-graph-zoom: DOM nodes -126
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 3ms
legacy-node-drag: layout count 7
legacy-node-drag: style recalc count 48
legacy-node-drag: task duration 1358ms
legacy-node-drag: script duration 609ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 118.1 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 1ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 8
minimap-idle: style recalc count 9
minimap-idle: task duration 431ms
minimap-idle: script duration 22ms
minimap-idle: TBT 0ms
minimap-idle: heap used 105.4 MB
minimap-idle: DOM nodes -138
minimap-idle: event listeners -65
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 2ms
subgraph-dom-widget-clipping: style recalc duration 4ms
subgraph-dom-widget-clipping: layout count 10
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 301ms
subgraph-dom-widget-clipping: script duration 98ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 95.5 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 2ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 418ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 90.3 MB
subgraph-idle: DOM nodes -208
subgraph-idle: event listeners -176
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 2ms
subgraph-mouse-sweep: style recalc duration 9ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 565ms
subgraph-mouse-sweep: script duration 68ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 94.0 MB
subgraph-mouse-sweep: DOM nodes -105
subgraph-mouse-sweep: event listeners -84
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 18ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 752ms
subgraph-transition-enter: script duration 19ms
subgraph-transition-enter: TBT 109ms
subgraph-transition-enter: heap used 126.5 MB
subgraph-transition-enter: DOM nodes 15950
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 15ms
viewport-pan-sweep: layout count 9
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 3912ms
viewport-pan-sweep: script duration 1815ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 99.5 MB
viewport-pan-sweep: DOM nodes -296
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 8614ms
vue-large-graph-idle: script duration 107ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 270.9 MB
vue-large-graph-idle: DOM nodes -1822
vue-large-graph-idle: event listeners -330
vue-large-graph-pan: avg frame time 21ms
vue-large-graph-pan: p95 frame time 50ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 9ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 66
vue-large-graph-pan: task duration 11469ms
vue-large-graph-pan: script duration 606ms
vue-large-graph-pan: TBT 67ms
vue-large-graph-pan: heap used 281.3 MB
vue-large-graph-pan: DOM nodes -3337
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 25ms
vue-node-resize-workload: p95 frame time 42ms
vue-node-resize-workload: layout duration 17ms
vue-node-resize-workload: style recalc duration 51ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4144ms
vue-node-resize-workload: script duration 68ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 262.0 MB
vue-node-resize-workload: DOM nodes -3339
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 20ms
vue-zoom-out-idle: p95 frame time 25ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5445ms
vue-zoom-out-idle: script duration 60ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 268.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 6ms
workflow-execution: layout count 9
workflow-execution: style recalc count 15
workflow-execution: task duration 76ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 93.3 MB
workflow-execution: DOM nodes 110
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 12ms
agent-composer-empty-conversation-typing: style recalc duration 0ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 209ms
agent-composer-empty-conversation-typing: script duration 91ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 93.8 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 12ms
agent-composer-long-conversation-typing: style recalc duration 1ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 259ms
agent-composer-long-conversation-typing: script duration 94ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 104.3 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 292
Raw data
{
  "timestamp": "2026-10-19T23:16:29.184Z",
  "gitSha": "cc643dea8b5d2f56db9e551156fb24a88df03392",
  "branch": "backport-21388-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2008.8059999999928,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 1.8410000000000002,
      "layouts": 10,
      "layoutDurationMs": 1.9849999999999999,
      "taskDurationMs": 467.873,
      "heapDeltaBytes": -10689036,
      "heapUsedBytes": 88621256,
      "domNodes": -200,
      "jsHeapTotalBytes": 6983680,
      "scriptDurationMs": 6.924999999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2010.787999999991,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 1.9510000000000005,
      "layouts": 11,
      "layoutDurationMs": 1.9839999999999995,
      "taskDurationMs": 357.817,
      "heapDeltaBytes": -5231700,
      "heapUsedBytes": 94167156,
      "domNodes": -200,
      "jsHeapTotalBytes": 6983680,
      "scriptDurationMs": 6.852,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1679.8510000000135,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 8.182,
      "layouts": 10,
      "layoutDurationMs": 1.7020000000000002,
      "taskDurationMs": 581.115,
      "heapDeltaBytes": -13615948,
      "heapUsedBytes": 90567064,
      "domNodes": -200,
      "jsHeapTotalBytes": 3313664,
      "scriptDurationMs": 103.647,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1695.9099999999694,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 8.112000000000002,
      "layouts": 10,
      "layoutDurationMs": 1.71,
      "taskDurationMs": 579.8220000000001,
      "heapDeltaBytes": -13383820,
      "heapUsedBytes": 90937796,
      "domNodes": -200,
      "jsHeapTotalBytes": 2527232,
      "scriptDurationMs": 104.116,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665686274509806,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1712.8079999999954,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.5160000000000005,
      "layouts": 12,
      "layoutDurationMs": 2.035,
      "taskDurationMs": 236.84299999999996,
      "heapDeltaBytes": 1796664,
      "heapUsedBytes": 105973596,
      "domNodes": 47,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 7.646999999999999,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1807.4660000000335,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 3.8120000000000003,
      "layouts": 12,
      "layoutDurationMs": 2.058,
      "taskDurationMs": 380.745,
      "heapDeltaBytes": 1808512,
      "heapUsedBytes": 105962848,
      "domNodes": 47,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 7.981,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66605504587156,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 533.3799999999655,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 1.5520000000000005,
      "layouts": 10,
      "layoutDurationMs": 1.6660000000000001,
      "taskDurationMs": 354.991,
      "heapDeltaBytes": 6821852,
      "heapUsedBytes": 111015016,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 116.648,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 532.2130000000129,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 1.8129999999999995,
      "layouts": 10,
      "layoutDurationMs": 1.8030000000000002,
      "taskDurationMs": 392.37100000000004,
      "heapDeltaBytes": 6906536,
      "heapUsedBytes": 111065044,
      "domNodes": 0,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 134.62199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1053.3350000000041,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 710.1359999999999,
      "heapDeltaBytes": -7925336,
      "heapUsedBytes": 102150736,
      "domNodes": -210,
      "jsHeapTotalBytes": 9613312,
      "scriptDurationMs": 40.868,
      "eventListeners": -168,
      "totalBlockingTimeMs": 384,
      "frameDurationMs": 29.166666666666654,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1071.3840000000232,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 724.514,
      "heapDeltaBytes": -18318028,
      "heapUsedBytes": 101939816,
      "domNodes": -210,
      "jsHeapTotalBytes": 15446016,
      "scriptDurationMs": 48.208999999999996,
      "eventListeners": -168,
      "totalBlockingTimeMs": 401,
      "frameDurationMs": 29.627777777777787,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 715.2769999999862,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 320.40799999999956,
      "heapDeltaBytes": -2847088,
      "heapUsedBytes": 97316020,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 90.17900000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 107,
      "frameDurationMs": 21.715151515151497,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 731.8880000000263,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.29999999999984,
      "heapDeltaBytes": -3966500,
      "heapUsedBytes": 96603256,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 94.31599999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 114,
      "frameDurationMs": 21.570588235294135,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6959.43299999999,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.7140000000000002,
      "layouts": 4,
      "layoutDurationMs": 0.704,
      "taskDurationMs": 6031.1050000000005,
      "heapDeltaBytes": 391448,
      "heapUsedBytes": 123702424,
      "domNodes": -276,
      "jsHeapTotalBytes": 17272832,
      "scriptDurationMs": 4755.356,
      "eventListeners": -130,
      "totalBlockingTimeMs": 86,
      "frameDurationMs": 24.470774647887325,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6429.748000000018,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.5580000000000004,
      "layouts": 3,
      "layoutDurationMs": 0.543,
      "taskDurationMs": 5532.199,
      "heapDeltaBytes": 74432468,
      "heapUsedBytes": 197938848,
      "domNodes": -276,
      "jsHeapTotalBytes": 92770304,
      "scriptDurationMs": 4315.625000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 74,
      "frameDurationMs": 24.18458646616541,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6231.738000000007,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.48800000000000016,
      "layouts": 3,
      "layoutDurationMs": 0.4919999999999998,
      "taskDurationMs": 5254.984,
      "heapDeltaBytes": 9266488,
      "heapUsedBytes": 131280472,
      "domNodes": -276,
      "jsHeapTotalBytes": 21663744,
      "scriptDurationMs": 4146.784000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 24.443529411764708,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6644.763000000012,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.4699999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.4689999999999998,
      "taskDurationMs": 6033.711,
      "heapDeltaBytes": 23256088,
      "heapUsedBytes": 147991812,
      "domNodes": -296,
      "jsHeapTotalBytes": 39817216,
      "scriptDurationMs": 4709.329000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 24.843071161048687,
      "p95FrameDurationMs": 33.40000000000009
    },
    {
      "name": "large-combo-open",
      "durationMs": 150.58000000001925,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 10.241,
      "layouts": 12,
      "layoutDurationMs": 2.464,
      "taskDurationMs": 96.27100000000002,
      "heapDeltaBytes": 13161104,
      "heapUsedBytes": 117658640,
      "domNodes": 917,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.6579999999999995,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.428571428571427,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "large-combo-open",
      "durationMs": 145.21500000000742,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 10.036,
      "layouts": 11,
      "layoutDurationMs": 2.2359999999999998,
      "taskDurationMs": 108.794,
      "heapDeltaBytes": 13169892,
      "heapUsedBytes": 118070176,
      "domNodes": 917,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.0920000000000005,
      "eventListeners": 196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.428571428571427,
      "p95FrameDurationMs": 50.09999999999991
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.1639999999848,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.555,
      "layouts": 8,
      "layoutDurationMs": 1.508,
      "taskDurationMs": 501.089,
      "heapDeltaBytes": 641924,
      "heapUsedBytes": 102195108,
      "domNodes": -296,
      "jsHeapTotalBytes": -4907008,
      "scriptDurationMs": 20.407,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.6960000000058,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.3709999999999998,
      "layouts": 8,
      "layoutDurationMs": 1.479,
      "taskDurationMs": 511.595,
      "heapDeltaBytes": 4045164,
      "heapUsedBytes": 105794980,
      "domNodes": -276,
      "jsHeapTotalBytes": -5599232,
      "scriptDurationMs": 24.861999999999995,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2194.8259999999777,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 4.825000000000001,
      "layouts": 8,
      "layoutDurationMs": 1.348,
      "taskDurationMs": 1201.1940000000002,
      "heapDeltaBytes": 1247972,
      "heapUsedBytes": 104209684,
      "domNodes": -296,
      "jsHeapTotalBytes": -1179648,
      "scriptDurationMs": 535.014,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66564885496183,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2179.46900000004,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 4.763,
      "layouts": 8,
      "layoutDurationMs": 1.2590000000000001,
      "taskDurationMs": 1218.3600000000001,
      "heapDeltaBytes": -2227496,
      "heapUsedBytes": 99050028,
      "domNodes": -296,
      "jsHeapTotalBytes": -1441792,
      "scriptDurationMs": 551.4389999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665648854961834,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3180.250000000001,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 6.025,
      "layouts": 66,
      "layoutDurationMs": 7.553999999999999,
      "taskDurationMs": 1291.02,
      "heapDeltaBytes": -16193216,
      "heapUsedBytes": 91148660,
      "domNodes": -276,
      "jsHeapTotalBytes": 17141760,
      "scriptDurationMs": 525.668,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665968586387436,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3126.4300000000276,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 6.229,
      "layouts": 66,
      "layoutDurationMs": 7.622999999999999,
      "taskDurationMs": 1138.692,
      "heapDeltaBytes": -16990612,
      "heapUsedBytes": 87868668,
      "domNodes": 24,
      "jsHeapTotalBytes": -1536000,
      "scriptDurationMs": 517.826,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665957446808513,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2225.1399999999535,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 3.2920000000000003,
      "layouts": 7,
      "layoutDurationMs": 1.2239999999999998,
      "taskDurationMs": 1355.303,
      "heapDeltaBytes": 17332400,
      "heapUsedBytes": 123588552,
      "domNodes": 0,
      "jsHeapTotalBytes": 6189056,
      "scriptDurationMs": 609.414,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.79242424242424,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2286.820999999975,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 3.1270000000000002,
      "layouts": 7,
      "layoutDurationMs": 1.1239999999999999,
      "taskDurationMs": 1360.366,
      "heapDeltaBytes": 17837764,
      "heapUsedBytes": 124186536,
      "domNodes": 0,
      "jsHeapTotalBytes": 6189056,
      "scriptDurationMs": 608.863,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665693430656937,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.1729999999998,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 1.4370000000000003,
      "layouts": 8,
      "layoutDurationMs": 1.4169999999999998,
      "taskDurationMs": 466.0199999999999,
      "heapDeltaBytes": -8676044,
      "heapUsedBytes": 108294412,
      "domNodes": 0,
      "jsHeapTotalBytes": 4755456,
      "scriptDurationMs": 22.363,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.893000000001,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 1.5250000000000004,
      "layouts": 8,
      "layoutDurationMs": 1.4440000000000002,
      "taskDurationMs": 396.234,
      "heapDeltaBytes": 9274824,
      "heapUsedBytes": 112708564,
      "domNodes": -276,
      "jsHeapTotalBytes": -5074944,
      "scriptDurationMs": 20.845999999999997,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 448.7230000000295,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 3.3800000000000003,
      "layouts": 9,
      "layoutDurationMs": 1.4860000000000002,
      "taskDurationMs": 279.31,
      "heapDeltaBytes": 2675380,
      "heapUsedBytes": 108839156,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 97.235,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 512.203999999997,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 3.794,
      "layouts": 10,
      "layoutDurationMs": 1.678,
      "taskDurationMs": 322.264,
      "heapDeltaBytes": -1576776,
      "heapUsedBytes": 91416840,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 99.47500000000001,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664516129032254,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.819999999981,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.991,
      "layouts": 10,
      "layoutDurationMs": 1.869,
      "taskDurationMs": 480.4560000000001,
      "heapDeltaBytes": -17758152,
      "heapUsedBytes": 88380588,
      "domNodes": -218,
      "jsHeapTotalBytes": 2265088,
      "scriptDurationMs": 6.4639999999999995,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.4330000000014,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 1.7810000000000004,
      "layouts": 10,
      "layoutDurationMs": 1.943,
      "taskDurationMs": 356.047,
      "heapDeltaBytes": -4821412,
      "heapUsedBytes": 101012292,
      "domNodes": -198,
      "jsHeapTotalBytes": 1740800,
      "scriptDurationMs": 6.417999999999998,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.5149999999671,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 8.746,
      "layouts": 11,
      "layoutDurationMs": 1.922,
      "taskDurationMs": 543.8860000000001,
      "heapDeltaBytes": -10836300,
      "heapUsedBytes": 89773828,
      "domNodes": -210,
      "jsHeapTotalBytes": 8294400,
      "scriptDurationMs": 66.775,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665686274509806,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1676.1589999999842,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 8.733999999999998,
      "layouts": 9,
      "layoutDurationMs": 1.475,
      "taskDurationMs": 585.5369999999999,
      "heapDeltaBytes": 15428612,
      "heapUsedBytes": 107430256,
      "domNodes": 0,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 69.608,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 900.5900000000224,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 18.064999999999998,
      "layouts": 5,
      "layoutDurationMs": 10.374999999999998,
      "taskDurationMs": 752.1089999999999,
      "heapDeltaBytes": 11569084,
      "heapUsedBytes": 132687888,
      "domNodes": 15950,
      "jsHeapTotalBytes": 16654336,
      "scriptDurationMs": 18.733,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 109,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8171.131000000003,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 15.394,
      "layouts": 9,
      "layoutDurationMs": 1.5819999999999999,
      "taskDurationMs": 3622.38,
      "heapDeltaBytes": 6895436,
      "heapUsedBytes": 107619072,
      "domNodes": -296,
      "jsHeapTotalBytes": -917504,
      "scriptDurationMs": 1806.495,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666122448979593,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8224.779000000013,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 15.214,
      "layouts": 9,
      "layoutDurationMs": 1.4519999999999997,
      "taskDurationMs": 4202.577,
      "heapDeltaBytes": -11224744,
      "heapUsedBytes": 100965300,
      "domNodes": -296,
      "jsHeapTotalBytes": -589824,
      "scriptDurationMs": 1823.41,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665922920892495,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10083.236999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8658.073000000002,
      "heapDeltaBytes": -22734304,
      "heapUsedBytes": 287122884,
      "domNodes": -307,
      "jsHeapTotalBytes": 31707136,
      "scriptDurationMs": 107.768,
      "eventListeners": -7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.474696707105718,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10011.272999999961,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8570.880000000001,
      "heapDeltaBytes": -43138620,
      "heapUsedBytes": 280960704,
      "domNodes": -3337,
      "jsHeapTotalBytes": 25153536,
      "scriptDurationMs": 105.70600000000002,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.180789022298455,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12512.479999999981,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 8.536000000000016,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11520.586000000001,
      "heapDeltaBytes": -11912732,
      "heapUsedBytes": 297289936,
      "domNodes": -3337,
      "jsHeapTotalBytes": 23056384,
      "scriptDurationMs": 538.886,
      "eventListeners": -651,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.965159128978225,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 12379.654999999957,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 8.836000000000011,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11417.339,
      "heapDeltaBytes": -11933160,
      "heapUsedBytes": 292709416,
      "domNodes": -3337,
      "jsHeapTotalBytes": 19910656,
      "scriptDurationMs": 673.8100000000001,
      "eventListeners": -651,
      "totalBlockingTimeMs": 134,
      "frameDurationMs": 20.90978077571669,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5087.091999999984,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 57.73999999999999,
      "layouts": 20,
      "layoutDurationMs": 16.916,
      "taskDurationMs": 4921.134999999999,
      "heapDeltaBytes": -48162736,
      "heapUsedBytes": 271318868,
      "domNodes": -3337,
      "jsHeapTotalBytes": 19124224,
      "scriptDurationMs": 83.698,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.213218390804595,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3557.837999999947,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 44.18599999999998,
      "layouts": 20,
      "layoutDurationMs": 16.153000000000002,
      "taskDurationMs": 3366.2050000000004,
      "heapDeltaBytes": -31042880,
      "heapUsedBytes": 278139832,
      "domNodes": -3341,
      "jsHeapTotalBytes": 27774976,
      "scriptDurationMs": 53.268,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.856725146198826,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7124.001000000021,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6542.968999999999,
      "heapDeltaBytes": -23166948,
      "heapUsedBytes": 279061204,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 66.38199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.936577181208047,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5108.574999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4347.45,
      "heapDeltaBytes": -22863852,
      "heapUsedBytes": 283780712,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 52.80299999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.942857142857147,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 447.9140000000257,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 7.16,
      "layouts": 12,
      "layoutDurationMs": 2.536,
      "taskDurationMs": 98.86399999999999,
      "heapDeltaBytes": -12347540,
      "heapUsedBytes": 89470812,
      "domNodes": 126,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.209,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670370370370385,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 89.00100000005295,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.829999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.3639999999999997,
      "taskDurationMs": 52.827,
      "heapDeltaBytes": 4639364,
      "heapUsedBytes": 106114744,
      "domNodes": 94,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.450000000000001,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 249.40000000003693,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.532,
      "layouts": 76,
      "layoutDurationMs": 12.002,
      "taskDurationMs": 205.429,
      "heapDeltaBytes": 9760812,
      "heapUsedBytes": 98873236,
      "domNodes": 4,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 88.86099999999999,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 247.1979999999121,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.439,
      "layouts": 76,
      "layoutDurationMs": 12.561,
      "taskDurationMs": 211.985,
      "heapDeltaBytes": 9663992,
      "heapUsedBytes": 97904908,
      "domNodes": 4,
      "jsHeapTotalBytes": 9175040,
      "scriptDurationMs": 93.691,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000007,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 312.8800000000638,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.3639999999999999,
      "layouts": 76,
      "layoutDurationMs": 11.648,
      "taskDurationMs": 264.678,
      "heapDeltaBytes": -6194252,
      "heapUsedBytes": 109132628,
      "domNodes": 4,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 96.563,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663157894736813,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 294.0929999999753,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.3259999999999998,
      "layouts": 76,
      "layoutDurationMs": 11.911,
      "taskDurationMs": 253.031,
      "heapDeltaBytes": -6298612,
      "heapUsedBytes": 109525656,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 90.449,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.0%

Coverage totals
Metric Covered Total Pct
Lines 56865 88891 64.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.5% 1166
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.0% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 46.6% 252
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 0.8% 240
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2951 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2272 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 650 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/19/2026, 11:08:17 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2a9b5574c1761003744a4d546b915aa7e998e094

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (111)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 61 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 19, 2026
@codecov

codecov Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff               @@
##           cloud/1.58   #21394      +/-   ##
==============================================
- Coverage       87.64%   87.04%   -0.61%     
==============================================
  Files            2808     2726      -82     
  Lines          153435   151400    -2035     
  Branches        40260    41268    +1008     
==============================================
- Hits           134481   131779    -2702     
- Misses          18406    19231     +825     
+ Partials          548      390     -158     
Flag Coverage Δ
billing-web-unit ?
e2e 64.08% <0.00%> (+0.08%) ⬆️
unit 85.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../components/TopUpCreditsDialogContentWorkspace.vue 94.68% <100.00%> (+0.16%) ⬆️

... and 167 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clean backport.

@comfy-pr-bot
comfy-pr-bot merged commit d872cd5 into cloud/1.58 Oct 20, 2026
146 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-21388-to-cloud-1.58 branch October 20, 2026 01:28
comfy-pr-bot pushed a commit that referenced this pull request Oct 20, 2026
…kout instead of closing the dialog (#21410)

## Why

Backport of #21395 to
`cloud/1.58` (`git cherry-pick -x
0b0ffbe`): after the hosted checkout
opens, the workspace Add credits dialog shows a "Checkout opened in a
new tab" hand-off with Close / Reopen checkout instead of closing at
once.

## How

- Builds on the PR 21388 backport, already merged to `cloud/1.58` as
#21394.
- Conflicts: none. The auto-backport failed only because 21388 had not
landed on `cloud/1.58` yet. With it merged the cherry-pick applies
cleanly, and every hunk is identical to the original (only line offsets
differ). No adaptation or extra main-only code.
- Tests: `pnpm exec vitest run
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts`
(98 passed); `oxlint --type-aware`, `oxfmt --check` and `eslint` on the
touched files clean.

## AS IS / TO BE

Same behaviour change as
#21395; see its
screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants