Repository navigation
[backport cloud/1.58] fix: guard touch handlers against a missing canvas and report why - #22279
Conversation
…1321) <!-- claude-slack-attribution --> _Requested via [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1792317627366019?thread_ts=1792317627.366019&cid=C09KFK2ABB8)_ **Before:** If `app.canvas` was never assigned, every click on the canvas threw `TypeError: Cannot read properties of undefined (reading 'pointer')` from the touch-support `processMouseDown` wrapper, and the two-finger touch handlers threw the same way. One production RUM session shows how that state arises: a browser userscript patches `CanvasRenderingContext2D.drawImage` and throws. The throw happens in the first synchronous frame inside `new LGraphCanvas(...)` (`startRendering` -> `renderFrame` -> `draw` -> `drawFrontCanvas`), so `ComfyApp.setup()` aborts before `app.canvas` is assigned. Event listeners were already bound by then, so each click hit the wrapper with no canvas. The app stayed unusable for the whole session. **After:** The wrapper uses the canvas it is called on (`this.pointer`) instead of the global, and the touch handlers read `app.canvasOrUndefined` once and skip the gesture when it is missing. A throwing first frame no longer aborts `LGraphCanvas` construction: it is reported and the instance finishes constructing, so `app.canvas` gets assigned. Per-frame behaviour is unchanged. - `simpleTouchSupport.ts`: `this.pointer.isDown = false` in the `processMouseDown` wrapper; `canvasOrReport` guards in the `touchstart` and `touchmove` pinch paths; pinch math moved into `zoomCanvasAroundPinch` unchanged. - `touchCanvasAccess.ts`: when a touch or pointer entry point finds no canvas, report once per entry point per page load (`errorType: error_handling_touch_input_missing_canvas`, level warning) with context: entry point, event type, pointer type, isPrimary, `document.readyState`, startup outcome (`pending`/`completed`/`failed`), whether `window.app` is defined, whether the canvas element exists and is connected, and whether the event target is the canvas element. No URLs, user data or ids. - `bootstrapTracer.ts`: read-only `outcome` getter so the report can say whether startup failed. - `LGraphCanvas.startRendering`: the initial `renderFrame` call is wrapped; on failure it resets `is_rendering`, reports `error_rendering_canvas_initial_frame` and returns instead of throwing out of the constructor. - Root cause is evidenced for one production session (the patched `drawImage` above), not proven for every occurrence. The new telemetry is meant to show whether other sessions share it or have a different cause. - Tests: `pnpm test:unit` on `simpleTouchSupport.test.ts`, `touchCanvasAccess.test.ts`, `LGraphCanvas.startRendering.test.ts`, `bootstrapTracer.test.ts` (30 passing). The new wrapper and construction tests fail against the previous code. - Not covered: a real browser with a userscript patching `drawImage`. - After release: query `@error.type:error_handling_touch_input_missing_canvas` and `@error.type:error_rendering_canvas_initial_frame` in Datadog and group by `bootstrapOutcome` and `entryPoint`. --- _Generated by [Claude Code](https://claude.ai/code/session_01EFm3kPsvMhmwyTUYf8eYuJ)_ (cherry picked from commit 42f00b3)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-29T18:54:28.310Z",
"gitSha": "78c25b7a0c88dd363d78c8b19a4d1bab1fc4a13a",
"branch": "backport-21321-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.8290000000056,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.422999999999999,
"layouts": 10,
"layoutDurationMs": 2.2300000000000004,
"taskDurationMs": 451.306,
"heapDeltaBytes": -3309656,
"heapUsedBytes": 84085392,
"domNodes": -200,
"jsHeapTotalBytes": -2293760,
"scriptDurationMs": 7.488000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.3010000000036,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.519,
"layouts": 11,
"layoutDurationMs": 2.6249999999999996,
"taskDurationMs": 465.3809999999999,
"heapDeltaBytes": -114496,
"heapUsedBytes": 87764196,
"domNodes": -200,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 8.013000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.8969999999927,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.79,
"layouts": 10,
"layoutDurationMs": 2.067,
"taskDurationMs": 734.2220000000001,
"heapDeltaBytes": -23414516,
"heapUsedBytes": 79411668,
"domNodes": -200,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 115.92000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.5250000000224,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.26,
"layouts": 10,
"layoutDurationMs": 2.447,
"taskDurationMs": 676.7030000000001,
"heapDeltaBytes": 18777196,
"heapUsedBytes": 110174684,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 113.261,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.4810000000257,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.32,
"layouts": 12,
"layoutDurationMs": 2.5789999999999997,
"taskDurationMs": 232.632,
"heapDeltaBytes": 21413936,
"heapUsedBytes": 111499720,
"domNodes": 47,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 9.315999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1792.3930000000041,
"styleRecalcs": 19,
"styleRecalcDurationMs": 4.221000000000001,
"layouts": 12,
"layoutDurationMs": 2.5460000000000003,
"taskDurationMs": 371.658,
"heapDeltaBytes": 1917168,
"heapUsedBytes": 99377052,
"domNodes": 47,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.332999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 545.1350000000161,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.9369999999999994,
"layouts": 10,
"layoutDurationMs": 2.524,
"taskDurationMs": 358.684,
"heapDeltaBytes": -1045552,
"heapUsedBytes": 90172652,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 137.81199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 550.6259999999656,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7860000000000005,
"layouts": 9,
"layoutDurationMs": 2.172,
"taskDurationMs": 364.01800000000003,
"heapDeltaBytes": 3530808,
"heapUsedBytes": 92245004,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 137.791,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1038.6100000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 702.0679999999999,
"heapDeltaBytes": -5770008,
"heapUsedBytes": 102325896,
"domNodes": -230,
"jsHeapTotalBytes": 8044544,
"scriptDurationMs": 51.69499999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 367,
"frameDurationMs": 28.702777777777783,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1053.307000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.61,
"heapDeltaBytes": -15446552,
"heapUsedBytes": 102793584,
"domNodes": -231,
"jsHeapTotalBytes": 15355904,
"scriptDurationMs": 48.681000000000004,
"eventListeners": -168,
"totalBlockingTimeMs": 377,
"frameDurationMs": 29.166666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 769.2729999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.55499999999984,
"heapDeltaBytes": -4806944,
"heapUsedBytes": 91465604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.712,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 22.547058823529422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.2309999999675,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.1170000000001,
"heapDeltaBytes": -3289396,
"heapUsedBytes": 97822328,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.32800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 23.038235294117626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7930.566999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7119.007,
"heapDeltaBytes": 38122692,
"heapUsedBytes": 141291736,
"domNodes": -296,
"jsHeapTotalBytes": 29687808,
"scriptDurationMs": 5490.067,
"eventListeners": -130,
"totalBlockingTimeMs": 113,
"frameDurationMs": 24.484567901234566,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7437.08799999996,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5589999999999996,
"layouts": 2,
"layoutDurationMs": 0.46600000000000025,
"taskDurationMs": 6594.491,
"heapDeltaBytes": 28670044,
"heapUsedBytes": 150211300,
"domNodes": -296,
"jsHeapTotalBytes": 35717120,
"scriptDurationMs": 5379.352,
"eventListeners": -130,
"totalBlockingTimeMs": 94,
"frameDurationMs": 24.612582781456954,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7342.075999999992,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.836,
"layouts": 3,
"layoutDurationMs": 0.8309999999999997,
"taskDurationMs": 6585.7429999999995,
"heapDeltaBytes": 2817352,
"heapUsedBytes": 123963360,
"domNodes": -296,
"jsHeapTotalBytes": 27852800,
"scriptDurationMs": 5056.044,
"eventListeners": -130,
"totalBlockingTimeMs": 89,
"frameDurationMs": 24.607718120805366,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7480.497000000014,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.5980000000000004,
"layouts": 2,
"layoutDurationMs": 0.5,
"taskDurationMs": 6760.49,
"heapDeltaBytes": 18621484,
"heapUsedBytes": 123269704,
"domNodes": -276,
"jsHeapTotalBytes": 24522752,
"scriptDurationMs": 5183.323,
"eventListeners": -130,
"totalBlockingTimeMs": 54,
"frameDurationMs": 24.295454545454547,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-combo-open",
"durationMs": 162.01300000000174,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.346000000000002,
"layouts": 11,
"layoutDurationMs": 2.532,
"taskDurationMs": 113.09599999999999,
"heapDeltaBytes": 13218228,
"heapUsedBytes": 117140900,
"domNodes": 917,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 6.474,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837500000000034,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 168.4759999999983,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.809,
"layouts": 11,
"layoutDurationMs": 2.792,
"taskDurationMs": 126.063,
"heapDeltaBytes": 13239644,
"heapUsedBytes": 117910444,
"domNodes": 917,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.489999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2041.5350000000103,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1999999999999997,
"layouts": 9,
"layoutDurationMs": 1.9839999999999995,
"taskDurationMs": 529.277,
"heapDeltaBytes": -21319848,
"heapUsedBytes": 87558088,
"domNodes": -296,
"jsHeapTotalBytes": -1953792,
"scriptDurationMs": 25.697000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.2820000000333,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0930000000000004,
"layouts": 9,
"layoutDurationMs": 1.9229999999999998,
"taskDurationMs": 393.087,
"heapDeltaBytes": 1036848,
"heapUsedBytes": 103067948,
"domNodes": -296,
"jsHeapTotalBytes": -2555904,
"scriptDurationMs": 28.424999999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2232.844,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.406,
"layouts": 7,
"layoutDurationMs": 1.536,
"taskDurationMs": 1324.586,
"heapDeltaBytes": -10672192,
"heapUsedBytes": 98451908,
"domNodes": -296,
"jsHeapTotalBytes": -1560576,
"scriptDurationMs": 619.7429999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667164179104475,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2252.164999999991,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.758999999999999,
"layouts": 7,
"layoutDurationMs": 1.5949999999999998,
"taskDurationMs": 1391.822,
"heapDeltaBytes": -33623812,
"heapUsedBytes": 86830912,
"domNodes": -296,
"jsHeapTotalBytes": -1347584,
"scriptDurationMs": 639.67,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3273.559999999975,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.245000000000001,
"layouts": 67,
"layoutDurationMs": 10.179,
"taskDurationMs": 1315.558,
"heapDeltaBytes": -7076044,
"heapUsedBytes": 97388280,
"domNodes": -272,
"jsHeapTotalBytes": -327680,
"scriptDurationMs": 632.001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.751020408163264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3305.6809999999928,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.485999999999997,
"layouts": 65,
"layoutDurationMs": 10.005,
"taskDurationMs": 1475.065,
"heapDeltaBytes": -4274920,
"heapUsedBytes": 100278168,
"domNodes": -272,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 626.0570000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666161616161617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2593.8510000000006,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.941000000000001,
"layouts": 8,
"layoutDurationMs": 1.96,
"taskDurationMs": 1568.3250000000003,
"heapDeltaBytes": 18326648,
"heapUsedBytes": 124228088,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 765.444,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.88246753246753,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2234.3210000000227,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.2909999999999995,
"layouts": 5,
"layoutDurationMs": 1.1740000000000002,
"taskDurationMs": 1444.4550000000002,
"heapDeltaBytes": 16896268,
"heapUsedBytes": 122765748,
"domNodes": 0,
"jsHeapTotalBytes": 6451200,
"scriptDurationMs": 791.571,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.918181818181818,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.915999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0710000000000006,
"layouts": 8,
"layoutDurationMs": 1.8439999999999999,
"taskDurationMs": 393.8999999999999,
"heapDeltaBytes": 2157100,
"heapUsedBytes": 105080272,
"domNodes": -296,
"jsHeapTotalBytes": -5439488,
"scriptDurationMs": 25.151,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.5230000000493,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.167,
"layouts": 10,
"layoutDurationMs": 2.196,
"taskDurationMs": 532.763,
"heapDeltaBytes": 106784,
"heapUsedBytes": 102751868,
"domNodes": -296,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 27.557999999999993,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 493.5520000000224,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.95,
"layouts": 10,
"layoutDurationMs": 2.348,
"taskDurationMs": 307.59400000000005,
"heapDeltaBytes": 22425280,
"heapUsedBytes": 114155692,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 118.03300000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 525.2659999999878,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5,
"layouts": 10,
"layoutDurationMs": 2.4290000000000003,
"taskDurationMs": 356.01300000000003,
"heapDeltaBytes": -2607528,
"heapUsedBytes": 102255644,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 120.45500000000001,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.1469999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2680000000000002,
"layouts": 10,
"layoutDurationMs": 2.245,
"taskDurationMs": 451.09399999999994,
"heapDeltaBytes": 1444540,
"heapUsedBytes": 91357556,
"domNodes": -218,
"jsHeapTotalBytes": -2818048,
"scriptDurationMs": 7.180000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2025.8150000000228,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.404,
"layouts": 10,
"layoutDurationMs": 2.32,
"taskDurationMs": 366.848,
"heapDeltaBytes": 648392,
"heapUsedBytes": 90276828,
"domNodes": -218,
"jsHeapTotalBytes": -196608,
"scriptDurationMs": 8.225999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1977.800000000002,
"styleRecalcs": 86,
"styleRecalcDurationMs": 12.701,
"layouts": 10,
"layoutDurationMs": 2.032,
"taskDurationMs": 921.3059999999999,
"heapDeltaBytes": -5321744,
"heapUsedBytes": 85073972,
"domNodes": -210,
"jsHeapTotalBytes": -3080192,
"scriptDurationMs": 87.31,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6672268907563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.7129999999788,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.689000000000002,
"layouts": 10,
"layoutDurationMs": 2.109,
"taskDurationMs": 594.3320000000001,
"heapDeltaBytes": -752220,
"heapUsedBytes": 89130812,
"domNodes": -210,
"jsHeapTotalBytes": -1769472,
"scriptDurationMs": 93.136,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.2089999999748,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.677000000000003,
"layouts": 5,
"layoutDurationMs": 12.243,
"taskDurationMs": 828.5560000000003,
"heapDeltaBytes": 7114672,
"heapUsedBytes": 120398828,
"domNodes": 16030,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 24.500999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 102,
"frameDurationMs": 18.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8376.825999999994,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.875999999999998,
"layouts": 9,
"layoutDurationMs": 2.05,
"taskDurationMs": 4633.161,
"heapDeltaBytes": 7697100,
"heapUsedBytes": 113256412,
"domNodes": -296,
"jsHeapTotalBytes": -389120,
"scriptDurationMs": 2111.0860000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662027833002,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8477.025000000027,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.464000000000002,
"layouts": 8,
"layoutDurationMs": 1.7509999999999997,
"taskDurationMs": 4852.411,
"heapDeltaBytes": -15911104,
"heapUsedBytes": 104532568,
"domNodes": -276,
"jsHeapTotalBytes": -692224,
"scriptDurationMs": 2225.373,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665815324165028,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13933.539999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13003.056999999999,
"heapDeltaBytes": -15184772,
"heapUsedBytes": 285983108,
"domNodes": -3344,
"jsHeapTotalBytes": 28037120,
"scriptDurationMs": 190.077,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.063557858376512,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 14373.422999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13522.861,
"heapDeltaBytes": -33267428,
"heapUsedBytes": 277161980,
"domNodes": -3344,
"jsHeapTotalBytes": 25153536,
"scriptDurationMs": 200.35,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.599486301369865,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 23555.926999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.71299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23193.175,
"heapDeltaBytes": -28334764,
"heapUsedBytes": 301169872,
"domNodes": -3344,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 728.904,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 43.934701492537314,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23109.943000000043,
"styleRecalcs": 175,
"styleRecalcDurationMs": 19.012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22781.126,
"heapDeltaBytes": -30426744,
"heapUsedBytes": 293840740,
"domNodes": -3344,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 736.359,
"eventListeners": -651,
"totalBlockingTimeMs": 3,
"frameDurationMs": 44.57129094412331,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6904.53100000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.224999999999994,
"layouts": 20,
"layoutDurationMs": 21.096000000000004,
"taskDurationMs": 6821.235000000001,
"heapDeltaBytes": -44022196,
"heapUsedBytes": 275483808,
"domNodes": -3344,
"jsHeapTotalBytes": 18862080,
"scriptDurationMs": 125.994,
"eventListeners": -653,
"totalBlockingTimeMs": 6,
"frameDurationMs": 40.349122807017544,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 5354.481999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.568,
"layouts": 20,
"layoutDurationMs": 22.21300000000001,
"taskDurationMs": 5261.817000000001,
"heapDeltaBytes": -6649748,
"heapUsedBytes": 298672736,
"domNodes": -3344,
"jsHeapTotalBytes": 29609984,
"scriptDurationMs": 87.25799999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.92369942196532,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10026.916999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9605.824,
"heapDeltaBytes": 4589588,
"heapUsedBytes": 302530324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 137.44699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.15992779783393,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7169.222999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6774.082,
"heapDeltaBytes": 10933356,
"heapUsedBytes": 298993364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.79199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.057342657342662,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 103.06700000001001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.838000000000001,
"layouts": 7,
"layoutDurationMs": 2.7390000000000003,
"taskDurationMs": 83.61200000000002,
"heapDeltaBytes": 4880332,
"heapUsedBytes": 105387100,
"domNodes": 98,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.401999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.52799999999206,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.233,
"layouts": 6,
"layoutDurationMs": 1.9630000000000003,
"taskDurationMs": 67.09,
"heapDeltaBytes": -20311536,
"heapUsedBytes": 89576308,
"domNodes": 94,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 4.6,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.979999999999926,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 316.47799999996096,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6880000000000001,
"layouts": 76,
"layoutDurationMs": 12.745,
"taskDurationMs": 279.989,
"heapDeltaBytes": 10712156,
"heapUsedBytes": 100843428,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 129.236,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 295.06800000001476,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.652,
"layouts": 76,
"layoutDurationMs": 11.907,
"taskDurationMs": 260.17400000000004,
"heapDeltaBytes": -19308456,
"heapUsedBytes": 70343104,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 115.123,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 331.36500000000524,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.232,
"layouts": 76,
"layoutDurationMs": 10.836,
"taskDurationMs": 292.051,
"heapDeltaBytes": -1778500,
"heapUsedBytes": 115673540,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 101.341,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 409.2399999999543,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.104,
"layouts": 76,
"layoutDurationMs": 12.418000000000001,
"taskDurationMs": 377.591,
"heapDeltaBytes": 49260,
"heapUsedBytes": 121151280,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.702,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 63.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2988 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b86a03fe38f5a802dff0b9872166509d25bec5e6
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (135)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
There was a problem hiding this comment.
Verdict: faithful backport of #21321; approval is pending completion of the required CI checks.
I compared merged source commit 42f00b3f, verified on current main. This target has not extracted touchPointerGuards, so the pointer change correctly stays in simpleTouchSupport's existing wrapper and the tests retain this branch's import-time registration setup. The source's missing-canvas regression cases are present, and the pinch helper is identical. The tracer resolution retains the target's _timeoutReported field alongside the new _outcome field. The remaining source hunks apply unchanged, with no missing changes or tests.
With cloud/1.58's own dependencies, all 30 tests across simpleTouchSupport, touchCanvasAccess, LGraphCanvas.startRendering, and bootstrapTracer pass. Changed-source ESLint and diff whitespace checks pass. At this head, lint-and-format has passed, but required test and e2e-status have not reported success and CI jobs are still running. I found no backport divergence; I am withholding approval only because required CI is incomplete.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.58 #22279 +/- ##
=============================================
Coverage ? 84.50%
=============================================
Files ? 3103
Lines ? 163092
Branches ? 38984
=============================================
Hits ? 137826
Misses ? 24875
Partials ? 391
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21321 to
cloud/1.58. The auto-backport hit cherry-pick conflicts.app.canvasis missing, and they report why.LGraphCanvasconstruction.simpleTouchSupport.tsmatches between 1.57 and 1.58.Full context for agent readers
Built by cherry-picking the core/1.57 carrier's resolution onto
cloud/1.58. The only conflict wasbootstrapTracer.ts, where both_timeoutReported(already on 1.58) and the new_outcomefield are kept.Local checks: the touch, startRendering and bootstrapTracer suites pass (30 tests), and
pnpm typecheckis clean.The AI co-author trailer from the source squash is dropped from this commit.
Follow-up #22273 (render loop recovery, pinch scale guard, timed_out outcome) will be backported here after it merges.
Part of https://linear.app/comfyorg/issue/FRONT-3716