Skip to content

[backport cloud/1.56] fix: guard touch handlers against a missing canvas and report why - #21854

Closed
christian-byrne wants to merge 1 commit into
cloud/1.56from
backport-21321-to-cloud-1.56
Closed

christian-byrne wants to merge 1 commit into
cloud/1.56from
backport-21321-to-cloud-1.56

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #21321 to cloud/1.56.

The target predates extraction of touchPointerGuards.ts, so this conflict resolution preserves the target branch's inline pointer guards rather than resurrecting the deleted helper. It adds guarded canvas access, telemetry, bootstrap outcome tracking, and the source regression tests.

Validation

  • NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/extensions/core/simpleTouchSupport.test.ts src/extensions/core/touchCanvasAccess.test.ts src/lib/litegraph/src/LGraphCanvas.startRendering.test.ts src/platform/telemetry/perf/bootstrapTracer.test.ts (25 passed)
  • targeted ESLint: no errors
  • targeted oxfmt --check: passed
  • pre-push knip/fallow gate: passed

Source commit: 42f00b3f1b33d42b8da10b3fbdcd47a97fcbc8a8

…1321)

<!-- claude-slack-attribution -->
_Requested via [Slack
thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1792317627366019?thread_ts=1792317627.366019&cid=C09KFK2ABB8)_

**Before:** If `app.canvas` was never assigned, every click on the
canvas threw `TypeError: Cannot read properties of undefined (reading
'pointer')` from the touch-support `processMouseDown` wrapper, and the
two-finger touch handlers threw the same way. One production RUM session
shows how that state arises: a browser userscript patches
`CanvasRenderingContext2D.drawImage` and throws. The throw happens in
the first synchronous frame inside `new LGraphCanvas(...)`
(`startRendering` -> `renderFrame` -> `draw` -> `drawFrontCanvas`), so
`ComfyApp.setup()` aborts before `app.canvas` is assigned. Event
listeners were already bound by then, so each click hit the wrapper with
no canvas. The app stayed unusable for the whole session.

**After:** The wrapper uses the canvas it is called on (`this.pointer`)
instead of the global, and the touch handlers read
`app.canvasOrUndefined` once and skip the gesture when it is missing. A
throwing first frame no longer aborts `LGraphCanvas` construction: it is
reported and the instance finishes constructing, so `app.canvas` gets
assigned. Per-frame behaviour is unchanged.

- `simpleTouchSupport.ts`: `this.pointer.isDown = false` in the
`processMouseDown` wrapper; `canvasOrReport` guards in the `touchstart`
and `touchmove` pinch paths; pinch math moved into
`zoomCanvasAroundPinch` unchanged.
- `touchCanvasAccess.ts`: when a touch or pointer entry point finds no
canvas, report once per entry point per page load (`errorType:
error_handling_touch_input_missing_canvas`, level warning) with context:
entry point, event type, pointer type, isPrimary, `document.readyState`,
startup outcome (`pending`/`completed`/`failed`), whether `window.app`
is defined, whether the canvas element exists and is connected, and
whether the event target is the canvas element. No URLs, user data or
ids.
- `bootstrapTracer.ts`: read-only `outcome` getter so the report can say
whether startup failed.
- `LGraphCanvas.startRendering`: the initial `renderFrame` call is
wrapped; on failure it resets `is_rendering`, reports
`error_rendering_canvas_initial_frame` and returns instead of throwing
out of the constructor.

- Root cause is evidenced for one production session (the patched
`drawImage` above), not proven for every occurrence. The new telemetry
is meant to show whether other sessions share it or have a different
cause.
- Tests: `pnpm test:unit` on `simpleTouchSupport.test.ts`,
`touchCanvasAccess.test.ts`, `LGraphCanvas.startRendering.test.ts`,
`bootstrapTracer.test.ts` (30 passing). The new wrapper and construction
tests fail against the previous code.
- Not covered: a real browser with a userscript patching `drawImage`.
- After release: query
`@error.type:error_handling_touch_input_missing_canvas` and
`@error.type:error_rendering_canvas_initial_frame` in Datadog and group
by `bootstrapOutcome` and `entryPoint`.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01EFm3kPsvMhmwyTUYf8eYuJ)_

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit 42f00b3)
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Oct 23, 2026
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 6 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 35.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 333ms TBT · 92.0 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 47.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 102ms TBT · 95.4 MB heap
extension-clean-combined-draw: · 44.1 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 14ms TBT · 66.1 MB heap
extension-rgthree-prototype-draw: · 41.5 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 60ms TBT · 74.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.0 MB heap
large-graph-pan: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
legacy-node-drag: · 59.8 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
subgraph-transition-enter: · 54.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 93ms TBT · 89.4 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.5 MB heap
vue-large-graph-idle: · 41.7 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 171.4 MB heap
vue-large-graph-pan: · 35.1 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 9ms TBT · 169.5 MB heap
vue-node-resize-workload: · 35.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 205.7 MB heap
vue-zoom-out-idle: · 44.7 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 170.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 399ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.3 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 19ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 659ms
canvas-mouse-sweep: script duration 130ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.0 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 11ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 323ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.7 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 392ms
dom-widget-clipping: script duration 136ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 57.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 28ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 610ms
dom-widget-order-dense-n200-w200-i120: script duration 44ms
dom-widget-order-dense-n200-w200-i120: TBT 333ms
dom-widget-order-dense-n200-w200-i120: heap used 92.0 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 330ms
dom-widget-order-sparse-n1000-w20-i120: script duration 113ms
dom-widget-order-sparse-n1000-w20-i120: TBT 102ms
dom-widget-order-sparse-n1000-w20-i120: heap used 95.4 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 23ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 4
extension-clean-combined-draw: task duration 5460ms
extension-clean-combined-draw: script duration 4168ms
extension-clean-combined-draw: TBT 14ms
extension-clean-combined-draw: heap used 66.1 MB
extension-clean-combined-draw: DOM nodes -142
extension-clean-combined-draw: event listeners -76
extension-rgthree-prototype-draw: avg frame time 24ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 4
extension-rgthree-prototype-draw: task duration 5685ms
extension-rgthree-prototype-draw: script duration 4439ms
extension-rgthree-prototype-draw: TBT 60ms
extension-rgthree-prototype-draw: heap used 74.6 MB
extension-rgthree-prototype-draw: DOM nodes -142
extension-rgthree-prototype-draw: event listeners -78
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 484ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 74.0 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1320ms
large-graph-pan: script duration 674ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 66.1 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 17ms
large-graph-zoom: style recalc duration 16ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 72
large-graph-zoom: task duration 1404ms
large-graph-zoom: script duration 640ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 66.3 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1624ms
legacy-node-drag: script duration 851ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 68.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 478ms
minimap-idle: script duration 36ms
minimap-idle: TBT 0ms
minimap-idle: heap used 76.3 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 349ms
subgraph-dom-widget-clipping: script duration 113ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 55.5 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 4ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 407ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.7 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 19ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 648ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.9 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 24ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 815ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 93ms
subgraph-transition-enter: heap used 89.4 MB
subgraph-transition-enter: DOM nodes 14227
subgraph-transition-enter: event listeners 2463
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 48ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4734ms
viewport-pan-sweep: script duration 2281ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.5 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 24ms
vue-large-graph-idle: p95 frame time 42ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13093ms
vue-large-graph-idle: script duration 216ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.4 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14917
vue-large-graph-pan: avg frame time 29ms
vue-large-graph-pan: p95 frame time 58ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 87
vue-large-graph-pan: task duration 15320ms
vue-large-graph-pan: script duration 710ms
vue-large-graph-pan: TBT 9ms
vue-large-graph-pan: heap used 169.5 MB
vue-large-graph-pan: DOM nodes -3046
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 28ms
vue-node-resize-workload: p95 frame time 50ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 57ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4768ms
vue-node-resize-workload: script duration 84ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 205.7 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 22ms
vue-zoom-out-idle: p95 frame time 42ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6450ms
vue-zoom-out-idle: script duration 105ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.8 MB
vue-zoom-out-idle: DOM nodes -3045
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 3
workflow-execution: style recalc count 9
workflow-execution: task duration 75ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.6 MB
workflow-execution: DOM nodes 105
workflow-execution: event listeners 25
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 29ms
agent-composer-empty-conversation-typing: style recalc duration 102ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 555ms
agent-composer-empty-conversation-typing: script duration 184ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 64.9 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 30ms
agent-composer-long-conversation-typing: style recalc duration 264ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1052ms
agent-composer-long-conversation-typing: script duration 281ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 108.7 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-23T22:45:02.769Z",
  "gitSha": "c3f0d126aaf2bcdb81e2ef71fe81956c40e3a535",
  "branch": "backport-21321-to-cloud-1.56",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.9239999999795,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.7299999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.98999999999995,
      "heapDeltaBytes": 673296,
      "heapUsedBytes": 68693988,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.566,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.8980000000115,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.246999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.90100000000007,
      "heapDeltaBytes": 689476,
      "heapUsedBytes": 68227040,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 13.645999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1713.6969999999963,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 20.256000000000004,
      "layouts": 12,
      "layoutDurationMs": 4.848,
      "taskDurationMs": 686.595,
      "heapDeltaBytes": -2040744,
      "heapUsedBytes": 66001064,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 139.043,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1709.1139999999996,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 17.274,
      "layouts": 12,
      "layoutDurationMs": 4.4799999999999995,
      "taskDurationMs": 630.99,
      "heapDeltaBytes": -2047700,
      "heapUsedBytes": 66189004,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 121.004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.0269999999919,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 9.933,
      "layouts": 6,
      "layoutDurationMs": 1.3419999999999999,
      "taskDurationMs": 338.01500000000004,
      "heapDeltaBytes": 4171812,
      "heapUsedBytes": 72257708,
      "domNodes": 53,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 16.281000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475727,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.9949999999553,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 11.718000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.4459999999999997,
      "taskDurationMs": 307.30100000000004,
      "heapDeltaBytes": 4195792,
      "heapUsedBytes": 71751320,
      "domNodes": 53,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 16.488000000000003,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 592.4440000000004,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 4.607,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.01,
      "heapDeltaBytes": -7071332,
      "heapUsedBytes": 61490968,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 143.56199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 556.9500000000289,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 4.494,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.437,
      "heapDeltaBytes": -7408592,
      "heapUsedBytes": 59458076,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 128.414,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636368,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 969.5020000000056,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 595.188,
      "heapDeltaBytes": 39617428,
      "heapUsedBytes": 107714808,
      "domNodes": 0,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 47.346,
      "eventListeners": 0,
      "totalBlockingTimeMs": 318,
      "frameDurationMs": 27.617142857142856,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 978.0120000000352,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 624.563,
      "heapDeltaBytes": 15925004,
      "heapUsedBytes": 85165008,
      "domNodes": 0,
      "jsHeapTotalBytes": 3309568,
      "scriptDurationMs": 41.239,
      "eventListeners": 0,
      "totalBlockingTimeMs": 348,
      "frameDurationMs": 29.290909090909103,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 716.0739999999919,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 332.35400000000004,
      "heapDeltaBytes": 17697456,
      "heapUsedBytes": 100274784,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 116.10300000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 103,
      "frameDurationMs": 21.073529411764707,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 714.7370000000137,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.94100000000003,
      "heapDeltaBytes": 17325304,
      "heapUsedBytes": 99715812,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 109.52199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 100,
      "frameDurationMs": 21.076470588235306,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6405.352999999991,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.6740000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5438.512000000001,
      "heapDeltaBytes": -7230932,
      "heapUsedBytes": 69566684,
      "domNodes": -142,
      "jsHeapTotalBytes": -9834496,
      "scriptDurationMs": 4172.436000000001,
      "eventListeners": -74,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 22.14463667820069,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6414.182000000039,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.162,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5481.3859999999995,
      "heapDeltaBytes": -14995440,
      "heapUsedBytes": 69158216,
      "domNodes": -142,
      "jsHeapTotalBytes": -12980224,
      "scriptDurationMs": 4163.903,
      "eventListeners": -78,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 23.247463768115946,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6535.687999999993,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.7859999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5676.2519999999995,
      "heapDeltaBytes": -12841736,
      "heapUsedBytes": 71528184,
      "domNodes": -142,
      "jsHeapTotalBytes": -6164480,
      "scriptDurationMs": 4447.736000000001,
      "eventListeners": -78,
      "totalBlockingTimeMs": 29,
      "frameDurationMs": 24.286617100371746,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6635.485999999957,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.2119999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5693.429,
      "heapDeltaBytes": 668568,
      "heapUsedBytes": 84850384,
      "domNodes": -142,
      "jsHeapTotalBytes": -8523776,
      "scriptDurationMs": 4430.334999999999,
      "eventListeners": -78,
      "totalBlockingTimeMs": 90,
      "frameDurationMs": 23.94620938628159,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.0350000000067,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.553000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.9000000000001,
      "heapDeltaBytes": -9612416,
      "heapUsedBytes": 78229644,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 36.425,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.1279999999992,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.9480000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.553,
      "heapDeltaBytes": -10654464,
      "heapUsedBytes": 76925508,
      "domNodes": 0,
      "jsHeapTotalBytes": 561152,
      "scriptDurationMs": 35.32299999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66528925619835,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2168.768,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.939000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1316.124,
      "heapDeltaBytes": -19150224,
      "heapUsedBytes": 69726800,
      "domNodes": 0,
      "jsHeapTotalBytes": 1347584,
      "scriptDurationMs": 659.977,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7953488372093,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2201.7779999999902,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 14.265000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1324.5939999999998,
      "heapDeltaBytes": -20226256,
      "heapUsedBytes": 68817340,
      "domNodes": 0,
      "jsHeapTotalBytes": 1347584,
      "scriptDurationMs": 688.438,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.793129770992362,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3147.9680000000485,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 16.376,
      "layouts": 60,
      "layoutDurationMs": 16.874,
      "taskDurationMs": 1367.0559999999998,
      "heapDeltaBytes": 1205196,
      "heapUsedBytes": 69299020,
      "domNodes": 24,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 615.5849999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666137566137568,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3212.8660000000195,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 16.467,
      "layouts": 60,
      "layoutDurationMs": 16.839,
      "taskDurationMs": 1441.422,
      "heapDeltaBytes": 2053712,
      "heapUsedBytes": 69661724,
      "domNodes": 24,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 663.834,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666321243523317,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2563.9320000000225,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.065,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1632.4289999999999,
      "heapDeltaBytes": 6474000,
      "heapUsedBytes": 75133196,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 871.043,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.775657894736845,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2413.735000000031,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.750999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1615.176,
      "heapDeltaBytes": -14186608,
      "heapUsedBytes": 68692492,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 831.189,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665972222222226,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.979999999999,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.580999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.03,
      "heapDeltaBytes": -9231460,
      "heapUsedBytes": 80077280,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 35.17000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.0250000000797,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.289,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.45899999999995,
      "heapDeltaBytes": -9360624,
      "heapUsedBytes": 79853112,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 36.292,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 532.1579999999813,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.403999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 336.76900000000006,
      "heapDeltaBytes": -11953612,
      "heapUsedBytes": 58117240,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 110.77600000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.9890000000023,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.867000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 361.85499999999996,
      "heapDeltaBytes": -12356148,
      "heapUsedBytes": 58195472,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 114.29499999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.260999999986,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.277000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.78800000000007,
      "heapDeltaBytes": -2584032,
      "heapUsedBytes": 60897552,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.790000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.0759999999932,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.7919999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.33599999999996,
      "heapDeltaBytes": 1190024,
      "heapUsedBytes": 70688356,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.641,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.293000000016,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 20.258,
      "layouts": 16,
      "layoutDurationMs": 6.319999999999999,
      "taskDurationMs": 653.405,
      "heapDeltaBytes": -5814360,
      "heapUsedBytes": 63885844,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 108.297,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.4149999999827,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 18.709,
      "layouts": 16,
      "layoutDurationMs": 5.433999999999999,
      "taskDurationMs": 643.0519999999999,
      "heapDeltaBytes": 17017936,
      "heapUsedBytes": 80547872,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 102.764,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1318.6239999999998,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 24.14199999999999,
      "layouts": 5,
      "layoutDurationMs": 10.678,
      "taskDurationMs": 815.348,
      "heapDeltaBytes": 1228984,
      "heapUsedBytes": 93766184,
      "domNodes": 14227,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 30.226000000000003,
      "eventListeners": 2463,
      "totalBlockingTimeMs": 93,
      "frameDurationMs": 18.51805555555556,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8212.747999999976,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 49.38,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4739.293999999999,
      "heapDeltaBytes": -18258068,
      "heapUsedBytes": 70945416,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2293.7340000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665922920892495,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8282.83399999998,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 46.835,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4728.976000000001,
      "heapDeltaBytes": 7878364,
      "heapUsedBytes": 95722988,
      "domNodes": 0,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 2268.163,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.699596774193548,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13913.911999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13324.252,
      "heapDeltaBytes": -39257016,
      "heapUsedBytes": 177632792,
      "domNodes": -3045,
      "jsHeapTotalBytes": 7217152,
      "scriptDurationMs": 214.92900000000003,
      "eventListeners": -14919,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.688099467140315,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13450.369000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12862.307999999999,
      "heapDeltaBytes": -45083620,
      "heapUsedBytes": 181788124,
      "domNodes": -3046,
      "jsHeapTotalBytes": 9457664,
      "scriptDurationMs": 216.313,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.240138408304496,
      "p95FrameDurationMs": 33.5
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16180.155000000013,
      "styleRecalcs": 96,
      "styleRecalcDurationMs": 20.625999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15659.511,
      "heapDeltaBytes": -17046116,
      "heapUsedBytes": 186069496,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5197824,
      "scriptDurationMs": 735.52,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 29.537158469945354,
      "p95FrameDurationMs": 66.69999999999709
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15433.712000000014,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 16.518000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14979.848,
      "heapDeltaBytes": -29667724,
      "heapUsedBytes": 169336936,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7688192,
      "scriptDurationMs": 684.735,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.470870337477802,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4967.258000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.18099999999998,
      "layouts": 20,
      "layoutDurationMs": 27.293,
      "taskDurationMs": 4917.906000000001,
      "heapDeltaBytes": -2833288,
      "heapUsedBytes": 214423244,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 88.215,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.21411764705882,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4717.404999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 54.839,
      "layouts": 20,
      "layoutDurationMs": 24.318999999999992,
      "taskDurationMs": 4618.263,
      "heapDeltaBytes": 958248,
      "heapUsedBytes": 217018552,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 80.24199999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.35953757225433,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6854.642000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6598.337,
      "heapDeltaBytes": -24061572,
      "heapUsedBytes": 182755856,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8790016,
      "scriptDurationMs": 107.871,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.041275167785237,
      "p95FrameDurationMs": 49.89999999999782
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6504.6140000000605,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6301.4090000000015,
      "heapDeltaBytes": -37658252,
      "heapUsedBytes": 175430796,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6246400,
      "scriptDurationMs": 102.178,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.738127090301006,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 120.8580000000552,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 12.721000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.092,
      "taskDurationMs": 90.08300000000003,
      "heapDeltaBytes": 3918788,
      "heapUsedBytes": 69095340,
      "domNodes": 97,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.771999999999997,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.657142857142844,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 90.12999999993099,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.885000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.601,
      "taskDurationMs": 59.77200000000002,
      "heapDeltaBytes": 3635564,
      "heapUsedBytes": 68576572,
      "domNodes": 113,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.560000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 617.3230000000558,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 105.269,
      "layouts": 76,
      "layoutDurationMs": 29.575,
      "taskDurationMs": 582.748,
      "heapDeltaBytes": -16729052,
      "heapUsedBytes": 68093088,
      "domNodes": 76,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 197.002,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664864864864875,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 561.3550000000487,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 99.276,
      "layouts": 76,
      "layoutDurationMs": 28.745,
      "taskDurationMs": 527.4929999999999,
      "heapDeltaBytes": -17508548,
      "heapUsedBytes": 68018212,
      "domNodes": 76,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 171.39800000000002,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667647058823523,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1105.5299999999306,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 276.81899999999996,
      "layouts": 76,
      "layoutDurationMs": 29.822000000000003,
      "taskDurationMs": 1082.907,
      "heapDeltaBytes": 6793824,
      "heapUsedBytes": 114934552,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 292.625,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665671641791036,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1047.971000000075,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 251.17899999999997,
      "layouts": 76,
      "layoutDurationMs": 29.553,
      "taskDurationMs": 1020.923,
      "heapDeltaBytes": 6168156,
      "heapUsedBytes": 112989840,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 269.806,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66507936507936,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🎭 Playwright: ✅ 2205 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2183 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/23/2026, 10:36:18 PM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 68a0aaa81bde9b1f9484e267e59ef7710360fe42

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 23, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete exact-head carrier diff against source #21321 and the target branch architecture. The conflict resolution intentionally keeps the release branch’s inline touch-count/zoom guards, does not resurrect the deleted touchPointerGuards helper, routes all nullable canvas access through canvasOrReport, preserves this.pointer on the LGraphCanvas method, and adds the source regression coverage. Focused touch/canvas/bootstrap tests, targeted lint/format, commit typecheck, and the repository pre-push gate passed. No actionable finding from this review.

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/extensions/core/simpleTouchSupport.ts 90.90% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.56   #21854   +/-   ##
=============================================
  Coverage              ?   83.16%           
=============================================
  Files                 ?     2398           
  Lines                 ?   128028           
  Branches              ?    39133           
=============================================
  Hits                  ?   106469           
  Misses                ?    21148           
  Partials              ?      411           
Flag Coverage Δ
unit 83.16% <93.61%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extensions/core/touchCanvasAccess.ts 100.00% <100.00%> (ø)
src/platform/telemetry/perf/bootstrapTracer.ts 95.52% <100.00%> (ø)
src/extensions/core/simpleTouchSupport.ts 79.27% <90.90%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟡 Medium 3
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

lastTouch: TouchPoint
) {
let scale = requestedScale
const newX = (center.clientX - lastTouch.clientX) / requestedScale

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — newX/newY divide by the unclamped requestedScale, and the caller only guards touchDist/lastScale against null, not zero. Two touches reporting identical coordinates make getMultiTouchPos return 0, so requestedScale is 0 (or NaN when touchDist was also 0) and ±Infinity/NaN is added into canvas.ds.offset, which never recovers; a NaN scale also slips past both clamp branches into ds.scale. Requiring a finite positive ratio and dividing by the clamped scale fixes this and the pan drift that occurs at the min/max zoom limits. Raised by 7 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro adversarial, kimi-k3-max edge-case).

this.is_rendering = true
renderFrame.call(this)
try {
renderFrame.call(this)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The try/catch only wraps the synchronous first renderFrame.call(this). Frames 2+ run from the requestAnimationFrame/setTimeout callback inside renderFrame, so a draw() throw there escapes before the re-scheduling block, queues no next frame, and leaves is_rendering === true — which makes every later startRendering() early-return, with no telemetry. Wrapping the body of renderFrame itself would cover the first and subsequent frames alike. Raised by 5 of 8 reviewers (gemini-3.1-pro edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).

try {
renderFrame.call(this)
} catch (cause) {
this.is_rendering = false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Catching the first-frame throw converts a loud constructor failure into a silently blank canvas: the constructor is the only production caller of startRendering(), so nothing re-arms the loop and reportError reaches telemetry but not the user. Startup then completes into a graph editor where no later setDirty() is ever painted. Consider a recovery path — re-arming rendering on the next setDirty, or a user-visible reload prompt — rather than leaving the canvas permanently dead. Raised by 3 of 8 reviewers (gpt-5.6-sol-max edge-case, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial).

return
}
app.canvas.pointer.isDown = false // Prevent context menu from opening on second tap
canvasOrReport('processMouseDown', e)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — canvasOrReport('processMouseDown', e) is now a pure telemetry probe (the line below mutates this), but it inspects the global app.canvasOrUndefined instead of the this canvas actually handling the event, and it runs for mouse and pen pointers too. A plain mouse press on a secondary or pre-assignment canvas therefore emits a false-positive error_handling_touch_input_missing_canvas, and since dedupe is permanent per entry point it consumes the single report a genuine touch press would have sent. Gate on e.pointerType === 'touch' and check the canvas handling the event. Raised by 4 of 8 reviewers (gemini-3.1-pro edge-case, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).

}
if (e.touches.length === 2 && lastTouch && !e.ctrlKey && !e.shiftKey) {
const canvas = canvasOrReport('touchmove', e)
if (!canvas) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This early return now precedes e.preventDefault(), which previously ran unconditionally on a two-finger touchmove. In exactly the degraded state this change instruments, the browser regains native pinch-zoom of the whole page — the behaviour the comment on the next line says the handler exists to suppress. Hoist preventDefault() above the canvasOrReport call. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).

return [...this._timings].sort((a, b) => a.startMs - b.startMs)
}

get outcome(): 'completed' | 'failed' | 'pending' {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — _outcome is only assigned in complete(), while a watchdog timeout emits its 'timed_out' outcome through _report() without touching it, so a startup that blew past the deadline still reads as 'pending' from this getter. That leaves the new bootstrapOutcome field in the touch telemetry unable to distinguish a hung startup — the case it most needs to diagnose — from one still legitimately in flight. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

})
}

export function canvasOrReport(entryPoint: string, e: Event) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — entryPoint is a free-form string keying a module-global Set that is never cleared, so a future caller passing a per-event value (event type, node id, timestamp) would grow the set unboundedly and defeat the dedupe it exists for. Narrowing the parameter to a string-literal union of the real entry points makes that bound a type guarantee and documents the accepted values. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

@thedatalife

Copy link
Copy Markdown
Contributor

Closing: cloud/1.56 doesn't ship any more. Core skipped 1.56 and went from 1.55 to 1.57, and no cloud environment serves 1.56 (prod is on 1.57, staging on 1.58). The fix is going to the 1.57 lines in #21850 and #21851. Thanks @christian-byrne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants