Repository navigation
[backport cloud/1.56] fix: mint DynamicGroup row values on add and shifted removal (#20992, #21057) - #21316
[backport cloud/1.56] fix: mint DynamicGroup row values on add and shifted removal (#20992, #21057)#21316mattmillerai wants to merge 2 commits into
Conversation
## Summary Adding a DynamicGroup row in a CRDT-bound workflow minted only the new row count. The new row's field widgets start at template defaults, but registering a widget emits no `set_widget` intent. The document keeps a removed row's values hidden, so after remove-then-add it showed those old values to followers and on reload, while the local canvas showed defaults. The DynamicGroup count setter now announces each newly created row widget's value through a new `widgetValueStore.announceValue`, after the count. That includes companion widgets such as `control_after_generate`. These intents go through the existing `docOpMinter` gate, so they are minted only for `local` edits in a bound workflow. Load, undo/redo restores (`load` source) and remote frames (`agent-remote`) mint nothing extra, and unbound workflows mint nothing. Fixes #20914 ## Verification - New `docOpMinter.test.ts` > `DynamicGroup rows` tests: remove the last row, then add one, mints the count ops plus `lora_name`, `seed` and `seed.0` defaults. A row added by an `agent-remote` or `load` write mints nothing. A row added while unbound mints nothing. The first test fails on `main` and passes with the fix. - `vitest run src/workbench/extensions/agent src/core/graph src/stores`: 247 files, 5047 passed. - Typecheck, oxlint, eslint, oxfmt, knip and fallow audit pass through the git hooks. (cherry picked from commit c449a01)
…21057) ## Summary In a doc-bound workflow, deleting a middle DynamicGroup row only minted the row-count `set_widget`. The later rows were renamed locally, but nothing was minted for the shifted `group.N.*` fields, so the document and peers dropped the last row and kept the deleted row's values (3 rows, delete row 0: this tab shows `[r1, r2]`, the doc ends up `[r0, r1]`). Each serializable widget renamed by a row shift now announces its current value (`announceValue`) under its new name. The minter still mints only local writes, so remote and load removals mint nothing. Stacked on #20992. Fixes #20992 (comment) ## Review focus - The shifted field `set_widget`s are minted before the count decrement. The doc host resolves each register by stamp, so the order does not change the final state. - Follow-up, not in this PR: the removed trailing row's registers are not cleared in the doc. A local regrow overwrites them (#20992 mints every added field), but a remote count write that regrows the group without field values could still bring back stale values. ## Tests - Red: new `mints the shifted field values after a middle row is removed` failed on the base branch. Only `set_widget loras 3 -> 2` was minted, with no `loras.1.*` ops. - Green: `pnpm -s vitest run src/core/graph src/workbench/extensions/agent/crdt src/stores/widgetValueStore.test.ts`: 89 files, 1375 passed, 1 expected fail. - Reverted only the implementation and confirmed the new test fails again. - Added `mints nothing for a row removed by a agent-remote/load write`. (cherry picked from commit e10c384)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-18T22:29:23.076Z",
"gitSha": "260c69e08a07c9fbecd0538333c4eb1da7ee5a0a",
"branch": "backport-cloud-1.56-dynamic-group-row-minting",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.0270000000037,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.952000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.801,
"heapDeltaBytes": 962460,
"heapUsedBytes": 69365612,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.414000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2009.800999999925,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.793,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.64899999999994,
"heapDeltaBytes": 23202904,
"heapUsedBytes": 82032260,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.653999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1675.5920000000515,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.062999999999999,
"layouts": 12,
"layoutDurationMs": 3.5959999999999996,
"taskDurationMs": 601.7889999999999,
"heapDeltaBytes": -2010972,
"heapUsedBytes": 65598456,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 110.292,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.935000000024,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.306000000000001,
"layouts": 12,
"layoutDurationMs": 3.7480000000000007,
"taskDurationMs": 612.271,
"heapDeltaBytes": -2288364,
"heapUsedBytes": 65309656,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 114.91000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.0580000000564,
"styleRecalcs": 31,
"styleRecalcDurationMs": 7.9830000000000005,
"layouts": 6,
"layoutDurationMs": 1.1060000000000003,
"taskDurationMs": 270.10499999999996,
"heapDeltaBytes": 4140032,
"heapUsedBytes": 71950396,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.562000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66442307692307,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.8759999999847,
"styleRecalcs": 31,
"styleRecalcDurationMs": 8.703000000000001,
"layouts": 6,
"layoutDurationMs": 1.092,
"taskDurationMs": 268.323,
"heapDeltaBytes": 4210840,
"heapUsedBytes": 71851948,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.207,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 532.7760000000126,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.379,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.892,
"heapDeltaBytes": -6326388,
"heapUsedBytes": 61290364,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 135.17800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 534.0579999999591,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.4080000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.003,
"heapDeltaBytes": -6352060,
"heapUsedBytes": 61116052,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 133.104,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1004.9589999999853,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 631.3969999999999,
"heapDeltaBytes": 11934524,
"heapUsedBytes": 92517288,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 52.816,
"eventListeners": 0,
"totalBlockingTimeMs": 376,
"frameDurationMs": 29.41176470588235,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 983.5030000000415,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.3109999999999,
"heapDeltaBytes": 15746828,
"heapUsedBytes": 84475604,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 46.35399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 371,
"frameDurationMs": 29.796969696969704,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 783.6660000000393,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.8589999999999,
"heapDeltaBytes": -7577944,
"heapUsedBytes": 90200320,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 117.02000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 785.1970000000392,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.8490000000001,
"heapDeltaBytes": -15465400,
"heapUsedBytes": 79186852,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 121.25599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7118.621999999959,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6230000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6267.321,
"heapDeltaBytes": 968864,
"heapUsedBytes": 85515584,
"domNodes": -143,
"jsHeapTotalBytes": -4591616,
"scriptDurationMs": 5063.505999999999,
"eventListeners": -82,
"totalBlockingTimeMs": 44,
"frameDurationMs": 25.415714285714284,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6812.4729999999545,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9310000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6170.812,
"heapDeltaBytes": 19619492,
"heapUsedBytes": 97506184,
"domNodes": -142,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 5046.633,
"eventListeners": -74,
"totalBlockingTimeMs": 40,
"frameDurationMs": 25.43432835820896,
"p95FrameDurationMs": 33.5
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7226.225999999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9389999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6676.075,
"heapDeltaBytes": 7404960,
"heapUsedBytes": 91728436,
"domNodes": -142,
"jsHeapTotalBytes": -2232320,
"scriptDurationMs": 5479.323,
"eventListeners": -74,
"totalBlockingTimeMs": 86,
"frameDurationMs": 26.433699633699632,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6582.564000000048,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9379999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6021.290000000001,
"heapDeltaBytes": 10892528,
"heapUsedBytes": 88919944,
"domNodes": -142,
"jsHeapTotalBytes": -5115904,
"scriptDurationMs": 4896.406,
"eventListeners": -74,
"totalBlockingTimeMs": 30,
"frameDurationMs": 25.222222222222218,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2008.4960000000365,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0269999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.71599999999995,
"heapDeltaBytes": -10378980,
"heapUsedBytes": 78192760,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.304999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.875999999963,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2459999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.918,
"heapDeltaBytes": -11146436,
"heapUsedBytes": 67374664,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 28.100999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2137.7290000000357,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1281.8049999999998,
"heapDeltaBytes": -19539404,
"heapUsedBytes": 68120492,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 709.94,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.8039999999173,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.075,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1204.4679999999998,
"heapDeltaBytes": -20111860,
"heapUsedBytes": 68611860,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 647.3330000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3190.4309999999896,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.969999999999999,
"layouts": 60,
"layoutDurationMs": 13.169,
"taskDurationMs": 1327.657,
"heapDeltaBytes": 3717360,
"heapUsedBytes": 83911724,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 636.9789999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3174.313999999981,
"styleRecalcs": 74,
"styleRecalcDurationMs": 12.897,
"layouts": 60,
"layoutDurationMs": 12.959,
"taskDurationMs": 1300.2240000000002,
"heapDeltaBytes": 3120128,
"heapUsedBytes": 83049644,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 622.623,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666315789473686,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2212.2000000000526,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.326000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1463.4839999999997,
"heapDeltaBytes": 4083180,
"heapUsedBytes": 71478292,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 768.9250000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793893129770993,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2230.376000000092,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.280999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1477.769,
"heapDeltaBytes": 8439020,
"heapUsedBytes": 75714292,
"domNodes": 0,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 781.6039999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.791666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.6610000000892,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.876,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.289,
"heapDeltaBytes": -9403284,
"heapUsedBytes": 79609620,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 28.15100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.0279999999111,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8589999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.883,
"heapDeltaBytes": -9598000,
"heapUsedBytes": 79349140,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.213000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.4379999999273,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.551,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.279,
"heapDeltaBytes": 9859672,
"heapUsedBytes": 74301188,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.02,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.5049999999856,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.2959999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.348,
"heapDeltaBytes": -11910476,
"heapUsedBytes": 57612852,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 113.39100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2011.1960000000408,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.198,
"heapDeltaBytes": -2550780,
"heapUsedBytes": 61236100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.260000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.6299999999965,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.476,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.32700000000006,
"heapDeltaBytes": 1246532,
"heapUsedBytes": 71798444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.895999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.536999999982,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.505999999999998,
"layouts": 16,
"layoutDurationMs": 4.032,
"taskDurationMs": 557.5369999999999,
"heapDeltaBytes": -5796820,
"heapUsedBytes": 63643796,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 77.685,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.8539999999111,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.254,
"layouts": 16,
"layoutDurationMs": 4.709,
"taskDurationMs": 568.3199999999999,
"heapDeltaBytes": 16546628,
"heapUsedBytes": 78353736,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 79.78699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 851.0410000000093,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.237999999999992,
"layouts": 5,
"layoutDurationMs": 10.245000000000001,
"taskDurationMs": 682.234,
"heapDeltaBytes": -688004,
"heapUsedBytes": 92802968,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 20.125000000000004,
"eventListeners": 2463,
"totalBlockingTimeMs": 84,
"frameDurationMs": 19.76511627906976,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8143.67500000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.449000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4284.8640000000005,
"heapDeltaBytes": -18120560,
"heapUsedBytes": 69888276,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2156.4269999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665848670756645,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8148.506999999995,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.177,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4221.5869999999995,
"heapDeltaBytes": -18482020,
"heapUsedBytes": 69738064,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2139.7509999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605316973415,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14430.32400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13702.023999999998,
"heapDeltaBytes": -45636288,
"heapUsedBytes": 185458316,
"domNodes": -3045,
"jsHeapTotalBytes": 13246464,
"scriptDurationMs": 200.611,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.100347826086956,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 14468.75399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13911.898,
"heapDeltaBytes": -44244944,
"heapUsedBytes": 180400496,
"domNodes": -3045,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 199.81400000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.686348122866896,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 17433.394000000022,
"styleRecalcs": 156,
"styleRecalcDurationMs": 14.585999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17003.296999999995,
"heapDeltaBytes": -32791924,
"heapUsedBytes": 183870080,
"domNodes": -3045,
"jsHeapTotalBytes": 5177344,
"scriptDurationMs": 682.9190000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.282407407407405,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17569.174999999974,
"styleRecalcs": 147,
"styleRecalcDurationMs": 14.167999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17109.839,
"heapDeltaBytes": -61720016,
"heapUsedBytes": 166510596,
"domNodes": -3045,
"jsHeapTotalBytes": 5148672,
"scriptDurationMs": 677.7729999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.95684803001877,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5277.219999999943,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.083,
"layouts": 20,
"layoutDurationMs": 20.758,
"taskDurationMs": 5225.249000000001,
"heapDeltaBytes": -12835620,
"heapUsedBytes": 215963204,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 83.71100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.094285714285714,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 5255.353000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.29100000000001,
"layouts": 20,
"layoutDurationMs": 21.219,
"taskDurationMs": 5176.586000000001,
"heapDeltaBytes": 8013080,
"heapUsedBytes": 221203912,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 83.93,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.88117647058823,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7366.237999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6975.551000000001,
"heapDeltaBytes": -21843960,
"heapUsedBytes": 180762548,
"domNodes": -3046,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 101.864,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.314089347079037,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7390.317999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7018.261,
"heapDeltaBytes": -23448328,
"heapUsedBytes": 181069504,
"domNodes": -3045,
"jsHeapTotalBytes": 4886528,
"scriptDurationMs": 104.41,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.45827586206897,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 119.03700000004847,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.576999999999998,
"layouts": 3,
"layoutDurationMs": 1.476,
"taskDurationMs": 70.87000000000002,
"heapDeltaBytes": 3952340,
"heapUsedBytes": 58453692,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.747000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 441.6200000000572,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.209999999999999,
"layouts": 4,
"layoutDurationMs": 1.7059999999999997,
"taskDurationMs": 93.22900000000001,
"heapDeltaBytes": 5528316,
"heapUsedBytes": 71876364,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.757,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 500.9830000000193,
"styleRecalcs": 78,
"styleRecalcDurationMs": 74.35300000000001,
"layouts": 76,
"layoutDurationMs": 17.636,
"taskDurationMs": 474.814,
"heapDeltaBytes": 14100156,
"heapUsedBytes": 95789064,
"domNodes": 76,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 178.348,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 517.4040000000559,
"styleRecalcs": 78,
"styleRecalcDurationMs": 75.871,
"layouts": 76,
"layoutDurationMs": 18.054000000000002,
"taskDurationMs": 484.07,
"heapDeltaBytes": -17644284,
"heapUsedBytes": 64521996,
"domNodes": 76,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 179.634,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1138.5780000000523,
"styleRecalcs": 78,
"styleRecalcDurationMs": 266.071,
"layouts": 76,
"layoutDurationMs": 23.174,
"taskDurationMs": 1124.343,
"heapDeltaBytes": 7318700,
"heapUsedBytes": 114577172,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 338.03900000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1063.7910000000375,
"styleRecalcs": 78,
"styleRecalcDurationMs": 234.51,
"layouts": 76,
"layoutDurationMs": 21.717,
"taskDurationMs": 1034.3629999999998,
"heapDeltaBytes": 6679312,
"heapUsedBytes": 113092080,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 308.848,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6640625,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2205 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1b0ddf2ef25caee1fb682ca2f08b352475983bdf
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21316 +/- ##
=============================================
Coverage ? 85.93%
=============================================
Files ? 2504
Lines ? 142881
Branches ? 36662
=============================================
Hits ? 122787
Misses ? 19708
Partials ? 386
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 2 |
Panel: 7/8 reviewers contributed findings.
Reviewers that did not contribute: gpt-5.6-sol-max:edge-case (error)
|
@mattmillerai closing this one because no environment serves |
ELI5
When someone adds or removes a row in a repeating group of settings on a shared workflow, the values in those rows now get saved and sent to everyone else. Before, the saved copy and other collaborators kept old values, so reloading showed something different from what was on screen.
Summary
Backport of #20992 and #21057 to
cloud/1.56. Prod symptom: after adding or removing DynamicGroup rows in a CRDT-bound workflow, the document and peers keep stale row values, and a reload shows different values than the canvas.Changes
git cherry-pick -x c449a01523 e10c38413d, applied without conflicts.widgetValueStore.announceValue, which emits aset_widgetintent with a widget's current value. Widgets created when rows are added get announced afterpublish().Review Focus
dynamicGroupWidget.ts:git merge-treeof this branch against [backport cloud/1.56] DynamicGroup stabilization fixes #21041's head reports no conflicts. The two can land in either order.Testing
pnpm typecheck:app: passes.vitest runondynamicGroupWidget.test.ts,widgetValueStore.test.tsanddocOpMinter.test.ts: 170/170 pass.origin/cloud/1.56, the 3 newdocOpMinterDynamicGroup tests fail. With the fix applied, they pass.set_widget/WidgetId/useWidgetValueStoredoc hits. None describe row-value minting. The upstream PRs changed no docs, and the ADR is the same onmain. The sweep stopped at its identifier limit, and the identifiers it skipped are test-local names.Provenance
cloud/1.56+needs-backportlabels to fix: mint field values for added DynamicGroup rows #20992/fix: mint shifted DynamicGroup row values after a middle-row removal #21057 and let the backport bot open the PR. I skipped that step, so I added no labels to those PRs.Residual
docOpMintertests.cloud/1.57label. Addcloud/1.56to them after this merges if release tracking relies on labels.