Skip to content

[backport cloud/1.56] fix: mint DynamicGroup row values on add and shifted removal (#20992, #21057) - #21316

Closed
mattmillerai wants to merge 2 commits into
cloud/1.56from
backport-cloud-1.56-dynamic-group-row-minting
Closed

mattmillerai wants to merge 2 commits into
cloud/1.56from
backport-cloud-1.56-dynamic-group-row-minting

Conversation

@mattmillerai

Copy link
Copy Markdown
Member

ELI5

When someone adds or removes a row in a repeating group of settings on a shared workflow, the values in those rows now get saved and sent to everyone else. Before, the saved copy and other collaborators kept old values, so reloading showed something different from what was on screen.

Summary

Backport of #20992 and #21057 to cloud/1.56. Prod symptom: after adding or removing DynamicGroup rows in a CRDT-bound workflow, the document and peers keep stale row values, and a reload shows different values than the canvas.

Changes

Review Focus

Testing

  • pnpm typecheck:app: passes.
  • vitest run on dynamicGroupWidget.test.ts, widgetValueStore.test.ts and docOpMinter.test.ts: 170/170 pass.
  • Red check: with the two source files reverted to origin/cloud/1.56, the 3 new docOpMinter DynamicGroup tests fail. With the fix applied, they pass.
  • eslint and oxfmt are clean on the changed files.
  • Doc-drift sweep: 24 references checked, 0 updated. I judged the DynamicGroup ADR (WIDGET-GROUP-0031) and the set_widget/WidgetId/useWidgetValueStore doc hits. None describe row-value minting. The upstream PRs changed no docs, and the ADR is the same on main. The sweep stopped at its identifier limit, and the identifiers it skipped are test-local names.

Provenance

Residual

## Summary

Adding a DynamicGroup row in a CRDT-bound workflow minted only the new
row count. The new row's field widgets start at template defaults, but
registering a widget emits no `set_widget` intent. The document keeps a
removed row's values hidden, so after remove-then-add it showed those
old values to followers and on reload, while the local canvas showed
defaults.

The DynamicGroup count setter now announces each newly created row
widget's value through a new `widgetValueStore.announceValue`, after the
count. That includes companion widgets such as `control_after_generate`.
These intents go through the existing `docOpMinter` gate, so they are
minted only for `local` edits in a bound workflow. Load, undo/redo
restores (`load` source) and remote frames (`agent-remote`) mint nothing
extra, and unbound workflows mint nothing.

Fixes #20914

## Verification

- New `docOpMinter.test.ts` > `DynamicGroup rows` tests: remove the last
row, then add one, mints the count ops plus `lora_name`, `seed` and
`seed.0` defaults. A row added by an `agent-remote` or `load` write
mints nothing. A row added while unbound mints nothing. The first test
fails on `main` and passes with the fix.
- `vitest run src/workbench/extensions/agent src/core/graph src/stores`:
247 files, 5047 passed.
- Typecheck, oxlint, eslint, oxfmt, knip and fallow audit pass through
the git hooks.

(cherry picked from commit c449a01)
…21057)

## Summary

In a doc-bound workflow, deleting a middle DynamicGroup row only minted
the row-count `set_widget`. The later rows were renamed locally, but
nothing was minted for the shifted `group.N.*` fields, so the document
and peers dropped the last row and kept the deleted row's values (3
rows, delete row 0: this tab shows `[r1, r2]`, the doc ends up `[r0,
r1]`).

Each serializable widget renamed by a row shift now announces its
current value (`announceValue`) under its new name. The minter still
mints only local writes, so remote and load removals mint nothing.

Stacked on #20992. Fixes
#20992 (comment)

## Review focus

- The shifted field `set_widget`s are minted before the count decrement.
The doc host resolves each register by stamp, so the order does not
change the final state.
- Follow-up, not in this PR: the removed trailing row's registers are
not cleared in the doc. A local regrow overwrites them (#20992 mints
every added field), but a remote count write that regrows the group
without field values could still bring back stale values.

## Tests

- Red: new `mints the shifted field values after a middle row is
removed` failed on the base branch. Only `set_widget loras 3 -> 2` was
minted, with no `loras.1.*` ops.
- Green: `pnpm -s vitest run src/core/graph
src/workbench/extensions/agent/crdt
src/stores/widgetValueStore.test.ts`: 89 files, 1375 passed, 1 expected
fail.
- Reverted only the implementation and confirmed the new test fails
again.
- Added `mints nothing for a row removed by a agent-remote/load write`.

(cherry picked from commit e10c384)
@mattmillerai
mattmillerai requested a review from a team as a code owner October 18, 2026 22:17
@mattmillerai mattmillerai added backport Backporting a PR onto a release candidate agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 18, 2026
@mattmillerai
mattmillerai requested review from a team as code owners October 18, 2026 22:17
@mattmillerai mattmillerai added backport Backporting a PR onto a release candidate agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 18, 2026
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 536698a9-7008-4a12-b29a-4533d1c209ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 6 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 33.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 374ms TBT · 84.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 43.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 160ms TBT · 80.8 MB heap
extension-clean-combined-draw: · 39.3 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 42ms TBT · 87.3 MB heap
extension-rgthree-prototype-draw: · 38.7 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 58ms TBT · 86.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
subgraph-transition-enter: · 50.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 84ms TBT · 88.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
vue-large-graph-idle: · 40.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 174.5 MB heap
vue-large-graph-pan: · 30.7 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 167.1 MB heap
vue-node-resize-workload: · 32.8 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 0ms TBT · 208.5 MB heap
vue-zoom-out-idle: · 39.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 172.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.4 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 322ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 72.2 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 71
canvas-mouse-sweep: task duration 607ms
canvas-mouse-sweep: script duration 113ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.4 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 8ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 269ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.6 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 15
dom-widget-clipping: task duration 369ms
dom-widget-clipping: script duration 134ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.4 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 30ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 625ms
dom-widget-order-dense-n200-w200-i120: script duration 50ms
dom-widget-order-dense-n200-w200-i120: TBT 374ms
dom-widget-order-dense-n200-w200-i120: heap used 84.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 23ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 373ms
dom-widget-order-sparse-n1000-w20-i120: script duration 119ms
dom-widget-order-sparse-n1000-w20-i120: TBT 160ms
dom-widget-order-sparse-n1000-w20-i120: heap used 80.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 25ms
extension-clean-combined-draw: p95 frame time 42ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 6219ms
extension-clean-combined-draw: script duration 5055ms
extension-clean-combined-draw: TBT 42ms
extension-clean-combined-draw: heap used 87.3 MB
extension-clean-combined-draw: DOM nodes -143
extension-clean-combined-draw: event listeners -78
extension-rgthree-prototype-draw: avg frame time 26ms
extension-rgthree-prototype-draw: p95 frame time 42ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 6349ms
extension-rgthree-prototype-draw: script duration 5188ms
extension-rgthree-prototype-draw: TBT 58ms
extension-rgthree-prototype-draw: heap used 86.1 MB
extension-rgthree-prototype-draw: DOM nodes -142
extension-rgthree-prototype-draw: event listeners -74
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 391ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.4 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1243ms
large-graph-pan: script duration 679ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 65.2 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 74
large-graph-zoom: task duration 1314ms
large-graph-zoom: script duration 630ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 79.6 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1471ms
legacy-node-drag: script duration 775ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 70.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 10
minimap-idle: task duration 395ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.8 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 314ms
subgraph-dom-widget-clipping: script duration 114ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 62.9 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 13
subgraph-idle: task duration 326ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.4 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 563ms
subgraph-mouse-sweep: script duration 79ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.7 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 682ms
subgraph-transition-enter: script duration 20ms
subgraph-transition-enter: TBT 84ms
subgraph-transition-enter: heap used 88.5 MB
subgraph-transition-enter: DOM nodes 14227
subgraph-transition-enter: event listeners 2463
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4253ms
viewport-pan-sweep: script duration 2148ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 66.6 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 25ms
vue-large-graph-idle: p95 frame time 50ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13807ms
vue-large-graph-idle: script duration 200ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 174.5 MB
vue-large-graph-idle: DOM nodes -3045
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 33ms
vue-large-graph-pan: p95 frame time 67ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 152
vue-large-graph-pan: task duration 17057ms
vue-large-graph-pan: script duration 680ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 167.1 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 30ms
vue-node-resize-workload: p95 frame time 58ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 60ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5201ms
vue-node-resize-workload: script duration 84ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 208.5 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 25ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6997ms
vue-zoom-out-idle: script duration 103ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.5 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 12ms
workflow-execution: layout count 4
workflow-execution: style recalc count 13
workflow-execution: task duration 82ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 62.1 MB
workflow-execution: DOM nodes 108
workflow-execution: event listeners 41
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 18ms
agent-composer-empty-conversation-typing: style recalc duration 75ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 479ms
agent-composer-empty-conversation-typing: script duration 179ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 76.4 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 22ms
agent-composer-long-conversation-typing: style recalc duration 250ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1079ms
agent-composer-long-conversation-typing: script duration 323ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 108.6 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-18T22:29:23.076Z",
  "gitSha": "260c69e08a07c9fbecd0538333c4eb1da7ee5a0a",
  "branch": "backport-cloud-1.56-dynamic-group-row-minting",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2021.0270000000037,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.952000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 315.801,
      "heapDeltaBytes": 962460,
      "heapUsedBytes": 69365612,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.414000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.800999999925,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.793,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.64899999999994,
      "heapDeltaBytes": 23202904,
      "heapUsedBytes": 82032260,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.653999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1675.5920000000515,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.062999999999999,
      "layouts": 12,
      "layoutDurationMs": 3.5959999999999996,
      "taskDurationMs": 601.7889999999999,
      "heapDeltaBytes": -2010972,
      "heapUsedBytes": 65598456,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 110.292,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1678.935000000024,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.306000000000001,
      "layouts": 12,
      "layoutDurationMs": 3.7480000000000007,
      "taskDurationMs": 612.271,
      "heapDeltaBytes": -2288364,
      "heapUsedBytes": 65309656,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 114.91000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663363,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1727.0580000000564,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 7.9830000000000005,
      "layouts": 6,
      "layoutDurationMs": 1.1060000000000003,
      "taskDurationMs": 270.10499999999996,
      "heapDeltaBytes": 4140032,
      "heapUsedBytes": 71950396,
      "domNodes": 53,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.562000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66442307692307,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1710.8759999999847,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 8.703000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.092,
      "taskDurationMs": 268.323,
      "heapDeltaBytes": 4210840,
      "heapUsedBytes": 71851948,
      "domNodes": 53,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.207,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 532.7760000000126,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.379,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.892,
      "heapDeltaBytes": -6326388,
      "heapUsedBytes": 61290364,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 135.17800000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668750000000003,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 534.0579999999591,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.4080000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.003,
      "heapDeltaBytes": -6352060,
      "heapUsedBytes": 61116052,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 133.104,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1004.9589999999853,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 631.3969999999999,
      "heapDeltaBytes": 11934524,
      "heapUsedBytes": 92517288,
      "domNodes": 0,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 52.816,
      "eventListeners": 0,
      "totalBlockingTimeMs": 376,
      "frameDurationMs": 29.41176470588235,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 983.5030000000415,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 619.3109999999999,
      "heapDeltaBytes": 15746828,
      "heapUsedBytes": 84475604,
      "domNodes": 0,
      "jsHeapTotalBytes": 3309568,
      "scriptDurationMs": 46.35399999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 371,
      "frameDurationMs": 29.796969696969704,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 783.6660000000393,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 369.8589999999999,
      "heapDeltaBytes": -7577944,
      "heapUsedBytes": 90200320,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 117.02000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 160,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 785.1970000000392,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.8490000000001,
      "heapDeltaBytes": -15465400,
      "heapUsedBytes": 79186852,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 121.25599999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 23.03823529411765,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7118.621999999959,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.6230000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6267.321,
      "heapDeltaBytes": 968864,
      "heapUsedBytes": 85515584,
      "domNodes": -143,
      "jsHeapTotalBytes": -4591616,
      "scriptDurationMs": 5063.505999999999,
      "eventListeners": -82,
      "totalBlockingTimeMs": 44,
      "frameDurationMs": 25.415714285714284,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6812.4729999999545,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.9310000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6170.812,
      "heapDeltaBytes": 19619492,
      "heapUsedBytes": 97506184,
      "domNodes": -142,
      "jsHeapTotalBytes": 389120,
      "scriptDurationMs": 5046.633,
      "eventListeners": -74,
      "totalBlockingTimeMs": 40,
      "frameDurationMs": 25.43432835820896,
      "p95FrameDurationMs": 33.5
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7226.225999999997,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.9389999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6676.075,
      "heapDeltaBytes": 7404960,
      "heapUsedBytes": 91728436,
      "domNodes": -142,
      "jsHeapTotalBytes": -2232320,
      "scriptDurationMs": 5479.323,
      "eventListeners": -74,
      "totalBlockingTimeMs": 86,
      "frameDurationMs": 26.433699633699632,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6582.564000000048,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.9379999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6021.290000000001,
      "heapDeltaBytes": 10892528,
      "heapUsedBytes": 88919944,
      "domNodes": -142,
      "jsHeapTotalBytes": -5115904,
      "scriptDurationMs": 4896.406,
      "eventListeners": -74,
      "totalBlockingTimeMs": 30,
      "frameDurationMs": 25.222222222222218,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.4960000000365,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.0269999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 393.71599999999995,
      "heapDeltaBytes": -10378980,
      "heapUsedBytes": 78192760,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 29.304999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.875999999963,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.2459999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.918,
      "heapDeltaBytes": -11146436,
      "heapUsedBytes": 67374664,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 28.100999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2137.7290000000357,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.033,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1281.8049999999998,
      "heapDeltaBytes": -19539404,
      "heapUsedBytes": 68120492,
      "domNodes": 0,
      "jsHeapTotalBytes": 561152,
      "scriptDurationMs": 709.94,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66640625,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2134.8039999999173,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.075,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1204.4679999999998,
      "heapDeltaBytes": -20111860,
      "heapUsedBytes": 68611860,
      "domNodes": 0,
      "jsHeapTotalBytes": 561152,
      "scriptDurationMs": 647.3330000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66640625,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3190.4309999999896,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 12.969999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.169,
      "taskDurationMs": 1327.657,
      "heapDeltaBytes": 3717360,
      "heapUsedBytes": 83911724,
      "domNodes": 24,
      "jsHeapTotalBytes": 561152,
      "scriptDurationMs": 636.9789999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665968586387432,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3174.313999999981,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 12.897,
      "layouts": 60,
      "layoutDurationMs": 12.959,
      "taskDurationMs": 1300.2240000000002,
      "heapDeltaBytes": 3120128,
      "heapUsedBytes": 83049644,
      "domNodes": 24,
      "jsHeapTotalBytes": 299008,
      "scriptDurationMs": 622.623,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666315789473686,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2212.2000000000526,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 6.326000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1463.4839999999997,
      "heapDeltaBytes": 4083180,
      "heapUsedBytes": 71478292,
      "domNodes": 0,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 768.9250000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.793893129770993,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2230.376000000092,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.280999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1477.769,
      "heapDeltaBytes": 8439020,
      "heapUsedBytes": 75714292,
      "domNodes": 0,
      "jsHeapTotalBytes": 1503232,
      "scriptDurationMs": 781.6039999999999,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.791666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.6610000000892,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.876,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 393.289,
      "heapDeltaBytes": -9403284,
      "heapUsedBytes": 79609620,
      "domNodes": 0,
      "jsHeapTotalBytes": 299008,
      "scriptDurationMs": 28.15100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.0279999999111,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.8589999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.883,
      "heapDeltaBytes": -9598000,
      "heapUsedBytes": 79349140,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 29.213000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 514.4379999999273,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 5.551,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 308.279,
      "heapDeltaBytes": 9859672,
      "heapUsedBytes": 74301188,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 114.02,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667741935483864,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 514.5049999999856,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.2959999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 319.348,
      "heapDeltaBytes": -11910476,
      "heapUsedBytes": 57612852,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 113.39100000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66451612903227,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.1960000000408,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.117,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 324.198,
      "heapDeltaBytes": -2550780,
      "heapUsedBytes": 61236100,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.260000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.6299999999965,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.476,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.32700000000006,
      "heapDeltaBytes": 1246532,
      "heapUsedBytes": 71798444,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.895999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1679.536999999982,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.505999999999998,
      "layouts": 16,
      "layoutDurationMs": 4.032,
      "taskDurationMs": 557.5369999999999,
      "heapDeltaBytes": -5796820,
      "heapUsedBytes": 63643796,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 77.685,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66534653465347,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.8539999999111,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 14.254,
      "layouts": 16,
      "layoutDurationMs": 4.709,
      "taskDurationMs": 568.3199999999999,
      "heapDeltaBytes": 16546628,
      "heapUsedBytes": 78353736,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 79.78699999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66534653465347,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 851.0410000000093,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 22.237999999999992,
      "layouts": 5,
      "layoutDurationMs": 10.245000000000001,
      "taskDurationMs": 682.234,
      "heapDeltaBytes": -688004,
      "heapUsedBytes": 92802968,
      "domNodes": 14227,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 20.125000000000004,
      "eventListeners": 2463,
      "totalBlockingTimeMs": 84,
      "frameDurationMs": 19.76511627906976,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8143.67500000003,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 32.449000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4284.8640000000005,
      "heapDeltaBytes": -18120560,
      "heapUsedBytes": 69888276,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2156.4269999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665848670756645,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8148.506999999995,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 34.177,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4221.5869999999995,
      "heapDeltaBytes": -18482020,
      "heapUsedBytes": 69738064,
      "domNodes": 0,
      "jsHeapTotalBytes": 1085440,
      "scriptDurationMs": 2139.7509999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66605316973415,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14430.32400000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13702.023999999998,
      "heapDeltaBytes": -45636288,
      "heapUsedBytes": 185458316,
      "domNodes": -3045,
      "jsHeapTotalBytes": 13246464,
      "scriptDurationMs": 200.611,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.100347826086956,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14468.75399999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13911.898,
      "heapDeltaBytes": -44244944,
      "heapUsedBytes": 180400496,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 199.81400000000002,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.686348122866896,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17433.394000000022,
      "styleRecalcs": 156,
      "styleRecalcDurationMs": 14.585999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17003.296999999995,
      "heapDeltaBytes": -32791924,
      "heapUsedBytes": 183870080,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5177344,
      "scriptDurationMs": 682.9190000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.282407407407405,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17569.174999999974,
      "styleRecalcs": 147,
      "styleRecalcDurationMs": 14.167999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17109.839,
      "heapDeltaBytes": -61720016,
      "heapUsedBytes": 166510596,
      "domNodes": -3045,
      "jsHeapTotalBytes": 5148672,
      "scriptDurationMs": 677.7729999999999,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.95684803001877,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5277.219999999943,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 59.083,
      "layouts": 20,
      "layoutDurationMs": 20.758,
      "taskDurationMs": 5225.249000000001,
      "heapDeltaBytes": -12835620,
      "heapUsedBytes": 215963204,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 83.71100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.094285714285714,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5255.353000000014,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.29100000000001,
      "layouts": 20,
      "layoutDurationMs": 21.219,
      "taskDurationMs": 5176.586000000001,
      "heapDeltaBytes": 8013080,
      "heapUsedBytes": 221203912,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 83.93,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.88117647058823,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7366.237999999953,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6975.551000000001,
      "heapDeltaBytes": -21843960,
      "heapUsedBytes": 180762548,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8146944,
      "scriptDurationMs": 101.864,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.314089347079037,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7390.317999999979,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7018.261,
      "heapDeltaBytes": -23448328,
      "heapUsedBytes": 181069504,
      "domNodes": -3045,
      "jsHeapTotalBytes": 4886528,
      "scriptDurationMs": 104.41,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.45827586206897,
      "p95FrameDurationMs": 50
    },
    {
      "name": "workflow-execution",
      "durationMs": 119.03700000004847,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.576999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.476,
      "taskDurationMs": 70.87000000000002,
      "heapDeltaBytes": 3952340,
      "heapUsedBytes": 58453692,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.747000000000002,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.671428571428546,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 441.6200000000572,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 13.209999999999999,
      "layouts": 4,
      "layoutDurationMs": 1.7059999999999997,
      "taskDurationMs": 93.22900000000001,
      "heapDeltaBytes": 5528316,
      "heapUsedBytes": 71876364,
      "domNodes": 99,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.757,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 500.9830000000193,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 74.35300000000001,
      "layouts": 76,
      "layoutDurationMs": 17.636,
      "taskDurationMs": 474.814,
      "heapDeltaBytes": 14100156,
      "heapUsedBytes": 95789064,
      "domNodes": 76,
      "jsHeapTotalBytes": 14680064,
      "scriptDurationMs": 178.348,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66451612903224,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 517.4040000000559,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 75.871,
      "layouts": 76,
      "layoutDurationMs": 18.054000000000002,
      "taskDurationMs": 484.07,
      "heapDeltaBytes": -17644284,
      "heapUsedBytes": 64521996,
      "domNodes": 76,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 179.634,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66451612903227,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1138.5780000000523,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 266.071,
      "layouts": 76,
      "layoutDurationMs": 23.174,
      "taskDurationMs": 1124.343,
      "heapDeltaBytes": 7318700,
      "heapUsedBytes": 114577172,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 338.03900000000004,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1063.7910000000375,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 234.51,
      "layouts": 76,
      "layoutDurationMs": 21.717,
      "taskDurationMs": 1034.3629999999998,
      "heapDeltaBytes": 6679312,
      "heapUsedBytes": 113092080,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 308.848,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6640625,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Line coverage: 64.2%

Coverage totals
Metric Covered Total Pct
Lines 54425 84749 64.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.4% 1180
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.7% 374
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/stores/teamWorkspaceStore.ts 39.2% 284
src/LGraph.ts 79.0% 272
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2205 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2183 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/18/2026, 10:19:37 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 1b0ddf2ef25caee1fb682ca2f08b352475983bdf

Full docs: ADR-DEVEX-LINT-0015

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 18, 2026
@github-actions
github-actions Bot requested a review from thedatalife October 18, 2026 22:18
@codecov

codecov Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.56   #21316   +/-   ##
=============================================
  Coverage              ?   85.93%           
=============================================
  Files                 ?     2504           
  Lines                 ?   142881           
  Branches              ?    36662           
=============================================
  Hits                  ?   122787           
  Misses                ?    19708           
  Partials              ?      386           
Flag Coverage Δ
e2e 64.12% <0.00%> (?)
unit 83.10% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/core/graph/widgets/dynamicGroupWidget.ts 93.46% <100.00%> (ø)
src/stores/widgetValueStore.ts 96.21% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 5 finding(s).

Severity Count
🟡 Medium 3
🟢 Low 2

Panel: 7/8 reviewers contributed findings.

Reviewers that did not contribute: gpt-5.6-sol-max:edge-case (error)

Comment thread src/stores/widgetValueStore.ts Resolved
Comment thread src/stores/widgetValueStore.ts Resolved
@thedatalife

Copy link
Copy Markdown
Contributor

@mattmillerai closing this one because no environment serves cloud/1.56 any more (prod is on 1.57, staging on 1.58). Both fixes already reached cloud/1.57 through #21072 and #21088. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-coded Opened by the agent-work code loop backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants