Repository navigation
[backport core/1.57] FE-1908 / DES-1033 fix(billing): offer hosted checkout when top-up has no default payment method (#21180) - #21218
Conversation
…s no default payment method (#21180) Consolidated-rail top-up now recovers from `NO_PAYMENT_METHOD` by offering Stripe-hosted Checkout for the same amount instead of ending on an error toast. Supersedes the copy change in #21171. **Why.** Off-session top-up (`POST /api/billing/topup`) is the only purchase path once a workspace leaves `legacy_stripe`. A workspace without a Stripe invoice default gets a dead-end toast and cannot buy credits at all. **Root cause (backend, confirmed on BE-5732).** `CreateTopup` charges only the customer's live Stripe `invoice_settings.default_payment_method`. A card saved only on the subscription, or merely attached, does not count, and the resolver deliberately does not promote one. `can_top_up` does not cover payment-method readiness: capabilities are UI guidance, so a `can_top_up: true` workspace can still be refused. **How.** - On a definitive `NO_PAYMENT_METHOD` refusal, the confirm step shows an inline hint and swaps **Pay** for **Continue to checkout**. Every other refusal keeps its existing toast. The refusal happens before any billing operation is reserved, so this cannot start a second payment for an in-flight purchase. - **Continue to checkout** calls the existing hosted endpoint `POST /api/billing/topup/checkout` with the selected amount and a `return_url` chosen by `topupCheckoutReturnUrl`: cloud web returns to `location.href`; Desktop, Desktop 2 and local web return to billing-web's neutral `/return/topup` page (#21199, renamed in #21205), because their own origin is not an allowed return host. The billing-web origin comes from `billing_web_url`, else from the connected Cloud environment (`billing.comfy.org` / `stagingbilling.comfy.org` / `testbilling.comfy.org`), since a local `/api/features` has none. If no origin resolves, checkout is not started. It goes through `sdk.topup.createHostedTopupCheckout` on the SDK rail and a new `workspaceApi.createTopupCheckout` on the legacy rail, so issue and recovery stay on one rail. It then sets the pending top-up marker so the balance refreshes on return, and opens Checkout. On Desktop the URL goes to the system browser through the host's popup handler. - Per DES review: a blocked checkout tab switches the dialog to a "Checkout didn't open" screen with an **Open checkout** retry (a fresh click) instead of navigating the app away, and a checkout that fails to open shows "The payment page couldn't open. Nothing was charged. Try again." inline instead of a Purchase Failed toast. - No new capability field: the hosted endpoint has no payment-method precondition, no rail branch and no flag gate, so a `can_top_up_hosted_checkout` would always equal `can_top_up` (agreed on FE-1908). - `noPaymentMethodError` is replaced by `noPaymentMethodCheckoutHint`: "This workspace has no card saved for one-click top-ups. Pay on a checkout page instead." It no longer points to Billing & invoices, because the generic portal does not set an invoice default. **Set a default card** (`flow_type: payment_method_update`, cloud#13970) follows once that flow is live in production. Linear: FE-1908, DES-1033 - Comfy Desktop 1.1.7 (Desktop 2) pointed at this branch (`dev:cloud`, testcloud, SDK rail), with `NO_PAYMENT_METHOD` stubbed on `POST /api/billing/topup`: the refused screen offers Continue to checkout; `POST /api/billing/topup/checkout` is sent with `return_url=https://testbilling.comfy.org/return/topup`; `window.open(checkout.comfy.org/...)` is handed to the system browser and the dialog closes without the blocked screen; a sandbox test-card payment lands on the neutral return page; switching back to the app fires `focus`, which refetches `/api/billing/balance` and moves the balance from 90,909 to 101,459 (+10,550). - Local e2e `topUpNoPaymentMethod.spec.ts` against a local backend: passed (local build sends the billing-web return page). - `topupCheckoutReturnUrl.test.ts`: cloud web, server origin, prefixed origin, each environment fallback, unresolved. - `pnpm exec vitest run` on `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts`, `useTopupOperation.test.ts`, `billingSdkStore.test.ts`: 181 passed. - New: checkout opens for the refused amount and the marker is set (legacy rail); checkout failure keeps the dialog open with an error; other refusals do not offer checkout; SDK rail routes through `createHostedTopupCheckout`; hosted-checkout failure projection. - `oxfmt`, `oxlint --type-aware`, `eslint`, server-fact gate, `typecheck:app` clean. <table> <tr><th>AS IS</th><th>TO BE</th></tr> <tr> <td> https://github.com/user-attachments/assets/6e32d1f8-32ae-4898-9b17-d88d4c50c98d </td> <td> https://github.com/user-attachments/assets/bf51da8b-508b-40ae-92a9-53c9fb1f0570 </td> </tr> <tr> <td>main build in Comfy Desktop 2: Pay ends on a "Purchase Failed" toast that points at a Manage billing button that does not exist.</td> <td>This PR in Comfy Desktop 2: refused, Continue to checkout, Stripe sandbox checkout in the system browser, test-card payment, billing-web return page, and back in the app the balance goes from 101,459 to 112,009.<br><br>The return page in this recording still shows the old title; #21205 renames it to "Return to ComfyUI" at <code>/return/topup</code>.</td> </tr> </table> | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Fix "Manage billing" copy | FE-1908 | #21171 | Superseded by this PR | | **Hosted checkout recovery on `NO_PAYMENT_METHOD`** | **FE-1908 / DES-1033** | **this PR** | **In review** | | Migration gate reads the live Stripe invoice default, not the stored field | BE-20139 follow-up | – | Proposed | | Neutral billing-web return page | FE-3464 | #21199 | Merged | | Generic return path and title (`/return/topup`, "Return to ComfyUI") | FE-3464 | #21205 | In review | | Test/staging return hosts | – | Comfy-Org/cloud#13964 | Merged | | Set a default card (`payment_method_update`) | BE-21143 | Comfy-Org/cloud#13970 | Merged, not in prod | ```mermaid graph LR A["PR 21171: copy fix"] -.->|"superseded"| B["This PR: hosted checkout recovery"] C["BE: migration gate uses live invoice default"] --> D["Fewer NO_PAYMENT_METHOD refusals"] B --> D E["PR 21199: billing-web return page"] --> B style B fill:#f9d71c,stroke:#333,stroke-width:2px ``` (cherry picked from commit fe4189d)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-17T03:50:00.180Z",
"gitSha": "6a582db4278782a5ba5dd9278359f114a519f333",
"branch": "backport-21180-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.537000000023,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1009999999999995,
"layouts": 10,
"layoutDurationMs": 2.488,
"taskDurationMs": 480.56699999999995,
"heapDeltaBytes": -891316,
"heapUsedBytes": 74348752,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.997000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.136999999986,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8719999999999999,
"layouts": 10,
"layoutDurationMs": 2.164,
"taskDurationMs": 419.586,
"heapDeltaBytes": 3418936,
"heapUsedBytes": 78592672,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 7.521,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.5969999999793,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.947,
"layouts": 9,
"layoutDurationMs": 1.8940000000000001,
"taskDurationMs": 723.525,
"heapDeltaBytes": 15171924,
"heapUsedBytes": 81404044,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 129.743,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1958.786000000032,
"styleRecalcs": 83,
"styleRecalcDurationMs": 10.762,
"layouts": 11,
"layoutDurationMs": 2.2079999999999997,
"taskDurationMs": 850.646,
"heapDeltaBytes": -8240536,
"heapUsedBytes": 66641748,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 108.553,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.357000000031,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.489,
"layouts": 12,
"layoutDurationMs": 2.534,
"taskDurationMs": 326.02,
"heapDeltaBytes": -4523296,
"heapUsedBytes": 70827364,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.085,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.739999999926,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.6510000000000002,
"layouts": 11,
"layoutDurationMs": 2.121,
"taskDurationMs": 304.74100000000004,
"heapDeltaBytes": 18345376,
"heapUsedBytes": 84650776,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.369,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 591.088999999954,
"styleRecalcs": 13,
"styleRecalcDurationMs": 1.5719999999999996,
"layouts": 8,
"layoutDurationMs": 1.575,
"taskDurationMs": 419.203,
"heapDeltaBytes": 3899104,
"heapUsedBytes": 79145376,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 133.608,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.142857142857142,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 601.1819999999943,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.0020000000000002,
"layouts": 10,
"layoutDurationMs": 1.929,
"taskDurationMs": 416.136,
"heapDeltaBytes": 1970380,
"heapUsedBytes": 76993292,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 125.666,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1148.5509999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.6940000000001,
"heapDeltaBytes": -11206516,
"heapUsedBytes": 81255452,
"domNodes": -192,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 51.76100000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 469,
"frameDurationMs": 31.08108108108108,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1097.0879999999283,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.9339999999999,
"heapDeltaBytes": -3293540,
"heapUsedBytes": 81225272,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 45.46399999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 420,
"frameDurationMs": 29.72972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 760.3819999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.7320000000001,
"heapDeltaBytes": -5032632,
"heapUsedBytes": 75527520,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 115.97899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 147,
"frameDurationMs": 23.230303030303013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 744.591000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.28499999999985,
"heapDeltaBytes": -5211560,
"heapUsedBytes": 76340904,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 101.94600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 129,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8923.922000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.18599999999999953,
"layouts": 1,
"layoutDurationMs": 0.17599999999999993,
"taskDurationMs": 7984.400000000001,
"heapDeltaBytes": 9369852,
"heapUsedBytes": 96953476,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 6223.266,
"eventListeners": -68,
"totalBlockingTimeMs": 198,
"frameDurationMs": 27.350613496932517,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7303.829000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.17299999999999954,
"layouts": 1,
"layoutDurationMs": 0.21600000000000005,
"taskDurationMs": 6554.027999999999,
"heapDeltaBytes": 19234784,
"heapUsedBytes": 96563020,
"domNodes": -258,
"jsHeapTotalBytes": 10088448,
"scriptDurationMs": 5426.834,
"eventListeners": -68,
"totalBlockingTimeMs": 86,
"frameDurationMs": 25.258477508650515,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7911.395999999968,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2149999999999999,
"layouts": 1,
"layoutDurationMs": 0.209,
"taskDurationMs": 6983.872,
"heapDeltaBytes": 12836584,
"heapUsedBytes": 100610016,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 5418.879000000001,
"eventListeners": -64,
"totalBlockingTimeMs": 119,
"frameDurationMs": 25.13142857142857,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6182.811000000015,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4520000000000001,
"layouts": 2,
"layoutDurationMs": 0.6859999999999999,
"taskDurationMs": 5448.387000000001,
"heapDeltaBytes": -1848380,
"heapUsedBytes": 97670608,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 4407.42,
"eventListeners": -68,
"totalBlockingTimeMs": 41,
"frameDurationMs": 25.134552845528454,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 225.908000000004,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.726999999999999,
"layouts": 12,
"layoutDurationMs": 3.129,
"taskDurationMs": 162.708,
"heapDeltaBytes": -8047804,
"heapUsedBytes": 79138432,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.245,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.65999999999999,
"p95FrameDurationMs": 66.59999999999991
},
{
"name": "large-combo-open",
"durationMs": 176.22299999999314,
"styleRecalcs": 22,
"styleRecalcDurationMs": 12.427,
"layouts": 11,
"layoutDurationMs": 2.65,
"taskDurationMs": 130.113,
"heapDeltaBytes": -8073324,
"heapUsedBytes": 78913992,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 6.881,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.837500000000034,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2010.520999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6049999999999998,
"layouts": 8,
"layoutDurationMs": 1.8210000000000002,
"taskDurationMs": 430.94100000000003,
"heapDeltaBytes": -2396184,
"heapUsedBytes": 77040680,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 26.596999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.735999999938,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.3299999999999996,
"layouts": 8,
"layoutDurationMs": 1.5399999999999998,
"taskDurationMs": 519.604,
"heapDeltaBytes": -3407696,
"heapUsedBytes": 75985336,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 20.473,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2183.3440000000337,
"styleRecalcs": 68,
"styleRecalcDurationMs": 3.72,
"layouts": 7,
"layoutDurationMs": 1.3220000000000003,
"taskDurationMs": 1330.973,
"heapDeltaBytes": -26862292,
"heapUsedBytes": 70897808,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 602.607,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66641221374046,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2282.3680000000195,
"styleRecalcs": 68,
"styleRecalcDurationMs": 3.443,
"layouts": 7,
"layoutDurationMs": 1.3639999999999999,
"taskDurationMs": 1255.362,
"heapDeltaBytes": -9927088,
"heapUsedBytes": 70677100,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 568.1670000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788235294117644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3291.7099999999664,
"styleRecalcs": 73,
"styleRecalcDurationMs": 6.007,
"layouts": 66,
"layoutDurationMs": 9.523,
"taskDurationMs": 1483.8100000000002,
"heapDeltaBytes": -22521244,
"heapUsedBytes": 76836436,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 610.657,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75128205128205,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3242.2010000000228,
"styleRecalcs": 73,
"styleRecalcDurationMs": 5.308999999999999,
"layouts": 67,
"layoutDurationMs": 8.290000000000001,
"taskDurationMs": 1307.894,
"heapDeltaBytes": -3046640,
"heapUsedBytes": 74798416,
"domNodes": -234,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 540.9529999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66546391752577,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2373.921999999993,
"styleRecalcs": 45,
"styleRecalcDurationMs": 3.169,
"layouts": 5,
"layoutDurationMs": 1.0030000000000001,
"taskDurationMs": 1543.641,
"heapDeltaBytes": 3152488,
"heapUsedBytes": 81251244,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 720.198,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.904285714285713,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2262.1849999999313,
"styleRecalcs": 44,
"styleRecalcDurationMs": 2.576,
"layouts": 5,
"layoutDurationMs": 0.7580000000000002,
"taskDurationMs": 1395.5579999999998,
"heapDeltaBytes": 2690996,
"heapUsedBytes": 86500008,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 647.473,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78962962962963,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2038.379999999961,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.6000000000000008,
"layouts": 9,
"layoutDurationMs": 1.9060000000000001,
"taskDurationMs": 409.15299999999996,
"heapDeltaBytes": -2412524,
"heapUsedBytes": 79395524,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 26.383000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.8810000000321,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.385,
"layouts": 8,
"layoutDurationMs": 1.6340000000000001,
"taskDurationMs": 512.9300000000001,
"heapDeltaBytes": -2312700,
"heapUsedBytes": 75660144,
"domNodes": -258,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 20.338,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 547.0230000000242,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.3420000000000005,
"layouts": 9,
"layoutDurationMs": 1.58,
"taskDurationMs": 330.27299999999997,
"heapDeltaBytes": 3235600,
"heapUsedBytes": 80016180,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 105.731,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.9069999999901,
"styleRecalcs": 47,
"styleRecalcDurationMs": 3.262,
"layouts": 10,
"layoutDurationMs": 1.8709999999999998,
"taskDurationMs": 324.666,
"heapDeltaBytes": -1083428,
"heapUsedBytes": 75790676,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 103.575,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.9050000000034,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.8120000000000003,
"layouts": 10,
"layoutDurationMs": 2.0229999999999997,
"taskDurationMs": 441.25800000000004,
"heapDeltaBytes": 22320492,
"heapUsedBytes": 89616684,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.529000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.592000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 1.5970000000000004,
"layouts": 9,
"layoutDurationMs": 1.588,
"taskDurationMs": 437.8109999999999,
"heapDeltaBytes": 22445404,
"heapUsedBytes": 89685620,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.631999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1940.420999999958,
"styleRecalcs": 85,
"styleRecalcDurationMs": 12.346,
"layouts": 10,
"layoutDurationMs": 1.931,
"taskDurationMs": 754.046,
"heapDeltaBytes": 11720660,
"heapUsedBytes": 78935072,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 78.082,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1991.8279999999413,
"styleRecalcs": 88,
"styleRecalcDurationMs": 11.033000000000001,
"layouts": 9,
"layoutDurationMs": 1.8020000000000003,
"taskDurationMs": 858.256,
"heapDeltaBytes": 11689132,
"heapUsedBytes": 78652900,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 78.845,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.9410000000125,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.797,
"layouts": 5,
"layoutDurationMs": 11.510000000000002,
"taskDurationMs": 680.7289999999999,
"heapDeltaBytes": 7260220,
"heapUsedBytes": 101534828,
"domNodes": 15953,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 18.951000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 138,
"frameDurationMs": 20.92790697674418,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8225.871000000041,
"styleRecalcs": 250,
"styleRecalcDurationMs": 10.911999999999997,
"layouts": 8,
"layoutDurationMs": 1.5000000000000002,
"taskDurationMs": 4083.7630000000004,
"heapDeltaBytes": 5886564,
"heapUsedBytes": 84878972,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2034.3550000000002,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.309000000054,
"styleRecalcs": 252,
"styleRecalcDurationMs": 10.113999999999999,
"layouts": 9,
"layoutDurationMs": 1.7510000000000001,
"taskDurationMs": 4342.115000000001,
"heapDeltaBytes": -13274240,
"heapUsedBytes": 83308100,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 1892.609,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665858585858587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16816.418999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15941.514000000001,
"heapDeltaBytes": -25875516,
"heapUsedBytes": 265105176,
"domNodes": -307,
"jsHeapTotalBytes": 12312576,
"scriptDurationMs": 234.23400000000004,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.71675213675214,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "vue-large-graph-idle",
"durationMs": 10749.303999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9666.43,
"heapDeltaBytes": -26289876,
"heapUsedBytes": 268881980,
"domNodes": -3330,
"jsHeapTotalBytes": -4206592,
"scriptDurationMs": 118.973,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.127487352445193,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 18758.38900000002,
"styleRecalcs": 160,
"styleRecalcDurationMs": 11.66700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18278.555,
"heapDeltaBytes": -10859180,
"heapUsedBytes": 265441080,
"domNodes": -3330,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 696.6009999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 33.00915492957746,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17991.457999999966,
"styleRecalcs": 163,
"styleRecalcDurationMs": 10.762999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17556.912,
"heapDeltaBytes": -21821520,
"heapUsedBytes": 269077536,
"domNodes": -3330,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 640.5609999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.68873239436619,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 4030.7699999999613,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.682999999999986,
"layouts": 20,
"layoutDurationMs": 18.453999999999997,
"taskDurationMs": 3900.294,
"heapDeltaBytes": 17363160,
"heapUsedBytes": 298112448,
"domNodes": -307,
"jsHeapTotalBytes": 30662656,
"scriptDurationMs": 57.48500000000001,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.44825581395349,
"p95FrameDurationMs": 49.900000000000546
},
{
"name": "vue-node-resize-workload",
"durationMs": 3834.609999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.732,
"layouts": 20,
"layoutDurationMs": 16.88200000000001,
"taskDurationMs": 3637.3149999999996,
"heapDeltaBytes": -10602964,
"heapUsedBytes": 292858236,
"domNodes": -3330,
"jsHeapTotalBytes": 30662656,
"scriptDurationMs": 53.419999999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.95269461077844,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7651.287000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7268.5909999999985,
"heapDeltaBytes": 349052,
"heapUsedBytes": 258998968,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 79.39000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.930847457627113,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7287.064999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6966.472,
"heapDeltaBytes": -8655016,
"heapUsedBytes": 267617168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 67.34100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.11379310344827,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 466.3360000000125,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.149999999999999,
"layouts": 14,
"layoutDurationMs": 6.593,
"taskDurationMs": 130.72699999999998,
"heapDeltaBytes": -12911124,
"heapUsedBytes": 70687996,
"domNodes": 126,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.467,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.43099999996684,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.948,
"layouts": 8,
"layoutDurationMs": 2.443,
"taskDurationMs": 72.235,
"heapDeltaBytes": -15461376,
"heapUsedBytes": 68437696,
"domNodes": 117,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 4.632000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 324.70200000000204,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.083,
"layouts": 76,
"layoutDurationMs": 13.962,
"taskDurationMs": 282.327,
"heapDeltaBytes": -9801404,
"heapUsedBytes": 84951556,
"domNodes": 4,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 127.62599999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 317.5370000000157,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8260000000000001,
"layouts": 76,
"layoutDurationMs": 12.889,
"taskDurationMs": 282.74999999999994,
"heapDeltaBytes": -16418356,
"heapUsedBytes": 69886672,
"domNodes": 4,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 130.53300000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 346.0489999999936,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9009999999999998,
"layouts": 76,
"layoutDurationMs": 12.641,
"taskDurationMs": 298.497,
"heapDeltaBytes": -6482728,
"heapUsedBytes": 108364736,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 112.10300000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 356.55400000007376,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.77,
"layouts": 76,
"layoutDurationMs": 13.586,
"taskDurationMs": 324.03700000000003,
"heapDeltaBytes": 9385660,
"heapUsedBytes": 161836740,
"domNodes": 4,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 120.914,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (34 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5572a657668ed6ea1a2c8aabe6f6448642f82347
Full docs: ADR-DEVEX-LINT-0015 |
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity check against the merged original (#21180), per branch: diffed sorted +/- lines against the original, then diffed the resulting files for every mismatch rather than calling a line mismatch a failure on its own.
Every remaining difference traces to this branch's pre-existing state (before that PR), not to a content loss:
TopUpCreditsDialogContentWorkspace.vueuses<h2>for step titles here (vs<DialogTitle>on main) — confirmed the pre-backport file on this branch already used<h2>throughout, so this predates the design-systemDialogTitleadoption on main.- Toast assertions reference the branch's existing
useToast: () => ({ add: mockToastAdd })mock shape rather than main's newer.errorhelper — confirmed via the pre-backport test file. openHostedBillingTab.ts'sreserveBillingTab()null handling reads differently (early-returnif (!tab) return 'blocked'vs main'stab?.navigate(...)ternary) but is equivalently null-safe.
No package.json touched, so no packaging/exports risk. No open review threads. CI fully green at this head. Approving.
Manual backport of #21180 (FE-1908 / DES-1033). The bot's cherry-pick hit conflicts.
Why
On the consolidated billing rail, top-up dead-ends with
NO_PAYMENT_METHODwhen the workspace has no Stripe invoice default. This backport brings the hosted-checkout recovery, the billing-webreturn_urlfor non-cloud-web origins, and the Desktop billing-tab handoff (#21198, folded into #21180) to this release line.Root cause
Off-session top-up charges only the Stripe customer's invoice default, and the dialog had no recovery when that was missing. Details and fix design are in #21180.
How
Cherry-pick of the #21180 squash commit, with the conflicts resolved as below.
Conflict resolution
mainhas #21170 (removesretryPaymentAuthentication/ the embedded checkout UI) and #21159 (theno-redundant-component-classeslint rule). This branch has neither, so:useTopupOperation.tsandTopUpCreditsDialogContentWorkspace.vuekeep this branch'sretryPaymentAuthentication/resumeTopupAuthenticationand addcreateHostedCheckoutandshowAmountStepnext to them.openHostedBillingTab.tsadds only thereserveBillingTabimport. This branch readsreadCheckoutOperationfromuseBillingContext; there is nobillingRefreshmodule here.<h2>titles instead ofDialogTitle. The new buttons follow this branch'sh-10 justify-centerclasses. TheBILLING_ACTION_NAMEattribute, which doesn't exist on this branch, is not added.Verification
viteston the top-up dialog,platform/workspace/billing,useTopupOperation,useWorkspaceBillingandcomposables/billing: all pass. The pre-commit hook ran lint and typecheck.AS IS / TO BE
See #21180 for the AS IS / TO BE recordings; this backport has no behavior of its own.