Repository navigation
[backport cloud/1.57] FE-1908 / DES-1033 fix(billing): offer hosted checkout when top-up has no default payment method (#21180) - #21219
Conversation
…s no default payment method (#21180) Consolidated-rail top-up now recovers from `NO_PAYMENT_METHOD` by offering Stripe-hosted Checkout for the same amount instead of ending on an error toast. Supersedes the copy change in #21171. **Why.** Off-session top-up (`POST /api/billing/topup`) is the only purchase path once a workspace leaves `legacy_stripe`. A workspace without a Stripe invoice default gets a dead-end toast and cannot buy credits at all. **Root cause (backend, confirmed on BE-5732).** `CreateTopup` charges only the customer's live Stripe `invoice_settings.default_payment_method`. A card saved only on the subscription, or merely attached, does not count, and the resolver deliberately does not promote one. `can_top_up` does not cover payment-method readiness: capabilities are UI guidance, so a `can_top_up: true` workspace can still be refused. **How.** - On a definitive `NO_PAYMENT_METHOD` refusal, the confirm step shows an inline hint and swaps **Pay** for **Continue to checkout**. Every other refusal keeps its existing toast. The refusal happens before any billing operation is reserved, so this cannot start a second payment for an in-flight purchase. - **Continue to checkout** calls the existing hosted endpoint `POST /api/billing/topup/checkout` with the selected amount and a `return_url` chosen by `topupCheckoutReturnUrl`: cloud web returns to `location.href`; Desktop, Desktop 2 and local web return to billing-web's neutral `/return/topup` page (#21199, renamed in #21205), because their own origin is not an allowed return host. The billing-web origin comes from `billing_web_url`, else from the connected Cloud environment (`billing.comfy.org` / `stagingbilling.comfy.org` / `testbilling.comfy.org`), since a local `/api/features` has none. If no origin resolves, checkout is not started. It goes through `sdk.topup.createHostedTopupCheckout` on the SDK rail and a new `workspaceApi.createTopupCheckout` on the legacy rail, so issue and recovery stay on one rail. It then sets the pending top-up marker so the balance refreshes on return, and opens Checkout. On Desktop the URL goes to the system browser through the host's popup handler. - Per DES review: a blocked checkout tab switches the dialog to a "Checkout didn't open" screen with an **Open checkout** retry (a fresh click) instead of navigating the app away, and a checkout that fails to open shows "The payment page couldn't open. Nothing was charged. Try again." inline instead of a Purchase Failed toast. - No new capability field: the hosted endpoint has no payment-method precondition, no rail branch and no flag gate, so a `can_top_up_hosted_checkout` would always equal `can_top_up` (agreed on FE-1908). - `noPaymentMethodError` is replaced by `noPaymentMethodCheckoutHint`: "This workspace has no card saved for one-click top-ups. Pay on a checkout page instead." It no longer points to Billing & invoices, because the generic portal does not set an invoice default. **Set a default card** (`flow_type: payment_method_update`, cloud#13970) follows once that flow is live in production. Linear: FE-1908, DES-1033 - Comfy Desktop 1.1.7 (Desktop 2) pointed at this branch (`dev:cloud`, testcloud, SDK rail), with `NO_PAYMENT_METHOD` stubbed on `POST /api/billing/topup`: the refused screen offers Continue to checkout; `POST /api/billing/topup/checkout` is sent with `return_url=https://testbilling.comfy.org/return/topup`; `window.open(checkout.comfy.org/...)` is handed to the system browser and the dialog closes without the blocked screen; a sandbox test-card payment lands on the neutral return page; switching back to the app fires `focus`, which refetches `/api/billing/balance` and moves the balance from 90,909 to 101,459 (+10,550). - Local e2e `topUpNoPaymentMethod.spec.ts` against a local backend: passed (local build sends the billing-web return page). - `topupCheckoutReturnUrl.test.ts`: cloud web, server origin, prefixed origin, each environment fallback, unresolved. - `pnpm exec vitest run` on `TopUpCreditsDialogContentWorkspace.test.ts`, `topupOperationView.test.ts`, `useTopupOperation.test.ts`, `billingSdkStore.test.ts`: 181 passed. - New: checkout opens for the refused amount and the marker is set (legacy rail); checkout failure keeps the dialog open with an error; other refusals do not offer checkout; SDK rail routes through `createHostedTopupCheckout`; hosted-checkout failure projection. - `oxfmt`, `oxlint --type-aware`, `eslint`, server-fact gate, `typecheck:app` clean. <table> <tr><th>AS IS</th><th>TO BE</th></tr> <tr> <td> https://github.com/user-attachments/assets/6e32d1f8-32ae-4898-9b17-d88d4c50c98d </td> <td> https://github.com/user-attachments/assets/bf51da8b-508b-40ae-92a9-53c9fb1f0570 </td> </tr> <tr> <td>main build in Comfy Desktop 2: Pay ends on a "Purchase Failed" toast that points at a Manage billing button that does not exist.</td> <td>This PR in Comfy Desktop 2: refused, Continue to checkout, Stripe sandbox checkout in the system browser, test-card payment, billing-web return page, and back in the app the balance goes from 101,459 to 112,009.<br><br>The return page in this recording still shows the old title; #21205 renames it to "Return to ComfyUI" at <code>/return/topup</code>.</td> </tr> </table> | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Fix "Manage billing" copy | FE-1908 | #21171 | Superseded by this PR | | **Hosted checkout recovery on `NO_PAYMENT_METHOD`** | **FE-1908 / DES-1033** | **this PR** | **In review** | | Migration gate reads the live Stripe invoice default, not the stored field | BE-20139 follow-up | – | Proposed | | Neutral billing-web return page | FE-3464 | #21199 | Merged | | Generic return path and title (`/return/topup`, "Return to ComfyUI") | FE-3464 | #21205 | In review | | Test/staging return hosts | – | Comfy-Org/cloud#13964 | Merged | | Set a default card (`payment_method_update`) | BE-21143 | Comfy-Org/cloud#13970 | Merged, not in prod | ```mermaid graph LR A["PR 21171: copy fix"] -.->|"superseded"| B["This PR: hosted checkout recovery"] C["BE: migration gate uses live invoice default"] --> D["Fewer NO_PAYMENT_METHOD refusals"] B --> D E["PR 21199: billing-web return page"] --> B style B fill:#f9d71c,stroke:#333,stroke-width:2px ``` (cherry picked from commit fe4189d) (cherry picked from commit a0d524e)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-17T03:52:32.720Z",
"gitSha": "4700f9bab9c86a6a2e235028fcc77b443a57b79d",
"branch": "backport-21180-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.4990000000198,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7560000000000007,
"layouts": 10,
"layoutDurationMs": 2.9970000000000003,
"taskDurationMs": 517.3380000000001,
"heapDeltaBytes": -892216,
"heapUsedBytes": 74471040,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.635000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.3320000000294,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1519999999999992,
"layouts": 9,
"layoutDurationMs": 2.7399999999999993,
"taskDurationMs": 513.292,
"heapDeltaBytes": 22158080,
"heapUsedBytes": 88056044,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1744.0970000000107,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.34,
"layouts": 9,
"layoutDurationMs": 2.437,
"taskDurationMs": 848.5509999999999,
"heapDeltaBytes": -3181308,
"heapUsedBytes": 72113432,
"domNodes": 0,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 158.934,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1976.6040000000658,
"styleRecalcs": 83,
"styleRecalcDurationMs": 17.71,
"layouts": 9,
"layoutDurationMs": 3.039,
"taskDurationMs": 1087.741,
"heapDeltaBytes": -7328360,
"heapUsedBytes": 68046824,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 169.38899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666386554621848,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.7839999999906,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.492,
"layouts": 11,
"layoutDurationMs": 2.9099999999999993,
"taskDurationMs": 282.661,
"heapDeltaBytes": 18811236,
"heapUsedBytes": 84234812,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 10.918000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.3559999999534,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.626000000000001,
"layouts": 12,
"layoutDurationMs": 3.493,
"taskDurationMs": 399.883,
"heapDeltaBytes": -4114108,
"heapUsedBytes": 71274124,
"domNodes": 47,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.448999999999998,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 577.2249999999985,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.945999999999999,
"layouts": 9,
"layoutDurationMs": 2.322,
"taskDurationMs": 419.756,
"heapDeltaBytes": 26527672,
"heapUsedBytes": 91983012,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 162.22400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 750.5300000000261,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.252,
"layouts": 9,
"layoutDurationMs": 2.7740000000000005,
"taskDurationMs": 533.2600000000001,
"heapDeltaBytes": 2844616,
"heapUsedBytes": 77349164,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 174.2,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.055813953488386,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1184.885999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 854.948,
"heapDeltaBytes": -11591236,
"heapUsedBytes": 81036584,
"domNodes": -192,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 68.892,
"eventListeners": -106,
"totalBlockingTimeMs": 529,
"frameDurationMs": 33.808571428571405,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.5760000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 900.9789999999999,
"heapDeltaBytes": 857512,
"heapUsedBytes": 81690208,
"domNodes": -192,
"jsHeapTotalBytes": 15212544,
"scriptDurationMs": 67.46400000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 521,
"frameDurationMs": 33.33055555555555,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.4139999999625,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.1319999999999,
"heapDeltaBytes": -6366328,
"heapUsedBytes": 74947996,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.75,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.233999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.1340000000001,
"heapDeltaBytes": -4700700,
"heapUsedBytes": 76012564,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.70999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 213,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10817.251999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9900.844000000001,
"heapDeltaBytes": -16812880,
"heapUsedBytes": 83151136,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 8055.04,
"eventListeners": -64,
"totalBlockingTimeMs": 1225,
"frameDurationMs": 32.191071428571426,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10532.862000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9730.694,
"heapDeltaBytes": -23885976,
"heapUsedBytes": 75579872,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 7912.192,
"eventListeners": -68,
"totalBlockingTimeMs": 1067,
"frameDurationMs": 31.353709198813057,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8945.286000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8232.752999999999,
"heapDeltaBytes": -23371416,
"heapUsedBytes": 75697968,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 6890.895,
"eventListeners": -68,
"totalBlockingTimeMs": 709,
"frameDurationMs": 32.84154411764706,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9435.473000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8588.179,
"heapDeltaBytes": -2957484,
"heapUsedBytes": 96373448,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7209.063999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 867,
"frameDurationMs": 32.19453924914676,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 196.9389999999862,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.33,
"layouts": 11,
"layoutDurationMs": 3.1220000000000003,
"taskDurationMs": 154.77999999999997,
"heapDeltaBytes": -8070268,
"heapUsedBytes": 79413516,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.11,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222222,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 232.24900000002435,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.144,
"layouts": 11,
"layoutDurationMs": 3.2479999999999998,
"taskDurationMs": 183.15900000000002,
"heapDeltaBytes": -8170996,
"heapUsedBytes": 79182356,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.647,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090843,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2024.2509999999925,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.412,
"layouts": 7,
"layoutDurationMs": 1.829,
"taskDurationMs": 630.1419999999999,
"heapDeltaBytes": -23897068,
"heapUsedBytes": 73844948,
"domNodes": -278,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 33.995000000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2057.023000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.86,
"layouts": 8,
"layoutDurationMs": 2.6319999999999997,
"taskDurationMs": 655.5830000000001,
"heapDeltaBytes": -18791584,
"heapUsedBytes": 77759428,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 34.981,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2527.3769999999445,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.458,
"layouts": 9,
"layoutDurationMs": 2.6519999999999997,
"taskDurationMs": 1736.321,
"heapDeltaBytes": -30199708,
"heapUsedBytes": 67737472,
"domNodes": -258,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 841.404,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775496688741725,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2268.6350000000175,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.646,
"layouts": 7,
"layoutDurationMs": 1.7920000000000003,
"taskDurationMs": 1531.6200000000001,
"heapDeltaBytes": 11226836,
"heapUsedBytes": 91678592,
"domNodes": -278,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 831.611,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788888888888888,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3799.9430000000416,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.785,
"layouts": 64,
"layoutDurationMs": 11.186,
"taskDurationMs": 1777.133,
"heapDeltaBytes": -20669400,
"heapUsedBytes": 78736284,
"domNodes": 24,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 796.679,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738766519823788,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3915.320999999949,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.478000000000001,
"layouts": 64,
"layoutDurationMs": 10.693999999999999,
"taskDurationMs": 1833.729,
"heapDeltaBytes": 4008960,
"heapUsedBytes": 85993660,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 786.99,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581197,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3063.8329999999883,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.447999999999999,
"layouts": 6,
"layoutDurationMs": 1.6480000000000001,
"taskDurationMs": 1971.261,
"heapDeltaBytes": 17252240,
"heapUsedBytes": 95586112,
"domNodes": 0,
"jsHeapTotalBytes": 4349952,
"scriptDurationMs": 965.5480000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757377049180324,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3108.075000000099,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.3629999999999995,
"layouts": 4,
"layoutDurationMs": 1.1389999999999993,
"taskDurationMs": 2013.4760000000003,
"heapDeltaBytes": 13617968,
"heapUsedBytes": 97293936,
"domNodes": 0,
"jsHeapTotalBytes": 8806400,
"scriptDurationMs": 989.0679999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.116216216216216,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.400999999984,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.091999999999999,
"layouts": 6,
"layoutDurationMs": 1.8749999999999996,
"taskDurationMs": 707.6250000000001,
"heapDeltaBytes": -25166904,
"heapUsedBytes": 73715992,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 38.511,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.0340000000188,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.966,
"layouts": 6,
"layoutDurationMs": 1.7079999999999995,
"taskDurationMs": 468.7879999999999,
"heapDeltaBytes": -2453532,
"heapUsedBytes": 79461964,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 31.242000000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.9589999999948,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.029999999999999,
"layouts": 10,
"layoutDurationMs": 3.024,
"taskDurationMs": 441.87299999999993,
"heapDeltaBytes": 21649456,
"heapUsedBytes": 89320332,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 156.52699999999996,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 566.0420000000386,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.094,
"layouts": 10,
"layoutDurationMs": 2.963,
"taskDurationMs": 381.68500000000006,
"heapDeltaBytes": 21615880,
"heapUsedBytes": 88622208,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 148.12,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.1170000000416,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5850000000000004,
"layouts": 8,
"layoutDurationMs": 2.4659999999999997,
"taskDurationMs": 522.7230000000001,
"heapDeltaBytes": 22421540,
"heapUsedBytes": 89327432,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.801,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2024.6170000000347,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.389,
"layouts": 10,
"layoutDurationMs": 3.234,
"taskDurationMs": 548.6450000000001,
"heapDeltaBytes": -179116,
"heapUsedBytes": 76410632,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.184,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.3530000000214,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.856,
"layouts": 9,
"layoutDurationMs": 2.391,
"taskDurationMs": 1050.9930000000002,
"heapDeltaBytes": -11410092,
"heapUsedBytes": 65903444,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 117.762,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.5709999999926,
"styleRecalcs": 87,
"styleRecalcDurationMs": 18.192999999999998,
"layouts": 9,
"layoutDurationMs": 2.6689999999999996,
"taskDurationMs": 1059.749,
"heapDeltaBytes": 11680176,
"heapUsedBytes": 79057892,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 115.26599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1235.6560000000059,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.738000000000007,
"layouts": 5,
"layoutDurationMs": 17.072999999999997,
"taskDurationMs": 850.5699999999998,
"heapDeltaBytes": 7398892,
"heapUsedBytes": 103722700,
"domNodes": 15953,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 30.014000000000006,
"eventListeners": 3244,
"totalBlockingTimeMs": 161,
"frameDurationMs": 20.161290322580644,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9923.825999999963,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.392,
"layouts": 8,
"layoutDurationMs": 2.58,
"taskDurationMs": 6128.880999999999,
"heapDeltaBytes": -17035660,
"heapUsedBytes": 79739944,
"domNodes": -258,
"jsHeapTotalBytes": 6909952,
"scriptDurationMs": 2756.684,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.750506756756756,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9848.488999999972,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.859,
"layouts": 7,
"layoutDurationMs": 1.742,
"taskDurationMs": 6270.418000000001,
"heapDeltaBytes": 4916492,
"heapUsedBytes": 102392100,
"domNodes": -258,
"jsHeapTotalBytes": 6909952,
"scriptDurationMs": 3014.5220000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72275042444822,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23212.747000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22587.131999999998,
"heapDeltaBytes": -14005124,
"heapUsedBytes": 262091668,
"domNodes": -3330,
"jsHeapTotalBytes": 10997760,
"scriptDurationMs": 340.10400000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.929432013769365,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 23469.88799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23003.725,
"heapDeltaBytes": -21121300,
"heapUsedBytes": 255245380,
"domNodes": -3330,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 350.715,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.59809688581315,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 28023.69699999997,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.451999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27594.657,
"heapDeltaBytes": -30032812,
"heapUsedBytes": 265634684,
"domNodes": -3330,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 907.632,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 51.849629629629625,
"p95FrameDurationMs": 116.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 28560.347999999976,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.24299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28250.408999999996,
"heapDeltaBytes": -39226588,
"heapUsedBytes": 255736208,
"domNodes": -3330,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 930.7660000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 16,
"frameDurationMs": 53.865660377358495,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8237.128999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.886,
"layouts": 20,
"layoutDurationMs": 28.189999999999994,
"taskDurationMs": 8136.278000000001,
"heapDeltaBytes": -2343740,
"heapUsedBytes": 274177760,
"domNodes": -3330,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 124.964,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.77784090909092,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8720.042999999918,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.51899999999999,
"layouts": 20,
"layoutDurationMs": 36.901,
"taskDurationMs": 8584.557999999999,
"heapDeltaBytes": -6749356,
"heapUsedBytes": 275003836,
"domNodes": -3330,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 141.49,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 50.189655172413794,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8259.697000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7849.102999999999,
"heapDeltaBytes": -8493724,
"heapUsedBytes": 239191772,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 130.61999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.11632653061225,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12278.00000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11760.395,
"heapDeltaBytes": 4619084,
"heapUsedBytes": 273855264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.3180000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.3544827586207,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 149.83100000000604,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.032,
"layouts": 10,
"layoutDurationMs": 5.002,
"taskDurationMs": 121.233,
"heapDeltaBytes": 4628744,
"heapUsedBytes": 76842216,
"domNodes": 97,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.976999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65999999999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 137.9660000000058,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.831,
"layouts": 8,
"layoutDurationMs": 3.4419999999999997,
"taskDurationMs": 103.031,
"heapDeltaBytes": -15434640,
"heapUsedBytes": 68009248,
"domNodes": 117,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7.745000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 487.3099999999795,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.957,
"layouts": 76,
"layoutDurationMs": 15.427,
"taskDurationMs": 433.721,
"heapDeltaBytes": -13944136,
"heapUsedBytes": 81797692,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 211.18200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 669.9039999999741,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.303,
"layouts": 76,
"layoutDurationMs": 19.736,
"taskDurationMs": 608.255,
"heapDeltaBytes": 13200020,
"heapUsedBytes": 87675496,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 283.738,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 644.5469999999887,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.026,
"layouts": 76,
"layoutDurationMs": 17.009,
"taskDurationMs": 598.19,
"heapDeltaBytes": 29319872,
"heapUsedBytes": 149386824,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 243.698,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 668.9740000000484,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.236,
"layouts": 76,
"layoutDurationMs": 17.798000000000002,
"taskDurationMs": 629.566,
"heapDeltaBytes": 839280,
"heapUsedBytes": 132261268,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 258.93300000000005,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2281 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (34 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0c6694bff645b845a05aef60491d6a9afcfd5c15
Full docs: ADR-DEVEX-LINT-0015 |
christian-byrne
left a comment
There was a problem hiding this comment.
Backport fidelity check against the merged original (#21180), per branch: diffed sorted +/- lines against the original, then diffed the resulting files for every mismatch rather than calling a line mismatch a failure on its own.
Every remaining difference traces to this branch's pre-existing state (before that PR), not to a content loss:
TopUpCreditsDialogContentWorkspace.vueuses<h2>for step titles here (vs<DialogTitle>on main) — confirmed the pre-backport file on this branch already used<h2>throughout, so this predates the design-systemDialogTitleadoption on main.- Toast assertions reference the branch's existing
useToast: () => ({ add: mockToastAdd })mock shape rather than main's newer.errorhelper — confirmed via the pre-backport test file. openHostedBillingTab.ts'sreserveBillingTab()null handling reads differently (early-returnif (!tab) return 'blocked'vs main'stab?.navigate(...)ternary) but is equivalently null-safe.
No package.json touched, so no packaging/exports risk. No open review threads. CI fully green at this head. Approving.
Manual backport of #21180 (FE-1908 / DES-1033). The bot's cherry-pick hit conflicts.
Why
On the consolidated billing rail, top-up dead-ends with
NO_PAYMENT_METHODwhen the workspace has no Stripe invoice default. This backport brings the hosted-checkout recovery, the billing-webreturn_urlfor non-cloud-web origins, and the Desktop billing-tab handoff (#21198, folded into #21180) to this release line.Root cause
Off-session top-up charges only the Stripe customer's invoice default, and the dialog had no recovery when that was missing. Details and fix design are in #21180.
How
Cherry-pick of the #21180 squash commit, with the conflicts resolved as below.
Conflict resolution
mainhas #21170 (removesretryPaymentAuthentication/ the embedded checkout UI) and #21159 (theno-redundant-component-classeslint rule). This branch has neither, so:useTopupOperation.tsandTopUpCreditsDialogContentWorkspace.vuekeep this branch'sretryPaymentAuthentication/resumeTopupAuthenticationand addcreateHostedCheckoutandshowAmountStepnext to them.openHostedBillingTab.tsadds only thereserveBillingTabimport. This branch readsreadCheckoutOperationfromuseBillingContext; there is nobillingRefreshmodule here.<h2>titles instead ofDialogTitle. The new buttons follow this branch'sh-10 justify-centerclasses. TheBILLING_ACTION_NAMEattribute, which doesn't exist on this branch, is not added.Verification
viteston the top-up dialog,platform/workspace/billing,useTopupOperation,useWorkspaceBillingandcomposables/billing: all pass. The pre-commit hook ran lint and typecheck.AS IS / TO BE
See #21180 for the AS IS / TO BE recordings; this backport has no behavior of its own.