Repository navigation
feat(website): swap the home page's Hub section behind the flag - #21099
mariana953 wants to merge 2 commits into
Conversation
The home page led with a provider marquee under "The latest, ready to run". Put the Hub banner — the three entries, Apps, Workflows and Models, under "Everything you need to make it" — in its place, and give visitors a way into the Hub from there. A switch picks between the two, so a visitor the flag has not answered for reads the section exactly as it is published today, in English and in Chinese.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7b8d8893ce9abbfec59a1ac40b1b45b3a2bcf679
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21099.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-2jld5ma12-comfyui.vercel.app Last updated: 2026-10-15T09:13:05Z for |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## mariana/hub-home #21099 +/- ##
=================================================
Coverage 86.27% 86.28%
=================================================
Files 3592 3604 +12
Lines 172433 172475 +42
Branches 47395 47383 -12
=================================================
+ Hits 148767 148818 +51
+ Misses 21758 21757 -1
+ Partials 1908 1900 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 24 files with indirect coverage changes 🚀 New features to boost your workflow:
|
## Summary Builds on #21099. Replaces the Apps half of the Hub catalogue with the Hub's grid: every app as a card, the ones still to come among them, and Show more once the grid runs past a page. The search toolbar and the Browse-all shelf go with the old half. `AppsHalf` picks between the two on the same `hub-home-enabled` flag. With the flag closed the Apps half renders `AppCatalogue` exactly as it is published today, down to its own copy — the new wording and the new app names live in a separate `hub-catalogue-apps`, so nothing today reads differently. Putting the choice in its own component also keeps `ModelsCatalogue`'s template under the complexity gate. The upcoming apps (Move anything, Relight, Hand product swap, Background Removal, Virtual try-on, Sprite Sheet Generator, Paparazzi me) and their images come across from the redesign branch. They are only reachable behind the flag. ## Verification - `pnpm test:unit apps/website/src/components/workshop`: 933 passing. The specs for today's Apps half are untouched and still pass, which is the evidence the closed-flag path is unchanged; two new cases cover the switch itself. - `astro check` reports 0 errors. Lint, format and the duplication/complexity audit are clean on the changed files. - Not yet viewed in a browser from this environment; the preview deployment is where to check both states. --- _Generated by [Claude Code](https://claude.ai/code/session_01GnpMtHjZzK5xfgS9aSEjvT)_
dante01yoon
left a comment
There was a problem hiding this comment.
Reviewed the stack slice against mariana/hub-home (this diff also carries #21100, which was already reviewed and merged into this branch, so I focused on the home-page swap commit).
The switch looks right: HomeHubSection gates the banner on useMounted(), so the server frame and first client frame both render today's ModelDiscoverySection, and the closed-flag path is covered by a behavioral test. CI is green. No gate concerns (no API types, no server-fact derivation: the lane open state is rendered straight from the PostHog flags).
Two non-blocking notes inline. Approving.
| "heading": "Run any model, from one place", | ||
| "subheading": "Hundreds of models from the labs building them, with their real inputs and the same API you would call from your own application.", | ||
| "browseAll": "Browse all models" | ||
| "about": { |
There was a problem hiding this comment.
suggestion: this commit re-sorts the whole English catalogue (about +4.6k/−4.6k lines) to add 38 keys; the key set and every existing value are unchanged (I diffed the flattened JSON). zh-CN wasn't re-sorted, and #21102 keeps the new order. If the sort isn't required by locale:check, could the reorder go in its own commit/PR (or be dropped)? As it stands it will conflict with any other website PR touching en/main.json, and the real additions are hard to see in review.
| import { useWorkshopFlag } from '@/scripts/posthog' | ||
|
|
||
| const PREVIEW_SWITCHES = [ | ||
| { id: 'hub-home-community', labelKey: 'workshop.preview.community' }, |
There was a problem hiding this comment.
nit-pick (non-blocking): only home-hub-pick-remix-run has a consumer in this PR; hub-home-community, hub-task-sidebar, hub-facet-sidebar and the three hub-workflows-* switches (plus their workshop.preview.* strings) aren't read anywhere yet. Consider adding each switch in the PR that introduces the section it toggles.
|
Thanks @dante01yoon! Both fair. Heads-up: the website moved to Comfy-Org/comfy-website on Oct 22 and @MaanilVerma you're taking over the Hub from me, could you take a look? Generated by Claude Code |
Summary
Builds on #21035. Swaps the Hub section on the home page from the provider marquee under "The latest, ready to run" to the Hub banner — Apps, Workflows and Models as three entries under "Everything you need to make it", with "Explore the Hub" leading into
/hub/.HomeHubSectionpicks between the two on the samehub-home-enabledflag the Hub home rides. With the flag closed the home page rendersModelDiscoverySectionexactly as it is published today, in English and in Chinese; nothing else on the page moves.The banner, its content resolver and the preview switch come across from the Hub redesign branch unchanged;
PREVIEW_SWITCHESstays module-local since the controls panel is not part of this change.Verification
pnpm test:unit apps/website/src/components/home: 78 passing, including the two new cases for the switch (today's section while the flag is closed, the banner once it answers) and the banner's own specs carried over with it.astro checkandvue-tscreport 0 errors. Lint, format and the duplication/complexity audit are clean on the changed files.ModelDiscoverySectionspecs are untouched and still pass, which is the evidence that the closed-flag path is unchanged.Generated by Claude Code