Repository navigation
feat(website): the Hub's Apps catalogue behind the flag - #21100
Conversation
The Apps half kept a search toolbar and a Browse-all shelf it had outgrown. Put the Hub's grid in its place — every app as a card, the ones still to come among them, with Show more once the grid runs past a page. AppsHalf picks between the two on the flag, so a visitor it has not answered for reads the Apps half exactly as it is published today, down to its own copy. The upcoming apps and their images come across with it.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 93b53761e2e1de3f510a8b3c36b01f94244944b5
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21100.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. Deployment detailsThis commit: https://website-frontend-67i5dl4rk-comfyui.vercel.app Last updated: 2026-10-21T22:15:26Z for |
The Cinematic Studio and Re-shoot covers are read through the app card data that today's Apps half shares, so they arrive with the change that moves that data behind the flag.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## mariana/hub-home-banner #21100 +/- ##
========================================================
Coverage 86.28% 86.28%
========================================================
Files 3596 3604 +8
Lines 172410 172475 +65
Branches 47369 47383 +14
========================================================
+ Hits 148758 148818 +60
- Misses 21753 21757 +4
- Partials 1899 1900 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The models listing imported the apps half eagerly, which pulled the apps catalogue code into the first render of /hub/models/ and kept its loader up past the render guard's budget. It now loads on demand, and the hub tab navigation preloads it alongside the apps catalogue.
benjcooley
left a comment
There was a problem hiding this comment.
Reviewed with the architecture and functionality reviewer agents. Every finding was checked against the code at ad020db.
No blockers. The closed-flag path looks unchanged: AppsHalf forwards browseAll, section and tabs correctly, and apps-catalogue stays on both paths. CI is green.
The flag-on path has some real gaps:
- The new wording for the two live apps is never wired up.
- The in-page Models/Workflows/Apps tabs disappear.
- Impression analytics are missing, so the flag-on and flag-off cohorts can't be compared.
- The new test doesn't exercise the flag answering after mount.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 4 |
| TRIVIAL | 3 |
Checked and fine:
- The
appMetakeys match real slugs (apps/cinematic-studio,apps/reshoot). - New-tab opening matches
ExploreResultCard. - The
hub-home-enabledflag resolves in the same PostHog callback as the gate that holds the Apps section in loading, so there's no flash on first load. - The en
main.jsonreorder only sorts keys; nothing was lost.
Note: these assets and app names are in a public repo and under public/, so the flag hides the cards but doesn't keep them secret.
… grid - The two open apps now read their summary and meta line from the Hub copy instead of the live catalogue's taglines; the unused name keys are gone and the card type extends the live one with an optional href. - The tabs to Models and Workflows render above the grid, in the same sticky band the live catalogue uses. - The grid reports a hub_row_viewed impression and clicks under a new app_grid source, so flag-on and flag-off CTR can be compared. - Upcoming apps are built inside HubAppCatalogue, so the list keeps its identity across parent re-renders and stays out of the flag-off chunk. - Upcoming cards drop aria-disabled and the hover zoom; the grid gets an sr-only h2. - Tab prefetch also loads HubAppCatalogue. - Tests: the flag flips after mount, real app slugs, card copy, tabs, HubAppCatalogue rendering and analytics, and usePagedList.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review of the new commit ca7b35f only, checked with the architecture and functionality reviewer agents against the surrounding code.
Six of my seven threads are fixed and resolved:
- The Hub copy now shows for the live apps.
- The tabs are back, in a pinnable
HUB_TOOLBAR_IDband. - The test flips the flag after mount and uses real slugs, and there is new coverage for
HubAppCatalogue,HubAppCardandusePagedList. upcominghas a stable identity and is out of the flag-off chunk.- The prefetch now includes
HubAppCatalogue. - The a11y fixes are in.
Nothing in the new tests looks like it would fail CI.
One gap is left, on the impressions thread: hub_row_viewed counts the 7 unclickable Soon cards (see the inline comment). Click-through therefore still can't be compared across the flag, which was the point of the change.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 1 |
| TRIVIAL | 0 |
I'm not approving yet because the impression payload fix is small but changes the data this flag exists to collect. website-unit, typecheck, build and the e2e shards were still pending when I posted.
The hub_row_viewed payload listed the seven Soon cards, so per-item click-through could not be compared with the flag-off shelf. The marker now watches the grid itself rather than the section with the tabs.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review of 8656fe7 only, checked with the architecture and functionality reviewer agents against the surrounding code.
The last open item is fixed:
hub_row_viewednow reports only openable apps (openSlugs, which uses the samehrefcheck as the click handler), soitem_countis 2. That makes it comparable with the flag-offapp_rowshelf.- Click positions line up with
row_slugsbecause live apps always come first. - The marker now watches the
app-grid-rowwrapper instead of the section with the sticky tabs. Layout andCatalogueShowMorespacing are unchanged. - The test asserts both the observed element and the payload.
instances[0]is reliably theHubRowSeenobserver:instancesis reset per test, and none of the fixtures renders a video.
All 9 review threads are now resolved.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 2 |
Optional follow-ups, not blocking:
- If a page has no openable apps, the grid still sends
hub_row_viewedwithitem_count: 0. The flag-off shelf does the same. You could skip the capture for an empty list. - Positions match
row_slugsonly because live apps are sorted first. A one-line comment bycardswould protect that from a later reorder.
CI: typecheck, lint and the website e2e shards pass on 8656fe7. Website Unit passed on ca7b35f and was still running on this 30-line delta when I approved.
Summary
Builds on #21099. Replaces the Apps half of the Hub catalogue with the Hub's grid: every app as a card, the ones still to come among them, and Show more once the grid runs past a page. The search toolbar and the Browse-all shelf go with the old half.
AppsHalfpicks between the two on the samehub-home-enabledflag. With the flag closed the Apps half rendersAppCatalogueexactly as it is published today, down to its own copy — the new wording and the new app names live in a separatehub-catalogue-apps, so nothing today reads differently. Putting the choice in its own component also keepsModelsCatalogue's template under the complexity gate.The upcoming apps (Move anything, Relight, Hand product swap, Background Removal, Virtual try-on, Sprite Sheet Generator, Paparazzi me) and their images come across from the redesign branch. They are only reachable behind the flag.
Verification
pnpm test:unit apps/website/src/components/workshop: 933 passing. The specs for today's Apps half are untouched and still pass, which is the evidence the closed-flag path is unchanged; two new cases cover the switch itself.astro checkreports 0 errors. Lint, format and the duplication/complexity audit are clean on the changed files.Generated by Claude Code