Skip to content

feat(website): the Hub's Apps catalogue behind the flag - #21100

Merged
christian-byrne merged 5 commits into
mariana/hub-home-bannerfrom
mariana/hub-apps
Oct 26, 2026
Merged

christian-byrne merged 5 commits into
mariana/hub-home-bannerfrom
mariana/hub-apps

Conversation

@mariana953

Copy link
Copy Markdown
Contributor

Summary

Builds on #21099. Replaces the Apps half of the Hub catalogue with the Hub's grid: every app as a card, the ones still to come among them, and Show more once the grid runs past a page. The search toolbar and the Browse-all shelf go with the old half.

AppsHalf picks between the two on the same hub-home-enabled flag. With the flag closed the Apps half renders AppCatalogue exactly as it is published today, down to its own copy — the new wording and the new app names live in a separate hub-catalogue-apps, so nothing today reads differently. Putting the choice in its own component also keeps ModelsCatalogue's template under the complexity gate.

The upcoming apps (Move anything, Relight, Hand product swap, Background Removal, Virtual try-on, Sprite Sheet Generator, Paparazzi me) and their images come across from the redesign branch. They are only reachable behind the flag.

Verification

  • pnpm test:unit apps/website/src/components/workshop: 933 passing. The specs for today's Apps half are untouched and still pass, which is the evidence the closed-flag path is unchanged; two new cases cover the switch itself.
  • astro check reports 0 errors. Lint, format and the duplication/complexity audit are clean on the changed files.
  • Not yet viewed in a browser from this environment; the preview deployment is where to check both states.

Generated by Claude Code

The Apps half kept a search toolbar and a Browse-all shelf it had
outgrown. Put the Hub's grid in its place — every app as a card,
the ones still to come among them, with Show more once the grid runs
past a page.

AppsHalf picks between the two on the flag, so a visitor it has not
answered for reads the Apps half exactly as it is published today,
down to its own copy. The upcoming apps and their images come across
with it.
@mariana953
mariana953 requested review from a team and dante01yoon as code owners October 15, 2026 09:49
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 345a4e15-882e-4432-a8c1-2bbc786e1613

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 93b53761e2e1de3f510a8b3c36b01f94244944b5

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21100.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-67i5dl4rk-comfyui.vercel.app

Last updated: 2026-10-21T22:15:26Z for 8656fe7

The Cinematic Studio and Re-shoot covers are read through the app card
data that today's Apps half shares, so they arrive with the change that
moves that data behind the flag.
@codecov

codecov Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...site/src/components/workshop/CatalogueShowMore.vue 33.33% 2 Missing ⚠️
...ebsite/src/components/workshop/HubAppCatalogue.vue 92.85% 1 Missing ⚠️
...pps/website/src/lib/workshop/hub-catalogue-apps.ts 87.50% 0 Missing and 1 partial ⚠️
apps/website/src/scripts/hubNavigation.ts 0.00% 1 Missing ⚠️
@@                   Coverage Diff                    @@
##           mariana/hub-home-banner   #21100   +/-   ##
========================================================
  Coverage                    86.28%   86.28%           
========================================================
  Files                         3596     3604    +8     
  Lines                       172410   172475   +65     
  Branches                     47369    47383   +14     
========================================================
+ Hits                        148758   148818   +60     
- Misses                       21753    21757    +4     
- Partials                      1899     1900    +1     
Flag Coverage Δ
website-unit 81.15% <92.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/workshop/AppsHalf.vue 100.00% <100.00%> (ø)
...pps/website/src/components/workshop/HubAppCard.vue 100.00% <100.00%> (ø)
...ebsite/src/components/workshop/ModelsCatalogue.vue 100.00% <100.00%> (ø)
apps/website/src/composables/usePagedList.ts 100.00% <100.00%> (ø)
apps/website/src/lib/workshop/apps-half.ts 100.00% <100.00%> (ø)
...s/website/src/lib/workshop/catalogue-components.ts 100.00% <100.00%> (ø)
...s/website/src/lib/workshop/hub-coming-soon-apps.ts 100.00% <100.00%> (ø)
apps/website/src/scripts/workshop-analytics.ts 95.45% <ø> (ø)
...ebsite/src/components/workshop/HubAppCatalogue.vue 92.85% <92.85%> (ø)
...pps/website/src/lib/workshop/hub-catalogue-apps.ts 87.50% <87.50%> (ø)
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 15, 2026
The models listing imported the apps half eagerly, which pulled the apps
catalogue code into the first render of /hub/models/ and kept its loader
up past the render guard's budget. It now loads on demand, and the hub
tab navigation preloads it alongside the apps catalogue.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with the architecture and functionality reviewer agents. Every finding was checked against the code at ad020db.

No blockers. The closed-flag path looks unchanged: AppsHalf forwards browseAll, section and tabs correctly, and apps-catalogue stays on both paths. CI is green.

The flag-on path has some real gaps:

  • The new wording for the two live apps is never wired up.
  • The in-page Models/Workflows/Apps tabs disappear.
  • Impression analytics are missing, so the flag-on and flag-off cohorts can't be compared.
  • The new test doesn't exercise the flag answering after mount.
Severity Count
BLOCKER 0
SHOULD FIX 4
TRIVIAL 3

Checked and fine:

  • The appMeta keys match real slugs (apps/cinematic-studio, apps/reshoot).
  • New-tab opening matches ExploreResultCard.
  • The hub-home-enabled flag resolves in the same PostHog callback as the gate that holds the Apps section in loading, so there's no flash on first load.
  • The en main.json reorder only sorts keys; nothing was lost.

Note: these assets and app names are in a public repo and under public/, so the flag hides the cards but doesn't keep them secret.

… grid

- The two open apps now read their summary and meta line from the Hub
  copy instead of the live catalogue's taglines; the unused name keys
  are gone and the card type extends the live one with an optional href.
- The tabs to Models and Workflows render above the grid, in the same
  sticky band the live catalogue uses.
- The grid reports a hub_row_viewed impression and clicks under a new
  app_grid source, so flag-on and flag-off CTR can be compared.
- Upcoming apps are built inside HubAppCatalogue, so the list keeps its
  identity across parent re-renders and stays out of the flag-off chunk.
- Upcoming cards drop aria-disabled and the hover zoom; the grid gets an
  sr-only h2.
- Tab prefetch also loads HubAppCatalogue.
- Tests: the flag flips after mount, real app slugs, card copy, tabs,
  HubAppCatalogue rendering and analytics, and usePagedList.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of the new commit ca7b35f only, checked with the architecture and functionality reviewer agents against the surrounding code.

Six of my seven threads are fixed and resolved:

  • The Hub copy now shows for the live apps.
  • The tabs are back, in a pinnable HUB_TOOLBAR_ID band.
  • The test flips the flag after mount and uses real slugs, and there is new coverage for HubAppCatalogue, HubAppCard and usePagedList.
  • upcoming has a stable identity and is out of the flag-off chunk.
  • The prefetch now includes HubAppCatalogue.
  • The a11y fixes are in.

Nothing in the new tests looks like it would fail CI.

One gap is left, on the impressions thread: hub_row_viewed counts the 7 unclickable Soon cards (see the inline comment). Click-through therefore still can't be compared across the flag, which was the point of the change.

Severity Count
BLOCKER 0
SHOULD FIX 1
TRIVIAL 0

I'm not approving yet because the impression payload fix is small but changes the data this flag exists to collect. website-unit, typecheck, build and the e2e shards were still pending when I posted.

@mariana953
mariana953 requested a review from benjcooley October 21, 2026 22:06
The hub_row_viewed payload listed the seven Soon cards, so per-item
click-through could not be compared with the flag-off shelf. The marker
now watches the grid itself rather than the section with the tabs.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of 8656fe7 only, checked with the architecture and functionality reviewer agents against the surrounding code.

The last open item is fixed:

  • hub_row_viewed now reports only openable apps (openSlugs, which uses the same href check as the click handler), so item_count is 2. That makes it comparable with the flag-off app_row shelf.
  • Click positions line up with row_slugs because live apps always come first.
  • The marker now watches the app-grid-row wrapper instead of the section with the sticky tabs. Layout and CatalogueShowMore spacing are unchanged.
  • The test asserts both the observed element and the payload. instances[0] is reliably the HubRowSeen observer: instances is reset per test, and none of the fixtures renders a video.

All 9 review threads are now resolved.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 2

Optional follow-ups, not blocking:

  • If a page has no openable apps, the grid still sends hub_row_viewed with item_count: 0. The flag-off shelf does the same. You could skip the capture for an empty list.
  • Positions match row_slugs only because live apps are sorted first. A one-line comment by cards would protect that from a later reorder.

CI: typecheck, lint and the website e2e shards pass on 8656fe7. Website Unit passed on ca7b35f and was still running on this 30-line delta when I approved.

@mariana953
mariana953 requested a review from benjcooley October 21, 2026 22:40
@christian-byrne
christian-byrne merged commit 34ca742 into mariana/hub-home-banner Oct 26, 2026
95 checks passed
@christian-byrne
christian-byrne deleted the mariana/hub-apps branch October 26, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants