Repository navigation
feat(website): a Hub home at /hub/ behind its own flag - #21035
mariana953 wants to merge 3 commits into
Conversation
/hub/ had no page of its own: the Hub was a menu whose entries each led straight to a catalogue. This builds the address and renders the three doors — Models, Workflows, Apps — each with one line of what it is for and a still from the catalogue it opens. The page reads the public showcase until the hub-home-enabled flag answers for the visitor, so it ships closed and opens per person without a deploy. Unlike the other gated hub sections it holds no loading frame: a visitor without the flag gets the showcase on the first frame, and the address stays noindex while it is closed. The home loads straight from the page entry rather than through ModelsCatalogue, so the three live catalogues keep the markup and the component they have in production. Search, popular items and the category tiles follow in a second change.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 22
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (46 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since de0f0e889ef2fa639a699f85da7fdc2c2830ccfb
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21035.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-3jbllp5ro-comfyui.vercel.app Last updated: 2026-10-15T07:59:59Z for |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #21035 +/- ##
==========================================
- Coverage 86.38% 86.27% -0.11%
==========================================
Files 3674 3592 -82
Lines 175334 172433 -2901
Branches 48389 47395 -994
==========================================
- Hits 151459 148767 -2692
+ Misses 21833 21758 -75
+ Partials 2042 1908 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 128 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The Hub home opened on the three doors alone. Add a search box above them that answers across apps, workflows and models, and a popular row underneath so the page is never empty. Typing puts the doors away and shows what matches, with a count per kind linking into each catalogue; clearing brings the doors back. All of it stays behind the Hub home flag.
The Hub home had no way in: nothing on the site linked to it. Add a row at the top of the Hub menu — an intro line and "Explore the Hub" — on desktop and on mobile, and left-align the open panel so the wider row sits under its trigger. It rides the same flag as the Hub home, so a visitor the flag has not answered for sees the menu exactly as it is today.
dante01yoon
left a comment
There was a problem hiding this comment.
question: apps/website no longer exists on main. #21861 (merged 2026-10-26) removed the frozen monorepo copy now that comfy.org and the Hub deploy from Comfy-Org/comfy-website, and it disconnected website CI, translation generation and deploy here. This PR's changes would land in a directory that is no longer built or deployed, so I haven't done a line-by-line review in this repo.
Could this be ported to Comfy-Org/comfy-website (and this PR closed)? I'm happy to review it there. If there is a reason it needs to land here first, could you share it?
|
Thanks @dante01yoon, agreed, this belongs in comfy-website now. I've moved to another project, so @MaanilVerma is taking over the Hub and will handle porting this stack (#21035, #21099, #21101, #21102) to Comfy-Org/comfy-website and closing these. Generated by Claude Code |
Summary
Opens a Hub home at
/hub/behind a single PostHog flag (hub-home-enabled), with a way into it from the Hub menu. Everything here is new or additive: with the flag closed,/hub/reads the existing showcase and the menu renders exactly as it does today. No live page changes.Three parts, in order:
/hub/is a new address, served by the existing models page through asection: 'explore'prop. It opens on the three doors (Models · Workflows · Apps) under "What will you make?". While the flag is closed the page shipsnoindex, nofollowand falls back toModelsShowcasewith no loading frame. The three live catalogues are untouched —ModelsCatalogue.vueis byte-identical to main.hubSections.exploreis true, which the flag feeds.NavigationMenugains an optionalviewportAlignthat defaults to today'scenter.Verification
pnpm test:uniton the touched specs: 122 passing. New cases cover the home behind its flag (showcase while closed, doors once open), the search (narrows and hides the doors, clearing restores them), the result card, the search itself, and the menu row (present when the flag is open, absent when closed) on desktop, mobile and in the navigation data.exploreand default it tofalse, so their assertions are unchanged.astro checkreports 0 errors. Lint, format and the duplication/complexity audit are clean on the changed files.Generated by Claude Code