Skip to content

feat(website): a Hub home at /hub/ behind its own flag - #21035

Open
mariana953 wants to merge 3 commits into
mainfrom
mariana/hub-home
Open

mariana953 wants to merge 3 commits into
mainfrom
mariana/hub-home

Conversation

@mariana953

@mariana953 mariana953 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Opens a Hub home at /hub/ behind a single PostHog flag (hub-home-enabled), with a way into it from the Hub menu. Everything here is new or additive: with the flag closed, /hub/ reads the existing showcase and the menu renders exactly as it does today. No live page changes.

Three parts, in order:

  • The home. /hub/ is a new address, served by the existing models page through a section: 'explore' prop. It opens on the three doors (Models · Workflows · Apps) under "What will you make?". While the flag is closed the page ships noindex, nofollow and falls back to ModelsShowcase with no loading frame. The three live catalogues are untouched — ModelsCatalogue.vue is byte-identical to main.
  • Search and a popular row. A search box above the doors answers across apps, workflows and models at once, with a count per kind linking into that catalogue. Typing replaces the doors with the results; clearing restores them. With no query the row shows the apps followed by the most popular workflows and models, so the page is never empty.
  • A way in. A row at the top of the Hub menu — an intro line and "Explore the Hub" — on desktop and mobile. It is attached to the nav item only when hubSections.explore is true, which the flag feeds. NavigationMenu gains an optional viewportAlign that defaults to today's center.

Verification

  • pnpm test:unit on the touched specs: 122 passing. New cases cover the home behind its flag (showcase while closed, doors once open), the search (narrows and hides the doors, clearing restores them), the result card, the search itself, and the menu row (present when the flag is open, absent when closed) on desktop, mobile and in the navigation data.
  • Existing header and navigation specs keep their original subjects: the shared helpers now take explore and default it to false, so their assertions are unchanged.
  • astro check reports 0 errors. Lint, format and the duplication/complexity audit are clean on the changed files.
  • Not yet viewed in a browser from this environment; the preview deployment is where to check it.

Generated by Claude Code

/hub/ had no page of its own: the Hub was a menu whose entries each led
straight to a catalogue. This builds the address and renders the three
doors — Models, Workflows, Apps — each with one line of what it is for and
a still from the catalogue it opens.

The page reads the public showcase until the hub-home-enabled flag answers
for the visitor, so it ships closed and opens per person without a deploy.
Unlike the other gated hub sections it holds no loading frame: a visitor
without the flag gets the showcase on the first frame, and the address
stays noindex while it is closed.

The home loads straight from the page entry rather than through
ModelsCatalogue, so the three live catalogues keep the markup and the
component they have in production.

Search, popular items and the category tiles follow in a second change.
@mariana953
mariana953 requested a review from a team October 14, 2026 22:13
@mariana953
mariana953 requested review from a team and dante01yoon as code owners October 14, 2026 22:13
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 22
  • apps/website/src/components/common/HeaderMain/HeaderMain.vue is excluded by !apps/website/**
  • apps/website/src/components/common/HeaderMain/HeaderMainDesktop.test.ts is excluded by !apps/website/**
  • apps/website/src/components/common/HeaderMain/HeaderMainDesktop.vue is excluded by !apps/website/**
  • apps/website/src/components/common/HeaderMain/HeaderMainMobile.test.ts is excluded by !apps/website/**
  • apps/website/src/components/common/HeaderMain/HeaderMainMobile.vue is excluded by !apps/website/**
  • apps/website/src/components/common/HeaderMain/NavExploreRow.vue is excluded by !apps/website/**
  • apps/website/src/components/ui/navigation-menu/NavigationMenu.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreFinder.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreHome.test.ts is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreHome.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreKindTag.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreResultCard.test.ts is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreResultCard.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreResults.vue is excluded by !apps/website/**
  • apps/website/src/components/workshop/ExploreResultsHeading.vue is excluded by !apps/website/**
  • apps/website/src/data/mainNavigation.test.ts is excluded by !apps/website/**
  • apps/website/src/data/mainNavigation.ts is excluded by !apps/website/**
  • apps/website/src/lib/hub/model-logos.ts is excluded by !apps/website/**
  • apps/website/src/lib/workshop/explore-search.test.ts is excluded by !apps/website/**
  • apps/website/src/lib/workshop/explore-search.ts is excluded by !apps/website/**
  • apps/website/src/locales/en/main.json is excluded by !apps/website/**
  • apps/website/src/locales/zh-CN/main.json is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c5930cb5-4393-4df0-b6ed-ff8c5e3266a8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (46 changed files).

Kind Finding Where Usual remedy
Complexity <template>() — cyclomatic 14, CRAP undefined apps/website/src/components/common/HeaderMain/HeaderMainDesktop.vue:63 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since de0f0e889ef2fa639a699f85da7fdc2c2830ccfb

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21035.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-3jbllp5ro-comfyui.vercel.app

Last updated: 2026-10-15T07:59:59Z for 7b8d889

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.29126% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...website/src/components/workshop/ExploreResults.vue 42.85% 4 Missing and 8 partials ⚠️
...ps/website/src/components/workshop/ExploreHome.vue 87.17% 4 Missing and 1 partial ⚠️
.../src/components/workshop/ExploreResultsHeading.vue 75.00% 0 Missing and 2 partials ⚠️
...pps/website/src/components/workshop/ModelsPage.vue 94.44% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main   #21035      +/-   ##
==========================================
- Coverage   86.38%   86.27%   -0.11%     
==========================================
  Files        3674     3592      -82     
  Lines      175334   172433    -2901     
  Branches    48389    47395     -994     
==========================================
- Hits       151459   148767    -2692     
+ Misses      21833    21758      -75     
+ Partials     2042     1908     -134     
Flag Coverage Δ
billing-web-unit ?
website-unit 81.09% <90.29%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...te/src/components/common/HeaderMain/HeaderMain.vue 90.58% <100.00%> (+0.22%) ⬆️
...components/common/HeaderMain/HeaderMainDesktop.vue 74.28% <100.00%> (+1.55%) ⬆️
.../components/common/HeaderMain/HeaderMainMobile.vue 94.82% <100.00%> (+0.28%) ⬆️
...src/components/common/HeaderMain/NavExploreRow.vue 100.00% <100.00%> (ø)
...c/components/ui/navigation-menu/NavigationMenu.vue 100.00% <100.00%> (+14.28%) ⬆️
...s/website/src/components/workshop/ExploreDoors.vue 100.00% <100.00%> (ø)
.../website/src/components/workshop/ExploreFinder.vue 100.00% <100.00%> (ø)
...website/src/components/workshop/ExploreKindTag.vue 100.00% <100.00%> (ø)
...site/src/components/workshop/ExploreResultCard.vue 100.00% <100.00%> (ø)
...components/workshop/explore-doors/DoorAppPanel.vue 100.00% <100.00%> (ø)
... and 18 more

... and 128 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
The Hub home opened on the three doors alone. Add a search box above
them that answers across apps, workflows and models, and a popular row
underneath so the page is never empty. Typing puts the doors away and
shows what matches, with a count per kind linking into each catalogue;
clearing brings the doors back.

All of it stays behind the Hub home flag.
The Hub home had no way in: nothing on the site linked to it. Add a row
at the top of the Hub menu — an intro line and "Explore the Hub" — on
desktop and on mobile, and left-align the open panel so the wider row
sits under its trigger.

It rides the same flag as the Hub home, so a visitor the flag has not
answered for sees the menu exactly as it is today.
@mariana953 mariana953 changed the title feat(website): open a Hub home at /hub/ behind its own flag feat(website): a Hub home at /hub/ behind its own flag Oct 15, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: apps/website no longer exists on main. #21861 (merged 2026-10-26) removed the frozen monorepo copy now that comfy.org and the Hub deploy from Comfy-Org/comfy-website, and it disconnected website CI, translation generation and deploy here. This PR's changes would land in a directory that is no longer built or deployed, so I haven't done a line-by-line review in this repo.

Could this be ported to Comfy-Org/comfy-website (and this PR closed)? I'm happy to review it there. If there is a reason it needs to land here first, could you share it?

Copy link
Copy Markdown
Contributor Author

Thanks @dante01yoon, agreed, this belongs in comfy-website now. I've moved to another project, so @MaanilVerma is taking over the Hub and will handle porting this stack (#21035, #21099, #21101, #21102) to Comfy-Org/comfy-website and closing these.


Generated by Claude Code

This branch was previously deployed

1 inactive deployment
website-approval — 7b8d8893 Deployed Oct 15, 2026 by mariana953 via fast-lane #4120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants