Repository navigation
[backport cloud/1.56] fix: propagate DynamicGroup row changes through nested promotions - #21038
Conversation
…0181) ## ELI5 Editing or deleting a repeated row now updates its promoted controls through nested subgraphs. Outer labels follow the surviving row, and controls and links disappear when their inner target is removed, while labels renamed by the user are preserved. ## Summary - Propagate DynamicGroup row renumbering and orphaned-promotion cleanup through every enclosing subgraph and its host instances. Inputs with other connected targets keep their promotion. - Preserve per-instance custom labels in the shared `SubgraphNode` rename listener; only labels still matching the previous generated label are updated. - Collect host instances lazily once per row-change operation and reuse that lookup across fields, rows and promotion boundaries. No persistent graph cache is added. - Exercise a remote resize of an already materialized root node through the real document applier, change tracker and outbound minter: frontend workflow serialization updates, one undo entry is recorded, and remote changes do not echo back. A subsequent local edit proves the outbound minter is active. ## Validation - Original regression proof: reverting the nested-promotion fix produced **2 failures / 38 passes**; applying it produced **40 passes**. - New per-instance-label regression: **1 failure / 41 passes** before the label fix. - `pnpm exec vitest run src/core/graph/widgets/dynamicGroupWidget.test.ts src/lib/litegraph/src/subgraph/SubgraphNode.test.ts src/workbench/extensions/agent/crdt/liveGraphApplier.changeTracker.test.ts --maxWorkers=1`: **98 passed**. After narrowing the new fixture's serialization types, its two tests passed again. - The unchanged real-backend regressions in [#17510 — test: verify DynamicGroup in a dedicated backend E2E job](#17510), now stacked here, both pass. The [dedicated Linux job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/37396376241/job/112054534444) reports **18 passed / 1 failed**: the remaining failure is Undo/Redo of a once-promoted row, which also fails after reverting both production files to this PR’s base (`9eaaf261ff`). Local testing matched **18 passed / 1 failed** (one worker, no retries; local Vite-only timeout 60s, CI retains 30s). - Formatting, lint, application typechecking, and commit/push hooks passed, including Knip and the changed-file Fallow gate. ## Separate Undo/Redo follow-up The remaining real-backend E2E failure is tracked in [#20285 — Redo history is cleared after Undo normalizes node size](#20285). Undo changes the restored source-node height, and the next navigation click records that difference as a new edit and clears Redo. The E2E child keeps this test enabled as a real failure; the linked completed Linux run reports 18 passed / 1 failed. No source-size workaround or shared history change is included in this PR. The shared-history fix now has an owned draft: [#20294 — fix: preserve redo after restored node size normalization](#20294), assigned to @jaeone94. Its two normalization regressions fail before the fix, and 140 related unit tests pass with it. Applying only that production patch to the unchanged E2E child makes the promoted-row Undo/Redo case pass locally. The full local run was 17 passed / 2 nested-entry click timeouts; see the draft for that limitation. The child branch and its CI result have not been changed by this verification. ## Remaining remote-edit scope The remote-frame test begins with a correctly materialized root node. It does not certify first catch-up, CLI/catalog integration, or edits inside subgraph definitions: the current collector/applier path handles root-node widget updates. Those broader agent-path checks remain separate from this nested-promotion fix. Fixes #20179 Fixes #20180 ## Provenance The two original nested-promotion regressions pass unchanged with the E2E PR stacked on this fix. The child's [completed Linux job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/37397861046/job/112059272768) reports 18 passed / 1 failed; the remaining shared-history Redo defect has the owned issue and draft linked above. The child subsequently updated its devtool and backend pin for the private API: four focused real-backend cases passed locally, while the new full-suite CI run is pending. The 18/1 result is evidence from before that pin update, not a claim that the latest child head is green. - **Authored by:** interactive session - **Verified:** the unit results and hook checks above. The [real-backend CI job](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/37396376241/job/112054534444) and local run both passed the two targeted regressions; the full suite is not green because the baseline Redo failure remains. - **Deviations:** full nested Agent/CLI/document/follower convergence is not covered by the root-node remote-frame test. No backend dependency override is added to this fix PR. --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-14T23:24:52.364Z",
"gitSha": "ab9cbe07473ae55e567ab78bb6ebd54abb0895d9",
"branch": "backport-20181-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.1319999999846,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.258,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.979,
"heapDeltaBytes": 1061632,
"heapUsedBytes": 68314860,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.873999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.6450000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.765999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.93399999999997,
"heapDeltaBytes": 1271688,
"heapUsedBytes": 69380292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.009999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.9360000000056,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.893,
"layouts": 12,
"layoutDurationMs": 4.61,
"taskDurationMs": 781.85,
"heapDeltaBytes": -2159468,
"heapUsedBytes": 65474268,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 161.26299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1786.2609999999677,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.431000000000004,
"layouts": 12,
"layoutDurationMs": 3.9810000000000003,
"taskDurationMs": 827.977,
"heapDeltaBytes": -1980516,
"heapUsedBytes": 65522328,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 163.75,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018691,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.1460000000147,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.899999999999999,
"layouts": 6,
"layoutDurationMs": 1.0150000000000001,
"taskDurationMs": 349.68100000000004,
"heapDeltaBytes": 4151716,
"heapUsedBytes": 72203608,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.146999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.0829999999896,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.992,
"layouts": 6,
"layoutDurationMs": 1.4389999999999998,
"taskDurationMs": 354.02500000000003,
"heapDeltaBytes": -97688,
"heapUsedBytes": 60865572,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.677000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 700.5189999999857,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.229,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.278,
"heapDeltaBytes": -6714324,
"heapUsedBytes": 61390152,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 165.08499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 723.118999999997,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.8019999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.20700000000005,
"heapDeltaBytes": -6678464,
"heapUsedBytes": 61164544,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 167.495,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.83900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.673,
"heapDeltaBytes": 12414332,
"heapUsedBytes": 92318924,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 69.104,
"eventListeners": 0,
"totalBlockingTimeMs": 534,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1161.7570000000796,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.7350000000001,
"heapDeltaBytes": 39263404,
"heapUsedBytes": 107858548,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 71.44099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 508,
"frameDurationMs": 32.8542857142857,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.9909999999891,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.4869999999997,
"heapDeltaBytes": 18915408,
"heapUsedBytes": 103589296,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 167.42899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.76285714285711,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 865.0410000000193,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.14500000000055,
"heapDeltaBytes": 17907612,
"heapUsedBytes": 102843628,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 167.50300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9243.57200000003,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7640000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8403.915,
"heapDeltaBytes": 15760572,
"heapUsedBytes": 92779164,
"domNodes": -172,
"jsHeapTotalBytes": -7737344,
"scriptDurationMs": 7143.3550000000005,
"eventListeners": -78,
"totalBlockingTimeMs": 977,
"frameDurationMs": 35.43946360153257,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9127.538999999957,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6069999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8496.970000000001,
"heapDeltaBytes": -5295680,
"heapUsedBytes": 72583024,
"domNodes": -142,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 7275.181,
"eventListeners": -74,
"totalBlockingTimeMs": 1105,
"frameDurationMs": 35.47237354085603,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9579.760000000022,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.047000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8821.608999999999,
"heapDeltaBytes": 13702904,
"heapUsedBytes": 81152632,
"domNodes": -142,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 7279.701999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 640,
"frameDurationMs": 32.76095890410959,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8774.665000000026,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9640000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8165.763999999999,
"heapDeltaBytes": 7429532,
"heapUsedBytes": 85494812,
"domNodes": -142,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 6935.972000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 911,
"frameDurationMs": 34.786904761904765,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2018.9120000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9269999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.99,
"heapDeltaBytes": -11176708,
"heapUsedBytes": 67345992,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 34.753,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.7470000001085,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.116999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.041,
"heapDeltaBytes": -10453072,
"heapUsedBytes": 77425340,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.763000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2447.8500000000167,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.041,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1602.469,
"heapDeltaBytes": 11415972,
"heapUsedBytes": 90420796,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 839.139,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779452054794522,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2530.1019999999426,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.626999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1683.0620000000001,
"heapDeltaBytes": -18148392,
"heapUsedBytes": 70117048,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 881.74,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.77733333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3560.637999999983,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.409999999999998,
"layouts": 60,
"layoutDurationMs": 13.779,
"taskDurationMs": 1616.771,
"heapDeltaBytes": 3866292,
"heapUsedBytes": 84661744,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 766.203,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467286,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3756.426999999917,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.434000000000001,
"layouts": 60,
"layoutDurationMs": 14.254999999999999,
"taskDurationMs": 1725.9609999999998,
"heapDeltaBytes": -20066916,
"heapUsedBytes": 70216380,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 821.3209999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666222222222224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3144.3909999999846,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.7019999999998,
"heapDeltaBytes": 21248136,
"heapUsedBytes": 100048556,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 991.0510000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755614973262027,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3124.5400000000245,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.886999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1865.4420000000002,
"heapDeltaBytes": 4880336,
"heapUsedBytes": 73724504,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 974.6340000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845945945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2016.5509999999927,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.047000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.0029999999999,
"heapDeltaBytes": -9603084,
"heapUsedBytes": 79650188,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.968,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2012.9120000000285,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7370000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.769,
"heapDeltaBytes": -9926524,
"heapUsedBytes": 79520568,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 34.71000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.5849999999864,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.501999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.061,
"heapDeltaBytes": -12563316,
"heapUsedBytes": 57528436,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 143.717,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.4160000000811,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.479,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.849,
"heapDeltaBytes": -11862976,
"heapUsedBytes": 58116388,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 142.847,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.9169999999735,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.771000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.0350000000001,
"heapDeltaBytes": 1180648,
"heapUsedBytes": 71020824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.411000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.5609999999533,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.460999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.71200000000005,
"heapDeltaBytes": 1211116,
"heapUsedBytes": 71128912,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.606999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.1479999999747,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.945999999999998,
"layouts": 16,
"layoutDurationMs": 5.813000000000001,
"taskDurationMs": 762.88,
"heapDeltaBytes": -5866924,
"heapUsedBytes": 63878496,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.18599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.6350000000057,
"styleRecalcs": 59,
"styleRecalcDurationMs": 17.986,
"layouts": 16,
"layoutDurationMs": 5.936999999999999,
"taskDurationMs": 781.397,
"heapDeltaBytes": -5908056,
"heapUsedBytes": 63315384,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.57299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.2630000000008,
"styleRecalcs": 16,
"styleRecalcDurationMs": 30.084999999999994,
"layouts": 5,
"layoutDurationMs": 14.661000000000003,
"taskDurationMs": 978.1499999999999,
"heapDeltaBytes": 1102740,
"heapUsedBytes": 93927520,
"domNodes": 14227,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.775999999999996,
"eventListeners": 2463,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.63424657534247,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8445.809999999994,
"styleRecalcs": 249,
"styleRecalcDurationMs": 34.879,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5516.501,
"heapDeltaBytes": 13509080,
"heapUsedBytes": 88544860,
"domNodes": 0,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 2718.237,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665810276679842,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8587.510000000066,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5782.233,
"heapDeltaBytes": -13814008,
"heapUsedBytes": 73642584,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2897.483,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698443579766536,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18059.250000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17210.95,
"heapDeltaBytes": -47660056,
"heapUsedBytes": 167916436,
"domNodes": -3045,
"jsHeapTotalBytes": 4915200,
"scriptDurationMs": 324.92600000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 31.201899827288425,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 18443.813999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17564.158000000003,
"heapDeltaBytes": -35788740,
"heapUsedBytes": 180175588,
"domNodes": -3045,
"jsHeapTotalBytes": 5459968,
"scriptDurationMs": 278.233,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.974523396880414,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22169.174,
"styleRecalcs": 172,
"styleRecalcDurationMs": 20.561999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21831.584,
"heapDeltaBytes": -20095548,
"heapUsedBytes": 192374860,
"domNodes": -3046,
"jsHeapTotalBytes": 7553024,
"scriptDurationMs": 849.622,
"eventListeners": -14915,
"totalBlockingTimeMs": 32,
"frameDurationMs": 41.016851851851854,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22505.133,
"styleRecalcs": 175,
"styleRecalcDurationMs": 21.743000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22175.611,
"heapDeltaBytes": -48411808,
"heapUsedBytes": 167473616,
"domNodes": -3045,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 895.671,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.96908396946564,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6556.744999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.94600000000001,
"layouts": 20,
"layoutDurationMs": 23.69599999999998,
"taskDurationMs": 6412.102999999999,
"heapDeltaBytes": 6477652,
"heapUsedBytes": 217095544,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.25599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.07912087912088,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6493.50400000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.703,
"layouts": 20,
"layoutDurationMs": 23.031999999999996,
"taskDurationMs": 6353.626,
"heapDeltaBytes": 786496,
"heapUsedBytes": 216783576,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.055,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.713186813186816,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9384.81200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8829.56,
"heapDeltaBytes": -35314288,
"heapUsedBytes": 179792136,
"domNodes": -3045,
"jsHeapTotalBytes": 5935104,
"scriptDurationMs": 147.72899999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.02423208191127,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9139.484999999922,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8746.106,
"heapDeltaBytes": -37036924,
"heapUsedBytes": 179411148,
"domNodes": -3045,
"jsHeapTotalBytes": 4411392,
"scriptDurationMs": 136.80100000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.284300341296927,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 498.1809999999314,
"styleRecalcs": 22,
"styleRecalcDurationMs": 23.663999999999998,
"layouts": 7,
"layoutDurationMs": 3.254,
"taskDurationMs": 159.29399999999998,
"heapDeltaBytes": 6185048,
"heapUsedBytes": 71913992,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 21.008999999999993,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.244827586206878,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.1629999999568,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.255,
"layouts": 4,
"layoutDurationMs": 1.894,
"taskDurationMs": 124.09199999999998,
"heapDeltaBytes": 5794124,
"heapUsedBytes": 71636104,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.465000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 868.9510000000382,
"styleRecalcs": 78,
"styleRecalcDurationMs": 103.292,
"layouts": 76,
"layoutDurationMs": 25.041999999999998,
"taskDurationMs": 834.5640000000001,
"heapDeltaBytes": 17445032,
"heapUsedBytes": 84885572,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 341.27299999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 992.4959999999601,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.031,
"layouts": 76,
"layoutDurationMs": 27.330000000000002,
"taskDurationMs": 957.0719999999999,
"heapDeltaBytes": 18911708,
"heapUsedBytes": 86801692,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 399.815,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491524,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1421.336999999994,
"styleRecalcs": 78,
"styleRecalcDurationMs": 255.923,
"layouts": 76,
"layoutDurationMs": 28.541,
"taskDurationMs": 1398.2649999999999,
"heapDeltaBytes": 8488804,
"heapUsedBytes": 115459332,
"domNodes": 76,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 468.47499999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.931645569620258,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1368.0960000000368,
"styleRecalcs": 78,
"styleRecalcDurationMs": 253.909,
"layouts": 76,
"layoutDurationMs": 28.745,
"taskDurationMs": 1351.334,
"heapDeltaBytes": 8185292,
"heapUsedBytes": 114164268,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 447.513,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.51012658227847,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2201 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 47e18c55154e8590246bb732aeac2d031e57265d
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.56 #21038 +/- ##
=============================================
Coverage ? 85.88%
=============================================
Files ? 2489
Lines ? 141966
Branches ? 36357
=============================================
Hits ? 121928
Misses ? 19654
Partials ? 384
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…#21096) Fixes typecheck on `cloud/1.56`. #21082 (backport of #20377) made `docPromotedWidgets` a required `DocOpMinterDeps` field, and #21038 (backport of #20181) added a test that builds the minter without it. Each passed CI on its own; together they break `pnpm typecheck` on the branch. This adds `docPromotedWidgets: () => null` to that test, same as on `main`. Tested: `pnpm typecheck`, `vitest run liveGraphApplier.changeTracker.test.ts`.
Backport of #20181 to
cloud/1.56Automatically created by backport workflow.