Skip to content

[cloud/1.56] test: pass docPromotedWidgets in the change tracker test - #21096

Merged
christian-byrne merged 1 commit into
cloud/1.56from
jaeone94/fix-cloud-1.56-minter-test-deps
Oct 15, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.56from
jaeone94/fix-cloud-1.56-minter-test-deps

Conversation

@jaeone94

Copy link
Copy Markdown
Collaborator

Fixes typecheck on cloud/1.56.

#21082 (backport of #20377) made docPromotedWidgets a required DocOpMinterDeps field, and #21038 (backport of #20181) added a test that builds the minter without it. Each passed CI on its own; together they break pnpm typecheck on the branch.

This adds docPromotedWidgets: () => null to that test, same as on main.

Tested: pnpm typecheck, vitest run liveGraphApplier.changeTracker.test.ts.

@jaeone94
jaeone94 requested review from a team as code owners October 15, 2026 08:25
@jaeone94 jaeone94 self-assigned this Oct 15, 2026
@jaeone94
jaeone94 requested a review from dante01yoon October 15, 2026 08:25
@jaeone94
jaeone94 temporarily deployed to website-approval October 15, 2026 08:25 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1a0de5ae-d6d7-4ac6-9017-87da8e5c4ad9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/15/2026, 08:27:52 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 628c24e43d0fdf379fee68443d943ded29ab15b6

Full docs: ADR-DEVEX-LINT-0015

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.56   #21096   +/-   ##
=============================================
  Coverage              ?   83.08%           
=============================================
  Files                 ?     2393           
  Lines                 ?   127311           
  Branches              ?    36590           
=============================================
  Hits                  ?   105773           
  Misses                ?    21127           
  Partials              ?      411           
Flag Coverage Δ
unit 83.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed: this is the exact fix for the cloud/1.56 post-merge typecheck break (run 38705065945) — docPromotedWidgets required by DocOpMinterDeps since #21082, missing from the test mock added by #21038. One-line fix matches main's shape, CI is green across the board. Approving to unblock the release branch.

@christian-byrne
christian-byrne merged commit 1a9d791 into cloud/1.56 Oct 15, 2026
100 checks passed
@christian-byrne
christian-byrne deleted the jaeone94/fix-cloud-1.56-minter-test-deps branch October 15, 2026 10:04

This branch was previously deployed

1 inactive deployment
website-approval — 42967bff Deployed Oct 15, 2026 by jaeone94 via fast-lane #4135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants