Repository navigation
[cloud/1.56] test: pass docPromotedWidgets in the change tracker test - #21096
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 628c24e43d0fdf379fee68443d943ded29ab15b6
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #21096 +/- ##
=============================================
Coverage ? 83.08%
=============================================
Files ? 2393
Lines ? 127311
Branches ? 36590
=============================================
Hits ? 105773
Misses ? 21127
Partials ? 411
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Confirmed: this is the exact fix for the cloud/1.56 post-merge typecheck break (run 38705065945) — docPromotedWidgets required by DocOpMinterDeps since #21082, missing from the test mock added by #21038. One-line fix matches main's shape, CI is green across the board. Approving to unblock the release branch.
Fixes typecheck on
cloud/1.56.#21082 (backport of #20377) made
docPromotedWidgetsa requiredDocOpMinterDepsfield, and #21038 (backport of #20181) added a test that builds the minter without it. Each passed CI on its own; together they breakpnpm typecheckon the branch.This adds
docPromotedWidgets: () => nullto that test, same as onmain.Tested:
pnpm typecheck,vitest run liveGraphApplier.changeTracker.test.ts.