Skip to content

feat(website): search and a popular row on the Hub home - #21037

Merged
mariana953 merged 1 commit into
mariana/hub-homefrom
mariana/hub-home-search
Oct 15, 2026
Merged

mariana953 merged 1 commit into
mariana/hub-homefrom
mariana/hub-home-search

Conversation

@mariana953

Copy link
Copy Markdown
Contributor

Summary

Builds on #21035. The Hub home opened on the three doors alone; this adds a search box above them and a popular row below, so the page answers a question and is never empty.

Typing searches across apps, workflows and models at once. The doors give way to the results, with a count per kind linking into that catalogue (/hub/workflows, /hub/apps, /models). Clearing the box brings the doors back. With no query the row shows the apps followed by the most popular workflows and models.

All of it stays behind the hub-home-enabled flag, so /hub/ reads the public showcase for everyone else. No live page changes.

Verification

  • pnpm test:unit on the touched specs: 21 passing, including 3 new cases for the home (opens on doors + popular; search narrows and hides the doors; clearing restores them), 1 for the result card and 8 for the search itself.
  • Typecheck, lint, format and fallow clean on the changed files.
  • Not yet viewed in a browser from this environment; the preview deployment is the place to check it.

Stacked on mariana/hub-home — merge that one first.


Generated by Claude Code

The Hub home opened on the three doors alone. Add a search box above
them that answers across apps, workflows and models, and a popular row
underneath so the page is never empty. Typing puts the doors away and
shows what matches, with a count per kind linking into each catalogue;
clearing brings the doors back.

All of it stays behind the Hub home flag.
@mariana953
mariana953 requested review from a team and dante01yoon as code owners October 14, 2026 23:10
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 02dacf52-5838-48c8-91b2-c47f38f5b107

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 83b994c11db23b09e7b25c80090dbed69dc11e54

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21037.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-368du6i6s-comfyui.vercel.app

Last updated: 2026-10-14T23:12:38Z for 6118248

@codecov

codecov Bot commented Oct 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.72043% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...website/src/components/workshop/ExploreResults.vue 42.85% 4 Missing and 8 partials ⚠️
...ps/website/src/components/workshop/ExploreHome.vue 87.50% 2 Missing and 1 partial ⚠️
.../src/components/workshop/ExploreResultsHeading.vue 75.00% 0 Missing and 2 partials ⚠️
@@                 Coverage Diff                  @@
##           mariana/hub-home   #21037      +/-   ##
====================================================
- Coverage             86.27%   86.27%   -0.01%     
====================================================
  Files                  3585     3584       -1     
  Lines                172319   172285      -34     
  Branches              47354    47342      -12     
====================================================
- Hits                 148668   148637      -31     
+ Misses                21753    21751       -2     
+ Partials               1898     1897       -1     
Flag Coverage Δ
website-unit 81.05% <81.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../website/src/components/workshop/ExploreFinder.vue 100.00% <100.00%> (ø)
...website/src/components/workshop/ExploreKindTag.vue 100.00% <100.00%> (ø)
...site/src/components/workshop/ExploreResultCard.vue 100.00% <100.00%> (ø)
apps/website/src/lib/hub/model-logos.ts 90.90% <100.00%> (-9.10%) ⬇️
apps/website/src/lib/workshop/explore-search.ts 100.00% <100.00%> (ø)
.../src/components/workshop/ExploreResultsHeading.vue 75.00% <75.00%> (ø)
...ps/website/src/components/workshop/ExploreHome.vue 87.17% <87.50%> (+13.84%) ⬆️
...website/src/components/workshop/ExploreResults.vue 42.85% <42.85%> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
@mariana953
mariana953 merged commit 6118248 into mariana/hub-home Oct 15, 2026
96 checks passed
@mariana953
mariana953 deleted the mariana/hub-home-search branch October 15, 2026 07:57

Copy link
Copy Markdown
Contributor Author

Folded into #21035 so the Hub home ships as one change: the home, the search and the way in from the Hub menu, all behind the same flag. Every commit from this branch is already in mariana/hub-home; nothing is lost.


Generated by Claude Code

This branch was previously deployed

1 inactive deployment
website-approval — 61182487 Deployed Oct 14, 2026 by mariana953 via fast-lane #3334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant