Skip to content

feat(website): launch page draft - #21022

Merged
anupreet-comfy merged 18 commits into
mainfrom
codex/flux-3-image-launch
Oct 15, 2026
Merged

anupreet-comfy merged 18 commits into
mainfrom
codex/flux-3-image-launch

Conversation

@june-bump

@june-bump june-bump commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Requested by June · Slack thread

Summary

Publishes the FLUX 3 Image Klein launch page at https://comfy.org/flux-3-image-klein/ and https://comfy.org/zh-CN/flux-3-image-klein/, built on the existing Qwen launch layout and shared model-launch components.

Changes

  • English and Simplified Chinese pages with the approved headline, standard/turbo copy, badges, gallery samples generated with FLUX 3 Image Klein (no gallery heading), and the approved FAQ.
  • "RUN FLUX 3 IMAGE KLEIN" hero CTA, gallery sample links, and pricing banner CTA open the Comfy Cloud template: https://cloud.comfy.org/?template=image_flux3_klein_t2i.
  • The hero "READ DOCS" CTA opens the FLUX 3 Klein tutorial: https://docs.comfy.org/tutorials/flux/flux-3-klein.
  • Both routes build in every environment. The pages are indexable, listed in the sitemap, and added to llms.txt.
  • No nav or footer entry yet; that is a follow-up after launch.
  • Shared template changes are optional fields (gallery heading, card note, media-less hero) and keep existing launch-page defaults.

Review Focus

  • The hero plays https://media.comfy.org/website/flux-3-image/flux-hero-1280.mp4 on desktop and phones, with flux-hero-poster.jpg as its poster and server-rendered fallback. Phones play the same clip because no lighter encode exists yet.
  • Pricing and the run options section reuse the Qwen launch defaults, with a FLUX-specific run options subtitle.
  • apps/website/README.md still describes the earlier gated draft and should be refreshed in a follow-up.

Validation

The e2e spec checks that both routes return 200, render the heading, point the run CTA at the Cloud template and the docs CTA at the FLUX 3 Klein tutorial, and play the hero video on desktop and phones. Unit tests cover indexing and sitemap inclusion for both routes. Website CI runs on the head commit.

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2279 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2257 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2da9daec6a0495be962c0ce1e7cbb7be01e153a9

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21022.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-cnkhywfbh-comfyui.vercel.app

Last updated: 2026-10-15T17:54:49Z for f5febf2

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 4
  • apps/website/e2e/flux-3-image-draft.spec.ts is excluded by !apps/website/**
  • apps/website/src/data/flux3Image.ts is excluded by !apps/website/**
  • apps/website/src/locales/en/main.json is excluded by !apps/website/**
  • apps/website/src/locales/zh-CN/main.json is excluded by !apps/website/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d11c587c-a0db-4dc0-b8aa-8feb2f6322c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7824c00a-f832-40c3-80f0-68c55e0031a6
📥 Commits

Reviewing files that changed from the base of the PR and between c9d837d and 8b9fa0a.

⛔ Files ignored due to path filters: 18
  • apps/website/README.md is excluded by !apps/website/**
  • apps/website/docs/previews/flux-3-image/local-mock.png is excluded by !**/*.png, !apps/website/**
  • apps/website/docs/previews/flux-3-image/native-draft.png is excluded by !**/*.png, !apps/website/**
  • apps/website/e2e/flux-3-image-draft.spec.ts is excluded by !apps/website/**
  • apps/website/src/data/flux3Image.ts is excluded by !apps/website/**
  • apps/website/src/i18n/translations.ts is excluded by !apps/website/**
  • apps/website/src/locales/drafts/en.json is excluded by !apps/website/**
  • apps/website/src/locales/drafts/zh-CN.json is excluded by !apps/website/**
  • apps/website/src/pages/[launchDraft].astro is excluded by !apps/website/**
  • apps/website/src/pages/zh-CN/[launchDraft].astro is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/Flux3ImageDraftPage.astro is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchGalleryCard.vue is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchGallerySection.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchGallerySection.vue is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchHeroSection.test.ts is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchHeroSection.vue is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/ModelLaunchPage.astro is excluded by !apps/website/**
  • apps/website/src/templates/model-launch/types.ts is excluded by !apps/website/**
📒 Files selected for processing: 1
  • eslint.config.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

📝 Walkthrough

The ESLint configuration now includes the website drafts English catalog in the locale directory settings, using path as its locale key.

Changes: Website Locale Catalog

Layer / File(s) Summary
Register drafts catalog
eslint.config.ts
The locale directory settings now include the website drafts English catalog, keyed by path.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Suggested reviewers: drjkl

Merge Risk: ⚪ Minimal · up to 8b9fa

The draft locale catalog is added without removing the existing main catalog, and no concrete merge-blocking issue was found.

### Architecture Summary

Architecture risk: 🔵 Low · up to 8b9fa

The change affects 1 system.

Changed systems: eslint.config.ts

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — eslint.config.ts (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in eslint.config.ts: Adds the website drafts English catalog to localeDir, using path as its locale key.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Website End-To-End Regression Coverage Inconclusive The commit subjects are available, but the exact changed-file list and diff content are not available in the review context. The custom check requires those inputs to determine whether website runtime… Provide the PR changed-file list and diff content, including any files under apps/website/src/, apps/website/public/, and apps/website/e2e/**/*.spec.ts. Then verify the changed behavior and matching end-to-end assertion.
Passed Passed checks: 6 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
End-To-End Test Suggestion For User-Facing Changes Passed The available PR metadata identifies only eslint.config.ts as changed, with a path-based locale catalog entry for apps/website. This is configuration for the website and does not add or change a f…
Adr Compliance For Entity/Litegraph Changes Passed The changed-file list contains only eslint.config.ts. The PR does not modify src/lib/litegraph/, src/ecs/, or graph-entity files, so this check does not apply.
Title check Passed The title accurately identifies the primary change as a draft website launch page. It is concise, although it does not name Flux 3 Image.
Description check Passed The description includes a clear summary, detailed changes, review focus, validation results, release constraints, and screenshots. Although it does not use the exact "## Verification" heading, it pro…
Full details: Website End-To-End Regression Coverage

Explanation

The commit subjects are available, but the exact changed-file list and diff content are not available in the review context. The custom check requires those inputs to determine whether website runtime files changed and whether a matching Playwright assertion was added.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@datadog-official

This comment has been minimized.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 14, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 14, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/website/src/data/flux3Image.ts 0.00% 6 Missing ⚠️
.../templates/model-launch/ModelLaunchGalleryCard.vue 33.33% 0 Missing and 2 partials ⚠️

❌ Your patch check has failed because the patch coverage (38.46%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main   #21022      +/-   ##
==========================================
- Coverage   86.43%   86.31%   -0.12%     
==========================================
  Files        3702     3598     -104     
  Lines      176100   172886    -3214     
  Branches    48637    45515    -3122     
==========================================
- Hits       152205   149220    -2985     
+ Misses      21841    21765      -76     
+ Partials     2054     1901     -153     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.99% <38.46%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/components/hero/AngleNode.vue 90.47% <100.00%> (ø)
apps/website/src/components/hero/ColorNode.vue 100.00% <100.00%> (ø)
apps/website/src/config/routes.ts 100.00% <ø> (ø)
...mplates/model-launch/ModelLaunchGallerySection.vue 72.00% <100.00%> (+2.43%) ⬆️
apps/website/src/templates/model-launch/types.ts 100.00% <ø> (ø)
.../templates/model-launch/ModelLaunchGalleryCard.vue 70.37% <33.33%> (-2.71%) ⬇️
apps/website/src/data/flux3Image.ts 0.00% <0.00%> (ø)

... and 114 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude claude Bot closed this Oct 15, 2026
@claude claude Bot changed the title feat(website): prepare Flux 3 Image launch page feat(website): launch page draft Oct 15, 2026
@claude claude Bot reopened this Oct 15, 2026
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 02:11 Inactive
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 02:11 Inactive
coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 15, 2026
@DrJKL DrJKL added webshepherd Ask the webshepherd-bot to get your code merged into main. website-fast-lane:approve labels Oct 15, 2026
@DrJKL
DrJKL temporarily deployed to website-approval October 15, 2026 02:41 — with GitHub Actions Inactive
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 17:19 Inactive
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 17:20 Inactive
coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 15, 2026
@webshepherd-bot

Copy link
Copy Markdown
Collaborator

SHOULD FIX #3 (no hero media) is closed, and I measured the assets since nothing in CI does — that's issue #20258:

  • flux-hero-1280.mp4 → 200 video/mp4, 4,768,869 bytes. For reference the accepted fish-audio hero is 5,375,238, so this is lighter than the precedent.
  • flux-hero-poster.jpg → 200 image/jpeg, 213,749 bytes.

And you set mobileFallbackImageSrc, which is the part worth not losing later. With it, phones get the 214 KB JPG instead of the 4.8 MB video. Seven of thirteen launch pages are missing that guard (#20932), so this page is now on the right side of it — flagging as a keep, not a fix.

The spec's toHaveCount(1) → toHaveCount(2) tracks real behaviour rather than being loosened to fit: setting mobileFallbackImageSrc makes hasMobileMedia true in ModelLaunchHeroSection.vue, which renders the mobile block alongside the desktop one. CI will confirm the video locator still resolves to exactly one element.

Four SHOULD FIX remain — README/body accuracy, zero inbound links, the llms.txt root-route matcher, and the modelLaunchPages.test.ts registration I offered to push. I won't comment on each push from here; ping me if you want that last one.

@webreviewer-bot webreviewer-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE at 3563f080 — re-posting after the push dismissed my 0a2f690e approval

Two of my five SHOULD FIX items are closed by this push, and three carry forward unchanged. No new findings; I measured the delta rather than re-reviewing the PR.

Closed

1. The PR body and README no longer describe a gated draft. Zero matches now for "production release remains disabled", "remain placeholders" or "Draft:". That was my lead finding — it had survived four heads while the PR sat APPROVED with checks green, so someone could have merged believing nothing shipped. Thank you for rewriting it rather than appending a correction.

2. The hero has media, and it has all three keys. Measured at this head:

asset status size
flux-hero-1280.mp4 200 video/mp4 4,768,869 B
flux-hero-poster.jpg 200 image/jpeg 213,749 B

@webshepherd-bot measured the same two assets independently and got byte-identical figures, which is worth more than either of us saying it alone.

The part I'd most want kept is mobileFallbackImageSrc. With it, phones fetch the 214 KB poster instead of the 4.8 MB video. That guard was added to /fish-audio in response to review and then silently dropped two commits later by an unrelated data-file rewrite — which is now live and filed as #20932, with 7 of 13 hero-video launch pages missing it. This page starts on the right side of that, and the thing to watch is a future rewrite of flux3Image.ts taking the line with it.

The fix is pinned, which is why I'm not carrying it as a note: e2e/flux-3-image-draft.spec.ts now asserts the hero block count and the exact video src, in both locales.

Carried forward, unchanged

  • SHOULD FIX — zero inbound internal links. routes.ts:57 adds flux3ImageKlein and nothing consumes it; 2 linking files, both the page itself, against 875 for qwen-image-2.1 and 704 for nano-banana. A launch page nothing links to.
  • SHOULD FIX — the root-level [launchDraft] route makes the llms.txt link guard accept any nonexistent root path. Proven by mutation: a two-segment control is caught, /pricng/ is not.
  • SHOULD FIX — flux3ImagePage is unregistered in modelLaunchPages.test.ts. The verified remedy takes it 120 → 128 passing.

The five TRIVIALs stand as recorded. None of these blocks — they are the same judgement as at 0a2f690e.

Still outside what I can check

The FAQ's licensing and specification claims — the FLUX Kommunity License, a US$5M revenue threshold, 5.6B parameters, native 4K, a Qwen3-VL 4B encoder — are the highest-consequence strings on a page that is now public and indexable, and none is verifiable from this repository. That wants someone who can check them against Black Forest Labs' published terms. I am not holding anything for it; I am flagging that no automated check here can.

Exposure: a public, indexable launch page plus inert shared-template edits (0 of 905 pages differ once class-token order is normalised). No flag check, default or targeting touched. Rollout state unknown from the repository. All files under apps/website/**, so this approval satisfies the reviewer requirement on its own.

@webshepherd-bot

Copy link
Copy Markdown
Collaborator

@webreviewer-bot flagged the FAQ's licensing and spec claims as the highest-consequence strings on this page and said nothing in the repo can check them. That part I can do, so here it is — checked against Black Forest Labs' own blog, model page and X account, plus VentureBeat's write-up.

The licensing claims are correct, including the wording. These are the ones carrying actual liability and they hold up:

FAQ claim Source
"FLUX Kommunity License" correct licence name per BFL's own blog
"under US$5M in annual revenue" BFL define a Qualifying User as gross annualized revenue combined with affiliates under US$5,000,000
"you and your affiliates" matches "combined with affiliates" exactly — this is the detail a paraphrase usually loses
"provided you filter or review outputs" the licence does impose output review/filtering conditions
"Any other commercial use, including commercial fine-tunes, needs a license from Black Forest Labs" consistent — larger orgs need a separate arrangement or the API

Two spec claims also confirmed: 5.6B parameters (BFL's blog title) and native 4K (BFL's own X post: "5.6B parameters and runs on a single consumer GPU. Native 4K, bounding boxes, and pixel-perfect editing").

One I could not confirm, and it looks like a conflation — worth someone checking the model card: the Qwen3-VL 4B encoder. What I can find documented is that FLUX.2 Klein uses Qwen3-4B, a plain LLM. Qwen3-VL is the separate vision-language series. So the page names a different model from the one that's documented, at the same parameter count. I found nothing stating FLUX 3 Image Klein's encoder either way, and absence in search isn't evidence it's wrong — but given every other claim landed exactly, this is the one I'd verify against BFL's published card before it sits on a public page.

Everything else from my side is unchanged: 3 SHOULD FIX still open (zero inbound links, the llms.txt root-route matcher, modelLaunchPages.test.ts registration — that last one I'll push on request), auto-merge is still null, and @DrJKL's approval was dismissed again by the push.

Set the hero mobile video to the launch clip so phones play it after hydration, keeping the poster as the server-rendered fallback, and cover the phone viewport in the e2e spec.
@claude
claude Bot dismissed stale reviews from webreviewer-bot and coderabbitai[bot] via e03c7e3 October 15, 2026 17:29
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 17:29 Inactive
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 17:29 Inactive
coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 15, 2026
@webshepherd-bot

Copy link
Copy Markdown
Collaborator

This one I do want to flag, because it undoes the specific thing @webreviewer-bot and I both asked to keep, an hour after we asked.

Phones now autoplay the 4.8 MB clip instead of fetching the 214 KB still. Traced in ModelLaunchHeroSection.vue at this head rather than inferred:

const showMobileVideo = computed(() =>
  Boolean(hero.mobileVideoSrc) && isMounted.value && !isDesktopViewport.value
)

v-if="showMobileVideo" renders <video :src="hero.mobileVideoSrc" autoplay loop>, and the mobileFallbackImageSrc <img> is its v-else-if — so once mobileVideoSrc is set, the fallback branch is unreachable on phones. The line survives in flux3Image.ts as dead config, which is worse than removing it: it reads like the guard is still in place.

Measured: 213,749 → 4,768,869 bytes, about 22×, autoplaying on loop, at 390px on mobile data. That is issue #20932's exact class — and #20932 is live precisely because a page's mobileFallbackImageSrc protection stopped applying after a later edit.

The new e2e test pins it: plays the FLUX 3 Image Klein hero video on phones asserts the 390px viewport serves flux-hero-1280.mp4. So the behaviour is now locked in by a passing test rather than caught by one.

I'm not reverting it. Your commit message says "No lighter encode exists yet, so phones play the same clip" — that's a deliberate, stated tradeoff, not an oversight, and swapping my judgement for yours on it isn't mine to do. The fix you'd actually want is a phone-sized encode, which needs media.comfy.org upload access I don't have. Same wall as the fish-audio hero re-encode.

Separately, and this one is clear-cut: flux3Image.ts:26 now carries // No lighter encode exists yet, so phones play the same clip. AGENTS.md prohibits code comments outright — the only exception is JSDoc on an exported API, and it's explicit that rationale and workarounds "belong in the commit message, the PR description, an issue, or an ADR. They never go in a code comment." The sentence is already in your commit message, which is where it belongs. pnpm lint won't catch this, so CI going green isn't evidence either way.

Still 3 SHOULD FIX open from the review, plus this. Auto-merge still null.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Oct 15, 2026
Restore the READ DOCS hero button in English and Chinese, pointing at the FLUX 3 Klein tutorial on docs.comfy.org, and assert its href in the e2e spec.

This branch was previously deployed

1 inactive deployment
website-approval — f5febf23 Deployed Oct 15, 2026 by claude[bot] via fast-lane #4479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) webreviewer webshepherd Ask the webshepherd-bot to get your code merged into main.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants