Skip to content

fix(website): hide the FLUX 3 Image Klein hero run CTA for now - #21112

Closed
claude[bot] wants to merge 1 commit into
mainfrom
website/flux-3-klein-remove-run-cta
Closed

claude[bot] wants to merge 1 commit into
mainfrom
website/flux-3-klein-remove-run-cta

Conversation

@claude

@claude claude Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Requested by June · Slack thread

Summary

Hides the hero "RUN FLUX 3 IMAGE KLEIN" button on /flux-3-image-klein/ (en and zh-CN) for now.

Before: the hero shows a RUN FLUX 3 IMAGE KLEIN button next to READ DOCS.
After: the hero shows only READ DOCS. Gallery card links and the pricing banner are unchanged.

How: dropped hero.primaryCta from apps/website/src/data/flux3Image.ts (the hero type already makes it optional and ModelLaunchHeroCtaButtons renders it behind v-if), removed the now-unused flux3Image.hero.primaryCta en and zh-CN strings, and changed the e2e spec to assert the run link is absent from the hero.

Verification

  • oxfmt --check clean on touched files; locale JSON parses.
  • Updated apps/website/e2e/flux-3-image-draft.spec.ts; unit tests, typecheck and e2e left to CI.

🤖 Generated with Claude Code


Generated by Claude Code

@claude
claude Bot requested a review from a team October 15, 2026 18:51
@claude
claude Bot temporarily deployed to website-approval October 15, 2026 18:51 Inactive
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d52e9531-dde4-4ceb-8270-4720bd096329

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since e3e8698aa5227718438a477180429420196710dd

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21112.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-l4gcmbb41-comfyui.vercel.app

Last updated: 2026-10-15T18:53:19Z for a10cfe2

@claude

claude Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

Closing: requester confirmed the run button stays; its link is already live via #21022.


Generated by Claude Code

@claude claude Bot closed this Oct 15, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #21112      +/-   ##
==========================================
- Coverage   86.45%   86.34%   -0.12%     
==========================================
  Files        3705     3600     -105     
  Lines      176357   173119    -3238     
  Branches    48731    47628    -1103     
==========================================
- Hits       152465   149473    -2992     
+ Misses      21835    21745      -90     
+ Partials     2057     1901     -156     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/data/flux3Image.ts 0.00% <ø> (ø)

... and 105 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 15, 2026

This branch was previously deployed

1 inactive deployment
website-approval — a10cfe22 Deployed Oct 15, 2026 by claude[bot] via fast-lane #4506
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants