Repository navigation
feat(website): launch page draft #21022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
945562c
8b9fa0a
78b008d
47c2c14
7bdfd75
4976f9a
d93719b
7fe4d0a
5755f16
9f50c03
4c9c766
6fa2b15
0e0a463
0a2f690
3563f08
e03c7e3
32c5558
f5febf2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,8 @@ export default defineConfig({ | |
| vite: { | ||
| plugins: [tailwindcss()], | ||
| define: { | ||
| 'import.meta.env.PUBLIC_LAUNCH_DRAFTS': | ||
| process.env.VERCEL_ENV === 'preview', | ||
|
Comment on lines
+46
to
+47
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TRIVIAL — dead config now. With the Worth deleting both so it is not later mistaken for a live switch — particularly since a Vite |
||
| __VUE_I18N_LEGACY_API__: false, | ||
| __VUE_I18N_FULL_INSTALL__: false, | ||
| __INTLIFY_PROD_DEVTOOLS__: false | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import { expect } from '@playwright/test' | ||
|
|
||
| import { test } from './fixtures/blockExternalMedia' | ||
|
|
||
| for (const prefix of ['', '/zh-CN']) { | ||
| test(`serves the ${prefix || 'English'} FLUX 3 Image Klein launch page`, async ({ | ||
| page | ||
| }) => { | ||
| const response = await page.goto(`${prefix}/flux-3-image-klein/`) | ||
|
|
||
| expect(response?.status()).toBe(200) | ||
| await expect( | ||
| page.getByRole('heading', { name: 'FLUX 3 Image Klein', exact: true }) | ||
| ).toBeVisible() | ||
| const hero = page.getByTestId('model-launch-hero-block') | ||
| await expect(hero).toHaveCount(2) | ||
| await expect(hero.locator('video')).toHaveAttribute( | ||
| 'src', | ||
| 'https://media.comfy.org/website/flux-3-image/flux-hero-1280.mp4' | ||
| ) | ||
| await expect( | ||
| page.getByRole('link', { | ||
| name: prefix ? '运行 FLUX 3 IMAGE KLEIN' : 'RUN FLUX 3 IMAGE KLEIN', | ||
| exact: true | ||
| }) | ||
| ).toHaveAttribute( | ||
| 'href', | ||
| 'https://cloud.comfy.org/?template=image_flux3_klein_t2i' | ||
| ) | ||
| await expect( | ||
| hero.getByRole('link', { | ||
| name: prefix ? '阅读文档' : 'READ DOCS', | ||
| exact: true | ||
| }) | ||
| ).toHaveAttribute( | ||
| 'href', | ||
| 'https://docs.comfy.org/tutorials/flux/flux-3-klein' | ||
| ) | ||
| }) | ||
| } | ||
|
|
||
| test('plays the FLUX 3 Image Klein hero video on phones', async ({ page }) => { | ||
| await page.setViewportSize({ width: 390, height: 844 }) | ||
| await page.goto('/flux-3-image-klein/') | ||
|
|
||
| await expect( | ||
| page.getByTestId('model-launch-hero-block').locator('video') | ||
| ).toHaveAttribute( | ||
| 'src', | ||
| 'https://media.comfy.org/website/flux-3-image/flux-hero-1280.mp4' | ||
| ) | ||
| }) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,6 +54,7 @@ const baseRoutes = { | |
| wan3: '/wan-3.0/', | ||
| chatgptImage25: '/chatgpt-image-2.5/', | ||
| qwenImage21: '/qwen-image-2.1/', | ||
| flux3ImageKlein: '/flux-3-image-klein/', | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SHOULD FIX — this entry is added but never consumed: Measured in The PR body says adding no navigation entry is deliberate, which was coherent while the route was suppressed. Alongside publishing it is an inconsistent end state. Readiness is not my call, so I am flagging rather than asserting. |
||
| nanoBanana: '/nano-banana/', | ||
| brand: '/brand/', | ||
| // The hub catalogue. `workshop` keeps its old name. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHOULD FIX — this section is wrong on six of seven claims at this head. I ran
pnpm build:e2eat0a2f690eand measured:/flux-3-image/and/zh-CN/flux-3-image/are not emitted — the slug isflux-3-image-klein, so both paths named here 404.getStaticPathsis unconditional now.<url>block each, both markdown twins written, and present inllms.txt,llms-full.txtandindexnow-manifest.json.qwen-image-2.1control carriesvideoSrc,posterSrc,mobileVideoSrcandmobileFallbackImageSrc).The only accurate sentence is the one about a navigation entry, and that is its own finding. The PR body repeats all of the above, which matters more than this file does: the PR is
APPROVEDwith checks green, so someone could merge on the strength of "production release remains disabled until launch approval".