Repository navigation
FE-3366 feat(lint): refine server-fact rules from the full-repo audit - #20806
Conversation
📦 Bundle: 9.4 MB gzip 🟢 -22 BDetailsSummary
Category Glance App Entry Points — 5.33 kB (baseline 5.33 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 61.1 kB (baseline 61.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 341 kB (baseline 341 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 25 unchanged Utilities & Hooks — 2.29 MB (baseline 2.29 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 62 unchanged Vendor & Third-Party — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19 MB) • 🟢 -160 BBundles that do not match a named category
Status: 2 added / 2 removed / 350 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-11T22:50:08.898Z",
"gitSha": "00bd5c82c1aa25737bdc674743833cbfc8976bba",
"branch": "jaewon/fe-3366-server-fact-rule-refinement",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2041.148000000021,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8070000000000004,
"layouts": 10,
"layoutDurationMs": 3.0200000000000005,
"taskDurationMs": 535.442,
"heapDeltaBytes": -10475636,
"heapUsedBytes": 64760616,
"domNodes": -162,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 10.75,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.70099999996,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5909999999999997,
"layouts": 10,
"layoutDurationMs": 2.501,
"taskDurationMs": 521.827,
"heapDeltaBytes": -1463948,
"heapUsedBytes": 66425108,
"domNodes": -162,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.464999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6672131147541,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.7660000000442,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.735999999999997,
"layouts": 11,
"layoutDurationMs": 2.802,
"taskDurationMs": 899.053,
"heapDeltaBytes": 1345184,
"heapUsedBytes": 67710052,
"domNodes": -162,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 145.791,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666363636363638,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1728.5210000000006,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.799000000000001,
"layouts": 10,
"layoutDurationMs": 2.834,
"taskDurationMs": 742.576,
"heapDeltaBytes": 5017440,
"heapUsedBytes": 72622260,
"domNodes": -162,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.238,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82718446601942,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.859000000024,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.056,
"layouts": 13,
"layoutDurationMs": 3.0509999999999997,
"taskDurationMs": 390.87699999999995,
"heapDeltaBytes": -2543568,
"heapUsedBytes": 73011936,
"domNodes": 47,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 13.722999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.4479999999903,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.195000000000001,
"layouts": 12,
"layoutDurationMs": 2.8339999999999996,
"taskDurationMs": 397.83599999999996,
"heapDeltaBytes": -407644,
"heapUsedBytes": 74616992,
"domNodes": 47,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 13.088,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 613.9400000000137,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.056,
"layouts": 10,
"layoutDurationMs": 2.827,
"taskDurationMs": 432.43899999999996,
"heapDeltaBytes": -130400,
"heapUsedBytes": 67618816,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 162.363,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 648.319000000015,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.1290000000000004,
"layouts": 11,
"layoutDurationMs": 2.9509999999999996,
"taskDurationMs": 458.07800000000003,
"heapDeltaBytes": -82944,
"heapUsedBytes": 67696800,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 156.734,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.962999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 853.8430000000001,
"heapDeltaBytes": -517844,
"heapUsedBytes": 81562364,
"domNodes": -192,
"jsHeapTotalBytes": 14688256,
"scriptDurationMs": 51.05299999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 486,
"frameDurationMs": 32.405555555555566,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1165.834000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 833.49,
"heapDeltaBytes": -5442372,
"heapUsedBytes": 81673004,
"domNodes": -192,
"jsHeapTotalBytes": 14950400,
"scriptDurationMs": 50.83299999999999,
"eventListeners": -105,
"totalBlockingTimeMs": 476,
"frameDurationMs": 31.52972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 777.3950000000127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.7949999999997,
"heapDeltaBytes": -4402884,
"heapUsedBytes": 75963824,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 124.95099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 148,
"frameDurationMs": 23.035294117647055,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.9530000000204,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.308,
"heapDeltaBytes": -4762556,
"heapUsedBytes": 77132128,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 123.10199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 23.041176470588226,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8411.766,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.085,
"layouts": 1,
"layoutDurationMs": 0.37500000000000033,
"taskDurationMs": 7423.268,
"heapDeltaBytes": 7693220,
"heapUsedBytes": 87190780,
"domNodes": -258,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 5897.429,
"eventListeners": -68,
"totalBlockingTimeMs": 199,
"frameDurationMs": 27.395751633986922,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9052.713999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8004.940999999999,
"heapDeltaBytes": 2682428,
"heapUsedBytes": 83223488,
"domNodes": -278,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 6216.0070000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 76,
"frameDurationMs": 27.175975975975977,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8992.611000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7976.167,
"heapDeltaBytes": 17355524,
"heapUsedBytes": 97088880,
"domNodes": -258,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 6214.339,
"eventListeners": -68,
"totalBlockingTimeMs": 100,
"frameDurationMs": 27.419877675840983,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7638.823000000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9790000000000008,
"layouts": 2,
"layoutDurationMs": 0.7300000000000006,
"taskDurationMs": 6753.169,
"heapDeltaBytes": 17678556,
"heapUsedBytes": 96893628,
"domNodes": -258,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 5374.883,
"eventListeners": -68,
"totalBlockingTimeMs": 58,
"frameDurationMs": 25.44333333333333,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 196.8710000000442,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.668999999999999,
"layouts": 10,
"layoutDurationMs": 2.8600000000000008,
"taskDurationMs": 162.017,
"heapDeltaBytes": -8552880,
"heapUsedBytes": 86199552,
"domNodes": 917,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7.9449999999999985,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.899999999999977,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 203.28700000004574,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.285,
"layouts": 11,
"layoutDurationMs": 3.2489999999999997,
"taskDurationMs": 161.476,
"heapDeltaBytes": -8219404,
"heapUsedBytes": 84860432,
"domNodes": 917,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.666,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.066666666666656,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2056.5010000000257,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.793000000000001,
"layouts": 10,
"layoutDurationMs": 3.109,
"taskDurationMs": 651.224,
"heapDeltaBytes": -8486192,
"heapUsedBytes": 89897236,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 37.754999999999995,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.1529999999884,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0229999999999997,
"layouts": 9,
"layoutDurationMs": 2.293,
"taskDurationMs": 459.56300000000005,
"heapDeltaBytes": -821684,
"heapUsedBytes": 81855192,
"domNodes": -258,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 30.021,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2246.988999999985,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.183,
"layouts": 9,
"layoutDurationMs": 2.5069999999999997,
"taskDurationMs": 1520.0349999999999,
"heapDeltaBytes": 509176,
"heapUsedBytes": 85092624,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 817.6170000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66567164179105,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2205.5030000000215,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.066000000000001,
"layouts": 7,
"layoutDurationMs": 1.6000000000000003,
"taskDurationMs": 1564.063,
"heapDeltaBytes": -4625148,
"heapUsedBytes": 79917568,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 735.539,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665151515151518,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3590.1700000000005,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.646999999999998,
"layouts": 66,
"layoutDurationMs": 12.598,
"taskDurationMs": 1748.4259999999997,
"heapDeltaBytes": -17721336,
"heapUsedBytes": 67811276,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 725.4119999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.743925233644863,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3517.488000000071,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.328,
"layouts": 65,
"layoutDurationMs": 12.272,
"taskDurationMs": 1715.882,
"heapDeltaBytes": -10669752,
"heapUsedBytes": 67793808,
"domNodes": -234,
"jsHeapTotalBytes": 2224128,
"scriptDurationMs": 716.3009999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665876777251185,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2973.1440000000475,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.875,
"layouts": 5,
"layoutDurationMs": 1.5100000000000005,
"taskDurationMs": 1850.5029999999997,
"heapDeltaBytes": 16275464,
"heapUsedBytes": 103449868,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 876.218,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.856250000000003,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2666.0040000000436,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.78,
"layouts": 7,
"layoutDurationMs": 1.565,
"taskDurationMs": 1632.5140000000001,
"heapDeltaBytes": 10971512,
"heapUsedBytes": 98541868,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 858.8319999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.770886075949367,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.0379999999764,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2390000000000008,
"layouts": 9,
"layoutDurationMs": 2.5190000000000006,
"taskDurationMs": 600.43,
"heapDeltaBytes": -715080,
"heapUsedBytes": 84744352,
"domNodes": -258,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 34.678999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2064.9649999999156,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.064999999999999,
"layouts": 8,
"layoutDurationMs": 2.3400000000000003,
"taskDurationMs": 627.347,
"heapDeltaBytes": -7705844,
"heapUsedBytes": 92433084,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 36.133,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.14299999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.463999999999999,
"layouts": 10,
"layoutDurationMs": 2.381,
"taskDurationMs": 397.664,
"heapDeltaBytes": 21273912,
"heapUsedBytes": 89221424,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 131.49,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.5259999999498,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.356,
"layouts": 10,
"layoutDurationMs": 2.359,
"taskDurationMs": 409.043,
"heapDeltaBytes": 21627916,
"heapUsedBytes": 89795268,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 133.487,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2053.709000000026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.457,
"layouts": 11,
"layoutDurationMs": 2.4690000000000003,
"taskDurationMs": 539.901,
"heapDeltaBytes": -5398360,
"heapUsedBytes": 71569132,
"domNodes": -180,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 10.206999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.7299999999868,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7790000000000004,
"layouts": 11,
"layoutDurationMs": 3.0789999999999997,
"taskDurationMs": 527.787,
"heapDeltaBytes": 6066676,
"heapUsedBytes": 82102236,
"domNodes": -180,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 10.491999999999999,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.877999999976,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.054,
"layouts": 11,
"layoutDurationMs": 2.4379999999999997,
"taskDurationMs": 824.384,
"heapDeltaBytes": -10339604,
"heapUsedBytes": 66997404,
"domNodes": -172,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 97.941,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.0519999999578,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.828,
"layouts": 11,
"layoutDurationMs": 2.8449999999999993,
"taskDurationMs": 833.584,
"heapDeltaBytes": -10891388,
"heapUsedBytes": 66622772,
"domNodes": -172,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 100.16799999999999,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.198999999945,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.936999999999994,
"layouts": 5,
"layoutDurationMs": 12.67,
"taskDurationMs": 955.3390000000002,
"heapDeltaBytes": 38517620,
"heapUsedBytes": 117741852,
"domNodes": 15956,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 28.462999999999994,
"eventListeners": 3244,
"totalBlockingTimeMs": 144,
"frameDurationMs": 19.863013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8268.154999999979,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.506,
"layouts": 10,
"layoutDurationMs": 2.3979999999999997,
"taskDurationMs": 5052.421,
"heapDeltaBytes": 10295124,
"heapUsedBytes": 92635760,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 2544.861,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665927419354837,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8234.254999999961,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.259999999999994,
"layouts": 9,
"layoutDurationMs": 2.63,
"taskDurationMs": 5596.0160000000005,
"heapDeltaBytes": 8968912,
"heapUsedBytes": 92573668,
"domNodes": -258,
"jsHeapTotalBytes": 4808704,
"scriptDurationMs": 2480.747,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665922920892495,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19212.139999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18735.551,
"heapDeltaBytes": -46160168,
"heapUsedBytes": 255718908,
"domNodes": -3334,
"jsHeapTotalBytes": -7655424,
"scriptDurationMs": 292.56800000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.045094664371774,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 19336.952999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18923.815,
"heapDeltaBytes": -14129024,
"heapUsedBytes": 282403356,
"domNodes": -3330,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 282.04699999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.36062176165803,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24212.354000000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 21.305000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23845.690000000002,
"heapDeltaBytes": -34265668,
"heapUsedBytes": 275205780,
"domNodes": -3330,
"jsHeapTotalBytes": -3551232,
"scriptDurationMs": 874.979,
"eventListeners": -651,
"totalBlockingTimeMs": 5,
"frameDurationMs": 45.487030075187974,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 17517.1620000001,
"styleRecalcs": 133,
"styleRecalcDurationMs": 13.603000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17122.824,
"heapDeltaBytes": -38309356,
"heapUsedBytes": 264944824,
"domNodes": -3330,
"jsHeapTotalBytes": 9633792,
"scriptDurationMs": 818.687,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 32.110989010989016,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 7110.242999999969,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.52999999999997,
"layouts": 20,
"layoutDurationMs": 23.877999999999997,
"taskDurationMs": 6996.82,
"heapDeltaBytes": -10321584,
"heapUsedBytes": 273439624,
"domNodes": -3330,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 115.55100000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.886516853932584,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5342.576000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.14900000000002,
"layouts": 20,
"layoutDurationMs": 30.260999999999996,
"taskDurationMs": 5204.8820000000005,
"heapDeltaBytes": 1292600,
"heapUsedBytes": 287320560,
"domNodes": -307,
"jsHeapTotalBytes": 8413184,
"scriptDurationMs": 85.08099999999999,
"eventListeners": -7,
"totalBlockingTimeMs": 1,
"frameDurationMs": 31.284795321637432,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9475.41000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9308.220000000001,
"heapDeltaBytes": 3178920,
"heapUsedBytes": 247085304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.31500000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.53024054982818,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7060.45000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6545.261,
"heapDeltaBytes": -20728652,
"heapUsedBytes": 258237572,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 103.11199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.95389830508475,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 479.6410000000151,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.693999999999999,
"layouts": 12,
"layoutDurationMs": 4.3020000000000005,
"taskDurationMs": 135.911,
"heapDeltaBytes": 7047404,
"heapUsedBytes": 74192580,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.078000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 474.96000000001004,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.262,
"layouts": 13,
"layoutDurationMs": 3.7089999999999996,
"taskDurationMs": 111.26700000000001,
"heapDeltaBytes": 6586552,
"heapUsedBytes": 73998952,
"domNodes": 95,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.298999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 415.0280000000066,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.003,
"layouts": 76,
"layoutDurationMs": 14.961,
"taskDurationMs": 366.861,
"heapDeltaBytes": 10563556,
"heapUsedBytes": 99606680,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 165.534,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538459,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 485.77000000000226,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3699999999999999,
"layouts": 76,
"layoutDurationMs": 16.563000000000002,
"taskDurationMs": 438.553,
"heapDeltaBytes": -12790124,
"heapUsedBytes": 83390780,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 199.242,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 599.2200000000594,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.134,
"layouts": 76,
"layoutDurationMs": 16.628,
"taskDurationMs": 559.999,
"heapDeltaBytes": 1093988,
"heapUsedBytes": 120867932,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 209.181,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 523.5460000000103,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.177,
"layouts": 76,
"layoutDurationMs": 14.674,
"taskDurationMs": 488.38300000000004,
"heapDeltaBytes": 33472,
"heapUsedBytes": 119489232,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 180.345,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2264 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4d51fa717a28c07a91475e0f7dfa68cdd6241f06
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20806 +/- ##
==========================================
+ Coverage 86.07% 86.87% +0.79%
==========================================
Files 3643 2593 -1050
Lines 173939 145722 -28217
Branches 47946 39905 -8041
==========================================
- Hits 149722 126598 -23124
+ Misses 22208 18738 -3470
+ Partials 2009 386 -1623
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1059 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Re-verified against the current head after CI settled (all shards SKIPPED/SUCCESS, 0 pending/failing, mergeable MERGEABLE). CodeRabbit APPROVED, zero open threads.
Confirmed hasLapsedTeamPlan and the BillingSubscriptionStatus-typed subscriptionStatus destructure removed from useTeamPlan.ts are genuinely dead on current main outside this PR's own files — checked useMembersPanel.ts and MembersPanelContent.vue directly against main's HEAD (not a stale local checkout, which still showed the old destructure from a different branch) and neither references either symbol anymore. The oxlint rule refinements read correctly against the added test fixtures.
No findings.
|
@dante01yoon Successfully backported to #20811 |
|
@dante01yoon Successfully backported to #20812 |
…mbined gate fails to compile (Comfy-Org#20818) ## Why FE-3361 (L1, server-fact guardrails). The changed-line lint (Comfy-Org#20679, refined in Comfy-Org#20806) is syntactic. It loses a server fact once the fact crosses a function, file, prop or store boundary under another name (Comfy-Org#19455 hid its derivation behind a helper). A type travels with the value, so the rule ("a gate renders one server fact as received", ADR-API-SERVER-FACTS-0042) can hold across boundaries. ## How **Design, picked from three options.** A boolean with a phantom brand keyed by the API field: ```ts type ServerFact<Field extends string, T = boolean> = T & { readonly [serverFactKey]: Field } receiveServerFact(field, value) // the only constructor (one cast) narrowServerFact(fact, localAllows) // ADR rule 1: local UI state may withhold, never grant pendingServerFact(ticket, value) // now returns a ServerFact; call shape unchanged ``` A gate slot typed `ServerFact<'can_invite_members'>` rejects all of these at compile time: - `fact || local` - `fact && !isLoading` - `isCloud ? fact : x` - `!fact` - a plain boolean - another field's fact Reading a fact needs no unwrapping (`if (fact)`, `v-if`, a boolean prop), because its runtime value is the boolean. **Rejected options** (probed with `tsc --strict`; full table in the design note): - **An opaque `{ granted }` object read through `renderFact()`.** TypeScript accepts `obj || local`, so the Comfy-Org#18662 shape compiles. Worse, `v-if="fact"` on an object is always truthy and vue-tsc doesn't check `v-if`, so one forgotten unwrap silently grants access. - **A ref-shaped alias.** It adds a name, not a guarantee. **Prototype on one surface.** - `useBillingCapabilities` `canInviteMembers` / `canManageMembers` return facts. - `useMembersPanel` `permissions` declares its four gate slots as facts and reads them from `useBillingCapabilities` directly; its `isCloud ? fact : role` lines are gone. The members panel is only registered on Cloud (`useSettingUI`), so the off-Cloud branch was unreachable and is deleted rather than given a local provider. The desktop visibility table in `useMembersPanel.test.ts` only exercised that branch and goes with it. - ADR-API-SERVER-FACTS-0042 now lists `ServerFact<Field>` as adopted surface by surface instead of deferred. - `serverFact.test.ts` proves each forbidden form with `@ts-expect-error`. **Limits.** - The guarantee holds only at slots typed as the fact. A `boolean`-typed gate or an inline template expression still accepts anything. - `factA && factB` assigned to `factB`'s slot compiles, and no encoding closes it. The lint stays required for that case, and a test covers it. ## AS IS / TO BE No UI or behaviour change. | Reintroduce Comfy-Org#18662 (`canInviteMembers.value \|\| isPlanEnded.value`) into the gate | AS IS | TO BE | |---|---|---| | Typecheck | passes | `vue-tsc` TS2322 at the slot | | Orthogonality tests (Comfy-Org#20694) | fail at runtime | fail at runtime | ## Decisions Resolved since the draft: 1. **Desktop/OSS member facts.** No local provider is needed: the members panel never renders off Cloud, so the role-and-seat fallback was dead code and is deleted. No lint exemption is added. 2. **ADR update.** Revised in this PR (Enforcement list and Alternatives considered). Decided as recommended (reversible): - Names `receiveServerFact` / `narrowServerFact`, so grep and lint targets stay unambiguous. - `pendingServerFact` keeps `(ticket, value)`, so the expiry script is unchanged. - Boolean facts only for now. ## Verification - `vitest run src/platform/serverFacts src/platform/workspace/composables tools/oxlint-plugins/serverFacts.test.ts`: 1140 passed on current main. - Mutation: the Comfy-Org#18662 shape fails `vue-tsc` with TS2322 at the slot. - Found while prototyping: `receiveServerFact('x', true)` inferred the literal type `true`, which TypeScript treats as always truthy, so `fact || local` passed. Fixed by widening booleans in both constructors (`FactValue<T>`). The type test caught it. - `pnpm lint:server-facts --base <merge-base>`: no findings on changed lines. - `vitest run src/platform/workspace src/platform/serverFacts tools/oxlint-plugins`: 2950 passed. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1: render capability reads | FE-3366 | Comfy-Org#20805 | Merged | | L6 lint rule refinement | FE-3366 | Comfy-Org#20806 | Merged | | **L1 `ServerFact` type (members panel)** | **FE-3361** | **this PR** | **In review** | | L2 local providers | FE-3362 | — | Not started; the members panel needs none | | L1 migration of the remaining surfaces (seats, lifecycle, top-up, subscribe) | FE-3361 | — | After this lands | ```mermaid graph LR A1["L6 A1 (PR 20805, merged)"] --> L1["L1 ServerFact type (this PR)"]:::current R["L6 rules (PR 20806, merged)"] --> L1 L1 --> M["L1 migrate remaining surfaces"] classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
Why
FE-3366 (L6) audited all 167 existing server-fact findings on main. About a third were not server-fact derivations at all, and a few real derivations went unreported. The changed-line gate and the write hook (#20679) fire on any edit to a flagged line, so every false positive blocks a legitimate edit, and every gap lets a real derivation through.
Root cause
The first version of the rules (#20681) was tuned on the incident PRs. The full-repo audit found shapes it misread:
It also missed
workspaceRole === 'owner'(only the exact namerolematched) and capability pass-throughs such ascanRunWorkflows.How
Each change has RuleTester valid and invalid cases at its boundary. All incident cases stay invalid.
topupOperation,operation,paymentLocked,isValidAmount,hasResolvedCapabilities,snapshotAuthoritative,isReady,isHiddenOnSection) andfailed.*load-error flags may narrow a capability, never grant it.lifecycleActionPermittedkeeps its findings.SubscriptionTier, typed asRecord<SubscriptionTier, true>so typecheck fails when the enum changes) are matched.x is T). Comparisons whose every branch is at(...)label. Comparators passed to.sortor.toSorted.ifor ternary and picks a value is allowed. A branch returning a boolean still counts as a step of a gate. Tier is not exempted, because fix(billing): the ended members treatment survives the backend seat collapse #19455 was tier gating.message.includes: reported only insrc/platform/errorCatalog/**, where the receiver is server error text.?? 'owner'fallbacks now also match names ending inRole, excluding user-chosentargetRole,selectedRole,newRoleandnextRole.const canX = computed(() => toValue(obj.canX))counts as that capability.hasLapsedTeamPlan(useTeamPlan.ts), which has no production reader.Known residual:
WorkspaceMembersPanelContent.vue:38,failed.members || (canViewPendingInvites && failed.invites). A load-error flag ORed with a narrowed capability has the same shape as the guarded(cap && !isLoading) || isSaving, and the AST can't tell "show an error" from "grant access". Exempting it would weaken that guard. It's an existing line, so it's only checked if edited.AS IS / TO BE
No UI change.
serverFacts.oxlintrc.jsonoversrcandapps/*/src(tests excluded)workspaceRole === 'owner',canRunWorkflowspass-throughVerification
vitest run tools/oxlint-plugins/serverFacts.test.ts scripts/server-fact-gate.test.ts scripts/hooks: 137 passed. Each new exemption was removed in turn and its valid case went red.typecheck:tools,oxlint --type-awareandoxfmt --checkare clean. knip and the fallow audit pass on the 5 changed files.useBillingCapabilities.ts:130-148) are removed by FE-3366 refactor(billing): render capability reads without the redundant isCloud guard #20805.Plan position
TDD: Server-fact guardrails. Parent: FE-3360.
is_original_ownerServerFacttype