Repository navigation
[backport cloud/1.56] FE-3366 feat(lint): refine server-fact rules from the full-repo audit - #20812
Conversation
…#20806) ## Why FE-3366 (L6) audited all 167 existing server-fact findings on main. About a third were not server-fact derivations at all, and a few real derivations went unreported. The changed-line gate and the write hook (#20679) fire on any edit to a flagged line, so every false positive blocks a legitimate edit, and every gap lets a real derivation through. ## Root cause The first version of the rules (#20681) was tuned on the incident PRs. The full-repo audit found shapes it misread: - local in-flight, read or form state treated as server state - non-boolean bindings seeded from a capability treated as capabilities - lowercase client catalog keys matched as server tiers - type guards, label copy and sort comparators reported - browser and library error text matched as server messages It also missed `workspaceRole === 'owner'` (only the exact name `role` matched) and capability pass-throughs such as `canRunWorkflows`. ## How Each change has RuleTester valid and invalid cases at its boundary. All incident cases stay invalid. - **Local UI state:** in-flight, form and read state (`topupOperation`, `operation`, `paymentLocked`, `isValidAmount`, `hasResolvedCapabilities`, `snapshotAuthoritative`, `isReady`, `isHiddenOnSection`) and `failed.*` load-error flags may narrow a capability, never grant it. - **Propagation:** only boolean-valued capability bindings propagate. An unknown type still counts, so `lifecycleActionPermitted` keeps its findings. - **Tier literals:** only server tiers (`SubscriptionTier`, typed as `Record<SubscriptionTier, true>` so typecheck fails when the enum changes) are matched. - **Skipped shapes:** runtime type guards (`x is T`). Comparisons whose every branch is a `t(...)` label. Comparators passed to `.sort` or `.toSorted`. - **Lone status:** a single status equality that is the whole test of an `if` or ternary and picks a value is allowed. A branch returning a boolean still counts as a step of a gate. Tier is not exempted, because #19455 was tier gating. - **`message.includes`:** reported only in `src/platform/errorCatalog/**`, where the receiver is server error text. - **Gaps closed:** - Role comparisons and `?? 'owner'` fallbacks now also match names ending in `Role`, excluding user-chosen `targetRole`, `selectedRole`, `newRole` and `nextRole`. - `const canX = computed(() => toValue(obj.canX))` counts as that capability. - **Dead code:** removed `hasLapsedTeamPlan` (`useTeamPlan.ts`), which has no production reader. **Known residual:** `WorkspaceMembersPanelContent.vue:38`, `failed.members || (canViewPendingInvites && failed.invites)`. A load-error flag ORed with a narrowed capability has the same shape as the guarded `(cap && !isLoading) || isSaving`, and the AST can't tell "show an error" from "grant access". Exempting it would weaken that guard. It's an existing line, so it's only checked if edited. ## AS IS / TO BE No UI change. | Full repo, `serverFacts.oxlintrc.json` over `src` and `apps/*/src` (tests excluded) | AS IS | TO BE | |---|---|---| | Findings | 167 | 147 (31 false positives removed, 11 real derivations newly reported) | | `workspaceRole === 'owner'`, `canRunWorkflows` pass-through | not reported | reported | ## Verification - `vitest run tools/oxlint-plugins/serverFacts.test.ts scripts/server-fact-gate.test.ts scripts/hooks`: 137 passed. Each new exemption was removed in turn and its valid case went red. - `typecheck:tools`, `oxlint --type-aware` and `oxfmt --check` are clean. knip and the fallow audit pass on the 5 changed files. - The remaining 147, grouped by kind, are listed in FE-3366. Seven of them (`useBillingCapabilities.ts:130-148`) are removed by #20805. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1: render seven capability reads | FE-3366 | #20805 | In review | | **L6 lint rule refinement** | **FE-3366** | **this PR** | **In review** | | L6 A2: downgrade reads `is_original_owner` | FE-3366 | — | Waiting on backend confirmation | | L1 `ServerFact` type | FE-3361 | — | Design done, decisions pending | | L2 local providers | FE-3362 | — | Not started | ```mermaid graph LR A1["L6 A1 (PR 20805)"] R["L6 rule refinement (this PR)"]:::current A2["L6 A2"] L1["L1 ServerFact type"] A1 --> L1 L1 --> L2["L2 local providers"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-12T00:23:52.747Z",
"gitSha": "98148c88ef0e7b4ccb123d8c5f5e3bbe39434787",
"branch": "backport-20806-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.7370000000296,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4000000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.648,
"heapDeltaBytes": 644752,
"heapUsedBytes": 68108720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.724000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.1489999999703,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.5920000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.41400000000004,
"heapDeltaBytes": 574428,
"heapUsedBytes": 68407340,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.814000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1747.5829999999632,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.566999999999998,
"layouts": 12,
"layoutDurationMs": 4.065,
"taskDurationMs": 749.444,
"heapDeltaBytes": -2119408,
"heapUsedBytes": 66786060,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 154.173,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1773.7399999999752,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.982999999999997,
"layouts": 12,
"layoutDurationMs": 4.132000000000001,
"taskDurationMs": 785.206,
"heapDeltaBytes": -1715412,
"heapUsedBytes": 66079804,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 161.44599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.6749999999756,
"styleRecalcs": 33,
"styleRecalcDurationMs": 10.699,
"layouts": 6,
"layoutDurationMs": 1.2679999999999998,
"taskDurationMs": 346.725,
"heapDeltaBytes": 4105464,
"heapUsedBytes": 72339732,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.793000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352933,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.3740000000298,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.194999999999999,
"layouts": 6,
"layoutDurationMs": 1.348,
"taskDurationMs": 364.559,
"heapDeltaBytes": 4046420,
"heapUsedBytes": 72004076,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.165000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 679.9520000000143,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.6249999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.947,
"heapDeltaBytes": -6856924,
"heapUsedBytes": 61061740,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 167.375,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926843,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 664.8300000000518,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.408,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.131,
"heapDeltaBytes": -6464084,
"heapUsedBytes": 61375292,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 160.067,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1138.6999999999716,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 788.4019999999999,
"heapDeltaBytes": 15833556,
"heapUsedBytes": 84845100,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 63.337,
"eventListeners": 0,
"totalBlockingTimeMs": 504,
"frameDurationMs": 33.33235294117645,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1153.092000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.7220000000001,
"heapDeltaBytes": 38407348,
"heapUsedBytes": 107801344,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 70.01899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 520,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.1089999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.30800000000016,
"heapDeltaBytes": 17771904,
"heapUsedBytes": 104582576,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 161.704,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.0560000000996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.85200000000015,
"heapDeltaBytes": 17687024,
"heapUsedBytes": 105394440,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 167.578,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10082.753000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9193.050000000001,
"heapDeltaBytes": -16064624,
"heapUsedBytes": 68414848,
"domNodes": -142,
"jsHeapTotalBytes": -11145216,
"scriptDurationMs": 7600.724,
"eventListeners": -74,
"totalBlockingTimeMs": 1037,
"frameDurationMs": 33.949158249158245,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8702.212000000032,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6690000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8067.339000000001,
"heapDeltaBytes": 3233596,
"heapUsedBytes": 81280804,
"domNodes": -142,
"jsHeapTotalBytes": -7999488,
"scriptDurationMs": 6853.49,
"eventListeners": -78,
"totalBlockingTimeMs": 896,
"frameDurationMs": 34.93855421686747,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10003.510000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9260.043,
"heapDeltaBytes": 15417944,
"heapUsedBytes": 94328628,
"domNodes": -143,
"jsHeapTotalBytes": 1699840,
"scriptDurationMs": 7755.110999999999,
"eventListeners": -82,
"totalBlockingTimeMs": 1483,
"frameDurationMs": 35.910071942446045,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9356.33800000005,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5369999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8569.879,
"heapDeltaBytes": -909328,
"heapUsedBytes": 83266904,
"domNodes": -143,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 7045.09,
"eventListeners": -82,
"totalBlockingTimeMs": 797,
"frameDurationMs": 32.5773519163763,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2007.8229999999735,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.42599999999993,
"heapDeltaBytes": -7693080,
"heapUsedBytes": 77396296,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 30.981999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2012.5639999999976,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.995000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.87,
"heapDeltaBytes": -6830040,
"heapUsedBytes": 78156336,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.308000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2326.909999999998,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.184999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1544.6899999999998,
"heapDeltaBytes": -19001128,
"heapUsedBytes": 70435860,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 837.0609999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665467625899282,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2257.9170000000204,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.876999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1525.2050000000002,
"heapDeltaBytes": -19304732,
"heapUsedBytes": 70089720,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 823.782,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665185185185187,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3550.9720000000016,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.720999999999998,
"layouts": 60,
"layoutDurationMs": 14.146,
"taskDurationMs": 1649.2710000000002,
"heapDeltaBytes": 1245832,
"heapUsedBytes": 69349148,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 795.01,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665727699530517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3601.15600000006,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.197000000000001,
"layouts": 60,
"layoutDurationMs": 13.722999999999999,
"taskDurationMs": 1655.695,
"heapDeltaBytes": 908448,
"heapUsedBytes": 69530092,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 803.582,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662037037037,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3086.1360000000104,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.323999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1886.73,
"heapDeltaBytes": -14061124,
"heapUsedBytes": 68443184,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 976.3259999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130427,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3115.3860000000577,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.483999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1941.4599999999998,
"heapDeltaBytes": 8809728,
"heapUsedBytes": 77420312,
"domNodes": 0,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 1047.479,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2010.0370000000112,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6370000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.0730000000001,
"heapDeltaBytes": -9243220,
"heapUsedBytes": 80492668,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.227000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.838999999938,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5120000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.267,
"heapDeltaBytes": -9422492,
"heapUsedBytes": 80877292,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.04599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.8410000000035,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.285999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.308,
"heapDeltaBytes": -12275640,
"heapUsedBytes": 58207340,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.233,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.5930000000044,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.208000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.894,
"heapDeltaBytes": -11633652,
"heapUsedBytes": 57477872,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.237,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.0830000000092,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7800000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.82800000000003,
"heapDeltaBytes": 1089084,
"heapUsedBytes": 70690804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.029999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4869999999555,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9330000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.07,
"heapDeltaBytes": 1079792,
"heapUsedBytes": 70865600,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.124000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9439999999877,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.1,
"layouts": 16,
"layoutDurationMs": 5.712,
"taskDurationMs": 732.162,
"heapDeltaBytes": -6031188,
"heapUsedBytes": 63742368,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.07799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.3850000000448,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.755,
"layouts": 16,
"layoutDurationMs": 5.053999999999999,
"taskDurationMs": 724.734,
"heapDeltaBytes": -6258088,
"heapUsedBytes": 63599444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.967,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.9380000000256,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.137000000000004,
"layouts": 5,
"layoutDurationMs": 14.687000000000003,
"taskDurationMs": 950.8099999999997,
"heapDeltaBytes": 1124092,
"heapUsedBytes": 96153228,
"domNodes": 14227,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 33.03300000000001,
"eventListeners": 2463,
"totalBlockingTimeMs": 138,
"frameDurationMs": 19.632876712328766,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8374.490999999978,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.513999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5502.437,
"heapDeltaBytes": -18168320,
"heapUsedBytes": 70677080,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2751.901,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699201596806386,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8656.769000000055,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.172,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5541.76,
"heapDeltaBytes": -19317116,
"heapUsedBytes": 69776180,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 2742.9949999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698069498069497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17628.461000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16891.293999999998,
"heapDeltaBytes": -36209152,
"heapUsedBytes": 178597924,
"domNodes": -3045,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 257.45300000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.756756756756758,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18064.71399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17253.216,
"heapDeltaBytes": -34874388,
"heapUsedBytes": 178700752,
"domNodes": -3045,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 297.34800000000007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.54027072758037,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21350.994999999955,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.043999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20924.519,
"heapDeltaBytes": -46299640,
"heapUsedBytes": 169454820,
"domNodes": -3045,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 849.134,
"eventListeners": -14915,
"totalBlockingTimeMs": 39,
"frameDurationMs": 38.846909090909094,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22253.243999999995,
"styleRecalcs": 180,
"styleRecalcDurationMs": 19.963000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21848.957,
"heapDeltaBytes": -14545124,
"heapUsedBytes": 184352564,
"domNodes": -3045,
"jsHeapTotalBytes": 6983680,
"scriptDurationMs": 899.198,
"eventListeners": -14915,
"totalBlockingTimeMs": 8,
"frameDurationMs": 40.89926470588235,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6309.980000000052,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.625,
"layouts": 20,
"layoutDurationMs": 23.236000000000008,
"taskDurationMs": 6207.418,
"heapDeltaBytes": 1232744,
"heapUsedBytes": 223060952,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 105.515,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.28121212121213,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6546.660999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.49000000000001,
"layouts": 20,
"layoutDurationMs": 24.603,
"taskDurationMs": 6379.249,
"heapDeltaBytes": 15012624,
"heapUsedBytes": 213043800,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 114.31099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.38722222222223,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8910.403999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8653.729,
"heapDeltaBytes": -32910272,
"heapUsedBytes": 180672676,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 154.78700000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.37440273037543,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8871.320999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8579.584000000003,
"heapDeltaBytes": -34442136,
"heapUsedBytes": 179451068,
"domNodes": -3045,
"jsHeapTotalBytes": 544768,
"scriptDurationMs": 133.35400000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.203754266211607,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 126.58299999998235,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.011999999999999,
"layouts": 3,
"layoutDurationMs": 1.913,
"taskDurationMs": 88.31,
"heapDeltaBytes": 3888084,
"heapUsedBytes": 63486800,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.576,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.433333333333394,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "workflow-execution",
"durationMs": 136.87700000002678,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.233,
"layouts": 3,
"layoutDurationMs": 1.5619999999999998,
"taskDurationMs": 88.03500000000003,
"heapDeltaBytes": 3728848,
"heapUsedBytes": 69509996,
"domNodes": 114,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.343999999999994,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66249999999991,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 880.16099999993,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.572,
"layouts": 76,
"layoutDurationMs": 25.13,
"taskDurationMs": 854.441,
"heapDeltaBytes": 17868392,
"heapUsedBytes": 84058648,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 353.485,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 830.4219999999987,
"styleRecalcs": 78,
"styleRecalcDurationMs": 100.633,
"layouts": 76,
"layoutDurationMs": 23.633000000000003,
"taskDurationMs": 799.64,
"heapDeltaBytes": 17540564,
"heapUsedBytes": 82738104,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 328.986,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1427.0739999999478,
"styleRecalcs": 78,
"styleRecalcDurationMs": 270.934,
"layouts": 76,
"layoutDurationMs": 30.226,
"taskDurationMs": 1400.001,
"heapDeltaBytes": 8503844,
"heapUsedBytes": 115449388,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 478.89799999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.14177215189872,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1320.145000000025,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.63000000000002,
"layouts": 76,
"layoutDurationMs": 27.654999999999998,
"taskDurationMs": 1301.906,
"heapDeltaBytes": 8377236,
"heapUsedBytes": 119584184,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 439.415,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.877215189873407,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2199 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c0e240c3ffb18695d5d4c17dd7293152f732041d
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20812 +/- ##
=============================================
Coverage ? 85.88%
=============================================
Files ? 2484
Lines ? 141671
Branches ? 38552
=============================================
Hits ? 121670
Misses ? 19618
Partials ? 383
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff is identical to #20806.
Backport of #20806 to
cloud/1.56Automatically created by backport workflow.