Repository navigation
[backport core/1.56] FE-3366 feat(lint): refine server-fact rules from the full-repo audit - #20811
Conversation
…#20806) ## Why FE-3366 (L6) audited all 167 existing server-fact findings on main. About a third were not server-fact derivations at all, and a few real derivations went unreported. The changed-line gate and the write hook (#20679) fire on any edit to a flagged line, so every false positive blocks a legitimate edit, and every gap lets a real derivation through. ## Root cause The first version of the rules (#20681) was tuned on the incident PRs. The full-repo audit found shapes it misread: - local in-flight, read or form state treated as server state - non-boolean bindings seeded from a capability treated as capabilities - lowercase client catalog keys matched as server tiers - type guards, label copy and sort comparators reported - browser and library error text matched as server messages It also missed `workspaceRole === 'owner'` (only the exact name `role` matched) and capability pass-throughs such as `canRunWorkflows`. ## How Each change has RuleTester valid and invalid cases at its boundary. All incident cases stay invalid. - **Local UI state:** in-flight, form and read state (`topupOperation`, `operation`, `paymentLocked`, `isValidAmount`, `hasResolvedCapabilities`, `snapshotAuthoritative`, `isReady`, `isHiddenOnSection`) and `failed.*` load-error flags may narrow a capability, never grant it. - **Propagation:** only boolean-valued capability bindings propagate. An unknown type still counts, so `lifecycleActionPermitted` keeps its findings. - **Tier literals:** only server tiers (`SubscriptionTier`, typed as `Record<SubscriptionTier, true>` so typecheck fails when the enum changes) are matched. - **Skipped shapes:** runtime type guards (`x is T`). Comparisons whose every branch is a `t(...)` label. Comparators passed to `.sort` or `.toSorted`. - **Lone status:** a single status equality that is the whole test of an `if` or ternary and picks a value is allowed. A branch returning a boolean still counts as a step of a gate. Tier is not exempted, because #19455 was tier gating. - **`message.includes`:** reported only in `src/platform/errorCatalog/**`, where the receiver is server error text. - **Gaps closed:** - Role comparisons and `?? 'owner'` fallbacks now also match names ending in `Role`, excluding user-chosen `targetRole`, `selectedRole`, `newRole` and `nextRole`. - `const canX = computed(() => toValue(obj.canX))` counts as that capability. - **Dead code:** removed `hasLapsedTeamPlan` (`useTeamPlan.ts`), which has no production reader. **Known residual:** `WorkspaceMembersPanelContent.vue:38`, `failed.members || (canViewPendingInvites && failed.invites)`. A load-error flag ORed with a narrowed capability has the same shape as the guarded `(cap && !isLoading) || isSaving`, and the AST can't tell "show an error" from "grant access". Exempting it would weaken that guard. It's an existing line, so it's only checked if edited. ## AS IS / TO BE No UI change. | Full repo, `serverFacts.oxlintrc.json` over `src` and `apps/*/src` (tests excluded) | AS IS | TO BE | |---|---|---| | Findings | 167 | 147 (31 false positives removed, 11 real derivations newly reported) | | `workspaceRole === 'owner'`, `canRunWorkflows` pass-through | not reported | reported | ## Verification - `vitest run tools/oxlint-plugins/serverFacts.test.ts scripts/server-fact-gate.test.ts scripts/hooks`: 137 passed. Each new exemption was removed in turn and its valid case went red. - `typecheck:tools`, `oxlint --type-aware` and `oxfmt --check` are clean. knip and the fallow audit pass on the 5 changed files. - The remaining 147, grouped by kind, are listed in FE-3366. Seven of them (`useBillingCapabilities.ts:130-148`) are removed by #20805. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1: render seven capability reads | FE-3366 | #20805 | In review | | **L6 lint rule refinement** | **FE-3366** | **this PR** | **In review** | | L6 A2: downgrade reads `is_original_owner` | FE-3366 | — | Waiting on backend confirmation | | L1 `ServerFact` type | FE-3361 | — | Design done, decisions pending | | L2 local providers | FE-3362 | — | Not started | ```mermaid graph LR A1["L6 A1 (PR 20805)"] R["L6 rule refinement (this PR)"]:::current A2["L6 A2"] L1["L1 ServerFact type"] A1 --> L1 L1 --> L2["L2 local providers"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-12T00:23:39.184Z",
"gitSha": "4ab7e01f2225f0795fdb83c7350206395d6a6cf0",
"branch": "backport-20806-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.1359999999745,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0539999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.9980000000001,
"heapDeltaBytes": 818652,
"heapUsedBytes": 69579292,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.206000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.1960000000217,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0489999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.76800000000003,
"heapDeltaBytes": 961464,
"heapUsedBytes": 68959720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.592000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.6389999999783,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.82,
"layouts": 12,
"layoutDurationMs": 4.287,
"taskDurationMs": 774.696,
"heapDeltaBytes": -2247476,
"heapUsedBytes": 65672332,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 158.84300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1779.154999999946,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.309,
"layouts": 12,
"layoutDurationMs": 4.164,
"taskDurationMs": 787.526,
"heapDeltaBytes": -2125464,
"heapUsedBytes": 66532472,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 164.522,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.3350000000146,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.345999999999998,
"layouts": 6,
"layoutDurationMs": 1.147,
"taskDurationMs": 320.77600000000007,
"heapDeltaBytes": 4133276,
"heapUsedBytes": 72620768,
"domNodes": 53,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.569000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.339999999931,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.321,
"layouts": 6,
"layoutDurationMs": 1.251,
"taskDurationMs": 324.639,
"heapDeltaBytes": 4096356,
"heapUsedBytes": 72222972,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.313000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 721.1859999999888,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.189,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.3619999999999,
"heapDeltaBytes": -6784552,
"heapUsedBytes": 61303068,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 167.68099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 720.7230000000209,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.86,
"heapDeltaBytes": -7167220,
"heapUsedBytes": 61078360,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 163.161,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1140.1480000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 791.6080000000001,
"heapDeltaBytes": 15964280,
"heapUsedBytes": 85330976,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 68.09200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 34.34242424242425,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1138.0930000000262,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 793.6089999999999,
"heapDeltaBytes": 14859248,
"heapUsedBytes": 84007552,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 65.298,
"eventListeners": 0,
"totalBlockingTimeMs": 505,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.7490000000453,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.69200000000046,
"heapDeltaBytes": 18865072,
"heapUsedBytes": 104751584,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.67199999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.0860000000566,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.7160000000001,
"heapDeltaBytes": 18485884,
"heapUsedBytes": 104641468,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.51899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8777.742000000018,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.0499999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8015.096,
"heapDeltaBytes": -12943196,
"heapUsedBytes": 71624660,
"domNodes": -142,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 6837.159000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 881,
"frameDurationMs": 34.715415019762844,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8483.474000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7736.628,
"heapDeltaBytes": -16336400,
"heapUsedBytes": 68451800,
"domNodes": -142,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 6553.959,
"eventListeners": -74,
"totalBlockingTimeMs": 610,
"frameDurationMs": 33.79641434262949,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9853.14299999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.48200000000000154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9178.798,
"heapDeltaBytes": 6461792,
"heapUsedBytes": 84131668,
"domNodes": -142,
"jsHeapTotalBytes": -5115904,
"scriptDurationMs": 7700.127,
"eventListeners": -74,
"totalBlockingTimeMs": 1181,
"frameDurationMs": 34.80424028268551,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9620.994999999994,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.699,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8881.960000000001,
"heapDeltaBytes": -8684876,
"heapUsedBytes": 76089648,
"domNodes": -142,
"jsHeapTotalBytes": -5902336,
"scriptDurationMs": 7339.686000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 1036,
"frameDurationMs": 33.38993055555556,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2009.1019999999844,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.703,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.033,
"heapDeltaBytes": -9812392,
"heapUsedBytes": 78589548,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.55100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.4249999999884,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6769999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.2909999999999,
"heapDeltaBytes": -9856356,
"heapUsedBytes": 78557672,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.72,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2278.5319999999842,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.556999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1518.004,
"heapDeltaBytes": -20623392,
"heapUsedBytes": 69263504,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 839.671,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78823529411765,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2315.666999999962,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.355999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1555.5689999999997,
"heapDeltaBytes": -19299660,
"heapUsedBytes": 70894932,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 836.368,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66521739130435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3570.300999999972,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.383000000000001,
"layouts": 60,
"layoutDurationMs": 13.933,
"taskDurationMs": 1602.751,
"heapDeltaBytes": 1557264,
"heapUsedBytes": 69924300,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 774.807,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3604.616999999962,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.362999999999998,
"layouts": 60,
"layoutDurationMs": 14.025999999999998,
"taskDurationMs": 1623.3369999999998,
"heapDeltaBytes": 1636500,
"heapUsedBytes": 69423292,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 780.046,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3085.2560000000153,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.73,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.4060000000002,
"heapDeltaBytes": 5164652,
"heapUsedBytes": 73945016,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 998.2010000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75597826086957,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3194.026000000008,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.669999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1898.5879999999997,
"heapDeltaBytes": 17630592,
"heapUsedBytes": 86513064,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1038.429,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753684210526316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.1359999999981,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.014999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.98599999999993,
"heapDeltaBytes": -8968808,
"heapUsedBytes": 80632748,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.424999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2013.8409999999567,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6969999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.77399999999994,
"heapDeltaBytes": -8470364,
"heapUsedBytes": 81417328,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.058,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 618.4030000000007,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.776000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.19999999999993,
"heapDeltaBytes": -11744784,
"heapUsedBytes": 57789992,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 145.235,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.9419999999991,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.141000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.622,
"heapDeltaBytes": 9339284,
"heapUsedBytes": 71278324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 151.392,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.6099999999997,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.323,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.86400000000003,
"heapDeltaBytes": 1128400,
"heapUsedBytes": 70620792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.227000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.7350000000115,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.347000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.706,
"heapDeltaBytes": 1064892,
"heapUsedBytes": 70209112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.202,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.5480000000211,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.575,
"layouts": 16,
"layoutDurationMs": 5.364000000000001,
"taskDurationMs": 717.603,
"heapDeltaBytes": -5983252,
"heapUsedBytes": 63557628,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.17500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.7350000000133,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.576,
"layouts": 16,
"layoutDurationMs": 4.98,
"taskDurationMs": 711.908,
"heapDeltaBytes": -5936504,
"heapUsedBytes": 63780608,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 105.71300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.4589999999844,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.787999999999997,
"layouts": 5,
"layoutDurationMs": 14.366999999999997,
"taskDurationMs": 899.7369999999997,
"heapDeltaBytes": 3053468,
"heapUsedBytes": 94339008,
"domNodes": 14227,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 30.486,
"eventListeners": 2463,
"totalBlockingTimeMs": 133,
"frameDurationMs": 19.367567567567566,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8389.745000000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.116,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5455.856,
"heapDeltaBytes": -19345844,
"heapUsedBytes": 69636136,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2749.288,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66613545816733,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8357.545000000073,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.698,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5393.404,
"heapDeltaBytes": -19161920,
"heapUsedBytes": 69321720,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2736.791,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16800.267000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16123.460000000001,
"heapDeltaBytes": -37489020,
"heapUsedBytes": 180781060,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 243.81000000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.28164983164983,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16873.25599999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16290.171,
"heapDeltaBytes": -33150380,
"heapUsedBytes": 180030844,
"domNodes": -3045,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 244.70999999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.68350340136054,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21295.376999999975,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.380000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20871.503999999997,
"heapDeltaBytes": -42938912,
"heapUsedBytes": 169665452,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 867.228,
"eventListeners": -14915,
"totalBlockingTimeMs": 26,
"frameDurationMs": 39.3083179297597,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 22431.186000000023,
"styleRecalcs": 179,
"styleRecalcDurationMs": 20.16000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22053.299,
"heapDeltaBytes": -36333244,
"heapUsedBytes": 174907236,
"domNodes": -3045,
"jsHeapTotalBytes": 8179712,
"scriptDurationMs": 956.626,
"eventListeners": -14915,
"totalBlockingTimeMs": 36,
"frameDurationMs": 42.08705440900563,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6341.249000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.83099999999999,
"layouts": 20,
"layoutDurationMs": 23.483000000000004,
"taskDurationMs": 6233.244000000001,
"heapDeltaBytes": 1193680,
"heapUsedBytes": 216781816,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 103.914,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.07784090909092,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6204.911000000038,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.785,
"layouts": 20,
"layoutDurationMs": 23.244,
"taskDurationMs": 6032.595,
"heapDeltaBytes": 1004992,
"heapUsedBytes": 213758096,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 101.315,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.225568181818176,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8618.653999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8220.847000000002,
"heapDeltaBytes": -33942388,
"heapUsedBytes": 179834684,
"domNodes": -3045,
"jsHeapTotalBytes": 5029888,
"scriptDurationMs": 122.19299999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.207796610169503,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8677.482000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8376.137999999999,
"heapDeltaBytes": -23230416,
"heapUsedBytes": 179616656,
"domNodes": -3045,
"jsHeapTotalBytes": 282624,
"scriptDurationMs": 168.37999999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.081879194630876,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 466.2460000000692,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.090000000000002,
"layouts": 3,
"layoutDurationMs": 0.8910000000000003,
"taskDurationMs": 110.77999999999999,
"heapDeltaBytes": 5611944,
"heapUsedBytes": 65481980,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.299000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 116.13299999999072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.724999999999998,
"layouts": 3,
"layoutDurationMs": 0.895,
"taskDurationMs": 75.838,
"heapDeltaBytes": 3761944,
"heapUsedBytes": 69655040,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.364000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.68333333333324,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 827.5110000000723,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.76100000000001,
"layouts": 76,
"layoutDurationMs": 24.032999999999998,
"taskDurationMs": 800.798,
"heapDeltaBytes": 17546376,
"heapUsedBytes": 82786768,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 330.294,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665999999999986,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 805.3340000000162,
"styleRecalcs": 78,
"styleRecalcDurationMs": 98.655,
"layouts": 76,
"layoutDurationMs": 22.828999999999997,
"taskDurationMs": 782.952,
"heapDeltaBytes": 17195648,
"heapUsedBytes": 82861580,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 319.534,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448968,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1423.8550000000032,
"styleRecalcs": 78,
"styleRecalcDurationMs": 269.289,
"layouts": 76,
"layoutDurationMs": 29.932,
"taskDurationMs": 1407.5800000000002,
"heapDeltaBytes": 8497664,
"heapUsedBytes": 115210780,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 484.257,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.37435897435896,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1416.1379999999326,
"styleRecalcs": 78,
"styleRecalcDurationMs": 264.626,
"layouts": 76,
"layoutDurationMs": 30.32,
"taskDurationMs": 1375.841,
"heapDeltaBytes": -19053268,
"heapUsedBytes": 110490712,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 466.341,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.693827160493836,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2203 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1a20ec611685b40d180f5ba046ccc33c3cf1f87a
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20811 +/- ##
============================================
Coverage 85.83% 85.84%
============================================
Files 2475 2475
Lines 141312 141311 -1
Branches 38457 36483 -1974
============================================
+ Hits 121300 121308 +8
+ Misses 19629 19620 -9
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff is identical to #20806.
Backport of #20806 to
core/1.56Automatically created by backport workflow.