Repository navigation
[backport core/1.56] FE-3355 test(workspace): orthogonality tests for members-panel server-fact gates - #20698
Conversation
…-fact gates (#20694) ## Why BE-19903 and BE-19904 shipped because members-panel gates recombined a server capability with plan state, seats and role. #19455 hid the derivation behind a helper and an `if`/`return`, so the lint rules (#20679) can't see it. The existing tests also didn't catch it: they mocked the capability at the composable, and one asserted the derivation as expected behaviour. ## Root cause No test asserted the property that matters: **a gate's output depends only on its server fact.** Each test pinned one combination of inputs, so a gate that also read `isPlanEnded` passed every test that didn't happen to flip it. ## How - **`describeServerFactGate`** (`src/utils/__tests__/serverFactGate.ts`, about 50 lines). Given a fact setter, a list of non-fact perturbations, `mount` and `read`, it generates `it.for` cases over both fact values and every perturbation: - Each perturbation must leave `read()` unchanged. - Flipping only the fact must change it. - The fact is set after the perturbation, so a perturbation can't override it. - **Applied to the Cloud members-panel gates** in `useMembersPanel.test.ts`: | Gate | Fact | Reads | |---|---|---| | Invite | `can_invite_members` | `showInviteButton`, `isInviteDisabled`, `permissions.canInviteMembers` | | Member management | `can_manage_members` | `canManageMembers`, `canViewPendingInvites`, `uiConfig.showPendingTab`, member menu non-empty | | Roster visibility | members response (`membersLoaded`) | `canViewOtherMembers`, `showMembersList` | Shared perturbations: - plan ended, Enterprise, ended Enterprise with `maxSeats` 1, `maxSeats` 1 - personal plan, cancel scheduled - not a billing manager, member role - `can_change_seats` flipped Each gate also flips the capabilities it must not depend on. Invite flips `can_manage_members`, management flips `can_invite_members`, and roster flips both, so one capability can't stand in for another. - **`CODEOWNERS`**: `/src/platform/workspace/` gets the billing owners. The incident lived there, and it was the only billing-adjacent path without owners. ## AS IS / TO BE There is no UI change. These are test outcomes on the two historical defects, each reintroduced by hand and not committed: | Mutation | AS IS (tests before this PR) | TO BE | |---|---|---| | #18662 disjunct back on Cloud `showInviteButton` (`canInviteMembers \|\| (isPlanEnded && canManageSubscription)`) | Existing suite still asserted it pre-#20674 | 4 failures, including "ignores an ended plan when the fact is false" and "ignores an ended Enterprise plan with one seat when the fact is false" | | #15675 substitution (`canManageMembers` ← `canChangeSeats`) | Not caught by an orthogonality case | 27 failures, including "ignores a flipped can_change_seats" (fact true and false) and "changes when the fact flips" | | After revert | — | 158 passed | ## Verification - `vitest run src/platform/workspace/composables/useMembersPanel.test.ts`: 158 passed. - oxlint `--type-aware` and oxfmt `--check` pass on touched files. The pre-commit hook ran `typecheck:app`. - No existing Cloud test still asserts a derivation (#20674 already flipped them), so none were rewritten. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3349. | Item | Ticket | PR | Status | |---|---|---|---| | S1 ADR + S2 lint gate + S3/S4 hooks (folded) | FE-3350..FE-3353 | #20679 | In review | | S5 `pendingServerFact` + expiry CI | FE-3354 | #20680 | Merged (backports #20692, #20693) | | **S6 orthogonality tests + CODEOWNERS** | **FE-3355** | **this PR** | **In review** | | S7 cloud agent instructions | FE-3356 | cloud#12741 | Merged | ```mermaid graph LR S1["S1-S4 ADR, lint gate, hooks (PR 20679)"] S5["S5 pendingServerFact (PR 20680, merged)"] -. "exempted by" .-> S1 P20674["PR 20674 member capabilities (merged)"] --> S6["S6 orthogonality tests (this PR)"]:::current S6 -. "covers what lint cannot" .-> S1 S7["S7 cloud AGENTS.md (merged)"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-10T22:18:30.264Z",
"gitSha": "aeef014dc59b510e2e41c782c11c3593b1807cc8",
"branch": "backport-20694-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.482000000015,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.635000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.291,
"heapDeltaBytes": 379600,
"heapUsedBytes": 69486028,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.320000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2013.3060000000569,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.4520000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.9,
"heapDeltaBytes": 614708,
"heapUsedBytes": 68027712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.469000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1827.3719999999685,
"styleRecalcs": 73,
"styleRecalcDurationMs": 19.211000000000002,
"layouts": 12,
"layoutDurationMs": 4.9319999999999995,
"taskDurationMs": 850.1070000000001,
"heapDeltaBytes": -1892336,
"heapUsedBytes": 65585584,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 174.64499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66545454545455,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.3030000000017,
"styleRecalcs": 79,
"styleRecalcDurationMs": 22.656000000000002,
"layouts": 12,
"layoutDurationMs": 5.666,
"taskDurationMs": 920.1949999999999,
"heapDeltaBytes": -2095936,
"heapUsedBytes": 65161408,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 181.051,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.4889999999918,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.908,
"layouts": 6,
"layoutDurationMs": 1.6650000000000003,
"taskDurationMs": 383.71200000000005,
"heapDeltaBytes": 4084252,
"heapUsedBytes": 71899548,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.753000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6673076923077,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.918000000016,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.084000000000001,
"layouts": 6,
"layoutDurationMs": 1.6599999999999997,
"taskDurationMs": 401.29499999999996,
"heapDeltaBytes": 4060136,
"heapUsedBytes": 71766288,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.361999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 764.5819999999617,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.803999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.276,
"heapDeltaBytes": -6487204,
"heapUsedBytes": 61455900,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 186.327,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66739130434784,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 779.1050000000723,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.720000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.3679999999999,
"heapDeltaBytes": -7091272,
"heapUsedBytes": 61316224,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 181.43400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1169.1810000000373,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 839.048,
"heapDeltaBytes": 37537772,
"heapUsedBytes": 105413344,
"domNodes": 0,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 75.03999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 542,
"frameDurationMs": 35.35454545454545,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1157.1809999999232,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 819.297,
"heapDeltaBytes": 15718316,
"heapUsedBytes": 85510636,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 69.991,
"eventListeners": 0,
"totalBlockingTimeMs": 520,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.2550000000424,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.8800000000001,
"heapDeltaBytes": 17323100,
"heapUsedBytes": 104486504,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 188.24400000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 241,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.9709999999595,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.0230000000001,
"heapDeltaBytes": 17816692,
"heapUsedBytes": 104987932,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 184.79800000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.23714285714289,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10952.115999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9916.216,
"heapDeltaBytes": -3122312,
"heapUsedBytes": 74441884,
"domNodes": -142,
"jsHeapTotalBytes": -6426624,
"scriptDurationMs": 8199.357000000002,
"eventListeners": -78,
"totalBlockingTimeMs": 1485,
"frameDurationMs": 34.1653125,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10019.70899999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9185.964,
"heapDeltaBytes": -16595464,
"heapUsedBytes": 68639660,
"domNodes": -142,
"jsHeapTotalBytes": -12455936,
"scriptDurationMs": 7574.657999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 983,
"frameDurationMs": 33.11092715231788,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10358.544999999993,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4999999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9498.419,
"heapDeltaBytes": -12032684,
"heapUsedBytes": 72783996,
"domNodes": -143,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 7781.915,
"eventListeners": -82,
"totalBlockingTimeMs": 1117,
"frameDurationMs": 33.71205211726384,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9978.545000000053,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9116.068000000001,
"heapDeltaBytes": -3391116,
"heapUsedBytes": 80501344,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 7462.945000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 1082,
"frameDurationMs": 33.332107023411375,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2039.0459999999848,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.393000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.146,
"heapDeltaBytes": -10151160,
"heapUsedBytes": 78022300,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 35.303000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2021.1249999999836,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.1930000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.4149999999998,
"heapDeltaBytes": -7315308,
"heapUsedBytes": 78346044,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 42.35,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2781.5650000000005,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.172999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1712.0789999999997,
"heapDeltaBytes": -17716336,
"heapUsedBytes": 71606900,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 930.5729999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666467065868257,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2734.158999999977,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.918999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1597.1190000000001,
"heapDeltaBytes": -19519908,
"heapUsedBytes": 70329508,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 915.0240000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3829.098999999985,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.749000000000002,
"layouts": 60,
"layoutDurationMs": 16.275000000000002,
"taskDurationMs": 1832.619,
"heapDeltaBytes": -18512224,
"heapUsedBytes": 68906908,
"domNodes": 24,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 880.3859999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665652173913045,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3934.1929999999365,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.458000000000002,
"layouts": 60,
"layoutDurationMs": 17.017,
"taskDurationMs": 1866.238,
"heapDeltaBytes": 1230316,
"heapUsedBytes": 69712236,
"domNodes": 24,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 881.79,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3122.883999999999,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.696999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1938.9689999999998,
"heapDeltaBytes": 8332908,
"heapUsedBytes": 77104376,
"domNodes": 0,
"jsHeapTotalBytes": 2322432,
"scriptDurationMs": 1005.6180000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846486486486484,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3197.1679999999196,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.489999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2048.4010000000003,
"heapDeltaBytes": 17949116,
"heapUsedBytes": 86316784,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1063.268,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75421052631579,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.124000000029,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.5299999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.552,
"heapDeltaBytes": -9554016,
"heapUsedBytes": 80569424,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.19599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.4889999999978,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.7610000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.373,
"heapDeltaBytes": 13425132,
"heapUsedBytes": 81077596,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.287000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.3509999999819,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.153,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.94800000000004,
"heapDeltaBytes": -12401504,
"heapUsedBytes": 58421464,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 151.53699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 718.3999999999742,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.280000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.006,
"heapDeltaBytes": -11638212,
"heapUsedBytes": 57862016,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 160.245,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.9750000000117,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.285,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.433,
"heapDeltaBytes": 1060744,
"heapUsedBytes": 71119444,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.165000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.6209999999628,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.011000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.017,
"heapDeltaBytes": 1154528,
"heapUsedBytes": 70549468,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.940999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1775.6290000000376,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.764,
"layouts": 16,
"layoutDurationMs": 7.507,
"taskDurationMs": 868.483,
"heapDeltaBytes": -5984020,
"heapUsedBytes": 63205088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 129.384,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.3079999999936,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.336,
"layouts": 16,
"layoutDurationMs": 6.373,
"taskDurationMs": 805.707,
"heapDeltaBytes": -5942060,
"heapUsedBytes": 64223624,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 120.99399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1422.7600000000393,
"styleRecalcs": 17,
"styleRecalcDurationMs": 32.084,
"layouts": 5,
"layoutDurationMs": 15.290000000000004,
"taskDurationMs": 1007.4909999999999,
"heapDeltaBytes": 1005200,
"heapUsedBytes": 95939580,
"domNodes": 14227,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 33.624,
"eventListeners": 2463,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.634246575342456,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9522.183999999981,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.01200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6060.121,
"heapDeltaBytes": -6009680,
"heapUsedBytes": 79330064,
"domNodes": 0,
"jsHeapTotalBytes": 753664,
"scriptDurationMs": 3004.866,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666140350877193,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10505.93600000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.24400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6332.009,
"heapDeltaBytes": -4431096,
"heapUsedBytes": 83957748,
"domNodes": 0,
"jsHeapTotalBytes": 1277952,
"scriptDurationMs": 3088.409,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666031746031745,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 19136.38199999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18383.083,
"heapDeltaBytes": -44365840,
"heapUsedBytes": 178799184,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 308.277,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.07249134948096,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 19774.710999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19079.969,
"heapDeltaBytes": -48450268,
"heapUsedBytes": 178511432,
"domNodes": -3045,
"jsHeapTotalBytes": 4214784,
"scriptDurationMs": 356.128,
"eventListeners": -14919,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.375304347826095,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 24715.449000000037,
"styleRecalcs": 181,
"styleRecalcDurationMs": 26.168999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24330.917,
"heapDeltaBytes": -38450476,
"heapUsedBytes": 185350180,
"domNodes": -3046,
"jsHeapTotalBytes": -155648,
"scriptDurationMs": 990.3439999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 31,
"frameDurationMs": 45.93996282527881,
"p95FrameDurationMs": 100
},
{
"name": "vue-large-graph-pan",
"durationMs": 25396.645000000033,
"styleRecalcs": 181,
"styleRecalcDurationMs": 27.146999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25112.906000000003,
"heapDeltaBytes": -45228112,
"heapUsedBytes": 176380540,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 992.1220000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 20,
"frameDurationMs": 48.07272727272728,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 6925.733999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.15699999999998,
"layouts": 20,
"layoutDurationMs": 27.17399999999999,
"taskDurationMs": 6796.773999999999,
"heapDeltaBytes": 1221048,
"heapUsedBytes": 214764032,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 124.37899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 17,
"frameDurationMs": 39.74885057471264,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 7071.908000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.94799999999996,
"layouts": 20,
"layoutDurationMs": 26.929999999999996,
"taskDurationMs": 6956.337,
"heapDeltaBytes": 9173988,
"heapUsedBytes": 219830504,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 135.70100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.34999999999999,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9896.961000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9625.724,
"heapDeltaBytes": -18334408,
"heapUsedBytes": 184726988,
"domNodes": -3045,
"jsHeapTotalBytes": 13127680,
"scriptDurationMs": 161.92000000000007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.22989323843416,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9815.682000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9502.951,
"heapDeltaBytes": -32394824,
"heapUsedBytes": 179508852,
"domNodes": -3045,
"jsHeapTotalBytes": 8441856,
"scriptDurationMs": 161.55800000000008,
"eventListeners": -14915,
"totalBlockingTimeMs": 26,
"frameDurationMs": 34.32631578947368,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 500.86899999996604,
"styleRecalcs": 22,
"styleRecalcDurationMs": 28.211,
"layouts": 5,
"layoutDurationMs": 2.618,
"taskDurationMs": 174.75199999999995,
"heapDeltaBytes": 6141552,
"heapUsedBytes": 71771048,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.764,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.237931034482745,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 479.2040000000952,
"styleRecalcs": 13,
"styleRecalcDurationMs": 15.596,
"layouts": 3,
"layoutDurationMs": 1.3200000000000003,
"taskDurationMs": 122.89499999999998,
"heapDeltaBytes": 5674220,
"heapUsedBytes": 71247924,
"domNodes": 101,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.605000000000006,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1285.4680000000371,
"styleRecalcs": 78,
"styleRecalcDurationMs": 129.795,
"layouts": 76,
"layoutDurationMs": 34.809,
"taskDurationMs": 1252.109,
"heapDeltaBytes": 20599340,
"heapUsedBytes": 90199872,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 511.92499999999995,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.579452054794512,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1281.1619999999948,
"styleRecalcs": 78,
"styleRecalcDurationMs": 125.18499999999999,
"layouts": 76,
"layoutDurationMs": 34.757999999999996,
"taskDurationMs": 1253.365,
"heapDeltaBytes": 21112184,
"heapUsedBytes": 90536248,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 519.09,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.111999999999995,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1709.7199999999475,
"styleRecalcs": 78,
"styleRecalcDurationMs": 326.454,
"layouts": 76,
"layoutDurationMs": 35.471000000000004,
"taskDurationMs": 1688.708,
"heapDeltaBytes": 8777040,
"heapUsedBytes": 115605812,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 554.471,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.934146341463418,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1681.2519999999722,
"styleRecalcs": 78,
"styleRecalcDurationMs": 313.98900000000003,
"layouts": 76,
"layoutDurationMs": 34.542,
"taskDurationMs": 1649.0170000000003,
"heapDeltaBytes": 8798532,
"heapUsedBytes": 115014576,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 547.8179999999999,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.528048780487797,
"p95FrameDurationMs": 33.399999999999636
}
]
}🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 83ba9d094f6cd991a1bb70538b4ad54c499163db
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Clean backport: the diff is identical to #20694.
|
Blocked on #20715, not on anything in this diff. All nine red checks here are the same Measured locally, both directions:
So this is an ordering inversion — the test carrier was opened ahead of its product dependency — rather than a defect to repair here. Worth flagging: adapting the test file to the current branch state would be counterproductive. #20715 rewrites that same test file and the same composable, so an adapted version would conflict with it, and it would pin the behaviour #20674 deliberately changes. The order is #20715 → this PR, then refresh this branch so the three required checks ( The approval here is not at risk from that refresh: |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20698 +/- ##
==========================================
Coverage 85.84% 85.84%
==========================================
Files 2471 2472 +1
Lines 141115 141130 +15
Branches 36444 36444
==========================================
+ Hits 121142 121159 +17
+ Misses 19590 19588 -2
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #20694 to
core/1.56Automatically created by backport workflow.