Repository navigation
FE-3351 feat(lint): server-fact rules gated on changed lines - #20681
dante01yoon merged 8 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2c6455a3bded88c026639669910178bb41877afa
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2250 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T22:44:42.031Z",
"gitSha": "1adad351bbbc0eedd1161dbeef341b6fb877bef4",
"branch": "jaewon/fe-3351-server-fact-lint",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.3780000000406,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4749999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.23100000000005,
"heapDeltaBytes": 5493092,
"heapUsedBytes": 62134884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.001000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2058.807999999999,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.470999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.06600000000003,
"heapDeltaBytes": -43668916,
"heapUsedBytes": 56879912,
"domNodes": -238,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.051999999999998,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1747.478000000001,
"styleRecalcs": 52,
"styleRecalcDurationMs": 13.644,
"layouts": 12,
"layoutDurationMs": 2.9059999999999997,
"taskDurationMs": 801.22,
"heapDeltaBytes": 916992,
"heapUsedBytes": 57948880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.144,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1765.9039999999777,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.112,
"layouts": 12,
"layoutDurationMs": 3.352,
"taskDurationMs": 811.977,
"heapDeltaBytes": 1328892,
"heapUsedBytes": 58034708,
"domNodes": -214,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 155.88500000000002,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.570999999968,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.3629999999999995,
"layouts": 3,
"layoutDurationMs": 0.6970000000000001,
"taskDurationMs": 357.787,
"heapDeltaBytes": 6765148,
"heapUsedBytes": 63653912,
"domNodes": 47,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.972999999999999,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.9820000000018,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.279,
"layouts": 3,
"layoutDurationMs": 0.7150000000000001,
"taskDurationMs": 276.425,
"heapDeltaBytes": 6784108,
"heapUsedBytes": 63501568,
"domNodes": 47,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.673000000000002,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.5150000000403,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.945,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.68799999999993,
"heapDeltaBytes": 18543284,
"heapUsedBytes": 75262728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.85199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 645.7980000000134,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.792000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.94100000000003,
"heapDeltaBytes": 18510772,
"heapUsedBytes": 75521752,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.322,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1189.3799999999715,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 858.3870000000001,
"heapDeltaBytes": 13984824,
"heapUsedBytes": 97243464,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 69.60499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 557,
"frameDurationMs": 34.80000000000002,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1158.4900000000289,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 819.8700000000001,
"heapDeltaBytes": 15963776,
"heapUsedBytes": 98096736,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 67.051,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.8909999999673,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.10699999999986,
"heapDeltaBytes": 21096752,
"heapUsedBytes": 127699084,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 176.081,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.0030000000297,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.57599999999957,
"heapDeltaBytes": 19192280,
"heapUsedBytes": 97609984,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.87800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.762857142857165,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10430.923000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9533.403999999999,
"heapDeltaBytes": 3415528,
"heapUsedBytes": 86332636,
"domNodes": 0,
"jsHeapTotalBytes": -19136512,
"scriptDurationMs": 7781.776,
"eventListeners": 0,
"totalBlockingTimeMs": 958,
"frameDurationMs": 31.904892966360862,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9037.603999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8215.938999999998,
"heapDeltaBytes": -13499520,
"heapUsedBytes": 69996348,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 6943.112,
"eventListeners": 0,
"totalBlockingTimeMs": 711,
"frameDurationMs": 32.72789855072464,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9599.20199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8785.963,
"heapDeltaBytes": -1120800,
"heapUsedBytes": 81895584,
"domNodes": 0,
"jsHeapTotalBytes": -21757952,
"scriptDurationMs": 7167.816,
"eventListeners": 0,
"totalBlockingTimeMs": 685,
"frameDurationMs": 31.68217821782178,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9651.441999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8800.968,
"heapDeltaBytes": -8047436,
"heapUsedBytes": 69302056,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 7152.883,
"eventListeners": 0,
"totalBlockingTimeMs": 642,
"frameDurationMs": 31.32987012987013,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 184.53899999997248,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.606,
"layouts": 5,
"layoutDurationMs": 1.6240000000000003,
"taskDurationMs": 144.407,
"heapDeltaBytes": 12107072,
"heapUsedBytes": 78784564,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.058000000000002,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912500000000023,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-combo-open",
"durationMs": 211.07999999992444,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.312,
"layouts": 5,
"layoutDurationMs": 1.71,
"taskDurationMs": 149.996,
"heapDeltaBytes": 12131904,
"heapUsedBytes": 76109896,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.276,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.659999999999947,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2044.9310000000196,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.381000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.0670000000001,
"heapDeltaBytes": -39779636,
"heapUsedBytes": 85760040,
"domNodes": -333,
"jsHeapTotalBytes": -4554752,
"scriptDurationMs": 34.952999999999996,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2047.551999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5180000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.459,
"heapDeltaBytes": -39237664,
"heapUsedBytes": 84745472,
"domNodes": -313,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 32.613,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2284.3729999999596,
"styleRecalcs": 65,
"styleRecalcDurationMs": 5.274000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1575.18,
"heapDeltaBytes": 19111736,
"heapUsedBytes": 85194984,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 823.738,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666423357664243,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2318.844000000013,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.625000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1599.197,
"heapDeltaBytes": 16242512,
"heapUsedBytes": 81921856,
"domNodes": -313,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 815.3130000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66521739130435,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3537.3050000000035,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.912000000000001,
"layouts": 60,
"layoutDurationMs": 9.465,
"taskDurationMs": 1554.395,
"heapDeltaBytes": 15328392,
"heapUsedBytes": 98707924,
"domNodes": 24,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 837.012,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3651.875999999902,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.849000000000002,
"layouts": 60,
"layoutDurationMs": 10.253,
"taskDurationMs": 1712.6350000000002,
"heapDeltaBytes": 13912496,
"heapUsedBytes": 84123032,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 814.272,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666210045662098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3013.2220000000416,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.432,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.0159999999998,
"heapDeltaBytes": 20825424,
"heapUsedBytes": 87973908,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 980.2839999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85337078651685,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2957.580000000007,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.102000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1908.1319999999996,
"heapDeltaBytes": 18078004,
"heapUsedBytes": 85954984,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 969.087,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.856571428571428,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.153999999986,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.5510000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.3370000000001,
"heapDeltaBytes": 20740608,
"heapUsedBytes": 86503244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.16400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.1159999999873,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4219999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.49199999999996,
"heapDeltaBytes": 23262356,
"heapUsedBytes": 93762404,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 38.133999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 544.7449999999776,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.286,
"heapDeltaBytes": 12009560,
"heapUsedBytes": 69231532,
"domNodes": -236,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.21800000000002,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665624999999977,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.5909999999876,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.409000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.48699999999997,
"heapDeltaBytes": -7818776,
"heapUsedBytes": 64309540,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 149.648,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7140000000213,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5380000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.124,
"heapDeltaBytes": 5526952,
"heapUsedBytes": 62973788,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.165000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.2590000000382,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.628,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.1499999999999,
"heapDeltaBytes": 5537252,
"heapUsedBytes": 62320324,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.586999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.16299999998,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.907000000000002,
"layouts": 16,
"layoutDurationMs": 4.002999999999999,
"taskDurationMs": 781.4449999999999,
"heapDeltaBytes": 23861728,
"heapUsedBytes": 81004608,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 108.602,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.9080000000276,
"styleRecalcs": 87,
"styleRecalcDurationMs": 20.511000000000003,
"layouts": 16,
"layoutDurationMs": 4.4190000000000005,
"taskDurationMs": 1024.1680000000001,
"heapDeltaBytes": -2196512,
"heapUsedBytes": 61785040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.8629999999112,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.406000000000002,
"layouts": 5,
"layoutDurationMs": 14.511,
"taskDurationMs": 999.6150000000001,
"heapDeltaBytes": 34000780,
"heapUsedBytes": 112096816,
"domNodes": 14650,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 33.22899999999999,
"eventListeners": 2456,
"totalBlockingTimeMs": 128,
"frameDurationMs": 19.405479452054788,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8403.013999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.465999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5651.273,
"heapDeltaBytes": -39813852,
"heapUsedBytes": 86090988,
"domNodes": -313,
"jsHeapTotalBytes": -3575808,
"scriptDurationMs": 2678.6510000000003,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600397614314,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8732.049000000075,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.741,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5716.118,
"heapDeltaBytes": -39249672,
"heapUsedBytes": 86361596,
"domNodes": -333,
"jsHeapTotalBytes": -4100096,
"scriptDurationMs": 2700.3810000000003,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698087954110896,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18700.70899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18013.033999999996,
"heapDeltaBytes": -35488660,
"heapUsedBytes": 184274524,
"domNodes": -3046,
"jsHeapTotalBytes": 5439488,
"scriptDurationMs": 275.65099999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.747707979626483,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18835.113999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18181.379,
"heapDeltaBytes": -31508312,
"heapUsedBytes": 184832684,
"domNodes": -3046,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 290.485,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.163931623931624,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 24136.742000000027,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.99700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23758.253,
"heapDeltaBytes": -31208040,
"heapUsedBytes": 189132384,
"domNodes": -3046,
"jsHeapTotalBytes": 4333568,
"scriptDurationMs": 964.2040000000001,
"eventListeners": -14913,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.88661710037174,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23860.14799999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.420999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23484.963,
"heapDeltaBytes": -29719384,
"heapUsedBytes": 189377276,
"domNodes": -3047,
"jsHeapTotalBytes": 5935104,
"scriptDurationMs": 878.631,
"eventListeners": -14913,
"totalBlockingTimeMs": 32,
"frameDurationMs": 43.790275229357796,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6921.856000000048,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.34899999999998,
"layouts": 20,
"layoutDurationMs": 23.742,
"taskDurationMs": 6775.679,
"heapDeltaBytes": 5195584,
"heapUsedBytes": 221043468,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 120.13099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.75,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6722.374000000059,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.46499999999997,
"layouts": 20,
"layoutDurationMs": 22.984000000000005,
"taskDurationMs": 6589.313,
"heapDeltaBytes": -13780548,
"heapUsedBytes": 217114136,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 111.373,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.19944751381216,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9600.973999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9212.167,
"heapDeltaBytes": -32422552,
"heapUsedBytes": 184240116,
"domNodes": -3046,
"jsHeapTotalBytes": 7163904,
"scriptDurationMs": 166.90899999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.10206896551723,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7328.215,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6805.025000000001,
"heapDeltaBytes": -19364692,
"heapUsedBytes": 188189860,
"domNodes": -3046,
"jsHeapTotalBytes": 13852672,
"scriptDurationMs": 123.066,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.964379084967316,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 505.3029999999126,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.462999999999997,
"layouts": 4,
"layoutDurationMs": 1.3710000000000002,
"taskDurationMs": 148.486,
"heapDeltaBytes": 6591760,
"heapUsedBytes": 62883460,
"domNodes": 134,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.305000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 441.8340000000853,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.562999999999995,
"layouts": 4,
"layoutDurationMs": 1.6869999999999998,
"taskDurationMs": 112.33999999999999,
"heapDeltaBytes": 6152556,
"heapUsedBytes": 62568076,
"domNodes": 103,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.812,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 846.4159999999765,
"styleRecalcs": 77,
"styleRecalcDurationMs": 85.836,
"layouts": 76,
"layoutDurationMs": 18.093999999999998,
"taskDurationMs": 815.6,
"heapDeltaBytes": 17930460,
"heapUsedBytes": 94407072,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 332.702,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 881.5479999999525,
"styleRecalcs": 77,
"styleRecalcDurationMs": 88.759,
"layouts": 76,
"layoutDurationMs": 18.778,
"taskDurationMs": 861.877,
"heapDeltaBytes": 18351412,
"heapUsedBytes": 92320744,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 360.921,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1368.5839999999416,
"styleRecalcs": 77,
"styleRecalcDurationMs": 246.567,
"layouts": 76,
"layoutDurationMs": 20.295,
"taskDurationMs": 1350.1970000000001,
"heapDeltaBytes": 13584616,
"heapUsedBytes": 135502896,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 472.963,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.510126582278495,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1354.4620000000123,
"styleRecalcs": 77,
"styleRecalcDurationMs": 244.346,
"layouts": 76,
"layoutDurationMs": 19.822,
"taskDurationMs": 1339.65,
"heapDeltaBytes": 13549160,
"heapUsedBytes": 136431520,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 462.924,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.29873417721517,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaewon/fe-3350-server-facts-adr #20681 +/- ##
==================================================================
Coverage ? 85.97%
==================================================================
Files ? 3626
Lines ? 173439
Branches ? 45845
==================================================================
Hits ? 149117
Misses ? 22295
Partials ? 2027
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Blocking: deletion-only edits can bypass the changed-line gate because their new-side anchor is shifted by one line.
Full context for agent readers
In a unified diff, +N,0 means the deletion happened before new line N, so the surviving boundary is N - 1. This parser stores after: N, and touches then requires a diagnostic to extend past N. A deletion that removes an operator or unwraps pendingServerFact at the end of a multiline expression can therefore miss the expression it changed. Please derive the boundary from real zero-context git diff output (after: start - 1) and add a regression where a deletion-only hunk makes a previously allowed expression forbidden.
…ct literals no-capability-recombination reports a billing capability combined with other state or chosen by a client-side condition. no-server-fact-literals reports role, tier and billing status literal comparisons, role fallbacks and server message text matching. Both skip pendingServerFact(...) and load from a dedicated config, not the root one, per docs/adr/API-SERVER-FACTS-0042-server-facts-are-rendered-not-derived.md
lint:server-facts runs the server-fact rules on changed src and apps/*/src files and fails only when a finding's span touches a changed or deleted line, including findings that start on an unchanged line of a multi-line expression. Existing findings on untouched code do not block.
Run lint:server-facts against the PR base, the merge-group base and the pushed range, feeding the required lint-and-format context, and run it once per commit from lint-staged when code is staged.
A config or plugin load failure printed a JSON parse stack instead of oxlint's own message; exit 2 with oxlint's output instead.
A -U0 deletion hunk '+N,0' sits between new lines N and N+1. Unwrapping a pendingServerFact call deletes lines just before and just after the expression, which the gate missed. A deletion now touches a finding when its boundary is inside or adjacent to the finding's span, so deleting a line right next to an existing finding also reports it.
Per ADR rule 1, loading, in-flight and validity flags may delay or disable a control but never grant it. no-capability-recombination now allows a logical expression whose only non-capability operands are listed local UI flags, when the operator can only narrow: cap && local, or !cap || local. Shapes that could grant (cap || local, !cap && local) and server-derived flags stay findings.
42c5695 to
0e62254
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Confirmed the deletion-boundary fix in touches(): the new condition covers both edges of a deletion-only hunk, matching the regression test added for it. Zero open threads, CI fully green. Approving.
… and approve time (#20682)
…DR, changed-line lint gate, agent hooks) (Comfy-Org#20679) > **This PR now carries the whole short-term stack.** The approved children were folded into this branch: Comfy-Org#20681 (S2 server-fact oxlint rules + changed-line gate, FE-3351) and Comfy-Org#20682 (S3/S4 write and approve hooks, FE-3352 / FE-3353). Each was reviewed and approved on its own PR. The reviewer-visible diff since the docs-only version is those two PRs plus two ADR wording commits: `83e85827ef` (rule 1 scoped to entitlement; local UI state may only narrow) and `2c6455a3bd` (enforcement described as planned per ticket, per CodeRabbit). ## Why Agents keep writing, and approving, frontend code that recombines server facts (capabilities, role, tier, plan status, seats, timestamps) into decisions the backend owns. The latest case shipped two billing P0s (BE-19903, BE-19904) through Comfy-Org#15675, Comfy-Org#18662 and Comfy-Org#19455. About 20 fixes since April moved a decision back to the server. ## Root cause There is no repo-level rule for this. The one piece of guidance that touches it points the other way: `docs/guidance/state-and-effects.md` says "Derive everything derivable", and its first example is a `can*` flag. A reviewer-side prose rule existed, and Comfy-Org#18662 and Comfy-Org#19455 were approved anyway. ## How - **`docs/adr/API-SERVER-FACTS-0042`** records the rule (R1–R5): a gate renders one server fact as received; `isCloud` picks the build, not the permission; failed reads use contract defaults, never role or tier fallbacks; a missing fact is a backend ticket plus `pendingServerFact`. It also records the rejected alternatives. - **`AGENTS.md`** gets one Common Pitfalls line linking the ADR, so every author's agent reads it. - **`state-and-effects.md` §4** now scopes "derive everything derivable" to state the feature owns, and sends server facts to the API. The `canTransition` example is dropped. Enforcement (lint rules, write and approve hooks, orthogonality tests, the `pendingServerFact` expiry check) follows in the sibling tickets below. This PR is the text those checks link to. ## AS IS / TO BE Docs only. There is no UI change. | | AS IS | TO BE | |---|---|---| | Repo rule | none | ADR + `AGENTS.md` line | | `state-and-effects.md` §4 | "derive everything derivable", `canTransition` example | feature-owned state only; server facts render the API field | ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3349. | Item | Ticket | PR | Status | |---|---|---|---| | **S1 ADR + AGENTS.md + guidance** | **FE-3350** | **this PR** | **In review** | | S2 oxlint rules, diff-scoped gate | FE-3351 | — | Next | | S3 write hook | FE-3352 | — | Blocked by S2 | | S4 approve hook | FE-3353 | — | Blocked by S2 | | S5 `pendingServerFact` + expiry CI | FE-3354 | — | Needs `LINEAR_API_KEY` secret | | S6 orthogonality tests + CODEOWNERS | FE-3355 | — | After Comfy-Org#20674 | | S7 cloud agent instructions | FE-3356 | — | Blocked by S1 | ```mermaid graph LR S1["S1 ADR (this PR)"]:::current --> S7["S7 cloud AGENTS.md"] S2["S2 oxlint rules"] --> S3["S3 write hook"] S2 --> S4["S4 approve hook"] S5["S5 pendingServerFact"] S6["S6 orthogonality tests"] P20674["PR 20674 member capabilities"] --> S6 classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
…Comfy-Org#20806) ## Why FE-3366 (L6) audited all 167 existing server-fact findings on main. About a third were not server-fact derivations at all, and a few real derivations went unreported. The changed-line gate and the write hook (Comfy-Org#20679) fire on any edit to a flagged line, so every false positive blocks a legitimate edit, and every gap lets a real derivation through. ## Root cause The first version of the rules (Comfy-Org#20681) was tuned on the incident PRs. The full-repo audit found shapes it misread: - local in-flight, read or form state treated as server state - non-boolean bindings seeded from a capability treated as capabilities - lowercase client catalog keys matched as server tiers - type guards, label copy and sort comparators reported - browser and library error text matched as server messages It also missed `workspaceRole === 'owner'` (only the exact name `role` matched) and capability pass-throughs such as `canRunWorkflows`. ## How Each change has RuleTester valid and invalid cases at its boundary. All incident cases stay invalid. - **Local UI state:** in-flight, form and read state (`topupOperation`, `operation`, `paymentLocked`, `isValidAmount`, `hasResolvedCapabilities`, `snapshotAuthoritative`, `isReady`, `isHiddenOnSection`) and `failed.*` load-error flags may narrow a capability, never grant it. - **Propagation:** only boolean-valued capability bindings propagate. An unknown type still counts, so `lifecycleActionPermitted` keeps its findings. - **Tier literals:** only server tiers (`SubscriptionTier`, typed as `Record<SubscriptionTier, true>` so typecheck fails when the enum changes) are matched. - **Skipped shapes:** runtime type guards (`x is T`). Comparisons whose every branch is a `t(...)` label. Comparators passed to `.sort` or `.toSorted`. - **Lone status:** a single status equality that is the whole test of an `if` or ternary and picks a value is allowed. A branch returning a boolean still counts as a step of a gate. Tier is not exempted, because Comfy-Org#19455 was tier gating. - **`message.includes`:** reported only in `src/platform/errorCatalog/**`, where the receiver is server error text. - **Gaps closed:** - Role comparisons and `?? 'owner'` fallbacks now also match names ending in `Role`, excluding user-chosen `targetRole`, `selectedRole`, `newRole` and `nextRole`. - `const canX = computed(() => toValue(obj.canX))` counts as that capability. - **Dead code:** removed `hasLapsedTeamPlan` (`useTeamPlan.ts`), which has no production reader. **Known residual:** `WorkspaceMembersPanelContent.vue:38`, `failed.members || (canViewPendingInvites && failed.invites)`. A load-error flag ORed with a narrowed capability has the same shape as the guarded `(cap && !isLoading) || isSaving`, and the AST can't tell "show an error" from "grant access". Exempting it would weaken that guard. It's an existing line, so it's only checked if edited. ## AS IS / TO BE No UI change. | Full repo, `serverFacts.oxlintrc.json` over `src` and `apps/*/src` (tests excluded) | AS IS | TO BE | |---|---|---| | Findings | 167 | 147 (31 false positives removed, 11 real derivations newly reported) | | `workspaceRole === 'owner'`, `canRunWorkflows` pass-through | not reported | reported | ## Verification - `vitest run tools/oxlint-plugins/serverFacts.test.ts scripts/server-fact-gate.test.ts scripts/hooks`: 137 passed. Each new exemption was removed in turn and its valid case went red. - `typecheck:tools`, `oxlint --type-aware` and `oxfmt --check` are clean. knip and the fallow audit pass on the 5 changed files. - The remaining 147, grouped by kind, are listed in FE-3366. Seven of them (`useBillingCapabilities.ts:130-148`) are removed by Comfy-Org#20805. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1: render seven capability reads | FE-3366 | Comfy-Org#20805 | In review | | **L6 lint rule refinement** | **FE-3366** | **this PR** | **In review** | | L6 A2: downgrade reads `is_original_owner` | FE-3366 | — | Waiting on backend confirmation | | L1 `ServerFact` type | FE-3361 | — | Design done, decisions pending | | L2 local providers | FE-3362 | — | Not started | ```mermaid graph LR A1["L6 A1 (PR 20805)"] R["L6 rule refinement (this PR)"]:::current A2["L6 A2"] L1["L1 ServerFact type"] A1 --> L1 L1 --> L2["L2 local providers"] classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
Why
Three PRs that agents wrote and agents approved shipped two billing P0s (BE-19903, BE-19904) by recombining server facts on the client:
isCloud ? canChangeSeats.value : workspaceRole.value === 'owner'canInviteMembers.value || (isPlanEnded.value && permissions.value.canManageSubscription)A reviewer-side prose rule was in place and both later PRs were approved anyway. This PR adds a check that exits non-zero.
Root cause
Nothing mechanical catches this class. A rule written as prose loses to the task in the agent's context. And the existing
oxlint-suppressions.jsoncount baseline can't hold the line for new code. I replayed the incidents with a prototype: #19455 edited a line inside an expression that was already flagged, so the file's finding count didn't rise and a count gate would have passed it.How
Two rules in
tools/oxlint-plugins/serverFacts.ts.comfy/no-capability-recombinationtracks bindings fromuseBillingCapabilities()(destructured, held as an object, or aliased through acomputed) and.can_*fields. It reports when one is combined through&&,||or??(?? falseis allowed), or chosen by a ternary on a non-literal condition. That covers bothisCloud ? capability : roleand the fix(billing): gate plan CTAs on the server capability set, not a client-derived one #16967 proxy choice.comfy/no-server-fact-literalsreports:rolecompared with'owner' | 'member' | 'admin'tier,billingStatusorsubscriptionStatuscompared with a string literalrole ?? 'owner'fallbacks*.message.includes(...)Both rules skip anything inside
pendingServerFact(...)(FE-3354 feat(serverFacts): pendingServerFact bridge that expires with its backend ticket #20680).Gate on changed lines, not on counts. The rules are not enabled in the root
.oxlintrc.json, because main has 159 existing findings. Instead,pnpm lint:server-factsruns them through a dedicated config (serverFacts.oxlintrc.json) on the changedsrc/andapps/*/src/files, and fails when a finding's span intersects a changed line..vueoffsets count from the start of the file.Wiring.
server-factsjob inci-lint-format.yamlandci-lint-format-queue.yaml. These feed the requiredlint-and-formatcontext, so no branch-protection change is needed.push, the queue job gatesgithub.event.before..HEADand skips branch-creation pushes.--staged.Deferred from the TDD, because both kinds were mostly false positives on main:
isCloud: 170 hits, mostly build switchesReview follow-ups (TDD comments, 2026-10-09)
0e62254639). Following the ADR's revised rule 1,cap && !isLoadingand!cap || isSubmittingare allowed when every other operand is a local UI flag from a small exact table (LOCAL_UI_STATE: loading, pending, submitting, form validity, and the like). Shapes that could grant entitlement stay findings:cap || isLoading,!cap && isLoading. So do server-derived names such ashasMemberSeats,isPlanEnded,isTeamPlanandisSubscribed. The full-repo count is unchanged at 159.2961703bbe). A+N,0deletion now touches a finding whenfirst <= N + 1 && last >= N. Before, removing the line right after a multi-line expression (unwrappingpendingServerFact(…)) slipped through. A real-diff acceptance test runs the gate on a deletion-only edit that removes the wrapper and requires exit 1. With the old inequality, 3 tests fail. Trade-off: deleting the line right next to an existing finding now reports that finding, and a test documents it.AS IS / TO BE
There is no UI change. The difference is what the gate does with the incident commits:
91e89697d9)useMembersPanel.ts:133-1371a981659b6)useMembersPanel.ts:253canInviteMembers.value || (isPlanEnded…)no findings on changed linesThe #18662 replay was rerun independently: a detached worktree at
1a981659b6^withcherry-pick -n, then the gate with--base 1a981659b6^.Verification
vitest run tools/oxlint-plugins/serverFacts.test.ts scripts/server-fact-gate.test.ts scripts/lint-staged-config.test.ts: 57 passed. The rule tests include the incident shapes as invalid cases and hard negatives as valid ones:result.status === 'ok',msg.role === 'user',isCloud && isNightly, a capability rendered alone,?? false, apendingServerFactwrapper, and a localcanClose.options.canTopUpvalid case.pendingServerFactskip fails its case.Plan position
TDD: Server-fact guardrails. Parent: FE-3349.
pendingServerFact+ expiry CI