Skip to content

FE-3351 feat(lint): server-fact rules gated on changed lines - #20681

Merged
dante01yoon merged 8 commits into
jaewon/fe-3350-server-facts-adrfrom
jaewon/fe-3351-server-fact-lint
Oct 9, 2026
Merged

dante01yoon merged 8 commits into
jaewon/fe-3350-server-facts-adrfrom
jaewon/fe-3351-server-fact-lint

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #20679 (ADR-API-SERVER-FACTS-0042). The rule messages link to that ADR, and ci-adr-links-validation needs the file to exist. Retarget to main once #20679 lands.

Why

Three PRs that agents wrote and agents approved shipped two billing P0s (BE-19903, BE-19904) by recombining server facts on the client:

A reviewer-side prose rule was in place and both later PRs were approved anyway. This PR adds a check that exits non-zero.

Root cause

Nothing mechanical catches this class. A rule written as prose loses to the task in the agent's context. And the existing oxlint-suppressions.json count baseline can't hold the line for new code. I replayed the incidents with a prototype: #19455 edited a line inside an expression that was already flagged, so the file's finding count didn't rise and a count gate would have passed it.

How

  • Two rules in tools/oxlint-plugins/serverFacts.ts.

    • comfy/no-capability-recombination tracks bindings from useBillingCapabilities() (destructured, held as an object, or aliased through a computed) and .can_* fields. It reports when one is combined through &&, || or ?? (?? false is allowed), or chosen by a ternary on a non-literal condition. That covers both isCloud ? capability : role and the fix(billing): gate plan CTAs on the server capability set, not a client-derived one #16967 proxy choice.
    • comfy/no-server-fact-literals reports:
      • role compared with 'owner' | 'member' | 'admin'
      • tier, billingStatus or subscriptionStatus compared with a string literal
      • role ?? 'owner' fallbacks
      • *.message.includes(...)

    Both rules skip anything inside pendingServerFact(...) (FE-3354 feat(serverFacts): pendingServerFact bridge that expires with its backend ticket #20680).

  • Gate on changed lines, not on counts. The rules are not enabled in the root .oxlintrc.json, because main has 159 existing findings. Instead, pnpm lint:server-facts runs them through a dedicated config (serverFacts.oxlintrc.json) on the changed src/ and apps/*/src/ files, and fails when a finding's span intersects a changed line.

  • Wiring.

    • A server-facts job in ci-lint-format.yaml and ci-lint-format-queue.yaml. These feed the required lint-and-format context, so no branch-protection change is needed.
    • On push, the queue job gates github.event.before..HEAD and skips branch-creation pushes.
    • The pre-commit hook runs --staged.
  • Deferred from the TDD, because both kinds were mostly false positives on main:

    • standalone isCloud: 170 hits, mostly build switches
    • local clock vs server timestamp: 16 hits, mostly cache TTLs

Review follow-ups (TDD comments, 2026-10-09)

  • Local UI state may narrow a capability (0e62254639). Following the ADR's revised rule 1, cap && !isLoading and !cap || isSubmitting are allowed when every other operand is a local UI flag from a small exact table (LOCAL_UI_STATE: loading, pending, submitting, form validity, and the like). Shapes that could grant entitlement stay findings: cap || isLoading, !cap && isLoading. So do server-derived names such as hasMemberSeats, isPlanEnded, isTeamPlan and isSubscribed. The full-repo count is unchanged at 159.
  • Deletion at a finding's boundary counts (2961703bbe). A +N,0 deletion now touches a finding when first <= N + 1 && last >= N. Before, removing the line right after a multi-line expression (unwrapping pendingServerFact(…)) slipped through. A real-diff acceptance test runs the gate on a deletion-only edit that removes the wrapper and requires exit 1. With the old inequality, 3 tests fail. Trade-off: deleting the line right next to an existing finding now reports that finding, and a test documents it.

AS IS / TO BE

There is no UI change. The difference is what the gate does with the incident commits:

Replay AS IS TO BE
#15675 (91e89697d9) passes exit 1, 44 findings incl. useMembersPanel.ts:133-137
#18662 (1a981659b6) passes exit 1, incl. useMembersPanel.ts:253 canInviteMembers.value || (isPlanEnded…)
This branch vs main n/a no findings on changed lines

The #18662 replay was rerun independently: a detached worktree at 1a981659b6^ with cherry-pick -n, then the gate with --base 1a981659b6^.

Verification

  • vitest run tools/oxlint-plugins/serverFacts.test.ts scripts/server-fact-gate.test.ts scripts/lint-staged-config.test.ts: 57 passed. The rule tests include the incident shapes as invalid cases and hard negatives as valid ones: result.status === 'ok', msg.role === 'user', isCloud && isNightly, a capability rendered alone, ?? false, a pendingServerFact wrapper, and a local canClose.
  • Mutation checks. Each of these was introduced and then reverted:
  • On this repo, the full scan with the dedicated config gives 159 production findings (103 literals, 56 recombination). None of them are gated until those lines change.

Plan position

TDD: Server-fact guardrails. Parent: FE-3349.

Item Ticket PR Status
S1 ADR + AGENTS.md + guidance FE-3350 #20679 In review (base of this PR)
S2 oxlint rules, diff-scoped gate FE-3351 this PR In review
S3 write hook FE-3352 — Next, reuses this gate
S4 approve hook FE-3353 — Next, reuses this gate
S5 pendingServerFact + expiry CI FE-3354 #20680 In review
S6 orthogonality tests + CODEOWNERS FE-3355 — After #20674
S7 cloud agent instructions FE-3356 cloud#12741 In review
graph LR
  S1["S1 ADR (PR 20679)"] --> S2["S2 rules + gate (this PR)"]:::current
  S1 --> S7["S7 cloud AGENTS.md (cloud PR 12741)"]
  S2 --> S3["S3 write hook"]
  S2 --> S4["S4 approve hook"]
  S5["S5 pendingServerFact (PR 20680)"] -. "exempted by" .-> S2
  P20674["PR 20674 member capabilities"] --> S6["S6 orthogonality tests"]
  classDef current fill:#f9d71c,stroke:#333,stroke-width:2px
Loading

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c52b520d-ba17-4fbe-ba66-f4a16efc574c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/09/2026, 11:17:07 PM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2c6455a3bded88c026639669910178bb41877afa

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2250 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2228 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 538ms TBT · 93.1 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 226ms TBT · 107.4 MB heap
extension-clean-combined-draw: · 30.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 835ms TBT · 74.5 MB heap
extension-rgthree-prototype-draw: · 31.7 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 664ms TBT · 72.1 MB heap
large-combo-open: · 44.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 73.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.2 MB heap
legacy-node-drag: · 59.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
subgraph-transition-enter: · 51.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 128ms TBT · 106.9 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
vue-large-graph-idle: · 31.3 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 176.0 MB heap
vue-large-graph-pan: · 22.6 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 16ms TBT · 180.5 MB heap
vue-node-resize-workload: · 26.0 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 208.9 MB heap
vue-zoom-out-idle: · 35.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 177.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.8 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.0 MB heap
agent-composer-long-conversation-typing: · 57.5 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 129.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 429ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.8 MB
canvas-idle: DOM nodes -119
canvas-idle: event listeners -66
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 64
canvas-mouse-sweep: task duration 807ms
canvas-mouse-sweep: script duration 155ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 55.3 MB
canvas-mouse-sweep: DOM nodes -107
canvas-mouse-sweep: event listeners -61
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 3
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 317ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 60.6 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 39
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 461ms
dom-widget-clipping: script duration 168ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.9 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 839ms
dom-widget-order-dense-n200-w200-i120: script duration 68ms
dom-widget-order-dense-n200-w200-i120: TBT 538ms
dom-widget-order-dense-n200-w200-i120: heap used 93.1 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 497ms
dom-widget-order-sparse-n1000-w20-i120: script duration 170ms
dom-widget-order-sparse-n1000-w20-i120: TBT 226ms
dom-widget-order-sparse-n1000-w20-i120: heap used 107.4 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8875ms
extension-clean-combined-draw: script duration 7362ms
extension-clean-combined-draw: TBT 835ms
extension-clean-combined-draw: heap used 74.5 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 8793ms
extension-rgthree-prototype-draw: script duration 7160ms
extension-rgthree-prototype-draw: TBT 664ms
extension-rgthree-prototype-draw: heap used 72.1 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-combo-open: avg frame time 22ms
large-combo-open: p95 frame time 67ms
large-combo-open: layout duration 2ms
large-combo-open: style recalc duration 16ms
large-combo-open: layout count 5
large-combo-open: style recalc count 24
large-combo-open: task duration 147ms
large-combo-open: script duration 8ms
large-combo-open: TBT 0ms
large-combo-open: heap used 73.9 MB
large-combo-open: DOM nodes 918
large-combo-open: event listeners 202
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 586ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.3 MB
large-graph-idle: DOM nodes -323
large-graph-idle: event listeners -126
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 6ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1587ms
large-graph-pan: script duration 820ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.7 MB
large-graph-pan: DOM nodes -157
large-graph-pan: event listeners -61
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1634ms
large-graph-zoom: script duration 826ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 87.2 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1910ms
legacy-node-drag: script duration 975ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 82.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 477ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 86.0 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 371ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 63.7 MB
subgraph-dom-widget-clipping: DOM nodes -118
subgraph-dom-widget-clipping: event listeners -43
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 445ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.7 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 18ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 82
subgraph-mouse-sweep: task duration 903ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.1 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1000ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 128ms
subgraph-transition-enter: heap used 106.9 MB
subgraph-transition-enter: DOM nodes 14650
subgraph-transition-enter: event listeners 2456
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 19ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5684ms
viewport-pan-sweep: script duration 2690ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.2 MB
viewport-pan-sweep: DOM nodes -323
viewport-pan-sweep: event listeners -124
vue-large-graph-idle: avg frame time 32ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18097ms
vue-large-graph-idle: script duration 283ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 176.0 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 44ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 17ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 23622ms
vue-large-graph-pan: script duration 921ms
vue-large-graph-pan: TBT 16ms
vue-large-graph-pan: heap used 180.5 MB
vue-large-graph-pan: DOM nodes -3047
vue-large-graph-pan: event listeners -14913
vue-node-resize-workload: avg frame time 38ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6682ms
vue-node-resize-workload: script duration 116ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 208.9 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 29ms
vue-zoom-out-idle: p95 frame time 50ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8009ms
vue-zoom-out-idle: script duration 145ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 177.6 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 4
workflow-execution: style recalc count 17
workflow-execution: task duration 130ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 59.8 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 73
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 18ms
agent-composer-empty-conversation-typing: style recalc duration 87ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 77
agent-composer-empty-conversation-typing: task duration 839ms
agent-composer-empty-conversation-typing: script duration 347ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 89.0 MB
agent-composer-empty-conversation-typing: DOM nodes 77
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 25ms
agent-composer-long-conversation-typing: layout duration 20ms
agent-composer-long-conversation-typing: style recalc duration 245ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 77
agent-composer-long-conversation-typing: task duration 1345ms
agent-composer-long-conversation-typing: script duration 468ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 129.7 MB
agent-composer-long-conversation-typing: DOM nodes 77
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-09T22:44:42.031Z",
  "gitSha": "1adad351bbbc0eedd1161dbeef341b6fb877bef4",
  "branch": "jaewon/fe-3351-server-fact-lint",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2006.3780000000406,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.4749999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.23100000000005,
      "heapDeltaBytes": 5493092,
      "heapUsedBytes": 62134884,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.001000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2058.807999999999,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.470999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.06600000000003,
      "heapDeltaBytes": -43668916,
      "heapUsedBytes": 56879912,
      "domNodes": -238,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 9.051999999999998,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66612903225806,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1747.478000000001,
      "styleRecalcs": 52,
      "styleRecalcDurationMs": 13.644,
      "layouts": 12,
      "layoutDurationMs": 2.9059999999999997,
      "taskDurationMs": 801.22,
      "heapDeltaBytes": 916992,
      "heapUsedBytes": 57948880,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 153.144,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1765.9039999999777,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 15.112,
      "layouts": 12,
      "layoutDurationMs": 3.352,
      "taskDurationMs": 811.977,
      "heapDeltaBytes": 1328892,
      "heapUsedBytes": 58034708,
      "domNodes": -214,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 155.88500000000002,
      "eventListeners": -122,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1700.570999999968,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 5.3629999999999995,
      "layouts": 3,
      "layoutDurationMs": 0.6970000000000001,
      "taskDurationMs": 357.787,
      "heapDeltaBytes": 6765148,
      "heapUsedBytes": 63653912,
      "domNodes": 47,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.972999999999999,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352944,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.9820000000018,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 6.279,
      "layouts": 3,
      "layoutDurationMs": 0.7150000000000001,
      "taskDurationMs": 276.425,
      "heapDeltaBytes": 6784108,
      "heapUsedBytes": 63501568,
      "domNodes": 47,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.673000000000002,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 626.5150000000403,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.945,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 468.68799999999993,
      "heapDeltaBytes": 18543284,
      "heapUsedBytes": 75262728,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 171.85199999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66486486486485,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 645.7980000000134,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 2.792000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.94100000000003,
      "heapDeltaBytes": 18510772,
      "heapUsedBytes": 75521752,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 163.322,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684193,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1189.3799999999715,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 858.3870000000001,
      "heapDeltaBytes": 13984824,
      "heapUsedBytes": 97243464,
      "domNodes": 0,
      "jsHeapTotalBytes": 1998848,
      "scriptDurationMs": 69.60499999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 557,
      "frameDurationMs": 34.80000000000002,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1158.4900000000289,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 819.8700000000001,
      "heapDeltaBytes": 15963776,
      "heapUsedBytes": 98096736,
      "domNodes": 0,
      "jsHeapTotalBytes": 2260992,
      "scriptDurationMs": 67.051,
      "eventListeners": 0,
      "totalBlockingTimeMs": 518,
      "frameDurationMs": 33.8235294117647,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 875.8909999999673,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.10699999999986,
      "heapDeltaBytes": 21096752,
      "heapUsedBytes": 127699084,
      "domNodes": 0,
      "jsHeapTotalBytes": 3674112,
      "scriptDurationMs": 176.081,
      "eventListeners": 0,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 25.488235294117658,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 859.0030000000297,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.57599999999957,
      "heapDeltaBytes": 19192280,
      "heapUsedBytes": 97609984,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 164.87800000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 219,
      "frameDurationMs": 24.762857142857165,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10430.923000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9533.403999999999,
      "heapDeltaBytes": 3415528,
      "heapUsedBytes": 86332636,
      "domNodes": 0,
      "jsHeapTotalBytes": -19136512,
      "scriptDurationMs": 7781.776,
      "eventListeners": 0,
      "totalBlockingTimeMs": 958,
      "frameDurationMs": 31.904892966360862,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9037.603999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8215.938999999998,
      "heapDeltaBytes": -13499520,
      "heapUsedBytes": 69996348,
      "domNodes": 0,
      "jsHeapTotalBytes": -18874368,
      "scriptDurationMs": 6943.112,
      "eventListeners": 0,
      "totalBlockingTimeMs": 711,
      "frameDurationMs": 32.72789855072464,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9599.20199999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8785.963,
      "heapDeltaBytes": -1120800,
      "heapUsedBytes": 81895584,
      "domNodes": 0,
      "jsHeapTotalBytes": -21757952,
      "scriptDurationMs": 7167.816,
      "eventListeners": 0,
      "totalBlockingTimeMs": 685,
      "frameDurationMs": 31.68217821782178,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9651.441999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8800.968,
      "heapDeltaBytes": -8047436,
      "heapUsedBytes": 69302056,
      "domNodes": 0,
      "jsHeapTotalBytes": -18874368,
      "scriptDurationMs": 7152.883,
      "eventListeners": 0,
      "totalBlockingTimeMs": 642,
      "frameDurationMs": 31.32987012987013,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 184.53899999997248,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 15.606,
      "layouts": 5,
      "layoutDurationMs": 1.6240000000000003,
      "taskDurationMs": 144.407,
      "heapDeltaBytes": 12107072,
      "heapUsedBytes": 78784564,
      "domNodes": 918,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.058000000000002,
      "eventListeners": 202,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 22.912500000000023,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "large-combo-open",
      "durationMs": 211.07999999992444,
      "styleRecalcs": 25,
      "styleRecalcDurationMs": 16.312,
      "layouts": 5,
      "layoutDurationMs": 1.71,
      "taskDurationMs": 149.996,
      "heapDeltaBytes": 12131904,
      "heapUsedBytes": 76109896,
      "domNodes": 918,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.276,
      "eventListeners": 202,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.659999999999947,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2044.9310000000196,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.381000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 594.0670000000001,
      "heapDeltaBytes": -39779636,
      "heapUsedBytes": 85760040,
      "domNodes": -333,
      "jsHeapTotalBytes": -4554752,
      "scriptDurationMs": 34.952999999999996,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2047.551999999996,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.5180000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 577.459,
      "heapDeltaBytes": -39237664,
      "heapUsedBytes": 84745472,
      "domNodes": -313,
      "jsHeapTotalBytes": -3506176,
      "scriptDurationMs": 32.613,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2284.3729999999596,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 5.274000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1575.18,
      "heapDeltaBytes": 19111736,
      "heapUsedBytes": 85194984,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 823.738,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666423357664243,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2318.844000000013,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 6.625000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1599.197,
      "heapDeltaBytes": 16242512,
      "heapUsedBytes": 81921856,
      "domNodes": -313,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 815.3130000000001,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66521739130435,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3537.3050000000035,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 7.912000000000001,
      "layouts": 60,
      "layoutDurationMs": 9.465,
      "taskDurationMs": 1554.395,
      "heapDeltaBytes": 15328392,
      "heapUsedBytes": 98707924,
      "domNodes": 24,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 837.012,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666037735849052,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3651.875999999902,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 7.849000000000002,
      "layouts": 60,
      "layoutDurationMs": 10.253,
      "taskDurationMs": 1712.6350000000002,
      "heapDeltaBytes": 13912496,
      "heapUsedBytes": 84123032,
      "domNodes": 24,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 814.272,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666210045662098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3013.2220000000416,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 4.432,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1911.0159999999998,
      "heapDeltaBytes": 20825424,
      "heapUsedBytes": 87973908,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 980.2839999999999,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.85337078651685,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2957.580000000007,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.102000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1908.1319999999996,
      "heapDeltaBytes": 18078004,
      "heapUsedBytes": 85954984,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 969.087,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.856571428571428,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.153999999986,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.5510000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.3370000000001,
      "heapDeltaBytes": 20740608,
      "heapUsedBytes": 86503244,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.16400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.1159999999873,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.4219999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.49199999999996,
      "heapDeltaBytes": 23262356,
      "heapUsedBytes": 93762404,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 38.133999999999986,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 544.7449999999776,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.851,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.286,
      "heapDeltaBytes": 12009560,
      "heapUsedBytes": 69231532,
      "domNodes": -236,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 146.21800000000002,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665624999999977,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 548.5909999999876,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.409000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 372.48699999999997,
      "heapDeltaBytes": -7818776,
      "heapUsedBytes": 64309540,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 149.648,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.7140000000213,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.5380000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.124,
      "heapDeltaBytes": 5526952,
      "heapUsedBytes": 62973788,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.165000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2014.2590000000382,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.628,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.1499999999999,
      "heapDeltaBytes": 5537252,
      "heapUsedBytes": 62320324,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 7.586999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.16299999998,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 15.907000000000002,
      "layouts": 16,
      "layoutDurationMs": 4.002999999999999,
      "taskDurationMs": 781.4449999999999,
      "heapDeltaBytes": 23861728,
      "heapUsedBytes": 81004608,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 108.602,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1974.9080000000276,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 20.511000000000003,
      "layouts": 16,
      "layoutDurationMs": 4.4190000000000005,
      "taskDurationMs": 1024.1680000000001,
      "heapDeltaBytes": -2196512,
      "heapUsedBytes": 61785040,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 114.003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66610169491526,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.8629999999112,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.406000000000002,
      "layouts": 5,
      "layoutDurationMs": 14.511,
      "taskDurationMs": 999.6150000000001,
      "heapDeltaBytes": 34000780,
      "heapUsedBytes": 112096816,
      "domNodes": 14650,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 33.22899999999999,
      "eventListeners": 2456,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 19.405479452054788,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8403.013999999985,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 19.465999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5651.273,
      "heapDeltaBytes": -39813852,
      "heapUsedBytes": 86090988,
      "domNodes": -313,
      "jsHeapTotalBytes": -3575808,
      "scriptDurationMs": 2678.6510000000003,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66600397614314,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8732.049000000075,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 18.741,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5716.118,
      "heapDeltaBytes": -39249672,
      "heapUsedBytes": 86361596,
      "domNodes": -333,
      "jsHeapTotalBytes": -4100096,
      "scriptDurationMs": 2700.3810000000003,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.698087954110896,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18700.70899999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18013.033999999996,
      "heapDeltaBytes": -35488660,
      "heapUsedBytes": 184274524,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5439488,
      "scriptDurationMs": 275.65099999999995,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.747707979626483,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18835.113999999976,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18181.379,
      "heapDeltaBytes": -31508312,
      "heapUsedBytes": 184832684,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7098368,
      "scriptDurationMs": 290.485,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.163931623931624,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24136.742000000027,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 16.99700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23758.253,
      "heapDeltaBytes": -31208040,
      "heapUsedBytes": 189132384,
      "domNodes": -3046,
      "jsHeapTotalBytes": 4333568,
      "scriptDurationMs": 964.2040000000001,
      "eventListeners": -14913,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 44.88661710037174,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23860.14799999998,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 16.420999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23484.963,
      "heapDeltaBytes": -29719384,
      "heapUsedBytes": 189377276,
      "domNodes": -3047,
      "jsHeapTotalBytes": 5935104,
      "scriptDurationMs": 878.631,
      "eventListeners": -14913,
      "totalBlockingTimeMs": 32,
      "frameDurationMs": 43.790275229357796,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6921.856000000048,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.34899999999998,
      "layouts": 20,
      "layoutDurationMs": 23.742,
      "taskDurationMs": 6775.679,
      "heapDeltaBytes": 5195584,
      "heapUsedBytes": 221043468,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 120.13099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.75,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6722.374000000059,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.46499999999997,
      "layouts": 20,
      "layoutDurationMs": 22.984000000000005,
      "taskDurationMs": 6589.313,
      "heapDeltaBytes": -13780548,
      "heapUsedBytes": 217114136,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 111.373,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.19944751381216,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9600.973999999951,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9212.167,
      "heapDeltaBytes": -32422552,
      "heapUsedBytes": 184240116,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7163904,
      "scriptDurationMs": 166.90899999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.10206896551723,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7328.215,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6805.025000000001,
      "heapDeltaBytes": -19364692,
      "heapUsedBytes": 188189860,
      "domNodes": -3046,
      "jsHeapTotalBytes": 13852672,
      "scriptDurationMs": 123.066,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.964379084967316,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 505.3029999999126,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 20.462999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.3710000000000002,
      "taskDurationMs": 148.486,
      "heapDeltaBytes": 6591760,
      "heapUsedBytes": 62883460,
      "domNodes": 134,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.305000000000001,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 441.8340000000853,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 19.562999999999995,
      "layouts": 4,
      "layoutDurationMs": 1.6869999999999998,
      "taskDurationMs": 112.33999999999999,
      "heapDeltaBytes": 6152556,
      "heapUsedBytes": 62568076,
      "domNodes": 103,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.812,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 846.4159999999765,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 85.836,
      "layouts": 76,
      "layoutDurationMs": 18.093999999999998,
      "taskDurationMs": 815.6,
      "heapDeltaBytes": 17930460,
      "heapUsedBytes": 94407072,
      "domNodes": 77,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 332.702,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 881.5479999999525,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 88.759,
      "layouts": 76,
      "layoutDurationMs": 18.778,
      "taskDurationMs": 861.877,
      "heapDeltaBytes": 18351412,
      "heapUsedBytes": 92320744,
      "domNodes": 77,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 360.921,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1368.5839999999416,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 246.567,
      "layouts": 76,
      "layoutDurationMs": 20.295,
      "taskDurationMs": 1350.1970000000001,
      "heapDeltaBytes": 13584616,
      "heapUsedBytes": 135502896,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 472.963,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.510126582278495,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1354.4620000000123,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 244.346,
      "layouts": 76,
      "layoutDurationMs": 19.822,
      "taskDurationMs": 1339.65,
      "heapDeltaBytes": 13549160,
      "heapUsedBytes": 136431520,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 462.924,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.29873417721517,
      "p95FrameDurationMs": 16.80000000000109
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 55010 85014 64.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1172
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.9% 375
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/stores/teamWorkspaceStore.ts 38.6% 281
src/LGraph.ts 78.9% 274
src/scripts/app.ts 72.7% 258
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                        Coverage Diff                         @@
##             jaewon/fe-3350-server-facts-adr   #20681   +/-   ##
==================================================================
  Coverage                                   ?   85.97%           
==================================================================
  Files                                      ?     3626           
  Lines                                      ?   173439           
  Branches                                   ?    45845           
==================================================================
  Hits                                       ?   149117           
  Misses                                     ?    22295           
  Partials                                   ?     2027           
Flag Coverage Δ
billing-web-unit 92.41% <ø> (?)
unit 84.59% <ø> (?)
website-unit 80.36% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 9, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: deletion-only edits can bypass the changed-line gate because their new-side anchor is shifted by one line.

Full context for agent readers

In a unified diff, +N,0 means the deletion happened before new line N, so the surviving boundary is N - 1. This parser stores after: N, and touches then requires a diagnostic to extend past N. A deletion that removes an operator or unwraps pendingServerFact at the end of a multiline expression can therefore miss the expression it changed. Please derive the boundary from real zero-context git diff output (after: start - 1) and add a regression where a deletion-only hunk makes a previously allowed expression forbidden.

…ct literals

no-capability-recombination reports a billing capability combined with
other state or chosen by a client-side condition. no-server-fact-literals
reports role, tier and billing status literal comparisons, role fallbacks
and server message text matching. Both skip pendingServerFact(...) and
load from a dedicated config, not the root one, per
docs/adr/API-SERVER-FACTS-0042-server-facts-are-rendered-not-derived.md
lint:server-facts runs the server-fact rules on changed src and apps/*/src
files and fails only when a finding's span touches a changed or deleted
line, including findings that start on an unchanged line of a multi-line
expression. Existing findings on untouched code do not block.
Run lint:server-facts against the PR base, the merge-group base and the
pushed range, feeding the required lint-and-format context, and run it
once per commit from lint-staged when code is staged.
A config or plugin load failure printed a JSON parse stack instead of
oxlint's own message; exit 2 with oxlint's output instead.
A -U0 deletion hunk '+N,0' sits between new lines N and N+1. Unwrapping a pendingServerFact call deletes lines just before and just after the expression, which the gate missed. A deletion now touches a finding when its boundary is inside or adjacent to the finding's span, so deleting a line right next to an existing finding also reports it.
Per ADR rule 1, loading, in-flight and validity flags may delay or disable a control but never grant it. no-capability-recombination now allows a logical expression whose only non-capability operands are listed local UI flags, when the operator can only narrow: cap && local, or !cap || local. Shapes that could grant (cap || local, !cap && local) and server-derived flags stay findings.
@dante01yoon
dante01yoon force-pushed the jaewon/fe-3351-server-fact-lint branch from 42c5695 to 0e62254 Compare October 9, 2026 22:30

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the deletion-boundary fix in touches(): the new condition covers both edges of a deletion-only hunk, matching the regression test added for it. Zero open threads, CI fully green. Approving.

@dante01yoon
dante01yoon merged commit b868acd into jaewon/fe-3350-server-facts-adr Oct 9, 2026
47 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-3351-server-fact-lint branch October 9, 2026 23:15
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…DR, changed-line lint gate, agent hooks) (Comfy-Org#20679)

> **This PR now carries the whole short-term stack.** The approved
children were folded into this branch: Comfy-Org#20681 (S2 server-fact oxlint
rules + changed-line gate, FE-3351) and Comfy-Org#20682 (S3/S4 write and approve
hooks, FE-3352 / FE-3353). Each was reviewed and approved on its own PR.
The reviewer-visible diff since the docs-only version is those two PRs
plus two ADR wording commits: `83e85827ef` (rule 1 scoped to
entitlement; local UI state may only narrow) and `2c6455a3bd`
(enforcement described as planned per ticket, per CodeRabbit).

## Why

Agents keep writing, and approving, frontend code that recombines server
facts (capabilities, role, tier, plan status, seats, timestamps) into
decisions the backend owns. The latest case shipped two billing P0s
(BE-19903, BE-19904) through Comfy-Org#15675, Comfy-Org#18662 and Comfy-Org#19455. About 20 fixes
since April moved a decision back to the server.

## Root cause

There is no repo-level rule for this. The one piece of guidance that
touches it points the other way: `docs/guidance/state-and-effects.md`
says "Derive everything derivable", and its first example is a `can*`
flag. A reviewer-side prose rule existed, and Comfy-Org#18662 and Comfy-Org#19455 were
approved anyway.

## How

- **`docs/adr/API-SERVER-FACTS-0042`** records the rule (R1–R5): a gate
renders one server fact as received; `isCloud` picks the build, not the
permission; failed reads use contract defaults, never role or tier
fallbacks; a missing fact is a backend ticket plus `pendingServerFact`.
It also records the rejected alternatives.
- **`AGENTS.md`** gets one Common Pitfalls line linking the ADR, so
every author's agent reads it.
- **`state-and-effects.md` §4** now scopes "derive everything derivable"
to state the feature owns, and sends server facts to the API. The
`canTransition` example is dropped.

Enforcement (lint rules, write and approve hooks, orthogonality tests,
the `pendingServerFact` expiry check) follows in the sibling tickets
below. This PR is the text those checks link to.

## AS IS / TO BE

Docs only. There is no UI change.

| | AS IS | TO BE |
|---|---|---|
| Repo rule | none | ADR + `AGENTS.md` line |
| `state-and-effects.md` §4 | "derive everything derivable",
`canTransition` example | feature-owned state only; server facts render
the API field |

## Plan position

TDD: [Server-fact
guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b).
Parent: FE-3349.

| Item | Ticket | PR | Status |
|---|---|---|---|
| **S1 ADR + AGENTS.md + guidance** | **FE-3350** | **this PR** | **In
review** |
| S2 oxlint rules, diff-scoped gate | FE-3351 | — | Next |
| S3 write hook | FE-3352 | — | Blocked by S2 |
| S4 approve hook | FE-3353 | — | Blocked by S2 |
| S5 `pendingServerFact` + expiry CI | FE-3354 | — | Needs
`LINEAR_API_KEY` secret |
| S6 orthogonality tests + CODEOWNERS | FE-3355 | — | After Comfy-Org#20674 |
| S7 cloud agent instructions | FE-3356 | — | Blocked by S1 |

```mermaid
graph LR
  S1["S1 ADR (this PR)"]:::current --> S7["S7 cloud AGENTS.md"]
  S2["S2 oxlint rules"] --> S3["S3 write hook"]
  S2 --> S4["S4 approve hook"]
  S5["S5 pendingServerFact"]
  S6["S6 orthogonality tests"]
  P20674["PR 20674 member capabilities"] --> S6
  classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px
```
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 12, 2026
…Comfy-Org#20806)

## Why

FE-3366 (L6) audited all 167 existing server-fact findings on main.
About a third were not server-fact derivations at all, and a few real
derivations went unreported. The changed-line gate and the write hook
(Comfy-Org#20679) fire on any edit to a flagged line, so every false positive
blocks a legitimate edit, and every gap lets a real derivation through.

## Root cause

The first version of the rules (Comfy-Org#20681) was tuned on the incident PRs.
The full-repo audit found shapes it misread:
- local in-flight, read or form state treated as server state
- non-boolean bindings seeded from a capability treated as capabilities
- lowercase client catalog keys matched as server tiers
- type guards, label copy and sort comparators reported
- browser and library error text matched as server messages

It also missed `workspaceRole === 'owner'` (only the exact name `role`
matched) and capability pass-throughs such as `canRunWorkflows`.

## How

Each change has RuleTester valid and invalid cases at its boundary. All
incident cases stay invalid.
- **Local UI state:** in-flight, form and read state (`topupOperation`,
`operation`, `paymentLocked`, `isValidAmount`,
`hasResolvedCapabilities`, `snapshotAuthoritative`, `isReady`,
`isHiddenOnSection`) and `failed.*` load-error flags may narrow a
capability, never grant it.
- **Propagation:** only boolean-valued capability bindings propagate. An
unknown type still counts, so `lifecycleActionPermitted` keeps its
findings.
- **Tier literals:** only server tiers (`SubscriptionTier`, typed as
`Record<SubscriptionTier, true>` so typecheck fails when the enum
changes) are matched.
- **Skipped shapes:** runtime type guards (`x is T`). Comparisons whose
every branch is a `t(...)` label. Comparators passed to `.sort` or
`.toSorted`.
- **Lone status:** a single status equality that is the whole test of an
`if` or ternary and picks a value is allowed. A branch returning a
boolean still counts as a step of a gate. Tier is not exempted, because
Comfy-Org#19455 was tier gating.
- **`message.includes`:** reported only in
`src/platform/errorCatalog/**`, where the receiver is server error text.
- **Gaps closed:**
- Role comparisons and `?? 'owner'` fallbacks now also match names
ending in `Role`, excluding user-chosen `targetRole`, `selectedRole`,
`newRole` and `nextRole`.
- `const canX = computed(() => toValue(obj.canX))` counts as that
capability.
- **Dead code:** removed `hasLapsedTeamPlan` (`useTeamPlan.ts`), which
has no production reader.

**Known residual:** `WorkspaceMembersPanelContent.vue:38`,
`failed.members || (canViewPendingInvites && failed.invites)`. A
load-error flag ORed with a narrowed capability has the same shape as
the guarded `(cap && !isLoading) || isSaving`, and the AST can't tell
"show an error" from "grant access". Exempting it would weaken that
guard. It's an existing line, so it's only checked if edited.

## AS IS / TO BE

No UI change.

| Full repo, `serverFacts.oxlintrc.json` over `src` and `apps/*/src`
(tests excluded) | AS IS | TO BE |
|---|---|---|
| Findings | 167 | 147 (31 false positives removed, 11 real derivations
newly reported) |
| `workspaceRole === 'owner'`, `canRunWorkflows` pass-through | not
reported | reported |

## Verification

- `vitest run tools/oxlint-plugins/serverFacts.test.ts
scripts/server-fact-gate.test.ts scripts/hooks`: 137 passed. Each new
exemption was removed in turn and its valid case went red.
- `typecheck:tools`, `oxlint --type-aware` and `oxfmt --check` are
clean. knip and the fallow audit pass on the 5 changed files.
- The remaining 147, grouped by kind, are listed in FE-3366. Seven of
them (`useBillingCapabilities.ts:130-148`) are removed by Comfy-Org#20805.

## Plan position

TDD: [Server-fact
guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b).
Parent: FE-3360.

| Item | Ticket | PR | Status |
|---|---|---|---|
| L6 A1: render seven capability reads | FE-3366 | Comfy-Org#20805 | In review |
| **L6 lint rule refinement** | **FE-3366** | **this PR** | **In
review** |
| L6 A2: downgrade reads `is_original_owner` | FE-3366 | — | Waiting on
backend confirmation |
| L1 `ServerFact` type | FE-3361 | — | Design done, decisions pending |
| L2 local providers | FE-3362 | — | Not started |

```mermaid
graph LR
  A1["L6 A1 (PR 20805)"]
  R["L6 rule refinement (this PR)"]:::current
  A2["L6 A2"]
  L1["L1 ServerFact type"]
  A1 --> L1
  L1 --> L2["L2 local providers"]
  classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants