Repository navigation
FE-3352 / FE-3353 feat(hooks): block server-fact derivations at write and approve time - #20682
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0e6225463904da16a21d6ddfad7f9acc76f801cb
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2246 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T22:47:03.818Z",
"gitSha": "900465e918d11d17120d1e47b2d17edb01790358",
"branch": "jaewon/fe-3352-server-fact-hooks",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.252000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.438,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.645,
"heapDeltaBytes": 5583840,
"heapUsedBytes": 62061572,
"domNodes": -217,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.413999999999996,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2024.7880000000578,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9310000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.9740000000002,
"heapDeltaBytes": 6950572,
"heapUsedBytes": 70386396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.517999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1830.9770000000185,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.286,
"layouts": 12,
"layoutDurationMs": 3.7529999999999997,
"taskDurationMs": 913.079,
"heapDeltaBytes": 910568,
"heapUsedBytes": 57913784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.036,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.8980000000129,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.377,
"layouts": 12,
"layoutDurationMs": 3.088,
"taskDurationMs": 872.2810000000001,
"heapDeltaBytes": 960660,
"heapUsedBytes": 57432720,
"domNodes": -235,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 164.281,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.115000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 7.277,
"layouts": 3,
"layoutDurationMs": 0.6130000000000001,
"taskDurationMs": 382.32200000000006,
"heapDeltaBytes": -37156672,
"heapUsedBytes": 62288404,
"domNodes": -170,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 16.289,
"eventListeners": -87,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.6279999999379,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.186000000000001,
"layouts": 3,
"layoutDurationMs": 0.8360000000000002,
"taskDurationMs": 432.52600000000007,
"heapDeltaBytes": 6838040,
"heapUsedBytes": 63729428,
"domNodes": -168,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.347,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 717.8160000000275,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.7029999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.841,
"heapDeltaBytes": 18186108,
"heapUsedBytes": 74599488,
"domNodes": -217,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 187.66,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 665.2010000000246,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.3040000000001,
"heapDeltaBytes": 842356,
"heapUsedBytes": 101856896,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 171.213,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1273.7830000000372,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1000.5600000000002,
"heapDeltaBytes": 16446500,
"heapUsedBytes": 99436236,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 76.011,
"eventListeners": 0,
"totalBlockingTimeMs": 634,
"frameDurationMs": 37.2558823529412,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1251.9080000000713,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 962.371,
"heapDeltaBytes": 15820492,
"heapUsedBytes": 97811420,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 71.05799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 620,
"frameDurationMs": 36.76176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 891.4540000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.7170000000001,
"heapDeltaBytes": 20608104,
"heapUsedBytes": 100492488,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 181.87299999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.979411764705862,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.8809999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.8140000000004,
"heapDeltaBytes": 19139904,
"heapUsedBytes": 98888296,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 172.65600000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9424.258000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8517.638,
"heapDeltaBytes": 2632672,
"heapUsedBytes": 85663668,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 6849.558,
"eventListeners": 0,
"totalBlockingTimeMs": 619,
"frameDurationMs": 31.492642140468224,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9918.422000000079,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8974.31,
"heapDeltaBytes": 13105760,
"heapUsedBytes": 86295928,
"domNodes": -141,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 7614.563999999999,
"eventListeners": -69,
"totalBlockingTimeMs": 1028,
"frameDurationMs": 32.091585760517795,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10598.765000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9738.937,
"heapDeltaBytes": -13417404,
"heapUsedBytes": 69167024,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 7957.0779999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 1053,
"frameDurationMs": 31.640597014925373,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10840.037000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10013.371000000001,
"heapDeltaBytes": -10257484,
"heapUsedBytes": 72712524,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 8189.911999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1285,
"frameDurationMs": 31.17672413793103,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "large-combo-open",
"durationMs": 212.51000000000886,
"styleRecalcs": 24,
"styleRecalcDurationMs": 18.513,
"layouts": 5,
"layoutDurationMs": 1.7029999999999998,
"taskDurationMs": 164.812,
"heapDeltaBytes": 12125724,
"heapUsedBytes": 76468172,
"domNodes": 918,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.126999999999997,
"eventListeners": 202,
"totalBlockingTimeMs": 2,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 253.97400000008474,
"styleRecalcs": 26,
"styleRecalcDurationMs": 23.529999999999998,
"layouts": 5,
"layoutDurationMs": 2.0090000000000003,
"taskDurationMs": 202.692,
"heapDeltaBytes": 12190496,
"heapUsedBytes": 75203736,
"domNodes": 918,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.086,
"eventListeners": 202,
"totalBlockingTimeMs": 6,
"frameDurationMs": 25,
"p95FrameDurationMs": 99.90000000000055
},
{
"name": "large-graph-idle",
"durationMs": 2041.7809999999577,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.9759999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.6320000000001,
"heapDeltaBytes": -39932976,
"heapUsedBytes": 85327824,
"domNodes": -333,
"jsHeapTotalBytes": -4030464,
"scriptDurationMs": 34.71399999999999,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2050.5540000000337,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0139999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.6800000000001,
"heapDeltaBytes": -39324184,
"heapUsedBytes": 85422352,
"domNodes": -313,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 37.132,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2281.569999999988,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.842000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1570.662,
"heapDeltaBytes": 16277644,
"heapUsedBytes": 82321700,
"domNodes": -313,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 793.697,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66617647058823,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2407.8029999999444,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.833999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1643.789,
"heapDeltaBytes": 18800720,
"heapUsedBytes": 84569984,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 824.529,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.90070422535211,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3819.714000000033,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.658999999999999,
"layouts": 60,
"layoutDurationMs": 10.042,
"taskDurationMs": 1817.006,
"heapDeltaBytes": 3786312,
"heapUsedBytes": 71628056,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 823.393,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66637554585153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3889.8590000000013,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.825,
"layouts": 60,
"layoutDurationMs": 9.778,
"taskDurationMs": 1845.8600000000001,
"heapDeltaBytes": 9718964,
"heapUsedBytes": 76321472,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 853.4079999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666094420600857,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3154.690999999957,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.399000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2016.8660000000002,
"heapDeltaBytes": 26674512,
"heapUsedBytes": 93464816,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1041.113,
"eventListeners": 182,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.022459893048133,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3265.5300000000125,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.445000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2122.472,
"heapDeltaBytes": 949524,
"heapUsedBytes": 87731536,
"domNodes": 0,
"jsHeapTotalBytes": 1765376,
"scriptDurationMs": 1088.6840000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.838860103626942,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2017.8220000000238,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.2560000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 650.263,
"heapDeltaBytes": 20736816,
"heapUsedBytes": 86244012,
"domNodes": -313,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.842999999999996,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.4540000000397,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.103000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.65,
"heapDeltaBytes": -39282328,
"heapUsedBytes": 85871984,
"domNodes": -313,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 42.160000000000004,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 715.1450000000068,
"styleRecalcs": 50,
"styleRecalcDurationMs": 7.1979999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.68999999999994,
"heapDeltaBytes": -8003576,
"heapUsedBytes": 64265564,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 148.733,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.3979999999974,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.887999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.938,
"heapDeltaBytes": -7901008,
"heapUsedBytes": 63210228,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 149.098,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66176470588235,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.5060000000162,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.08,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.0900000000001,
"heapDeltaBytes": 5488560,
"heapUsedBytes": 62624892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.9910000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2058.5289999999077,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.545999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.722,
"heapDeltaBytes": -39114292,
"heapUsedBytes": 61743272,
"domNodes": -235,
"jsHeapTotalBytes": -1835008,
"scriptDurationMs": 9.01,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.830000000025,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.458000000000002,
"layouts": 16,
"layoutDurationMs": 4.276000000000001,
"taskDurationMs": 786.0060000000001,
"heapDeltaBytes": 23870016,
"heapUsedBytes": 81368052,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 109.049,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.93700000002,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.952,
"layouts": 16,
"layoutDurationMs": 4.960000000000001,
"taskDurationMs": 788.278,
"heapDeltaBytes": 23828380,
"heapUsedBytes": 80543416,
"domNodes": -232,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 108.114,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1419.2219999999907,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.070999999999998,
"layouts": 5,
"layoutDurationMs": 13.819,
"taskDurationMs": 1019.9649999999998,
"heapDeltaBytes": 33879824,
"heapUsedBytes": 112035148,
"domNodes": 14650,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 32.604,
"eventListeners": 2456,
"totalBlockingTimeMs": 127,
"frameDurationMs": 19.368918918918908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10041.735000000017,
"styleRecalcs": 247,
"styleRecalcDurationMs": 20.328000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6370.574,
"heapDeltaBytes": 3071876,
"heapUsedBytes": 68057304,
"domNodes": -313,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3010.864,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.721666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9591.224000000011,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.489,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6183.477,
"heapDeltaBytes": -39947012,
"heapUsedBytes": 86038960,
"domNodes": -313,
"jsHeapTotalBytes": -4886528,
"scriptDurationMs": 2870.0150000000003,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695130434782605,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18629.29200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17918.836,
"heapDeltaBytes": -30511552,
"heapUsedBytes": 185299436,
"domNodes": -3046,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 281.22400000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.01460481099656,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 18693.65400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18119.491,
"heapDeltaBytes": -37890752,
"heapUsedBytes": 182415552,
"domNodes": -3046,
"jsHeapTotalBytes": 3239936,
"scriptDurationMs": 289.36,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.773129251700677,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 23664.07700000002,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.48800000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23245.052,
"heapDeltaBytes": -40553576,
"heapUsedBytes": 190376800,
"domNodes": -3046,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 885.315,
"eventListeners": -14913,
"totalBlockingTimeMs": 19,
"frameDurationMs": 43.90667903525046,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 24349.430999999982,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.80699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24001.015,
"heapDeltaBytes": -27497312,
"heapUsedBytes": 189373368,
"domNodes": -3046,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 931.112,
"eventListeners": -14913,
"totalBlockingTimeMs": 28,
"frameDurationMs": 45.4811214953271,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7122.834999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.83800000000002,
"layouts": 20,
"layoutDurationMs": 27.959999999999997,
"taskDurationMs": 6984.1630000000005,
"heapDeltaBytes": -650040,
"heapUsedBytes": 215733552,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 127.133,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.073595505617966,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7065.579999999954,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.211,
"layouts": 20,
"layoutDurationMs": 26.457000000000008,
"taskDurationMs": 6913.866000000001,
"heapDeltaBytes": 617992,
"heapUsedBytes": 216956340,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 113.802,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.03216374269006,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9543.402000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9135.045,
"heapDeltaBytes": -24238896,
"heapUsedBytes": 192063816,
"domNodes": -3046,
"jsHeapTotalBytes": 5701632,
"scriptDurationMs": 197.76499999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 3,
"frameDurationMs": 32.37152542372881,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9464.367000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9060.787,
"heapDeltaBytes": -37442220,
"heapUsedBytes": 183452772,
"domNodes": -3046,
"jsHeapTotalBytes": 5120000,
"scriptDurationMs": 141.97000000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.19829931972789,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 124.23300000000381,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.310999999999998,
"layouts": 3,
"layoutDurationMs": 1.379,
"taskDurationMs": 96.641,
"heapDeltaBytes": 4248532,
"heapUsedBytes": 72019596,
"domNodes": 120,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.834999999999997,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 491.971000000035,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.650999999999998,
"layouts": 4,
"layoutDurationMs": 1.5279999999999998,
"taskDurationMs": 128.67600000000002,
"heapDeltaBytes": 6427432,
"heapUsedBytes": 62689512,
"domNodes": -85,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.901000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517236,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 900.1990000000433,
"styleRecalcs": 77,
"styleRecalcDurationMs": 92.031,
"layouts": 76,
"layoutDurationMs": 19.845000000000002,
"taskDurationMs": 871.523,
"heapDeltaBytes": 18053156,
"heapUsedBytes": 92191952,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 360.771,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814825,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 916.8040000000701,
"styleRecalcs": 77,
"styleRecalcDurationMs": 93.277,
"layouts": 76,
"layoutDurationMs": 19.734,
"taskDurationMs": 889.803,
"heapDeltaBytes": 17932836,
"heapUsedBytes": 95054020,
"domNodes": 77,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 364.41200000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667272727272742,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1486.485000000016,
"styleRecalcs": 77,
"styleRecalcDurationMs": 266,
"layouts": 76,
"layoutDurationMs": 20.714,
"taskDurationMs": 1468.818,
"heapDeltaBytes": -19205976,
"heapUsedBytes": 117042592,
"domNodes": 77,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 504.671,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.29268292682927,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1547.7450000000772,
"styleRecalcs": 77,
"styleRecalcDurationMs": 291.655,
"layouts": 76,
"layoutDurationMs": 21.567,
"taskDurationMs": 1517.8990000000001,
"heapDeltaBytes": 10290556,
"heapUsedBytes": 121839328,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 524.661,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.901219512195116,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaewon/fe-3351-server-fact-lint #20682 +/- ##
===================================================================
+ Coverage 85.97% 86.80% +0.83%
===================================================================
Files 3626 2565 -1061
Lines 173439 144962 -28477
Branches 45845 39780 -6065
===================================================================
- Hits 149115 125836 -23279
+ Misses 22297 18738 -3559
+ Partials 2027 388 -1639
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Blocking: the write-guard and approve-guard both inherit the open deletion-boundary gap from #20681 (the oxlint-rules/gate PR this one is stacked on).
Full context for agent readers
scripts/hooks/server-fact-write-guard.ts's proposedRanges and scripts/hooks/server-fact-approve-guard.ts's approvalDecision both derive their changed-line set from changedRanges/touches in scripts/server-fact-gate-core.ts, the same function already under a CHANGES_REQUESTED finding on #20681 for undercounting a deletion-only hunk's boundary. Neither new hook adds a regression test for a pure-deletion edit (for example, deleting the || isPlanEnded.value operand without adding a replacement line): server-fact-write-guard.test.ts only exercises additions and combined add/delete edits, and server-fact-approve-guard.test.ts's fixtures are all addition hunks. Until the boundary in server-fact-gate-core.ts is fixed, an agent's Edit that removes a server-fact violation through a deletion-only change, or a gh pr review --approve on a PR whose last commit is deletion-only, can both pass the gate silently — the exact bypass these two hooks exist to close.
Please land that fix first (or fold it into this PR, since both now share the dependency), and add one deletion-only case to each of server-fact-write-guard.test.ts and server-fact-approve-guard.test.ts.
42c5695 to
0e62254
Compare
Hooks need to lint file snapshots that are not on disk at their real path. lintSnapshot mirrors them into a temp dir at the same repo-relative path so path-based behaviour and the jsPlugin config still apply.
A PreToolUse hook for Edit, Write and MultiEdit builds the proposed file, lints it with the server-fact rules and blocks findings on the lines the edit changes, plus newly added inline disables of those rules. Pre-existing findings and ungated paths pass. Internal failures warn and allow; CI stays the fail-closed gate.
A PreToolUse hook for Bash recognises gh pr review --approve and gh api review submissions with event APPROVE, resolves the Comfy-Org/ComfyUI_frontend PR, lints its gated files at head and blocks findings on changed lines. Other repositories and non-approvals pass; network and git failures warn and allow.
The hooks fail open on internal errors, which keeps the required CI gate authoritative but could hide a hook that is permanently broken. Each skip now appends a JSON line to server-fact-guard-skips.log in the git common dir, shared by worktrees and never committed, and the warning reports how many skips the last 7 days hold. Logging failures never block the tool. The agent guidance also states that local UI state may narrow a capability.
0bcdb1a to
a019d6f
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Confirmed this PR inherits 20681's boundary fix directly through its stacked base rather than a local copy -- both hooks still import changedRanges from the same server-fact-gate-core.ts. The added fail-open-skip logging is reasonable extra hardening. Zero open threads, CI fully green. Approving.
9e4555d
into
jaewon/fe-3351-server-fact-lint
…DR, changed-line lint gate, agent hooks) (Comfy-Org#20679) > **This PR now carries the whole short-term stack.** The approved children were folded into this branch: Comfy-Org#20681 (S2 server-fact oxlint rules + changed-line gate, FE-3351) and Comfy-Org#20682 (S3/S4 write and approve hooks, FE-3352 / FE-3353). Each was reviewed and approved on its own PR. The reviewer-visible diff since the docs-only version is those two PRs plus two ADR wording commits: `83e85827ef` (rule 1 scoped to entitlement; local UI state may only narrow) and `2c6455a3bd` (enforcement described as planned per ticket, per CodeRabbit). ## Why Agents keep writing, and approving, frontend code that recombines server facts (capabilities, role, tier, plan status, seats, timestamps) into decisions the backend owns. The latest case shipped two billing P0s (BE-19903, BE-19904) through Comfy-Org#15675, Comfy-Org#18662 and Comfy-Org#19455. About 20 fixes since April moved a decision back to the server. ## Root cause There is no repo-level rule for this. The one piece of guidance that touches it points the other way: `docs/guidance/state-and-effects.md` says "Derive everything derivable", and its first example is a `can*` flag. A reviewer-side prose rule existed, and Comfy-Org#18662 and Comfy-Org#19455 were approved anyway. ## How - **`docs/adr/API-SERVER-FACTS-0042`** records the rule (R1–R5): a gate renders one server fact as received; `isCloud` picks the build, not the permission; failed reads use contract defaults, never role or tier fallbacks; a missing fact is a backend ticket plus `pendingServerFact`. It also records the rejected alternatives. - **`AGENTS.md`** gets one Common Pitfalls line linking the ADR, so every author's agent reads it. - **`state-and-effects.md` §4** now scopes "derive everything derivable" to state the feature owns, and sends server facts to the API. The `canTransition` example is dropped. Enforcement (lint rules, write and approve hooks, orthogonality tests, the `pendingServerFact` expiry check) follows in the sibling tickets below. This PR is the text those checks link to. ## AS IS / TO BE Docs only. There is no UI change. | | AS IS | TO BE | |---|---|---| | Repo rule | none | ADR + `AGENTS.md` line | | `state-and-effects.md` §4 | "derive everything derivable", `canTransition` example | feature-owned state only; server facts render the API field | ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3349. | Item | Ticket | PR | Status | |---|---|---|---| | **S1 ADR + AGENTS.md + guidance** | **FE-3350** | **this PR** | **In review** | | S2 oxlint rules, diff-scoped gate | FE-3351 | — | Next | | S3 write hook | FE-3352 | — | Blocked by S2 | | S4 approve hook | FE-3353 | — | Blocked by S2 | | S5 `pendingServerFact` + expiry CI | FE-3354 | — | Needs `LINEAR_API_KEY` secret | | S6 orthogonality tests + CODEOWNERS | FE-3355 | — | After Comfy-Org#20674 | | S7 cloud agent instructions | FE-3356 | — | Blocked by S1 | ```mermaid graph LR S1["S1 ADR (this PR)"]:::current --> S7["S7 cloud AGENTS.md"] S2["S2 oxlint rules"] --> S3["S3 write hook"] S2 --> S4["S4 approve hook"] S5["S5 pendingServerFact"] S6["S6 orthogonality tests"] P20674["PR 20674 member capabilities"] --> S6 classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
Why
The approve step is where #15675, #18662 and #19455 got through. Each was written by an agent and approved by an agent. S2 (#20681) adds a fail-closed CI gate. That catches a derivation only after it's committed and pushed. These hooks stop it earlier, in every Claude Code session that runs in this repo:
Edit,WriteorMultiEditthat adds a server-fact derivation is blocked before the file changes, and the agent gets the rule plus the legal path (backend ticket +pendingServerFact).Root cause
A rule written as prose loses to the task in an agent's context. A reviewer-side "never approve a derived server fact" rule was in place, and #18662 and #19455 were approved anyway. The fix is a check that exits non-zero at the moment of writing or approving.
How
scripts/server-fact-oxlint.ts(refactor). The oxlint runner is extracted so the CI gate and both hooks share one runner and one changed-line intersection (changedRanges,findingsOnChangedLinesfrom S2).lintSnapshotlints file contents at their repo-relative path and points at the real config.scripts/hooks/server-fact-write-guard.ts.Writeuses the new content;EditandMultiEditapply the edits to the file on disk.eslint-disable/oxlint-disable, because a bare one turns this rule off too.src/andapps/*/src/) exit without running oxlint.scripts/hooks/server-fact-approve-guard.ts.gh pr review … --approve|-a, orgh api …/pulls/<n>/reviewswithevent=APPROVEin the args or the--inputfile..claude/settings.jsonregisters both underPreToolUse(Edit|Write|MultiEdit, 20s;Bash, 120s). No permissions change.runHookappends{ ts, hook, reason }toserver-fact-guard-skips.login the git common dir (shared by worktrees, never committed), and the warning readsserver-fact guard skipped (3 skips in the last 7 days, see <path>): <reason>. A hook that keeps failing shows up as a growing count instead of a silent bypass. A failure to write the log never blocks the tool.gh api graphql(addPullRequestReview) and approvals in the GitHub UI aren't intercepted. CI covers them.Size note: about 690 non-test lines, which is over the usual 300. The write guard and approve guard are separate commits (
9d336cfdd4,4f9c67003a) and can be reviewed independently.AS IS / TO BE
There is no UI change. The table shows agent-session behavior.
canInviteMembers.value || isPlanEnded.valuetouseMembersPanel.tsuseMembersPanel.ts:125 A server capability is combined with other state through ||, plus guidancegh pr review 18662 --repo Comfy-Org/ComfyUI_frontend --approveuseMembersPanel.ts151, 152, 171, 252, 253, 270), "Approval blocked until these are resolved."gh pr review N --comment/--request-changes, other reposVerification
vitest run scripts/hooks scripts/server-fact-gate.test.ts: 71 passed. The tests check exit codes and stderr from spawned hook processes. The skip-log test runs the write guard twice against agit initrepo with a broken oxlint config and asserts both JSON lines and the "2 skips in the last 7 days" warning. A second case with an invalid git dir still fails open.event=APPROVEcheck or the gated-file filter fails 3.oxlint --type-aware,oxfmt --check,typecheck:scripts,knip: clean.fallow audit: no issues in the 23 changed files.approvalDecisionwith an injected diff and injected lint results, and checked manually against fix(billing): members invites stay live while cancelled; ended explains itself #18662.Plan position
TDD: Server-fact guardrails. Parent: FE-3349.
pendingServerFact+ expiry CI