Skip to content

FE-3352 / FE-3353 feat(hooks): block server-fact derivations at write and approve time - #20682

Merged
dante01yoon merged 5 commits into
jaewon/fe-3351-server-fact-lintfrom
jaewon/fe-3352-server-fact-hooks
Oct 9, 2026
Merged

dante01yoon merged 5 commits into
jaewon/fe-3351-server-fact-lintfrom
jaewon/fe-3352-server-fact-hooks

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #20681 (S2 rules and gate), which is stacked on #20679 (ADR). Retarget as each one lands.

Why

The approve step is where #15675, #18662 and #19455 got through. Each was written by an agent and approved by an agent. S2 (#20681) adds a fail-closed CI gate. That catches a derivation only after it's committed and pushed. These hooks stop it earlier, in every Claude Code session that runs in this repo:

  • S3, write. An Edit, Write or MultiEdit that adds a server-fact derivation is blocked before the file changes, and the agent gets the rule plus the legal path (backend ticket + pendingServerFact).
  • S4, approve. An agent can't approve a PR whose changed lines still carry server-fact findings.

Root cause

A rule written as prose loses to the task in an agent's context. A reviewer-side "never approve a derived server fact" rule was in place, and #18662 and #19455 were approved anyway. The fix is a check that exits non-zero at the moment of writing or approving.

How

  • scripts/server-fact-oxlint.ts (refactor). The oxlint runner is extracted so the CI gate and both hooks share one runner and one changed-line intersection (changedRanges, findingsOnChangedLines from S2). lintSnapshot lints file contents at their repo-relative path and points at the real config.
  • scripts/hooks/server-fact-write-guard.ts.
    • It builds the proposed file. Write uses the new content; Edit and MultiEdit apply the edits to the file on disk.
    • It diffs the current and proposed file, lints the proposed one, and exits 2 listing only the findings on changed lines, followed by the guidance once.
    • Existing findings elsewhere in the file don't block.
    • It also blocks a newly added disable comment that names a server-fact rule, and a bare eslint-disable / oxlint-disable, because a bare one turns this rule off too.
    • Non-gated paths (tests, stories, anything outside src/ and apps/*/src/) exit without running oxlint.
  • scripts/hooks/server-fact-approve-guard.ts.
    • It classifies the Bash command: gh pr review … --approve|-a, or gh api …/pulls/<n>/reviews with event=APPROVE in the args or the --input file.
    • Only for an approval of this repo does it fetch the PR head and base by SHA, lint the changed gated files at the head, and block with the findings.
    • Every other command returns right after classification. That costs about 80 ms per Bash call.
  • .claude/settings.json registers both under PreToolUse (Edit|Write|MultiEdit, 20s; Bash, 120s). No permissions change.
  • The hooks are an advisory first line. The required CI gate from S2 is the authoritative block. On an internal error (oxlint crash, git or network failure) a hook fails open, so a broken guard never blocks all editing. Each skip is recorded: runHook appends { ts, hook, reason } to server-fact-guard-skips.log in the git common dir (shared by worktrees, never committed), and the warning reads server-fact guard skipped (3 skips in the last 7 days, see <path>): <reason>. A hook that keeps failing shows up as a growing count instead of a silent bypass. A failure to write the log never blocks the tool.
  • Known gap: approvals sent through gh api graphql (addPullRequestReview) and approvals in the GitHub UI aren't intercepted. CI covers them.

Size note: about 690 non-test lines, which is over the usual 300. The write guard and approve guard are separate commits (9d336cfdd4, 4f9c67003a) and can be reviewed independently.

AS IS / TO BE

There is no UI change. The table shows agent-session behavior.

Action AS IS TO BE
Edit adds canInviteMembers.value || isPlanEnded.value to useMembersPanel.ts Written Blocked (exit 2): useMembersPanel.ts:125 A server capability is combined with other state through ||, plus guidance
Comment-only edit in a file with existing findings Written Written
gh pr review 18662 --repo Comfy-Org/ComfyUI_frontend --approve Approved Blocked: 6 findings (useMembersPanel.ts 151, 152, 171, 252, 253, 270), "Approval blocked until these are resolved."
gh pr review N --comment / --request-changes, other repos Runs Runs

Verification

  • vitest run scripts/hooks scripts/server-fact-gate.test.ts: 71 passed. The tests check exit codes and stderr from spawned hook processes. The skip-log test runs the write guard twice against a git init repo with a broken oxlint config and asserts both JSON lines and the "2 skips in the last 7 days" warning. A second case with an invalid git dir still fails open.
  • Mutation checks. Each of these was introduced and then reverted:
    • Removing the gated-path filter fails 2 tests.
    • Disabling the disable-comment scan fails 4.
    • Treating every line as changed fails the existing-findings case.
    • Removing the event=APPROVE check or the gated-file filter fails 3.
  • Timing: about 0.25–0.38s on a gated file, 0.06s on a non-gated one, about 1.0s for a real approval check.
  • oxlint --type-aware, oxfmt --check, typecheck:scripts, knip: clean. fallow audit: no issues in the 23 changed files.
  • Not end-to-end tested: the network fetch step, which is covered through approvalDecision with an injected diff and injected lint results, and checked manually against fix(billing): members invites stay live while cancelled; ended explains itself #18662.

Plan position

TDD: Server-fact guardrails. Parent: FE-3349.

Item Ticket PR Status
S1 ADR + AGENTS.md + guidance FE-3350 #20679 In review
S2 oxlint rules, diff-scoped gate FE-3351 #20681 In review (base of this PR)
S3 write hook FE-3352 this PR In review
S4 approve hook FE-3353 this PR In review
S5 pendingServerFact + expiry CI FE-3354 #20680 In review
S6 orthogonality tests + CODEOWNERS FE-3355 — After #20674
S7 cloud agent instructions FE-3356 cloud#12741 In review
graph LR
  S1["S1 ADR (PR 20679)"] --> S2["S2 rules + gate (PR 20681)"]
  S1 --> S7["S7 cloud AGENTS.md (cloud PR 12741)"]
  S2 --> S34["S3 + S4 hooks (this PR)"]:::current
  S5["S5 pendingServerFact (PR 20680)"] -. "exempted by" .-> S2
  P20674["PR 20674 member capabilities"] --> S6["S6 orthogonality tests"]
  classDef current fill:#f9d71c,stroke:#333,stroke-width:2px
Loading

@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9cf24e97-590a-4573-84fe-d5c99e206879

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 0e6225463904da16a21d6ddfad7f9acc76f801cb

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2246 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2224 / ❌ 0 / ⚠️ 2 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 27.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 627ms TBT · 94.1 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 38.9 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 234ms TBT · 95.1 MB heap
extension-clean-combined-draw: · 31.5 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 824ms TBT · 82.0 MB heap
extension-rgthree-prototype-draw: · 31.8 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1169ms TBT · 67.7 MB heap
large-combo-open: · 40.8 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 4ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
large-graph-pan: · 59.6 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
legacy-node-drag: · 59.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 6ms TBT · 86.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
subgraph-transition-enter: · 51.6 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 127ms TBT · 106.8 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.5 MB heap
vue-large-graph-idle: · 31.4 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 175.3 MB heap
vue-large-graph-pan: · 22.4 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 24ms TBT · 181.1 MB heap
vue-node-resize-workload: · 24.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 206.3 MB heap
vue-zoom-out-idle: · 31.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 2ms TBT · 179.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.2 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.3 MB heap
agent-composer-long-conversation-typing: · 53.8 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 113.9 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 4ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 523ms
canvas-idle: script duration 14ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.2 MB
canvas-idle: DOM nodes -109
canvas-idle: event listeners -63
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 16ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 893ms
canvas-mouse-sweep: script duration 171ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 55.0 MB
canvas-mouse-sweep: DOM nodes -118
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 7ms
canvas-zoom-sweep: layout count 3
canvas-zoom-sweep: style recalc count 20
canvas-zoom-sweep: task duration 407ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 60.1 MB
canvas-zoom-sweep: DOM nodes -169
canvas-zoom-sweep: event listeners -24
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 495ms
dom-widget-clipping: script duration 179ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.1 MB
dom-widget-clipping: DOM nodes -109
dom-widget-clipping: event listeners -63
dom-widget-order-dense-n200-w200-i120: avg frame time 37ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 981ms
dom-widget-order-dense-n200-w200-i120: script duration 74ms
dom-widget-order-dense-n200-w200-i120: TBT 627ms
dom-widget-order-dense-n200-w200-i120: heap used 94.1 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 26ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 508ms
dom-widget-order-sparse-n1000-w20-i120: script duration 177ms
dom-widget-order-sparse-n1000-w20-i120: TBT 234ms
dom-widget-order-sparse-n1000-w20-i120: heap used 95.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8746ms
extension-clean-combined-draw: script duration 7232ms
extension-clean-combined-draw: TBT 824ms
extension-clean-combined-draw: heap used 82.0 MB
extension-clean-combined-draw: DOM nodes -71
extension-clean-combined-draw: event listeners -35
extension-rgthree-prototype-draw: avg frame time 31ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 9876ms
extension-rgthree-prototype-draw: script duration 8073ms
extension-rgthree-prototype-draw: TBT 1169ms
extension-rgthree-prototype-draw: heap used 67.7 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-combo-open: avg frame time 25ms
large-combo-open: p95 frame time 92ms
large-combo-open: layout duration 2ms
large-combo-open: style recalc duration 21ms
large-combo-open: layout count 5
large-combo-open: style recalc count 25
large-combo-open: task duration 184ms
large-combo-open: script duration 10ms
large-combo-open: TBT 4ms
large-combo-open: heap used 72.3 MB
large-combo-open: DOM nodes 918
large-combo-open: event listeners 202
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 605ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.4 MB
large-graph-idle: DOM nodes -323
large-graph-idle: event listeners -126
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 6ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1607ms
large-graph-pan: script duration 809ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.6 MB
large-graph-pan: DOM nodes -157
large-graph-pan: event listeners -61
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1831ms
large-graph-zoom: script duration 838ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.5 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 2070ms
legacy-node-drag: script duration 1065ms
legacy-node-drag: TBT 6ms
legacy-node-drag: heap used 86.4 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 663ms
minimap-idle: script duration 41ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.1 MB
minimap-idle: DOM nodes -313
minimap-idle: event listeners -126
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 7ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 430ms
subgraph-dom-widget-clipping: script duration 149ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 60.8 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 475ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.3 MB
subgraph-idle: DOM nodes -118
subgraph-idle: event listeners -86
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 17ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 787ms
subgraph-mouse-sweep: script duration 109ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 77.2 MB
subgraph-mouse-sweep: DOM nodes -116
subgraph-mouse-sweep: event listeners -82
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1020ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 127ms
subgraph-transition-enter: heap used 106.8 MB
subgraph-transition-enter: DOM nodes 14650
subgraph-transition-enter: event listeners 2456
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 21ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6277ms
viewport-pan-sweep: script duration 2940ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 73.5 MB
viewport-pan-sweep: DOM nodes -313
viewport-pan-sweep: event listeners -124
vue-large-graph-idle: avg frame time 32ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18019ms
vue-large-graph-idle: script duration 285ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 175.3 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 45ms
vue-large-graph-pan: p95 frame time 92ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 181
vue-large-graph-pan: task duration 23623ms
vue-large-graph-pan: script duration 908ms
vue-large-graph-pan: TBT 24ms
vue-large-graph-pan: heap used 181.1 MB
vue-large-graph-pan: DOM nodes -3046
vue-large-graph-pan: event listeners -14913
vue-node-resize-workload: avg frame time 41ms
vue-node-resize-workload: p95 frame time 83ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6949ms
vue-node-resize-workload: script duration 120ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 206.3 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 32ms
vue-zoom-out-idle: p95 frame time 67ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9098ms
vue-zoom-out-idle: script duration 170ms
vue-zoom-out-idle: TBT 2ms
vue-zoom-out-idle: heap used 179.1 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 4
workflow-execution: style recalc count 16
workflow-execution: task duration 113ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.2 MB
workflow-execution: DOM nodes 18
workflow-execution: event listeners 49
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 20ms
agent-composer-empty-conversation-typing: style recalc duration 93ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 77
agent-composer-empty-conversation-typing: task duration 881ms
agent-composer-empty-conversation-typing: script duration 363ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 89.3 MB
agent-composer-empty-conversation-typing: DOM nodes 77
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 19ms
agent-composer-long-conversation-typing: p95 frame time 33ms
agent-composer-long-conversation-typing: layout duration 21ms
agent-composer-long-conversation-typing: style recalc duration 279ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 77
agent-composer-long-conversation-typing: task duration 1493ms
agent-composer-long-conversation-typing: script duration 515ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 113.9 MB
agent-composer-long-conversation-typing: DOM nodes 77
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-09T22:47:03.818Z",
  "gitSha": "900465e918d11d17120d1e47b2d17edb01790358",
  "branch": "jaewon/fe-3352-server-fact-hooks",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2021.252000000004,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.438,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.645,
      "heapDeltaBytes": 5583840,
      "heapUsedBytes": 62061572,
      "domNodes": -217,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.413999999999996,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.7880000000578,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.9310000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.9740000000002,
      "heapDeltaBytes": 6950572,
      "heapUsedBytes": 70386396,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.517999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760327,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1830.9770000000185,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 17.286,
      "layouts": 12,
      "layoutDurationMs": 3.7529999999999997,
      "taskDurationMs": 913.079,
      "heapDeltaBytes": 910568,
      "heapUsedBytes": 57913784,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 178.036,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665454545454544,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1793.8980000000129,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 15.377,
      "layouts": 12,
      "layoutDurationMs": 3.088,
      "taskDurationMs": 872.2810000000001,
      "heapDeltaBytes": 960660,
      "heapUsedBytes": 57432720,
      "domNodes": -235,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 164.281,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66635514018692,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.115000000007,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 7.277,
      "layouts": 3,
      "layoutDurationMs": 0.6130000000000001,
      "taskDurationMs": 382.32200000000006,
      "heapDeltaBytes": -37156672,
      "heapUsedBytes": 62288404,
      "domNodes": -170,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 16.289,
      "eventListeners": -87,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666019417475724,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1700.6279999999379,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 6.186000000000001,
      "layouts": 3,
      "layoutDurationMs": 0.8360000000000002,
      "taskDurationMs": 432.52600000000007,
      "heapDeltaBytes": 6838040,
      "heapUsedBytes": 63729428,
      "domNodes": -168,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 16.347,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 717.8160000000275,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 4.7029999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.841,
      "heapDeltaBytes": 18186108,
      "heapUsedBytes": 74599488,
      "domNodes": -217,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 187.66,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664285714285704,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 665.2010000000246,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.965,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.3040000000001,
      "heapDeltaBytes": 842356,
      "heapUsedBytes": 101856896,
      "domNodes": 0,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 171.213,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664102564102578,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1273.7830000000372,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1000.5600000000002,
      "heapDeltaBytes": 16446500,
      "heapUsedBytes": 99436236,
      "domNodes": 0,
      "jsHeapTotalBytes": 1998848,
      "scriptDurationMs": 76.011,
      "eventListeners": 0,
      "totalBlockingTimeMs": 634,
      "frameDurationMs": 37.2558823529412,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1251.9080000000713,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 962.371,
      "heapDeltaBytes": 15820492,
      "heapUsedBytes": 97811420,
      "domNodes": 0,
      "jsHeapTotalBytes": 1998848,
      "scriptDurationMs": 71.05799999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 620,
      "frameDurationMs": 36.76176470588234,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 891.4540000000102,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.7170000000001,
      "heapDeltaBytes": 20608104,
      "heapUsedBytes": 100492488,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 181.87299999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 234,
      "frameDurationMs": 25.979411764705862,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 858.8809999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.8140000000004,
      "heapDeltaBytes": 19139904,
      "heapUsedBytes": 98888296,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 172.65600000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 234,
      "frameDurationMs": 25.491176470588258,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9424.258000000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8517.638,
      "heapDeltaBytes": 2632672,
      "heapUsedBytes": 85663668,
      "domNodes": 0,
      "jsHeapTotalBytes": -20447232,
      "scriptDurationMs": 6849.558,
      "eventListeners": 0,
      "totalBlockingTimeMs": 619,
      "frameDurationMs": 31.492642140468224,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9918.422000000079,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8974.31,
      "heapDeltaBytes": 13105760,
      "heapUsedBytes": 86295928,
      "domNodes": -141,
      "jsHeapTotalBytes": -7475200,
      "scriptDurationMs": 7614.563999999999,
      "eventListeners": -69,
      "totalBlockingTimeMs": 1028,
      "frameDurationMs": 32.091585760517795,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10598.765000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9738.937,
      "heapDeltaBytes": -13417404,
      "heapUsedBytes": 69167024,
      "domNodes": 0,
      "jsHeapTotalBytes": -22020096,
      "scriptDurationMs": 7957.0779999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1053,
      "frameDurationMs": 31.640597014925373,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10840.037000000051,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10013.371000000001,
      "heapDeltaBytes": -10257484,
      "heapUsedBytes": 72712524,
      "domNodes": 0,
      "jsHeapTotalBytes": -15204352,
      "scriptDurationMs": 8189.911999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1285,
      "frameDurationMs": 31.17672413793103,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "large-combo-open",
      "durationMs": 212.51000000000886,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 18.513,
      "layouts": 5,
      "layoutDurationMs": 1.7029999999999998,
      "taskDurationMs": 164.812,
      "heapDeltaBytes": 12125724,
      "heapUsedBytes": 76468172,
      "domNodes": 918,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.126999999999997,
      "eventListeners": 202,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 24.077777777777758,
      "p95FrameDurationMs": 83.30000000000018
    },
    {
      "name": "large-combo-open",
      "durationMs": 253.97400000008474,
      "styleRecalcs": 26,
      "styleRecalcDurationMs": 23.529999999999998,
      "layouts": 5,
      "layoutDurationMs": 2.0090000000000003,
      "taskDurationMs": 202.692,
      "heapDeltaBytes": 12190496,
      "heapUsedBytes": 75203736,
      "domNodes": 918,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 11.086,
      "eventListeners": 202,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 99.90000000000055
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2041.7809999999577,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.9759999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 626.6320000000001,
      "heapDeltaBytes": -39932976,
      "heapUsedBytes": 85327824,
      "domNodes": -333,
      "jsHeapTotalBytes": -4030464,
      "scriptDurationMs": 34.71399999999999,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.5540000000337,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.0139999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.6800000000001,
      "heapDeltaBytes": -39324184,
      "heapUsedBytes": 85422352,
      "domNodes": -313,
      "jsHeapTotalBytes": -3244032,
      "scriptDurationMs": 37.132,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2281.569999999988,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 5.842000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1570.662,
      "heapDeltaBytes": 16277644,
      "heapUsedBytes": 82321700,
      "domNodes": -313,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 793.697,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66617647058823,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2407.8029999999444,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 5.833999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1643.789,
      "heapDeltaBytes": 18800720,
      "heapUsedBytes": 84569984,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 824.529,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.90070422535211,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3819.714000000033,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.658999999999999,
      "layouts": 60,
      "layoutDurationMs": 10.042,
      "taskDurationMs": 1817.006,
      "heapDeltaBytes": 3786312,
      "heapUsedBytes": 71628056,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 823.393,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66637554585153,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3889.8590000000013,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 7.825,
      "layouts": 60,
      "layoutDurationMs": 9.778,
      "taskDurationMs": 1845.8600000000001,
      "heapDeltaBytes": 9718964,
      "heapUsedBytes": 76321472,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 853.4079999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666094420600857,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3154.690999999957,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.399000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2016.8660000000002,
      "heapDeltaBytes": 26674512,
      "heapUsedBytes": 93464816,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1041.113,
      "eventListeners": 182,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 17.022459893048133,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3265.5300000000125,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.445000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2122.472,
      "heapDeltaBytes": 949524,
      "heapUsedBytes": 87731536,
      "domNodes": 0,
      "jsHeapTotalBytes": 1765376,
      "scriptDurationMs": 1088.6840000000002,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.838860103626942,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2017.8220000000238,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.2560000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 650.263,
      "heapDeltaBytes": 20736816,
      "heapUsedBytes": 86244012,
      "domNodes": -313,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.842999999999996,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2046.4540000000397,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.103000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 675.65,
      "heapDeltaBytes": -39282328,
      "heapUsedBytes": 85871984,
      "domNodes": -313,
      "jsHeapTotalBytes": -2981888,
      "scriptDurationMs": 42.160000000000004,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 715.1450000000068,
      "styleRecalcs": 50,
      "styleRecalcDurationMs": 7.1979999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 470.68999999999994,
      "heapDeltaBytes": -8003576,
      "heapUsedBytes": 64265564,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 148.733,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66744186046511,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 573.3979999999974,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.887999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.938,
      "heapDeltaBytes": -7901008,
      "heapUsedBytes": 63210228,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 149.098,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66176470588235,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.5060000000162,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.08,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 432.0900000000001,
      "heapDeltaBytes": 5488560,
      "heapUsedBytes": 62624892,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.9910000000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2058.5289999999077,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 4.545999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.722,
      "heapDeltaBytes": -39114292,
      "heapUsedBytes": 61743272,
      "domNodes": -235,
      "jsHeapTotalBytes": -1835008,
      "scriptDurationMs": 9.01,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665853658536584,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.830000000025,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 16.458000000000002,
      "layouts": 16,
      "layoutDurationMs": 4.276000000000001,
      "taskDurationMs": 786.0060000000001,
      "heapDeltaBytes": 23870016,
      "heapUsedBytes": 81368052,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 109.049,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1702.93700000002,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 16.952,
      "layouts": 16,
      "layoutDurationMs": 4.960000000000001,
      "taskDurationMs": 788.278,
      "heapDeltaBytes": 23828380,
      "heapUsedBytes": 80543416,
      "domNodes": -232,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 108.114,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1419.2219999999907,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.070999999999998,
      "layouts": 5,
      "layoutDurationMs": 13.819,
      "taskDurationMs": 1019.9649999999998,
      "heapDeltaBytes": 33879824,
      "heapUsedBytes": 112035148,
      "domNodes": 14650,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 32.604,
      "eventListeners": 2456,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 19.368918918918908,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10041.735000000017,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 20.328000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6370.574,
      "heapDeltaBytes": 3071876,
      "heapUsedBytes": 68057304,
      "domNodes": -313,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3010.864,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.721666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9591.224000000011,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 21.489,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6183.477,
      "heapDeltaBytes": -39947012,
      "heapUsedBytes": 86038960,
      "domNodes": -313,
      "jsHeapTotalBytes": -4886528,
      "scriptDurationMs": 2870.0150000000003,
      "eventListeners": -124,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.695130434782605,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18629.29200000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17918.836,
      "heapDeltaBytes": -30511552,
      "heapUsedBytes": 185299436,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7884800,
      "scriptDurationMs": 281.22400000000005,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.01460481099656,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18693.65400000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18119.491,
      "heapDeltaBytes": -37890752,
      "heapUsedBytes": 182415552,
      "domNodes": -3046,
      "jsHeapTotalBytes": 3239936,
      "scriptDurationMs": 289.36,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 31.773129251700677,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23664.07700000002,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 18.48800000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23245.052,
      "heapDeltaBytes": -40553576,
      "heapUsedBytes": 190376800,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7622656,
      "scriptDurationMs": 885.315,
      "eventListeners": -14913,
      "totalBlockingTimeMs": 19,
      "frameDurationMs": 43.90667903525046,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24349.430999999982,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 20.80699999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24001.015,
      "heapDeltaBytes": -27497312,
      "heapUsedBytes": 189373368,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7884800,
      "scriptDurationMs": 931.112,
      "eventListeners": -14913,
      "totalBlockingTimeMs": 28,
      "frameDurationMs": 45.4811214953271,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7122.834999999952,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.83800000000002,
      "layouts": 20,
      "layoutDurationMs": 27.959999999999997,
      "taskDurationMs": 6984.1630000000005,
      "heapDeltaBytes": -650040,
      "heapUsedBytes": 215733552,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 127.133,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.073595505617966,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7065.579999999954,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.211,
      "layouts": 20,
      "layoutDurationMs": 26.457000000000008,
      "taskDurationMs": 6913.866000000001,
      "heapDeltaBytes": 617992,
      "heapUsedBytes": 216956340,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 113.802,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 41.03216374269006,
      "p95FrameDurationMs": 83.30000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9543.402000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9135.045,
      "heapDeltaBytes": -24238896,
      "heapUsedBytes": 192063816,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5701632,
      "scriptDurationMs": 197.76499999999996,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 32.37152542372881,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9464.367000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9060.787,
      "heapDeltaBytes": -37442220,
      "heapUsedBytes": 183452772,
      "domNodes": -3046,
      "jsHeapTotalBytes": 5120000,
      "scriptDurationMs": 141.97000000000003,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.19829931972789,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "workflow-execution",
      "durationMs": 124.23300000000381,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 12.310999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.379,
      "taskDurationMs": 96.641,
      "heapDeltaBytes": 4248532,
      "heapUsedBytes": 72019596,
      "domNodes": 120,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.834999999999997,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662500000000023,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 491.971000000035,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 15.650999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.5279999999999998,
      "taskDurationMs": 128.67600000000002,
      "heapDeltaBytes": 6427432,
      "heapUsedBytes": 62689512,
      "domNodes": -85,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.901000000000002,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662068965517236,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 900.1990000000433,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 92.031,
      "layouts": 76,
      "layoutDurationMs": 19.845000000000002,
      "taskDurationMs": 871.523,
      "heapDeltaBytes": 18053156,
      "heapUsedBytes": 92191952,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 360.771,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664814814814825,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 916.8040000000701,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 93.277,
      "layouts": 76,
      "layoutDurationMs": 19.734,
      "taskDurationMs": 889.803,
      "heapDeltaBytes": 17932836,
      "heapUsedBytes": 95054020,
      "domNodes": 77,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 364.41200000000003,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667272727272742,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1486.485000000016,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 266,
      "layouts": 76,
      "layoutDurationMs": 20.714,
      "taskDurationMs": 1468.818,
      "heapDeltaBytes": -19205976,
      "heapUsedBytes": 117042592,
      "domNodes": 77,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 504.671,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.29268292682927,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1547.7450000000772,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 291.655,
      "layouts": 76,
      "layoutDurationMs": 21.567,
      "taskDurationMs": 1517.8990000000001,
      "heapDeltaBytes": 10290556,
      "heapUsedBytes": 121839328,
      "domNodes": 77,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 524.661,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.901219512195116,
      "p95FrameDurationMs": 33.399999999999636
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 55007 85014 64.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.6% 1172
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.9% 375
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/platform/workspace/stores/teamWorkspaceStore.ts 38.6% 281
src/LGraph.ts 78.9% 274
src/scripts/app.ts 72.7% 258
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 9, 2026
@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                         Coverage Diff                         @@
##           jaewon/fe-3351-server-fact-lint   #20682      +/-   ##
===================================================================
+ Coverage                            85.97%   86.80%   +0.83%     
===================================================================
  Files                                 3626     2565    -1061     
  Lines                               173439   144962   -28477     
  Branches                             45845    39780    -6065     
===================================================================
- Hits                                149115   125836   -23279     
+ Misses                               22297    18738    -3559     
+ Partials                              2027      388    -1639     
Flag Coverage Δ
billing-web-unit ?
e2e 64.70% <ø> (-0.01%) ⬇️
unit 84.59% <ø> (+<0.01%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1066 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: the write-guard and approve-guard both inherit the open deletion-boundary gap from #20681 (the oxlint-rules/gate PR this one is stacked on).

Full context for agent readers

scripts/hooks/server-fact-write-guard.ts's proposedRanges and scripts/hooks/server-fact-approve-guard.ts's approvalDecision both derive their changed-line set from changedRanges/touches in scripts/server-fact-gate-core.ts, the same function already under a CHANGES_REQUESTED finding on #20681 for undercounting a deletion-only hunk's boundary. Neither new hook adds a regression test for a pure-deletion edit (for example, deleting the || isPlanEnded.value operand without adding a replacement line): server-fact-write-guard.test.ts only exercises additions and combined add/delete edits, and server-fact-approve-guard.test.ts's fixtures are all addition hunks. Until the boundary in server-fact-gate-core.ts is fixed, an agent's Edit that removes a server-fact violation through a deletion-only change, or a gh pr review --approve on a PR whose last commit is deletion-only, can both pass the gate silently — the exact bypass these two hooks exist to close.

Please land that fix first (or fold it into this PR, since both now share the dependency), and add one deletion-only case to each of server-fact-write-guard.test.ts and server-fact-approve-guard.test.ts.

@dante01yoon
dante01yoon force-pushed the jaewon/fe-3351-server-fact-lint branch from 42c5695 to 0e62254 Compare October 9, 2026 22:30
Hooks need to lint file snapshots that are not on disk at their real path. lintSnapshot mirrors them into a temp dir at the same repo-relative path so path-based behaviour and the jsPlugin config still apply.
A PreToolUse hook for Edit, Write and MultiEdit builds the proposed file, lints it with the server-fact rules and blocks findings on the lines the edit changes, plus newly added inline disables of those rules. Pre-existing findings and ungated paths pass. Internal failures warn and allow; CI stays the fail-closed gate.
A PreToolUse hook for Bash recognises gh pr review --approve and gh api review submissions with event APPROVE, resolves the Comfy-Org/ComfyUI_frontend PR, lints its gated files at head and blocks findings on changed lines. Other repositories and non-approvals pass; network and git failures warn and allow.
The hooks fail open on internal errors, which keeps the required CI gate authoritative but could hide a hook that is permanently broken. Each skip now appends a JSON line to server-fact-guard-skips.log in the git common dir, shared by worktrees and never committed, and the warning reports how many skips the last 7 days hold. Logging failures never block the tool. The agent guidance also states that local UI state may narrow a capability.
@dante01yoon
dante01yoon force-pushed the jaewon/fe-3352-server-fact-hooks branch from 0bcdb1a to a019d6f Compare October 9, 2026 22:31

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this PR inherits 20681's boundary fix directly through its stacked base rather than a local copy -- both hooks still import changedRanges from the same server-fact-gate-core.ts. The added fail-open-skip logging is reasonable extra hardening. Zero open threads, CI fully green. Approving.

@dante01yoon
dante01yoon merged commit 9e4555d into jaewon/fe-3351-server-fact-lint Oct 9, 2026
127 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-3352-server-fact-hooks branch October 9, 2026 23:15
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…DR, changed-line lint gate, agent hooks) (Comfy-Org#20679)

> **This PR now carries the whole short-term stack.** The approved
children were folded into this branch: Comfy-Org#20681 (S2 server-fact oxlint
rules + changed-line gate, FE-3351) and Comfy-Org#20682 (S3/S4 write and approve
hooks, FE-3352 / FE-3353). Each was reviewed and approved on its own PR.
The reviewer-visible diff since the docs-only version is those two PRs
plus two ADR wording commits: `83e85827ef` (rule 1 scoped to
entitlement; local UI state may only narrow) and `2c6455a3bd`
(enforcement described as planned per ticket, per CodeRabbit).

## Why

Agents keep writing, and approving, frontend code that recombines server
facts (capabilities, role, tier, plan status, seats, timestamps) into
decisions the backend owns. The latest case shipped two billing P0s
(BE-19903, BE-19904) through Comfy-Org#15675, Comfy-Org#18662 and Comfy-Org#19455. About 20 fixes
since April moved a decision back to the server.

## Root cause

There is no repo-level rule for this. The one piece of guidance that
touches it points the other way: `docs/guidance/state-and-effects.md`
says "Derive everything derivable", and its first example is a `can*`
flag. A reviewer-side prose rule existed, and Comfy-Org#18662 and Comfy-Org#19455 were
approved anyway.

## How

- **`docs/adr/API-SERVER-FACTS-0042`** records the rule (R1–R5): a gate
renders one server fact as received; `isCloud` picks the build, not the
permission; failed reads use contract defaults, never role or tier
fallbacks; a missing fact is a backend ticket plus `pendingServerFact`.
It also records the rejected alternatives.
- **`AGENTS.md`** gets one Common Pitfalls line linking the ADR, so
every author's agent reads it.
- **`state-and-effects.md` §4** now scopes "derive everything derivable"
to state the feature owns, and sends server facts to the API. The
`canTransition` example is dropped.

Enforcement (lint rules, write and approve hooks, orthogonality tests,
the `pendingServerFact` expiry check) follows in the sibling tickets
below. This PR is the text those checks link to.

## AS IS / TO BE

Docs only. There is no UI change.

| | AS IS | TO BE |
|---|---|---|
| Repo rule | none | ADR + `AGENTS.md` line |
| `state-and-effects.md` §4 | "derive everything derivable",
`canTransition` example | feature-owned state only; server facts render
the API field |

## Plan position

TDD: [Server-fact
guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b).
Parent: FE-3349.

| Item | Ticket | PR | Status |
|---|---|---|---|
| **S1 ADR + AGENTS.md + guidance** | **FE-3350** | **this PR** | **In
review** |
| S2 oxlint rules, diff-scoped gate | FE-3351 | — | Next |
| S3 write hook | FE-3352 | — | Blocked by S2 |
| S4 approve hook | FE-3353 | — | Blocked by S2 |
| S5 `pendingServerFact` + expiry CI | FE-3354 | — | Needs
`LINEAR_API_KEY` secret |
| S6 orthogonality tests + CODEOWNERS | FE-3355 | — | After Comfy-Org#20674 |
| S7 cloud agent instructions | FE-3356 | — | Blocked by S1 |

```mermaid
graph LR
  S1["S1 ADR (this PR)"]:::current --> S7["S7 cloud AGENTS.md"]
  S2["S2 oxlint rules"] --> S3["S3 write hook"]
  S2 --> S4["S4 approve hook"]
  S5["S5 pendingServerFact"]
  S6["S6 orthogonality tests"]
  P20674["PR 20674 member capabilities"] --> S6
  classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants