Repository navigation
feat(website): Hub admin redesign, content editor and a shareable demo preview - #20640
mariana953 wants to merge 43 commits into
Conversation
One Draft list merges catalog changes and workflow submissions, with a review sheet, Run in Comfy Cloud, publish that approves the included workflows, multi-reject, All content, publish history with rollback, and a slimmer preview bar with a time picker and a changes list. Adds shadcn-vue Switch, Checkbox and Popover in the site's style.
Moves listing filters, stats, rows, review details, the time picker and the changes list into their own components, and the filtering rules into tested helpers, so each template stays small.
The admin and the preview bar are work tools, so they now use the developer platform's graphite palette, type scale and controls instead of the marketing site's ink and yellow: a sidebar shell, dense tables, status dots, 8px controls and neutral dialogs and side panels. Admin primitives (button, dialog, side panel, status label, page header) live in components/cms/ui on top of reka-ui, and BaseLayout gains a bare mode so the admin can bring its own chrome.
A pull request labelled cms-demo now builds its Vercel preview with the Hub admin running on in-memory sample data, so design can share a link without a backend. The mock that pnpm dev:cms serves moves to lib/cms/mock-ingest.ts; in demo mode the site API and catalog reads are answered by it instead of the network. The flag is baked in at build time and refused when VERCEL_ENV is production. All content's row actions become icon buttons with platform tooltips.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-16T17:08:05.658Z",
"gitSha": "b66b8313a6852a5e21b54b217c2bfd13e03f6c01",
"branch": "claude/fervent-dijkstra-i2d35k",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.6810000000053,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.0659999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 243.01700000000002,
"heapDeltaBytes": 7453720,
"heapUsedBytes": 76764124,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.211999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.3689999999924,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.5469999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 287.532,
"heapDeltaBytes": 3569080,
"heapUsedBytes": 65728680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.447,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1672.6680000000158,
"styleRecalcs": 71,
"styleRecalcDurationMs": 11.374,
"layouts": 12,
"layoutDurationMs": 3.9380000000000006,
"taskDurationMs": 435.12100000000004,
"heapDeltaBytes": 25607392,
"heapUsedBytes": 79547188,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 86.476,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.705000000003,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.282000000000002,
"layouts": 12,
"layoutDurationMs": 4.031999999999999,
"taskDurationMs": 518.931,
"heapDeltaBytes": -585208,
"heapUsedBytes": 61893864,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.018,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1716.6439999999739,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.286999999999999,
"layouts": 3,
"layoutDurationMs": 0.8619999999999997,
"taskDurationMs": 193.61299999999997,
"heapDeltaBytes": 4492048,
"heapUsedBytes": 59427500,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.122,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.2399999999852,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.564,
"layouts": 3,
"layoutDurationMs": 0.9629999999999999,
"taskDurationMs": 286.163,
"heapDeltaBytes": 9713456,
"heapUsedBytes": 78468952,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.457999999999998,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 410.9619999999836,
"styleRecalcs": 17,
"styleRecalcDurationMs": 4.234999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.037,
"heapDeltaBytes": 16245116,
"heapUsedBytes": 75208688,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.02999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 447.23600000003216,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.844000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.439,
"heapDeltaBytes": -4917308,
"heapUsedBytes": 64646036,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.07699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962965,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 883.3360000000141,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.36499999999995,
"heapDeltaBytes": 12242028,
"heapUsedBytes": 94240648,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 36.36899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 274,
"frameDurationMs": 26.766666666666673,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 863.8479999999618,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.8960000000001,
"heapDeltaBytes": 14529604,
"heapUsedBytes": 86326328,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 38.73500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 251,
"frameDurationMs": 25.48823529411763,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 672.378000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 250.52199999999968,
"heapDeltaBytes": -12935584,
"heapUsedBytes": 83106072,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 86.05500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 20.703030303030296,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 720.2669999999785,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.37199999999984,
"heapDeltaBytes": -12997896,
"heapUsedBytes": 87440944,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 103.00400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 88,
"frameDurationMs": 20.477142857142876,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5908.372000000014,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.439000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4768.442,
"heapDeltaBytes": 8216860,
"heapUsedBytes": 94429576,
"domNodes": -141,
"jsHeapTotalBytes": -13242368,
"scriptDurationMs": 3783.902,
"eventListeners": -73,
"totalBlockingTimeMs": 1,
"frameDurationMs": 18.436875,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6076.426000000027,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1999999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4827.794,
"heapDeltaBytes": 567448,
"heapUsedBytes": 69965428,
"domNodes": -141,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 3924.178,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.19778481012658,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5897.318000000013,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6759999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4838.961,
"heapDeltaBytes": -11623304,
"heapUsedBytes": 69638912,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 3855.256,
"eventListeners": 0,
"totalBlockingTimeMs": 27,
"frameDurationMs": 18.729206349206347,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5868.849999999952,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.5279999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4854.594000000001,
"heapDeltaBytes": 92296,
"heapUsedBytes": 86552892,
"domNodes": -172,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 3820.977,
"eventListeners": -81,
"totalBlockingTimeMs": 8,
"frameDurationMs": 18.38996865203762,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "large-graph-idle",
"durationMs": 2010.417000000018,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.1329999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 272.136,
"heapDeltaBytes": -4770060,
"heapUsedBytes": 74775240,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 18.008000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.759000000031,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5700000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.12,
"heapDeltaBytes": -3724884,
"heapUsedBytes": 85277648,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.154,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2066.1499999999933,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.935,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.3649999999999,
"heapDeltaBytes": -9690096,
"heapUsedBytes": 80957648,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 513.2359999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2229.658000000029,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.706999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1065.1709999999998,
"heapDeltaBytes": -12555224,
"heapUsedBytes": 67785640,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 557.005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666417910447763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3102.38099999998,
"styleRecalcs": 74,
"styleRecalcDurationMs": 8.005999999999998,
"layouts": 60,
"layoutDurationMs": 15.499,
"taskDurationMs": 1014.389,
"heapDeltaBytes": 5688192,
"heapUsedBytes": 74452876,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 488.81399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665591397849465,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3161.2440000000106,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.378,
"layouts": 60,
"layoutDurationMs": 17.665,
"taskDurationMs": 1134.309,
"heapDeltaBytes": 5455328,
"heapUsedBytes": 69795096,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 517.0790000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666315789473682,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "legacy-node-drag",
"durationMs": 2248.2160000000135,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.638000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1143.582,
"heapDeltaBytes": 17718572,
"heapUsedBytes": 87276328,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 621.575,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592592592593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2305.6250000000205,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.221999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1275.074,
"heapDeltaBytes": -7191132,
"heapUsedBytes": 71777704,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 664.913,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.8019999999601,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2439999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.139,
"heapDeltaBytes": -4843920,
"heapUsedBytes": 76212420,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 24.633000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.1410000000333,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.710999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.715,
"heapDeltaBytes": -2145572,
"heapUsedBytes": 88261160,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.595,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 377.9049999999984,
"styleRecalcs": 50,
"styleRecalcDurationMs": 5.513000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 239.586,
"heapDeltaBytes": 12306000,
"heapUsedBytes": 74247376,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 87.97500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66956521739131,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 448.1309999999894,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.145000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 280.041,
"heapDeltaBytes": 13037308,
"heapUsedBytes": 77301400,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 98.925,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370367,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2004.7869999999648,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.2399999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 242.437,
"heapDeltaBytes": 3804076,
"heapUsedBytes": 67063176,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.183999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.1349999999816,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0410000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 215.38199999999998,
"heapDeltaBytes": 2265288,
"heapUsedBytes": 58054680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.658,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.0559999999932,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.951,
"layouts": 16,
"layoutDurationMs": 4.577,
"taskDurationMs": 426.00800000000004,
"heapDeltaBytes": 21871800,
"heapUsedBytes": 83111208,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 69.122,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.830999999955,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.595,
"layouts": 16,
"layoutDurationMs": 5.6499999999999995,
"taskDurationMs": 521.123,
"heapDeltaBytes": 21247380,
"heapUsedBytes": 76372168,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.75200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.5639999999516,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.046,
"layouts": 5,
"layoutDurationMs": 8.531000000000002,
"taskDurationMs": 543.8779999999999,
"heapDeltaBytes": 32576168,
"heapUsedBytes": 108427660,
"domNodes": 14570,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 17.633000000000003,
"eventListeners": 2458,
"totalBlockingTimeMs": 55,
"frameDurationMs": 18.6046511627907,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8103.376000000026,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.481,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3371.799,
"heapDeltaBytes": 7030356,
"heapUsedBytes": 84278020,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1781.488,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665843621399176,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.412999999988,
"styleRecalcs": 249,
"styleRecalcDurationMs": 23.918000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3949.575,
"heapDeltaBytes": 10518744,
"heapUsedBytes": 84314196,
"domNodes": 0,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 1972.805,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666064257028115,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12025.60299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11152.063999999998,
"heapDeltaBytes": -28227072,
"heapUsedBytes": 186943204,
"domNodes": -3046,
"jsHeapTotalBytes": 7688192,
"scriptDurationMs": 161.29,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.5339590443686,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 12560.592000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11974.659,
"heapDeltaBytes": -36289408,
"heapUsedBytes": 185031200,
"domNodes": -3046,
"jsHeapTotalBytes": 8998912,
"scriptDurationMs": 181.508,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.497255574614066,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 14623.671000000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.425000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14193.166000000001,
"heapDeltaBytes": -30105780,
"heapUsedBytes": 185868564,
"domNodes": -3046,
"jsHeapTotalBytes": 3428352,
"scriptDurationMs": 669.3670000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 50,
"frameDurationMs": 26.587114337568053,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 14974.59200000003,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.229000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14560.233,
"heapDeltaBytes": -25774744,
"heapUsedBytes": 187569912,
"domNodes": -3046,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 644.1309999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.153887884267633,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4527.254000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.038999999999994,
"layouts": 20,
"layoutDurationMs": 22.836999999999996,
"taskDurationMs": 4393.487,
"heapDeltaBytes": 1168668,
"heapUsedBytes": 225508208,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 73.43100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.373595505617978,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4506.907000000069,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.58000000000001,
"layouts": 20,
"layoutDurationMs": 24.02,
"taskDurationMs": 4373.911,
"heapDeltaBytes": -591776,
"heapUsedBytes": 217400608,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 73.689,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.422598870056493,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6374.588000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5952.098999999998,
"heapDeltaBytes": -27790864,
"heapUsedBytes": 184531232,
"domNodes": -3046,
"jsHeapTotalBytes": 8527872,
"scriptDurationMs": 86.26699999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.2923076923077,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6368.64700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5934.3330000000005,
"heapDeltaBytes": -25831440,
"heapUsedBytes": 190564120,
"domNodes": -3046,
"jsHeapTotalBytes": 16535552,
"scriptDurationMs": 90.783,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.29264214046822,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 453.6709999999857,
"styleRecalcs": 19,
"styleRecalcDurationMs": 13.432999999999998,
"layouts": 4,
"layoutDurationMs": 1.63,
"taskDurationMs": 99.03799999999998,
"heapDeltaBytes": 6487340,
"heapUsedBytes": 61081796,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 71.5340000000424,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.176,
"layouts": 3,
"layoutDurationMs": 1.3559999999999999,
"taskDurationMs": 54.321000000000005,
"heapDeltaBytes": 4036520,
"heapUsedBytes": 62593920,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.748,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 352.31800000008207,
"styleRecalcs": 78,
"styleRecalcDurationMs": 59.826,
"layouts": 76,
"layoutDurationMs": 17.317,
"taskDurationMs": 328.639,
"heapDeltaBytes": 12627564,
"heapUsedBytes": 84241592,
"domNodes": 76,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 107.065,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668181818181832,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 327.474000000052,
"styleRecalcs": 78,
"styleRecalcDurationMs": 58.636,
"layouts": 76,
"layoutDurationMs": 15.417,
"taskDurationMs": 291.406,
"heapDeltaBytes": 12521504,
"heapUsedBytes": 84393188,
"domNodes": 76,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 92.619,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 721.8030000000226,
"styleRecalcs": 78,
"styleRecalcDurationMs": 194.541,
"layouts": 76,
"layoutDurationMs": 23.529999999999998,
"taskDurationMs": 678.015,
"heapDeltaBytes": 5164332,
"heapUsedBytes": 111184336,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 166.28500000000003,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 747.2420000000284,
"styleRecalcs": 78,
"styleRecalcDurationMs": 197.31699999999998,
"layouts": 76,
"layoutDurationMs": 25.604,
"taskDurationMs": 708.57,
"heapDeltaBytes": -16583508,
"heapUsedBytes": 109125680,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 172.803,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2235 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 091f18c8b1a1793e992216a87a11104ad1f2b9fe
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-20640.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-dklwej8iv-comfyui.vercel.app Last updated: 2026-10-16T17:00:11Z for |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (26.15%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## feat/website-cms-test-preview #20640 +/- ##
================================================================
Coverage ? 84.85%
================================================================
Files ? 3617
Lines ? 171425
Branches ? 45058
================================================================
Hits ? 145457
Misses ? 23873
Partials ? 2095
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…in a new tab Also split the middleware so the demo error wrapper stays small.
Replaces the middleware wrapper; the demo build alone injects /500.
On Vercel the function failed to import ScrollToPlugin by name from gsap's ESM files, which sit in a package Node reads as CommonJS.
One person publishing in the shared demo emptied the Draft for everyone else on that function instance. Each sign-in now gets its own credential and its own in-memory catalog.
|
This doesn't come from this PR. The diff only touches There's no fix to port yet. I'll re-run the failed job once when the run finishes. Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
Live is now a preview view instead of leaving preview, so the bar stays until Exit preview. The bar stacks above the sticky header, which docks below it. The admin sidebar title gets the Comfy mark.
…w flow The preview bar only shows on the site, not in the admin. Preview draft opens the list of changed pages on arrival and is hidden when the draft is empty. The bar counts page changes, which is what the preview shows, and says workflow submissions are checked in Comfy Cloud. Sheets cover the bar again, and the reject note no longer mentions the review API.
…lk review
From the workshop standup review of the admin design:
- Content editor at /admin/edit/{uid}: name, summary, credit and tags in
English and Chinese, cover, examples with prompts, each input's default
and whether it is basic, advanced or hidden, visibility and schedule.
Saving puts the item in the draft through the site API's item endpoint,
after checking it against the schemas the website renders from.
- Add content starts from a copy of an existing item; archive and restore
are saves with the deleted flag. All content lists new and archived
items and links each row to its editor.
- Publish history can restore any earlier publish, not only the previous.
- The Draft queue includes, leaves out or rejects everything a filter or
search shows.
- The preview bar links back to the admin and to the editor of the page
in view, and in Draft labels the cards and links the draft changes.
- The demo mock saves items, archives, and restores real LIVE snapshots.
…parts Keeps each template and function within the complexity limits: the editor's header, details, cover and publishing panel are their own components, parameter rows render separately, history moves to its own Astro component, and the publish, revert and reject actions and the mock save are split into single-purpose functions.
The cover and each example take an uploaded image or video as well as a link. Until the site API has file storage, only the demo accepts uploads and keeps them inline, up to 3 MB; elsewhere the button explains why it is off. Draft items now go through the checks a reviewer makes before publishing: the page builds, and it has a name, a description, a cover and, for models, examples. Gaps show on the row, in the review panel and in the publish confirmation, and never block publishing. The demo's new sample model is left incomplete to show them.
Draft opens with the same layout as All content: tabs on the left with their underline, type and search on the right, and one table whose header box ticks every row shown. Publish moves to the page header next to View draft on site.
|
Two app e2e checks are red on ff262a4. Neither failure comes from this PR, which only changes the
I don't know of an existing fix to port for either one, so I'm re-running the failed jobs once. Generated by Claude Code |
|
Follow-up: I re-ran
The sidebar shard is on the same re-run, and I'll report back if it fails again. Generated by Claude Code |
The review panel footer can take any change out of the draft: Discard changes for an edit, Delete for a page that isn't live yet, and Delete for a submitted workflow, which replaces the old Reject. See it on the page now opens a page that exists: a change that turns the page off opens the live page, and a scheduled one opens the draft at its start date.
Brings in Mar's admin shell, Draft table/tabs/filters, review drawer, final-review popup, content list/history components and editor controls, wired to the real catalog API instead of the sample-data ingest. Kept from the CCC integration: - checked-only publication (unchecked changes stay in the next Draft; checked tombstones publish as removals), trash discards a Draft change - server-confirmed final candidate; stale Draft is rejected - verified media uploads and protected Draft media previews - graph/API workflow pairs, author picker, Delete/Undelete Mar's sample-data login stays opt-in (SITE_CATALOG_DEMO=1) and is disabled on Vercel production.
MaanilVerma
left a comment
There was a problem hiding this comment.
These notes come from a review for the legacy workflow migration (Hub workflows and app templates into the CCC). Nothing here affects production today, because the static build output with SITE_CATALOG_API_URL unset keeps the same file list, sitemap, robots and llms files. Some comments name lines from the base branch feat/website-cms-test-preview. I anchored them on the closest line that this PR changes.
- problem: This branch conflicts with main in 8 files (
BaseLayout.astro,catalogue.json.test.ts,docs/adr/README.md, threeingest-typesfiles,pnpm-lock.yaml,pnpm-workspace.yaml) and with #20933 in 12 files (git merge-tree). - question: This PR and #20933 add two preview UIs with opposite LIVE-banner rules: ADR-0039 keeps the banner in Draft and LIVE, and ADR-0044 shows no banner in LIVE. Which ADR is the decision?
| kind: z.enum(['MODEL', 'WORKFLOW', 'APP']), | ||
| slug: z | ||
| .string() | ||
| .regex(/^\/hub\/(models|workflows|apps)\/[a-z0-9]+(?:-[a-z0-9]+)*$/), |
There was a problem hiding this comment.
problem: The admin writes target a different backend contract than the CCC stack in cloud #13026, #13028 and #13030. This schema requires slugs like /hub/workflows/x and visibility PUBLIC, the website mints the UID for a new item (index.astro:36), putItem sends no Idempotency-Key, and publish sends approved_uids. The Go store rejects each one, because its slug pattern is ^[a-z0-9]+(?:-[a-z0-9]+)*$, visibility is public or staff, a create with a given UID returns sql: no rows in result set, and publish requires a review-bound selection digest. Receipt: the Go schema probe and TestArchitectProbeClientMintedUID on cloud 2ee380f7b0. Can you align savedRecordSchema, putItem and publishCommand with the cloud contract, or tell us which backend this PR targets?
Context for agents
- Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
- Location:
apps/website/src/lib/cms/save-item.ts:10-20(savedRecordSchema),:54-77(putItem);apps/website/src/routes/admin/actions.ts:60-80(publishCommand);apps/website/src/routes/admin/index.astro:36 - Defect: The CCC store in the cloud stack rejects every create, save and publish from this console.
- Reproduce: On cloud
2ee380f7b0,ccc.Validateon a workflow with"slug":"/hub/workflows/x"returns$.slug: string doesn't match the regular expression "^[a-z0-9]+(?:-[a-z0-9]+)*$", with"visibility":"PUBLIC"returnsvalue is not one of the allowed values ["public","staff"], and withdata.formLayoutreturnsproperty "formLayout" is unsupported.s.Save(ctx, actor, Edit{ExpectedDraft: st.Draft, UID: uuid.NewString(), Type: "workflow", ...})returnssql: no rows in result set. - Expected vs actual: The console payloads validate against the CCC store / each one is rejected.
- Fix direction: Decide the contract first. If the target is the CCC stack: send
slugwithout the/hub/<kind>/prefix, lowercasevisibility, omituidon create and read it from the response, send anIdempotency-Keyheader per action, and publish with theReviewCheckedPublicationdigest (expected_selection_digest+selected_uids). - Test to add:
save-item.test.ts: assert the PUT body for a new item has nouid, hasslug: "x"andvisibility: "public", and the request has anIdempotency-Keyheader. - Related:
apps/website/src/lib/cms/admin.ts:31-38,apps/website/src/lib/cms/mock-ingest.ts(mock contract),packages/ingest-types(base branch types).
There was a problem hiding this comment.
Not changing this here. This PR is the admin's UX pass. The data seam (save-item.ts, actions.ts, mock-ingest.ts) follows the contract of the base branch feat/website-cms-test-preview, and which backend it targets is @benjcooley's call as owner of that branch and the integration. Once that's decided, aligning savedRecordSchema, putItem and publishCommand is contained to those modules, as the PR body's wiring table lists.
Generated by Claude Code
| return new Response('Invalid submission', { status: 400 }) | ||
| return { | ||
| commands: [ | ||
| ...approvals, |
There was a problem hiding this comment.
problem: publishCommand sends the legacy submission approvals first and the catalog publish last, and runCommands stops at the first error. If the catalog publish returns 409 (any save after the final review), the submissions stay approved on the live legacy Hub without the catalog change. A retry then sends the approvals again, which return 409 because the status is already set, so the retry stops before the publish. The mock publish never returns 409 (mock-ingest.ts:228-252), so the tests do not cover this path. Receipt (not tested at runtime): actions.ts:60-79,141-161 and contentcatalog/review.go:90-97 on cloud feat/hub-cms-test-preview, which returns 409 for a status that is already set. Can you send the catalog publish first and approve the submissions only after it succeeds, or move both writes into one backend endpoint?
Context for agents
- Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
- Location:
apps/website/src/routes/admin/actions.ts:60-80(functionpublishCommand),:141-162(functionrunCommands) - Defect: A non-atomic two-store publish can leave legacy approvals applied without the catalog publish, and a retry cannot recover.
- Reproduce: With a backend that returns 409 for
/admin/api/site/publish: POSTaction=publish,confirm=yes, oneapprove=<share>:<version>and oneapprove_item=<uid>. The approval POST returns 200, the publish returns 409. POST the same form again: the approval returns 409, and the publish is not sent. - Expected vs actual: Both writes apply, or neither / the approval applies alone, and the retry stops at the approval.
- Fix direction: Move the approvals into the backend publish call (one transaction), or reorder: publish first, then approvals, and treat a 409 "already approved" on approval as success.
- Test to add:
actions.test.ts: mock publish to return 409, assert that no approval request was sent (or that a retry after the 409 reaches the publish). - Related:
apps/website/src/lib/cms/mock-ingest.ts:228-252(add a 409 path to the mock).
There was a problem hiding this comment.
Fixed in 6388c94. publishCommand now sends the catalog publish first and the submission approvals after it, so a 409 on publish approves nothing. An approval that answers 409 counts as already applied, so a retry after a partial run gets through. actions.test.ts covers the order, the refused publish (no approval sent) and the already-approved case.
Generated by Claude Code
| if (session.preview?.now) url.searchParams.set('now', session.preview.now) | ||
| } | ||
| const response = await fetch(url, { | ||
| const response = await catalogFetch(url, { |
There was a problem hiding this comment.
problem: loadSiteCatalog parses all items with one z.array(modelSchema) and one z.array(detailSchema) (lines 44-55, from the base branch), and it applies modelSchema to workflow items too. Thus one Draft or Live item that does not match makes every /hub page return 503, also the pages of valid items. Receipt: at 83744da58f, line 54 returns { ok: false, status: 503 } when !models.success || !details.success. Can you parse each item on its own with the schema for its kind, drop the bad ones and render the rest?
Context for agents
- Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
- Location:
apps/website/src/lib/cms/catalog.ts:44-55(functionloadSiteCatalog, base branchfeat/website-cms-test-preview). Anchored on line 28, the closest line this PR changes. - Defect: An all-or-nothing array parse turns one invalid item into a site-wide 503.
- Reproduce: In a vitest for
loadSiteCatalog, stubcatalogFetchto return a valid projection with two model items, then make one item'sdatamiss a requiredmodelSchemafield. - Expected vs actual: The valid item renders and the bad one is dropped /
{ ok: false, status: 503 }. - Fix direction: Map over
projection.data.items,safeParseeachitem.datawithmodelSchema(forMODEL) or the workflow and app schema, keep the successes and report the failures. Return 503 only when the projection itself does not parse. - Test to add:
catalog.test.ts: with one bad item among two,loadSiteCatalog()returnsok: truewith one model. - Related:
apps/website/src/lib/cms/catalog-contract.ts(normalizeProjection).
There was a problem hiding this comment.
Fixed in 6388c94. loadSiteCatalog now safeParses each item on its own (modelSchema for every item, detailSchema for non-APP items) and drops the failures. It returns 503 only when the projection itself fails to parse. catalog.test.ts covers one broken model among valid ones: ok: true, and the broken one is absent.
Generated by Claude Code
| import { catalogFetch } from './demo' | ||
|
|
||
| // Server-only configuration. Browser islands read same-origin JSON endpoints. | ||
| export const cmsEnabled = () => Boolean(process.env.SITE_CATALOG_API_URL) |
There was a problem hiding this comment.
problem: cmsEnabled returns true whenever SITE_CATALOG_API_URL is set, and that enables SSR for /hub, but loadSiteCatalog (line 15) returns 503 when VERCEL_ENV === 'production'. Thus if someone sets SITE_CATALOG_API_URL in the production Vercel project, every /hub page returns 503 with X-Robots-Tag: noindex. Both lines come from the base branch feat/website-cms-test-preview. Receipt: a vitest probe with both variables set gets status 503 from loadSiteCatalog. Can you make cmsEnabled return false in production, so that production keeps the static pages?
Context for agents
- Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
- Location:
apps/website/src/lib/cms/catalog.ts:11(cmsEnabled) and:15(loadSiteCatalog), base branchfeat/website-cms-test-preview - Defect: The SSR switch and the production guard disagree, so one env var in production replaces the static
/hubpages with 503 responses. - Reproduce: In a vitest:
vi.stubEnv('SITE_CATALOG_API_URL', 'https://example.test'),vi.stubEnv('VERCEL_ENV', 'production'), thencmsEnabled()returns true andawait loadSiteCatalog()returns{ ok: false, status: 503 }. - Expected vs actual:
cmsEnabled()is false in production / true, and every/hubrequest returnscatalogUnavailable()(503,noindex). - Fix direction:
export const cmsEnabled = () => Boolean(process.env.SITE_CATALOG_API_URL) && process.env.VERCEL_ENV !== 'production', and remove the duplicate guard inloadSiteCatalog. - Test to add:
catalog.test.ts: with both variables stubbed,cmsEnabled()returns false. - Related:
apps/website/astro.config.tsandapps/website/src/middleware.ts(callers ofcmsEnabled).
There was a problem hiding this comment.
Fixed in 6388c94. cmsEnabled() is now false when VERCEL_ENV === 'production', and loadSiteCatalog and the middleware's cms switch both go through it, so the guard lives in one place. catalog.test.ts asserts cmsEnabled() is false with both variables set. (astro.config.ts still keys the adapter off the variable at build time. That doesn't matter for this case, because every route now falls back to the static data.)
Generated by Claude Code
| if (session.preview?.now) url.searchParams.set('now', session.preview.now) | ||
| } | ||
| const response = await fetch(url, { | ||
| const response = await catalogFetch(url, { |
There was a problem hiding this comment.
problem: Each SSR request fetches the full catalog projection with cache: 'no-store' and parses it three times with zod. The demo catalog of 180 items is 3.83 MB and took 2.53 s through ngrok, which is half of the 5 s timeout on line 32 that returns 503. At the import size of about 1,600 items, the response is about 34 MB for each page view. Receipt: items-live.json from the demo backend is 3,827,899 bytes for 180 items. Can you cache the projection per Live revision, or fetch only the items that the page renders?
Context for agents
- Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
- Location:
apps/website/src/lib/cms/catalog.ts:13-62(functionloadSiteCatalog), base branch code that this PR edits on line 28 - Defect: Every SSR page view downloads and parses the whole catalog, so latency and size grow linearly with the catalog.
- Reproduce: Point
SITE_CATALOG_API_URLat the demo backend and request any/hubpage twice: each request fetches/api/v1/catalog/itemsin full (3.83 MB for 180 items, 2.53 s via ngrok). - Expected vs actual: One fetch per Live revision (or per item) / one full fetch per request.
- Fix direction: Keep a module-level cache keyed by
live_revwith a short TTL (for example 30 s) for the public path, and add a by-slug endpoint for detail pages. Keepno-storeonly for the staff preview session path. - Test to add:
catalog.test.ts: twoloadSiteCatalog()calls without a session within the TTL callcatalogFetchonce. - Related:
apps/website/src/lib/cms/demo.ts(catalogFetch).
There was a problem hiding this comment.
Agreed this is needed before real catalog sizes, but it belongs with the backend integration on the base branch (a by-slug endpoint and a live_rev-keyed cache both depend on the API shape), so I'm leaving it to @benjcooley rather than widening this UX PR.
Generated by Claude Code
|
@MaanilVerma, on the two review-level points:
Generated by Claude Code |
…figured cmsRendering() turned off prerendering on every /hub route whenever SITE_CATALOG_API_URL was set, but cmsEnabled() refuses the CMS in production. Production then had neither prerendered pages nor a catalog, so every detail page returned 404. Both now use cmsEnabled(), moved to a dependency-free module so the integration can import it at config load.
…rashing the Hub formForWorkflow throws when a workflow's inputs and inputSchema disagree. safeParse does not catch a throw inside a transform, so one bad workflow broke loadSiteCatalog for every Hub page. The transform now reports a schema issue instead. loadSiteCatalog also drops an item that fails either schema from the projection, so its page returns 404 rather than being found and failing to render.
Ports the remaining change from Mar's #20640 head (6388c94, by way of a2bbfb4) into the integration branch. The legacy admin publish now sends the catalog publication first, so a refused publish approves nothing on the Hub, and a retry treats a 409 on a re-sent approval as already applied. This handler stays restricted to the sample-data demo. The other two commits on that head (production-static gate and dropping unreadable CMS items) already exist here in adapted form.
|
Hi Mar! #21204 now carries this PR forward. It keeps your admin layout (Draft table, tabs/filters, review drawer, final-review popup, editor, content/history views), wired to the real catalog API instead of the sample-data ingest, and includes this PR up to its current head |
Ports the remaining change from Mar's #20640 head (6388c94, by way of a2bbfb4) into the integration branch. The legacy admin publish now sends the catalog publication first, so a refused publish approves nothing on the Hub, and a retry treats a 409 on a re-sent approval as already applied. This handler stays restricted to the sample-data demo. The other two commits on that head (production-static gate and dropping unreadable CMS items) already exist here in adapted form.
Summary
Design pass on the Hub CMS admin from
feat/website-cms-test-preview. The admin and preview bar use the developer platform's neutral graphite look (tokens--color-admin-*, reka-ui primitives incomponents/cms/ui) instead of the marketing ink/yellow.Scope is the admin's UX. Data access goes through a few small modules, so the catalog API can be wired in without reshaping the screens:
lib/cms/staging.ts: review statuslib/cms/versions.ts: item historylib/cms/save-item.ts: saving and undolib/cms/submissions.ts: submitted workflowsDraft is a pick-and-publish list.
approved_uids). Unticked changes still in review move to Later first (POST staging), so the API sees nothing left to review. There are no per-row Approve, Later or Reject actions and no separate final review step.Review panel:
now=)action=undo)action=reject), replacing the old RejectUndo one change (
action=undo) puts a draft item back to its live value. An item that was never published becomes a tombstone instead. It's available from the review panel and from the editor.draftChangesignores saves whose content matches live.Workflow review: besides "Run in Comfy Cloud", the panel previews the Hub card with a "Pending approval" tag.
Readiness checks (
lib/cms/readiness.ts):Gaps show on the row, in the review panel and in the publish confirmation. They flag and never block.
All content has Active, Needs attention and Archived views, and sorts by popularity by default, with runs and downloads on each row. Needs attention runs the readiness checks over every page, with a filter per missing field.
List filters: the type filter and search always sit on the right, and the tab underline stops where they begin.
Content editor at
/admin/edit/{uid}.data.useCases, the catalogue's existing filter) is a searchable multi-select. For workflows, whether it runs on the page or is a node graph only (data.runsOnHub).data.faq, question and answer pairs).AdminSelect); parameter "Shown as" columns line up.It covers name, summary, credit and tags in English and 中文, the cover and example media (uploaded or linked), examples in order, and each input's default and placement. Saving sends
PUT /admin/api/site/items/{uid}, but only after the item passes the catalogue and page schemas.Add content at
/admin/newstarts from a copy of an existing item.Publish history: restore any earlier publish.
Navigation fits on one line on phones.
Preview bar:
Wiring to the catalog API (each item is one module):
/admin/api/site/…)GET staging/POST staging {items:[{id,status}]}GET/POST /api/v1/catalog/draft/staging(statuses,selected_uids)POST publish {approved_uids}GET items/{uid}/historyGET /api/v1/catalog/items/{uid}/historyPUTof that save)POST /api/v1/catalog/draft/items/{uid}/restorePUTof the live value)POST /api/v1/catalog/draft/items/{uid}/restore-liveStill needs backend support:
data.translations['zh-CN']data.formLayout(basic, advanced or hidden per input)data.faqanddata.runsOnHub, and a Hub page layout for node-graph-only workflowsdata.popularity,data.downloadsanddata.runsper item, filled in from analytics. The editor only shows them and writes back what it loaded, so a page copied from a template starts empty.target_idon revertSiteSubmissionThe
cms-demolabel builds this PR's Vercel preview with the admin on in-memory sample data (lib/cms/mock-ingest.ts)./adminwithout a session goes to the demo entry.VERCEL_ENVisproduction.Enter at
/admin/local-access.Verification
pnpm typecheck:website, eslint, oxlint, knip and fallow pass (repo hooks).lib/cms,routes/admin,components/cmsand the middleware. New tests cover: