Skip to content

feat(website): Hub admin redesign, content editor and a shareable demo preview - #20640

Open
mariana953 wants to merge 43 commits into
feat/website-cms-test-previewfrom
claude/fervent-dijkstra-i2d35k
Open

mariana953 wants to merge 43 commits into
feat/website-cms-test-previewfrom
claude/fervent-dijkstra-i2d35k

Conversation

@mariana953

@mariana953 mariana953 commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Design pass on the Hub CMS admin from feat/website-cms-test-preview. The admin and preview bar use the developer platform's neutral graphite look (tokens --color-admin-*, reka-ui primitives in components/cms/ui) instead of the marketing ink/yellow.

Scope is the admin's UX. Data access goes through a few small modules, so the catalog API can be wired in without reshaping the screens:

  • lib/cms/staging.ts: review status

  • lib/cms/versions.ts: item history

  • lib/cms/save-item.ts: saving and undo

  • lib/cms/submissions.ts: submitted workflows

  • Draft is a pick-and-publish list.

    • Same layout as All content: tabs All, New content (models, workflows and apps not on the Hub yet) and Updates (edits to live pages) on the left; type filter and search on the right.
    • One table. Its header box ticks every row shown. Publish N changes in the page header opens the publish confirmation straight away. The confirmation lists the ticked changes and their gaps, and says how many stay in the draft.
    • Only the ticked changes are published (approved_uids). Unticked changes still in review move to Later first (POST staging), so the API sees nothing left to review. There are no per-row Approve, Later or Reject actions and no separate final review step.
    • "View draft on site" opens the preview.
  • Review panel:

    • Actions come first. When every check passes, readiness is one line.
    • See it on the page opens a page that exists:
      • a change that turns the page off opens the live page ("See the live page")
      • a scheduled change opens the draft at its start date (now=)
    • Then "What changes on the site": image fields show before and after pictures, and dates are readable.
    • The footer has Add to publish, which ticks the row, and a way to take the change out of the draft:
      • Discard changes for an edit (action=undo)
      • Delete for a page that isn't live yet
      • Delete for a submitted workflow (action=reject), replacing the old Reject
  • Undo one change (action=undo) puts a draft item back to its live value. An item that was never published becomes a tombstone instead. It's available from the review panel and from the editor. draftChanges ignores saves whose content matches live.

  • Workflow review: besides "Run in Comfy Cloud", the panel previews the Hub card with a "Pending approval" tag.

  • Readiness checks (lib/cms/readiness.ts):

    • the page builds against the catalogue and page schemas
    • it has a name, a summary and a cover
    • models also need at least one example

    Gaps show on the row, in the review panel and in the publish confirmation. They flag and never block.

  • All content has Active, Needs attention and Archived views, and sorts by popularity by default, with runs and downloads on each row. Needs attention runs the readiness checks over every page, with a filter per missing field.

  • List filters: the type filter and search always sit on the right, and the tab underline stops where they begin.

  • Content editor at /admin/edit/{uid}.

    • A View card button in the header opens the Hub card built from the form, unsaved edits included.
    • Name, address and cover errors show as soon as the field is edited. The saved notice links to the page preview.
    • The sidebar starts with read-only Usage (popularity, runs, downloads), then visibility and the scheduled date, undo changes, archive and restore. New pages don't show visibility controls: they always go through review in the Draft.
    • Version history lists every save with who made it and when, marks the live and current versions, and restores any earlier save into the draft.
    • Tags are chips (Enter or a comma adds one). Use cases (data.useCases, the catalogue's existing filter) is a searchable multi-select. For workflows, whether it runs on the page or is a node graph only (data.runsOnHub).
    • FAQ (data.faq, question and answer pairs).
    • Dropdowns use one styled select (AdminSelect); parameter "Shown as" columns line up.

    It covers name, summary, credit and tags in English and 中文, the cover and example media (uploaded or linked), examples in order, and each input's default and placement. Saving sends PUT /admin/api/site/items/{uid}, but only after the item passes the catalogue and page schemas.

  • Add content at /admin/new starts from a copy of an existing item.

  • Publish history: restore any earlier publish.

  • Navigation fits on one line on phones.

  • Preview bar:

    • stays on in Draft and Live, pinned above the header
    • Draft is marked in blue with a thin frame around the page; Live is green
    • links to the admin and to the page's editor
    • labels and outlines the cards the draft changes
    • counts the workflows waiting for approval

Wiring to the catalog API (each item is one module):

Admin call (/admin/api/site/…) Catalog API
GET staging / POST staging {items:[{id,status}]} GET / POST /api/v1/catalog/draft/staging (statuses, selected_uids)
POST publish {approved_uids} publish of the reviewed generation
GET items/{uid}/history GET /api/v1/catalog/items/{uid}/history
restore a version (PUT of that save) POST /api/v1/catalog/draft/items/{uid}/restore
undo a change (PUT of the live value) POST /api/v1/catalog/draft/items/{uid}/restore-live

Still needs backend support:

  • data.translations['zh-CN']
  • data.formLayout (basic, advanced or hidden per input)
  • data.faq and data.runsOnHub, and a Hub page layout for node-graph-only workflows
  • data.popularity, data.downloads and data.runs per item, filled in from analytics. The editor only shows them and writes back what it loaded, so a page copied from a template starts empty.
  • target_id on revert
  • file storage for uploads (demo keeps them inline up to 3 MB)
  • thumbnail, creator name and models used on SiteSubmission

The cms-demo label builds this PR's Vercel preview with the admin on in-memory sample data (lib/cms/mock-ingest.ts).

  • The mock implements staging, partial publish, per-item save history, uploads, LIVE snapshots and sample usage numbers.
  • Each visitor gets a separate sandbox. Opening /admin without a session goes to the demo entry.
  • It is refused when VERCEL_ENV is production.

Enter at /admin/local-access.

Verification

  • pnpm typecheck:website, eslint, oxlint, knip and fallow pass (repo hooks).
  • Unit tests pass for lib/cms, routes/admin, components/cms and the middleware. New tests cover:
    • staging decisions, including the permission check and the client post
    • publishing only approved items
    • "edited after approval" resetting to review
    • item history and restoring a version, with its refusals
    • undo
    • readable dates in diffs
    • new pages start public, and use cases, FAQ and run mode survive a save
    • reading usage numbers, sorting by popularity and short number formatting
    • the demo entry redirect, and the admin staying hidden outside the demo
  • In a browser against the local demo:
    • Draft tabs: All shows 6 rows and Updates shows 3. Publish stays disabled until a row is ticked. With two rows ticked, Publish opens the confirmation listing both, with "4 changes you didn't pick stay in the draft".
    • Add to publish in the review panel ticks the row. Publishing that one change lands on Publish history and leaves the other five in Draft.
    • See it on the page returns 200 for all four catalog changes in the demo draft. Before this change, the disabled one and the scheduled one returned 404.
    • Delete on a submitted workflow removes it from Draft (6 rows → 5). The footer reads Delete on a new model and Discard changes on an edit.
    • restore the oldest save of an edited model: the page matches live again
    • undo from the panel and from the editor
    • add and remove tags as chips; pick use cases from the dropdown; change audience and parameter defaults with the styled select
    • All content sorted by popularity, with runs and downloads; Usage in the editor sidebar
    • set use cases, the node-graph-only mode and an FAQ on a workflow, save, and see them kept
    • errors appear while typing on a new page; the saved notice opens the page preview
    • Needs attention filters, View card, uploads, archive and restore, add from template, restore a publish, the preview bar in Draft and Live, and Draft, All content and the nav at 390px

claude added 7 commits October 8, 2026 16:16
One Draft list merges catalog changes and workflow submissions, with a
review sheet, Run in Comfy Cloud, publish that approves the included
workflows, multi-reject, All content, publish history with rollback,
and a slimmer preview bar with a time picker and a changes list.
Adds shadcn-vue Switch, Checkbox and Popover in the site's style.
Moves listing filters, stats, rows, review details, the time picker and
the changes list into their own components, and the filtering rules into
tested helpers, so each template stays small.
The admin and the preview bar are work tools, so they now use the
developer platform's graphite palette, type scale and controls instead
of the marketing site's ink and yellow: a sidebar shell, dense tables,
status dots, 8px controls and neutral dialogs and side panels.

Admin primitives (button, dialog, side panel, status label, page header)
live in components/cms/ui on top of reka-ui, and BaseLayout gains a
bare mode so the admin can bring its own chrome.
A pull request labelled cms-demo now builds its Vercel preview with the
Hub admin running on in-memory sample data, so design can share a link
without a backend. The mock that pnpm dev:cms serves moves to
lib/cms/mock-ingest.ts; in demo mode the site API and catalog reads are
answered by it instead of the network. The flag is baked in at build
time and refused when VERCEL_ENV is production.

All content's row actions become icon buttons with platform tooltips.
@mariana953 mariana953 added the cms-demo label Oct 9, 2026 — with Claude
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7a74ca6d-efc9-4e90-b43b-906288cb740b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 38.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 263ms TBT · 86.1 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 48.6 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 85ms TBT · 81.3 MB heap
extension-clean-combined-draw: · 53.1 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 1ms TBT · 78.4 MB heap
extension-rgthree-prototype-draw: · 53.9 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 18ms TBT · 74.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.0 MB heap
subgraph-transition-enter: · 53.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 55ms TBT · 103.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
vue-large-graph-idle: · 47.6 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 177.4 MB heap
vue-large-graph-pan: · 37.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 25ms TBT · 178.1 MB heap
vue-node-resize-workload: · 39.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 211.2 MB heap
vue-zoom-out-idle: · 47.0 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 178.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.0 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 105.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 265ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.9 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 71
canvas-mouse-sweep: task duration 477ms
canvas-mouse-sweep: script duration 96ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.4 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 5ms
canvas-zoom-sweep: layout count 3
canvas-zoom-sweep: style recalc count 18
canvas-zoom-sweep: task duration 240ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 65.8 MB
canvas-zoom-sweep: DOM nodes 45
canvas-zoom-sweep: event listeners 39
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 4ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 17
dom-widget-clipping: task duration 292ms
dom-widget-clipping: script duration 106ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 66.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 26ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 478ms
dom-widget-order-dense-n200-w200-i120: script duration 38ms
dom-widget-order-dense-n200-w200-i120: TBT 263ms
dom-widget-order-dense-n200-w200-i120: heap used 86.1 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 21ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 263ms
dom-widget-order-sparse-n1000-w20-i120: script duration 95ms
dom-widget-order-sparse-n1000-w20-i120: TBT 85ms
dom-widget-order-sparse-n1000-w20-i120: heap used 81.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 5
extension-clean-combined-draw: task duration 4798ms
extension-clean-combined-draw: script duration 3854ms
extension-clean-combined-draw: TBT 1ms
extension-clean-combined-draw: heap used 78.4 MB
extension-clean-combined-draw: DOM nodes -141
extension-clean-combined-draw: event listeners -69
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 5
extension-rgthree-prototype-draw: task duration 4847ms
extension-rgthree-prototype-draw: script duration 3838ms
extension-rgthree-prototype-draw: TBT 18ms
extension-rgthree-prototype-draw: heap used 74.5 MB
extension-rgthree-prototype-draw: DOM nodes -86
extension-rgthree-prototype-draw: event listeners -41
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 11
large-graph-idle: task duration 296ms
large-graph-idle: script duration 24ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 76.3 MB
large-graph-idle: DOM nodes 0
large-graph-idle: event listeners 0
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 8ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 991ms
large-graph-pan: script duration 535ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 70.9 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 17ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1074ms
large-graph-zoom: script duration 503ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 68.8 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 49
legacy-node-drag: task duration 1209ms
legacy-node-drag: script duration 643ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 75.8 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 10
minimap-idle: task duration 362ms
minimap-idle: script duration 29ms
minimap-idle: TBT 0ms
minimap-idle: heap used 78.4 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 6ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 50
subgraph-dom-widget-clipping: task duration 260ms
subgraph-dom-widget-clipping: script duration 93ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 72.3 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 229ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.7 MB
subgraph-idle: DOM nodes 0
subgraph-idle: event listeners 0
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 13ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 75
subgraph-mouse-sweep: task duration 474ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 76.0 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 17ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 544ms
subgraph-transition-enter: script duration 18ms
subgraph-transition-enter: TBT 55ms
subgraph-transition-enter: heap used 103.4 MB
subgraph-transition-enter: DOM nodes 14570
subgraph-transition-enter: event listeners 2458
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 23ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3661ms
viewport-pan-sweep: script duration 1877ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.4 MB
viewport-pan-sweep: DOM nodes 0
viewport-pan-sweep: event listeners 0
vue-large-graph-idle: avg frame time 21ms
vue-large-graph-idle: p95 frame time 33ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11563ms
vue-large-graph-idle: script duration 171ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 177.4 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 27ms
vue-large-graph-pan: p95 frame time 50ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 10ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 68
vue-large-graph-pan: task duration 14377ms
vue-large-graph-pan: script duration 657ms
vue-large-graph-pan: TBT 25ms
vue-large-graph-pan: heap used 178.1 MB
vue-large-graph-pan: DOM nodes -3046
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 25ms
vue-node-resize-workload: p95 frame time 50ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 47ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4384ms
vue-node-resize-workload: script duration 74ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 211.2 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 21ms
vue-zoom-out-idle: p95 frame time 33ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5943ms
vue-zoom-out-idle: script duration 89ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 178.9 MB
vue-zoom-out-idle: DOM nodes -3046
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 77ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 59.0 MB
workflow-execution: DOM nodes 129
workflow-execution: event listeners 57
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 16ms
agent-composer-empty-conversation-typing: style recalc duration 59ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 310ms
agent-composer-empty-conversation-typing: script duration 100ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 80.4 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 25ms
agent-composer-long-conversation-typing: style recalc duration 196ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 693ms
agent-composer-long-conversation-typing: script duration 170ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 105.1 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-16T17:08:05.658Z",
  "gitSha": "b66b8313a6852a5e21b54b217c2bfd13e03f6c01",
  "branch": "claude/fervent-dijkstra-i2d35k",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2010.6810000000053,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.0659999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 243.01700000000002,
      "heapDeltaBytes": 7453720,
      "heapUsedBytes": 76764124,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.211999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2009.3689999999924,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.5469999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 287.532,
      "heapDeltaBytes": 3569080,
      "heapUsedBytes": 65728680,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.447,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1672.6680000000158,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 11.374,
      "layouts": 12,
      "layoutDurationMs": 3.9380000000000006,
      "taskDurationMs": 435.12100000000004,
      "heapDeltaBytes": 25607392,
      "heapUsedBytes": 79547188,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 86.476,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1677.705000000003,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 14.282000000000002,
      "layouts": 12,
      "layoutDurationMs": 4.031999999999999,
      "taskDurationMs": 518.931,
      "heapDeltaBytes": -585208,
      "heapUsedBytes": 61893864,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 106.018,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1716.6439999999739,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 4.286999999999999,
      "layouts": 3,
      "layoutDurationMs": 0.8619999999999997,
      "taskDurationMs": 193.61299999999997,
      "heapDeltaBytes": 4492048,
      "heapUsedBytes": 59427500,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.122,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66504854368932,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.2399999999852,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 6.564,
      "layouts": 3,
      "layoutDurationMs": 0.9629999999999999,
      "taskDurationMs": 286.163,
      "heapDeltaBytes": 9713456,
      "heapUsedBytes": 78468952,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.457999999999998,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 410.9619999999836,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 4.234999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 290.037,
      "heapDeltaBytes": 16245116,
      "heapUsedBytes": 75208688,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 106.02999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667999999999992,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 447.23600000003216,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 3.844000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 294.439,
      "heapDeltaBytes": -4917308,
      "heapUsedBytes": 64646036,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 106.07699999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662962962962965,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 883.3360000000141,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 476.36499999999995,
      "heapDeltaBytes": 12242028,
      "heapUsedBytes": 94240648,
      "domNodes": 0,
      "jsHeapTotalBytes": 3309568,
      "scriptDurationMs": 36.36899999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 274,
      "frameDurationMs": 26.766666666666673,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 863.8479999999618,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.8960000000001,
      "heapDeltaBytes": 14529604,
      "heapUsedBytes": 86326328,
      "domNodes": 0,
      "jsHeapTotalBytes": 2785280,
      "scriptDurationMs": 38.73500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 251,
      "frameDurationMs": 25.48823529411763,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 672.378000000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 250.52199999999968,
      "heapDeltaBytes": -12935584,
      "heapUsedBytes": 83106072,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 86.05500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 82,
      "frameDurationMs": 20.703030303030296,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 720.2669999999785,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 276.37199999999984,
      "heapDeltaBytes": -12997896,
      "heapUsedBytes": 87440944,
      "domNodes": 0,
      "jsHeapTotalBytes": 528384,
      "scriptDurationMs": 103.00400000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 20.477142857142876,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5908.372000000014,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.439000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4768.442,
      "heapDeltaBytes": 8216860,
      "heapUsedBytes": 94429576,
      "domNodes": -141,
      "jsHeapTotalBytes": -13242368,
      "scriptDurationMs": 3783.902,
      "eventListeners": -73,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 18.436875,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 6076.426000000027,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1999999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4827.794,
      "heapDeltaBytes": 567448,
      "heapUsedBytes": 69965428,
      "domNodes": -141,
      "jsHeapTotalBytes": -10883072,
      "scriptDurationMs": 3924.178,
      "eventListeners": -65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.19778481012658,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5897.318000000013,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 0.6759999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4838.961,
      "heapDeltaBytes": -11623304,
      "heapUsedBytes": 69638912,
      "domNodes": 0,
      "jsHeapTotalBytes": -22282240,
      "scriptDurationMs": 3855.256,
      "eventListeners": 0,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 18.729206349206347,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5868.849999999952,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 1.5279999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4854.594000000001,
      "heapDeltaBytes": 92296,
      "heapUsedBytes": 86552892,
      "domNodes": -172,
      "jsHeapTotalBytes": -10883072,
      "scriptDurationMs": 3820.977,
      "eventListeners": -81,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 18.38996865203762,
      "p95FrameDurationMs": 33.30000000000018
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2010.417000000018,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.1329999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 272.136,
      "heapDeltaBytes": -4770060,
      "heapUsedBytes": 74775240,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 18.008000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.759000000031,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.5700000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 319.12,
      "heapDeltaBytes": -3724884,
      "heapUsedBytes": 85277648,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 29.154,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2066.1499999999933,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 7.935,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 916.3649999999999,
      "heapDeltaBytes": -9690096,
      "heapUsedBytes": 80957648,
      "domNodes": 0,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 513.2359999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66532258064516,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2229.658000000029,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 7.706999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1065.1709999999998,
      "heapDeltaBytes": -12555224,
      "heapUsedBytes": 67785640,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 557.005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666417910447763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3102.38099999998,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 8.005999999999998,
      "layouts": 60,
      "layoutDurationMs": 15.499,
      "taskDurationMs": 1014.389,
      "heapDeltaBytes": 5688192,
      "heapUsedBytes": 74452876,
      "domNodes": 24,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 488.81399999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665591397849465,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3161.2440000000106,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 8.378,
      "layouts": 60,
      "layoutDurationMs": 17.665,
      "taskDurationMs": 1134.309,
      "heapDeltaBytes": 5455328,
      "heapUsedBytes": 69795096,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 517.0790000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666315789473682,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2248.2160000000135,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 5.638000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1143.582,
      "heapDeltaBytes": 17718572,
      "heapUsedBytes": 87276328,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 621.575,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66592592592593,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2305.6250000000205,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.221999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1275.074,
      "heapDeltaBytes": -7191132,
      "heapUsedBytes": 71777704,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 664.913,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665217391304346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.8019999999601,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.2439999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 293.139,
      "heapDeltaBytes": -4843920,
      "heapUsedBytes": 76212420,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 24.633000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666942148760334,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.1410000000333,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.710999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.715,
      "heapDeltaBytes": -2145572,
      "heapUsedBytes": 88261160,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 33.595,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 377.9049999999984,
      "styleRecalcs": 50,
      "styleRecalcDurationMs": 5.513000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 239.586,
      "heapDeltaBytes": 12306000,
      "heapUsedBytes": 74247376,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 87.97500000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66956521739131,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 448.1309999999894,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 6.145000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 280.041,
      "heapDeltaBytes": 13037308,
      "heapUsedBytes": 77301400,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 98.925,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670370370370367,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.7869999999648,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.2399999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 242.437,
      "heapDeltaBytes": 3804076,
      "heapUsedBytes": 67063176,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.183999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.1349999999816,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.0410000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 215.38199999999998,
      "heapDeltaBytes": 2265288,
      "heapUsedBytes": 58054680,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.658,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.0559999999932,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 11.951,
      "layouts": 16,
      "layoutDurationMs": 4.577,
      "taskDurationMs": 426.00800000000004,
      "heapDeltaBytes": 21871800,
      "heapUsedBytes": 83111208,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 69.122,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1680.830999999955,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 14.595,
      "layouts": 16,
      "layoutDurationMs": 5.6499999999999995,
      "taskDurationMs": 521.123,
      "heapDeltaBytes": 21247380,
      "heapUsedBytes": 76372168,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 83.75200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665346534653462,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 800.5639999999516,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 17.046,
      "layouts": 5,
      "layoutDurationMs": 8.531000000000002,
      "taskDurationMs": 543.8779999999999,
      "heapDeltaBytes": 32576168,
      "heapUsedBytes": 108427660,
      "domNodes": 14570,
      "jsHeapTotalBytes": 2621440,
      "scriptDurationMs": 17.633000000000003,
      "eventListeners": 2458,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 18.6046511627907,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8103.376000000026,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 21.481,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3371.799,
      "heapDeltaBytes": 7030356,
      "heapUsedBytes": 84278020,
      "domNodes": 0,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 1781.488,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665843621399176,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8305.412999999988,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 23.918000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3949.575,
      "heapDeltaBytes": 10518744,
      "heapUsedBytes": 84314196,
      "domNodes": 0,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 1972.805,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666064257028115,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12025.60299999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11152.063999999998,
      "heapDeltaBytes": -28227072,
      "heapUsedBytes": 186943204,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7688192,
      "scriptDurationMs": 161.29,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.5339590443686,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12560.592000000042,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11974.659,
      "heapDeltaBytes": -36289408,
      "heapUsedBytes": 185031200,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8998912,
      "scriptDurationMs": 181.508,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.497255574614066,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14623.671000000002,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 9.425000000000017,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14193.166000000001,
      "heapDeltaBytes": -30105780,
      "heapUsedBytes": 185868564,
      "domNodes": -3046,
      "jsHeapTotalBytes": 3428352,
      "scriptDurationMs": 669.3670000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 50,
      "frameDurationMs": 26.587114337568053,
      "p95FrameDurationMs": 50.099999999998545
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14974.59200000003,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 10.229000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14560.233,
      "heapDeltaBytes": -25774744,
      "heapUsedBytes": 187569912,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6836224,
      "scriptDurationMs": 644.1309999999999,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 27.153887884267633,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4527.254000000028,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 46.038999999999994,
      "layouts": 20,
      "layoutDurationMs": 22.836999999999996,
      "taskDurationMs": 4393.487,
      "heapDeltaBytes": 1168668,
      "heapUsedBytes": 225508208,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 73.43100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.373595505617978,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4506.907000000069,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.58000000000001,
      "layouts": 20,
      "layoutDurationMs": 24.02,
      "taskDurationMs": 4373.911,
      "heapDeltaBytes": -591776,
      "heapUsedBytes": 217400608,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 73.689,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 25.422598870056493,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6374.588000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5952.098999999998,
      "heapDeltaBytes": -27790864,
      "heapUsedBytes": 184531232,
      "domNodes": -3046,
      "jsHeapTotalBytes": 8527872,
      "scriptDurationMs": 86.26699999999998,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.2923076923077,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6368.64700000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5934.3330000000005,
      "heapDeltaBytes": -25831440,
      "heapUsedBytes": 190564120,
      "domNodes": -3046,
      "jsHeapTotalBytes": 16535552,
      "scriptDurationMs": 90.783,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.29264214046822,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.6709999999857,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 13.432999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.63,
      "taskDurationMs": 99.03799999999998,
      "heapDeltaBytes": 6487340,
      "heapUsedBytes": 61081796,
      "domNodes": 135,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 71.5340000000424,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 9.176,
      "layouts": 3,
      "layoutDurationMs": 1.3559999999999999,
      "taskDurationMs": 54.321000000000005,
      "heapDeltaBytes": 4036520,
      "heapUsedBytes": 62593920,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.748,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 352.31800000008207,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 59.826,
      "layouts": 76,
      "layoutDurationMs": 17.317,
      "taskDurationMs": 328.639,
      "heapDeltaBytes": 12627564,
      "heapUsedBytes": 84241592,
      "domNodes": 76,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 107.065,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668181818181832,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 327.474000000052,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 58.636,
      "layouts": 76,
      "layoutDurationMs": 15.417,
      "taskDurationMs": 291.406,
      "heapDeltaBytes": 12521504,
      "heapUsedBytes": 84393188,
      "domNodes": 76,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 92.619,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66500000000001,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 721.8030000000226,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 194.541,
      "layouts": 76,
      "layoutDurationMs": 23.529999999999998,
      "taskDurationMs": 678.015,
      "heapDeltaBytes": 5164332,
      "heapUsedBytes": 111184336,
      "domNodes": 76,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 166.28500000000003,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665909090909096,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 747.2420000000284,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 197.31699999999998,
      "layouts": 76,
      "layoutDurationMs": 25.604,
      "taskDurationMs": 708.57,
      "heapDeltaBytes": -16583508,
      "heapUsedBytes": 109125680,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 172.803,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 54556 84238 64.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.8% 1167
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.8% 369
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 79.0% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 39.3% 258
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

🎭 Playwright: ✅ 2235 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2213 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/16/2026, 05:00:12 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 091f18c8b1a1793e992216a87a11104ad1f2b9fe

Full docs: ADR-DEVEX-LINT-0015

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-20640.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-dklwej8iv-comfyui.vercel.app

Last updated: 2026-10-16T17:00:11Z for a2bbfb4

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.15385% with 1200 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ebsite/src/components/cms/editor/ContentEditor.vue 0.00% 63 Missing ⚠️
apps/website/src/components/cms/DraftQueue.vue 0.00% 58 Missing ⚠️
apps/website/src/components/cms/PreviewBar.vue 0.00% 57 Missing ⚠️
apps/website/src/components/cms/ContentList.vue 0.00% 49 Missing ⚠️
...ebsite/src/components/cms/editor/EditorDetails.vue 0.00% 47 Missing ⚠️
...bsite/src/components/cms/editor/EditorExamples.vue 0.00% 44 Missing ⚠️
...bsite/src/components/cms/editor/EditorVersions.vue 0.00% 41 Missing ⚠️
.../website/src/components/cms/editor/MediaPicker.vue 0.00% 39 Missing ⚠️
apps/website/src/lib/cms/mock-ingest.ts 72.22% 18 Missing and 17 partials ⚠️
...ps/website/src/components/cms/UndoChangeButton.vue 0.00% 32 Missing ⚠️
... and 70 more

❌ Your patch check has failed because the patch coverage (26.15%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@                       Coverage Diff                        @@
##             feat/website-cms-test-preview   #20640   +/-   ##
================================================================
  Coverage                                 ?   84.85%           
================================================================
  Files                                    ?     3617           
  Lines                                    ?   171425           
  Branches                                 ?    45058           
================================================================
  Hits                                     ?   145457           
  Misses                                   ?    23873           
  Partials                                 ?     2095           
Flag Coverage Δ
billing-web-unit 92.23% <ø> (?)
e2e 64.72% <ø> (?)
unit 83.61% <ø> (?)
website-unit 76.79% <26.15%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...te/src/components/common/HeaderMain/HeaderMain.vue 89.47% <ø> (ø)
apps/website/src/config/models-page-data.ts 92.85% <100.00%> (ø)
apps/website/src/lib/cms/admin.ts 88.33% <100.00%> (ø)
apps/website/src/lib/cms/catalog.ts 67.85% <100.00%> (ø)
apps/website/src/lib/cms/cms-enabled.ts 100.00% <100.00%> (ø)
apps/website/src/lib/cms/diff.ts 96.55% <ø> (ø)
apps/website/src/lib/cms/stage-client.ts 100.00% <100.00%> (ø)
apps/website/src/lib/cms/stats.ts 100.00% <100.00%> (ø)
packages/ingest-types/src/zod.gen.ts 100.00% <ø> (ø)
apps/website/src/components/cms/ui/adminButton.ts 0.00% <0.00%> (ø)
... and 79 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

claude added 6 commits October 9, 2026 13:38
…in a new tab

Also split the middleware so the demo error wrapper stays small.
Replaces the middleware wrapper; the demo build alone injects /500.
On Vercel the function failed to import ScrollToPlugin by name from gsap's
ESM files, which sit in a package Node reads as CommonJS.
One person publishing in the shared demo emptied the Draft for everyone
else on that function instance. Each sign-in now gets its own credential
and its own in-memory catalog.

Copy link
Copy Markdown
Contributor Author

playwright-tests-cloud-sharded (2, 4) is red on 1d70a0c. The failing test is browser_tests/tests/cloudSsoSignIn.spec.ts › "an SSO email navigates to ingest SSO start with its email and return path". The network-isolation fixture blocked a request during that test.

This doesn't come from this PR. The diff only touches apps/website/, the website preview workflow, an ADR, and an automated reformat of packages/ingest-types/src/zod.gen.ts (formatting only, no behaviour change). Nothing touches the app under src/ or browser_tests/. The same shard's other test, agentReplyDrafts, is marked flaky in the same run.

There's no fix to port yet. I'll re-run the failed job once when the run finishes.


Generated by Claude Code

@datadog-official

This comment has been minimized.

claude added 5 commits October 9, 2026 15:26
Live is now a preview view instead of leaving preview, so the bar stays
until Exit preview. The bar stacks above the sticky header, which docks
below it. The admin sidebar title gets the Comfy mark.
…w flow

The preview bar only shows on the site, not in the admin. Preview draft
opens the list of changed pages on arrival and is hidden when the draft
is empty. The bar counts page changes, which is what the preview shows,
and says workflow submissions are checked in Comfy Cloud. Sheets cover
the bar again, and the reject note no longer mentions the review API.
…lk review

From the workshop standup review of the admin design:

- Content editor at /admin/edit/{uid}: name, summary, credit and tags in
  English and Chinese, cover, examples with prompts, each input's default
  and whether it is basic, advanced or hidden, visibility and schedule.
  Saving puts the item in the draft through the site API's item endpoint,
  after checking it against the schemas the website renders from.
- Add content starts from a copy of an existing item; archive and restore
  are saves with the deleted flag. All content lists new and archived
  items and links each row to its editor.
- Publish history can restore any earlier publish, not only the previous.
- The Draft queue includes, leaves out or rejects everything a filter or
  search shows.
- The preview bar links back to the admin and to the editor of the page
  in view, and in Draft labels the cards and links the draft changes.
- The demo mock saves items, archives, and restores real LIVE snapshots.
@mariana953 mariana953 changed the title feat(website): Hub admin redesign with a shareable demo preview feat(website): Hub admin redesign, content editor and a shareable demo preview Oct 9, 2026
…parts

Keeps each template and function within the complexity limits: the
editor's header, details, cover and publishing panel are their own
components, parameter rows render separately, history moves to its own
Astro component, and the publish, revert and reject actions and the mock
save are split into single-purpose functions.
The cover and each example take an uploaded image or video as well as a
link. Until the site API has file storage, only the demo accepts uploads
and keeps them inline, up to 3 MB; elsewhere the button explains why it
is off.

Draft items now go through the checks a reviewer makes before
publishing: the page builds, and it has a name, a description, a cover
and, for models, examples. Gaps show on the row, in the review panel and
in the publish confirmation, and never block publishing. The demo's new
sample model is left incomplete to show them.
Draft opens with the same layout as All content: tabs on the left with
their underline, type and search on the right, and one table whose header
box ticks every row shown. Publish moves to the page header next to View
draft on site.

Copy link
Copy Markdown
Contributor Author

Two app e2e checks are red on ff262a4. Neither failure comes from this PR, which only changes the apps/website admin UI:

  • playwright-tests-chromium-sharded (11, 16): sidebar/sidebarSplitterWidth.spec.ts "persists both side panels…" timed out in reloadAndWaitForApp ("app never became ready"). This shard passed on the previous head, c18a317.
  • playwright-tests-cloud-sharded (2, 4): cloudSsoSignIn.spec.ts fails with route.continue: Route is already handled! in networkIsolationFixture. This is the same cloud SSO failure as on earlier heads, and it passed on c18a317.

I don't know of an existing fix to port for either one, so I'm re-running the failed jobs once.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

Follow-up: I re-ran playwright-tests-cloud-sharded (2, 4) on ff262a4 and it failed again with the same error, route.continue: Route is already handled!, in cloudSsoSignIn.spec.ts "an SSO email navigates to ingest SSO start…".

The sidebar shard is on the same re-run, and I'll report back if it fails again.


Generated by Claude Code

The review panel footer can take any change out of the draft: Discard
changes for an edit, Delete for a page that isn't live yet, and Delete for
a submitted workflow, which replaces the old Reject. See it on the page
now opens a page that exists: a change that turns the page off opens the
live page, and a scheduled one opens the draft at its start date.
benjcooley added a commit that referenced this pull request Oct 15, 2026
Brings in Mar's admin shell, Draft table/tabs/filters, review drawer,
final-review popup, content list/history components and editor controls,
wired to the real catalog API instead of the sample-data ingest.

Kept from the CCC integration:
- checked-only publication (unchecked changes stay in the next Draft;
  checked tombstones publish as removals), trash discards a Draft change
- server-confirmed final candidate; stale Draft is rejected
- verified media uploads and protected Draft media previews
- graph/API workflow pairs, author picker, Delete/Undelete

Mar's sample-data login stays opt-in (SITE_CATALOG_DEMO=1) and is
disabled on Vercel production.

@MaanilVerma MaanilVerma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These notes come from a review for the legacy workflow migration (Hub workflows and app templates into the CCC). Nothing here affects production today, because the static build output with SITE_CATALOG_API_URL unset keeps the same file list, sitemap, robots and llms files. Some comments name lines from the base branch feat/website-cms-test-preview. I anchored them on the closest line that this PR changes.

  • problem: This branch conflicts with main in 8 files (BaseLayout.astro, catalogue.json.test.ts, docs/adr/README.md, three ingest-types files, pnpm-lock.yaml, pnpm-workspace.yaml) and with #20933 in 12 files (git merge-tree).
  • question: This PR and #20933 add two preview UIs with opposite LIVE-banner rules: ADR-0039 keeps the banner in Draft and LIVE, and ADR-0044 shows no banner in LIVE. Which ADR is the decision?

kind: z.enum(['MODEL', 'WORKFLOW', 'APP']),
slug: z
.string()
.regex(/^\/hub\/(models|workflows|apps)\/[a-z0-9]+(?:-[a-z0-9]+)*$/),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem: The admin writes target a different backend contract than the CCC stack in cloud #13026, #13028 and #13030. This schema requires slugs like /hub/workflows/x and visibility PUBLIC, the website mints the UID for a new item (index.astro:36), putItem sends no Idempotency-Key, and publish sends approved_uids. The Go store rejects each one, because its slug pattern is ^[a-z0-9]+(?:-[a-z0-9]+)*$, visibility is public or staff, a create with a given UID returns sql: no rows in result set, and publish requires a review-bound selection digest. Receipt: the Go schema probe and TestArchitectProbeClientMintedUID on cloud 2ee380f7b0. Can you align savedRecordSchema, putItem and publishCommand with the cloud contract, or tell us which backend this PR targets?

Context for agents
  • Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
  • Location: apps/website/src/lib/cms/save-item.ts:10-20 (savedRecordSchema), :54-77 (putItem); apps/website/src/routes/admin/actions.ts:60-80 (publishCommand); apps/website/src/routes/admin/index.astro:36
  • Defect: The CCC store in the cloud stack rejects every create, save and publish from this console.
  • Reproduce: On cloud 2ee380f7b0, ccc.Validate on a workflow with "slug":"/hub/workflows/x" returns $.slug: string doesn't match the regular expression "^[a-z0-9]+(?:-[a-z0-9]+)*$", with "visibility":"PUBLIC" returns value is not one of the allowed values ["public","staff"], and with data.formLayout returns property "formLayout" is unsupported. s.Save(ctx, actor, Edit{ExpectedDraft: st.Draft, UID: uuid.NewString(), Type: "workflow", ...}) returns sql: no rows in result set.
  • Expected vs actual: The console payloads validate against the CCC store / each one is rejected.
  • Fix direction: Decide the contract first. If the target is the CCC stack: send slug without the /hub/<kind>/ prefix, lowercase visibility, omit uid on create and read it from the response, send an Idempotency-Key header per action, and publish with the ReviewCheckedPublication digest (expected_selection_digest + selected_uids).
  • Test to add: save-item.test.ts: assert the PUT body for a new item has no uid, has slug: "x" and visibility: "public", and the request has an Idempotency-Key header.
  • Related: apps/website/src/lib/cms/admin.ts:31-38, apps/website/src/lib/cms/mock-ingest.ts (mock contract), packages/ingest-types (base branch types).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changing this here. This PR is the admin's UX pass. The data seam (save-item.ts, actions.ts, mock-ingest.ts) follows the contract of the base branch feat/website-cms-test-preview, and which backend it targets is @benjcooley's call as owner of that branch and the integration. Once that's decided, aligning savedRecordSchema, putItem and publishCommand is contained to those modules, as the PR body's wiring table lists.


Generated by Claude Code

return new Response('Invalid submission', { status: 400 })
return {
commands: [
...approvals,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem: publishCommand sends the legacy submission approvals first and the catalog publish last, and runCommands stops at the first error. If the catalog publish returns 409 (any save after the final review), the submissions stay approved on the live legacy Hub without the catalog change. A retry then sends the approvals again, which return 409 because the status is already set, so the retry stops before the publish. The mock publish never returns 409 (mock-ingest.ts:228-252), so the tests do not cover this path. Receipt (not tested at runtime): actions.ts:60-79,141-161 and contentcatalog/review.go:90-97 on cloud feat/hub-cms-test-preview, which returns 409 for a status that is already set. Can you send the catalog publish first and approve the submissions only after it succeeds, or move both writes into one backend endpoint?

Context for agents
  • Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
  • Location: apps/website/src/routes/admin/actions.ts:60-80 (function publishCommand), :141-162 (function runCommands)
  • Defect: A non-atomic two-store publish can leave legacy approvals applied without the catalog publish, and a retry cannot recover.
  • Reproduce: With a backend that returns 409 for /admin/api/site/publish: POST action=publish, confirm=yes, one approve=<share>:<version> and one approve_item=<uid>. The approval POST returns 200, the publish returns 409. POST the same form again: the approval returns 409, and the publish is not sent.
  • Expected vs actual: Both writes apply, or neither / the approval applies alone, and the retry stops at the approval.
  • Fix direction: Move the approvals into the backend publish call (one transaction), or reorder: publish first, then approvals, and treat a 409 "already approved" on approval as success.
  • Test to add: actions.test.ts: mock publish to return 409, assert that no approval request was sent (or that a retry after the 409 reaches the publish).
  • Related: apps/website/src/lib/cms/mock-ingest.ts:228-252 (add a 409 path to the mock).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6388c94. publishCommand now sends the catalog publish first and the submission approvals after it, so a 409 on publish approves nothing. An approval that answers 409 counts as already applied, so a retry after a partial run gets through. actions.test.ts covers the order, the refused publish (no approval sent) and the already-approved case.


Generated by Claude Code

if (session.preview?.now) url.searchParams.set('now', session.preview.now)
}
const response = await fetch(url, {
const response = await catalogFetch(url, {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem: loadSiteCatalog parses all items with one z.array(modelSchema) and one z.array(detailSchema) (lines 44-55, from the base branch), and it applies modelSchema to workflow items too. Thus one Draft or Live item that does not match makes every /hub page return 503, also the pages of valid items. Receipt: at 83744da58f, line 54 returns { ok: false, status: 503 } when !models.success || !details.success. Can you parse each item on its own with the schema for its kind, drop the bad ones and render the rest?

Context for agents
  • Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
  • Location: apps/website/src/lib/cms/catalog.ts:44-55 (function loadSiteCatalog, base branch feat/website-cms-test-preview). Anchored on line 28, the closest line this PR changes.
  • Defect: An all-or-nothing array parse turns one invalid item into a site-wide 503.
  • Reproduce: In a vitest for loadSiteCatalog, stub catalogFetch to return a valid projection with two model items, then make one item's data miss a required modelSchema field.
  • Expected vs actual: The valid item renders and the bad one is dropped / { ok: false, status: 503 }.
  • Fix direction: Map over projection.data.items, safeParse each item.data with modelSchema (for MODEL) or the workflow and app schema, keep the successes and report the failures. Return 503 only when the projection itself does not parse.
  • Test to add: catalog.test.ts: with one bad item among two, loadSiteCatalog() returns ok: true with one model.
  • Related: apps/website/src/lib/cms/catalog-contract.ts (normalizeProjection).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6388c94. loadSiteCatalog now safeParses each item on its own (modelSchema for every item, detailSchema for non-APP items) and drops the failures. It returns 503 only when the projection itself fails to parse. catalog.test.ts covers one broken model among valid ones: ok: true, and the broken one is absent.


Generated by Claude Code

Comment thread apps/website/src/lib/cms/catalog.ts Outdated
import { catalogFetch } from './demo'

// Server-only configuration. Browser islands read same-origin JSON endpoints.
export const cmsEnabled = () => Boolean(process.env.SITE_CATALOG_API_URL)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem: cmsEnabled returns true whenever SITE_CATALOG_API_URL is set, and that enables SSR for /hub, but loadSiteCatalog (line 15) returns 503 when VERCEL_ENV === 'production'. Thus if someone sets SITE_CATALOG_API_URL in the production Vercel project, every /hub page returns 503 with X-Robots-Tag: noindex. Both lines come from the base branch feat/website-cms-test-preview. Receipt: a vitest probe with both variables set gets status 503 from loadSiteCatalog. Can you make cmsEnabled return false in production, so that production keeps the static pages?

Context for agents
  • Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
  • Location: apps/website/src/lib/cms/catalog.ts:11 (cmsEnabled) and :15 (loadSiteCatalog), base branch feat/website-cms-test-preview
  • Defect: The SSR switch and the production guard disagree, so one env var in production replaces the static /hub pages with 503 responses.
  • Reproduce: In a vitest: vi.stubEnv('SITE_CATALOG_API_URL', 'https://example.test'), vi.stubEnv('VERCEL_ENV', 'production'), then cmsEnabled() returns true and await loadSiteCatalog() returns { ok: false, status: 503 }.
  • Expected vs actual: cmsEnabled() is false in production / true, and every /hub request returns catalogUnavailable() (503, noindex).
  • Fix direction: export const cmsEnabled = () => Boolean(process.env.SITE_CATALOG_API_URL) && process.env.VERCEL_ENV !== 'production', and remove the duplicate guard in loadSiteCatalog.
  • Test to add: catalog.test.ts: with both variables stubbed, cmsEnabled() returns false.
  • Related: apps/website/astro.config.ts and apps/website/src/middleware.ts (callers of cmsEnabled).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6388c94. cmsEnabled() is now false when VERCEL_ENV === 'production', and loadSiteCatalog and the middleware's cms switch both go through it, so the guard lives in one place. catalog.test.ts asserts cmsEnabled() is false with both variables set. (astro.config.ts still keys the adapter off the variable at build time. That doesn't matter for this case, because every route now falls back to the static data.)


Generated by Claude Code

if (session.preview?.now) url.searchParams.set('now', session.preview.now)
}
const response = await fetch(url, {
const response = await catalogFetch(url, {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem: Each SSR request fetches the full catalog projection with cache: 'no-store' and parses it three times with zod. The demo catalog of 180 items is 3.83 MB and took 2.53 s through ngrok, which is half of the 5 s timeout on line 32 that returns 503. At the import size of about 1,600 items, the response is about 34 MB for each page view. Receipt: items-live.json from the demo backend is 3,827,899 bytes for 180 items. Can you cache the projection per Live revision, or fetch only the items that the page renders?

Context for agents
  • Repo / PR / head: Comfy-Org/ComfyUI_frontend feat(website): Hub admin redesign, content editor and a shareable demo preview #20640 @ 83744da
  • Location: apps/website/src/lib/cms/catalog.ts:13-62 (function loadSiteCatalog), base branch code that this PR edits on line 28
  • Defect: Every SSR page view downloads and parses the whole catalog, so latency and size grow linearly with the catalog.
  • Reproduce: Point SITE_CATALOG_API_URL at the demo backend and request any /hub page twice: each request fetches /api/v1/catalog/items in full (3.83 MB for 180 items, 2.53 s via ngrok).
  • Expected vs actual: One fetch per Live revision (or per item) / one full fetch per request.
  • Fix direction: Keep a module-level cache keyed by live_rev with a short TTL (for example 30 s) for the public path, and add a by-slug endpoint for detail pages. Keep no-store only for the staff preview session path.
  • Test to add: catalog.test.ts: two loadSiteCatalog() calls without a session within the TTL call catalogFetch once.
  • Related: apps/website/src/lib/cms/demo.ts (catalogFetch).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is needed before real catalog sizes, but it belongs with the backend integration on the base branch (a by-slug endpoint and a live_rev-keyed cache both depend on the API shape), so I'm leaving it to @benjcooley rather than widening this UX PR.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

@MaanilVerma, on the two review-level points:


Generated by Claude Code

@benjcooley
benjcooley marked this pull request as ready for review October 16, 2026 06:43
…figured

cmsRendering() turned off prerendering on every /hub route whenever
SITE_CATALOG_API_URL was set, but cmsEnabled() refuses the CMS in
production. Production then had neither prerendered pages nor a catalog,
so every detail page returned 404. Both now use cmsEnabled(), moved to a
dependency-free module so the integration can import it at config load.
…rashing the Hub

formForWorkflow throws when a workflow's inputs and inputSchema disagree.
safeParse does not catch a throw inside a transform, so one bad workflow
broke loadSiteCatalog for every Hub page. The transform now reports a
schema issue instead. loadSiteCatalog also drops an item that fails
either schema from the projection, so its page returns 404 rather than
being found and failing to render.
benjcooley added a commit that referenced this pull request Oct 16, 2026
Ports the remaining change from Mar's #20640 head (6388c94, by way of
a2bbfb4) into the integration branch. The legacy admin publish now
sends the catalog publication first, so a refused publish approves
nothing on the Hub, and a retry treats a 409 on a re-sent approval as
already applied. This handler stays restricted to the sample-data demo.

The other two commits on that head (production-static gate and dropping
unreadable CMS items) already exist here in adapted form.
@benjcooley

Copy link
Copy Markdown
Collaborator

Hi Mar! #21204 now carries this PR forward. It keeps your admin layout (Draft table, tabs/filters, review drawer, final-review popup, editor, content/history views), wired to the real catalog API instead of the sample-data ingest, and includes this PR up to its current head a2bbfb4458. It also merges #20933, so there's one preview implementation and one banner rule (ADR WEBSITE-CMS-0039, "Integrated replacement"). I haven't closed this PR; that's up to you and Ben. Review on #21204 is very welcome.

benjcooley added a commit that referenced this pull request Oct 19, 2026
Ports the remaining change from Mar's #20640 head (6388c94, by way of
a2bbfb4) into the integration branch. The legacy admin publish now
sends the catalog publication first, so a refused publish approves
nothing on the Hub, and a retry treats a 409 on a re-sent approval as
already applied. This handler stays restricted to the sample-data demo.

The other two commits on that head (production-static gate and dropping
unreadable CMS items) already exist here in adapted form.

This branch was previously deployed

1 inactive deployment
website-approval — a2bbfb44 Deployed Oct 16, 2026 by MaanilVerma via fast-lane #5756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cms-demo risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants