Skip to content

test(website): check the long description, FAQ and models in workflow server HTML - #21550

Closed
MaanilVerma wants to merge 7 commits into
work/ccc-mar-integration-20261014from
maanil/ccc-workflow-ssr-body
Closed

MaanilVerma wants to merge 7 commits into
work/ccc-mar-integration-20261014from
maanil/ccc-workflow-ssr-body

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The catalog detail audit now proves that the server HTML of a CCC workflow page contains its long description, its FAQ and its model list, each in its own section. Before this PR, the SSR test used only seed records, and seed records have no long description and no FAQ. Thus nothing proved that this content reaches search engines and AI crawlers.

The page body was already in the server HTML, because Astro server-renders the client:load island of CatalogDetailPage. On a runnable workflow, the model list sits in a hidden tab panel. withoutHiddenMarkup counts hidden-tab content as present. Visitors see no change. The only runtime change is a data-testid="model-about" attribute on the About section of LocalModelPage.vue.

Changes

  • auditCatalogDetailBody in scripts/models-html-audit.ts now reports a page whose server HTML does not contain each paragraph of catalogDetails.longDescription, each FAQ question and answer, or each model name.
  • Each check reads only the text of its own section. The long description must be in the About section (aria-labelledby="workflow-about-heading" or data-testid="model-about"), the FAQ in #workflow-faq or #model-faq, and the models in data-testid="workflow-runs-on".
  • elementWith finds the element that holds a section marker by counting nested tags of the same name. It returns no text when the close tag is missing, so a section that does not close gives a report.
  • The model list check runs only for a record with a workflowId. A workflow without catalogDetails takes its model list from workflow.template.models, so the seed records get the model check too.
  • The FAQ answer check uses faqAnswerPlainText from @/utils/faqAnswer, so an inline link inside an answer does not cause a false report.
  • The audit compares the authored text with only its whitespace removed. Thus authored text such as <lora:detail:0.8> or 1 < 2 & 3 > 2 matches its escaped form in the HTML. The summary check now uses the same rule.
  • bodyErrors calls one function for each section: descriptionErrors, faqErrors and modelErrors.
  • LocalModelPage.vue adds data-testid="model-about" to its About section, so the audit can find it.
  • catalog-detail-ssr.test.ts now server-renders three CCC workflow records and runs the audit on them: one with a Run form, one without, and one with only a long description.

QA Focus

  • Run pnpm exec vitest run scripts/models-html-audit.test.ts in apps/website. Expected: 36 tests pass. Author: tested at 7310c18316, 36 pass. Before the first audit change, 5 of the first 28 tests did not pass (red).
  • Run pnpm exec vitest run scripts/models-html-audit.test.ts src/routes/models/catalog-detail-ssr.test.ts in apps/website. Expected: all tests pass. Author: tested at df8ff9cda7, 227 pass (with 34 audit tests at that commit). Not run together again after 7310c18316 added two audit tests.
  • In faqErrors, remove !inFaq(question) || and run the audit tests. Expected: the case rejects a workflow body without an FAQ question does not pass. Author: tested, 1 failed | 33 passed.
  • Change textWithin back to whole-page text and run the audit tests. Expected: the out-of-section cases do not pass. Author: tested, 4 failed | 30 passed.
  • Set the model marker back to workflow-facts and run the audit tests. Expected: the case the model in its runs-on list does not pass. Author: tested, 2 failed | 34 passed.
  • Make elementWith return rest when the close tag is missing and run the audit tests. Expected: the case a closed FAQ section does not pass. Author: tested, 1 failed | 35 passed.
  • Remove the workflowId gate in workflowModelNames and run the audit tests. Expected: the case checks the body of a model record without a model list does not pass. Author: tested, 1 failed | 33 passed.
  • Put either removed textOf call back on the record side and run the audit tests. Expected: the case keeps authored angle brackets and ampersands as text does not pass. Author: tested, 1 failed | 33 passed. The red commit is 9e048b4371.
  • Make the FAQ in WorkflowPage.vue not render (v-if="false") and run the SSR test again. Expected: both CCC workflow cases that have an FAQ report the missing FAQ. Author: tested in the first review round, both cases did not pass with "server HTML is missing the FAQ". I restored the file after the run.
  • Make the long description in WorkflowPage.vue not render (v-if="false" on the about section) and run the CCC workflow cases again. Expected: all three cases report the missing long description. Author: tested in the first review round, 3 of 3 did not pass with "server HTML is missing the long description". I restored the file after the run.
  • Run curl on a CMS workflow page of the preview with JavaScript off. Expected: the h1, the summary, the long description, the FAQ and the model names are in the HTML. Author: not tested, because the preview reads seed data, and seed records have no long description and no FAQ.
  • Run catalog-detail-ssr.test.ts at the default 5 s timeout. Expected: all tests pass in CI. Author: on this busy machine, the first test timed out on the base branch and on this branch, so the CI run decides it.

Risky areas

  • scripts/models-html-audit.ts is also used by scripts/check-models-html.ts and scripts/models-gallery-audit.ts. A model record with catalogDetails now gets the long description and FAQ checks in data-testid="model-about" and #model-faq. A model record gets no model list check, because it has no workflowId.
  • The section checks depend on the markers aria-labelledby="workflow-about-heading", data-testid="model-about", #workflow-faq, #model-faq and data-testid="workflow-runs-on". If a later change renames one of them, the audit reports missing content for every CCC page.
  • For a runnable workflow, the model list is only in the Workflow tab panel, which the server renders with display:none. The audit accepts this, because the text is in the HTML. Google can give lower weight to text in a hidden tab. A visible model list is a UI change and is not in this PR.

PR dependency map

  1. main (base)
  2. feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204 feat(website): Comfy Content Catalog Hub CMS (supersedes feat(website): Hub admin redesign, content editor and a shareable demo preview #20640, feat(website): stage CCC admin and Preview primitives #20933) (open, targets main)
  3. test(website): check the long description, FAQ and models in workflow server HTML #21550 test(website): check the long description, FAQ and models in workflow server HTML (open, targets feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204) (this PR)
  4. feat(website): give CCC workflow pages their own structured data and meta #21551 feat(website): give CCC workflow pages their own structured data and meta (open, targets test(website): check the long description, FAQ and models in workflow server HTML #21550)

Merge #21204 before this PR. #21551 merges after it.

… server HTML

The catalog detail audit now reports a workflow page whose server HTML does
not contain its long description, each FAQ question and answer, or its model
list. The SSR test runs the audit on two CCC workflow records, one with a Run
form and one without.
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since cfcff3a504815861c835bdb52cee50ca1d0f9d6a

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (132)

  • billing path matches no source files: src/components/dialog/content/credit/**. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 82 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21550.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-6284ts948-comfyui.vercel.app

Last updated: 2026-10-21T16:53:19Z for cb22522

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 21, 2026
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a59ca866-ed77-48e5-81fb-d22c816464e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@datadog-official

This comment has been minimized.

@MaanilVerma
MaanilVerma marked this pull request as ready for review October 22, 2026 02:36

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: no blockers. A few audit-accuracy gaps.

The approach is sound: the paragraph split, the FAQ flattening and the model-list selection all match WorkflowPage.vue, FAQSplit01.vue and WorkflowFacts.vue. Blank FAQs are dropped upstream in faqDetails(). Vitest config auto-restores the env and fetch stubs, so nothing leaks.

The main issue: the audit treats authored record text as HTML. Text that looks like a tag is dropped from the expected value, so a long description that contains ComfyUI prompt syntax falsely fails (inline). The audit also matches substrings across the whole page, so some checks are weaker than they look.

Note: auditCatalogDetailBody has no caller outside the vitest SSR tests. check-models-html.ts does not use it, so this guards fixtures and not the built dist. That is fine for this PR, but don't read it as a production audit.

Severity Count
BLOCKER 0
SHOULD FIX 3
TRIVIAL 2

Tested: scripts/models-html-audit.test.ts passes 28/28 on a copy of the branch. Mutation testing was done on that copy, not on the branch. The SSR test was not run locally because of a missing dependency.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review: no fixes yet

The only new commit is ac5ec67f23, a merge from work/ccc-mar-integration-20261014. The three PR files are byte-identical to cb22522837, so none of the five round-1 threads are addressed. All five are still open:

Thread Severity Status
has() passes authored text through textOf, which strips <…> (false "missing" on <lora:…> prompt syntax) SHOULD FIX open
whole-page substring matching (SD/Flux pass from the h1 or summary) SHOULD FIX open
no test drops the FAQ question (the mutation survives) SHOULD FIX open
faqAnswerText duplicates faqAnswerPlainText TRIVIAL open
MODEL records with catalogDetails.models false-fail (latent) TRIVIAL open

The merge brought in a FAQSplit01.vue change (optional faq.link), which I checked. The audit's FAQ input comes from faqDetails() and never sets link, so the audit is unaffected.

CI note: website-unit failed on cb22522837 only because of src/styles/catalog-styles.test.ts, which is unrelated. This PR's audit and SSR tests passed at the default timeout, which answers your open QA item about the 5 s timeout.

Severity Open
BLOCKER 0
SHOULD FIX 3
TRIVIAL 2

The first SHOULD FIX has a one-line committable suggestion on its thread. Please push fixes or reply on each thread before I approve.

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                          Coverage Diff                          @@
##           work/ccc-mar-integration-20261014   #21550      +/-   ##
=====================================================================
- Coverage                              86.45%   86.34%   -0.11%     
=====================================================================
  Files                                   4030     3924     -106     
  Lines                                 184642   181388    -3254     
  Branches                               50825    49716    -1109     
=====================================================================
- Hits                                  159627   156622    -3005     
+ Misses                                 22316    22216     -100     
+ Partials                                2699     2550     -149     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.75% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...website/src/components/workshop/LocalModelPage.vue 71.42% <ø> (ø)

... and 122 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review (round 3): approve

I checked the five round-1 threads against 9e048b4371, df8ff9cda7 and 7d0fd565d9. All five are fixed, and I resolved them.

  • Authored text is matched as-is. The <lora:…>, <b>, & and </> cases pass, and the summary check got the same fix.
  • Section scoping. All five markers exist in the real components (WorkflowPage.vue:183,210, WorkflowFacts.vue:97, LocalModelPage.vue:55,75) and are the first occurrence of their string. A renamed marker gives an empty section, so the check fails loudly.
  • The workflowId gate is correct. workflowId is required on workflow records (models-catalogue-data.ts:51). CCC records set it (catalog-presentation.ts:488), and CatalogDetailPage.vue:85 uses the same field to pick WorkflowPage. So the model check still runs in the real SSR tests, and all 30 seed workflows have template.models.
  • The FAQ-question test exists. The faqAnswerPlainText reuse is in.

Verification: the unit audit tests pass 34/34 locally. Mutation probes on the new code were all caught: depth tracking, whole-page scope, the workflowId gate, the FAQ ||, the summary <> handling and the model scope. CI is green on 7d0fd565d9, with 55 checks passing.

Two inline TRIVIAL notes, neither blocking. Two optional test gaps:

  • No case puts About or FAQ text after its section's close tag. The facts case covers the shared elementWith close logic.
  • No SSR case renders a local MODEL record with catalogDetails, so model-about and model-faq are checked only against fixtures.
Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 2 inline + 2 optional

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review (round 4): approve

7310c18316 fixes both TRIVIAL notes from round 3, and I resolved both threads.

  • The model check now reads data-testid="workflow-runs-on". That marker exists once, in WorkflowModelLinks.vue:16, which WorkflowFacts renders once. The new author row Flux Kontext Fan makes the runs-on case a real test: with the old workflow-facts marker, 2 cases fail.
  • elementWith returns '' when the section is never closed. I traced the new unclosed-FAQ case: the depth goes 1 → 2 → 1 through the runs-on <section> and never reaches 0, so it hits the new branch. With return rest restored, it fails.

Verification: the unit audit tests pass 36/36 locally. Every mutation of the two changed lines is caught. website-unit and typecheck were still pending when I submitted.

Optional nit: the case the model in its facts block now really means outside its runs-on list.

Severity Count
BLOCKER 0
SHOULD FIX 0
TRIVIAL 1 (optional)

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Moved to Comfy-Org/comfy-website#25 (the website now lives there). This PR stays open for its review history.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Closing: the website moved; this change lives in Comfy-Org/comfy-website#25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants