Skip to content

feat(website): make the hub workflow and app lists indexable - #21559

Closed
MaanilVerma wants to merge 11 commits into
work/ccc-mar-integration-20261014from
maanil/ccc-hub-lists-indexable
Closed

MaanilVerma wants to merge 11 commits into
work/ccc-mar-integration-20261014from
maanil/ccc-hub-lists-indexable

Conversation

@MaanilVerma

@MaanilVerma MaanilVerma commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

/hub/workflows/ and /hub/apps/ can now rank in search once the CCC list serves them. In CMS mode each list is indexable, has a localized title, description and H1, shows a short intro paragraph and emits a CollectionPage. The CollectionPage has an ItemList of the listed records whose own page is indexable, so the list stays empty until the detail pages launch (SEO3). The static production list keeps noindex. This is plan item SEO4 and ships with the CCC cutover.

Changes

Indexing:

  • isIndexableModelPage() in config/indexing.ts now returns cmsEnabled() for the two list pages (section kind). In CMS mode they get no robots noindex and are in the sitemap. Without CMS they keep noindex and stay out of the sitemap, as on the base.
  • The new isIndexableHubList() strips the catalog locale prefix before the check, and hub-section.astro uses it for its robots rule. Thus /zh-CN/hub/workflows/ and /ja/hub/apps/ follow the English rule.

Routes whose indexing changes, in CMS mode only: /hub/workflows/, /hub/apps/, /zh-CN/hub/workflows/, /zh-CN/hub/apps/, /ja/hub/workflows/, /ja/hub/apps/. Nothing changes without CMS, and the workflow and app detail pages do not change.

Structured data:

  • The new hubSectionJsonLd() in utils/modelJsonLd.ts builds a CollectionPage with a Home breadcrumb and an ItemList with locale-prefixed URLs.
  • The ItemList keeps a record only when isIndexableModelPage(item.href) is true. Today no record passes, so the page has the CollectionPage and the breadcrumbs but no ItemList.
  • The ItemList comes only from CMS records (catalog.models) and only for the request with no query. A ?cursor=, ?p= or filter view shows other records under the same canonical URL, so it gets the CollectionPage without the list.
  • hub-section.astro passes the locale that pageContext() returns, so the ItemList URLs follow the same locale as t() and the canonical URL.
  • Paged and filtered views stay indexable with the canonical on the unpaged URL. This is the same rule /hub/models/ uses for its own query views.
  • modelsHubJsonLd() now uses the same private collectionPageJsonLd() helper, and its output does not change.

Copy:

  • HUB_SECTION_COPY is deleted. The new hubSectionCopy(section, t) in hub-section-copy.ts returns the title, description and heading from workshop.hubSection.<section> in the en, zh-CN and ja locale files. The English title and description are the same as before.
  • hub-section.astro uses hubSectionCopy for the H1, the catalogue island headings and the JSON-LD name. index.astro uses it for the two tab headings, so they are localized too.
  • A new intro section under each list answers "What is a ComfyUI workflow?" or "What is a ComfyUI app?".

QA Focus

  • Run pnpm exec vitest run src/utils/modelJsonLd.test.ts in apps/website. Expected: all tests pass, and the ItemList names only records whose page is indexable. Author: tested. At 8703d127f3 (test only), the new table test got 4 URLs where it expected none or only the two workflows. At 09a42bce24, both rows pass.
  • Run pnpm exec vitest run src/routes/models/hub-section-copy.test.ts. Expected: 4 tests pass, and zh-CN and ja get a localized heading for both lists. Author: tested at f4a552be34, 4 pass. With the heading set back to the English text, all 4 do not pass.
  • Run pnpm exec vitest run src/config/indexing.test.ts with and without SITE_CATALOG_API_URL exported. Expected: the same result both times. CMS off keeps both lists noindex and out of the sitemap, and CMS on indexes them and the zh-CN and ja paths. Author: tested at a15fdf443a, 130 pass both times. Before the file-level stub, 11 rows did not pass with the variable exported.
  • Start astro dev with SITE_CATALOG_API_URL set to a catalog mock and WEBSITE_INDEXABLE=1, then run validateHtml() on the server HTML of the list URLs. Expected: no robots meta, a CollectionPage, no ItemList while no detail page is indexable, and zero violations. Author: tested in the first review round on /hub/workflows/, /hub/apps/, /zh-CN/hub/workflows/, /zh-CN/hub/apps/, ?cursor=abc and ?p=2, 0 violations (temp/qa-evidence/seo4-hub-lists/). That run predates the indexable filter, so it showed an ItemList of 5 and 2 records. Not run again.
  • Open /hub/workflows/ and /hub/apps/ at 1440 px and 390 px. Expected: the intro heading and paragraph show under the list. Author: tested, see the QA comment.
  • Open the Chinese and Japanese lists and read the new copy, the H1 and the tab headings. Expected: the copy reads naturally. Author: not tested by a native speaker.
  • Render hub-section.astro and read its robots meta in CMS and static mode. Expected: the isIndexableHubList() result sets noindex. Author: not tested, because the website suite has no Astro render tests and the website e2e suite has no CMS backend.
  • Gates: pnpm typecheck:website, eslint on the changed files, website format:check and pnpm knip. Expected: all pass. Author: tested in the first review round, all exit 0. Not run again after the second round.

Risky areas

  • isIndexableModelPage() in config/indexing.ts now reads cmsEnabled() for the lists. The sitemap and the robots rule follow the build environment, so a CMS build that is not the production cutover can index the lists. isIndexableBuild() still keeps every preview build out of search.
  • The ItemList depends on isIndexableModelPage() for each record. When the detail pages launch, the ItemList fills with no change here. The list records carry no translation status, so after launch a zh-CN or ja list can name a record whose locale page is noindex.
  • The zh-CN and ja lists are indexable in CMS mode with translated head copy. The record content on them falls back to English where a translation does not exist.
  • index.astro also takes its two tab headings from hubSectionCopy with Astro.locals.t. Thus a change to the workshop.hubSection.<section>.name keys also changes the model hub tabs.

Follow-ups, already on the base and not changed here:

  • sitemapAlternates() does not add hreflang alternates for the localized lists. No build today is both CMS and indexable, and the change touches every /hub/* sitemap path, so it belongs in its own PR before the CCC cutover.
  • The <noscript> record links on the zh-CN and ja lists have no locale prefix.
  • A key that is missing in ja or zh-CN still passes translations.test.ts and locale:check.
  • isExcludedFromSitemap() does not strip the locale prefix.
  • In local dev, /ja/hub/workflows/ and /ja/hub/apps/ answer 503 before the catalog request, so the ja lists show no records.
  • At the cutover, public/llms.txt and published-model-pages.json must list the two lists, and the hub pages e2e test must expect no noindex.

PR dependency map

  1. main (base)
  2. feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204 feat(website): Comfy Content Catalog Hub CMS (supersedes feat(website): Hub admin redesign, content editor and a shareable demo preview #20640, feat(website): stage CCC admin and Preview primitives #20933) (open, targets main)
  3. feat(website): make the hub workflow and app lists indexable #21559 feat(website): make the hub workflow and app lists indexable (open, targets feat(website): Comfy Content Catalog Hub CMS (supersedes #20640, #20933) #21204) (this PR)

Merge #21204 before this PR. This PR ships with the CCC cutover, through the integration branch.

…ecords

The indexing tests now expect /hub/workflows/ and /hub/apps/ to be
indexable and in the sitemap. A new hubSectionJsonLd test checks the
list graph with validateHtml() in English and Chinese.
/hub/workflows/ and /hub/apps/ now have an index robots meta, a sitemap
entry and a localized title and description. In CMS mode, each list
also emits a CollectionPage with an ItemList of the records it shows.
A short intro paragraph under each list tells readers what a workflow
or an app is, in English, Chinese and Japanese.
The four optional props pushed the template over the pre-push complexity limit.
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since cfcff3a504815861c835bdb52cee50ca1d0f9d6a

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (132)

  • billing path matches no source files: src/components/dialog/content/credit/**. Remove or update it in docs/architecture/domains/records/billing.domain.json.
  • workspace path matches no source files: src/platform/workspace/fixtures/**. Remove or update it in docs/architecture/domains/records/workspace.domain.json.
  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/Popover.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/agentPanel.historyIdentity.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/dynamicPrompts.serializeValue.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dHost.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/reportLoadModelOutcome.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/LiteGraphGlobal.cloneObject.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkHideTransition.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSnapGeometry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 82 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

🌐 Website E2E

Tip

All tests passed.

View Report

Test results
Status ✅ Passed

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-21559.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

Deployment details

This commit: https://website-frontend-4tc1kll2i-comfyui.vercel.app

Last updated: 2026-10-21T19:06:32Z for cc3058f

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

QA: hub workflow and app lists are indexable, with intro copy and an ItemList

I ran astro dev on this branch in CMS mode against a local catalog mock (5 workflow cards, 2 app cards) with WEBSITE_INDEXABLE=1, so the robots result shows the page rule and not the build rule. Playwright drove each list at 1440 px and 390 px. A script ran validateHtml() from scripts/validate-jsonld.ts on the server HTML of the English and Chinese lists.

What it checks Proof
The workflows list shows the intro under the grid at 1440 px. It has no robots meta and an ItemList of 5.
The workflows list shows the intro at 390 px.
The apps list shows the intro under the grid at 1440 px. It has no robots meta and an ItemList of 2.
The apps list shows the intro at 390 px.
The server HTML of /hub/workflows/, /hub/apps/, /zh-CN/hub/workflows/ and /zh-CN/hub/apps/ has a CollectionPage, an ItemList with locale-prefixed URLs and 0 validateHtml() violations. ssr-check.ts output, 4 of 4 URLs with 0 violations · trace
The base branch has noindex, nofollow, no ItemList and no intro on the same URLs. ssr-check.ts on the base files, all 3 URLs checked
The indexing and JSON-LD tests are red on the test-only commit and green on the tip. unit: 11 failures on 3e4b713a07, 546 passes in 16 files on the tip

Counts: 4 pass, 0 fail, 0 escalated, 0 inconclusive. 4 screenshots, 1 trace, run against a local mock catalog.

Not covered here: the static non-CMS list (no ItemList by design, so only the robots and intro change there) and a native-speaker read of the Chinese and Japanese copy.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 21, 2026
…hed pages

The llms.txt test requires a link for each indexable route, and the
published-model-pages check requires a record for each new sitemap
page. The hub pages e2e test now expects no noindex on the two lists.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d09808ff-d89b-4017-8c5d-b3cd2047f3eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

…mList on paged views

The indexing tests now expect /hub/workflows/ and /hub/apps/ to be
indexable and in the sitemap only when the CMS list renders. A new
isIndexableHubList test covers the zh-CN and ja prefixes. The JSON-LD
test expects no ItemList on a cursor, page or search view.
…ist on paged views

isIndexableModelPage() now indexes the two lists only when cmsEnabled(),
so the static production list keeps noindex and stays out of the
sitemap. Because of this, llms.txt, the published model pages list and
the hub pages e2e test go back to the base state. The new
isIndexableHubList() strips the catalog locale prefix and the page uses
it for its robots rule. hubSectionJsonLd() emits the ItemList only for
the request with no query, because a cursor, page or filter view shows
other records under the same canonical URL.
@datadog-official

This comment has been minimized.

@MaanilVerma
MaanilVerma marked this pull request as ready for review October 22, 2026 02:36

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of SEO4 hub list indexing. No blockers. On Vercel, cmsEnabled() (non-production only) and isIndexableBuild() (production only) never overlap today. So nothing changes in prod until the CCC cutover, and previews stay noindex via meta + X-Robots-Tag. Checked and fine: section kind covers only /hub/workflows + /hub/apps; the {...jsonLd} props match BaseLayout; modelsHubJsonLd output is unchanged; env stubs are auto-restored (unstubEnvs: true); @astrojs/sitemap 3.x does include the static-path SSR list routes.

Severity Count
BLOCKER 0
SHOULD FIX 2
TRIVIAL 3

Not inline (outside the diff):

  • TRIVIAL (pre-existing): sitemapAlternates() in src/lib/hreflang.ts doesn't pass localizedHub. In an indexable CMS build, the sitemap emits no hreflang for /hub/workflows/ and /hub/apps/, but the page head emits the en/zh-CN/ja cluster. Pass { localizedHub: cmsEnabled() } there.
  • Coverage gap: nothing exercises hub-section.astro. Reverting noindex to isIndexableModelPage(Astro.url.pathname) passes every unit test and silently noindexes the zh-CN/ja lists.

Comment thread apps/website/src/utils/modelJsonLd.ts Resolved

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review scoped to commits since cc3058f667. The only new commit is 621307de20, a merge of work/ccc-mar-integration-20261014. Apart from hunk line offsets, the PR's own diff is byte-identical (+300/−47, 9 files), so none of the round-1 threads were addressed in code, and none have replies.

I checked the base changes pulled in against the files this PR depends on. BaseLayout gained an optional ogImages prop, which does not collide with the {...jsonLd} spread, and astro.config gained noExternal: ['three']. Nothing touches indexing, hreflang, JSON-LD, the launch flags or the H1 path, so there is no semantic conflict and the round-1 findings stand as written. CI on 621307de20 has no failures so far; unit, e2e, lint and typecheck are still pending.

Severity Open
BLOCKER 0
SHOULD FIX 2 (English H1 on zh-CN/ja, ItemList of noindex URLs)
TRIVIAL 2

Not approving while both SHOULD FIX items are untouched. Neither blocks merge.

Comment thread apps/website/src/utils/modelJsonLd.ts Resolved
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                          Coverage Diff                          @@
##           work/ccc-mar-integration-20261014   #21559      +/-   ##
=====================================================================
- Coverage                              86.45%   86.34%   -0.11%     
=====================================================================
  Files                                   4030     3924     -106     
  Lines                                 184642   181396    -3246     
  Branches                               50825    49718    -1107     
=====================================================================
- Hits                                  159627   156623    -3004     
+ Misses                                 22316    22221      -95     
+ Partials                                2699     2552     -147     
Flag Coverage Δ
billing-web-unit ?
website-unit 80.73% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/website/src/config/indexing.ts 97.29% <100.00%> (+0.15%) ⬆️
apps/website/src/routes/models/hub-section-copy.ts 100.00% <100.00%> (+100.00%) ⬆️
apps/website/src/utils/modelJsonLd.ts 100.00% <100.00%> (ø)

... and 115 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Replies to the two points outside the diff in the review summary:

  • sitemapAlternates(): not changed in this PR. On Vercel, cmsEnabled() is false for production and isIndexableBuild() is true only for production, so no build today has an indexable sitemap with the CMS Hub. The change also adds hreflang for every /hub/* sitemap path, and that includes detail pages whose locale version can be noindex. That change belongs in its own PR, with a check against catalogDetailNoindex, before the CCC cutover.
  • Coverage of hub-section.astro: partly closed. The H1, title and description now come from hubSectionCopy, which hub-section-copy.test.ts covers in zh-CN and ja. The noindex={!isIndexableHubList(...)} wiring is still not covered. The website suite has no Astro render tests, and the website e2e suite has no CMS backend.

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round-3 re-review, scoped to 8703d127f3, 09a42bce24, a15fdf443a and f4a552be34. All four round-1 threads are fixed in code, each with a test that fails without the fix, so I've resolved them.

  • English H1: HUB_SECTION_COPY is gone. Heading, title and description come from workshop.hubSection.*, and both consumers (hub-section.astro, models/index.astro) plus the island initialHeadings now get localized text. No English heading remains outside e2e specs for English routes.
  • ItemList of noindex URLs: it is now filtered with isIndexableModelPage on the unprefixed href (list hrefs are ${record.slug}/, so the registry lookup matches), and it is empty until workflow pages launch.
  • JSON-LD locale: it now uses pageContext().locale, typed Locale.
  • Test hermeticity: the CMS-off rows stub SITE_CATALOG_API_URL='', and the dead workflowsLaunched axis is gone.

CI at f4a552be34: website-unit, typecheck, lint, website-build and all e2e shards pass. The SEO4 lists are inert on Vercel until the CCC cutover lifts the production guard on cmsEnabled().

Severity Open
BLOCKER 0
SHOULD FIX 0
TRIVIAL 1 (pre-SEO3 follow-up, inline)

Optional polish, not required:

  • hubSectionHeadings(t) would avoid building throwaway title/description objects for the tab labels in both pages.
  • Pin the English string in hub-section-copy.test.ts so a missing en key can't make the not.toBe pass.

}: HubSectionJsonLdInput): CollectionPageJsonLd {
const site = new URL(siteUrl)
const listed = (search === '' ? items : [])
.filter((item) => isIndexableModelPage(item.href))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL (follow-up before launchedWorkflowPages flips): catalogDetailNoindex also noindexes a locale detail page without a reviewed translation (!load.translated). List records carry no translated flag, so this filter can't apply that check. After SEO3, /zh-CN and /ja ItemLists would name untranslated, noindex detail URLs. This has no effect today, since the ItemList is empty everywhere. A comment here, or a launch-checklist note next to launchedWorkflowPages, would keep it from being missed; the real fix needs a per-locale translated flag on the card records.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in comfy-website#23 (this PR moved there): 5dd465c49b. A line next to launchedWorkflowPages in config/model-page-launch.ts says that zh-CN and ja hub ItemLists can name untranslated noindex detail pages, because list cards carry no translated flag. The per-locale flag on the card records is still the real fix, and it is in our deferred list. Not tested: the change is a comment only, and lint and format pass.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Moved to Comfy-Org/comfy-website#23 (the website now lives there). This PR stays open for its review history.

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Closing: the website moved; this change lives in Comfy-Org/comfy-website#23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants