Repository navigation
feat(website): make the hub workflow and app lists indexable - #21559
MaanilVerma wants to merge 11 commits into
Conversation
…ecords The indexing tests now expect /hub/workflows/ and /hub/apps/ to be indexable and in the sitemap. A new hubSectionJsonLd test checks the list graph with validateHtml() in English and Chinese.
/hub/workflows/ and /hub/apps/ now have an index robots meta, a sitemap entry and a localized title and description. In CMS mode, each list also emits a CollectionPage with an ItemList of the records it shows. A short intro paragraph under each list tells readers what a workflow or an app is, in English, Chinese and Japanese.
The four optional props pushed the template over the pre-push complexity limit.
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since cfcff3a504815861c835bdb52cee50ca1d0f9d6a
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (132)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog 🌐 Website E2ETip All tests passed. Test results
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-21559.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. Deployment detailsThis commit: https://website-frontend-4tc1kll2i-comfyui.vercel.app Last updated: 2026-10-21T19:06:32Z for |
QA: hub workflow and app lists are indexable, with intro copy and an ItemListI ran
Counts: 4 pass, 0 fail, 0 escalated, 0 inconclusive. 4 screenshots, 1 trace, run against a local mock catalog. Not covered here: the static non-CMS list (no ItemList by design, so only the robots and intro change there) and a native-speaker read of the Chinese and Japanese copy. |
…hed pages The llms.txt test requires a link for each indexable route, and the published-model-pages check requires a record for each new sitemap page. The hub pages e2e test now expects no noindex on the two lists.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
…mList on paged views The indexing tests now expect /hub/workflows/ and /hub/apps/ to be indexable and in the sitemap only when the CMS list renders. A new isIndexableHubList test covers the zh-CN and ja prefixes. The JSON-LD test expects no ItemList on a cursor, page or search view.
…ist on paged views isIndexableModelPage() now indexes the two lists only when cmsEnabled(), so the static production list keeps noindex and stays out of the sitemap. Because of this, llms.txt, the published model pages list and the hub pages e2e test go back to the base state. The new isIndexableHubList() strips the catalog locale prefix and the page uses it for its robots rule. hubSectionJsonLd() emits the ItemList only for the request with no query, because a cursor, page or filter view shows other records under the same canonical URL.
This comment has been minimized.
This comment has been minimized.
benjcooley
left a comment
There was a problem hiding this comment.
Review of SEO4 hub list indexing. No blockers. On Vercel, cmsEnabled() (non-production only) and isIndexableBuild() (production only) never overlap today. So nothing changes in prod until the CCC cutover, and previews stay noindex via meta + X-Robots-Tag. Checked and fine: section kind covers only /hub/workflows + /hub/apps; the {...jsonLd} props match BaseLayout; modelsHubJsonLd output is unchanged; env stubs are auto-restored (unstubEnvs: true); @astrojs/sitemap 3.x does include the static-path SSR list routes.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 |
| TRIVIAL | 3 |
Not inline (outside the diff):
- TRIVIAL (pre-existing):
sitemapAlternates()insrc/lib/hreflang.tsdoesn't passlocalizedHub. In an indexable CMS build, the sitemap emits no hreflang for/hub/workflows/and/hub/apps/, but the page head emits the en/zh-CN/ja cluster. Pass{ localizedHub: cmsEnabled() }there. - Coverage gap: nothing exercises
hub-section.astro. RevertingnoindextoisIndexableModelPage(Astro.url.pathname)passes every unit test and silently noindexes the zh-CN/ja lists.
benjcooley
left a comment
There was a problem hiding this comment.
Re-review scoped to commits since cc3058f667. The only new commit is 621307de20, a merge of work/ccc-mar-integration-20261014. Apart from hunk line offsets, the PR's own diff is byte-identical (+300/−47, 9 files), so none of the round-1 threads were addressed in code, and none have replies.
I checked the base changes pulled in against the files this PR depends on. BaseLayout gained an optional ogImages prop, which does not collide with the {...jsonLd} spread, and astro.config gained noExternal: ['three']. Nothing touches indexing, hreflang, JSON-LD, the launch flags or the H1 path, so there is no semantic conflict and the round-1 findings stand as written. CI on 621307de20 has no failures so far; unit, e2e, lint and typecheck are still pending.
| Severity | Open |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 2 (English H1 on zh-CN/ja, ItemList of noindex URLs) |
| TRIVIAL | 2 |
Not approving while both SHOULD FIX items are untouched. Neither blocks merge.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## work/ccc-mar-integration-20261014 #21559 +/- ##
=====================================================================
- Coverage 86.45% 86.34% -0.11%
=====================================================================
Files 4030 3924 -106
Lines 184642 181396 -3246
Branches 50825 49718 -1107
=====================================================================
- Hits 159627 156623 -3004
+ Misses 22316 22221 -95
+ Partials 2699 2552 -147
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 115 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Replies to the two points outside the diff in the review summary:
|
benjcooley
left a comment
There was a problem hiding this comment.
Round-3 re-review, scoped to 8703d127f3, 09a42bce24, a15fdf443a and f4a552be34. All four round-1 threads are fixed in code, each with a test that fails without the fix, so I've resolved them.
- English H1:
HUB_SECTION_COPYis gone. Heading, title and description come fromworkshop.hubSection.*, and both consumers (hub-section.astro,models/index.astro) plus the islandinitialHeadingsnow get localized text. No English heading remains outside e2e specs for English routes. - ItemList of noindex URLs: it is now filtered with
isIndexableModelPageon the unprefixed href (list hrefs are${record.slug}/, so the registry lookup matches), and it is empty until workflow pages launch. - JSON-LD locale: it now uses
pageContext().locale, typedLocale. - Test hermeticity: the CMS-off rows stub
SITE_CATALOG_API_URL='', and the deadworkflowsLaunchedaxis is gone.
CI at f4a552be34: website-unit, typecheck, lint, website-build and all e2e shards pass. The SEO4 lists are inert on Vercel until the CCC cutover lifts the production guard on cmsEnabled().
| Severity | Open |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 0 |
| TRIVIAL | 1 (pre-SEO3 follow-up, inline) |
Optional polish, not required:
hubSectionHeadings(t)would avoid building throwaway title/description objects for the tab labels in both pages.- Pin the English string in
hub-section-copy.test.tsso a missingenkey can't make thenot.toBepass.
| }: HubSectionJsonLdInput): CollectionPageJsonLd { | ||
| const site = new URL(siteUrl) | ||
| const listed = (search === '' ? items : []) | ||
| .filter((item) => isIndexableModelPage(item.href)) |
There was a problem hiding this comment.
TRIVIAL (follow-up before launchedWorkflowPages flips): catalogDetailNoindex also noindexes a locale detail page without a reviewed translation (!load.translated). List records carry no translated flag, so this filter can't apply that check. After SEO3, /zh-CN and /ja ItemLists would name untranslated, noindex detail URLs. This has no effect today, since the ItemList is empty everywhere. A comment here, or a launch-checklist note next to launchedWorkflowPages, would keep it from being missed; the real fix needs a per-locale translated flag on the card records.
There was a problem hiding this comment.
Added in comfy-website#23 (this PR moved there): 5dd465c49b. A line next to launchedWorkflowPages in config/model-page-launch.ts says that zh-CN and ja hub ItemLists can name untranslated noindex detail pages, because list cards carry no translated flag. The per-locale flag on the card records is still the real fix, and it is in our deferred list. Not tested: the change is a comment only, and lint and format pass.
|
Moved to Comfy-Org/comfy-website#23 (the website now lives there). This PR stays open for its review history. |
|
Closing: the website moved; this change lives in Comfy-Org/comfy-website#23. |




Summary
/hub/workflows/and/hub/apps/can now rank in search once the CCC list serves them. In CMS mode each list is indexable, has a localized title, description and H1, shows a short intro paragraph and emits aCollectionPage. TheCollectionPagehas anItemListof the listed records whose own page is indexable, so the list stays empty until the detail pages launch (SEO3). The static production list keepsnoindex. This is plan item SEO4 and ships with the CCC cutover.Changes
Indexing:
isIndexableModelPage()inconfig/indexing.tsnow returnscmsEnabled()for the two list pages (sectionkind). In CMS mode they get no robotsnoindexand are in the sitemap. Without CMS they keepnoindexand stay out of the sitemap, as on the base.isIndexableHubList()strips the catalog locale prefix before the check, andhub-section.astrouses it for its robots rule. Thus/zh-CN/hub/workflows/and/ja/hub/apps/follow the English rule.Routes whose indexing changes, in CMS mode only:
/hub/workflows/,/hub/apps/,/zh-CN/hub/workflows/,/zh-CN/hub/apps/,/ja/hub/workflows/,/ja/hub/apps/. Nothing changes without CMS, and the workflow and app detail pages do not change.Structured data:
hubSectionJsonLd()inutils/modelJsonLd.tsbuilds aCollectionPagewith a Home breadcrumb and anItemListwith locale-prefixed URLs.ItemListkeeps a record only whenisIndexableModelPage(item.href)is true. Today no record passes, so the page has theCollectionPageand the breadcrumbs but noItemList.ItemListcomes only from CMS records (catalog.models) and only for the request with no query. A?cursor=,?p=or filter view shows other records under the same canonical URL, so it gets theCollectionPagewithout the list.hub-section.astropasses the locale thatpageContext()returns, so theItemListURLs follow the same locale ast()and the canonical URL./hub/models/uses for its own query views.modelsHubJsonLd()now uses the same privatecollectionPageJsonLd()helper, and its output does not change.Copy:
HUB_SECTION_COPYis deleted. The newhubSectionCopy(section, t)inhub-section-copy.tsreturns the title, description and heading fromworkshop.hubSection.<section>in theen,zh-CNandjalocale files. The English title and description are the same as before.hub-section.astrouseshubSectionCopyfor the H1, the catalogue island headings and the JSON-LD name.index.astrouses it for the two tab headings, so they are localized too.QA Focus
pnpm exec vitest run src/utils/modelJsonLd.test.tsinapps/website. Expected: all tests pass, and theItemListnames only records whose page is indexable. Author: tested. At8703d127f3(test only), the new table test got 4 URLs where it expected none or only the two workflows. At09a42bce24, both rows pass.pnpm exec vitest run src/routes/models/hub-section-copy.test.ts. Expected: 4 tests pass, and zh-CN and ja get a localized heading for both lists. Author: tested atf4a552be34, 4 pass. With the heading set back to the English text, all 4 do not pass.pnpm exec vitest run src/config/indexing.test.tswith and withoutSITE_CATALOG_API_URLexported. Expected: the same result both times. CMS off keeps both listsnoindexand out of the sitemap, and CMS on indexes them and thezh-CNandjapaths. Author: tested ata15fdf443a, 130 pass both times. Before the file-level stub, 11 rows did not pass with the variable exported.astro devwithSITE_CATALOG_API_URLset to a catalog mock andWEBSITE_INDEXABLE=1, then runvalidateHtml()on the server HTML of the list URLs. Expected: no robots meta, aCollectionPage, noItemListwhile no detail page is indexable, and zero violations. Author: tested in the first review round on/hub/workflows/,/hub/apps/,/zh-CN/hub/workflows/,/zh-CN/hub/apps/,?cursor=abcand?p=2, 0 violations (temp/qa-evidence/seo4-hub-lists/). That run predates the indexable filter, so it showed anItemListof 5 and 2 records. Not run again./hub/workflows/and/hub/apps/at 1440 px and 390 px. Expected: the intro heading and paragraph show under the list. Author: tested, see the QA comment.hub-section.astroand read its robots meta in CMS and static mode. Expected: theisIndexableHubList()result setsnoindex. Author: not tested, because the website suite has no Astro render tests and the website e2e suite has no CMS backend.pnpm typecheck:website, eslint on the changed files, websiteformat:checkandpnpm knip. Expected: all pass. Author: tested in the first review round, all exit 0. Not run again after the second round.Risky areas
isIndexableModelPage()inconfig/indexing.tsnow readscmsEnabled()for the lists. The sitemap and the robots rule follow the build environment, so a CMS build that is not the production cutover can index the lists.isIndexableBuild()still keeps every preview build out of search.ItemListdepends onisIndexableModelPage()for each record. When the detail pages launch, theItemListfills with no change here. The list records carry no translation status, so after launch azh-CNorjalist can name a record whose locale page isnoindex.zh-CNandjalists are indexable in CMS mode with translated head copy. The record content on them falls back to English where a translation does not exist.index.astroalso takes its two tab headings fromhubSectionCopywithAstro.locals.t. Thus a change to theworkshop.hubSection.<section>.namekeys also changes the model hub tabs.Follow-ups, already on the base and not changed here:
sitemapAlternates()does not add hreflang alternates for the localized lists. No build today is both CMS and indexable, and the change touches every/hub/*sitemap path, so it belongs in its own PR before the CCC cutover.<noscript>record links on thezh-CNandjalists have no locale prefix.jaorzh-CNstill passestranslations.test.tsandlocale:check.isExcludedFromSitemap()does not strip the locale prefix./ja/hub/workflows/and/ja/hub/apps/answer 503 before the catalog request, so thejalists show no records.public/llms.txtandpublished-model-pages.jsonmust list the two lists, and the hub pages e2e test must expect nonoindex.PR dependency map
main(base)main)Merge #21204 before this PR. This PR ships with the CCC cutover, through the integration branch.