Repository navigation
[backport cloud/1.56] comfy-multi-player 0.3.10 (schema v5) + stale-schema reseed handshake (#20096, #19032, #20264) - #20620
Conversation
…ribe (#19032) ## Summary When the server can no longer read a workflow's stored CRDT document (an older document schema), the agent follower now asks the server to re-mint it from the canvas the tab currently shows. Before this, the tab sat there re-probing the document until the next prompt. ## Changes - **What**: - Every `doc_subscribe` now advertises `supports_reseed: true`. A server that knows the flag refuses a stale-schema document with `stale_schema_reseed_required`. A server that doesn't know it ignores the flag, and nothing changes. - On that refusal, `useAgentCrdtFollower` asks `LayoutFollowerBridge` to send one `doc_reseed` through the bridge. The frame carries the serialized graph the bound tab shows: the same content a prompt posts as its `draft`, supplied by `AgentPanelRoot` through a new `canvasFor` argument. - The bridge owns and consumes a refusal token, allowing one reseed per refusal. Retryable results may reseed only after the bounded subscribe backoff produces a fresh refusal. The follower falls back to the ordinary bounded refused-subscribe retry when: - there is no canvas, or the canvas has no nodes, or - the frame can't leave the socket. - `LayoutFollowerBridge` treats a `doc_reseed_result` that is `ok` (or `conflict`, meaning another tab won) as a lineage reset. It dispatches `doc_reset`, drops the doc and resubscribes with an empty state vector. That's the same path a server `doc_reset` takes, and it's needed because a refused tab isn't following the channel the reset went out on. - Non-retryable answers are final; `retry`, `unavailable`, `overloaded`, and `error` return to the bounded refused-subscribe backoff. The lifecycle stops probing that document quietly (no error report) until a reconnect or retarget. - The dev panel gets two new event kinds: `doc_reseed_sent` and `doc_reseed_result`. - **Breaking**: none. The new subscribe field is additive. ## Review Focus - The server's own copy of the graph is never used to re-mint, because it can lag human edits. The canvas on screen is the only source, which is why the follower does this rather than the server. - There is no loop: one reseed per refusal; successful or conflicting resets block another answer until subscribe confirmation, reconnect, or retarget; retryable failures remain within the lifecycle budget; and a final refusal stops probing. - Deploy order: server first. The capability flag makes either order safe. Server counterpart: Comfy-Org/cloud#10814 ## Testing Each behaviour was written red first: - `docFrameClient.reseed.test.ts`. Red: 9 failures (no `reseed`, no `doc_reseed_result` parsing, no flag on subscribe). Green: - the subscribe advertises the flag, and `doc_reseed` is encoded with the canvas; - `doc_reseed_result` is parsed and validated; - the bridge only reseeds the workflow it follows; - `ok`, `already_current` and `conflict` each reset the lineage and resubscribe with a fresh doc; - a final refusal is forwarded without a resubscribe; - an unsolicited result is ignored. - `useAgentCrdtFollower.test.ts` (stale-schema reseed block). Red: 4 failures. The fallback cases passed from the start and act as guards. Green: - on the refusal code, one reseed is sent with `canvasFor(workflowId)` and no backoff race; - each fresh refusal can be answered once, including after reconnect or a retryable result; - without the code, the ordinary retry is unchanged; - no canvas, an empty canvas, or an unsendable frame falls back to the retry; - a refused reseed stops probing with no error report; - a retarget and reconnect both allow a fresh refusal to be answered; unavailable canvases can recover on a later refusal. - The existing subscribe-encoding assertion was updated for the new field; brittle duplicate and exact-listener-count tests were removed. The parser table now rejects inherited object keys and is exhaustively typed. - `pnpm typecheck`, `pnpm knip`, oxfmt, oxlint and eslint on the changed files all pass, as do the focused CRDT suite (164 tests) and the pre-push `fallow audit`. --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 3235c9c)
## Summary Follow-up to review comments on #19032: type the retryable reseed codes and give the awareness state parser a discriminated result, with no behavior change. ## Changes - **What**: - `docFrameCodes.ts`: adds the `RetryableReseedCode` union. The code set stays a `ReadonlySet<string>` built with `new Set<RetryableReseedCode>([...] as const)`, so a member outside the union fails to compile, and `isRetryableReseedCode` narrows to the union. - `docFrameClient.ts`: `parseAwarenessState` returns `{ kind: 'present', state } | { kind: 'absent' } | { kind: 'invalid' }`. The awareness parser rejects the frame on `invalid`, omits `state` on `absent` (missing or null), and passes the record on `present`. - `docFrameClient.awareness.test.ts`: one `it.for` table covers missing, null, string, array, exactly 8 KiB, 8 KiB plus one byte, and valid states, each row with its expected frame inline. The standalone 8 KiB and valid-frame tests it replaces are gone. ## Review Focus The helper exists instead of two inline checks because inlining them gives `awareness` an estimated fallow CRAP of 37 against the threshold of 30, which fails the pre-push audit. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com> (cherry picked from commit 409c6eb)
…r proof of what it fixes (FE-3036) (#20096) > [!WARNING] > **Do not merge this alone.** It carries `do-not-merge`, and it must land in the > same drained step as [`Comfy-Org/cloud` > (the matching doc-host pin, also held), **cloud first**. The follower's read > gate is exact equality against the schema version the build compiled against > and the package offers no compatibility reader, so a frontend at v5 against a > doc-host at v4 refuses every document. Rollout order and the exposure window > are in "The cutover window" below — read it before merging, not after. Moves the `@comfyorg/comfy-multi-player` catalog pin from `0.3.6` (schema v4) to `0.3.10` (schema v5), which fixes a silent value loss on any class whose pinned `widget_order` names one widget twice: v4 keeps a single register for that name, so the second position's value overwrites the first and a write aimed at the second lands on the first. No `src/` file changes — the proof is three tests, one in the browser and two at unit level. <details><summary>What the pin fixes, and the exact scope of the behaviour change</summary> With the pin at `0.3.6`, a node of a repeated-name class renders the **other** occurrence's value on the widget the frontend kept, and the document's projection of a two-widget node is a **one-element** array — a value is gone, silently. At `0.3.10` the kept widget gets its own occurrence, the occurrence it cannot address is reported `agent_graph_widget_missing` and skipped, and the projection carries both values. Measured against both published packages (`project()` output, repeated-name catalog `{ widget_order: ['dup','dup'] }`, seed `['A','B']`): | op the frontend can mint | `0.3.6` | `0.3.10` | | --- | --- | --- | | mint only | `["B"]` | `["A","B"]` | | `set_widget{dup}` | `applied`, `["W"]` — moves **both** positions | `applied`, `["W","B"]` | | `set_widget{dup#1}` (the local rename) | `rejected unknown_widget`, `["B"]` | `rejected unknown_widget`, `["A","B"]` | | `set_widget{dup, occurrence 1}` | `applied`, `["W"]` — the field is **silently ignored** | `applied`, `["A","W"]` | That table is now committed as four `applierConformance.test.ts` rows, so it re-asserts at every future pin swap rather than living in a PR description. **The frontend needs no occurrence minting for this.** The standing concern was that v5 reads an absent `widget_occurrence` as zero, so a frontend that cannot express an occurrence would write the wrong widget. That is a property of the **ambiguity**, not of the pin: an occurrence-free `set_widget` is a write to occurrence 0, which after #20087 is the only widget that name addresses. The ambiguous widget is refused at construction and the renamable repeat becomes `name#1`, which the applier rejects `unknown_widget` rather than misaddressing. **Scope of the behaviour difference, narrowed to what was measured.** Not "the only widget behaviour that differs" — probed at both pins, v5 also keeps `widgets_values_named` in step with writes on every class (A23) where v4 leaves it stale, accepts option-owned dynamic-combo widget names, and admits self-described (A24) nodes. For a repeated-name class A23 ties the named register to the last occurrence, so with `NamedValuesRestore` (or `fallbackWidgetsValuesNames`) on, a recreated node could show occurrence 1's value on the kept widget; that residual is **not** verified here and belongs to FE-3036. What is verified is that the whole 63-file agent CRDT unit directory passes unchanged at `0.3.10` — which is why a pin bump looks inert and needed a browser case plus the two unit cases below to show it is doing anything. **`0.3.10` and not `0.3.9`.** `0.3.9` publishes A22/A24 occurrence addressing without comfy-multi-player #272's decoded-name overflow bound, so a storage key whose decoded name is an `_extra_<n>` placeholder is unbounded on the unpinned path. `0.3.10` is the first release containing `a1f9435e2d`. </details> <details><summary>The cutover window, measured in source on both repos</summary> Landing both pins in one step is **necessary and not sufficient**, and the window has two distinct shapes that behave differently. The earlier version of this section described only the first. **1. Host-replica skew — loud, self-healing.** A doc-host that meets a stored document *newer than itself* refuses the subscribe with `schema_version_mismatch`. That code is in `PERMANENT_SUBSCRIBE_REFUSAL_CODES` (`agentCrdtDocLifecycle.ts:50`) so it skips the retry ladder and latches, and it is **not** in `SILENT_PERMANENT_REFUSAL_CODES`, so the person gets the localized toast: summary "This workflow can't sync", with the canvas-unchanged reassurance as the **second sentence** of `agent.workflowSyncFailedDetail`. The latch is per connection — `onReconnected()` releases it — and a rolling deploy restarts sockets anyway, so an affected tab recovers on its next reconnect. **2. Client/document skew — silent, needs a reload.** This is the case that is not covered by any merge ordering, and it is the one worth planning for. - `doc_subscribe` carries `v: DOC_PROTOCOL_VERSION` (1), `workflow_id`, `state_vector_b64` and `supports_reseed` — **no schema version** (`docFrameClient.ts:498-505`). The host never learns what the client can read. - On cloud `main` the host *accepts* a **stale** stored document at seq 0 and arranges a re-mint (`doc_stale_schema_test.go`, `TestDocResyncAcceptsAStaleSchemaDocumentLikeAPreMintSubscribe`; the socket twin asserts the same). Only a *newer* claim, an unreadable claim, or a stale doc off the CRDT path are refused. - So a v5 frontend against v4 documents, or a not-yet-reloaded v4 tab against re-minted v5 documents, reaches no host refusal at all. It reaches the client-side gate: `assertReadableSchema` inside `isReadableUpdate` (`layoutFollowerBridge.ts:399`) throws, the update is not propagated, and a `schema_error` event is dispatched. - `onSchemaError` (`useAgentCrdtFollower.ts:642`) sets `connected = false`, clears the stale probe, discards the pending projection and counts an `errored` outcome. **No toast** — `onSyncError` is raised only from `handleRejectedSubscription`, i.e. a host refusal — and **no permanent latch**, which lives in the subscribe path. - A reconnect returns the same document to the same build, so the gate fails again. The tab stays without a follower **until a reload**, not "for one connection". **Rollout plan, therefore:** deploy cloud #11864 first, then this pin in the same drained step, with the host re-mint of stored v4 documents. Watch `comfy.agent.turn_failure_cause{failure_cause:doc_unreadable}` for shape 1 — and note that **shape 2 is invisible to that monitor**. The signal for it is the follower's own `schema_error` dev event and the `errored` outcome counter; if those are not exported, the silent case is unmeasured, and that is a gap in the plan rather than in this diff. Both gates are already correct and fail closed; what this needs from people is the order and the acknowledgement that the window is not empty. Traced through source on both repos; not run end to end. </details> <details><summary>Telemetry volume after cutover, and the one open owner question</summary> **`agent_graph_widget_missing` volume.** Measured from the new unit case rather than estimated. For a production class that repeats a name, a follower catch-up reports: | report | errorType | level | message | | --- | --- | --- | --- | | the duplicate refused at registration | `failure_renaming_widget_duplicate_name` | `warning` | `Refused a widget named "dup": node N already has a widget of that name and the duplicate cannot be renamed` | | the register it cannot address | `agent_graph_widget_missing` | **none → Sentry default (`error`)** | `Node N (Class) has no widget '<NUL>widget-occurrence:["dup",1]'` | `reportOnce` keys on `widget:<nodeId>:<name>`, so it is **once per (node, register) per `LiveGraphApplier` instance**, not once per frame. Volume is therefore bounded by the number of such nodes a follower builds in a session. Two things are nonetheless wrong with it for a condition that is correct by design: it is `error` severity while its sibling refusal is already `warning`, and the `name` it carries is the raw NUL-prefixed doc-internal storage key, which is not readable or greppable in a dashboard. The right shape is `level: 'warning'` or a dedicated errorType. Both are `src/` changes and neither belongs to a pin bump — filed against FE-3036. **This cannot be measured in production before the cutover**, because the condition requires a v5 document and none exists until cloud #11864 deploys; the pre-cutover `agent_graph_widget_missing` rate is a different population (positional `_extra_N` aliases). **Open, and owned by a person rather than this diff:** the host re-mint of stored v4 documents needs an owner. Nothing here provides it. **Settled since the last review, so no longer open:** - **#20087 has merged** as [`5c17af2334`](5c17af2), implementing construction-time uniqueness. The duplicate-identity question this case depends on is resolved; it is no longer awaiting a verdict. - **`__widgets_form` does not pass through the follower.** 0.3.9 added that doc-internal key (A24) and `readDocNode` would copy it into `fields`, `zComfyNode` is `.passthrough()`, and `wireNodeSnapshot` strips only `__incarnation` — so if a document carried it, an `add_node` re-minted from that node would be rejected `invalid_node_payload` (probed: it is). The precondition does not hold. `__widgets_form` is written **only** for a node whose payload declares `widgets_values_form`, and `widgets_values_form` appears **zero times** in `ComfyUI_frontend`, `Comfy-Org/cloud` and `ComfyUI` (code search, all three). A v5 host therefore writes the key for no class, and `project()` emits `widgets_values_form` in its place rather than the internal key. No `src/` strip is added for an unreachable path; if a producer ever opts into A24, `wireNodeSnapshot` is where it goes. - **#20124 and #20135, which rework the refusal this spec matches.** Both are still OPEN and both are `CONFLICTING`/`DIRTY` against `main` — #20124 is 20 ahead / **178 behind**, #20135 is 38 ahead / **112 behind**, and both are based on #20087's merge. At its current head (`7b5b27a0de`) #20124 **does** still rename the errorType to `widget_duplicate_name_refused`, so if it lands as written the console match in this spec stops matching; at `87e6b68352` keeps `failure_renaming_widget_duplicate_name` and is compatible. Neither can land without a rebase, so neither lands silently ahead of this. </details> Node 26 per `.nvmrc`, `NODE_OPTIONS=--no-experimental-webstorage`. All at head `e52c184e30`. - `pnpm typecheck`, `pnpm typecheck:browser`, `pnpm format:check` — exit 0; `oxlint --type-aware` clean on all three changed test files. - `pnpm test:unit src/workbench/extensions/agent/crdt` — **63 files, 948 passed, 1 expected fail** (943 before this PR's two new cases). - `playwright test browser_tests/tests/agent/agentDuplicateWidgetOccurrenceFollower.spec.ts --project=cloud` — 1 test, passes. `--list` confirms this spec adds exactly one cloud test. - `pnpm install --lockfile-only` in a scratch project resolves `@comfyorg/comfy-multi-player@0.3.10` with **no** `minimumReleaseAgeExclude` entry and adds none, while the same run against a genuinely young version (`@comfyorg/comfyui-desktop-bridge-types@0.4.0`) prints "Added 1 entry" — so the 0.3.10 exclude line this PR removes was a supply-chain bypass that did nothing. **Tests.** `browser_tests/tests/agent/agentDuplicateWidgetOccurrenceFollower.spec.ts` is six `test.step`s, black-box throughout: the rendered node, the refusal's own `errorType` on the console, and the host document's projection. The host is the real applier in-process (`HostDoc`) at this same pin, so both legs are v5. Two unit cases carry the facts a browser shard should not be the only guard for: `applierConformance.test.ts` gains the four-row op table above, and `liveGraphApplier.test.ts` gains the repair itself against the real applier, the real `LGraph` and the pinned package. **Mutation matrix, re-measured at `e52c184e30`.** Each mutation reverted before the next; the unmutated control is green before and after. | Mutation | Result | | --- | --- | | pin reverted to `0.3.6` — browser case | **red**: `toHaveValue` expected `"first occurrence"`, received `"second occurrence"` | | pin reverted to `0.3.6` — `liveGraphApplier.test.ts` | **red**: `[["dup","second occurrence"]]` for `[["dup","first occurrence"]]` | | pin reverted to `0.3.6` — `applierConformance.test.ts` | **red**, all four rows: `["B"]`, `["W"]`, `["B"]`, `["W"]` | | the #20087 refusal neutered (`dropUnrenamableDuplicateWidgets` returns `[]`) | **red**: `toHaveCount(1)` receives 0 | | `failure_renaming_widget_duplicate_name` renamed in `nodeShellLifecycle.ts:39` | **red**: no refusal report — the console matcher is a literal at a word boundary | | the fixture stops installing the duplicate widget | **red**: no refusal report | | `widget_occurrence` dropped from the host's ops | **red**: the kept widget shows `"rewritten second occurrence"` | | the resubscribe removed (`hostSocket.disconnect()` deleted) | **red**: the unbroadcast marker never renders | The last three exist because the first version of this case was vacuous on its own precondition. The previous matrix was measured against a superseded contract — it named `syncWidgetOrder` and a `widget_duplicate_name_refused` string that exists nowhere at this head — and this one replaces it. **"Red with the pin at `0.3.6`" is the claim**, not "red on this PR's parent": HEAD is a merge whose first parent already pins 0.3.10. No screenshots: the pin changes which register a value lands in, and the only visible difference is the string inside a widget, which the browser case asserts by value. --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 60d58f2)
…: it asserts #20087's report, which is not on cloud/1.56
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
CodeRabbit skipped this PR because of the repository's |
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c592ed1126f5807c5dfba9fa1de39bde3f46f01b
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2200 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T06:48:49.055Z",
"gitSha": "555a8c2b6e228f9efa6ed4505929c800c4055065",
"branch": "glary/cloud-1.56-backport-multiplayer-v5",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2018.0279999999584,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.248,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.29599999999994,
"heapDeltaBytes": 642412,
"heapUsedBytes": 68035436,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.515000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2018.0400000000418,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9720000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.139,
"heapDeltaBytes": 504072,
"heapUsedBytes": 68686772,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.157000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.1710000000394,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.396,
"layouts": 12,
"layoutDurationMs": 4.329000000000001,
"taskDurationMs": 813.6750000000002,
"heapDeltaBytes": -2226392,
"heapUsedBytes": 66576808,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.44400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740745,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1786.5309999999681,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.304,
"layouts": 12,
"layoutDurationMs": 4.408,
"taskDurationMs": 777.8670000000001,
"heapDeltaBytes": -2411360,
"heapUsedBytes": 66019100,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 163.008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.5780000000414,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.323000000000002,
"layouts": 6,
"layoutDurationMs": 1.3230000000000002,
"taskDurationMs": 340.961,
"heapDeltaBytes": 3776968,
"heapUsedBytes": 70903104,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.356000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.456000000031,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.625,
"layouts": 6,
"layoutDurationMs": 1.1710000000000003,
"taskDurationMs": 343.024,
"heapDeltaBytes": 3956060,
"heapUsedBytes": 72871644,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.270999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 702.8450000000248,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.7820000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.9,
"heapDeltaBytes": -6709260,
"heapUsedBytes": 61264236,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 167.088,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 698.5079999999471,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.313000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.311,
"heapDeltaBytes": -8800796,
"heapUsedBytes": 59989168,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 172.939,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1141.9429999999693,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.337,
"heapDeltaBytes": 15364252,
"heapUsedBytes": 84936676,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 71.96900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 523,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1144.5449999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.4379999999999,
"heapDeltaBytes": 15276300,
"heapUsedBytes": 84399184,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 69.45400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 518,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 879.6089999999595,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.02599999999995,
"heapDeltaBytes": 18738056,
"heapUsedBytes": 100588432,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.14799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.237142857142835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 876.4200000000528,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.7109999999999,
"heapDeltaBytes": 17749972,
"heapUsedBytes": 104791128,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 174.57899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 242,
"frameDurationMs": 25.234285714285736,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10311.812999999973,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.057999999999999025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9312.825,
"heapDeltaBytes": 9124468,
"heapUsedBytes": 94284296,
"domNodes": -142,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 7709.601,
"eventListeners": -78,
"totalBlockingTimeMs": 1298,
"frameDurationMs": 33.65882352941176,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9148.094000000016,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4410000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8384.96,
"heapDeltaBytes": -16576040,
"heapUsedBytes": 68054976,
"domNodes": -142,
"jsHeapTotalBytes": -12193792,
"scriptDurationMs": 6878.7919999999995,
"eventListeners": -78,
"totalBlockingTimeMs": 635,
"frameDurationMs": 32.50177935943061,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10040.208000000006,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5249999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9256.732,
"heapDeltaBytes": -284944,
"heapUsedBytes": 84767892,
"domNodes": -142,
"jsHeapTotalBytes": -2232320,
"scriptDurationMs": 7686.751,
"eventListeners": -78,
"totalBlockingTimeMs": 1142,
"frameDurationMs": 33.55518394648829,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9672.358000000031,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5140000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8935.719,
"heapDeltaBytes": -856596,
"heapUsedBytes": 77002236,
"domNodes": -142,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 7425.431,
"eventListeners": -78,
"totalBlockingTimeMs": 1113,
"frameDurationMs": 34.27730496453901,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2007.6980000000049,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.159000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.825,
"heapDeltaBytes": -9613376,
"heapUsedBytes": 78029440,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.037,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2018.5450000000174,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.681,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.09799999999996,
"heapDeltaBytes": -10303004,
"heapUsedBytes": 77518424,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.92,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2337.274999999977,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.285,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1590.6160000000002,
"heapDeltaBytes": -20485904,
"heapUsedBytes": 69632852,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 842.814,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7863309352518,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2342.7379999999403,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.907000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1557.9959999999996,
"heapDeltaBytes": -19684796,
"heapUsedBytes": 70615300,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 827.842,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.784999999999997,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3668.0619999999635,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.623000000000003,
"layouts": 60,
"layoutDurationMs": 14.978,
"taskDurationMs": 1682.197,
"heapDeltaBytes": 1589380,
"heapUsedBytes": 69414048,
"domNodes": 24,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 798.095,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3571.2839999999915,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.764000000000001,
"layouts": 60,
"layoutDurationMs": 13.983,
"taskDurationMs": 1643.331,
"heapDeltaBytes": 2962888,
"heapUsedBytes": 84537016,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 775.455,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3135.458999999969,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.554000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1870.8339999999998,
"heapDeltaBytes": 17613804,
"heapUsedBytes": 86899756,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 971.3119999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3088.563000000022,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.403000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1857.8960000000002,
"heapDeltaBytes": 2981664,
"heapUsedBytes": 72276696,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 974.3689999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130438,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2010.9070000000884,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.6950000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.5729999999999,
"heapDeltaBytes": -11246712,
"heapUsedBytes": 69762780,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.30500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.1830000000264,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.278999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.2979999999999,
"heapDeltaBytes": -11139200,
"heapUsedBytes": 70294904,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 36.373999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.4709999999714,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.87800000000004,
"heapDeltaBytes": -11644768,
"heapUsedBytes": 57487204,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 144.715,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.7459999999173,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.476000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.43999999999994,
"heapDeltaBytes": -11706808,
"heapUsedBytes": 58082844,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 154.742,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66842105263157,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2008.9179999999942,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.699,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.616,
"heapDeltaBytes": 1062492,
"heapUsedBytes": 70283836,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.6870000000000065,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.8489999999883,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.285999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.00199999999995,
"heapDeltaBytes": 1014572,
"heapUsedBytes": 70860156,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.762999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.182999999939,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.049,
"layouts": 16,
"layoutDurationMs": 5.771999999999999,
"taskDurationMs": 749.107,
"heapDeltaBytes": -5931272,
"heapUsedBytes": 63724588,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.326,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.4059999999818,
"styleRecalcs": 61,
"styleRecalcDurationMs": 18.192,
"layouts": 16,
"layoutDurationMs": 6.104,
"taskDurationMs": 741.98,
"heapDeltaBytes": -6209912,
"heapUsedBytes": 63942024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 111.634,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.8679999999986,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.052999999999997,
"layouts": 5,
"layoutDurationMs": 14.487000000000004,
"taskDurationMs": 897.732,
"heapDeltaBytes": 3069488,
"heapUsedBytes": 97848524,
"domNodes": 14227,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 27.664999999999996,
"eventListeners": 2463,
"totalBlockingTimeMs": 131,
"frameDurationMs": 19.368918918918908,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8529.684999999972,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.806,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5640.192000000001,
"heapDeltaBytes": 7578480,
"heapUsedBytes": 86897668,
"domNodes": 0,
"jsHeapTotalBytes": 1015808,
"scriptDurationMs": 2788.8039999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698630136986303,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8730.919000000085,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.727999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5713.9439999999995,
"heapDeltaBytes": -13617172,
"heapUsedBytes": 71857836,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2883.381,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697896749521988,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17590.212000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16826.485,
"heapDeltaBytes": -33153704,
"heapUsedBytes": 179853284,
"domNodes": -3045,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 264.02500000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.902380952380955,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 18061.57600000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17232.983999999997,
"heapDeltaBytes": -43875548,
"heapUsedBytes": 179811084,
"domNodes": -3045,
"jsHeapTotalBytes": 106496,
"scriptDurationMs": 268.672,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.829351535836178,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22461.962999999967,
"styleRecalcs": 177,
"styleRecalcDurationMs": 19.849000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21982.94,
"heapDeltaBytes": -37757636,
"heapUsedBytes": 184056144,
"domNodes": -3045,
"jsHeapTotalBytes": 892928,
"scriptDurationMs": 857.836,
"eventListeners": -14915,
"totalBlockingTimeMs": 22,
"frameDurationMs": 40.92149362477231,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22090.779,
"styleRecalcs": 179,
"styleRecalcDurationMs": 19.401000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21698.028000000002,
"heapDeltaBytes": -20781816,
"heapUsedBytes": 189636508,
"domNodes": -3045,
"jsHeapTotalBytes": 5836800,
"scriptDurationMs": 869.642,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.223132969034616,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6539.60399999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.80800000000005,
"layouts": 20,
"layoutDurationMs": 23.60699999999999,
"taskDurationMs": 6346.710999999999,
"heapDeltaBytes": 4719028,
"heapUsedBytes": 218370836,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 113.896,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.987912087912086,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6629.24200000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.70000000000005,
"layouts": 20,
"layoutDurationMs": 24.91800000000001,
"taskDurationMs": 6484.606000000002,
"heapDeltaBytes": 942840,
"heapUsedBytes": 223132880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.556,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.445054945054956,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9450.252999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9002.779,
"heapDeltaBytes": -42845052,
"heapUsedBytes": 179474420,
"domNodes": -3045,
"jsHeapTotalBytes": 368640,
"scriptDurationMs": 144.01799999999997,
"eventListeners": -14914,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.25119453924914,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8931.03199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8581.371999999998,
"heapDeltaBytes": -33674764,
"heapUsedBytes": 180053492,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 141.05800000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.327891156462577,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 476.9810000000234,
"styleRecalcs": 21,
"styleRecalcDurationMs": 17.548000000000002,
"layouts": 4,
"layoutDurationMs": 1.5749999999999997,
"taskDurationMs": 121.67500000000001,
"heapDeltaBytes": 5812660,
"heapUsedBytes": 71592940,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.451000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 122.56699999988996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.268,
"layouts": 4,
"layoutDurationMs": 2.015,
"taskDurationMs": 89.85099999999998,
"heapDeltaBytes": 3727164,
"heapUsedBytes": 69282292,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.788000000000006,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.44999999999997,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 803.1209999999191,
"styleRecalcs": 78,
"styleRecalcDurationMs": 99.611,
"layouts": 76,
"layoutDurationMs": 24.585,
"taskDurationMs": 771.6299999999999,
"heapDeltaBytes": 17235776,
"heapUsedBytes": 81980296,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 310.14,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448985,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 870.7699999999932,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.313,
"layouts": 76,
"layoutDurationMs": 25.235,
"taskDurationMs": 823.2819999999999,
"heapDeltaBytes": 17717932,
"heapUsedBytes": 82486064,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 332.45599999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1441.9279999999617,
"styleRecalcs": 78,
"styleRecalcDurationMs": 272.528,
"layouts": 76,
"layoutDurationMs": 30.683,
"taskDurationMs": 1423.131,
"heapDeltaBytes": 8616916,
"heapUsedBytes": 115504948,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 489.113,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.123749999999994,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1440.4919999999493,
"styleRecalcs": 78,
"styleRecalcDurationMs": 268.146,
"layouts": 76,
"layoutDurationMs": 29.686,
"taskDurationMs": 1407.146,
"heapDeltaBytes": 8328616,
"heapUsedBytes": 114897048,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 468.324,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.143037974683534,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.56 #20620 +/- ##
=============================================
Coverage ? 85.13%
=============================================
Files ? 3513
Lines ? 169026
Branches ? 44054
=============================================
Hits ? 143903
Misses ? 23136
Partials ? 1987
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR Created by the Glary-Bot Agent
Why
Prod's frontend and agent disagree on the CRDT document schema:
cloud/1.55@7774606(and the currentcloud/1.56tip) ships@comfyorg/comfy-multi-player0.3.6 → schema v4.#20096 was meant to land in lockstep with that cloud change, but it only reached
main. Two things follow:CRDT follower: doc meta.schema_version=5 is not the v4 layout this build reads, and RUM shows about 88 errors across 59 sessions in 48h.stale_schema_reseed_required, and documents stored at v4 stay locked. The agent logged about 96k seq-0 accepts across about 287 workflows.This backports the minimum set that puts the release frontend on v5, with the handshake.
Commits
161fe98a526272f4d36070c6880869@comfyorg/comfy-multi-player0.3.1094b1439945agentDuplicateWidgetOccurrenceFollower.spec.tsConflicts resolved in #20096:
pnpm-workspace.yaml: kept 1.56'sminimumReleaseAgeExcludeand removed the 0.3.6 row.liveGraphApplier.test.ts: kept the 1.56 version.Tests deliberately left out. #20096's message mentions three tests; only
applierConformance.test.tsremains here. Main's repeated-nameliveGraphApplier.test.tshunk and the browser spec are both dropped. They assert thefailure_renaming_widget_duplicate_namereport, which comes from #20087, and #20087 is not oncloud/1.56.No other
src/changes come with the pin, andyjsstays at 13.6.32.Rollout
Testing
pnpm typecheckpasses.vitest src/workbench/extensions/agent: 2769 of 2770 pass.agentSubgraphDefinitions.test.ts("scans deeply nested definition ids…"), a lib0deepFreezestack overflow.cloud/1.56with the original 0.3.6 pin, and this branch doesn't touch that code or yjs/lib0.Review
deep-reviewergave a PASS on the final head. It confirmed that #19032 and #20264 match theirmainoriginals and that every symbol they use exists on 1.56. Two upstream notes, both of which apply identically onmain: