Repository navigation
[cloud/1.55] fix(agent): pin comfy-multi-player 0.3.10 so the follower reads doc-host schema v5 - #20625
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
No changes needed for the CodeRabbit notice. It only says auto-review is skipped because this PR targets the This branch has already been reviewed separately (two independent reviewers, verdict PASS). The red/green repro and verification results are in the PR description. |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🎭 Playwright: ✅ 2156 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 646859f1d12930733557052c51a18be88ceeba0b
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-09T08:19:04.286Z",
"gitSha": "60dbac62ae583fd877e5db6937a953412296d19c",
"branch": "glary/cloud-1.55-multi-player-v5",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.7890000000161,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.249000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.086,
"heapDeltaBytes": 7143212,
"heapUsedBytes": 76024688,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.498999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1998.9550000000236,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.973999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.349,
"heapDeltaBytes": 7605332,
"heapUsedBytes": 76711004,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.617999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1715.3169999999704,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.696000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 752.566,
"heapDeltaBytes": 8240728,
"heapUsedBytes": 77204300,
"domNodes": -257,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 133.33700000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1692.6389999999856,
"styleRecalcs": 44,
"styleRecalcDurationMs": 11.608,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.946,
"heapDeltaBytes": -4540136,
"heapUsedBytes": 58486272,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 120.788,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.33300000001,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.609999999999998,
"layouts": 6,
"layoutDurationMs": 0.9630000000000001,
"taskDurationMs": 261.233,
"heapDeltaBytes": 3312992,
"heapUsedBytes": 72535284,
"domNodes": 79,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.335999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.3720000000912,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.379999999999997,
"layouts": 6,
"layoutDurationMs": 0.8989999999999999,
"taskDurationMs": 262.58000000000004,
"heapDeltaBytes": 3293764,
"heapUsedBytes": 72115628,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.828,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 555.9840000000236,
"styleRecalcs": 16,
"styleRecalcDurationMs": 9.743,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.21100000000007,
"heapDeltaBytes": 18280800,
"heapUsedBytes": 87243640,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 137.019,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 534.0079999999716,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.419,
"heapDeltaBytes": -7922900,
"heapUsedBytes": 61481568,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 130.005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1157.987999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 828.8860000000001,
"heapDeltaBytes": 25725720,
"heapUsedBytes": 97310300,
"domNodes": -292,
"jsHeapTotalBytes": 18239488,
"scriptDurationMs": 49.67200000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 521,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1044.565999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.448,
"heapDeltaBytes": 27274764,
"heapUsedBytes": 98843976,
"domNodes": -296,
"jsHeapTotalBytes": 18763776,
"scriptDurationMs": 47.53399999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 419,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 777.6660000000106,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.401,
"heapDeltaBytes": 15234932,
"heapUsedBytes": 92126712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 124.05,
"eventListeners": 0,
"totalBlockingTimeMs": 163,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.4260000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.0180000000001,
"heapDeltaBytes": 15125912,
"heapUsedBytes": 92346424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.18,
"eventListeners": 0,
"totalBlockingTimeMs": 157,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7382.138999999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6439.041,
"heapDeltaBytes": 12232580,
"heapUsedBytes": 93824992,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5330.539,
"eventListeners": 0,
"totalBlockingTimeMs": 69,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7889.885000000049,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.8480000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7051.693,
"heapDeltaBytes": 4002788,
"heapUsedBytes": 85455940,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 5686.455000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7607.662000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6707.467,
"heapDeltaBytes": 699932,
"heapUsedBytes": 82056588,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5396.161,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8081.855000000019,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8060000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7220.063999999999,
"heapDeltaBytes": 2609180,
"heapUsedBytes": 83078488,
"domNodes": -269,
"jsHeapTotalBytes": 17293312,
"scriptDurationMs": 5962.811000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2009.3129999999633,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.242000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.858,
"heapDeltaBytes": -23087956,
"heapUsedBytes": 67148344,
"domNodes": -248,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 29.182999999999993,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2005.9039999999868,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.485000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.1029999999999,
"heapDeltaBytes": 4179872,
"heapUsedBytes": 87690140,
"domNodes": -257,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 27.858999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2155.162999999959,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.387999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1308.109,
"heapDeltaBytes": 785520,
"heapUsedBytes": 91922712,
"domNodes": -245,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 670.9029999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2137.540999999942,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.692999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1259.434,
"heapDeltaBytes": 307068,
"heapUsedBytes": 91198288,
"domNodes": -251,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 643.5540000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3224.5300000000157,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.822,
"layouts": 60,
"layoutDurationMs": 12.921999999999999,
"taskDurationMs": 1396.685,
"heapDeltaBytes": -18277948,
"heapUsedBytes": 74195168,
"domNodes": -236,
"jsHeapTotalBytes": 5533696,
"scriptDurationMs": 653.842,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3168.9249999999447,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.145,
"layouts": 60,
"layoutDurationMs": 12.302999999999999,
"taskDurationMs": 1273.111,
"heapDeltaBytes": 105456,
"heapUsedBytes": 65851728,
"domNodes": 32,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 617.239,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2308.073000000036,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.011000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1511.2509999999997,
"heapDeltaBytes": -16443428,
"heapUsedBytes": 77475108,
"domNodes": 16,
"jsHeapTotalBytes": 6852608,
"scriptDurationMs": 800.4290000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2149.7940000000426,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.6850000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1444.994,
"heapDeltaBytes": 3608824,
"heapUsedBytes": 68530064,
"domNodes": -247,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 766.9649999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.6349999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.644999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.83700000000005,
"heapDeltaBytes": -24045492,
"heapUsedBytes": 66897620,
"domNodes": -250,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 29.380000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.1949999999679,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.540000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.0909999999999,
"heapDeltaBytes": -23082256,
"heapUsedBytes": 68619968,
"domNodes": -247,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 26.975999999999992,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 538.7329999999793,
"styleRecalcs": 50,
"styleRecalcDurationMs": 10.322999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.437,
"heapDeltaBytes": 13290872,
"heapUsedBytes": 84162832,
"domNodes": 25,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 121.107,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 509.53900000001795,
"styleRecalcs": 49,
"styleRecalcDurationMs": 9.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.249,
"heapDeltaBytes": 12938064,
"heapUsedBytes": 84209920,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 115.772,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.0490000000086,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.8330000000001,
"heapDeltaBytes": 10157292,
"heapUsedBytes": 80954808,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.100999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2008.8240000000042,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.211999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.70599999999996,
"heapDeltaBytes": -10254900,
"heapUsedBytes": 61129132,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.645000000000001,
"eventListeners": -230,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.5519999999874,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.044999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.0780000000001,
"heapDeltaBytes": -10897720,
"heapUsedBytes": 59985100,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 78.378,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.2280000000046,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.551,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.6600000000001,
"heapDeltaBytes": -10689944,
"heapUsedBytes": 59995164,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 76.053,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1300.5560000000287,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.172000000000004,
"layouts": 5,
"layoutDurationMs": 9.961999999999998,
"taskDurationMs": 785.4109999999998,
"heapDeltaBytes": -6330108,
"heapUsedBytes": 81701848,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 26.295999999999992,
"eventListeners": 2383,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8211.842999999988,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.98500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4405.772,
"heapDeltaBytes": -970688,
"heapUsedBytes": 89276836,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 2208.3019999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.635999999992,
"styleRecalcs": 252,
"styleRecalcDurationMs": 34.608,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4317.175,
"heapDeltaBytes": -1146556,
"heapUsedBytes": 89053988,
"domNodes": -233,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2168.603,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13870.300999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13675.837000000001,
"heapDeltaBytes": -56873256,
"heapUsedBytes": 182232404,
"domNodes": -8062,
"jsHeapTotalBytes": -20451328,
"scriptDurationMs": 188.946,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14005.78100000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13770.043000000001,
"heapDeltaBytes": -55689804,
"heapUsedBytes": 173182812,
"domNodes": -8062,
"jsHeapTotalBytes": -16556032,
"scriptDurationMs": 192.03900000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17127.71399999997,
"styleRecalcs": 127,
"styleRecalcDurationMs": 14.52400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16939.909,
"heapDeltaBytes": -52592836,
"heapUsedBytes": 190823432,
"domNodes": -8062,
"jsHeapTotalBytes": -21012480,
"scriptDurationMs": 728.993,
"eventListeners": -14928,
"totalBlockingTimeMs": 13,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16889.438999999926,
"styleRecalcs": 118,
"styleRecalcDurationMs": 13.376,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16546.935,
"heapDeltaBytes": -43895676,
"heapUsedBytes": 169573172,
"domNodes": -8062,
"jsHeapTotalBytes": -13352960,
"scriptDurationMs": 701.279,
"eventListeners": -14928,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4108.455000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.39599999999999,
"layouts": 20,
"layoutDurationMs": 28.202000000000005,
"taskDurationMs": 4069.909000000001,
"heapDeltaBytes": -35611096,
"heapUsedBytes": 178637196,
"domNodes": -8062,
"jsHeapTotalBytes": 13910016,
"scriptDurationMs": 67.655,
"eventListeners": -14928,
"totalBlockingTimeMs": 104,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5257.923000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.79199999999999,
"layouts": 20,
"layoutDurationMs": 23.248000000000005,
"taskDurationMs": 5241.136,
"heapDeltaBytes": -43992024,
"heapUsedBytes": 176870260,
"domNodes": -8062,
"jsHeapTotalBytes": 13303808,
"scriptDurationMs": 82.26700000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 284,
"frameDurationMs": 18.33666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7387.242000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7355.794,
"heapDeltaBytes": -2063784,
"heapUsedBytes": 174991428,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 106.96800000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7424.210000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7399.658999999998,
"heapDeltaBytes": -16175112,
"heapUsedBytes": 177576720,
"domNodes": 0,
"jsHeapTotalBytes": -34340864,
"scriptDurationMs": 109.61100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 463.3609999999635,
"styleRecalcs": 16,
"styleRecalcDurationMs": 24.117,
"layouts": 3,
"layoutDurationMs": 1.643,
"taskDurationMs": 192.882,
"heapDeltaBytes": 5148196,
"heapUsedBytes": 72138764,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.482,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 90.36700000001474,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.149999999999997,
"layouts": 3,
"layoutDurationMs": 1.154,
"taskDurationMs": 65.11799999999998,
"heapDeltaBytes": 2999052,
"heapUsedBytes": 65510688,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.598000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20625 +/- ##
=============================================
Coverage ? 84.18%
=============================================
Files ? 3121
Lines ? 154157
Branches ? 39773
=============================================
Hits ? 129781
Misses ? 22960
Partials ? 1416
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This is the only thing currently standing between prod and the agent co-editing breakage, and it needs one approval. Flagging that plainly because the reason it was filed as a fallback no longer holds. Why it is now the primary fix, not the fallback. Since the 10-08 release the doc host writes workflow schema v5, while prod's frontend on
What approving costs you. +59/-8, and the change is a version pin: comfy-multi-player 0.3.10 so the follower reads doc-host schema v5. CI is 101 successful, 9 skipped, 1 pending, and the PR is The risk of waiting is asymmetric: if the 1.56 canary is held or rolled back, this is the only path, and it is the path that was deliberately kept open for exactly that case. Added |
|
Agree this should land, and nothing in the diff needs to change. Two facts from the current branches matter for the approval. 1. My PR description is now out of date about 2. This PR is narrower than #20620. It carries only the version bump. It does not include the stale-schema reseed handshake (#19032 / #20264), and
If 1.56 ends up held for long, the full #20620 set is the better backport for 1.55. This PR is the smallest change that stops new sessions from rendering empty, and that is why it's worth approving now. Also: |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
| @@ -210,4 +210,3 @@ overrides: | |||
| # Transitional - drop each entry once that version is older than the release-age gate. | |||
| minimumReleaseAgeExclude: | |||
| - '@comfyorg/comfyui-desktop-bridge-types@0.2.0' | |||
There was a problem hiding this comment.
🟡 Medium — The @comfyorg/comfy-multi-player@0.3.6 release-age exemption is deleted while the catalog pin moves forward to 0.3.10, which was published strictly later and is therefore younger than the gate 0.3.6 needed the exemption for. The committed lockfile keeps --frozen-lockfile CI green, but any install that must re-resolve this dependency (Renovate, pnpm update, a lockfile merge conflict, --no-frozen-lockfile) will be refused until the window elapses. Retarget the entry to @comfyorg/comfy-multi-player@0.3.10 instead of removing it. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| zod-validation-error: ^3.3.0 | ||
| '@datadog/browser-logs': 6.33.0 | ||
| '@comfyorg/comfy-multi-player': 0.3.6 | ||
| '@comfyorg/comfy-multi-player': 0.3.10 |
There was a problem hiding this comment.
🟡 Medium — This pin supplies SCHEMA_VERSION, which schemaGuard.assertReadableSchema compares by strict equality and fails closed on, and the new fixture shows 0.3.10 mints schema_version=5. Because the frontend and the cloud doc-host deploy independently, any window where their pins disagree (frontend rolled out first, or a cached client after the doc-host moves) makes the bridge reject every doc_update and agent canvas sync stops silently. Confirm the doc-host is already on 0.3.10 and note the required deploy ordering, since there is no backward-tolerant read path. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| * doc-host pins (Comfy-Org/cloud services/agent/dochost/package.json). | ||
| * Regenerate with that exact version whenever the doc-host pin moves. | ||
| */ | ||
| export const DOC_HOST_MULTI_PLAYER_VERSION = '0.3.10' |
There was a problem hiding this comment.
🟢 Low — DOC_HOST_MULTI_PLAYER_VERSION is only interpolated into the it() title; nothing compares it to the installed @comfyorg/comfy-multi-player version or to the opaque base64 bytes below it, and there is no script that regenerates or verifies the blob. If the pin or the fixture is refreshed without the other, the suite keeps passing while advertising a version it no longer exercises — exactly the drift this fixture exists to catch. Assert the constant against the package's real version (or against the schema_version read from the decoded doc) so a stale fixture fails loudly. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
|
@dante01yoon assigning you because this is the live fix for prod agent co-editing and it had no reviewer at all. One approval lands it. What it is: a one-line version pin on Why it is urgent rather than routine: since the 10-08 release the doc host writes schema v5 while prod's frontend reads v4 and refuses agent documents, so sessions show an empty canvas. The plan was to fix prod by promoting Going to Dario rather than Alex purely to avoid a queue: DrJKL already received a batch of review asks at 00:42Z, and this one should not sit behind them. If you would rather it went to him, say so and I will move it. |
|
@dante01yoon, this needs no code changes. If it helps your review, here is where to look:
|
…d bytes The v0.448+ empty-canvas regression (PM-2052, consolidating PM-2046 and PM-2047) shipped because no test in the tree could see host/client skew: every follower test mints its document with the same comfy-multi-player the follower compiles against, so writer and reader are the same build by construction. #20625 fixed that with a checked-in document minted by the doc-host's own package version -- but only on `cloud/1.55`. `main`, `cloud/1.56` (the line production is promoted from) and `core/1.56` never got it. This ports the fixture and the integration case to `main`, so the branch every release branch is cut from carries the pin. Red at catalog 0.3.6 (the reader users were served during the incident): `expected undefined to be 'Sink'`, preceded by the KA-11 refusal. Green at 0.3.10, which is both current `main` and the served production pin d27dab0. Holding the bytes constant is the point: the case fails if this build's reader and the doc-host's writer disagree again in either direction. A mint() call here would pass unconditionally. Test only; no production code changes.
…d bytes (#20758) ## Summary The v0.448+ empty-canvas regression ([PM-2052](https://linear.app/comfyorg/issue/PM-2052), consolidating PM-2046, PM-2047 and eight Typeform reports) shipped because **no test in this repository could see host/client document-schema skew.** Every follower test mints its document with the same `@comfyorg/comfy-multi-player` the follower compiles against, so the writer and the reader are the same build by construction. Cloud moved the doc-host to document schema v5 while the frontend builds users were served still read v4. `assertReadableSchema` (KA-11) is exact-equality, so the follower refused every document the host minted: the server committed and validated normally and the canvas stayed empty. Turns where the previous turn ended with nodes and the next began empty went from a 0.48%–1.76% baseline to roughly one in four. #20625 fixed the blind spot with a checked-in document minted by the **doc-host's own** package version — but only on `cloud/1.55`. `main`, `cloud/1.56` (the line production was actually promoted from) and `core/1.56` never got it: ``` origin/main (absent) origin/cloud/1.56 (absent) ← production is promoted from here origin/cloud/1.55 src/.../__fixtures__/docHostMintedSink.ts origin/core/1.56 (absent) ``` This ports the fixture and the integration case to `main`, so the branch every release branch is cut from carries the pin. **Test only. No production code changes.** The catalog pin is untouched — `main` is already on 0.3.10. ### Why the bytes are checked in rather than `mint()`-ed That is the whole point of the case. Holding the document constant makes the assertion fail if this build's reader and the doc-host's writer ever disagree again, in **either** direction. A `mint()` call here would pass unconditionally, which is exactly the property that let the regression through. The fixture header says so, names the doc-host pin it was generated under, and states that the catalog pin and these bytes are a lockstep pair. ## Verification Measured in a worktree off `origin/main`, `vitest run src/workbench/extensions/agent/crdt/useAgentCrdtFollower.integration.test.ts`: - **Red** at catalog `0.3.6`, the reader users were served during the incident — `AssertionError: expected undefined to be 'Sink'`, preceded by the KA-11 refusal `doc meta.schema_version is not the layout this build reads`. The pre-existing case in the same file still passes, so the failure is the new assertion and not a broken suite. This is the production failure. - **Green** at catalog `0.3.10` — 2 passed. That is current `main` and also the pin on the revision production serves, `d27dab0457808b3437fffa819df5f587bf3ae785` (`cloud/v1.56.3`), confirmed against the live served header. Pre-commit gates green: `oxfmt`, `oxlint --type-aware`, `eslint`, `lint:server-facts`, `typecheck:app`. ## Notes for reviewers - A `cloud/1.56` backport is a clean one-file cherry-pick if the release owner wants the regression pin on the served line too. It carries the correct runtime pin already; it just has no test that would notice if that changed. - Regenerating: run `Y.encodeStateAsUpdate(mint({ nodes: [{ id: 99, type: 'Sink' }], links: [] }, { types: {} }))` under the version `Comfy-Org/cloud` `services/agent/dochost/package.json` pins, and move the catalog pin in the same change. - Separately open and still needed: #20702 makes the refusal visible to the user instead of silent. This PR pins the mechanism; that one covers the symptom.
PR Created by the Glary-Bot Agent
Summary
Prod Comfy Agent users get an empty canvas while the agent reports it built the workflow. This adds a test that reproduces that and backports the pin half of #20096 to
cloud/1.55, which is the branch prod serves (1.55.18 @7774606).Root cause
comfy-multi-player@0.3.10, which uses schema v5.main. Bothcloud/1.55andcloud/1.56still pin 0.3.6, which uses schema v4.assertReadableSchema, KA-11) is exact-equality. It therefore refuses every document the prod doc-host now mints.schema_errorwith no toast and no latch. This is the "shape 2: silent" case described in chore(deps): pin @comfyorg/comfy-multi-player 0.3.10, with the browser proof of what it fixes (FE-3036) #20096.Changes
pnpm-workspace.yaml/pnpm-lock.yaml: catalog pin 0.3.6 → 0.3.10, and the now-unused 0.3.6minimumReleaseAgeExcludeentry is dropped. The lockfile hunks are identical to chore(deps): pin @comfyorg/comfy-multi-player 0.3.10, with the browser proof of what it fixes (FE-3036) #20096 onmain, including the integrity hash.__fixtures__/docHostMintedSink.ts: realmint()bytes produced by 0.3.10, the doc-host's pin, not by the package the follower compiles against. Every existing test mints with the follower's own package, so none of them can see host/client skew.useAgentCrdtFollower.integration.test.ts: deliversdoc_subscribedand adoc_updatecarrying those bytes, then asserts the node lands on the liveLGraph.Red / green
expected undefined to be 'Sink', preceded by the KA-11 assertiondoc meta.schema_version is not the layout this build reads. This is the prod failure.Verification
vitest run src/workbench/extensions/agent: 2654 passed, 2 expected fail, 1 failure.agentSubgraphDefinitions.test.ts› "scans deeply nested definition ids…", a lib0deepFreezestack overflow.cloud/1.55at 0.3.6, so it is pre-existing. yjs and lib0 are unchanged here.pnpm typecheck: exit 0. Pre-commit hooks (oxfmt, oxlint, eslint, typecheck:app) pass.Notes for reviewers
cloud/1.55does not have fix(widgets): refuse a widget that cannot be given a unique name (FE-3036) #20087 or occurrence-key decoding.\0widget-occurrence:[...]) is not resolved byliveGraphApplier, so the live widget shows occurrence 0's value. A later sync may send one error-levelagent_graph_widget_missingreport per node and key.cloud/1.56has the same 0.3.6 pin and needs the same backport before it ships.schema_errorraises no user-facing error, anddoc_subscribecarries no schema version, so the host can't refuse up front. That is worth its own fix onmain.