Repository navigation
feat(agent): report the client's comfy-multi-player schema version on doc_subscribe - #20623
christian-byrne wants to merge 2 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f9be289d9b15dd19df1326004a382d1fff624cb9
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.36 MB gzip 🔴 +2 BDetailsSummary
Category Glance App Entry Points — 4.56 kB (baseline 4.56 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 154 kB (baseline 154 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 19 unchanged Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 30 unchanged User & Accounts — 54.6 kB (baseline 54.6 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 339 kB (baseline 339 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 13 unchanged UI Components — 201 kB (baseline 201 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 3.06 MB (baseline 3.06 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 819 kB (baseline 819 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 53 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.8 MB (baseline 18.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 346 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T08:01:29.665Z",
"gitSha": "2c7986cb02f8393a0fd1734ae6bdd59f928b0d02",
"branch": "glary/doc-subscribe-schema-version",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.7079999999846,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.787999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.225,
"heapDeltaBytes": 5523864,
"heapUsedBytes": 61951616,
"domNodes": -215,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.260000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2020.4590000000735,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.902,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.54,
"heapDeltaBytes": 5534300,
"heapUsedBytes": 62078104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.189999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.8910000000346,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.274,
"layouts": 12,
"layoutDurationMs": 3.05,
"taskDurationMs": 825.4240000000001,
"heapDeltaBytes": -17866536,
"heapUsedBytes": 83138884,
"domNodes": -217,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 146.594,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1723.3830000000125,
"styleRecalcs": 54,
"styleRecalcDurationMs": 13.283999999999999,
"layouts": 12,
"layoutDurationMs": 3.179,
"taskDurationMs": 767.479,
"heapDeltaBytes": 910808,
"heapUsedBytes": 57428252,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 147.435,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.7069999999944,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.3709999999999996,
"layouts": 3,
"layoutDurationMs": 0.6460000000000001,
"taskDurationMs": 414.74000000000007,
"heapDeltaBytes": 6411660,
"heapUsedBytes": 63401824,
"domNodes": 47,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.317000000000004,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.054999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 7.041000000000002,
"layouts": 3,
"layoutDurationMs": 0.9119999999999998,
"taskDurationMs": 426.202,
"heapDeltaBytes": 6429272,
"heapUsedBytes": 63420744,
"domNodes": 47,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.037999999999998,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.1029999999964,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.0950000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.85600000000005,
"heapDeltaBytes": 18537248,
"heapUsedBytes": 75161372,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.39,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 587.472000000048,
"styleRecalcs": 16,
"styleRecalcDurationMs": 4.233,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.774,
"heapDeltaBytes": 1145696,
"heapUsedBytes": 101748416,
"domNodes": 0,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 164.57300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1129.4689999999719,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.5450000000001,
"heapDeltaBytes": 18771708,
"heapUsedBytes": 93881480,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 65.322,
"eventListeners": 0,
"totalBlockingTimeMs": 505,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1260.5839999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 935.98,
"heapDeltaBytes": 13249472,
"heapUsedBytes": 96721192,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 72.165,
"eventListeners": 0,
"totalBlockingTimeMs": 641,
"frameDurationMs": 37.25588235294117,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.0070000000237,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.79300000000023,
"heapDeltaBytes": 20302912,
"heapUsedBytes": 98621416,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.35500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.9669999999123,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.2589999999999,
"heapDeltaBytes": -7348552,
"heapUsedBytes": 83255800,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 170.04900000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9848.768000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8977.983,
"heapDeltaBytes": 12847252,
"heapUsedBytes": 95561200,
"domNodes": 0,
"jsHeapTotalBytes": -17563648,
"scriptDurationMs": 7322.173,
"eventListeners": 0,
"totalBlockingTimeMs": 737,
"frameDurationMs": 31.772903225806452,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10259.67700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9443.999,
"heapDeltaBytes": 13164976,
"heapUsedBytes": 96324596,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 7781.602999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1045,
"frameDurationMs": 31.24878048780488,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9074.210999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8325.855000000001,
"heapDeltaBytes": 2233284,
"heapUsedBytes": 85596320,
"domNodes": 0,
"jsHeapTotalBytes": -20971520,
"scriptDurationMs": 6752.194,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 31.811578947368425,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9959.418000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9114.288,
"heapDeltaBytes": -12667392,
"heapUsedBytes": 70298088,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 7390.548,
"eventListeners": 0,
"totalBlockingTimeMs": 853,
"frameDurationMs": 30.89937888198758,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 196.62599999998065,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.772000000000002,
"layouts": 5,
"layoutDurationMs": 1.602,
"taskDurationMs": 156.20399999999998,
"heapDeltaBytes": 12145280,
"heapUsedBytes": 77076044,
"domNodes": 918,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.272000000000002,
"eventListeners": 202,
"totalBlockingTimeMs": 3,
"frameDurationMs": 25,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 225.32699999999295,
"styleRecalcs": 25,
"styleRecalcDurationMs": 18.161,
"layouts": 5,
"layoutDurationMs": 1.6900000000000002,
"taskDurationMs": 166.049,
"heapDeltaBytes": 12048876,
"heapUsedBytes": 77481816,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.123,
"eventListeners": 202,
"totalBlockingTimeMs": 3,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2045.4149999999913,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.575,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.7860000000001,
"heapDeltaBytes": -40357916,
"heapUsedBytes": 85409052,
"domNodes": -314,
"jsHeapTotalBytes": -5079040,
"scriptDurationMs": 36.407999999999994,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2061.853000000042,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.508,
"heapDeltaBytes": -40981892,
"heapUsedBytes": 85434784,
"domNodes": -313,
"jsHeapTotalBytes": -4816896,
"scriptDurationMs": 40.037,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2298.0459999999994,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1588.645,
"heapDeltaBytes": 20415588,
"heapUsedBytes": 85618608,
"domNodes": -313,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 809.5559999999999,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.788970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2158.5959999999886,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.195999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1398.924,
"heapDeltaBytes": -49919692,
"heapUsedBytes": 82506400,
"domNodes": -333,
"jsHeapTotalBytes": -3018752,
"scriptDurationMs": 774.4720000000001,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.795348837209303,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3664.152999999999,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.546,
"layouts": 60,
"layoutDurationMs": 9.623,
"taskDurationMs": 1697.4300000000003,
"heapDeltaBytes": 9277172,
"heapUsedBytes": 75785836,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.242,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666210045662098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3545.4280000000153,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.474000000000001,
"layouts": 60,
"layoutDurationMs": 9.520000000000001,
"taskDurationMs": 1674.149,
"heapDeltaBytes": 7912224,
"heapUsedBytes": 74964636,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 763.9639999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2838.212999999996,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1710.0040000000001,
"heapDeltaBytes": 17368696,
"heapUsedBytes": 84943460,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 963.415,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76449704142012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2839.4759999999906,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.294,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1834.2030000000002,
"heapDeltaBytes": 17391048,
"heapUsedBytes": 84970336,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 926.0269999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.864285714285714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.82999999998,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.1639999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.5030000000002,
"heapDeltaBytes": 20790560,
"heapUsedBytes": 86470524,
"domNodes": -183,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.268,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.3389999999226,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.63,
"heapDeltaBytes": -41961188,
"heapUsedBytes": 84991068,
"domNodes": -313,
"jsHeapTotalBytes": -4030464,
"scriptDurationMs": 45.91100000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 615.8810000000017,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.902999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.528,
"heapDeltaBytes": -32479512,
"heapUsedBytes": 67810548,
"domNodes": -235,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 148.25199999999998,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 563.7970000000223,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.760999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.60900000000004,
"heapDeltaBytes": -32623828,
"heapUsedBytes": 68533736,
"domNodes": -235,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 142.871,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636353,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.4930000000304,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.5589999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.27400000000006,
"heapDeltaBytes": 5487204,
"heapUsedBytes": 62835456,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.833999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2025.8199999999533,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.1979999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.572,
"heapDeltaBytes": 5552032,
"heapUsedBytes": 62600492,
"domNodes": -235,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.897000000000001,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.129999999992,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.600999999999999,
"layouts": 16,
"layoutDurationMs": 3.6020000000000003,
"taskDurationMs": 816.875,
"heapDeltaBytes": 23794356,
"heapUsedBytes": 81131556,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.38300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.7720000000572,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.147000000000002,
"layouts": 16,
"layoutDurationMs": 3.9130000000000007,
"taskDurationMs": 738.795,
"heapDeltaBytes": 23894644,
"heapUsedBytes": 80765716,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.22799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.8639999999086,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.999000000000002,
"layouts": 5,
"layoutDurationMs": 16.39,
"taskDurationMs": 937.9719999999998,
"heapDeltaBytes": 33936088,
"heapUsedBytes": 113119332,
"domNodes": 14650,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 30.636999999999997,
"eventListeners": 2456,
"totalBlockingTimeMs": 129,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8750.658999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5664.4220000000005,
"heapDeltaBytes": -43905960,
"heapUsedBytes": 81338936,
"domNodes": -314,
"jsHeapTotalBytes": -5672960,
"scriptDurationMs": 2632.2720000000004,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666030534351144,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8821.149999999989,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.306000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5625.4529999999995,
"heapDeltaBytes": 21211444,
"heapUsedBytes": 85669972,
"domNodes": -313,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2650.952,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18736.549999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17898.942,
"heapDeltaBytes": -35841944,
"heapUsedBytes": 183299884,
"domNodes": -3047,
"jsHeapTotalBytes": 4100096,
"scriptDurationMs": 285.561,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.858333333333334,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 14233.996000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13120.024000000001,
"heapDeltaBytes": -29892072,
"heapUsedBytes": 189602308,
"domNodes": -3046,
"jsHeapTotalBytes": 12226560,
"scriptDurationMs": 232.12199999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.96060606060606,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 16456.28599999998,
"styleRecalcs": 99,
"styleRecalcDurationMs": 9.180000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15981.951000000003,
"heapDeltaBytes": -25615260,
"heapUsedBytes": 190677388,
"domNodes": -3046,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 819.8209999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 6,
"frameDurationMs": 29.01866197183099,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 17031.45900000004,
"styleRecalcs": 133,
"styleRecalcDurationMs": 11.747000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16620.170000000002,
"heapDeltaBytes": -30091740,
"heapUsedBytes": 189974984,
"domNodes": -3046,
"jsHeapTotalBytes": 7274496,
"scriptDurationMs": 831.4789999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 25,
"frameDurationMs": 30.942468239564427,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 6576.326999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.35600000000004,
"layouts": 20,
"layoutDurationMs": 22.01800000000001,
"taskDurationMs": 6460.117,
"heapDeltaBytes": 15535848,
"heapUsedBytes": 214806428,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 108.142,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.08571428571428,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6672.446000000036,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.96499999999997,
"layouts": 20,
"layoutDurationMs": 22.308000000000007,
"taskDurationMs": 6533.307,
"heapDeltaBytes": -10397300,
"heapUsedBytes": 214888884,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 112.533,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.093714285714285,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9705.637999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9396.074999999999,
"heapDeltaBytes": -30108000,
"heapUsedBytes": 185077572,
"domNodes": -3046,
"jsHeapTotalBytes": 7888896,
"scriptDurationMs": 174.08599999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.5489932885906,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9423.010999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9030.473999999998,
"heapDeltaBytes": -30195252,
"heapUsedBytes": 184672800,
"domNodes": -3046,
"jsHeapTotalBytes": 8658944,
"scriptDurationMs": 180.678,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.976271186440677,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 517.2980000000962,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.889000000000003,
"layouts": 3,
"layoutDurationMs": 0.77,
"taskDurationMs": 178.64500000000004,
"heapDeltaBytes": -38141288,
"heapUsedBytes": 59287400,
"domNodes": -88,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 11.544,
"eventListeners": -52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 470.8610000000135,
"styleRecalcs": 20,
"styleRecalcDurationMs": 14.123999999999999,
"layouts": 3,
"layoutDurationMs": 1.313,
"taskDurationMs": 116.35599999999998,
"heapDeltaBytes": 6458744,
"heapUsedBytes": 62755288,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.925,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 861.2860000000637,
"styleRecalcs": 77,
"styleRecalcDurationMs": 91.794,
"layouts": 76,
"layoutDurationMs": 17.616,
"taskDurationMs": 834.3629999999999,
"heapDeltaBytes": -8464928,
"heapUsedBytes": 68747892,
"domNodes": 77,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 346.04699999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 833.3400000000211,
"styleRecalcs": 77,
"styleRecalcDurationMs": 89.75,
"layouts": 76,
"layoutDurationMs": 17.017999999999997,
"taskDurationMs": 804.857,
"heapDeltaBytes": 17559272,
"heapUsedBytes": 94133516,
"domNodes": 77,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 327.99100000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1461.0450000000128,
"styleRecalcs": 77,
"styleRecalcDurationMs": 249.752,
"layouts": 76,
"layoutDurationMs": 19.206999999999997,
"taskDurationMs": 1432.292,
"heapDeltaBytes": -19313208,
"heapUsedBytes": 116920480,
"domNodes": 77,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 513.824,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.125,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1451.5650000000733,
"styleRecalcs": 77,
"styleRecalcDurationMs": 253.59599999999998,
"layouts": 76,
"layoutDurationMs": 19.954,
"taskDurationMs": 1422.1699999999998,
"heapDeltaBytes": 10377644,
"heapUsedBytes": 125547216,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 499.44899999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.901234567901245,
"p95FrameDurationMs": 33.29999999999927
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2247 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
@coderabbitai This comment is only the "review in progress" placeholder, so it has no findings yet and I haven't changed anything. I'll address any inline findings once the review of |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20623 +/- ##
==========================================
+ Coverage 85.90% 86.75% +0.84%
==========================================
Files 3602 2548 -1054
Lines 172505 144245 -28260
Branches 45533 37512 -8021
==========================================
- Hits 148195 125142 -23053
+ Misses 22291 18716 -3575
+ Partials 2019 387 -1632
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1076 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Thanks @thedatalife. The approval has no inline comments or review body, and the PR is already merged into Next step is to ship
|
PR Created by the Glary-Bot Agent
Why
Prod has been running mismatched comfy-multi-player document schemas, and nothing noticed:
cloud/1.55) ships@comfyorg/comfy-multi-player0.3.6 (schema v4).As a result, the CRDT follower has refused every agent document since 2026-10-08. The only signal was a RUM assert: 88 errors across 59 sessions in 48 hours. That assert is reported to Sentry and isn't alerted on.
What
doc_subscribenow carriesschema_version: SCHEMA_VERSION. That's the package's public constant, and the follower's read gate (schemaGuard.ts) checks against the same value. A backend can therefore compare the schema this build reads with its doc host's schema at the first subscribe. Every subscribe path, including reconnects and resubscribes after a reseed, goes throughDocFrameClient.subscribe(), so all of them carry the field.json.Unmarshal, and nothing else about the frame changes.glary/multiplayer-schema-skew-gates) adds the field toDocSubscribeFrame, relays it through ingest, and has the agent emitcomfy.agent.doc.client_schema_skew. Until it ships, this field is sent but dropped.Related PRs in this incident
cloud/1.56.Testing
vitestdocFrameClient*: 133 tests pass. The frame assertions now includeschema_version.pnpm typecheckpasses. ESLint: 0 errors (2 pre-existing warnings).oxfmt --checkis clean.deep-reviewer: PASS.