Repository navigation
[backport cloud/1.55] fix(agent): report upload failure cause, file type and size for attachment telemetry - #20429
Conversation
…hment telemetry (#20405) ## Summary - The agent composer's attachment upload has two error paths (direct upload, deferred drag/paste fetch) that each used a bare `catch {}`, discarding the real thrown error before reporting a synthetic, context-free `Error('Agent attachment upload failed')`. - That's why the Sentry alert for PM-1997 carries zero diagnostic detail — no HTTP status, failure shape, file type, or size — nothing to distinguish a size rejection from an auth refusal from a transport failure. - This PR binds the caught error, classifies it into a bounded `upload_failure_cause` tag (`http_<status>`, `unreadable_response`, `timeout`, `aborted`, `unknown`), and adds `file_type`/`file_size_bytes` tags to the existing `reportError()` call. - The original error's message/stack are still never reported (an existing test guards against a dropped file's local path leaking into telemetry) — only the file's own declared, bounded metadata and a closed-set failure-shape tag are added. ## Why PM-1997 is a one-line Sentry relay from `cloud-frontend-prod` with no repro steps, file name, MIME type, size, or HTTP status — nothing to build a targeted fix from. Per the project's standing telemetry-first triage pattern (see PM-1802 / #20046), this PR adds the missing structured context at the failure site instead of guessing at a fix, so the alert is actionable once fresh occurrences land. ## Test plan - [x] Added test cases asserting `upload_failure_cause` resolves correctly for `AgentApiError` (HTTP status), `AgentResponseUnreadableError`, a timeout, and an unrecognized error shape. - [x] Updated the existing privacy-preserving test (reported error must never leak a dropped file's local path) to assert the new bounded tags are present. - [x] `pnpm vitest run src/workbench/extensions/agent/composables/agent/` — 401/401 passing, no regressions. - [x] `pnpm typecheck:app` — clean. - [x] `eslint` / `oxlint` on changed files — clean. Linear: PM-1997
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2155 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d90610a154d4410c78df2dbe71a45986228edd37
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-07T16:23:44.659Z",
"gitSha": "02160af8616364b42681714d0cad60e9df8278ad",
"branch": "backport-20405-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.0189999999611,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.148,
"heapDeltaBytes": 9369172,
"heapUsedBytes": 78529216,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.05,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1990.007999999989,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.331,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.951,
"heapDeltaBytes": 8570996,
"heapUsedBytes": 77843740,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.684,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.4780000000046,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.178999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 683.819,
"heapDeltaBytes": 11211092,
"heapUsedBytes": 79907100,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 121.425,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.4949999999608,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.068,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 722.012,
"heapDeltaBytes": 10708136,
"heapUsedBytes": 79911764,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 133.742,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.2850000000267,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.984,
"layouts": 6,
"layoutDurationMs": 0.9710000000000001,
"taskDurationMs": 312.709,
"heapDeltaBytes": 3341352,
"heapUsedBytes": 72120820,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.226999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.5570000000516,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.735,
"layouts": 6,
"layoutDurationMs": 1.0379999999999998,
"taskDurationMs": 323.623,
"heapDeltaBytes": 3631352,
"heapUsedBytes": 72808736,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.113999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 549.3710000000078,
"styleRecalcs": 14,
"styleRecalcDurationMs": 10.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.382,
"heapDeltaBytes": 18190960,
"heapUsedBytes": 87126416,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 136.49099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 554.5499999999493,
"styleRecalcs": 16,
"styleRecalcDurationMs": 9.902000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.423,
"heapDeltaBytes": -7963992,
"heapUsedBytes": 61294060,
"domNodes": 24,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 140.768,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1064.9010000000203,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 779.5960000000001,
"heapDeltaBytes": -15015972,
"heapUsedBytes": 73184544,
"domNodes": -295,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 55.324,
"eventListeners": -217,
"totalBlockingTimeMs": 417,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1106.2130000000252,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 774.6359999999999,
"heapDeltaBytes": 28298688,
"heapUsedBytes": 99813884,
"domNodes": -295,
"jsHeapTotalBytes": 18239488,
"scriptDurationMs": 51.067,
"eventListeners": -217,
"totalBlockingTimeMs": 470,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 776.0439999999562,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.77600000000024,
"heapDeltaBytes": 15285128,
"heapUsedBytes": 92441396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 119.78999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 781.3450000001012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.01100000000025,
"heapDeltaBytes": 14865636,
"heapUsedBytes": 90751892,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.35199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7732.602999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6795.648,
"heapDeltaBytes": -8476908,
"heapUsedBytes": 73355092,
"domNodes": -20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5488.34,
"eventListeners": 0,
"totalBlockingTimeMs": 40,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7942.904999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7123.263,
"heapDeltaBytes": 2045496,
"heapUsedBytes": 84061416,
"domNodes": -16,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 5845.0509999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 73,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7993.8500000000095,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8770000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7035.932,
"heapDeltaBytes": 6425648,
"heapUsedBytes": 86169228,
"domNodes": -263,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 5672.3949999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 138,
"frameDurationMs": 18.33666666666668,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7256.132999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6474.581999999999,
"heapDeltaBytes": -8182420,
"heapUsedBytes": 73773232,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 5424.925,
"eventListeners": 0,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2031.499999999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.738999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.57300000000004,
"heapDeltaBytes": -16710084,
"heapUsedBytes": 73564892,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.925000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2023.949000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.641,
"heapDeltaBytes": -23166108,
"heapUsedBytes": 66593152,
"domNodes": -253,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 39.415000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2165.9070000000042,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.168999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1357.983,
"heapDeltaBytes": 712452,
"heapUsedBytes": 65111964,
"domNodes": -247,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 701.692,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2114.213999999947,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.495,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.3519999999999,
"heapDeltaBytes": -24341200,
"heapUsedBytes": 66470932,
"domNodes": -242,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 712.138,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3271.1630000000014,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.771999999999998,
"layouts": 60,
"layoutDurationMs": 14.150999999999998,
"taskDurationMs": 1499.628,
"heapDeltaBytes": -15718140,
"heapUsedBytes": 76572068,
"domNodes": -242,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 676.037,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3292.2210000000405,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.075999999999999,
"layouts": 60,
"layoutDurationMs": 13.687999999999999,
"taskDurationMs": 1468.7620000000002,
"heapDeltaBytes": 81704,
"heapUsedBytes": 65825468,
"domNodes": 34,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 687.038,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2487.601999999981,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.14,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1684.513,
"heapDeltaBytes": -16261628,
"heapUsedBytes": 78196032,
"domNodes": 16,
"jsHeapTotalBytes": 6852608,
"scriptDurationMs": 866.743,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2434.2570000000023,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.727000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.8819999999998,
"heapDeltaBytes": 3292956,
"heapUsedBytes": 69127728,
"domNodes": 10,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 837.669,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.4110000000196,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.837999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.67800000000005,
"heapDeltaBytes": -17418272,
"heapUsedBytes": 74044444,
"domNodes": -239,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.037,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.257000000025,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.595000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.068,
"heapDeltaBytes": -23780396,
"heapUsedBytes": 68491528,
"domNodes": -253,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 34.16,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.8909999999773,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.2,
"heapDeltaBytes": 13541272,
"heapUsedBytes": 84549088,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 119.38399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.1009999999897,
"styleRecalcs": 49,
"styleRecalcDurationMs": 18.202999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.5019999999999,
"heapDeltaBytes": 13971448,
"heapUsedBytes": 84516228,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 130.658,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.9059999999954,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.399999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.326,
"heapDeltaBytes": -12486908,
"heapUsedBytes": 58903888,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.001000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.4080000000076,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.563000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.70799999999997,
"heapDeltaBytes": 8569220,
"heapUsedBytes": 79740336,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.092,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.9630000000257,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.443000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.828,
"heapDeltaBytes": 4904916,
"heapUsedBytes": 76093396,
"domNodes": -273,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 91.41199999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.6550000000398,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.202,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.3839999999999,
"heapDeltaBytes": -10248292,
"heapUsedBytes": 60603408,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 89.96,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1264.9450000000115,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.166000000000007,
"layouts": 5,
"layoutDurationMs": 10.598999999999998,
"taskDurationMs": 800.233,
"heapDeltaBytes": 20259988,
"heapUsedBytes": 104282096,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 27.128,
"eventListeners": 2383,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8253.187999999966,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.631,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4660.62,
"heapDeltaBytes": 2400256,
"heapUsedBytes": 92338792,
"domNodes": -237,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2283.5340000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8213.236000000052,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.058,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4933.959,
"heapDeltaBytes": -4826316,
"heapUsedBytes": 85364228,
"domNodes": -248,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 2373.664,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14703.968999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14580.252999999999,
"heapDeltaBytes": -60368756,
"heapUsedBytes": 180239528,
"domNodes": -8061,
"jsHeapTotalBytes": -14397440,
"scriptDurationMs": 217.696,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14858.100999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14708.670999999998,
"heapDeltaBytes": -50878560,
"heapUsedBytes": 178308740,
"domNodes": -8062,
"jsHeapTotalBytes": -20021248,
"scriptDurationMs": 221.89999999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17437.89400000003,
"styleRecalcs": 121,
"styleRecalcDurationMs": 16.485,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17343.99,
"heapDeltaBytes": -61697048,
"heapUsedBytes": 179501944,
"domNodes": -8065,
"jsHeapTotalBytes": -20717568,
"scriptDurationMs": 778.632,
"eventListeners": -14928,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17515.228000000094,
"styleRecalcs": 126,
"styleRecalcDurationMs": 16.570999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17438.837,
"heapDeltaBytes": -57001372,
"heapUsedBytes": 169756176,
"domNodes": -8061,
"jsHeapTotalBytes": -18067456,
"scriptDurationMs": 737.9219999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5529.5509999999695,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.24399999999999,
"layouts": 20,
"layoutDurationMs": 25.062999999999988,
"taskDurationMs": 5467.518,
"heapDeltaBytes": -64689816,
"heapUsedBytes": 178151908,
"domNodes": -8062,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 99.459,
"eventListeners": -14928,
"totalBlockingTimeMs": 254,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5422.923999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.53399999999998,
"layouts": 20,
"layoutDurationMs": 23.014999999999993,
"taskDurationMs": 5402.996,
"heapDeltaBytes": -30106536,
"heapUsedBytes": 187118280,
"domNodes": -8062,
"jsHeapTotalBytes": 15757312,
"scriptDurationMs": 88.695,
"eventListeners": -14928,
"totalBlockingTimeMs": 278,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7335.995000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7316.3160000000025,
"heapDeltaBytes": 24291056,
"heapUsedBytes": 193133552,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 99.96699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7380.133000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7345.279999999999,
"heapDeltaBytes": 4420820,
"heapUsedBytes": 184974384,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 107.76599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 105.78299999997398,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.196,
"layouts": 6,
"layoutDurationMs": 2.513,
"taskDurationMs": 85.52200000000002,
"heapDeltaBytes": 3315848,
"heapUsedBytes": 70391368,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.288,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 94.36200000004646,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.479,
"layouts": 3,
"layoutDurationMs": 1.533,
"taskDurationMs": 73.519,
"heapDeltaBytes": 3111324,
"heapUsedBytes": 65698660,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.583,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #20429 +/- ##
=============================================
Coverage ? 84.99%
=============================================
Files ? 2343
Lines ? 134489
Branches ? 34085
=============================================
Hits ? 114315
Misses ? 19811
Partials ? 363
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #20405, with identical hunks in all three files.
I compared against #20405's merge commit 8066b642461d456a3d74583a292e4b92315b83ad. useAttachment.ts, useAttachment.test.ts and AgentPanelRoot.test.ts carry exactly the source's added and removed lines. No adaptation was needed.
Checks: useAttachment.test.ts and AgentPanelRoot.test.ts pass locally at this head (388 tests). Hosted CI at 901b72c is fully green, including lint-and-format, typecheck, test and e2e-status.
Backport of #20405 to
cloud/1.55Automatically created by backport workflow.