Repository navigation
fix(agent): report backend detail and credential kind on auth rejection - #20177
Conversation
Keep the stable Sentry message for agent 401/403 rejections but add the credential kind sent (session cookie, bearer, api key, none), the backend error type/code, the accepted auth methods and a bounded, scrubbed copy of the backend text, so the next event shows whether the request was cookie-only, had no token, or carried the wrong credential.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c5985fbfe89b47043cb4779dd133bf66ed284c78
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.3 MB gzip 🔴 +173 BDetailsSummary
Category Glance App Entry Points — 4.17 kB (baseline 4.17 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 143 kB (baseline 143 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 678 kB (baseline 678 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 18 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 2 unchanged UI Components — 203 kB (baseline 203 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed / 11 unchanged Data & Services — 4.2 MB (baseline 4.2 MB) • 🔴 +892 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 584 kB (baseline 584 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 21 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.6 MB (baseline 18.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 81 added / 81 removed / 237 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T16:51:35.145Z",
"gitSha": "a6d0648db541fe87d518fcc60530242442f42eb2",
"branch": "fix/agent-auth-rejection-diagnostics",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2014.6879999999783,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.8579999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 300.77600000000007,
"heapDeltaBytes": 2618632,
"heapUsedBytes": 59254492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.5340000000000025,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.737000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9939999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.56999999999994,
"heapDeltaBytes": -52384832,
"heapUsedBytes": 56870932,
"domNodes": -212,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 8.221000000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1777.8539999999907,
"styleRecalcs": 56,
"styleRecalcDurationMs": 16.152,
"layouts": 12,
"layoutDurationMs": 4.235,
"taskDurationMs": 850.3400000000001,
"heapDeltaBytes": -29417964,
"heapUsedBytes": 79822024,
"domNodes": -212,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 160.44899999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018691,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1770.4330000000255,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.783999999999999,
"layouts": 12,
"layoutDurationMs": 4.361000000000001,
"taskDurationMs": 836.527,
"heapDeltaBytes": -31364320,
"heapUsedBytes": 78121104,
"domNodes": -212,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 154.96300000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.9989999999684,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.61,
"layouts": 3,
"layoutDurationMs": 0.8549999999999999,
"taskDurationMs": 334.31899999999996,
"heapDeltaBytes": 9708336,
"heapUsedBytes": 80052596,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.144999999999994,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.8509999999906,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.007000000000001,
"layouts": 3,
"layoutDurationMs": 0.846,
"taskDurationMs": 343.38599999999997,
"heapDeltaBytes": 9629896,
"heapUsedBytes": 80353428,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.676999999999998,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 648.4850000000506,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.757999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.44399999999996,
"heapDeltaBytes": -6311960,
"heapUsedBytes": 63414292,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 174.55399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 670.3449999999975,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.6319999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.8910000000001,
"heapDeltaBytes": 17920808,
"heapUsedBytes": 79994764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.298,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307703,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1169.7229999999763,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 770.1680000000001,
"heapDeltaBytes": 13171160,
"heapUsedBytes": 96912816,
"domNodes": 0,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 64.20400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 534,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.4109999999673,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.603,
"heapDeltaBytes": 13838324,
"heapUsedBytes": 86390864,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 65.99,
"eventListeners": 0,
"totalBlockingTimeMs": 524,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.6639999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.58899999999994,
"heapDeltaBytes": -6172228,
"heapUsedBytes": 95347468,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 157.902,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3919999999471,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.89400000000006,
"heapDeltaBytes": 18654372,
"heapUsedBytes": 100994344,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.686,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10566.430000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9637.925000000001,
"heapDeltaBytes": 3840956,
"heapUsedBytes": 75986648,
"domNodes": -141,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 7990.700000000001,
"eventListeners": -69,
"totalBlockingTimeMs": 1154,
"frameDurationMs": 32.61203703703704,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10209.592999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9304.526000000002,
"heapDeltaBytes": 17198516,
"heapUsedBytes": 89494208,
"domNodes": -141,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 7718.788,
"eventListeners": -69,
"totalBlockingTimeMs": 1026,
"frameDurationMs": 31.675776397515524,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9134.434999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8339.16,
"heapDeltaBytes": -7767616,
"heapUsedBytes": 74950684,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 7092.469,
"eventListeners": 0,
"totalBlockingTimeMs": 851,
"frameDurationMs": 32.386170212765954,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9168.21600000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8404.669,
"heapDeltaBytes": -13041464,
"heapUsedBytes": 69689648,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 6866.293,
"eventListeners": 0,
"totalBlockingTimeMs": 578,
"frameDurationMs": 31.937979094076653,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2008.34100000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5919999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.96199999999993,
"heapDeltaBytes": -5577348,
"heapUsedBytes": 73466776,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.934,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2047.0540000000028,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.636,
"heapDeltaBytes": -49063852,
"heapUsedBytes": 83060356,
"domNodes": -308,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 31.31,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2308.283000000017,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.514000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1617.187,
"heapDeltaBytes": -5859172,
"heapUsedBytes": 86105936,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 860.668,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66521739130435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2236.4710000000514,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.4159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1568.343,
"heapDeltaBytes": 16151520,
"heapUsedBytes": 81030464,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 808.9150000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616541353383,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3507.1249999999736,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.109000000000003,
"layouts": 60,
"layoutDurationMs": 15.465,
"taskDurationMs": 1466.3529999999998,
"heapDeltaBytes": 5076072,
"heapUsedBytes": 71243628,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.127,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666190476190476,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3540.5119999999215,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.015,
"layouts": 60,
"layoutDurationMs": 15.847999999999997,
"taskDurationMs": 1667.9689999999998,
"heapDeltaBytes": 5482880,
"heapUsedBytes": 85888300,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 791.4019999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2995.383000000004,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.975000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.2430000000002,
"heapDeltaBytes": -15195236,
"heapUsedBytes": 70270648,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 990.3559999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75921787709497,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2738.4960000000547,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.697999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1701.7069999999999,
"heapDeltaBytes": 8724624,
"heapUsedBytes": 79726292,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 979.0069999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7680981595092,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.312999999987,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9359999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.72700000000003,
"heapDeltaBytes": 20054612,
"heapUsedBytes": 90034348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.466999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.3990000000022,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.9429999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.876,
"heapDeltaBytes": -5126452,
"heapUsedBytes": 78832988,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.542,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.3940000000271,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.747000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.93499999999995,
"heapDeltaBytes": -9877796,
"heapUsedBytes": 61770916,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 145.66299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.7730000000638,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.050999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.292,
"heapDeltaBytes": 13071392,
"heapUsedBytes": 79086084,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.564,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66764705882355,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.7579999999484,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.242,
"heapDeltaBytes": 4175032,
"heapUsedBytes": 70284916,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.252,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.5000000000173,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.234,
"heapDeltaBytes": 4200300,
"heapUsedBytes": 69920240,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.892,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.7079999999914,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.652,
"layouts": 16,
"layoutDurationMs": 5.281,
"taskDurationMs": 597.406,
"heapDeltaBytes": -389540,
"heapUsedBytes": 72629180,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 101.65400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.9589999999516,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.854,
"layouts": 16,
"layoutDurationMs": 6.0009999999999994,
"taskDurationMs": 757.771,
"heapDeltaBytes": -272408,
"heapUsedBytes": 72329552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.67200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.2210000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.121000000000006,
"layouts": 5,
"layoutDurationMs": 14.492999999999999,
"taskDurationMs": 930.0950000000001,
"heapDeltaBytes": 6522668,
"heapUsedBytes": 108252544,
"domNodes": 14570,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 29.519999999999996,
"eventListeners": 2458,
"totalBlockingTimeMs": 125,
"frameDurationMs": 19.176712328767117,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8421.96100000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.872999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5708.424,
"heapDeltaBytes": 11009364,
"heapUsedBytes": 89525800,
"domNodes": 0,
"jsHeapTotalBytes": 716800,
"scriptDurationMs": 2898.526,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8379.727000000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5421.241999999999,
"heapDeltaBytes": -64602528,
"heapUsedBytes": 67038568,
"domNodes": -308,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 2634.993,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6662027833002,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18451.96500000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17485.022,
"heapDeltaBytes": -31631740,
"heapUsedBytes": 185063164,
"domNodes": -3046,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 274.787,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.32308998302207,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 18481.186999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17494.098,
"heapDeltaBytes": -42399364,
"heapUsedBytes": 183116804,
"domNodes": -3046,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 276.49500000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.37979626485569,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 23358.70900000003,
"styleRecalcs": 180,
"styleRecalcDurationMs": 14.749999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22895.014,
"heapDeltaBytes": -26251308,
"heapUsedBytes": 190392196,
"domNodes": -3046,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 891.8109999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 42.87284403669725,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22707.012000000075,
"styleRecalcs": 179,
"styleRecalcDurationMs": 14.573999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22313.897999999997,
"heapDeltaBytes": -23126176,
"heapUsedBytes": 189475248,
"domNodes": -3046,
"jsHeapTotalBytes": 2117632,
"scriptDurationMs": 916.574,
"eventListeners": -14915,
"totalBlockingTimeMs": 19,
"frameDurationMs": 41.68018348623853,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6590.507000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.07900000000004,
"layouts": 20,
"layoutDurationMs": 23.606,
"taskDurationMs": 6431.137999999999,
"heapDeltaBytes": 959932,
"heapUsedBytes": 217855068,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 111.319,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.17087912087912,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6549.77400000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.88,
"layouts": 20,
"layoutDurationMs": 24.205000000000005,
"taskDurationMs": 6436.656999999999,
"heapDeltaBytes": 5266764,
"heapUsedBytes": 217850968,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 108.705,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.64252873563219,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9487.067000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9059.056,
"heapDeltaBytes": -36513488,
"heapUsedBytes": 184048560,
"domNodes": -3046,
"jsHeapTotalBytes": 4333568,
"scriptDurationMs": 149.76899999999992,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.36484641638224,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9378.870000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8923.981,
"heapDeltaBytes": -32247940,
"heapUsedBytes": 184506548,
"domNodes": -3046,
"jsHeapTotalBytes": 7372800,
"scriptDurationMs": 136.25500000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.486577181208055,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 483.40300000006664,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.758000000000003,
"layouts": 5,
"layoutDurationMs": 2.727,
"taskDurationMs": 133.64200000000002,
"heapDeltaBytes": 6507780,
"heapUsedBytes": 62710216,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.176000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 484.7909999999729,
"styleRecalcs": 19,
"styleRecalcDurationMs": 14.634,
"layouts": 3,
"layoutDurationMs": 1.6360000000000001,
"taskDurationMs": 120.016,
"heapDeltaBytes": 6188936,
"heapUsedBytes": 67936992,
"domNodes": 130,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.036999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 823.2580000000098,
"styleRecalcs": 78,
"styleRecalcDurationMs": 90.34100000000001,
"layouts": 76,
"layoutDurationMs": 23.871,
"taskDurationMs": 804.1850000000001,
"heapDeltaBytes": 17539840,
"heapUsedBytes": 95013232,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 329.202,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 829.7629999999572,
"styleRecalcs": 78,
"styleRecalcDurationMs": 87.917,
"layouts": 76,
"layoutDurationMs": 24.782,
"taskDurationMs": 808.4259999999999,
"heapDeltaBytes": 17689960,
"heapUsedBytes": 87976072,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 335.811,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1374.557999999979,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.659,
"layouts": 76,
"layoutDurationMs": 28.569,
"taskDurationMs": 1352.621,
"heapDeltaBytes": 10449260,
"heapUsedBytes": 123355632,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 466.447,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.291250000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1393.5450000000174,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.313,
"layouts": 76,
"layoutDurationMs": 28.987,
"taskDurationMs": 1380.466,
"heapDeltaBytes": 10806460,
"heapUsedBytes": 123703560,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 477.503,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.498749999999994,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2240 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20177 +/- ##
==========================================
+ Coverage 85.64% 86.48% +0.83%
==========================================
Files 3543 2496 -1047
Lines 169919 141912 -28007
Branches 44602 38582 -6020
==========================================
- Hits 145533 122726 -22807
+ Misses 22383 18801 -3582
+ Partials 2003 385 -1618
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1050 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 2 |
| 🟢 Low | 5 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| onAuthHeader?.(authHeader !== null) | ||
| if (!authHeader) return { scheme: 'none', unifiedRetryOn401: false } | ||
| if (!authHeader) { | ||
| return { scheme: 'none', credential: 'none', unifiedRetryOn401: false } |
There was a problem hiding this comment.
🟢 Low — 'none' is inferred only from getAuthHeader(), not from what the request actually carries: cloud requests are same-origin and fetch defaults to credentials: 'same-origin', so a lingering session cookie (or a caller-supplied auth header already in headers) can accompany a request reported as none, defeating the diagnostic on the missing-credential path. Either omit cookies on the header path or report the full credential set. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).
There was a problem hiding this comment.
Not changing: the session cookie is HttpOnly so JS cannot see whether one rode along, and the same-origin default is how fetch behaves today for every cloud request. none here means "no token/key header was attached", which is what separates the missing-token case from the cookie-only one (that is the session-cookie value). Omitting credentials on the header path would change request behavior, which is out of scope for a diagnostics PR.
Replace the scrubbed free-text extra with allowlisted tags (reason,
error type, error code, accepted methods; anything else is 'other') so
no backend text, id or token can reach telemetry and tag cardinality
stays bounded. Read the ingest { code, message } shape, fall back to
error.code when the top-level code is not a string, and only report an
api-key credential when an X-API-KEY header was actually attached.
christian-byrne
left a comment
There was a problem hiding this comment.
It needs changes:
- use shared types
- extract out helpers/pure functions
- use literal types / template strings
- don't hardcode things
- make it fail open so it doesn't block anything
- see if you can decouple and make import direction better aligned with rest of codebase
…and fail open Move AuthScheme/AuthCredential to types/authTypes, derive the credential kind from the shared AuthHeader keys, and parse rejection bodies with the generated ingest schemas in a pure platform/auth/authRejection module so workbench imports downward and scripts/api no longer owns the types. Reporting and the onAuthCredential callback now swallow their own failures so the original error and response path is unchanged.
|
Pushed d6f7f1c for this review. Shared types: 🤖 Generated with Claude Code |
|
🔗 Commit SHA: dd30e37 | Docs | View more details | Give us feedback! |
skishore23
left a comment
There was a problem hiding this comment.
Reviewed. Only the credential kind is reported, never a header value; backend values are checked against a fixed list (anything else is other) and the message text is matched, never copied. Telemetry failures are caught. Non-blocking: the accepted-methods list is missing cookie and comfy_admin_key, which ingest also returns, so a cookie-only route reports other and hides the session vs bearer difference this is meant to show.
|
Thanks for the review. I did not add 🤖 Generated with Claude Code |
dante01yoon
left a comment
There was a problem hiding this comment.
Deep strict review at e92c40c: approved for the bounded diagnostics change; this does not establish or fix the live authentication failure's root cause.
PASS: own frozen-lockfile installation; 192 focused tests across auth classification, real fetchApi credential callbacks, agent REST errors and the real error reporter; app typecheck, Cloud and restored-head OSS production builds, changed-file type-aware oxlint/format, production ESLint and knip. ESLint intentionally excludes the four unit files; oxlint/format covered them.
An independent integration case exercised createAgentRestClient → real reportError → real Sentry SDK normalization with controlled request/transport boundaries. The original AgentApiError retained the server message, while the emitted event used the stable message and bounded credential/refusal tags, mapped an unknown accepted method to other, contained none of the private sentinel text, and did not emit a duplicate when the caller reported the same original error.
Regression/mutation evidence: restoring pre-PR production wiring from the actual PR merge base produced 21 FAIL / 106 PASS. Removing the code allowlist produced 1 FAIL / 25 PASS; removing the accepted-method allowlist produced 3 FAIL / 24 PASS including the real SDK integration; removing credential-callback fail-open protection produced 2 FAIL / 34 PASS. Restored head: 162 focused cases PASS including the SDK case. All nine PR files are byte-identical and checkout is clean. The first trial used HEAD^ of this merge commit, which still contained the feature and passed; that trial is not regression proof, and the merge-base result above replaces it.
Backend bodies are parsed with generated zAuthTypeNotAllowedError/zErrorResponse; the local literal lists describe bounded frontend telemetry categories rather than redeclaring a closed server response enum. No new server-owned capability is synthesized. The accepted cookie/admin-key observation is intentionally mapped to other by the allowlist. Credential tags describe the client-selected auth path/header; they do not prove that no ambient HttpOnly cookie or caller-supplied credential rode along, nor identify what the backend accepted. The existing author reply preserves transport behavior, which is appropriate for this diagnostics scope.
Latest required checks are successful and their workflow head matches this SHA. NOT_RUN: live Cloud login/rejection/flag pairing, real telemetry ingestion, browser UI and other OS/browser. No rendered UI changed; request/SDK behavior was exercised directly with controlled boundaries. This approval must not be read as confirmation that the reported customer login problem is resolved. No performance improvement is claimed.
0832b8d
dante01yoon
left a comment
There was a problem hiding this comment.
Rechecked latest head 0832b8d8e6d2ed8949321ef8d96fe02a6bb99e1c after the main merge and new auth-rejected keyboard retry coverage. PASS: fresh frozen install in the exact isolated checkout; 194 related unit tests plus one real REST→reportError→Sentry-normalization diagnostic; app/browser types, Cloud production build, changed-file type-aware lint/format, knip and final clean-source types/knip. Actual production Cloud UI with an isolated ComfyUI backend passes all 3 run-mode journeys, including held 403→same focused option→Enter retry→saved mode. Restoring latest-main production files yields 21 failures/108 survivors; privacy-code, accepted-method and fail-open mutations yield 1/3/2 failures respectively, and original restoration passes 164 focused tests including the SDK diagnostic. All 10 changed files match HEAD and checkout is clean. Transport/auth/SDK capture are controlled fixtures, not live auth-failure or ingestion proof. NOT_RUN: live customer authentication issue, other OS/browsers and unrelated full suites; the credential tag still identifies the FE-selected credential path, not what the backend actually authenticated.
Approval is pending the active exact-head CI run 37647206983. Its unit gate has succeeded, but E2E is still running. The red test/e2e-status entries from run 37647203883 belong to an actually cancelled run; they are not evidence of a reproduced product defect or a latest completed E2E failure. I have not restarted CI and will check the newer run before approval. The author claude[bot] is still ineligible for assignee (current eligibility lookup 404); no other assignee was replaced.
dante01yoon
left a comment
There was a problem hiding this comment.
Increment rechecked at 7f90f59 after the main merges. Auth diagnostic source and Run mode regression are byte-identical to the previously validated 0832 head.
PASS: own frozen installation; 246 related unit tests; real REST → reportError → real Sentry normalization (1 case, controlled transport); app/browser types, Cloud production build, changed-file type-aware oxlint/ESLint/format and knip, final types/knip after diagnostic cleanup; production frontend + isolated ComfyUI backend Run mode 3 PASS. Historical mutation results remain separate; fresh mutations NOT_RUN because this increment changes only already merged attachment/UserMessage code and leaves this feature unchanged. Live auth/customer incident/ingestion and actual BE credential identity NOT_RUN.
Approval pending: matching-head workflow 37650552700 still has E2E/ecosystem shards running, although test/lint succeeded. I will check the final required contexts when it completes; no CI rerun requested.
dante01yoon
left a comment
There was a problem hiding this comment.
Rechecked current head dd30e37 after the main merge containing the employee web-session flag override. Auth diagnostic production files and Run mode spec are byte-identical to the previous validated head.
PASS: own frozen install; 502 related unit tests (9 files, including auth/web-session flag override); real REST → reportError → real Sentry normalization 1 PASS, controlled transport; app/browser types, Cloud production build, changed-file oxlint/ESLint/format/knip and final diagnostic-cleanup types/knip; production frontend + isolated backend Run mode 3 PASS. Fresh feature mutations NOT_RUN because those feature files are unchanged; historical 0832 red/restore evidence remains separate. Live customer auth failure/ingestion/actual BE credential identity/other browsers NOT_RUN. No API shape or auth authority changes in this PR increment.
question: approval pending matching-head run37653411663, still running. Previous 7f90 run succeeded but belongs to a different head and is not reused as CI proof. I will check final required contexts on this head before approval. Author claude[bot] is still not assignee-eligible (404); other assignees are preserved.
dante01yoon
left a comment
There was a problem hiding this comment.
Rechecked current head dd30e37 after the main merge containing the employee web-session flag override. Auth diagnostic production files and Run mode spec are byte-identical to the previous validated head.
PASS: own frozen install; 502 related unit tests (9 files, including auth/web-session flag override); real REST → reportError → real Sentry normalization 1 PASS, controlled transport; app/browser types, Cloud production build, changed-file oxlint/ESLint/format/knip and final diagnostic-cleanup types/knip; production frontend + isolated backend Run mode 3 PASS. Fresh feature mutations NOT_RUN because those feature files are unchanged; historical 0832 red/restore evidence remains separate. Live customer auth failure/ingestion/actual BE credential identity/other browsers NOT_RUN. No API shape or auth authority changes in this PR increment.
CI-only follow-up: latest required 5 SUCCESS, workflow37653411663 completedSUCCESS at this exact head; website37653410386 and CLA37653410404 matching heads. Cancelled duplicate failures are excluded. No new local execution is claimed in this follow-up. Scope is frontend credential-path diagnostics plus keyboard retry behavior, not proof the customer auth incident or live ingestion is resolved. The credential tag proves the selected frontend auth path/header, not what credentials the backend actually received. Author claude[bot] remains not assignee-eligible (fresh404), existing assignees preserved.
|
|
… on agent API auth rejections (#20445) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1791182719420129)_ Backport of #20046 to `core/1.55`. The automated backport hit merge conflicts, so this is a manual cherry-pick (`git cherry-pick -x 97c647a`). Adapted for this branch: - `core/1.55` has no web-session request path, so `fetchApi` reports only `cloud-auth-header` or `none` through `onAuthScheme`. The `web-session` member stays in the `AuthScheme` type so later diagnostics backports apply cleanly. - `reportError` has no required `surface` tag here, so it is omitted from the new call and test. - The web-session `fetchApi` test was dropped because the module it depends on does not exist on this branch; the other `onAuthScheme` tests are kept. - Added `__mocks__/reportError.ts` (new on this branch) and kept this branch's existing run-mode and truncated-body behavior. Checked locally: `pnpm typecheck`, `oxfmt --check` and oxlint on the touched files, and the agent, telemetry and `src/extensions/core` vitest suites (4049 passed). #20177 depends on this and will be backported after it merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj --- _Generated by [Claude Code](https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj)_ Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…e on agent API auth rejections (#20447) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1791182719420129)_ Backport of #20046 to `cloud/1.55`. The automated backport hit merge conflicts, so this is a manual cherry-pick (`git cherry-pick -x 97c647a`). Adapted for this branch: - `cloud/1.55` has no web-session request path, so `fetchApi` reports only `cloud-auth-header` or `none` through `onAuthScheme`. The `web-session` member stays in the `AuthScheme` type so later diagnostics backports apply cleanly. - `reportError` has no required `surface` tag here, so it is omitted from the new call and test. - The web-session `fetchApi` test was dropped because the module it depends on does not exist on this branch; the other `onAuthScheme` tests are kept. - Added `__mocks__/reportError.ts` (new on this branch), and added a `get_cloud_workflow` operation for the single-workflow request this branch has. Checked locally: `pnpm typecheck`, `oxfmt --check` and oxlint on the touched files, and the agent, telemetry and `src/extensions/core` vitest suites (4748 passed across agent, telemetry, scripts and extensions/core). #20177 depends on this and will be backported after it merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj --- _Generated by [Claude Code](https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj)_ Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…on (#20177) Backport of #20177 to core/1.55. Adds the credential kind sent and an allowlisted classification of the backend's refusal to the agent auth-rejection report, without copying any backend free text. Adapted for this branch: it has no web-session request path, so that credential case and its test are dropped; and its generated ingest types lack AuthTypeNotAllowedError, so authRejection.ts defines an equivalent local schema until they are synced. (cherry picked from commit 66b9e9a)
…on (#20177) Backport of #20177 to cloud/1.55. Adds the credential kind sent and an allowlisted classification of the backend's refusal to the agent auth-rejection report, without copying any backend free text. Adapted for this branch: it has no web-session request path, so that credential case and its test are dropped. (cherry picked from commit 66b9e9a)
… kind on auth rejection (#20466) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1791182719420129)_ Backport of #20177 to `core/1.55`, on top of the #20046 backport (already merged here). The automated backport hit merge conflicts because #20046 was not on the branch yet, so this is a manual cherry-pick (`git cherry-pick -x 66b9e9a`) rebased onto the updated branch. Adapted for this branch: - It has no web-session request path, so the `session-cookie` credential case and its `fetchApi` test case are dropped. - Its generated ingest types do not include `AuthTypeNotAllowedError`, so `authRejection.ts` defines an equivalent local zod schema. Switch to the generated one once the ingest types are synced to this branch. Checked locally: `pnpm typecheck`, `oxfmt --check` and oxlint on the touched files, and the agent, auth and scripts vitest suites. The Playwright change in `agentRunModePopover.spec.ts` was not run locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj --- _Generated by [Claude Code](https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…l kind on auth rejection (#20467) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C09KFK2ABB8/p1791182719420129)_ Backport of #20177 to `cloud/1.55`, on top of the #20046 backport (already merged here). The automated backport hit merge conflicts because #20046 was not on the branch yet, so this is a manual cherry-pick (`git cherry-pick -x 66b9e9a`) rebased onto the updated branch. Adapted for this branch: - It has no web-session request path, so the `session-cookie` credential case and its `fetchApi` test case are dropped. Checked locally: `pnpm typecheck`, `oxfmt --check` and oxlint on the touched files, and the agent, auth and scripts vitest suites. The Playwright change in `agentRunModePopover.spec.ts` was not run locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj --- _Generated by [Claude Code](https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Requested via Slack thread
Summary
Before: The Sentry alert "AgentApiError: Authentication method not allowed for this endpoint. Accepted: bearer_jwt, x_api_key" (thrown from
GET /agent/run-mode) cannot be diagnosed. #20046 added telemetry for agent 401/403s, but it only records the operation, status and auth scheme under a constant message, and drops the backend's own refusal. That cannot separate a cookie-only web session, a request with no token yet, and a request with the wrong credential.After: Agent 401/403 reports keep the same stable message and grouping, and add tags for the credential kind actually sent (
session-cookie,bearer,api-key,none), the backend error type and code, and the accepted auth methods, plus an allowlisted classification of the backend's refusal. No backend free text is reported. The next event tells us which of the three cases it is. This is diagnostics only, not a behavior fix.Changes
AuthSchemeandAuthCredentialnow live insrc/types/authTypes.ts, andauthCredentialOfderives the credential kind from the sharedAuthHeaderkeys.fetchApireports the kind through an optionalonAuthCredentialcallback that cannot break the request. The new pure modulesrc/platform/auth/authRejection.tsparses a rejection body with the generated ingest schemas (zAuthTypeNotAllowedError,zErrorResponse) and returns tags:backendReason,backendErrorType,backendErrorCode,acceptedMethods. Backend values come only from the lists exported there, anything else isother, and response text is never copied.agentRestClientaddscredentialand the backend tags to the existing report, and a failure inside classification or reporting is swallowed so the originalAgentApiErroris thrown unchanged. Unit tests sit next to each module.Review Focus
Why not a fix: I could not show from the code that forcing a bearer credential for agent routes is right. Per the generated ingest types, a route that does not take a credential answers
auth_type_not_allowed, and that includes the web session while the server-sideweb_session_enabledis off for the user. So a likely cause is the client web-session flag (or a session/dev override, which skips the server pairing inuseFeatureFlags) disagreeing with the server flag, which is a flag-pairing problem rather than something a bearer override should paper over. The other candidates are an unauthenticated request (credential: none, with a legacy session cookie still riding along) or a wrong credential kind. Switching agent requests off the cookie path would also diverge from the unified web-session design and could break users the server does accept. The new tags settle which case it is. Operation already names method and endpoint one-to-one, so no separate route tag was added (path-derived tags were rejected in #20046 because of ids and cursors).Backport: this builds on #20046, which is on
mainbut not oncloud/1.54,cloud/1.55orcore/1.55. A backport of this PR alone will conflict unless #20046 lands there first.🤖 Generated with Claude Code
https://claude.ai/code/session_01S5cB4waJ1vMLEm9A1XeYfj
Generated by Claude Code