Repository navigation
[backport core/1.55] fix(agent): report upload failure cause, file type and size for attachment telemetry - #20428
Conversation
…hment telemetry (#20405) ## Summary - The agent composer's attachment upload has two error paths (direct upload, deferred drag/paste fetch) that each used a bare `catch {}`, discarding the real thrown error before reporting a synthetic, context-free `Error('Agent attachment upload failed')`. - That's why the Sentry alert for PM-1997 carries zero diagnostic detail — no HTTP status, failure shape, file type, or size — nothing to distinguish a size rejection from an auth refusal from a transport failure. - This PR binds the caught error, classifies it into a bounded `upload_failure_cause` tag (`http_<status>`, `unreadable_response`, `timeout`, `aborted`, `unknown`), and adds `file_type`/`file_size_bytes` tags to the existing `reportError()` call. - The original error's message/stack are still never reported (an existing test guards against a dropped file's local path leaking into telemetry) — only the file's own declared, bounded metadata and a closed-set failure-shape tag are added. ## Why PM-1997 is a one-line Sentry relay from `cloud-frontend-prod` with no repro steps, file name, MIME type, size, or HTTP status — nothing to build a targeted fix from. Per the project's standing telemetry-first triage pattern (see PM-1802 / #20046), this PR adds the missing structured context at the failure site instead of guessing at a fix, so the alert is actionable once fresh occurrences land. ## Test plan - [x] Added test cases asserting `upload_failure_cause` resolves correctly for `AgentApiError` (HTTP status), `AgentResponseUnreadableError`, a timeout, and an unrecognized error shape. - [x] Updated the existing privacy-preserving test (reported error must never leak a dropped file's local path) to assert the new bounded tags are present. - [x] `pnpm vitest run src/workbench/extensions/agent/composables/agent/` — 401/401 passing, no regressions. - [x] `pnpm typecheck:app` — clean. - [x] `eslint` / `oxlint` on changed files — clean. Linear: PM-1997
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2155 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d5c4bb63663091f0339b92e342f79354c625928a
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-07T16:24:30.853Z",
"gitSha": "6f21680f0f42c0d40531363576abcd038767a3ff",
"branch": "backport-20405-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2002.9480000000035,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.451,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.34499999999997,
"heapDeltaBytes": -9257136,
"heapUsedBytes": 59863644,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.029000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2003.4180000000106,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.350999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.752,
"heapDeltaBytes": -7383848,
"heapUsedBytes": 61725652,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.76,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.2909999999802,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 711.846,
"heapDeltaBytes": 3462144,
"heapUsedBytes": 72611300,
"domNodes": -260,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 164.83,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.2119999999813,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.4060000000001,
"heapDeltaBytes": 8726216,
"heapUsedBytes": 77812488,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 157.87599999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.1460000000025,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.069999999999999,
"layouts": 6,
"layoutDurationMs": 1.0119999999999998,
"taskDurationMs": 358.37499999999994,
"heapDeltaBytes": 3591888,
"heapUsedBytes": 72688436,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.190000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.3510000000033,
"styleRecalcs": 29,
"styleRecalcDurationMs": 17.419,
"layouts": 6,
"layoutDurationMs": 1.1099999999999999,
"taskDurationMs": 337.54300000000006,
"heapDeltaBytes": 3351696,
"heapUsedBytes": 71546588,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.677,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 668.0859999999598,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.695000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.14199999999994,
"heapDeltaBytes": -8012876,
"heapUsedBytes": 61018168,
"domNodes": 20,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 169.41299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 642.4780000000965,
"styleRecalcs": 14,
"styleRecalcDurationMs": 7.839,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.31999999999994,
"heapDeltaBytes": 17872984,
"heapUsedBytes": 86543068,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 164.202,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1252.9160000000275,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 929.4870000000001,
"heapDeltaBytes": 39144720,
"heapUsedBytes": 107277272,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 70.96,
"eventListeners": 0,
"totalBlockingTimeMs": 635,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1199.8720000000276,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 850.9789999999999,
"heapDeltaBytes": 34709468,
"heapUsedBytes": 105838820,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 71.94700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 582,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.1560000000272,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.7460000000001,
"heapDeltaBytes": 15535012,
"heapUsedBytes": 91208364,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.25999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.0920000000597,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.9119999999995,
"heapDeltaBytes": 15054600,
"heapUsedBytes": 91866560,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.44000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10584.010000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9636.117,
"heapDeltaBytes": 11873524,
"heapUsedBytes": 92801996,
"domNodes": -10,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8012.549999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1213,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10890.618000000017,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.28000000000000247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9974.367,
"heapDeltaBytes": 2374768,
"heapUsedBytes": 81071232,
"domNodes": -273,
"jsHeapTotalBytes": 9691136,
"scriptDurationMs": 8387.165,
"eventListeners": -174,
"totalBlockingTimeMs": 1470,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10216.000000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9292.393,
"heapDeltaBytes": 4914800,
"heapUsedBytes": 80818108,
"domNodes": -12,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7764.562,
"eventListeners": 0,
"totalBlockingTimeMs": 1070,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10655.034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9747.05,
"heapDeltaBytes": -8113992,
"heapUsedBytes": 73591508,
"domNodes": -16,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8201.387,
"eventListeners": 0,
"totalBlockingTimeMs": 1374,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2021.5119999999729,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.670000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.14599999999996,
"heapDeltaBytes": -16583724,
"heapUsedBytes": 73052520,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 31.769,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.8000000000566,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.493,
"heapDeltaBytes": -24042648,
"heapUsedBytes": 65461324,
"domNodes": -258,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 35.066,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2197.2900000000095,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1576.6530000000002,
"heapDeltaBytes": -2228416,
"heapUsedBytes": 88400324,
"domNodes": -253,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 829.374,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2245.1769999998987,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1637.321,
"heapDeltaBytes": -4872636,
"heapUsedBytes": 78902352,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 857.947,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3541.2259999999947,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.948,
"layouts": 60,
"layoutDurationMs": 13.431,
"taskDurationMs": 1624.888,
"heapDeltaBytes": 6727720,
"heapUsedBytes": 97617332,
"domNodes": 36,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 787.702,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3519.1790000000083,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.666,
"layouts": 60,
"layoutDurationMs": 13.049,
"taskDurationMs": 1612.6660000000002,
"heapDeltaBytes": -215140,
"heapUsedBytes": 65676180,
"domNodes": 32,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 793.3019999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3195.715000000007,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.945000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.4039999999998,
"heapDeltaBytes": -17186716,
"heapUsedBytes": 75901088,
"domNodes": 14,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 1028.652,
"eventListeners": 180,
"totalBlockingTimeMs": 29,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.0160000000105,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.6629999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1822.6,
"heapDeltaBytes": 8984404,
"heapUsedBytes": 74326376,
"domNodes": 4,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 986.3600000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2000.3150000000005,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.68799999999993,
"heapDeltaBytes": 9958868,
"heapUsedBytes": 74047456,
"domNodes": -246,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.062,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.3259999999982,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.188,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 546.681,
"heapDeltaBytes": -23766140,
"heapUsedBytes": 67543564,
"domNodes": -256,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 34.84899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.1339999999591,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.931999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.5920000000001,
"heapDeltaBytes": 13536276,
"heapUsedBytes": 84672776,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 148.451,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.0020000000222,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.149000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.3450000000001,
"heapDeltaBytes": 13571864,
"heapUsedBytes": 83845624,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.388,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.7100000000119,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.247,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.295,
"heapDeltaBytes": 6954216,
"heapUsedBytes": 77330144,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.339000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.0099999999702,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.433,
"heapDeltaBytes": -6858828,
"heapUsedBytes": 64064976,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.242999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.1710000000166,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.192,
"heapDeltaBytes": 2934748,
"heapUsedBytes": 73994948,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 103.92899999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1702.1760000000086,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.366,
"heapDeltaBytes": -8124792,
"heapUsedBytes": 62939912,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 104.93299999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.5679999999602,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.714000000000006,
"layouts": 5,
"layoutDurationMs": 13.877,
"taskDurationMs": 953.897,
"heapDeltaBytes": -6337112,
"heapUsedBytes": 82207492,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.124000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8257.344999999987,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.858000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5451.511999999999,
"heapDeltaBytes": -1364484,
"heapUsedBytes": 88074156,
"domNodes": -244,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2796.047,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8316.777999999998,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5476.8460000000005,
"heapDeltaBytes": 28292040,
"heapUsedBytes": 92230704,
"domNodes": -244,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 2765.501,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12991.109999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12452.458,
"heapDeltaBytes": -58281128,
"heapUsedBytes": 183324128,
"domNodes": -8061,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 225.787,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17026.336000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16520.538,
"heapDeltaBytes": -61232452,
"heapUsedBytes": 173127544,
"domNodes": -8065,
"jsHeapTotalBytes": -7876608,
"scriptDurationMs": 261.042,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16010.834999999986,
"styleRecalcs": 86,
"styleRecalcDurationMs": 12.91399999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15575.607,
"heapDeltaBytes": -44216896,
"heapUsedBytes": 169594532,
"domNodes": -8061,
"jsHeapTotalBytes": -12070912,
"scriptDurationMs": 850.911,
"eventListeners": -14928,
"totalBlockingTimeMs": 14,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21106.797000000028,
"styleRecalcs": 172,
"styleRecalcDurationMs": 18.354999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20673.447,
"heapDeltaBytes": -34968528,
"heapUsedBytes": 192943444,
"domNodes": -8061,
"jsHeapTotalBytes": -18358272,
"scriptDurationMs": 920.948,
"eventListeners": -14928,
"totalBlockingTimeMs": 93,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6143.20900000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.656,
"layouts": 20,
"layoutDurationMs": 24.05,
"taskDurationMs": 6048.975,
"heapDeltaBytes": -50078352,
"heapUsedBytes": 183968336,
"domNodes": -8061,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 118.275,
"eventListeners": -14928,
"totalBlockingTimeMs": 333,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6128.307000000063,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.97599999999998,
"layouts": 20,
"layoutDurationMs": 23.995,
"taskDurationMs": 6045.639999999999,
"heapDeltaBytes": -38362216,
"heapUsedBytes": 196972040,
"domNodes": -8061,
"jsHeapTotalBytes": 15605760,
"scriptDurationMs": 108.97999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 446,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6483.971999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6229.817000000003,
"heapDeltaBytes": 12590028,
"heapUsedBytes": 183313680,
"domNodes": 0,
"jsHeapTotalBytes": -18612224,
"scriptDurationMs": 108.09299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8473.502999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8252.114999999998,
"heapDeltaBytes": -6361616,
"heapUsedBytes": 170714340,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 134.67799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.69799999999941,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.218,
"layouts": 3,
"layoutDurationMs": 0.9160000000000001,
"taskDurationMs": 88.60500000000002,
"heapDeltaBytes": 3203208,
"heapUsedBytes": 69947460,
"domNodes": 111,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.653999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 451.6360000000077,
"styleRecalcs": 15,
"styleRecalcDurationMs": 21.235,
"layouts": 3,
"layoutDurationMs": 1.0050000000000001,
"taskDurationMs": 104.464,
"heapDeltaBytes": 4763864,
"heapUsedBytes": 71582552,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.499,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #20428 +/- ##
=============================================
- Coverage 84.91% 84.91% -0.01%
=============================================
Files 2343 2343
Lines 133834 133848 +14
Branches 35731 33838 -1893
=============================================
+ Hits 113644 113651 +7
- Misses 19827 19834 +7
Partials 363 363
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@DrJKL review ownership for the paired generated telemetry backports is now batched to you after the first owner stayed silent beyond two hours: #20428 (core/1.55) and #20429 (cloud/1.55). Both exact heads are unchanged, mergeable, and |
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #20405, with identical hunks in all three files.
I compared against #20405's merge commit 8066b642461d456a3d74583a292e4b92315b83ad. useAttachment.ts, useAttachment.test.ts and AgentPanelRoot.test.ts carry exactly the source's added and removed lines. No adaptation was needed. The unchanged surface: 'agent' context line around the source's reportError hunk does not exist on core/1.55, but the source's changed lines apply cleanly next to this branch's existing call.
Checks: useAttachment.test.ts and AgentPanelRoot.test.ts pass locally at this head (366 tests), and vue-tsc --noEmit passes. Hosted CI at e36aede is green, including lint-and-format, test and e2e-status.
Backport of #20405 to
core/1.55Automatically created by backport workflow.