Skip to content

fix(agent): close cloud/1.54 reseed safety gaps - #20416

Merged
christian-byrne merged 13 commits into
cloud/1.54from
christian/stale-schema-recovery-cloud154-followup
Oct 8, 2026
Merged

christian-byrne merged 13 commits into
cloud/1.54from
christian/stale-schema-recovery-cloud154-followup

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Direct successor to #20312. Closes its post-merge Cursor findings before cloud/1.54 delivery is considered complete.

  • serializes the confirmed live canvas without mutating undo state
  • bounds reseed retries and makes permanent failures terminal
  • abandons ambiguous lineages on timeout, reconnect, and conflict
  • replays in-flight human edits after replacement
  • sizes the complete UTF-8 wire frame once and resets lineage node bookkeeping

Verification:

  • 56 CRDT and Agent panel test files: 1,238 passed, 6 expected failures
  • typecheck, format, lint, and pre-commit knip passed

Tracks PM-1793 and PM-1794.

Review source: #20312 (review)

Addresses post-merge review findings on #20312:\nhttps://github.com//pull/20312#pullrequestreview-5434364237
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR cloud/1.54 Backport PRs for cloud 1.54 agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations greenlight labels Oct 7, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 7, 2026 11:50
@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 7, 2026 9:38pm UTC
billing-web-test Ignored Ignored Oct 7, 2026 9:38pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 76864495-53e8-42ca-8332-935415db257f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 97 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/07/2026, 09:40:21 PM UTC

Links

🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1970 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 134ms TBT · 79.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 6ms TBT · 172.4 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 53ms TBT · 173.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 189ms TBT · 169.1 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 552ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.4 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -195
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 24ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 793ms
canvas-mouse-sweep: script duration 133ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.5 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -196
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 339ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.2 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 412ms
dom-widget-clipping: script duration 144ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 62.1 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 529ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.9 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -179
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1379ms
large-graph-pan: script duration 691ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 64.1 MB
large-graph-pan: DOM nodes 3
large-graph-pan: event listeners 4
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 1533ms
large-graph-zoom: script duration 672ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 64.3 MB
large-graph-zoom: DOM nodes -115
large-graph-zoom: event listeners -91
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1717ms
legacy-node-drag: script duration 875ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 72.5 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 497ms
minimap-idle: script duration 31ms
minimap-idle: TBT 0ms
minimap-idle: heap used 73.3 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -178
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 374ms
subgraph-dom-widget-clipping: script duration 124ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.3 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 458ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 59.2 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 23ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 753ms
subgraph-mouse-sweep: script duration 91ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.4 MB
subgraph-mouse-sweep: DOM nodes -305
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 826ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 134ms
subgraph-transition-enter: heap used 79.6 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5007ms
viewport-pan-sweep: script duration 2343ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 77.2 MB
viewport-pan-sweep: DOM nodes -275
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14131ms
vue-large-graph-idle: script duration 263ms
vue-large-graph-idle: TBT 6ms
vue-large-graph-idle: heap used 172.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 148
vue-large-graph-pan: task duration 17244ms
vue-large-graph-pan: script duration 874ms
vue-large-graph-pan: TBT 53ms
vue-large-graph-pan: heap used 173.5 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 30ms
vue-node-resize-workload: style recalc duration 75ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5128ms
vue-node-resize-workload: script duration 107ms
vue-node-resize-workload: TBT 189ms
vue-node-resize-workload: heap used 169.1 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7003ms
vue-zoom-out-idle: script duration 120ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.9 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 3
workflow-execution: style recalc count 7
workflow-execution: task duration 70ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.1 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-10-07T21:49:17.179Z",
  "gitSha": "3f606637be40f5a6b9149b021697d4ff24801c29",
  "branch": "christian/stale-schema-recovery-cloud154-followup",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2086.5380000000187,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.618,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 626.553,
      "heapDeltaBytes": -8851448,
      "heapUsedBytes": 64575232,
      "domNodes": -278,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 11.201999999999996,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2034.6339999999827,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.486999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.104,
      "heapDeltaBytes": -1323656,
      "heapUsedBytes": 72670520,
      "domNodes": -283,
      "jsHeapTotalBytes": 4227072,
      "scriptDurationMs": 9.588,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1824.9609999999734,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.930999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.169,
      "taskDurationMs": 815.46,
      "heapDeltaBytes": -6673040,
      "heapUsedBytes": 64855280,
      "domNodes": -283,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 133.998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1753.0179999999973,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 22.532000000000004,
      "layouts": 14,
      "layoutDurationMs": 3.683,
      "taskDurationMs": 769.7769999999999,
      "heapDeltaBytes": 833424,
      "heapUsedBytes": 74607092,
      "domNodes": -282,
      "jsHeapTotalBytes": 4489216,
      "scriptDurationMs": 132.745,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000007,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.057000000012,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.877999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.111,
      "taskDurationMs": 351.566,
      "heapDeltaBytes": 4542600,
      "heapUsedBytes": 75725692,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.381,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1710.6280000000424,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 12.925999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.0119999999999998,
      "taskDurationMs": 326.605,
      "heapDeltaBytes": 4243384,
      "heapUsedBytes": 75711980,
      "domNodes": 74,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.147999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 626.7149999999901,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 7.601000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.87300000000005,
      "heapDeltaBytes": -7891392,
      "heapUsedBytes": 63303280,
      "domNodes": 22,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 145.3,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 582.4470000000019,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.257000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.5799999999999,
      "heapDeltaBytes": -7208392,
      "heapUsedBytes": 66826900,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 141.788,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2036.9570000000294,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.376,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.923,
      "heapDeltaBytes": -3477440,
      "heapUsedBytes": 76573568,
      "domNodes": -271,
      "jsHeapTotalBytes": -1802240,
      "scriptDurationMs": 35.818,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2006.6550000000234,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.398,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.092,
      "heapDeltaBytes": 13845156,
      "heapUsedBytes": 91084216,
      "domNodes": -281,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 36.507,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2116.51999999998,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.971999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1377.23,
      "heapDeltaBytes": 898780,
      "heapUsedBytes": 67184936,
      "domNodes": 2,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 689.74,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2122.9050000000598,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.843000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1381.0670000000002,
      "heapDeltaBytes": 965244,
      "heapUsedBytes": 67314260,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 692.562,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3453.223000000037,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.187000000000001,
      "layouts": 60,
      "layoutDurationMs": 13.196,
      "taskDurationMs": 1511.0430000000001,
      "heapDeltaBytes": -419356,
      "heapUsedBytes": 67377232,
      "domNodes": 26,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 668.4440000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3392.357000000061,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.747999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.86,
      "taskDurationMs": 1555.7210000000002,
      "heapDeltaBytes": -15290680,
      "heapUsedBytes": 67376788,
      "domNodes": -255,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 675.1729999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2904.5739999999682,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.193,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1724.429,
      "heapDeltaBytes": 8521284,
      "heapUsedBytes": 76108064,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 890.334,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2898.914999999988,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.483000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1708.6580000000001,
      "heapDeltaBytes": 7973940,
      "heapUsedBytes": 75944872,
      "domNodes": 0,
      "jsHeapTotalBytes": 454656,
      "scriptDurationMs": 860.325,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.6860000000074,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.3799999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.683,
      "heapDeltaBytes": -5201248,
      "heapUsedBytes": 77034968,
      "domNodes": -271,
      "jsHeapTotalBytes": -2588672,
      "scriptDurationMs": 31.648999999999997,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.4919999999665,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.383,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.4919999999999,
      "heapDeltaBytes": -5264528,
      "heapUsedBytes": 76697700,
      "domNodes": -267,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 31.056999999999995,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 567.9269999999974,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.786999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 381.099,
      "heapDeltaBytes": 14560828,
      "heapUsedBytes": 88423136,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 128.608,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 561.3020000000688,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.079999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.84099999999995,
      "heapDeltaBytes": -10546260,
      "heapUsedBytes": 65344036,
      "domNodes": 22,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 119.89000000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2016.8129999999564,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.198,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.6170000000001,
      "heapDeltaBytes": -6829504,
      "heapUsedBytes": 66488520,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.241,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1997.9190000000244,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.402999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.06100000000004,
      "heapDeltaBytes": -18056612,
      "heapUsedBytes": 57587100,
      "domNodes": -298,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 8.733999999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.2220000000543,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 22.470999999999997,
      "layouts": 18,
      "layoutDurationMs": 4.098,
      "taskDurationMs": 739.293,
      "heapDeltaBytes": -23020,
      "heapUsedBytes": 73736972,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 88.932,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1758.6730000000443,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 23.472,
      "layouts": 18,
      "layoutDurationMs": 4.95,
      "taskDurationMs": 767.3389999999999,
      "heapDeltaBytes": -4338344,
      "heapUsedBytes": 71713848,
      "domNodes": -315,
      "jsHeapTotalBytes": 5799936,
      "scriptDurationMs": 92.071,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1083.4149999999454,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.068999999999996,
      "layouts": 15,
      "layoutDurationMs": 12.409,
      "taskDurationMs": 825.766,
      "heapDeltaBytes": -8875316,
      "heapUsedBytes": 83464068,
      "domNodes": 13831,
      "jsHeapTotalBytes": 12582912,
      "scriptDurationMs": 25.758999999999997,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 134,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8201.623999999982,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 40.766000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5120.427000000001,
      "heapDeltaBytes": 17281548,
      "heapUsedBytes": 94475912,
      "domNodes": -282,
      "jsHeapTotalBytes": 3002368,
      "scriptDurationMs": 2376.319,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8166.027999999983,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.17,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4893.009,
      "heapDeltaBytes": 1827248,
      "heapUsedBytes": 67504552,
      "domNodes": -268,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 2310.676,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14794.381999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14252.725000000002,
      "heapDeltaBytes": -55025616,
      "heapUsedBytes": 178291200,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12070912,
      "scriptDurationMs": 233.50199999999998,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14780.231999999956,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14009.854,
      "heapDeltaBytes": -49151824,
      "heapUsedBytes": 183316640,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15138816,
      "scriptDurationMs": 292.06699999999995,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17594.68099999998,
      "styleRecalcs": 148,
      "styleRecalcDurationMs": 19.43900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17189.157000000003,
      "heapDeltaBytes": -52233220,
      "heapUsedBytes": 170200000,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14688256,
      "scriptDurationMs": 899.161,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 105,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17706.481999999938,
      "styleRecalcs": 148,
      "styleRecalcDurationMs": 19.343999999999973,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17299.170000000002,
      "heapDeltaBytes": -27215648,
      "heapUsedBytes": 193638532,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10829824,
      "scriptDurationMs": 848.5100000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.216666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5284.587999999985,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.91199999999998,
      "layouts": 20,
      "layoutDurationMs": 35.76299999999999,
      "taskDurationMs": 5206.482,
      "heapDeltaBytes": -48765180,
      "heapUsedBytes": 176873956,
      "domNodes": -8067,
      "jsHeapTotalBytes": 9162752,
      "scriptDurationMs": 95.582,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 210,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5141.99300000007,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.85400000000003,
      "layouts": 20,
      "layoutDurationMs": 24.038000000000004,
      "taskDurationMs": 5049.2339999999995,
      "heapDeltaBytes": -44887056,
      "heapUsedBytes": 177831488,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13094912,
      "scriptDurationMs": 118.00900000000001,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 167,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7301.427999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6950.566,
      "heapDeltaBytes": -3812908,
      "heapUsedBytes": 178626520,
      "domNodes": 0,
      "jsHeapTotalBytes": -7340032,
      "scriptDurationMs": 116.14000000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7337.281999999959,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7055.876999999999,
      "heapDeltaBytes": 973324,
      "heapUsedBytes": 177614248,
      "domNodes": 0,
      "jsHeapTotalBytes": -20447232,
      "scriptDurationMs": 123.01499999999999,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 100.95699999999397,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 13.008,
      "layouts": 3,
      "layoutDurationMs": 1.7580000000000002,
      "taskDurationMs": 74.43400000000001,
      "heapDeltaBytes": 3062548,
      "heapUsedBytes": 72314316,
      "domNodes": 127,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.947,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 100.93699999993078,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.319999999999999,
      "layouts": 2,
      "layoutDurationMs": 1.0359999999999998,
      "taskDurationMs": 66.155,
      "heapDeltaBytes": 2923668,
      "heapUsedBytes": 74772580,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 3.3349999999999995,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51183 76656 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@christian-byrne
christian-byrne removed the request for review from DrJKL October 7, 2026 11:51
@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.67347% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 80.64% 12 Missing ⚠️
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 81.81% 4 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #20416   +/-   ##
=============================================
  Coverage              ?   84.17%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128558           
  Branches              ?    34635           
=============================================
  Hits                  ?   108218           
  Misses                ?    20159           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.77% <ø> (?)
unit 79.64% <83.67%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 92.73% <100.00%> (ø)
.../workbench/extensions/agent/crdt/docFrameClient.ts 98.98% <100.00%> (ø)
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 94.81% <81.81%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 95.45% <80.64%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 3
🟡 Medium 5
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 7, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 2 — ledger: 10 prior finding(s) across 1 round(s) (0 never answered).

Found 10 finding(s).

Severity Count
🟠 High 4
🟡 Medium 4
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Comment. This is a release-only fix with no counterpart on main, so I cannot verify it as a backport, and it needs a full review.

The description names no source PR. It presents this as the direct successor to #20312 (0bd97d8c27), which adapted #19032 (3235c9c4c9) to cloud/1.54's older follower architecture without cherry-picking it. The changes here answer post-merge automated review findings on #20312 and on this PR:

  • bounded reseed retries and terminal failures
  • abandoning ambiguous lineages on timeout, reconnect and conflict
  • holding and replaying post-snapshot human edits
  • the serialization_failed terminal reason
  • the UTF-8 frame-size check

I searched main for these and found none of them. Neither reseedHeldOperations, reseedAttempts nor serialization_failed exists there, and main's reseed lives in the separate AgentCrdtDocLifecycle/projection code that cloud/1.54 lacks. So there is no merged source diff to compare hunk by hunk. The behavior in useAgentCrdtFollower.ts, layoutFollowerBridge.ts, docFrameClient.ts and AgentPanelRoot.vue needs to be reviewed on its own merits. The latest automated pass at 1395d5f also raised new High-severity findings in those files that are still open.

CI at 1395d5f: lint-and-format passes. e2e-status fails because shard 3 fails "Sign-in dialog resolves true on login" in browser_tests/tests/dialog.spec.ts. That is the same sign-in harness failure seen on other cloud/1.54 PRs, and this diff does not touch it.

I have not approved or rejected this as a backport. A reviewer who owns the cloud/1.54 agent follower should review it in full.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 7, 2026

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Comment. This is still a release-only fix with no counterpart on main, so I cannot verify it as a backport, and it needs a full review.

The only change since my previous review (at 1395d5f) is 94c3ecc, a merge of cloud/1.54. It brings in #20406, #20379 and #20439. The PR's own diff against the branch is unchanged: the same 6 files and +290/-29, byte for byte.

My earlier finding stands. This PR follows up #20312, which was itself a release-native adaptation of #19032, and its reseed changes do not exist on main. Neither reseedHeldOperations, reseedAttempts nor serialization_failed appears there. So there is no merged source diff to compare, and the changes to useAgentCrdtFollower.ts, layoutFollowerBridge.ts, docFrameClient.ts and AgentPanelRoot.vue need a full review on their merits, including the automated findings still open at the previous head.

CI at 94c3ecc is now green: lint-and-format, typecheck, test and e2e-status. The sign-in dialog failure is gone after #20439's test isolation landed on cloud/1.54.

I have not approved or rejected this as a backport.

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Comment. This is still a release-only fix with no counterpart on main, so I cannot verify it as a backport, and it needs a full review.

Since my previous review at 94c3ecc, ten commits (f948ab0 through eb51b45) extend the reseed hardening. They answer the automated findings left open there. The net diff against cloud/1.54 is now 11 files and +645/-49, including new browser-test fixtures and an agentHumanAddTabSwitch.spec.ts case. The changes cover:

  • coupling held reseed edits into a single pendingReseed envelope
  • keeping the lineage on a rejected or late conflict
  • snapshotting through the workflow change tracker
  • retrying unsettled bindings
  • retaining edits across reconnect and tab suspension
  • ignoring cross-workflow results
  • one terminal cleanup path
  • preserving confirmedDeletes when the canvas is kept

None of this exists on main. The pendingReseed envelope, abandonPendingReseed, reseedAttempts and the serialization_failed reason appear only on this branch. main's reseed (#19032) is built on the separate lifecycle and projection code that cloud/1.54 lacks, and this PR follows up #20312, which was already a release-native adaptation rather than a cherry-pick. So there is still no merged source diff to compare hunk by hunk. The behavior in useAgentCrdtFollower.ts, layoutFollowerBridge.ts, docFrameClient.ts and AgentPanelRoot.vue needs a full review by an owner of the cloud/1.54 agent follower.

CI at eb51b45 was still running when I posted: test, typecheck and the e2e shards were in progress. I have not approved or rejected this as a backport.

@christian-byrne christian-byrne assigned dante01yoon and unassigned DrJKL Oct 8, 2026

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for one important regression-test gap (Gate 1), plus a contract-limit question that needs clarification before approval. The original recovery failure is proven: restoring the four pre-PR production files gives 14 failed/463 passed unit tests and the production stale-schema/tab-switch case fails with zero accepted human operations. Restoring the exact head gives 477 unit tests and the same browser case passing.

Executed on isolated exact eb51b45af9ece448724439283403d02448763218 with own frozen install:

  • Prior checkpoint PASS: 1250 unit tests/56 files plus 6 existing expected failures, app/browser types, Cloud production build, changed-file type-aware oxlint, production/browser ESLint, format and knip. Those results belong to the previous tick at this same SHA; they are not fresh executions this tick.
  • Fresh PASS: seven production Cloud Chromium journeys against an isolated local ComfyUI backend, including stale refusal → reseed → post-snapshot edit → switch away/back → confirmed host/live/activeState preservation. Auth, billing, workflow persistence and Agent/socket transport are controlled fixtures, not live customer or Agent service evidence.
  • Fresh RED: tab-hold and reconnect-hold mutations each 1 failed/88 passed; live-target guard 2/87; terminal cleanup 1/88; UTF-8 guard 1/9; confirmed-delete preservation 1/88; prepareForSave call removal 2/376. Original source/output restored: 477 unit tests and recovery browser PASS. The budget mutant instead passes the existing 89 tests; an independent scoped guard passes 90 at head and fails 1/89 with that mutant. This exposes the missing safety net, not a current-head infinite-loop claim.
  • Direct contract check: current Cloud source a759955812af678e38452717bba6ed75aa9cb8dc, actual messages.ParseDocReseed accepts the exact 168-byte small FE frame, rejects the exact 3,145,891-byte large FE frame because its workflow is 3,145,805 bytes versus the 2,097,152-byte field cap. The current real FE client sends both. An independent FE contract guard is 1 failed/1 passed. These are actual serializer/parser executions, not deployed-backend observations.

No new server response shape is declared: DocReseedSendResult describes local send outcomes; workflow/sequence authorization still comes from host frames. Existing graph/document routing and callers were inspected. No performance improvement or live incident-resolution claim is made. Latest required checks and corresponding workflow heads were queried separately; CI success does not settle the two inline points.

NOT_RUN: live customer/Cloud Agent service, native Desktop, other OS/browser, broad extension packs, full performance/media/a11y suites, and live server rollout of the contract cap. UI layout is unchanged. Unit ESLint is ignored by this release config; actual type-aware oxlint ran. A temporary budget probe initially sat outside the suite's scoped setup and was rejected as invalid evidence; moving it inside that setup produced the head/RED results above. The sparse Go checkout initially lacked workspace modules; isolated common-module dependency installation recovered the real parser run. All temporary tests/mutations and production output were restored, both Git checkouts are clean, and the owned backend is stopped.

@dante01yoon dante01yoon removed their assignment Oct 8, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review under the standing Agent 1.54/1.55 backport grant (program/release-backport-authority.md): the coordinator may review and merge Agent backports targeting cloud/1.54 once our own gates pass. Submitting as COMMENT because GitHub does not accept an author approving their own PR; the grant permits the merge without manufacturing an approval record.

Gates checked at exact head eb51b45af9ece448724439283403d02448763218:

  • Target in scope — base is cloud/1.54.
  • Source already merged — #20312 ("fix(agent): recover stale schema on cloud/1.54") merged into cloud/1.54 on 2026-10-06T23:08:35Z. This carrier closes that PR's post-merge Cursor findings on the same release line, so it is release-line follow-up to landed Agent work, not a speculative forward port.
  • Hosted checks — 83 pass, 13 skipping, 0 failing, 0 pending. MERGEABLE, no conflicts against the current cloud/1.54 tip 2566d2fada.
  • No unresolved human objection — the only verdicts are bot COMMENTs. mrseek-reviews declines to verify this as a backport because there is no main counterpart; that is correct and expected for a fix to code that exists only on the release line, and under this grant REVIEW_REQUIRED alone is not a new human-approval requirement.
  • Acceptance evidence — browser-observable coverage in browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts, plus reseed/follower unit coverage in docFrameClient.reseed.test.ts and useAgentCrdtFollower.test.ts.

Substantive read of the diff:

  • DocFrameClient.reseed now returns a discriminated DocReseedSendResult instead of a boolean, and sizes the complete {type,data} frame in UTF-8 bytes rather than the JS string length of data alone. The previous check could pass a frame that the transport then rejected, so this closes a real undercount on multi-byte canvases.
  • Reseed is bounded: reseedAttempts is capped at SUBSCRIBE_RETRY_MAX_ATTEMPTS, and too_large / serialization_failed / host rejection are now terminal via giveUpOnReseed rather than retried forever.
  • abandonPendingReseed drops the doc and dispatches follower_replaced to the projectors before resubscribing. This is consistent with ADR-025: doc replacement is reserved for a genuine lineage break, and an in-flight reseed at reconnect/timeout is exactly an ambiguous lineage rather than an ordinary seq gap. Ordinary reconnect without a pending reseed still takes the resubscribe() path, so state-vector delta replay is preserved.
  • canvasForWorkflow now returns undefined unless the resolved target's path equals the bound tab path, so a reseed can no longer serialize a tab the agent is not actually bound to.

Two non-blocking notes for a follow-up, neither worth spending an approval on:

  1. In onSubscribed, pendingReseed = null is assigned inside the held-operations branch and then again unconditionally below it. The second assignment makes the first redundant.
  2. abandonPendingReseed(preserveCanvas = true) carries the flag only on its own follower_replaced event detail and never crosses into a shared layer, so it stays clear of the shared-layer policy leak the invariants forbid. Worth keeping that way if the signature grows.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Justification: merging with administrator privileges under the standing Agent 1.54/1.55 backport grant (program/release-backport-authority.md), whose September 20 clarification from the program lead states that release candidates "just admin merge them, since backports are allowed to merge ourselves once our own gates are passed." The grant covers Comfy-Org/ComfyUI_frontend targets core/1.54, cloud/1.54, core/1.55 and cloud/1.55, and explicitly records that REVIEW_REQUIRED alone is not a separate human-approval requirement for these carriers.

Gates passed at exact head eb51b45af9ece448724439283403d02448763218:

  • 83 required checks pass, 13 skipping, 0 failing, 0 pending.
  • MERGEABLE with no conflicts against cloud/1.54 tip 2566d2fada0becd8b6ed0bdd362af86ffc7216cb.
  • Source fix(agent): recover stale schema on cloud/1.54 #20312 already merged to the same release line on 2026-10-06; this carrier closes its post-merge review findings.
  • No unresolved human objection: the only verdicts on the PR are bot COMMENTs.
  • Diff reviewed substantively at this exact head; review and two non-blocking follow-up notes recorded above.

Administrator privileges are used for merge mechanism only. No new merge authority is claimed, no human objection is dismissed, and this does not extend to main, deployments, or any target outside the four named release branches.

@christian-byrne
christian-byrne merged commit cca0b09 into cloud/1.54 Oct 8, 2026
108 checks passed
@christian-byrne
christian-byrne deleted the christian/stale-schema-recovery-cloud154-followup branch October 8, 2026 00:36
christian-byrne added a commit that referenced this pull request Oct 8, 2026
## Summary

- reject reseed workflows above Cloud’s 2 MiB inline workflow-field
limit before transport
- cover the exact UTF-8 byte boundary, including multibyte payloads
- prove reseed attempts remain bounded across inactive/active tab
transitions

Follow-up to #20416. Supports PM-1793 and PM-1794.

## Testing

- `pnpm exec vitest run
src/workbench/extensions/agent/crdt/docFrameClient.reseed.test.ts
src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` (100
passed)
- `pnpm typecheck`
- focused oxlint/ESLint/format checks and pre-push knip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants