Repository navigation
fix(agent): close cloud/1.54 reseed safety gaps - #20416
christian-byrne merged 13 commits into
Conversation
Addresses post-merge review findings on #20312:\nhttps://github.com//pull/20312#pullrequestreview-5434364237
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 97 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-07T21:49:17.179Z",
"gitSha": "3f606637be40f5a6b9149b021697d4ff24801c29",
"branch": "christian/stale-schema-recovery-cloud154-followup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2086.5380000000187,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.618,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.553,
"heapDeltaBytes": -8851448,
"heapUsedBytes": 64575232,
"domNodes": -278,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 11.201999999999996,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2034.6339999999827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.486999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.104,
"heapDeltaBytes": -1323656,
"heapUsedBytes": 72670520,
"domNodes": -283,
"jsHeapTotalBytes": 4227072,
"scriptDurationMs": 9.588,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.9609999999734,
"styleRecalcs": 74,
"styleRecalcDurationMs": 24.930999999999997,
"layouts": 14,
"layoutDurationMs": 4.169,
"taskDurationMs": 815.46,
"heapDeltaBytes": -6673040,
"heapUsedBytes": 64855280,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 133.998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1753.0179999999973,
"styleRecalcs": 73,
"styleRecalcDurationMs": 22.532000000000004,
"layouts": 14,
"layoutDurationMs": 3.683,
"taskDurationMs": 769.7769999999999,
"heapDeltaBytes": 833424,
"heapUsedBytes": 74607092,
"domNodes": -282,
"jsHeapTotalBytes": 4489216,
"scriptDurationMs": 132.745,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.057000000012,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.877999999999998,
"layouts": 6,
"layoutDurationMs": 1.111,
"taskDurationMs": 351.566,
"heapDeltaBytes": 4542600,
"heapUsedBytes": 75725692,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.381,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.6280000000424,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.925999999999998,
"layouts": 6,
"layoutDurationMs": 1.0119999999999998,
"taskDurationMs": 326.605,
"heapDeltaBytes": 4243384,
"heapUsedBytes": 75711980,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.147999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 626.7149999999901,
"styleRecalcs": 15,
"styleRecalcDurationMs": 7.601000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.87300000000005,
"heapDeltaBytes": -7891392,
"heapUsedBytes": 63303280,
"domNodes": 22,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 145.3,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 582.4470000000019,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.257000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.5799999999999,
"heapDeltaBytes": -7208392,
"heapUsedBytes": 66826900,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 141.788,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2036.9570000000294,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.376,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.923,
"heapDeltaBytes": -3477440,
"heapUsedBytes": 76573568,
"domNodes": -271,
"jsHeapTotalBytes": -1802240,
"scriptDurationMs": 35.818,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.6550000000234,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.092,
"heapDeltaBytes": 13845156,
"heapUsedBytes": 91084216,
"domNodes": -281,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 36.507,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2116.51999999998,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.971999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1377.23,
"heapDeltaBytes": 898780,
"heapUsedBytes": 67184936,
"domNodes": 2,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 689.74,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2122.9050000000598,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.843000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1381.0670000000002,
"heapDeltaBytes": 965244,
"heapUsedBytes": 67314260,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 692.562,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3453.223000000037,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.187000000000001,
"layouts": 60,
"layoutDurationMs": 13.196,
"taskDurationMs": 1511.0430000000001,
"heapDeltaBytes": -419356,
"heapUsedBytes": 67377232,
"domNodes": 26,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 668.4440000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3392.357000000061,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.747999999999998,
"layouts": 60,
"layoutDurationMs": 12.86,
"taskDurationMs": 1555.7210000000002,
"heapDeltaBytes": -15290680,
"heapUsedBytes": 67376788,
"domNodes": -255,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 675.1729999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2904.5739999999682,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1724.429,
"heapDeltaBytes": 8521284,
"heapUsedBytes": 76108064,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 890.334,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2898.914999999988,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.483000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1708.6580000000001,
"heapDeltaBytes": 7973940,
"heapUsedBytes": 75944872,
"domNodes": 0,
"jsHeapTotalBytes": 454656,
"scriptDurationMs": 860.325,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.6860000000074,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3799999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.683,
"heapDeltaBytes": -5201248,
"heapUsedBytes": 77034968,
"domNodes": -271,
"jsHeapTotalBytes": -2588672,
"scriptDurationMs": 31.648999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2021.4919999999665,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.383,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.4919999999999,
"heapDeltaBytes": -5264528,
"heapUsedBytes": 76697700,
"domNodes": -267,
"jsHeapTotalBytes": -2326528,
"scriptDurationMs": 31.056999999999995,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 567.9269999999974,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.786999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.099,
"heapDeltaBytes": 14560828,
"heapUsedBytes": 88423136,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 128.608,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.3020000000688,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.079999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.84099999999995,
"heapDeltaBytes": -10546260,
"heapUsedBytes": 65344036,
"domNodes": 22,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 119.89000000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.8129999999564,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.198,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.6170000000001,
"heapDeltaBytes": -6829504,
"heapUsedBytes": 66488520,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.241,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.9190000000244,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.06100000000004,
"heapDeltaBytes": -18056612,
"heapUsedBytes": 57587100,
"domNodes": -298,
"jsHeapTotalBytes": 3702784,
"scriptDurationMs": 8.733999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.2220000000543,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.470999999999997,
"layouts": 18,
"layoutDurationMs": 4.098,
"taskDurationMs": 739.293,
"heapDeltaBytes": -23020,
"heapUsedBytes": 73736972,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 88.932,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.6730000000443,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.472,
"layouts": 18,
"layoutDurationMs": 4.95,
"taskDurationMs": 767.3389999999999,
"heapDeltaBytes": -4338344,
"heapUsedBytes": 71713848,
"domNodes": -315,
"jsHeapTotalBytes": 5799936,
"scriptDurationMs": 92.071,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1083.4149999999454,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.068999999999996,
"layouts": 15,
"layoutDurationMs": 12.409,
"taskDurationMs": 825.766,
"heapDeltaBytes": -8875316,
"heapUsedBytes": 83464068,
"domNodes": 13831,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 25.758999999999997,
"eventListeners": 2387,
"totalBlockingTimeMs": 134,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8201.623999999982,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.766000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5120.427000000001,
"heapDeltaBytes": 17281548,
"heapUsedBytes": 94475912,
"domNodes": -282,
"jsHeapTotalBytes": 3002368,
"scriptDurationMs": 2376.319,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8166.027999999983,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.17,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4893.009,
"heapDeltaBytes": 1827248,
"heapUsedBytes": 67504552,
"domNodes": -268,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 2310.676,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14794.381999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14252.725000000002,
"heapDeltaBytes": -55025616,
"heapUsedBytes": 178291200,
"domNodes": -8068,
"jsHeapTotalBytes": -12070912,
"scriptDurationMs": 233.50199999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14780.231999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14009.854,
"heapDeltaBytes": -49151824,
"heapUsedBytes": 183316640,
"domNodes": -8068,
"jsHeapTotalBytes": -15138816,
"scriptDurationMs": 292.06699999999995,
"eventListeners": -14929,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17594.68099999998,
"styleRecalcs": 148,
"styleRecalcDurationMs": 19.43900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17189.157000000003,
"heapDeltaBytes": -52233220,
"heapUsedBytes": 170200000,
"domNodes": -8068,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 899.161,
"eventListeners": -14931,
"totalBlockingTimeMs": 105,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17706.481999999938,
"styleRecalcs": 148,
"styleRecalcDurationMs": 19.343999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17299.170000000002,
"heapDeltaBytes": -27215648,
"heapUsedBytes": 193638532,
"domNodes": -8068,
"jsHeapTotalBytes": -10829824,
"scriptDurationMs": 848.5100000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5284.587999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.91199999999998,
"layouts": 20,
"layoutDurationMs": 35.76299999999999,
"taskDurationMs": 5206.482,
"heapDeltaBytes": -48765180,
"heapUsedBytes": 176873956,
"domNodes": -8067,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 95.582,
"eventListeners": -14927,
"totalBlockingTimeMs": 210,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5141.99300000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.85400000000003,
"layouts": 20,
"layoutDurationMs": 24.038000000000004,
"taskDurationMs": 5049.2339999999995,
"heapDeltaBytes": -44887056,
"heapUsedBytes": 177831488,
"domNodes": -8068,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 118.00900000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 167,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7301.427999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6950.566,
"heapDeltaBytes": -3812908,
"heapUsedBytes": 178626520,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 116.14000000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7337.281999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7055.876999999999,
"heapDeltaBytes": 973324,
"heapUsedBytes": 177614248,
"domNodes": 0,
"jsHeapTotalBytes": -20447232,
"scriptDurationMs": 123.01499999999999,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 100.95699999999397,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.008,
"layouts": 3,
"layoutDurationMs": 1.7580000000000002,
"taskDurationMs": 74.43400000000001,
"heapDeltaBytes": 3062548,
"heapUsedBytes": 72314316,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.947,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 100.93699999993078,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.319999999999999,
"layouts": 2,
"layoutDurationMs": 1.0359999999999998,
"taskDurationMs": 66.155,
"heapDeltaBytes": 2923668,
"heapUsedBytes": 74772580,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.3349999999999995,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #20416 +/- ##
=============================================
Coverage ? 84.17%
=============================================
Files ? 2132
Lines ? 128558
Branches ? 34635
=============================================
Hits ? 108218
Misses ? 20159
Partials ? 181
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 5 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (0 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
There was a problem hiding this comment.
Verdict: Comment. This is a release-only fix with no counterpart on main, so I cannot verify it as a backport, and it needs a full review.
The description names no source PR. It presents this as the direct successor to #20312 (0bd97d8c27), which adapted #19032 (3235c9c4c9) to cloud/1.54's older follower architecture without cherry-picking it. The changes here answer post-merge automated review findings on #20312 and on this PR:
- bounded reseed retries and terminal failures
- abandoning ambiguous lineages on timeout, reconnect and conflict
- holding and replaying post-snapshot human edits
- the
serialization_failedterminal reason - the UTF-8 frame-size check
I searched main for these and found none of them. Neither reseedHeldOperations, reseedAttempts nor serialization_failed exists there, and main's reseed lives in the separate AgentCrdtDocLifecycle/projection code that cloud/1.54 lacks. So there is no merged source diff to compare hunk by hunk. The behavior in useAgentCrdtFollower.ts, layoutFollowerBridge.ts, docFrameClient.ts and AgentPanelRoot.vue needs to be reviewed on its own merits. The latest automated pass at 1395d5f also raised new High-severity findings in those files that are still open.
CI at 1395d5f: lint-and-format passes. e2e-status fails because shard 3 fails "Sign-in dialog resolves true on login" in browser_tests/tests/dialog.spec.ts. That is the same sign-in harness failure seen on other cloud/1.54 PRs, and this diff does not touch it.
I have not approved or rejected this as a backport. A reviewer who owns the cloud/1.54 agent follower should review it in full.
There was a problem hiding this comment.
Verdict: Comment. This is still a release-only fix with no counterpart on main, so I cannot verify it as a backport, and it needs a full review.
The only change since my previous review (at 1395d5f) is 94c3ecc, a merge of cloud/1.54. It brings in #20406, #20379 and #20439. The PR's own diff against the branch is unchanged: the same 6 files and +290/-29, byte for byte.
My earlier finding stands. This PR follows up #20312, which was itself a release-native adaptation of #19032, and its reseed changes do not exist on main. Neither reseedHeldOperations, reseedAttempts nor serialization_failed appears there. So there is no merged source diff to compare, and the changes to useAgentCrdtFollower.ts, layoutFollowerBridge.ts, docFrameClient.ts and AgentPanelRoot.vue need a full review on their merits, including the automated findings still open at the previous head.
CI at 94c3ecc is now green: lint-and-format, typecheck, test and e2e-status. The sign-in dialog failure is gone after #20439's test isolation landed on cloud/1.54.
I have not approved or rejected this as a backport.
Addresses review feedback: #20416 (comment)
Addresses review feedback: #20416 (comment)
Addresses review feedback: #20416 (comment)
Addresses review feedback: #20416 (comment)
Addresses review feedback: #20416 (comment)
Addresses review feedback: #20416 (comment)
Addresses review feedback: #20416 (comment)
Addresses review feedback: #20416 (comment)
There was a problem hiding this comment.
Verdict: Comment. This is still a release-only fix with no counterpart on main, so I cannot verify it as a backport, and it needs a full review.
Since my previous review at 94c3ecc, ten commits (f948ab0 through eb51b45) extend the reseed hardening. They answer the automated findings left open there. The net diff against cloud/1.54 is now 11 files and +645/-49, including new browser-test fixtures and an agentHumanAddTabSwitch.spec.ts case. The changes cover:
- coupling held reseed edits into a single
pendingReseedenvelope - keeping the lineage on a rejected or late conflict
- snapshotting through the workflow change tracker
- retrying unsettled bindings
- retaining edits across reconnect and tab suspension
- ignoring cross-workflow results
- one terminal cleanup path
- preserving
confirmedDeleteswhen the canvas is kept
None of this exists on main. The pendingReseed envelope, abandonPendingReseed, reseedAttempts and the serialization_failed reason appear only on this branch. main's reseed (#19032) is built on the separate lifecycle and projection code that cloud/1.54 lacks, and this PR follows up #20312, which was already a release-native adaptation rather than a cherry-pick. So there is still no merged source diff to compare hunk by hunk. The behavior in useAgentCrdtFollower.ts, layoutFollowerBridge.ts, docFrameClient.ts and AgentPanelRoot.vue needs a full review by an owner of the cloud/1.54 agent follower.
CI at eb51b45 was still running when I posted: test, typecheck and the e2e shards were in progress. I have not approved or rejected this as a backport.
dante01yoon
left a comment
There was a problem hiding this comment.
Requesting changes for one important regression-test gap (Gate 1), plus a contract-limit question that needs clarification before approval. The original recovery failure is proven: restoring the four pre-PR production files gives 14 failed/463 passed unit tests and the production stale-schema/tab-switch case fails with zero accepted human operations. Restoring the exact head gives 477 unit tests and the same browser case passing.
Executed on isolated exact eb51b45af9ece448724439283403d02448763218 with own frozen install:
- Prior checkpoint PASS: 1250 unit tests/56 files plus 6 existing expected failures, app/browser types, Cloud production build, changed-file type-aware oxlint, production/browser ESLint, format and knip. Those results belong to the previous tick at this same SHA; they are not fresh executions this tick.
- Fresh PASS: seven production Cloud Chromium journeys against an isolated local ComfyUI backend, including stale refusal → reseed → post-snapshot edit → switch away/back → confirmed host/live/activeState preservation. Auth, billing, workflow persistence and Agent/socket transport are controlled fixtures, not live customer or Agent service evidence.
- Fresh RED: tab-hold and reconnect-hold mutations each 1 failed/88 passed; live-target guard 2/87; terminal cleanup 1/88; UTF-8 guard 1/9; confirmed-delete preservation 1/88; prepareForSave call removal 2/376. Original source/output restored: 477 unit tests and recovery browser PASS. The budget mutant instead passes the existing 89 tests; an independent scoped guard passes 90 at head and fails 1/89 with that mutant. This exposes the missing safety net, not a current-head infinite-loop claim.
- Direct contract check: current Cloud source
a759955812af678e38452717bba6ed75aa9cb8dc, actualmessages.ParseDocReseedaccepts the exact 168-byte small FE frame, rejects the exact 3,145,891-byte large FE frame because its workflow is 3,145,805 bytes versus the 2,097,152-byte field cap. The current real FE client sends both. An independent FE contract guard is 1 failed/1 passed. These are actual serializer/parser executions, not deployed-backend observations.
No new server response shape is declared: DocReseedSendResult describes local send outcomes; workflow/sequence authorization still comes from host frames. Existing graph/document routing and callers were inspected. No performance improvement or live incident-resolution claim is made. Latest required checks and corresponding workflow heads were queried separately; CI success does not settle the two inline points.
NOT_RUN: live customer/Cloud Agent service, native Desktop, other OS/browser, broad extension packs, full performance/media/a11y suites, and live server rollout of the contract cap. UI layout is unchanged. Unit ESLint is ignored by this release config; actual type-aware oxlint ran. A temporary budget probe initially sat outside the suite's scoped setup and was rejected as invalid evidence; moving it inside that setup produced the head/RED results above. The sparse Go checkout initially lacked workspace modules; isolated common-module dependency installation recovered the real parser run. All temporary tests/mutations and production output were restored, both Git checkouts are clean, and the owned backend is stopped.
christian-byrne
left a comment
There was a problem hiding this comment.
Review under the standing Agent 1.54/1.55 backport grant (program/release-backport-authority.md): the coordinator may review and merge Agent backports targeting cloud/1.54 once our own gates pass. Submitting as COMMENT because GitHub does not accept an author approving their own PR; the grant permits the merge without manufacturing an approval record.
Gates checked at exact head eb51b45af9ece448724439283403d02448763218:
- Target in scope — base is
cloud/1.54. - Source already merged — #20312 ("fix(agent): recover stale schema on cloud/1.54") merged into
cloud/1.54on 2026-10-06T23:08:35Z. This carrier closes that PR's post-merge Cursor findings on the same release line, so it is release-line follow-up to landed Agent work, not a speculative forward port. - Hosted checks — 83 pass, 13 skipping, 0 failing, 0 pending.
MERGEABLE, no conflicts against the currentcloud/1.54tip2566d2fada. - No unresolved human objection — the only verdicts are bot
COMMENTs.mrseek-reviewsdeclines to verify this as a backport because there is nomaincounterpart; that is correct and expected for a fix to code that exists only on the release line, and under this grantREVIEW_REQUIREDalone is not a new human-approval requirement. - Acceptance evidence — browser-observable coverage in
browser_tests/tests/agent/agentHumanAddTabSwitch.spec.ts, plus reseed/follower unit coverage indocFrameClient.reseed.test.tsanduseAgentCrdtFollower.test.ts.
Substantive read of the diff:
DocFrameClient.reseednow returns a discriminatedDocReseedSendResultinstead of a boolean, and sizes the complete{type,data}frame in UTF-8 bytes rather than the JS string length ofdataalone. The previous check could pass a frame that the transport then rejected, so this closes a real undercount on multi-byte canvases.- Reseed is bounded:
reseedAttemptsis capped atSUBSCRIBE_RETRY_MAX_ATTEMPTS, andtoo_large/serialization_failed/ host rejection are now terminal viagiveUpOnReseedrather than retried forever. abandonPendingReseeddrops the doc and dispatchesfollower_replacedto the projectors before resubscribing. This is consistent with ADR-025: doc replacement is reserved for a genuine lineage break, and an in-flight reseed at reconnect/timeout is exactly an ambiguous lineage rather than an ordinary seq gap. Ordinary reconnect without a pending reseed still takes theresubscribe()path, so state-vector delta replay is preserved.canvasForWorkflownow returnsundefinedunless the resolved target'spathequals the bound tab path, so a reseed can no longer serialize a tab the agent is not actually bound to.
Two non-blocking notes for a follow-up, neither worth spending an approval on:
- In
onSubscribed,pendingReseed = nullis assigned inside the held-operations branch and then again unconditionally below it. The second assignment makes the first redundant. abandonPendingReseed(preserveCanvas = true)carries the flag only on its ownfollower_replacedevent detail and never crosses into a shared layer, so it stays clear of the shared-layer policy leak the invariants forbid. Worth keeping that way if the signature grows.
|
Justification: merging with administrator privileges under the standing Agent 1.54/1.55 backport grant ( Gates passed at exact head
Administrator privileges are used for merge mechanism only. No new merge authority is claimed, no human objection is dismissed, and this does not extend to |
## Summary - reject reseed workflows above Cloud’s 2 MiB inline workflow-field limit before transport - cover the exact UTF-8 byte boundary, including multibyte payloads - prove reseed attempts remain bounded across inactive/active tab transitions Follow-up to #20416. Supports PM-1793 and PM-1794. ## Testing - `pnpm exec vitest run src/workbench/extensions/agent/crdt/docFrameClient.reseed.test.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts` (100 passed) - `pnpm typecheck` - focused oxlint/ESLint/format checks and pre-push knip
Direct successor to #20312. Closes its post-merge Cursor findings before cloud/1.54 delivery is considered complete.
Verification:
Tracks PM-1793 and PM-1794.
Review source: #20312 (review)