Repository navigation
refactor(agent): doc reseed review nits - #20264
Conversation
- Mark the retryable reseed codes `as const`; the set is typed as a string set so lookups by an arbitrary code still compile. - Read the awareness state with two plain checks in order (malformed, then over budget) instead of a ternary inside an `if`. Same behavior.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 03bca8ad7f4c928cdc860e34f44ba5274454e1e8
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.33 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 4.25 kB (baseline 4.25 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 2.08 MB (baseline 2.08 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 144 kB (baseline 144 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 670 kB (baseline 670 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 137 kB (baseline 137 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 11 unchanged UI Components — 213 kB (baseline 213 kB) • ⚪ 0 BReusable component library chunks Status: 23 unchanged Data & Services — 3.41 MB (baseline 3.41 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 22 unchanged Utilities & Hooks — 736 kB (baseline 736 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 48 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.7 MB (baseline 18.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 335 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-08T04:36:04.513Z",
"gitSha": "a03ce4cb0acc4cbe8cf0f5c88855b182d9e06d96",
"branch": "kishore/agent-docframe-nits",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.7280000000292,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.751000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.33399999999995,
"heapDeltaBytes": 10529804,
"heapUsedBytes": 80466256,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.406000000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2022.784999999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.746000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.2529999999999,
"heapDeltaBytes": 10403892,
"heapUsedBytes": 79960956,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.192999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1764.866999999981,
"styleRecalcs": 55,
"styleRecalcDurationMs": 15.275,
"layouts": 12,
"layoutDurationMs": 4.621,
"taskDurationMs": 866.5379999999999,
"heapDeltaBytes": -52627284,
"heapUsedBytes": 56749824,
"domNodes": -212,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 157.79600000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.9039999999432,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.583000000000002,
"layouts": 12,
"layoutDurationMs": 4.548,
"taskDurationMs": 890.2480000000002,
"heapDeltaBytes": 6051480,
"heapUsedBytes": 76791704,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 172.176,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864867,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.1349999999793,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.603,
"layouts": 3,
"layoutDurationMs": 0.858,
"taskDurationMs": 395.915,
"heapDeltaBytes": 7721456,
"heapUsedBytes": 72058836,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.759999999999998,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1702.6959999999463,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.803000000000002,
"layouts": 3,
"layoutDurationMs": 0.8450000000000003,
"taskDurationMs": 420.867,
"heapDeltaBytes": 11318168,
"heapUsedBytes": 81848416,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.647000000000002,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.8950000000268,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.224,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.005,
"heapDeltaBytes": -38813904,
"heapUsedBytes": 71357844,
"domNodes": -212,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 177.377,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.06428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 742.8620000000592,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.054,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.077,
"heapDeltaBytes": -7712344,
"heapUsedBytes": 56979196,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.097,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909075,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1201.6649999999913,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.7800000000001,
"heapDeltaBytes": 17058672,
"heapUsedBytes": 102506864,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 78.90599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 572,
"frameDurationMs": 35.291176470588226,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1220.4179999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 918.802,
"heapDeltaBytes": 11749044,
"heapUsedBytes": 97030048,
"domNodes": 0,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 75.738,
"eventListeners": 0,
"totalBlockingTimeMs": 575,
"frameDurationMs": 35.782352941176484,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.4090000000137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.96000000000004,
"heapDeltaBytes": -6944208,
"heapUsedBytes": 80290732,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 162.90500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 872.3500000000968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.7929999999996,
"heapDeltaBytes": 19201476,
"heapUsedBytes": 107393804,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 171.81599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10434.731,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9494.019999999999,
"heapDeltaBytes": 25824816,
"heapUsedBytes": 96352256,
"domNodes": -141,
"jsHeapTotalBytes": -9310208,
"scriptDurationMs": 7698.407,
"eventListeners": -47,
"totalBlockingTimeMs": 1013,
"frameDurationMs": 31.379879879879873,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10545.189999999933,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09599999999999886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9534.488,
"heapDeltaBytes": 21044768,
"heapUsedBytes": 94927324,
"domNodes": -141,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 8114.302000000001,
"eventListeners": -65,
"totalBlockingTimeMs": 1236,
"frameDurationMs": 32.01489361702127,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10434.523000000012,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5279999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9589.475,
"heapDeltaBytes": -10608512,
"heapUsedBytes": 78141428,
"domNodes": -141,
"jsHeapTotalBytes": -3280896,
"scriptDurationMs": 7904.33,
"eventListeners": -73,
"totalBlockingTimeMs": 1195,
"frameDurationMs": 31.424397590361444,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10342.889000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9505.043,
"heapDeltaBytes": -11125808,
"heapUsedBytes": 72842052,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 7772.817,
"eventListeners": 0,
"totalBlockingTimeMs": 1055,
"frameDurationMs": 30.936826347305388,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2022.7029999999786,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7890000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.1449999999999,
"heapDeltaBytes": -2079548,
"heapUsedBytes": 81016372,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.364000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.7020000000484,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.7620000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 700.1020000000001,
"heapDeltaBytes": -47795684,
"heapUsedBytes": 85565280,
"domNodes": -308,
"jsHeapTotalBytes": -4292608,
"scriptDurationMs": 38.235,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2444.5350000000303,
"styleRecalcs": 66,
"styleRecalcDurationMs": 6.150999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.398,
"heapDeltaBytes": 16349856,
"heapUsedBytes": 81651756,
"domNodes": -308,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 849.7909999999999,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.780136986301372,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2446.419999999989,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1721.5510000000004,
"heapDeltaBytes": -5901584,
"heapUsedBytes": 86760024,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 892.3749999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3562.225000000012,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.277999999999999,
"layouts": 60,
"layoutDurationMs": 17.003999999999998,
"taskDurationMs": 1632.0620000000001,
"heapDeltaBytes": -15271412,
"heapUsedBytes": 70244084,
"domNodes": 24,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 820.222,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467286,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3769.0620000000763,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.015,
"layouts": 60,
"layoutDurationMs": 16.5,
"taskDurationMs": 1788.912,
"heapDeltaBytes": 8403636,
"heapUsedBytes": 76403432,
"domNodes": -284,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 808.448,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66592920353982,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3139.887999999985,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.658,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2007.4420000000002,
"heapDeltaBytes": -6901924,
"heapUsedBytes": 79231524,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1020.6790000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.845161290322583,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3120.7670000000007,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.071999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1959.1119999999999,
"heapDeltaBytes": 21085516,
"heapUsedBytes": 89253428,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 974.6429999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846486486486487,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.3919999999925,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.2050000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.5399999999998,
"heapDeltaBytes": -21529880,
"heapUsedBytes": 85829116,
"domNodes": -308,
"jsHeapTotalBytes": -4329472,
"scriptDurationMs": 35.474,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2028.5699999999451,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.9679999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.5969999999999,
"heapDeltaBytes": 20229280,
"heapUsedBytes": 85529768,
"domNodes": -308,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.916,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 542.4330000000737,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.344999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.69499999999994,
"heapDeltaBytes": -9635660,
"heapUsedBytes": 62393592,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.25199999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.5919999999878,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.960999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.12600000000003,
"heapDeltaBytes": -42664580,
"heapUsedBytes": 69254752,
"domNodes": -228,
"jsHeapTotalBytes": -5505024,
"scriptDurationMs": 147.622,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.3740000000134,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9140000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.104,
"heapDeltaBytes": 6968152,
"heapUsedBytes": 73471648,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.435,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2056.242999999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.898,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.972,
"heapDeltaBytes": -31854872,
"heapUsedBytes": 60440580,
"domNodes": -250,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 13.853000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1792.2939999999699,
"styleRecalcs": 60,
"styleRecalcDurationMs": 17.876,
"layouts": 16,
"layoutDurationMs": 7.35,
"taskDurationMs": 895.469,
"heapDeltaBytes": -33141712,
"heapUsedBytes": 77789372,
"domNodes": -230,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 114.075,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.5790000000006,
"styleRecalcs": 57,
"styleRecalcDurationMs": 17.138,
"layouts": 16,
"layoutDurationMs": 7.2909999999999995,
"taskDurationMs": 842.772,
"heapDeltaBytes": 23789400,
"heapUsedBytes": 79720436,
"domNodes": -230,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.613,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.2730000000229,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.039000000000005,
"layouts": 6,
"layoutDurationMs": 15.754000000000001,
"taskDurationMs": 1061.524,
"heapDeltaBytes": 31878908,
"heapUsedBytes": 109667392,
"domNodes": 14650,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 33.472,
"eventListeners": 2456,
"totalBlockingTimeMs": 141,
"frameDurationMs": 19.406849315068502,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9200.967000000048,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.95,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5997.763,
"heapDeltaBytes": 25316264,
"heapUsedBytes": 90606724,
"domNodes": -308,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2787.9559999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.696370235934666,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9702.391000000034,
"styleRecalcs": 250,
"styleRecalcDurationMs": 21.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6195.357,
"heapDeltaBytes": -42577540,
"heapUsedBytes": 90397484,
"domNodes": -308,
"jsHeapTotalBytes": -3051520,
"scriptDurationMs": 2869.5779999999995,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.694655172413796,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 19129.272000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18598.476,
"heapDeltaBytes": -36000788,
"heapUsedBytes": 184338676,
"domNodes": -3046,
"jsHeapTotalBytes": 6692864,
"scriptDurationMs": 301.45700000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.78902229845625,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 13693.439000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12907.700000000003,
"heapDeltaBytes": -43005836,
"heapUsedBytes": 187904396,
"domNodes": -3046,
"jsHeapTotalBytes": 13012992,
"scriptDurationMs": 228.58,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.34948805460751,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 23946.735999999986,
"styleRecalcs": 180,
"styleRecalcDurationMs": 21.37,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23581.681,
"heapDeltaBytes": -40479120,
"heapUsedBytes": 189616720,
"domNodes": -3046,
"jsHeapTotalBytes": 9490432,
"scriptDurationMs": 938.1129999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 25,
"frameDurationMs": 45.35776515151515,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 23768.748999999956,
"styleRecalcs": 179,
"styleRecalcDurationMs": 20.28699999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23495.374000000003,
"heapDeltaBytes": -41915484,
"heapUsedBytes": 189943948,
"domNodes": -3046,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 955.101,
"eventListeners": -14913,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.12770398481974,
"p95FrameDurationMs": 83.5
},
{
"name": "vue-node-resize-workload",
"durationMs": 6948.900999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.18699999999995,
"layouts": 20,
"layoutDurationMs": 29.227000000000004,
"taskDurationMs": 6805.978999999999,
"heapDeltaBytes": -10102344,
"heapUsedBytes": 216450444,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 119.64299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.739181286549716,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 6813.074000000029,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.27400000000002,
"layouts": 20,
"layoutDurationMs": 26.993000000000002,
"taskDurationMs": 6737.938000000001,
"heapDeltaBytes": -13665036,
"heapUsedBytes": 216407504,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 117.904,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.174712643678156,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9810.932999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9504.046999999999,
"heapDeltaBytes": -26516720,
"heapUsedBytes": 190584300,
"domNodes": -3046,
"jsHeapTotalBytes": 14893056,
"scriptDurationMs": 163.78400000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.026388888888896,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9723.833000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9472.561,
"heapDeltaBytes": -31003560,
"heapUsedBytes": 184826104,
"domNodes": -3046,
"jsHeapTotalBytes": 8966144,
"scriptDurationMs": 161.127,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.04863945578232,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "workflow-execution",
"durationMs": 171.17799999994077,
"styleRecalcs": 12,
"styleRecalcDurationMs": 22.147,
"layouts": 4,
"layoutDurationMs": 2.2900000000000005,
"taskDurationMs": 160.48700000000002,
"heapDeltaBytes": -51559260,
"heapUsedBytes": 55990888,
"domNodes": 103,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 12.882000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.377777777777737,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 491.49899999997615,
"styleRecalcs": 17,
"styleRecalcDurationMs": 15.685999999999998,
"layouts": 3,
"layoutDurationMs": 0.897,
"taskDurationMs": 207.653,
"heapDeltaBytes": -51279708,
"heapUsedBytes": 57090644,
"domNodes": -139,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 11.229000000000001,
"eventListeners": -58,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517236,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 931.402999999932,
"styleRecalcs": 77,
"styleRecalcDurationMs": 98.402,
"layouts": 76,
"layoutDurationMs": 28.392,
"taskDurationMs": 899.212,
"heapDeltaBytes": 18136852,
"heapUsedBytes": 94600844,
"domNodes": 77,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 369.69399999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571417,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1145.2639999999974,
"styleRecalcs": 77,
"styleRecalcDurationMs": 106.52799999999999,
"layouts": 76,
"layoutDurationMs": 31.043000000000003,
"taskDurationMs": 1101.697,
"heapDeltaBytes": 19992500,
"heapUsedBytes": 97615936,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 462.353,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.162686567164172,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1483.0839999999625,
"styleRecalcs": 77,
"styleRecalcDurationMs": 264.778,
"layouts": 76,
"layoutDurationMs": 30.201999999999998,
"taskDurationMs": 1464.98,
"heapDeltaBytes": 14157700,
"heapUsedBytes": 140617808,
"domNodes": 77,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 503.40400000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.31234567901234,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1541.1139999999932,
"styleRecalcs": 77,
"styleRecalcDurationMs": 281.911,
"layouts": 76,
"layoutDurationMs": 31.892999999999997,
"taskDurationMs": 1519.2089999999998,
"heapDeltaBytes": -18819800,
"heapUsedBytes": 119108528,
"domNodes": 77,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 515.342,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.90121951219514,
"p95FrameDurationMs": 33.30000000000109
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2101 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe awareness parser classifies state as absent, present, or invalid. It omits absent state, includes valid state, and rejects malformed or over-budget state. Tests cover these cases. The retryable reseed code set retains its four values, and its predicate narrows to the retryable code type. ChangesCRDT frame parsing
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established; this change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20264 +/- ##
==========================================
+ Coverage 85.14% 86.54% +1.39%
==========================================
Files 3486 2517 -969
Lines 167968 142265 -25703
Branches 45990 39883 -6107
==========================================
- Hits 143022 123120 -19902
+ Misses 22968 18759 -4209
+ Partials 1978 386 -1592
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1584 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: 236e9e0 | Docs | View more details | Give us feedback! |
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation failed to run ( Evaluation budget remaining for this pull request: 99 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
Replace the null/undefined split with { ok: true; state } | { ok: false }.
Cover absent, null, malformed, over-budget, and valid state in one table.
Replace the { ok, state | null } result with a kind union (state, absent,
invalid) so no variant carries a meaningful null. The awareness parser
rejects invalid, omits state when absent, and passes the record otherwise.
Behavior is unchanged.
There was a problem hiding this comment.
Verdict: ready for human review. Behavior is unchanged and the three-way result answers the union request; what remains is P3 polish in the test table, two comments, an inert as const, and a stale PR description.
I ran the awareness parser at this head and at origin/main over 30 state shapes crossed with 8 expires_at shapes, and every output matched, including which keys are present. The order swap is safe because isAbsent(x) implies parseRecord(x) === null. Inlining the two checks does trip fallow (estimated CRAP 37.1 for awareness against a threshold of 30), so the helper earns its place. Nine inline comments follow, all P3; five carry a committable suggestion.
Findings without an anchorable line (2)
- P3: the PR description predates the last two commits. It says the state is read "with two plain checks in order", but
2f66351and19b687eadded theAwarenessStateResultunion (docFrameClient.ts:344-347) that DrJKL asked for, and folded three tests into a six-rowit.fortable. Neither appears in the body, so the squash message will not record them. Two smaller wording problems:- "CRAP 37 at threshold": the default threshold is 30 and
.fallowrc.jsoncdoes not override it, so 37 is seven over, not at it. - "mark the retryable reseed codes
as const(typed as a string set so lookups still compile)": theReadonlySet<string>annotation is what changed the type; theas constadds nothing under it (inline comment ondocFrameCodes.ts:9).
- "CRAP 37 at threshold": the default threshold is 30 and
- P3: the body skips the repository template. AGENTS.md asks PRs to follow
.github/pull_request_template.md, which has## Summary,## Changesand## Review Focus. The existing sentences fit under those headings; Screenshots can go since nothing visible changed.
Existing findings (3, all addressed at this head)
- DrJKL r4190780783, discriminated union instead of a null vs undefined distinction: addressed.
parseAwarenessStatereturns{ kind: 'state' | 'absent' | 'invalid' }(docFrameClient.ts:344-358) and the caller switches onkind(:427-435). - github-actions r4190790862, tri-state return inverts the file's null/undefined sentinel convention: addressed by the same change; no sentinel is left to misread.
- DrJKL r4201050228 / r4201059857, no significant
null: addressed in19b687e. Mutations that treat null as invalid, drop the absent arm, or accept invalid state each turn a table row red.
Review record
- DrJKL r4190780783 (union, not null vs undefined): addressed in
2f66351and19b687e, author reply r4192311576. - github-actions r4190790862 (sentinel inversion, Low): addressed in
2f66351, author reply r4192311793. - DrJKL r4201050228 / r4201059857 (no significant null): addressed in
19b687e, author reply r4201130523. - This review: nine P3 inline items and two P3 body items, all open.
Checks at 19b687e: vitest run src/workbench/extensions/agent/crdt/docFrameClient 134/134 pass; pnpm typecheck exit 0; oxlint --type-aware and oxfmt --check on the three files clean; eslint clean (it ignores the test file, oxlint covers it); head-vs-main equivalence over 242 inputs all equal; fallow on the inlined variant 37.1 vs 30; mutation runs on the parser and the test table as cited inline.
Checked and cleared (3)
- No test pins each member of
RETRYABLE_RESEED_CODES; dropping'error'or'overloaded'stays green. Cleared as not introduced: the set and its tests are the same onmainand this PR only changes the type. A test per member would also just restate the list. - No size row uses multibyte text, so a UTF-16-length budget survives. Cleared as not introduced: the old over-8 KiB test was ASCII-only too and
encodedJsonSizeis untouched. - The local
awarenessFramehelper (lines 5-16) duplicates__fixtures__/docFrameClient.ts. Cleared as not introduced: those lines are unchanged context. It would still be a good cleanup next time this file is touched.
Coverage
Depth standard. Lanes run: correctness (blast-radius, regression-risk-reviewer, boundary-discipline, fix-root-causes, idempotency, shared-state), maintainability (no-comments, ponytail, minimize-reader-load, subtract-before-you-add, laziness-protocol, migrate-callers), idiomaticity (typescript-best-practices, type-system-discipline), tests (designing-test-suites, reviewing-unit-tests, test-mock-quality-analysis, consolidating-test-setup, prove-it-works), documentation (technical-writing). No lane skipped. no-comments inventory: two added comment blocks, both covered inline. Open PRs touching these files (#20416, #19918, #20377, #20014, #19923) do not touch the awareness parser or the codes module.
Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com>
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: approved at 236e9e0.
I pushed 164e788 and 236e9e0 myself and applied four review suggestions in 5ad22e3, 0ef5bb9, 97e53a4 and e641473, so no independent reviewer has seen those commits. Behavior is unchanged: missing or null state keeps the frame without state, malformed or over-budget state rejects it, and a valid record passes through.
Review record
Earlier rounds:
- r4190780783 (use a discriminated union, not null vs undefined): addressed in
2f66351and19b687e. - r4190790862 (github-actions, sentinel inversion): addressed in
2f66351. - r4201050228 / r4201059857 (no significant null): addressed in
19b687e.
Review 5446144345, all P3:
as constinert underReadonlySet<string>: resolved per the owner's direction in164e788.RetryableReseedCodeis defined, the set keepsReadonlySet<string>andas constand is built withnew Set<RetryableReseedCode>, so a misspelled member fails with TS2769;isRetryableReseedCodenarrows to the union (reply).- Redundant
parseAwarenessStatedocblock: removed ine641473(reply). 'state'tag overloadsstate: renamed to'present'in164e788(reply).- Test comment dropped the server fact and cited an unresolvable id: replaced in
5ad22e3, moved onto the null row in236e9e0(reply). - Hoisted
withoutState/rejected: inlined in236e9e0(reply). - Unasserted
kindcolumn: removed, titles state outcomes, in236e9e0(reply). - 8 KiB boundary split and 12 bytes loose: rows in
0ef5bb9, standalone test deleted in236e9e0(reply). - Duplicate valid-frame test: row in
97e53a4, duplicate deleted in236e9e0(reply). - Fixture byte-length premise assertion: deleted with the standalone test in
236e9e0(reply). - PR description stale and off-template: rewritten to the template to match this head.
- Left as is: the local
awarenessFramehelper duplicating__fixtures__/docFrameClient.ts, which predates this PR.
Checks at 236e9e0:
vitest run src/workbench/extensions/agent/crdt: 61 files, 875 passed, 1 expected fail.pnpm typecheck,oxlint --type-awareandeslinton the changed files,oxfmt --check: all clean. Pre-commit and pre-push hooks passed.- Mutations, each caught: budget +11 bytes (plus-one-byte row), strict
<(exactly-8 KiB row), null treated as invalid (null row), dropped state spread (two rows), invalid accepted (three rows), misspelled set member (TS2769). - Hosted CI: 60 passed, 31 skipped and 29 still running (Playwright, ecosystem, perf, unit report) when I approved.
playwright-tests-chromium-sharded (5, 16)failed on an artifact download (ECONNRESETin GetSignedArtifactURL), an infrastructure error unrelated to these three files; I did not rerun it.
…chema reseed handshake (#20096, #19032, #20264) (#20620) *PR Created by the Glary-Bot Agent* --- ## Why Prod's frontend and agent disagree on the CRDT document schema: - **Frontend:** `cloud/1.55` @ `7774606` (and the current `cloud/1.56` tip) ships `@comfyorg/comfy-multi-player` **0.3.6 → schema v4**. - **Agent doc host:** prod comfy-agent has run **0.3.10 → schema v5** since Comfy-Org/cloud#11864 (2026-10-08). #20096 was meant to land in lockstep with that cloud change, but it only reached `main`. Two things follow: - **The follower refuses every v5 document.** That covers every document the agent mints or re-mints. The error is `CRDT follower: doc meta.schema_version=5 is not the v4 layout this build reads`, and RUM shows about 88 errors across 59 sessions in 48h. - **The reseed handshake (#19032) isn't on the release branches.** So prod tabs never answer `stale_schema_reseed_required`, and documents stored at v4 stay locked. The agent logged about 96k seq-0 accepts across about 287 workflows. This backports the minimum set that puts the release frontend on v5, with the handshake. ## Commits | | original | note | |---|---|---| | `161fe98a52` | #19032 feat(agent): re-mint a stale-schema document from the canvas on subscribe | clean cherry-pick | | `6272f4d360` | #20264 refactor(agent): doc reseed review nits | clean cherry-pick | | `70c6880869` | #20096 pin `@comfyorg/comfy-multi-player` 0.3.10 | see conflicts below | | `94b1439945` | drop `agentDuplicateWidgetOccurrenceFollower.spec.ts` | see below | **Conflicts resolved in #20096:** - `pnpm-workspace.yaml`: kept 1.56's `minimumReleaseAgeExclude` and removed the 0.3.6 row. - `liveGraphApplier.test.ts`: kept the 1.56 version. **Tests deliberately left out.** #20096's message mentions three tests; only `applierConformance.test.ts` remains here. Main's repeated-name `liveGraphApplier.test.ts` hunk and the browser spec are both dropped. They assert the `failure_renaming_widget_duplicate_name` report, which comes from #20087, and #20087 is not on `cloud/1.56`. No other `src/` changes come with the pin, and `yjs` stays at 13.6.32. ## Rollout - **Order:** cloud first (already done: prod doc host is on v5). Ship this release through the canary. - **#20096's exposure-window warning is now reversed.** The risk is the *current* state, where prod FE v4 runs against a v5 doc host. - **Companion cloud PR:** Comfy-Org/cloud#12665 migrates stored v4 documents server-side when no canvas is posted. - **Follow-up PRs in this incident:** schema-skew metric, canary gate, and monitors. ## Testing - `pnpm typecheck` passes. - ESLint on the changed files reports 0 errors. - `vitest src/workbench/extensions/agent`: 2769 of 2770 pass. - The one failure is `agentSubgraphDefinitions.test.ts` ("scans deeply nested definition ids…"), a lib0 `deepFreeze` stack overflow. - It reproduces on `cloud/1.56` with the original 0.3.6 pin, and this branch doesn't touch that code or yjs/lib0. - **Not run:** browser E2E, and screenshots (this is a dependency pin plus protocol code with no UI change). ## Review `deep-reviewer` gave a PASS on the final head. It confirmed that #19032 and #20264 match their `main` originals and that every symbol they use exists on 1.56. Two upstream notes, both of which apply identically on `main`: - After a retryable reseed result, one extra reseed can be sent while a subscribe is still queued. - The 45s ack budget is shorter than the relay's 65s reseed timeout. --------- Co-authored-by: skishore23 <shimikeri.kishore@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: mrseek-reviews[bot] <337131926+mrseek-reviews[bot]@users.noreply.github.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Summary
Follow-up to review comments on #19032: type the retryable reseed codes and give the awareness state parser a discriminated result, with no behavior change.
Changes
docFrameCodes.ts: adds theRetryableReseedCodeunion. The code set stays aReadonlySet<string>built withnew Set<RetryableReseedCode>([...] as const), so a member outside the union fails to compile, andisRetryableReseedCodenarrows to the union.docFrameClient.ts:parseAwarenessStatereturns{ kind: 'present', state } | { kind: 'absent' } | { kind: 'invalid' }. The awareness parser rejects the frame oninvalid, omitsstateonabsent(missing or null), and passes the record onpresent.docFrameClient.awareness.test.ts: oneit.fortable covers missing, null, string, array, exactly 8 KiB, 8 KiB plus one byte, and valid states, each row with its expected frame inline. The standalone 8 KiB and valid-frame tests it replaces are gone.Review Focus
The helper exists instead of two inline checks because inlining them gives
awarenessan estimated fallow CRAP of 37 against the threshold of 30, which fails the pre-push audit.