Skip to content

fix(agent): align cloud/1.54 reseed payload contract - #20546

Merged
christian-byrne merged 2 commits into
cloud/1.54from
christian/stale-schema-cloud154-contract-fix
Oct 8, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
christian/stale-schema-cloud154-contract-fix

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

  • reject reseed workflows above Cloud’s 2 MiB inline workflow-field limit before transport
  • cover the exact UTF-8 byte boundary, including multibyte payloads
  • prove reseed attempts remain bounded across inactive/active tab transitions

Follow-up to #20416. Supports PM-1793 and PM-1794.

Testing

  • pnpm exec vitest run src/workbench/extensions/agent/crdt/docFrameClient.reseed.test.ts src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts (100 passed)
  • pnpm typecheck
  • focused oxlint/ESLint/format checks and pre-push knip

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 8, 2026 12:09pm UTC
billing-web-test Ignored Ignored Oct 8, 2026 12:09pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: ad251ac1-6e79-4174-8403-1063a9d6bb1f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne enabled auto-merge (squash) October 8, 2026 11:40
@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/08/2026, 12:11:38 PM UTC

Links

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 151ms TBT · 106.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.4 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 129ms TBT · 174.1 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 570ms TBT · 175.1 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 653ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 71.0 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -179
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 35ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 985ms
canvas-mouse-sweep: script duration 168ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.2 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -180
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 460ms
canvas-zoom-sweep: script duration 16ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 501ms
dom-widget-clipping: script duration 166ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.4 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 698ms
large-graph-idle: script duration 41ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 69.6 MB
large-graph-idle: DOM nodes -278
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1728ms
large-graph-pan: script duration 856ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 89.1 MB
large-graph-pan: DOM nodes -287
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 68
large-graph-zoom: task duration 1870ms
large-graph-zoom: script duration 859ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.3 MB
large-graph-zoom: DOM nodes -259
large-graph-zoom: event listeners -177
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1988ms
legacy-node-drag: script duration 1022ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 71.9 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 103
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 10ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 732ms
minimap-idle: script duration 42ms
minimap-idle: TBT 0ms
minimap-idle: heap used 67.3 MB
minimap-idle: DOM nodes -281
minimap-idle: event listeners -193
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 14ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 453ms
subgraph-dom-widget-clipping: script duration 153ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 85.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 600ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 75.2 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 33ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 877ms
subgraph-mouse-sweep: script duration 120ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 75.7 MB
subgraph-mouse-sweep: DOM nodes -130
subgraph-mouse-sweep: event listeners -118
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1063ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 151ms
subgraph-transition-enter: heap used 106.3 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 45ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6202ms
viewport-pan-sweep: script duration 2889ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 64.4 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 18346ms
vue-large-graph-idle: script duration 368ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.4 MB
vue-large-graph-idle: DOM nodes -8071
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 28ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 23226ms
vue-large-graph-pan: script duration 1011ms
vue-large-graph-pan: TBT 129ms
vue-large-graph-pan: heap used 174.1 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 32ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6774ms
vue-node-resize-workload: script duration 156ms
vue-node-resize-workload: TBT 570ms
vue-node-resize-workload: heap used 175.1 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 9104ms
vue-zoom-out-idle: script duration 176ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.1 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 81ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.1 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-10-08T12:22:03.295Z",
  "gitSha": "11a6021fe757b8c938baf110ef4c3085c280cfeb",
  "branch": "christian/stale-schema-cloud154-contract-fix",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2090.5089999999973,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.361,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.5690000000001,
      "heapDeltaBytes": -6672620,
      "heapUsedBytes": 66761800,
      "domNodes": -282,
      "jsHeapTotalBytes": 3440640,
      "scriptDurationMs": 13.219999999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2044.1450000000714,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.224999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 667.864,
      "heapDeltaBytes": 8646124,
      "heapUsedBytes": 82055944,
      "domNodes": -281,
      "jsHeapTotalBytes": 3702784,
      "scriptDurationMs": 12.931000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1969.2450000000008,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 35.062000000000005,
      "layouts": 14,
      "layoutDurationMs": 4.657000000000001,
      "taskDurationMs": 978.748,
      "heapDeltaBytes": -14840552,
      "heapUsedBytes": 58459004,
      "domNodes": -282,
      "jsHeapTotalBytes": 3440640,
      "scriptDurationMs": 171.74900000000002,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1934.0399999999818,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.527,
      "layouts": 14,
      "layoutDurationMs": 4.396000000000001,
      "taskDurationMs": 990.343,
      "heapDeltaBytes": -1351376,
      "heapUsedBytes": 71913216,
      "domNodes": -281,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 163.659,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1731.6430000000196,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 20.504999999999995,
      "layouts": 6,
      "layoutDurationMs": 1.2930000000000001,
      "taskDurationMs": 481.029,
      "heapDeltaBytes": 4254124,
      "heapUsedBytes": 75740572,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 17.475,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.1020000000026,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.755000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.19,
      "taskDurationMs": 439.20300000000003,
      "heapDeltaBytes": 4925652,
      "heapUsedBytes": 78900548,
      "domNodes": 76,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 15.437999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 761.1370000000193,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 9.299,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.3040000000001,
      "heapDeltaBytes": -7179648,
      "heapUsedBytes": 66659088,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 164.02800000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 733.1819999999425,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.926000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.163,
      "heapDeltaBytes": -6829000,
      "heapUsedBytes": 66248380,
      "domNodes": 14,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 167.32799999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.9259999999663,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.186999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 657.8389999999999,
      "heapDeltaBytes": -7814140,
      "heapUsedBytes": 72450288,
      "domNodes": -277,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 39.762,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2069.3659999999454,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.306000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 738.597,
      "heapDeltaBytes": -6674404,
      "heapUsedBytes": 73441136,
      "domNodes": -279,
      "jsHeapTotalBytes": -2326528,
      "scriptDurationMs": 42.302,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2476.54399999999,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.839,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1743.288,
      "heapDeltaBytes": 15608300,
      "heapUsedBytes": 94021748,
      "domNodes": -285,
      "jsHeapTotalBytes": 643072,
      "scriptDurationMs": 888.546,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2353.554999999915,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.222,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1713.4359999999997,
      "heapDeltaBytes": 11685796,
      "heapUsedBytes": 92793852,
      "domNodes": -289,
      "jsHeapTotalBytes": -1052672,
      "scriptDurationMs": 823.141,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3793.7900000000013,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 16.403999999999996,
      "layouts": 60,
      "layoutDurationMs": 14.583999999999998,
      "taskDurationMs": 1939.556,
      "heapDeltaBytes": -900860,
      "heapUsedBytes": 79142644,
      "domNodes": -265,
      "jsHeapTotalBytes": 2514944,
      "scriptDurationMs": 898.38,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3791.413000000034,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.816000000000003,
      "layouts": 60,
      "layoutDurationMs": 13.941,
      "taskDurationMs": 1800.6800000000003,
      "heapDeltaBytes": 1364020,
      "heapUsedBytes": 68200016,
      "domNodes": -253,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 819.4990000000001,
      "eventListeners": -158,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3111.953000000028,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.732000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1935.2780000000002,
      "heapDeltaBytes": 6739404,
      "heapUsedBytes": 74724908,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 1032.0349999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3194.5719999999937,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 7.810999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2040.42,
      "heapDeltaBytes": -6128404,
      "heapUsedBytes": 75969376,
      "domNodes": -283,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 1012.327,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2074.787000000015,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 14.287,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 799.6379999999999,
      "heapDeltaBytes": -7455748,
      "heapUsedBytes": 74830924,
      "domNodes": -276,
      "jsHeapTotalBytes": -753664,
      "scriptDurationMs": 49.085,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.8959999999888,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.525,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 664.5279999999999,
      "heapDeltaBytes": -13510832,
      "heapUsedBytes": 66335100,
      "domNodes": -285,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 35.81,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 649.2119999999773,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.312,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 453.2419999999999,
      "heapDeltaBytes": 14961492,
      "heapUsedBytes": 88629112,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 155.90599999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 677.8870000000552,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 16.707000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.561,
      "heapDeltaBytes": 14440768,
      "heapUsedBytes": 90135352,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 149.23600000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.6580000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.484999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.183,
      "heapDeltaBytes": -705756,
      "heapUsedBytes": 75386180,
      "domNodes": -297,
      "jsHeapTotalBytes": 3964928,
      "scriptDurationMs": 10.526999999999997,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2032.2159999999485,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.126,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 633.6360000000001,
      "heapDeltaBytes": 7147472,
      "heapUsedBytes": 82277764,
      "domNodes": -298,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 13.379999999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1788.7269999999944,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 32.599000000000004,
      "layouts": 18,
      "layoutDurationMs": 5.799,
      "taskDurationMs": 902.7090000000001,
      "heapDeltaBytes": -2538032,
      "heapUsedBytes": 73421964,
      "domNodes": -296,
      "jsHeapTotalBytes": 4751360,
      "scriptDurationMs": 118.228,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.8310000000183,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 32.618,
      "layouts": 18,
      "layoutDurationMs": 5.688,
      "taskDurationMs": 852.0540000000001,
      "heapDeltaBytes": 19451748,
      "heapUsedBytes": 85311880,
      "domNodes": 36,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 121.407,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.3439999999573,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.83199999999999,
      "layouts": 15,
      "layoutDurationMs": 15.867999999999997,
      "taskDurationMs": 1063.1419999999998,
      "heapDeltaBytes": 21381036,
      "heapUsedBytes": 111438448,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 36.139,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 151,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9504.040999999972,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 45.57599999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6528.821000000001,
      "heapDeltaBytes": -12493776,
      "heapUsedBytes": 67756512,
      "domNodes": -273,
      "jsHeapTotalBytes": -1015808,
      "scriptDurationMs": 3074.704,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8365.74500000006,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 44.211,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5875.457,
      "heapDeltaBytes": -13436692,
      "heapUsedBytes": 67196420,
      "domNodes": -268,
      "jsHeapTotalBytes": -1802240,
      "scriptDurationMs": 2702.664,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18873.493000000053,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18589.026,
      "heapDeltaBytes": -49536708,
      "heapUsedBytes": 178262216,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18288640,
      "scriptDurationMs": 383.26,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18391.71699999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18102.295,
      "heapDeltaBytes": -43096200,
      "heapUsedBytes": 177099396,
      "domNodes": -8074,
      "jsHeapTotalBytes": -17424384,
      "scriptDurationMs": 352.953,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23497.707999999988,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 28.684000000000044,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23409.948999999997,
      "heapDeltaBytes": -54093168,
      "heapUsedBytes": 170126124,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9711616,
      "scriptDurationMs": 1069.457,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 201,
      "frameDurationMs": 17.77666666666652,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23117.077999999994,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 26.334000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23042.248,
      "heapDeltaBytes": -27086276,
      "heapUsedBytes": 195044808,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11927552,
      "scriptDurationMs": 953.435,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.77666666666652,
      "p95FrameDurationMs": 16.799999999995634
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6842.342999999914,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.08100000000002,
      "layouts": 20,
      "layoutDurationMs": 37.674000000000014,
      "taskDurationMs": 6790.667,
      "heapDeltaBytes": -34272404,
      "heapUsedBytes": 193517788,
      "domNodes": -8068,
      "jsHeapTotalBytes": 6877184,
      "scriptDurationMs": 182.18400000000003,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 674,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6808.361999999988,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.185,
      "layouts": 20,
      "layoutDurationMs": 26.179999999999996,
      "taskDurationMs": 6757.317,
      "heapDeltaBytes": -51347104,
      "heapUsedBytes": 173588868,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14143488,
      "scriptDurationMs": 129.164,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 465,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9411.304999999971,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9271.414999999999,
      "heapDeltaBytes": -7160456,
      "heapUsedBytes": 177137736,
      "domNodes": 0,
      "jsHeapTotalBytes": -32768000,
      "scriptDurationMs": 198.66799999999995,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9111.627999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8937.569000000001,
      "heapDeltaBytes": 6311188,
      "heapUsedBytes": 179485344,
      "domNodes": 0,
      "jsHeapTotalBytes": -8388608,
      "scriptDurationMs": 152.90000000000003,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 119.25899999994272,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.797,
      "layouts": 2,
      "layoutDurationMs": 1.1480000000000001,
      "taskDurationMs": 84.77399999999999,
      "heapDeltaBytes": 3090660,
      "heapUsedBytes": 72089116,
      "domNodes": 130,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.104000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 105.68200000000161,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.368,
      "layouts": 2,
      "layoutDurationMs": 1.5170000000000001,
      "taskDurationMs": 77.63,
      "heapDeltaBytes": 2986592,
      "heapUsedBytes": 74847644,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.268000000000002,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51185 76659 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@christian-byrne christian-byrne added agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 8, 2026
@mrseek-reviews
mrseek-reviews Bot requested a review from DrJKL October 8, 2026 11:41
@comfy-greenlight-bot

comfy-greenlight-bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Swarmhost agentic review

The detailed evaluation is available to employees in the internal Slack review thread.

Evaluation budget remaining for this pull request: 98 automatic and 99 manual.

Updated by Swarmhost's agentic review process.

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 8, 2026
@christian-byrne
christian-byrne removed the request for review from DrJKL October 8, 2026 11:46

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟡 Medium 3
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20546   +/-   ##
=============================================
  Coverage              ?   84.20%           
=============================================
  Files                 ?     2132           
  Lines                 ?   128745           
  Branches              ?    35000           
=============================================
  Hits                  ?   108406           
  Misses                ?    20158           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.77% <ø> (?)
unit 79.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../workbench/extensions/agent/crdt/docFrameClient.ts 99.00% <100.00%> (ø)
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 95.49% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@comfy-greenlight-bot comfy-greenlight-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request at head commit 6b95184 has been reviewed and approved by Swarmhost's agentic review process.

The detailed evaluation is available to employees in the internal Slack review thread.

@christian-byrne
christian-byrne merged commit c05850c into cloud/1.54 Oct 8, 2026
97 checks passed
@christian-byrne
christian-byrne deleted the christian/stale-schema-cloud154-contract-fix branch October 8, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-crdt Agent document synchronization, graph projection or CRDT operations cloud/1.54 Backport PRs for cloud 1.54 cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants