Repository navigation
FE-3241 feat(billing): billing banners for personal plans - #20254
Conversation
Personal plans get out-of-credits, ending and plan-ended notices with first-person copy, picked by a team/personal audience derived next to the banner kind. Paused owners see one body for both audiences. On a personal workspace's Members tab the plan lifecycle notices give way to the upgrade pitch.
An ended plan on an unrecognized tier read as plan-ended in a personal workspace and swapped the upgrade pitch for the team-worded ended variants.
The card stays wherever the banner is not showing, since the banner is still behind billing_control_enabled.
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (16 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 417f25b2d4ccc04ff8c58163bfc49356b701ccdd
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10.2 MB gzip 🟢 -90.8 kBDetailsSummary
Category Glance App Entry Points — 3.98 kB (baseline 4.17 kB) • 🟢 -186 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.45 MB) • 🔴 +14.8 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 143 kB) • 🟢 -8.06 kBTop-level views, pages, and routed surfaces
Status: 16 added / 16 removed / 2 unchanged Panels & Settings — 648 kB (baseline 672 kB) • 🟢 -23.8 kBConfiguration panels, inspectors, and settings screens
Status: 10 added / 11 removed / 18 unchanged User & Accounts — 53.7 kB (baseline 54.4 kB) • 🟢 -706 BAuthentication, profile, and account management bundles
Status: 11 added / 11 removed / 4 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • 🟢 -3 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed UI Components — 194 kB (baseline 205 kB) • 🟢 -10.8 kBReusable component library chunks
Status: 18 added / 20 removed Data & Services — 4.17 MB (baseline 4.18 MB) • 🟢 -16.3 kBStores, services, APIs, and repositories
Status: 13 added / 14 removed / 3 unchanged Utilities & Hooks — 580 kB (baseline 582 kB) • 🟢 -1.71 kBHelpers, composables, and utility bundles
Status: 25 added / 24 removed / 14 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.3 MB) • 🟢 -25.4 kBExternal libraries and shared vendor chunks
Status: 3 added / 3 removed / 15 unchanged Other — 18.4 MB (baseline 18.6 MB) • 🟢 -145 kBBundles that do not match a named category
Status: 155 added / 162 removed / 154 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-05T22:23:13.363Z",
"gitSha": "e22dcefb7097985e7bf8ae24e592da9c191c8960",
"branch": "jaewon/fe-3241-personal-plan-billing-banners",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.4629999999825,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.610000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.372,
"heapDeltaBytes": 518348,
"heapUsedBytes": 68195616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.854,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2017.6250000000095,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.4549999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.706,
"heapDeltaBytes": 520788,
"heapUsedBytes": 68544824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.7689999999999975,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.6029999999723,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.751,
"layouts": 12,
"layoutDurationMs": 3.0770000000000004,
"taskDurationMs": 597.128,
"heapDeltaBytes": -2144720,
"heapUsedBytes": 66224072,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 112.096,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.3950000000195,
"styleRecalcs": 73,
"styleRecalcDurationMs": 11.356000000000002,
"layouts": 12,
"layoutDurationMs": 3.074,
"taskDurationMs": 577.77,
"heapDeltaBytes": -2137596,
"heapUsedBytes": 66218596,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 103.67599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.3340000000085,
"styleRecalcs": 32,
"styleRecalcDurationMs": 7.9719999999999995,
"layouts": 6,
"layoutDurationMs": 1.113,
"taskDurationMs": 270.248,
"heapDeltaBytes": 3543252,
"heapUsedBytes": 72294024,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.11,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.2170000000096,
"styleRecalcs": 31,
"styleRecalcDurationMs": 6.545000000000001,
"layouts": 6,
"layoutDurationMs": 0.8450000000000001,
"taskDurationMs": 259.212,
"heapDeltaBytes": 3692536,
"heapUsedBytes": 72678772,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.288,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 533.8210000000458,
"styleRecalcs": 16,
"styleRecalcDurationMs": 2.7230000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.748,
"heapDeltaBytes": -7424272,
"heapUsedBytes": 60594540,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 124.971,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 532.8059999999937,
"styleRecalcs": 15,
"styleRecalcDurationMs": 2.586,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.7,
"heapDeltaBytes": -8018308,
"heapUsedBytes": 59501368,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.61600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1012.0499999999879,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 649.9189999999999,
"heapDeltaBytes": 15139516,
"heapUsedBytes": 85026548,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 44.657000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 406,
"frameDurationMs": 30.809090909090905,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1020.5710000000181,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.9169999999999,
"heapDeltaBytes": 15776828,
"heapUsedBytes": 87124720,
"domNodes": 0,
"jsHeapTotalBytes": 4882432,
"scriptDurationMs": 52.466,
"eventListeners": 0,
"totalBlockingTimeMs": 405,
"frameDurationMs": 30.809090909090905,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 750.8720000000153,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.57500000000016,
"heapDeltaBytes": -8822420,
"heapUsedBytes": 78634216,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 105.84099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 119,
"frameDurationMs": 22.061764705882364,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.7259999999569,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.99099999999993,
"heapDeltaBytes": 16816516,
"heapUsedBytes": 104319664,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 94.00000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 21.567647058823507,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6699.81599999997,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.7620000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5885.528,
"heapDeltaBytes": -19192,
"heapUsedBytes": 85027776,
"domNodes": -142,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 4666.084,
"eventListeners": -78,
"totalBlockingTimeMs": 44,
"frameDurationMs": 25.703846153846154,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6424.477999999965,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.8540000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5474.213000000001,
"heapDeltaBytes": -180420,
"heapUsedBytes": 84820836,
"domNodes": -142,
"jsHeapTotalBytes": -9834496,
"scriptDurationMs": 4563.001,
"eventListeners": -78,
"totalBlockingTimeMs": 32,
"frameDurationMs": 25.361264822134387,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6539.117999999973,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.7409999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5786.031999999999,
"heapDeltaBytes": -11793544,
"heapUsedBytes": 73564896,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 4598.601000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 74,
"frameDurationMs": 25.42023346303502,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6436.8879999999535,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6680000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5722.929,
"heapDeltaBytes": -12415452,
"heapUsedBytes": 73145272,
"domNodes": -142,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 4566.995999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 24,
"frameDurationMs": 24.934496124031007,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2007.4489999999514,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.58700000000005,
"heapDeltaBytes": -10020008,
"heapUsedBytes": 78655096,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 28.983999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.609000000045,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.6900000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.0250000000001,
"heapDeltaBytes": -11901528,
"heapUsedBytes": 68023716,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 21.84,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2163.4839999999826,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.473,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1264.1999999999998,
"heapDeltaBytes": -18117140,
"heapUsedBytes": 68429180,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 652.29,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2110.232999999994,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.722,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1122.744,
"heapDeltaBytes": -19098476,
"heapUsedBytes": 70295428,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 574.828,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3152.620000000013,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.478000000000002,
"layouts": 60,
"layoutDurationMs": 11.373,
"taskDurationMs": 1252.0319999999997,
"heapDeltaBytes": 1264996,
"heapUsedBytes": 69629392,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 572.715,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66560846560846,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3183.988999999997,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.634999999999998,
"layouts": 60,
"layoutDurationMs": 11.383,
"taskDurationMs": 1244.2000000000003,
"heapDeltaBytes": 2114256,
"heapUsedBytes": 71704552,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 576.856,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665445026178013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2197.3780000000147,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.631999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1397.6519999999998,
"heapDeltaBytes": 5819972,
"heapUsedBytes": 74587012,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 709.6320000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.794615384615387,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2176.0100000000193,
"styleRecalcs": 48,
"styleRecalcDurationMs": 4.580000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1316.8809999999999,
"heapDeltaBytes": 5156884,
"heapUsedBytes": 73882348,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 658.2729999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.795348837209303,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.9630000000184,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3809999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.7820000000001,
"heapDeltaBytes": -9327744,
"heapUsedBytes": 80930448,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 25.765000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.308000000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.114000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.86599999999993,
"heapDeltaBytes": -10496152,
"heapUsedBytes": 79353632,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 28.745999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 504.8060000000305,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.230999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 310.266,
"heapDeltaBytes": -11953168,
"heapUsedBytes": 57409252,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 102.032,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.0289999999177,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.695000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.2049999999999,
"heapDeltaBytes": -12280020,
"heapUsedBytes": 58067980,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 106.73400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.5070000000087,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5400000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 351.214,
"heapDeltaBytes": 996732,
"heapUsedBytes": 70915032,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.468000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.421999999906,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.0830000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.463,
"heapDeltaBytes": 1029000,
"heapUsedBytes": 70378960,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.554999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.298000000032,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.291000000000002,
"layouts": 16,
"layoutDurationMs": 4.237,
"taskDurationMs": 610.5860000000001,
"heapDeltaBytes": 16791020,
"heapUsedBytes": 80006660,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 79.681,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.3690000000752,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.289000000000001,
"layouts": 16,
"layoutDurationMs": 3.8580000000000005,
"taskDurationMs": 531.4179999999999,
"heapDeltaBytes": 16047444,
"heapUsedBytes": 77951328,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 68.54299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 850.5569999999807,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.012999999999998,
"layouts": 5,
"layoutDurationMs": 9.933000000000002,
"taskDurationMs": 700.0680000000001,
"heapDeltaBytes": -1611272,
"heapUsedBytes": 85595732,
"domNodes": 14227,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 21.186999999999998,
"eventListeners": 2463,
"totalBlockingTimeMs": 104,
"frameDurationMs": 20.73170731707317,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "viewport-pan-sweep",
"durationMs": 8129.733999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.055,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4061.262,
"heapDeltaBytes": 11472840,
"heapUsedBytes": 100353816,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 1927.393,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577868852459,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8173.225000000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.265,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3958.5280000000002,
"heapDeltaBytes": -18015168,
"heapUsedBytes": 71079224,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 1874.811,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66591836734694,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11935.09499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11071.23,
"heapDeltaBytes": -19069716,
"heapUsedBytes": 180011160,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 163.021,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.122596964586844,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 11771.483999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10903.095000000001,
"heapDeltaBytes": -41667416,
"heapUsedBytes": 179918244,
"domNodes": -3045,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 155.50300000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.77512605042017,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 16268.78899999997,
"styleRecalcs": 106,
"styleRecalcDurationMs": 14.617999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15627.468999999997,
"heapDeltaBytes": -37681628,
"heapUsedBytes": 183918136,
"domNodes": -3045,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 791.298,
"eventListeners": -14915,
"totalBlockingTimeMs": 17,
"frameDurationMs": 28.495454545454546,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 14048.696999999947,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.050000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13441.831,
"heapDeltaBytes": -26178712,
"heapUsedBytes": 186862400,
"domNodes": -3045,
"jsHeapTotalBytes": 2310144,
"scriptDurationMs": 661.6690000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 53,
"frameDurationMs": 24.807760141093475,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-node-resize-workload",
"durationMs": 4151.896999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.00900000000001,
"layouts": 20,
"layoutDurationMs": 18.178,
"taskDurationMs": 3892.975,
"heapDeltaBytes": 1228500,
"heapUsedBytes": 222809452,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 54.845,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.561349693251532,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4185.0050000000465,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.34599999999998,
"layouts": 20,
"layoutDurationMs": 18.568,
"taskDurationMs": 3969.6940000000004,
"heapDeltaBytes": 944240,
"heapUsedBytes": 222472700,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 54.378,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.199397590361446,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5965.824999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5463.230000000001,
"heapDeltaBytes": -34008436,
"heapUsedBytes": 179639496,
"domNodes": -3045,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 99.85499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.43287671232877,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6060.184999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5572.780000000002,
"heapDeltaBytes": -42921944,
"heapUsedBytes": 179853608,
"domNodes": -3045,
"jsHeapTotalBytes": 1155072,
"scriptDurationMs": 77.30900000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.165666666666663,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 454.31800000000067,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.617,
"layouts": 4,
"layoutDurationMs": 1.574,
"taskDurationMs": 107.64100000000002,
"heapDeltaBytes": 5927876,
"heapUsedBytes": 71271952,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.351999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 92.50599999995757,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.773,
"layouts": 3,
"layoutDurationMs": 1.4220000000000002,
"taskDurationMs": 64.69500000000001,
"heapDeltaBytes": 3716068,
"heapUsedBytes": 69543884,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.653999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 427.8759999999693,
"styleRecalcs": 78,
"styleRecalcDurationMs": 68.564,
"layouts": 76,
"layoutDurationMs": 16.077,
"taskDurationMs": 400.144,
"heapDeltaBytes": 13329192,
"heapUsedBytes": 93257600,
"domNodes": 76,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 143.449,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538459,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 443.7360000000581,
"styleRecalcs": 78,
"styleRecalcDurationMs": 72.128,
"layouts": 76,
"layoutDurationMs": 16.311,
"taskDurationMs": 407.81,
"heapDeltaBytes": 13428756,
"heapUsedBytes": 93416620,
"domNodes": 76,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 142.069,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 724.933999999962,
"styleRecalcs": 78,
"styleRecalcDurationMs": 175.203,
"layouts": 76,
"layoutDurationMs": 15.764,
"taskDurationMs": 693.037,
"heapDeltaBytes": -22434904,
"heapUsedBytes": 106270032,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 195.56099999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 783.9330000000473,
"styleRecalcs": 78,
"styleRecalcDurationMs": 185.109,
"layouts": 76,
"layoutDurationMs": 17.325,
"taskDurationMs": 747.4839999999999,
"heapDeltaBytes": 3946676,
"heapUsedBytes": 110009664,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 215.341,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665957446808516,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2198 passed, 0 failed · 2 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (12)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughBilling banner selection now supports recognized personal plans, including out-of-credits, ending, and ended states. The banner shows audience-specific copy and actions, and workspace settings panels adjust banner visibility and upsell behavior for personal plans. ChangesPersonal Workspace Billing Notices
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant WorkspaceSettingsPanelContent
participant BillingStatusBanner
participant useBillingBanner
WorkspaceSettingsPanelContent->>BillingStatusBanner: Pass the current section
BillingStatusBanner->>useBillingBanner: Read banner kind and audience
useBillingBanner-->>BillingStatusBanner: Return derived kind and audience
BillingStatusBanner-->>WorkspaceSettingsPanelContent: Render or suppress the banner
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The personal-plan billing changes have no established issue that should block merging after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change primarily expands billing guidance for personal plans while preserving existing owner and capability checks. No introduced authorization bypass was established. Some dismissal behavior spans workspace changes, but independent subscription recovery remains available. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The commit subject “fix(members): keep the Team upsell on a personal workspace's Members tab” uses bug-fix language. The changed-file list includes frontend files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20254 +/- ##
==========================================
+ Coverage 85.13% 85.89% +0.76%
==========================================
Files 3480 2449 -1031
Lines 167783 140159 -27624
Branches 45927 38072 -7855
==========================================
- Hits 142842 120396 -22446
+ Misses 22963 19386 -3577
+ Partials 1978 377 -1601
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1039 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: 20ca932 | Docs | View more details | Give us feedback! |
|
Rerunning |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved after exact-head review: the focused change is covered by settled green checks and has no unresolved review threads.
|
@dante01yoon Successfully backported to #20342 |
|
@dante01yoon Successfully backported to #20343 |
Why
Design added a Personal column to the billing banner reference for Standard, Creator and Pro plans, and updated the Members tab matrix. Today only Subscription paused reaches personal workspaces. Out of credits, Plan ending and Plan ended are team-only, so a personal plan that runs out, is cancelled or ends shows no banner. The decisions come from the design thread.
How
deriveBillingBannerstays the single pure derivation. Next to the kind it now derives an audience,team | personal | null. A plan is personal when it is not team, not Enterprise, and on a known personal tier. Enterprise and unrecognized tiers getnulland still fail closed.BillingStatusBannerreads its copy from a small table keyed by that audience, instead of checking the workspace type in each view.billing_control_enabledand subscription access. The copy is first person and uses the tier name ("Your Pro plan ends on {date}").usePlanEnded, in the same priority slot right after Paused, with a session-long dismiss. Resubscribe opens the pricing table on Personal plans.usePlanEnded().isPlanEndeditself is unchanged, because the Members panel reads it.MemberUpsellBanner("To add teammates, upgrade your plan") carries that tab. That upsell no longer switches to the team-worded ended or contact-sales variants in a personal workspace. Paused and Out of credits still show.billing_control_enabled, so the card remains wherever the banner is not shown.A terminal personal subscription that comes back with no tier, or an unknown tier, gets no Plan ended banner. That follows the existing fail-closed rule for unrecognized tiers.
AS IS / TO BE
Surface: the real cloud app (
DISTRIBUTION=clouddev build, Settings dialog, personal workspace) on origin/main (AS IS) and this branch (TO BE), against a local ComfyUI backend. Firebase auth and the personal-workspace billing endpoints (/api/billing/*,/customers/balance, workspace and members) are stubbed per state with Playwright routes;billing_control_enabledandv1_payment_recoveryare turned on through the devff:overrides. Pro tier, monthly. The Ended state has no plan catalog in the stub, so the plan card falls back to Free.Cancelled Pro plan (
subscription_status: canceled,cancel_atset). The amber canceled card is replaced by the "Your Pro plan ends on ..." banner.Out of credits (
has_funds: false).Ended (
subscription_status: ended,billing_status: inactive).Members tab, ended plan. Both sides show the upgrade-to-Team upsell and no plan-ended banner; the personal workspace keeps the upsell and does not pick up the new banner.
Paused (
billing_status: paused). Same copy as team: "This workspace's subscription is paused. Update payment to resume."Plan position
Fixes FE-3241