Repository navigation
[backport cloud/1.56] FE-3241 feat(billing): billing banners for personal plans - #20343
Conversation
## Why Design added a Personal column to the [billing banner reference](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30628) for Standard, Creator and Pro plans, and updated the [Members tab matrix](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7244-30885). Today only Subscription paused reaches personal workspaces. Out of credits, Plan ending and Plan ended are team-only, so a personal plan that runs out, is cancelled or ends shows no banner. The decisions come from the [design thread](https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1791229801307819). ## How - **Audience.** `deriveBillingBanner` stays the single pure derivation. Next to the kind it now derives an audience, `team | personal | null`. A plan is personal when it is not team, not Enterprise, and on a known personal tier. Enterprise and unrecognized tiers get `null` and still fail closed. `BillingStatusBanner` reads its copy from a small table keyed by that audience, instead of checking the workspace type in each view. - **Paused.** The owner copy is the same for team and personal. The personal-only bodies are deleted. - **Out of credits, Plan ending (personal).** Same gates as team: `billing_control_enabled` and subscription access. The copy is first person and uses the tier name ("Your Pro plan ends on {date}"). - **Plan ending owner bodies (team and personal).** Both now start with "You won't be charged again." This line used to live only on the canceled card. - **Plan ended (personal).** Uses the same terminal test as `usePlanEnded`, in the same priority slot right after Paused, with a session-long dismiss. Resubscribe opens the pricing table on Personal plans. `usePlanEnded().isPlanEnded` itself is unchanged, because the Members panel reads it. - **Members tab, personal workspace.** The banner hides Plan ended, Plan ending and Scheduled change, so `MemberUpsellBanner` ("To add teammates, upgrade your plan") carries that tab. That upsell no longer switches to the team-worded ended or contact-sales variants in a personal workspace. Paused and Out of credits still show. - **Amber "Your subscription has been canceled" card.** Hidden while the Plan ending banner shows. The banner is still behind `billing_control_enabled`, so the card remains wherever the banner is not shown. - **Scheduled plan change.** Stays team-only, since there is no personal design for it. A terminal personal subscription that comes back with no tier, or an unknown tier, gets no Plan ended banner. That follows the existing fail-closed rule for unrecognized tiers. ## AS IS / TO BE Surface: the real cloud app (`DISTRIBUTION=cloud` dev build, Settings dialog, personal workspace) on origin/main (AS IS) and this branch (TO BE), against a local ComfyUI backend. Firebase auth and the personal-workspace billing endpoints (`/api/billing/*`, `/customers/balance`, workspace and members) are stubbed per state with Playwright routes; `billing_control_enabled` and `v1_payment_recovery` are turned on through the dev `ff:` overrides. Pro tier, monthly. The Ended state has no plan catalog in the stub, so the plan card falls back to Free. **Cancelled Pro plan** (`subscription_status: canceled`, `cancel_at` set). The amber canceled card is replaced by the "Your Pro plan ends on ..." banner. | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/b0c8d40f-4e23-4ff1-a45c-46cc6c293fb2" width="480"> | <img src="https://github.com/user-attachments/assets/7c87a0a9-bf41-49e9-84c3-f96edfe283dc" width="480"> | **Out of credits** (`has_funds: false`). | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/9e2e2594-42d6-4702-a489-5d78fa9bd4c7" width="480"> | <img src="https://github.com/user-attachments/assets/1b79610e-4b5d-4d92-aa13-d826f3dcd1f6" width="480"> | **Ended** (`subscription_status: ended`, `billing_status: inactive`). | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/5ea54910-ef5e-40ac-b3dc-7fe619c7ef4c" width="480"> | <img src="https://github.com/user-attachments/assets/ddfda87e-e8a2-4fee-b836-74bc2fc5b149" width="480"> | **Members tab, ended plan.** Both sides show the upgrade-to-Team upsell and no plan-ended banner; the personal workspace keeps the upsell and does not pick up the new banner. | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/43e45cbb-4125-486a-a46c-47f2aadd7f34" width="480"> | <img src="https://github.com/user-attachments/assets/d86a5d7e-76c5-4f2f-ac74-2c632866c2d5" width="480"> | **Paused** (`billing_status: paused`). Same copy as team: "This workspace's subscription is paused. Update payment to resume." | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/756be259-7bd8-441c-94d8-c1eee5b883ba" width="480"> | <img src="https://github.com/user-attachments/assets/4e83ff50-ac50-463d-9160-70dc7b11ac7f" width="480"> | ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Align billing banners with the design reference | FE-3138 | #19680 | Merged | | Plan ended banner on every workspace tab | FE-3136 | #19682 | Merged | | **Personal-plan banners + canceled card handoff** | **FE-3241** | **this PR** | **Open** | | Retire the Members-only ended banner | FE-3159 | | Backlog | ```mermaid graph LR A["FE-3138 PR 19680 banner copy"] --> C["FE-3241 personal banners"] B["FE-3136 PR 19682 plan ended banner"] --> C B --> D["FE-3159 retire Members-only ended banner"] style C fill:#f9d71c,stroke:#333,stroke-width:2px ``` Fixes FE-3241
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (16 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4270d954e9bc60f4572943780b6ab58eb105c795
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-06T21:45:27.799Z",
"gitSha": "b53136322931765ca5076c009664d5dd4e665e46",
"branch": "backport-20254-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.9250000000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.360000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.41099999999994,
"heapDeltaBytes": 616384,
"heapUsedBytes": 68516368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.883000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.2409999999745,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8960000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.52599999999995,
"heapDeltaBytes": 528568,
"heapUsedBytes": 68527840,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.05299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.2179999999935,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.715,
"layouts": 12,
"layoutDurationMs": 3.9810000000000003,
"taskDurationMs": 770.449,
"heapDeltaBytes": -2134364,
"heapUsedBytes": 65540112,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 158.40599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.9819999999409,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.667,
"layouts": 12,
"layoutDurationMs": 4.348,
"taskDurationMs": 666.669,
"heapDeltaBytes": -2121932,
"heapUsedBytes": 65833464,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 161.47,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1696.3849999999638,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.499999999999998,
"layouts": 6,
"layoutDurationMs": 1.216,
"taskDurationMs": 328.98400000000004,
"heapDeltaBytes": 3730548,
"heapUsedBytes": 71400420,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.372,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.6589999999496,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.143999999999998,
"layouts": 6,
"layoutDurationMs": 1.2340000000000002,
"taskDurationMs": 329.494,
"heapDeltaBytes": 4060132,
"heapUsedBytes": 71778368,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.493999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 695.6199999999626,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.2890000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.78600000000006,
"heapDeltaBytes": -7462792,
"heapUsedBytes": 59937744,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 169.25300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 672.3910000000615,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.6039999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.77900000000005,
"heapDeltaBytes": -6516828,
"heapUsedBytes": 61414744,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 161.384,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1139.887999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 783.2299999999999,
"heapDeltaBytes": 15676816,
"heapUsedBytes": 85126096,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 63.48000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 503,
"frameDurationMs": 33.33235294117645,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1141.5289999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 802.988,
"heapDeltaBytes": 15689608,
"heapUsedBytes": 85289192,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 64.37400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 514,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.8470000000211,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.45300000000015,
"heapDeltaBytes": 18779100,
"heapUsedBytes": 105219460,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.02299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.76285714285711,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 865.4429999999138,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.57499999999965,
"heapDeltaBytes": 17634976,
"heapUsedBytes": 105162616,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.047,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 25.485294117647058,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8841.090000000007,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05500000000000123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7969.503000000001,
"heapDeltaBytes": -4825704,
"heapUsedBytes": 80138512,
"domNodes": -142,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 6776.355,
"eventListeners": -78,
"totalBlockingTimeMs": 658,
"frameDurationMs": 33.84329501915709,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8406.968000000006,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7019999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7654.570999999999,
"heapDeltaBytes": -12660060,
"heapUsedBytes": 71951692,
"domNodes": -142,
"jsHeapTotalBytes": -9572352,
"scriptDurationMs": 6477.8330000000005,
"eventListeners": -74,
"totalBlockingTimeMs": 569,
"frameDurationMs": 33.733333333333334,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8903.76699999996,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.8479999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8162.011999999999,
"heapDeltaBytes": 8123788,
"heapUsedBytes": 92708820,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 6699.447,
"eventListeners": -78,
"totalBlockingTimeMs": 593,
"frameDurationMs": 32.961481481481485,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8926.550000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8245.62,
"heapDeltaBytes": -5569140,
"heapUsedBytes": 79427932,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 6799.839999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 631,
"frameDurationMs": 32.90147601476014,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2022.43100000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.920999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.54799999999994,
"heapDeltaBytes": -9530180,
"heapUsedBytes": 79230700,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 30.753000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2007.6800000000503,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.376999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.19800000000004,
"heapDeltaBytes": -9567688,
"heapUsedBytes": 79890496,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.136999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2359.818999999959,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.608999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1549.3670000000002,
"heapDeltaBytes": -19294740,
"heapUsedBytes": 70358424,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 838.208,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2323.180000000093,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1518.195,
"heapDeltaBytes": -20672636,
"heapUsedBytes": 69494472,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 816.693,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985505,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3586.4310000000046,
"styleRecalcs": 72,
"styleRecalcDurationMs": 13.77,
"layouts": 60,
"layoutDurationMs": 13.834000000000001,
"taskDurationMs": 1602.1799999999996,
"heapDeltaBytes": 1420424,
"heapUsedBytes": 70101772,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 778.6869999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348834,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3554.9009999999726,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.479000000000001,
"layouts": 60,
"layoutDurationMs": 13.693999999999999,
"taskDurationMs": 1608.1870000000001,
"heapDeltaBytes": 1234172,
"heapUsedBytes": 69639164,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 772.3960000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3077.5109999999586,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.206,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1836.4450000000002,
"heapDeltaBytes": 4739052,
"heapUsedBytes": 73030148,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 972.132,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3068.655000000035,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1874.3400000000001,
"heapDeltaBytes": 9909788,
"heapUsedBytes": 78942160,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 1000.761,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.757377049180324,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.8579999999943,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.2849999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.773,
"heapDeltaBytes": -9470732,
"heapUsedBytes": 81211392,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.357999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.345000000072,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.653,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.4429999999999,
"heapDeltaBytes": -9334528,
"heapUsedBytes": 81242896,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.948000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.3199999999683,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.848,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.41400000000004,
"heapDeltaBytes": -11991444,
"heapUsedBytes": 57760548,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 143.931,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.7160000000813,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.1789999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.896,
"heapDeltaBytes": -11666688,
"heapUsedBytes": 58018948,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 146.60899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.3370000000164,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.356000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.51599999999996,
"heapDeltaBytes": 1073416,
"heapUsedBytes": 71953972,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.133000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.6999999999525,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.656000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.693,
"heapDeltaBytes": 1030732,
"heapUsedBytes": 70213648,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.454000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.8810000000003,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.266000000000005,
"layouts": 16,
"layoutDurationMs": 5.618,
"taskDurationMs": 712.82,
"heapDeltaBytes": -6013628,
"heapUsedBytes": 63454416,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 106.91499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.8620000000246,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.176000000000002,
"layouts": 16,
"layoutDurationMs": 5.183999999999999,
"taskDurationMs": 711.684,
"heapDeltaBytes": 16880020,
"heapUsedBytes": 80356180,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 106.579,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.0049999999783,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.822999999999997,
"layouts": 5,
"layoutDurationMs": 14.293000000000003,
"taskDurationMs": 888.4969999999998,
"heapDeltaBytes": 3072140,
"heapUsedBytes": 98762472,
"domNodes": 14227,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 27.17599999999999,
"eventListeners": 2463,
"totalBlockingTimeMs": 129,
"frameDurationMs": 19.176712328767117,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8254.04900000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 34.531,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5435.789000000001,
"heapDeltaBytes": 12247992,
"heapUsedBytes": 90425656,
"domNodes": 0,
"jsHeapTotalBytes": 1277952,
"scriptDurationMs": 2750.73,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665991902834012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8284.205000000042,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5320.407999999999,
"heapDeltaBytes": -18886772,
"heapUsedBytes": 70073264,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2648.0209999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258063,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17633.425999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16795.074,
"heapDeltaBytes": -42214316,
"heapUsedBytes": 179193412,
"domNodes": -3045,
"jsHeapTotalBytes": 630784,
"scriptDurationMs": 261.60100000000006,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.486120401337793,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 12451.643999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11638.483,
"heapDeltaBytes": -15105484,
"heapUsedBytes": 184034328,
"domNodes": -3045,
"jsHeapTotalBytes": 8671232,
"scriptDurationMs": 203.839,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.923529411764704,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 21785.955,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.315000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21297.823999999997,
"heapDeltaBytes": -10108940,
"heapUsedBytes": 196302008,
"domNodes": -3045,
"jsHeapTotalBytes": 13037568,
"scriptDurationMs": 827.219,
"eventListeners": -14907,
"totalBlockingTimeMs": 12,
"frameDurationMs": 39.31841155234657,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 21211.82799999997,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.526999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20743.242000000002,
"heapDeltaBytes": -23549004,
"heapUsedBytes": 189483180,
"domNodes": -3045,
"jsHeapTotalBytes": 7028736,
"scriptDurationMs": 896.0360000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 51,
"frameDurationMs": 38.47386569872958,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6279.304999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.28200000000002,
"layouts": 20,
"layoutDurationMs": 22.819999999999993,
"taskDurationMs": 6143.078,
"heapDeltaBytes": 744768,
"heapUsedBytes": 215883320,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 102.318,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.68148148148148,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6261.337000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.45699999999997,
"layouts": 20,
"layoutDurationMs": 22.409,
"taskDurationMs": 6075.487000000001,
"heapDeltaBytes": 992052,
"heapUsedBytes": 215913924,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 101.22600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.86058823529412,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9038.37900000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8631.822999999999,
"heapDeltaBytes": -36554240,
"heapUsedBytes": 180054016,
"domNodes": -3045,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 137.241,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.11,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8700.691000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8340.723,
"heapDeltaBytes": -21866764,
"heapUsedBytes": 181005916,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 129.61100000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.095986622073582,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 486.73699999994824,
"styleRecalcs": 21,
"styleRecalcDurationMs": 15.895,
"layouts": 3,
"layoutDurationMs": 1.561,
"taskDurationMs": 131.29099999999997,
"heapDeltaBytes": 5941892,
"heapUsedBytes": 71006420,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.317000000000004,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 114.81900000001133,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.179,
"layouts": 3,
"layoutDurationMs": 1.009,
"taskDurationMs": 80.851,
"heapDeltaBytes": 3862460,
"heapUsedBytes": 70243676,
"domNodes": 95,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.156,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 895.0379999999996,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.98599999999999,
"layouts": 76,
"layoutDurationMs": 26.610000000000003,
"taskDurationMs": 862.579,
"heapDeltaBytes": 18245964,
"heapUsedBytes": 82631768,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 355.609,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 797.4140000000034,
"styleRecalcs": 78,
"styleRecalcDurationMs": 97.926,
"layouts": 76,
"layoutDurationMs": 23.599999999999998,
"taskDurationMs": 777.3330000000001,
"heapDeltaBytes": 17058124,
"heapUsedBytes": 82094748,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 316.53499999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665306122448985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1379.1059999999788,
"styleRecalcs": 78,
"styleRecalcDurationMs": 260.055,
"layouts": 76,
"layoutDurationMs": 28.512,
"taskDurationMs": 1360.786,
"heapDeltaBytes": -19638112,
"heapUsedBytes": 114219776,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 461.28400000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.510126582278495,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1407.0870000000468,
"styleRecalcs": 78,
"styleRecalcDurationMs": 259.504,
"layouts": 76,
"layoutDurationMs": 28.330000000000002,
"taskDurationMs": 1392.798,
"heapDeltaBytes": 8759072,
"heapUsedBytes": 119858348,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 474.93800000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.707500000000003,
"p95FrameDurationMs": 33.19999999999891
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of PR 20254.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20343 +/- ##
=============================================
Coverage ? 85.95%
=============================================
Files ? 2461
Lines ? 140592
Branches ? 36261
=============================================
Hits ? 120844
Misses ? 19370
Partials ? 378
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #20254 to
cloud/1.56Automatically created by backport workflow.