Repository navigation
[backport core/1.56] FE-3241 feat(billing): billing banners for personal plans - #20342
Conversation
## Why Design added a Personal column to the [billing banner reference](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30628) for Standard, Creator and Pro plans, and updated the [Members tab matrix](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7244-30885). Today only Subscription paused reaches personal workspaces. Out of credits, Plan ending and Plan ended are team-only, so a personal plan that runs out, is cancelled or ends shows no banner. The decisions come from the [design thread](https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1791229801307819). ## How - **Audience.** `deriveBillingBanner` stays the single pure derivation. Next to the kind it now derives an audience, `team | personal | null`. A plan is personal when it is not team, not Enterprise, and on a known personal tier. Enterprise and unrecognized tiers get `null` and still fail closed. `BillingStatusBanner` reads its copy from a small table keyed by that audience, instead of checking the workspace type in each view. - **Paused.** The owner copy is the same for team and personal. The personal-only bodies are deleted. - **Out of credits, Plan ending (personal).** Same gates as team: `billing_control_enabled` and subscription access. The copy is first person and uses the tier name ("Your Pro plan ends on {date}"). - **Plan ending owner bodies (team and personal).** Both now start with "You won't be charged again." This line used to live only on the canceled card. - **Plan ended (personal).** Uses the same terminal test as `usePlanEnded`, in the same priority slot right after Paused, with a session-long dismiss. Resubscribe opens the pricing table on Personal plans. `usePlanEnded().isPlanEnded` itself is unchanged, because the Members panel reads it. - **Members tab, personal workspace.** The banner hides Plan ended, Plan ending and Scheduled change, so `MemberUpsellBanner` ("To add teammates, upgrade your plan") carries that tab. That upsell no longer switches to the team-worded ended or contact-sales variants in a personal workspace. Paused and Out of credits still show. - **Amber "Your subscription has been canceled" card.** Hidden while the Plan ending banner shows. The banner is still behind `billing_control_enabled`, so the card remains wherever the banner is not shown. - **Scheduled plan change.** Stays team-only, since there is no personal design for it. A terminal personal subscription that comes back with no tier, or an unknown tier, gets no Plan ended banner. That follows the existing fail-closed rule for unrecognized tiers. ## AS IS / TO BE Surface: the real cloud app (`DISTRIBUTION=cloud` dev build, Settings dialog, personal workspace) on origin/main (AS IS) and this branch (TO BE), against a local ComfyUI backend. Firebase auth and the personal-workspace billing endpoints (`/api/billing/*`, `/customers/balance`, workspace and members) are stubbed per state with Playwright routes; `billing_control_enabled` and `v1_payment_recovery` are turned on through the dev `ff:` overrides. Pro tier, monthly. The Ended state has no plan catalog in the stub, so the plan card falls back to Free. **Cancelled Pro plan** (`subscription_status: canceled`, `cancel_at` set). The amber canceled card is replaced by the "Your Pro plan ends on ..." banner. | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/b0c8d40f-4e23-4ff1-a45c-46cc6c293fb2" width="480"> | <img src="https://github.com/user-attachments/assets/7c87a0a9-bf41-49e9-84c3-f96edfe283dc" width="480"> | **Out of credits** (`has_funds: false`). | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/9e2e2594-42d6-4702-a489-5d78fa9bd4c7" width="480"> | <img src="https://github.com/user-attachments/assets/1b79610e-4b5d-4d92-aa13-d826f3dcd1f6" width="480"> | **Ended** (`subscription_status: ended`, `billing_status: inactive`). | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/5ea54910-ef5e-40ac-b3dc-7fe619c7ef4c" width="480"> | <img src="https://github.com/user-attachments/assets/ddfda87e-e8a2-4fee-b836-74bc2fc5b149" width="480"> | **Members tab, ended plan.** Both sides show the upgrade-to-Team upsell and no plan-ended banner; the personal workspace keeps the upsell and does not pick up the new banner. | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/43e45cbb-4125-486a-a46c-47f2aadd7f34" width="480"> | <img src="https://github.com/user-attachments/assets/d86a5d7e-76c5-4f2f-ac74-2c632866c2d5" width="480"> | **Paused** (`billing_status: paused`). Same copy as team: "This workspace's subscription is paused. Update payment to resume." | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/756be259-7bd8-441c-94d8-c1eee5b883ba" width="480"> | <img src="https://github.com/user-attachments/assets/4e83ff50-ac50-463d-9160-70dc7b11ac7f" width="480"> | ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Align billing banners with the design reference | FE-3138 | #19680 | Merged | | Plan ended banner on every workspace tab | FE-3136 | #19682 | Merged | | **Personal-plan banners + canceled card handoff** | **FE-3241** | **this PR** | **Open** | | Retire the Members-only ended banner | FE-3159 | | Backlog | ```mermaid graph LR A["FE-3138 PR 19680 banner copy"] --> C["FE-3241 personal banners"] B["FE-3136 PR 19682 plan ended banner"] --> C B --> D["FE-3159 retire Members-only ended banner"] style C fill:#f9d71c,stroke:#333,stroke-width:2px ``` Fixes FE-3241
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (16 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 834017738c00c804d0be906402d3db0c64a1f0c4
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2202 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-06T23:40:44.884Z",
"gitSha": "681b5a58636ed710c43bf3753b9e9b12173797cb",
"branch": "backport-20254-to-core-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.8559999999661,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8000000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.533,
"heapDeltaBytes": 557612,
"heapUsedBytes": 69269100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.732,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2011.1350000000243,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8870000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.662,
"heapDeltaBytes": 591520,
"heapUsedBytes": 68062536,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.495000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1679.317000000026,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.931,
"layouts": 12,
"layoutDurationMs": 3.9830000000000005,
"taskDurationMs": 587.115,
"heapDeltaBytes": -2422104,
"heapUsedBytes": 66179908,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 111.12599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66435643564357,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.2890000000125,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.411,
"layouts": 12,
"layoutDurationMs": 4.329000000000001,
"taskDurationMs": 612.7909999999999,
"heapDeltaBytes": -2429852,
"heapUsedBytes": 65570340,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 120.98500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.048999999979,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.711000000000002,
"layouts": 6,
"layoutDurationMs": 1.185,
"taskDurationMs": 288.091,
"heapDeltaBytes": 3794092,
"heapUsedBytes": 71821064,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.360999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.3290000000497,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.559999999999999,
"layouts": 6,
"layoutDurationMs": 1.346,
"taskDurationMs": 274.27299999999997,
"heapDeltaBytes": 3740232,
"heapUsedBytes": 71708608,
"domNodes": 53,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.024,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66442307692308,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 511.6610000000037,
"styleRecalcs": 16,
"styleRecalcDurationMs": 2.8540000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.441,
"heapDeltaBytes": -9447752,
"heapUsedBytes": 59371728,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.71600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 582.2339999999713,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.935000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.53999999999996,
"heapDeltaBytes": -6452208,
"heapUsedBytes": 61015712,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 127.438,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 982.168999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.4309999999999,
"heapDeltaBytes": 15046740,
"heapUsedBytes": 85034388,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 38.51700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 364,
"frameDurationMs": 28.920588235294108,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 983.4699999999543,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.7650000000001,
"heapDeltaBytes": 15668312,
"heapUsedBytes": 85214948,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 45.08899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 363,
"frameDurationMs": 29.79999999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 747.682999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.2979999999998,
"heapDeltaBytes": 17020660,
"heapUsedBytes": 103841592,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 106.50099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 124,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.6310000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.81499999999994,
"heapDeltaBytes": 18101716,
"heapUsedBytes": 104202332,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 103.28099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 103,
"frameDurationMs": 21.076470588235306,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6044.573000000014,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5071.567,
"heapDeltaBytes": -12204668,
"heapUsedBytes": 72132844,
"domNodes": -142,
"jsHeapTotalBytes": -10883072,
"scriptDurationMs": 4001.099,
"eventListeners": -78,
"totalBlockingTimeMs": 31,
"frameDurationMs": 23.75236220472441,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6032.595000000015,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.8909999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5217.21,
"heapDeltaBytes": 8828648,
"heapUsedBytes": 93266224,
"domNodes": -143,
"jsHeapTotalBytes": -10096640,
"scriptDurationMs": 3978.8859999999995,
"eventListeners": -82,
"totalBlockingTimeMs": 24,
"frameDurationMs": 24.132399999999997,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6169.88200000003,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2329999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5411.555,
"heapDeltaBytes": -4005308,
"heapUsedBytes": 81308348,
"domNodes": -142,
"jsHeapTotalBytes": -11931648,
"scriptDurationMs": 4109.083,
"eventListeners": -78,
"totalBlockingTimeMs": 3,
"frameDurationMs": 24.86451612903226,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6212.680999999975,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9879999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5507.321999999999,
"heapDeltaBytes": 475196,
"heapUsedBytes": 85882984,
"domNodes": -143,
"jsHeapTotalBytes": -8523776,
"scriptDurationMs": 4232.121,
"eventListeners": -82,
"totalBlockingTimeMs": 27,
"frameDurationMs": 24.798800000000004,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2008.0520000000206,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.667000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.308,
"heapDeltaBytes": -9331848,
"heapUsedBytes": 79332472,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.895999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.3749999999536,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8909999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.60499999999996,
"heapDeltaBytes": -9818244,
"heapUsedBytes": 79323220,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 31.023999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2131.7129999999906,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.943999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1226.108,
"heapDeltaBytes": -20412800,
"heapUsedBytes": 68496956,
"domNodes": 0,
"jsHeapTotalBytes": 299008,
"scriptDurationMs": 630.802,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2135.0680000000466,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.168,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1207.084,
"heapDeltaBytes": -19682316,
"heapUsedBytes": 70898092,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 615.6039999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3266.5000000000077,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.916,
"layouts": 60,
"layoutDurationMs": 16.61,
"taskDurationMs": 1346.3829999999998,
"heapDeltaBytes": 1267912,
"heapUsedBytes": 70165340,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 617.5189999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3370.3590000000077,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.630999999999998,
"layouts": 60,
"layoutDurationMs": 16.48,
"taskDurationMs": 1359.7039999999997,
"heapDeltaBytes": 851152,
"heapUsedBytes": 69635216,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 621.3369999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665841584158418,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2261.821999999995,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.369999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1436.2939999999999,
"heapDeltaBytes": 5412564,
"heapUsedBytes": 74594276,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 726.086,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.790298507462683,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2256.1490000000504,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.721,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1411.095,
"heapDeltaBytes": 5240284,
"heapUsedBytes": 74466300,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 710.5450000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.791044776119403,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.712999999958,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8409999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.42600000000004,
"heapDeltaBytes": -9494896,
"heapUsedBytes": 80650792,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 29.822000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.4769999999899,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.323999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.50000000000006,
"heapDeltaBytes": -8507400,
"heapUsedBytes": 81788780,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 32.95200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 490.5430000000024,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.042000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 307.37899999999996,
"heapDeltaBytes": -12681608,
"heapUsedBytes": 57137168,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 106.412,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 476.06500000006235,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.6259999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.9,
"heapDeltaBytes": 10436120,
"heapUsedBytes": 74188276,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 102.066,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662068965517236,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2023.2179999999858,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.893,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.718,
"heapDeltaBytes": 1088728,
"heapUsedBytes": 71338292,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.938999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.4839999999767,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9460000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.32300000000004,
"heapDeltaBytes": 1079108,
"heapUsedBytes": 70520068,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.397999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1680.531999999971,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.119999999999997,
"layouts": 16,
"layoutDurationMs": 5.517,
"taskDurationMs": 604.4300000000001,
"heapDeltaBytes": -6227172,
"heapUsedBytes": 62837132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.231,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673267,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.9799999999773,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.152000000000001,
"layouts": 16,
"layoutDurationMs": 5.018,
"taskDurationMs": 581.761,
"heapDeltaBytes": -5979852,
"heapUsedBytes": 64046756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.892,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.4819999999622,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.193999999999996,
"layouts": 5,
"layoutDurationMs": 8.571000000000002,
"taskDurationMs": 653.2379999999999,
"heapDeltaBytes": -588060,
"heapUsedBytes": 90160068,
"domNodes": 14227,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 22.41100000000001,
"eventListeners": 2463,
"totalBlockingTimeMs": 95,
"frameDurationMs": 20.153488372093033,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8146.953999999994,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4307.082,
"heapDeltaBytes": -18925068,
"heapUsedBytes": 69264640,
"domNodes": 0,
"jsHeapTotalBytes": 1347584,
"scriptDurationMs": 2071.8709999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605316973415,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8177.193999999986,
"styleRecalcs": 251,
"styleRecalcDurationMs": 43.065000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4347.064,
"heapDeltaBytes": 7872476,
"heapUsedBytes": 96359124,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 2101.273,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665987780040734,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12348.960999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11663.521999999999,
"heapDeltaBytes": -40659048,
"heapUsedBytes": 181019632,
"domNodes": -3045,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 203.12300000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825632377740305,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 12334.80899999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11626.350999999999,
"heapDeltaBytes": -32727020,
"heapUsedBytes": 180800248,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 194.91699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.938709677419354,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-pan",
"durationMs": 15422.897999999976,
"styleRecalcs": 88,
"styleRecalcDurationMs": 17.63199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14727.618999999999,
"heapDeltaBytes": -32224908,
"heapUsedBytes": 183780344,
"domNodes": -3046,
"jsHeapTotalBytes": 3866624,
"scriptDurationMs": 730.775,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.009265734265735,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 15542.197999999986,
"styleRecalcs": 91,
"styleRecalcDurationMs": 17.967999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14883.787999999999,
"heapDeltaBytes": -20431240,
"heapUsedBytes": 189033024,
"domNodes": -3045,
"jsHeapTotalBytes": 1609728,
"scriptDurationMs": 736.368,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 27.62890070921986,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 4781.327000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.92600000000001,
"layouts": 20,
"layoutDurationMs": 26.723999999999997,
"taskDurationMs": 4651.131,
"heapDeltaBytes": 1071020,
"heapUsedBytes": 214646936,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 86.394,
"eventListeners": 0,
"totalBlockingTimeMs": 2,
"frameDurationMs": 26.281318681318677,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4996.4840000000095,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.90199999999998,
"layouts": 20,
"layoutDurationMs": 26.797,
"taskDurationMs": 4837.915000000001,
"heapDeltaBytes": 2816304,
"heapUsedBytes": 224751356,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 87.819,
"eventListeners": 0,
"totalBlockingTimeMs": 5,
"frameDurationMs": 27.93184357541899,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6265.445,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5804.245999999999,
"heapDeltaBytes": -27811360,
"heapUsedBytes": 181149152,
"domNodes": -3045,
"jsHeapTotalBytes": 7098368,
"scriptDurationMs": 101.49600000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.31428571428572,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6108.834999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5718.452000000001,
"heapDeltaBytes": -33446276,
"heapUsedBytes": 180678452,
"domNodes": -3045,
"jsHeapTotalBytes": 7884800,
"scriptDurationMs": 95.72699999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.209634551495025,
"p95FrameDurationMs": 33.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 462.5819999999976,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.062,
"layouts": 5,
"layoutDurationMs": 2.401,
"taskDurationMs": 127.66800000000003,
"heapDeltaBytes": 5900352,
"heapUsedBytes": 71292608,
"domNodes": 129,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.785999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 119.84799999993356,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.623,
"layouts": 3,
"layoutDurationMs": 1.2049999999999998,
"taskDurationMs": 69.718,
"heapDeltaBytes": 3767460,
"heapUsedBytes": 68983508,
"domNodes": 94,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.664000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 460.39599999994607,
"styleRecalcs": 78,
"styleRecalcDurationMs": 69.919,
"layouts": 76,
"layoutDurationMs": 16.768,
"taskDurationMs": 422.215,
"heapDeltaBytes": 13344332,
"heapUsedBytes": 88570980,
"domNodes": 76,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 140.684,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 447.8440000000319,
"styleRecalcs": 78,
"styleRecalcDurationMs": 66.327,
"layouts": 76,
"layoutDurationMs": 17.117,
"taskDurationMs": 418.175,
"heapDeltaBytes": 13464052,
"heapUsedBytes": 94779352,
"domNodes": 76,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 143.873,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 815.0490000000445,
"styleRecalcs": 78,
"styleRecalcDurationMs": 188.63299999999998,
"layouts": 76,
"layoutDurationMs": 18.011,
"taskDurationMs": 792.7460000000001,
"heapDeltaBytes": 10131816,
"heapUsedBytes": 130589048,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 216.88000000000002,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 764.7979999999279,
"styleRecalcs": 78,
"styleRecalcDurationMs": 179.64,
"layouts": 76,
"layoutDurationMs": 16.832,
"taskDurationMs": 729.7479999999999,
"heapDeltaBytes": 3734600,
"heapUsedBytes": 110383316,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 195.32,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663829787234057,
"p95FrameDurationMs": 16.799999999999272
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
dante01yoon
left a comment
There was a problem hiding this comment.
Backport of PR 20254.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.56 #20342 +/- ##
==========================================
Coverage 85.90% 85.90%
==========================================
Files 2461 2461
Lines 140588 140613 +25
Branches 38212 38228 +16
==========================================
+ Hits 120768 120791 +23
- Misses 19442 19444 +2
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
The |
Backport of #20254 to
core/1.56Automatically created by backport workflow.