Repository navigation
fix(agent): release minimap graph-activity layer reliably on unmount - #20071
Conversation
The agent.graph-activity minimap layer was disposed as the last statement of a long onBeforeUnmount hook, so any earlier teardown step throwing left the id registered and the next mount reported a duplicate layer. Dispose it in its own hook registered next to the registration, and add a regression test.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e019a32c9313dc18eb044f46c3661b0b9e98b291
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10.2 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.92 kB (baseline 3.92 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.47 MB (baseline 1.47 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 648 kB (baseline 648 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 53.7 kB (baseline 53.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 194 kB (baseline 194 kB) • ⚪ 0 BReusable component library chunks Status: 18 unchanged Data & Services — 4.11 MB (baseline 4.11 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 14 unchanged Utilities & Hooks — 587 kB (baseline 587 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.4 MB (baseline 18.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 306 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-04T06:18:35.071Z",
"gitSha": "df7edb7117896bd8ccf8a7d27c39ab322e06d0e3",
"branch": "fix/agent-minimap-layer-leak",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.6940000000245,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.877,
"heapDeltaBytes": 509536,
"heapUsedBytes": 68220104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.239000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2017.4620000000232,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.238999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.64,
"heapDeltaBytes": 22382580,
"heapUsedBytes": 76485856,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.858999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.0929999999858,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.237000000000002,
"layouts": 12,
"layoutDurationMs": 4.127000000000001,
"taskDurationMs": 548.5609999999999,
"heapDeltaBytes": -2399624,
"heapUsedBytes": 65240728,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.26999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1739.7589999999923,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.987999999999996,
"layouts": 12,
"layoutDurationMs": 4.049,
"taskDurationMs": 570.05,
"heapDeltaBytes": -31598328,
"heapUsedBytes": 72415580,
"domNodes": -231,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 114.643,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1714.3350000000055,
"styleRecalcs": 33,
"styleRecalcDurationMs": 9.498,
"layouts": 6,
"layoutDurationMs": 1.1669999999999998,
"taskDurationMs": 226.99999999999997,
"heapDeltaBytes": 25392032,
"heapUsedBytes": 79330536,
"domNodes": -177,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.7,
"eventListeners": -145,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.3619999999892,
"styleRecalcs": 29,
"styleRecalcDurationMs": 8.658000000000001,
"layouts": 6,
"layoutDurationMs": 1.224,
"taskDurationMs": 216.385,
"heapDeltaBytes": 25598676,
"heapUsedBytes": 79672916,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.233,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 466.2119999999845,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.226999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.006,
"heapDeltaBytes": 14219856,
"heapUsedBytes": 68126964,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.354,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 471.12199999997983,
"styleRecalcs": 16,
"styleRecalcDurationMs": 3.8169999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.715,
"heapDeltaBytes": -35980080,
"heapUsedBytes": 67951448,
"domNodes": -232,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 106.495,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 872.7859999999907,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.255,
"heapDeltaBytes": 12534480,
"heapUsedBytes": 82097156,
"domNodes": 0,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 36.839999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 247,
"frameDurationMs": 25.237142857142864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 876.2949999999705,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.768,
"heapDeltaBytes": 14963156,
"heapUsedBytes": 91883208,
"domNodes": 0,
"jsHeapTotalBytes": 8290304,
"scriptDurationMs": 35.422000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 269,
"frameDurationMs": 25.9764705882353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 687.2789999999895,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.96599999999995,
"heapDeltaBytes": -14363156,
"heapUsedBytes": 79617068,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 98.89300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 91,
"frameDurationMs": 20.58529411764705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 699.3909999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.45399999999995,
"heapDeltaBytes": -14322108,
"heapUsedBytes": 105247680,
"domNodes": 0,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 91.859,
"eventListeners": 0,
"totalBlockingTimeMs": 86,
"frameDurationMs": 20.585294117647074,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5728.399999999993,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.9069999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4710.972,
"heapDeltaBytes": 3318536,
"heapUsedBytes": 83782712,
"domNodes": 0,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 3674.503,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.186619718309856,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5461.381000000018,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.0880000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4626.315,
"heapDeltaBytes": 16862416,
"heapUsedBytes": 94059704,
"domNodes": -142,
"jsHeapTotalBytes": -6164480,
"scriptDurationMs": 3705.172,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.960384615384616,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5578.401999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4842.004999999999,
"heapDeltaBytes": -750700,
"heapUsedBytes": 80489600,
"domNodes": 0,
"jsHeapTotalBytes": -13369344,
"scriptDurationMs": 3832.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.228517110266157,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5610.015000000032,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6479999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4726.294999999999,
"heapDeltaBytes": -8591864,
"heapUsedBytes": 71873292,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 3684.418,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.215884476534292,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2039.7319999999581,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6089999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.576,
"heapDeltaBytes": -53785632,
"heapUsedBytes": 72081732,
"domNodes": -328,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 25.690000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.986000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.947000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.09000000000003,
"heapDeltaBytes": -53804776,
"heapUsedBytes": 71884444,
"domNodes": -328,
"jsHeapTotalBytes": -1146880,
"scriptDurationMs": 24.634,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2099.9099999999657,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.767,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1012.346,
"heapDeltaBytes": 1163400,
"heapUsedBytes": 64268316,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 532.831,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2167.093999999963,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1124.148,
"heapDeltaBytes": 10099108,
"heapUsedBytes": 89580812,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 588.286,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79609375,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3068.7679999999773,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.326999999999998,
"layouts": 60,
"layoutDurationMs": 14.56,
"taskDurationMs": 1109.532,
"heapDeltaBytes": -670576,
"heapUsedBytes": 64400396,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 508.33400000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665760869565215,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3078.501000000017,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.382000000000001,
"layouts": 60,
"layoutDurationMs": 14.642000000000001,
"taskDurationMs": 1124.8749999999998,
"heapDeltaBytes": 140592,
"heapUsedBytes": 64393820,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 510.1319999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2206.6790000000083,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.271,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1267.1219999999998,
"heapDeltaBytes": 4565416,
"heapUsedBytes": 70700556,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 641.813,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2146.199999999965,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.261,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1185.662,
"heapDeltaBytes": 3182668,
"heapUsedBytes": 71675992,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 635.092,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000002,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2004.267000000027,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.705,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 286.82900000000006,
"heapDeltaBytes": 13831524,
"heapUsedBytes": 87469036,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 25.764999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.66299999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8509999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.13,
"heapDeltaBytes": -27338556,
"heapUsedBytes": 72797536,
"domNodes": -328,
"jsHeapTotalBytes": -3805184,
"scriptDurationMs": 26.331,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 454.1100000000142,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.62899999999996,
"heapDeltaBytes": -42431488,
"heapUsedBytes": 63205080,
"domNodes": -249,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 96.79899999999999,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670370370370385,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 451.6830000000027,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.405000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.18500000000006,
"heapDeltaBytes": -42476244,
"heapUsedBytes": 63211680,
"domNodes": -250,
"jsHeapTotalBytes": -2097152,
"scriptDurationMs": 96.06099999999999,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2028.4970000000158,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.709999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.231,
"heapDeltaBytes": -30314176,
"heapUsedBytes": 75802736,
"domNodes": -249,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 8.533,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.7720000000077,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.119,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.437,
"heapDeltaBytes": 685124,
"heapUsedBytes": 70707544,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.757,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.824000000011,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.853,
"layouts": 16,
"layoutDurationMs": 5.634,
"taskDurationMs": 508.644,
"heapDeltaBytes": 15046316,
"heapUsedBytes": 69379088,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.39300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667326732673274,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.561000000012,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.605,
"layouts": 16,
"layoutDurationMs": 6.790000000000001,
"taskDurationMs": 545.763,
"heapDeltaBytes": -6290388,
"heapUsedBytes": 63449044,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.809,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.6019999999653,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.85599999999999,
"layouts": 5,
"layoutDurationMs": 8.575000000000001,
"taskDurationMs": 639.954,
"heapDeltaBytes": 21983284,
"heapUsedBytes": 108837700,
"domNodes": 13747,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 21.386000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 66,
"frameDurationMs": 19.44523809523809,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8119.420000000047,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.743,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3794.842,
"heapDeltaBytes": 8367252,
"heapUsedBytes": 95434208,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1906.9799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665913757700206,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8241.725000000031,
"styleRecalcs": 251,
"styleRecalcDurationMs": 41.550999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3770.2000000000003,
"heapDeltaBytes": -7410536,
"heapUsedBytes": 91016444,
"domNodes": -328,
"jsHeapTotalBytes": -2793472,
"scriptDurationMs": 1815.86,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665991902834005,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11575.697000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10705.552999999998,
"heapDeltaBytes": -39150848,
"heapUsedBytes": 170507884,
"domNodes": -3045,
"jsHeapTotalBytes": 8179712,
"scriptDurationMs": 161.072,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.665365025466894,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 12434.552000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11408.217,
"heapDeltaBytes": -28565928,
"heapUsedBytes": 186824452,
"domNodes": -3045,
"jsHeapTotalBytes": 7798784,
"scriptDurationMs": 173.54999999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.108658743633274,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 13876.073000000019,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.205999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13272.419000000002,
"heapDeltaBytes": -21511404,
"heapUsedBytes": 187625412,
"domNodes": -3045,
"jsHeapTotalBytes": 7847936,
"scriptDurationMs": 599.8950000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.86475849731664,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14476.440000000024,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.469999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13866.097000000002,
"heapDeltaBytes": -17553480,
"heapUsedBytes": 192855080,
"domNodes": -3045,
"jsHeapTotalBytes": 7442432,
"scriptDurationMs": 611.968,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.783481349911188,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4317.571999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 52.55000000000001,
"layouts": 20,
"layoutDurationMs": 22.654,
"taskDurationMs": 4195.679,
"heapDeltaBytes": -6123076,
"heapUsedBytes": 205357552,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 69.188,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.847305389221557,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4281.740000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.97000000000001,
"layouts": 20,
"layoutDurationMs": 21.49600000000001,
"taskDurationMs": 4153.878,
"heapDeltaBytes": 8106540,
"heapUsedBytes": 226389084,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 69.82799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.757803468208095,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6406.160999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6065.054999999999,
"heapDeltaBytes": -24506500,
"heapUsedBytes": 191361668,
"domNodes": -3045,
"jsHeapTotalBytes": 7290880,
"scriptDurationMs": 95.88800000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.841979522184303,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6237.234000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5656.848999999999,
"heapDeltaBytes": -64552528,
"heapUsedBytes": 167004508,
"domNodes": -3050,
"jsHeapTotalBytes": 9314304,
"scriptDurationMs": 103.18499999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.846488294314383,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "workflow-execution",
"durationMs": 113.12099999997827,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.569000000000003,
"layouts": 3,
"layoutDurationMs": 0.9940000000000001,
"taskDurationMs": 73.59199999999998,
"heapDeltaBytes": 3956352,
"heapUsedBytes": 57770700,
"domNodes": 97,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.889999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 116.93300000001727,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.953,
"layouts": 3,
"layoutDurationMs": 1.1170000000000002,
"taskDurationMs": 85.225,
"heapDeltaBytes": -44802968,
"heapUsedBytes": 57021020,
"domNodes": -119,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 5.804,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.657142857142844,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 497.0289999999977,
"styleRecalcs": 78,
"styleRecalcDurationMs": 77.613,
"layouts": 76,
"layoutDurationMs": 21.581,
"taskDurationMs": 450.974,
"heapDeltaBytes": 13938448,
"heapUsedBytes": 85694896,
"domNodes": 76,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 151.76999999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.260714285714275,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 380.7199999999966,
"styleRecalcs": 78,
"styleRecalcDurationMs": 69.49900000000001,
"layouts": 76,
"layoutDurationMs": 17.517999999999997,
"taskDurationMs": 342.49199999999996,
"heapDeltaBytes": 12820632,
"heapUsedBytes": 85225432,
"domNodes": 76,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 110.571,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66956521739131,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 740.7030000000532,
"styleRecalcs": 78,
"styleRecalcDurationMs": 199.23499999999999,
"layouts": 76,
"layoutDurationMs": 25.132,
"taskDurationMs": 712.053,
"heapDeltaBytes": 9176224,
"heapUsedBytes": 130464500,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 173.309,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668888888888876,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 764.4739999999501,
"styleRecalcs": 78,
"styleRecalcDurationMs": 202.882,
"layouts": 76,
"layoutDurationMs": 23.594,
"taskDurationMs": 733.973,
"heapDeltaBytes": 9394032,
"heapUsedBytes": 131774708,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 186.706,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2193 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20071 +/- ##
==========================================
+ Coverage 85.01% 85.75% +0.74%
==========================================
Files 3458 2430 -1028
Lines 166371 138817 -27554
Branches 43463 37577 -5886
==========================================
- Hits 141433 119043 -22390
+ Misses 22967 19399 -3568
+ Partials 1971 375 -1596
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1033 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| @@ -1243,7 +1247,6 @@ onBeforeUnmount(() => { | |||
| ++activeTabGeneration | |||
| tabActivity.setEditing(null) | |||
| tabActivity.setCreating(false) | |||
There was a problem hiding this comment.
🟡 Medium — Pulling only dispose() out of this hook rescues one victim and leaves the rest exposed to the same hazard: a throw in setEditing/setCreating, releaseCoachCompletionWaiters(), invalidateSubmission(), docOpMinter.detach(), exitNodeSelectionMode(), or stop() still skips the PM-1575 setCanvasSyncGate reset documented immediately below, leaving a torn-down follower's gate on the store singleton — which that comment calls the only thing standing between a resumed turn and the stale gate. Because no app.config.errorHandler is registered, outside production Vue rethrows out of invokeArrayFns, so the remainder of unmountComponent (the cancelAllUploads hook, scope.stop()) is abandoned too. Wrapping each step the way runFollowerTeardown already does in this file would cover all of them instead of one. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case).
There was a problem hiding this comment.
Agreed this hazard exists, but it predates this PR: those steps were already unguarded before #17730's layer was added, and wrapping them (as runFollowerTeardown does) is a wider teardown change than this leak fix. Leaving it out of scope here; worth a separate follow-up.
Generated by Claude Code
There was a problem hiding this comment.
Reopening this: the follow-up exists now — #20078.
Two corrections to the reply above. It does not only predate #20071: #20071 added a dependency on the hazard by putting a step before the hook whose failure it is protecting against, which is why the layer dispose had to move out. And the gate is not merely reset late — it is never reset at all. Arming docOpMinter.detach() to throw and spying setCanvasSyncGate across unmount records zero calls against this PR's merged state.
#20078 runs every step of all three onBeforeUnmount hooks through a runPanelTeardown that reports a failing step as failure_tearing_down_agent_panel and continues, the shape runFollowerTeardown already uses — so the remaining steps, the later hooks and scope.stop() all survive. Step order is unchanged, and the duplicate-free remount assertion from this PR is untouched.
Registering the layer during setup left the id claimed when setup threw before the component mounted, since no unmount hook ever ran. Register it in onMounted instead and keep the dispose in its own onBeforeUnmount hook. Tighten the unmount regression test to arm the throw right before unmount and assert it comes from the beforeUnmount hook, and add a test for a setup failure.
Claiming the layer on mount closes the setup-failure window, but it does not cover the other order the registry can see: a replacement panel finishing its mount while the outgoing one still holds the id. The duplicate branch handed the newcomer a no-op layer, so the panel that survived the handover painted nothing on the minimap for the rest of the session and only a Sentry event showed it. Hand the id to the newest registrant instead, and mark the replaced layer disposed so the outgoing panel's own dispose() cannot delete its replacement's rows. The duplicate is still reported: one id held twice at once is worth seeing, and it is now a diagnostic rather than a broken minimap. Tests: a registry unit test for the handover, an AgentPanelRoot test asserting the surviving panel still paints (both fail without this change), and a black-box spec asserting the minimap's accessible summary reports the same nodes after the panel closes and reopens. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Reviewed this at Claiming the layer in Three tests came with it: a registry unit test for the handover and an On the open thread about wrapping the remaining teardown steps: agreed that is wider than this fix. One thing worth recording for whoever takes it, since it changed under this PR: the minimap release is now the first |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
|
…r reliably on unmount (#20077) Backports #20071 to `cloud/1.54` after the automated cherry-pick conflicted.\n\nConflict resolution preserves the target Agent/billing test surface and adds the original lifecycle regression coverage.\n\nVerification: `corepack pnpm vitest src/renderer/extensions/minimap/minimapDecorationRegistry.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --run` — 379/379 passed. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
… reliably on unmount (#20075) Backport of #20071 to `core/1.55` Automatically created by backport workflow. Justification: authorized core/1.55 Agent backport under program/release-backport-authority.md; source #20071 exact head 16dc864 was approved by christian-byrne, carrier head 726814a preserves the reviewed five-file repair and black-box proof, all required checks are terminal green, no review threads or objections exist, and the sole target-tip delta 25df034 has zero file overlap. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…r reliably on unmount (#20076) Backport of #20071 to `cloud/1.55` Automatically created by backport workflow. Justification: Authorized Agent backport to cloud/1.55 under the standing release grant. Exact head fe6db05 has all required checks green, no adverse or pending checks, no review objection, and preserves the reviewed #20071 five-file behavior/test slice. The target advanced by one commit ba538e1 touching six node-error contract files; the binding gate reports zero file overlap with this carrier's minimap/panel files, so the untested delta cannot interact. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
## Summary Follow-up to Comfy-Org#20071: make the agent panel's unmount total, so no teardown step can be skipped by an earlier one throwing. ## Context Comfy-Org#20071 moved the `agent.graph-activity` minimap dispose into its own `onBeforeUnmount`, ahead of the large unmount hook, so a throwing teardown step could no longer leave the layer id claimed in the module registry. Review ([thread](Comfy-Org#20071 (comment)), raised by 4 of 8 reviewers) found that this rescues one victim and leaves the rest exposed, and the PR merged with the thread open and the fix deferred to a follow-up. This is that follow-up. A throw in `releaseCoachCompletionWaiters()`, `invalidateSubmission()`, `docOpMinter.detach()`, `restoreOpMinter.detach()`, `exitNodeSelectionMode()`, `stop()` or `setEditing`/`setCreating` still skips every later step in the same hook — including the PM-1575 `setCanvasSyncGate` reset, which the comment beside it calls the only thing standing between a turn resumed in the meantime and a torn-down follower's gate on the store singleton. The gate is not merely late in that case, it is never reset: a reverted-fix run of the new test records **zero** `setCanvasSyncGate` calls during unmount. It is also wider than one hook. No `app.config.errorHandler` is registered anywhere in the app, so Vue's `logError` re-throws outside production builds; the throw escapes `invokeArrayFns` and abandons the remaining `beforeUnmount` hooks (`attachment.cancelAllUploads()`) and the rest of `unmountComponent`, including `scope.stop()`. ## Changes - **What**: every step of `AgentPanelRoot.vue`'s unmount now runs through a local `runPanelTeardown`, which reports a failing step as `failure_tearing_down_agent_panel` and continues to the next one. All three of the component's `onBeforeUnmount` hooks go through it, so no hook can abandon a later one either. Step order is unchanged. - **Steps are keyed, not positional**: the key rides on `tags.step`, because the error is swallowed now and the report is the only remaining signal that a release was skipped — telemetry has to be able to tell a `stopSession` failure (a leaked event-stream subscription and un-aborted turn recovery for the session) from a benign `clearCreatingTab` one. No key is integer-like, so `Object.entries` order is specified and insertion order stays the run order. Steps return `undefined` rather than `void` so an async step — whose rejection would escape the catch while still looking contained — fails to compile. The `reportError` call has its own try/catch, since it was the one call in the loop that could abort the teardown it was reporting on. - **Tests**: a new case arms `docOpMinter.detach()` to throw and asserts the PM-1575 gate is still reset to the always-safe default (`gate() === false`, `outcomeCount() === 0`); it fails on the primary assertion against `main` (`expected to be called once, but got 0 times`). The existing throwing-teardown case now asserts the error is *contained and reported* rather than escaping to Vue's handler, and also fails against `main`. A third case arms the reporter itself to throw and asserts the gate is still reset; it fails against an unguarded reporter. Both pre-existing cases assert the `step` tag. The minimap duplicate-free remount assertion from Comfy-Org#20071 is unchanged. ## Review Focus Four review findings came back on the first revision; three are fixed in 6234899 (async-step typing, the unguarded reporter, the undifferentiated `errorType`). The fourth — that several steps are themselves multi-release sequences with no internal guard — is real and is answered on the thread: it needs three small per-module changes rather than anything this call site can express, and `exitNodeSelectionMode()` in particular is re-entrant by design so splitting it at the call site is unsafe. This deliberately mirrors `runFollowerTeardown` in `crdt/useAgentCrdtFollower.ts` — same rationale, same report-and-continue shape — rather than sharing it, because that file is the CRDT follower's own teardown and its reporter is hard-coded to a different `errorType`. Say the word if you would rather have one shared helper and I will extract it. The second-order question the thread raises and this does not answer: registering an `app.config.errorHandler` would make unmount resilient app-wide instead of one component at a time. That is a global behavior change well outside a teardown fix, so it is not attempted here.
Requested via Slack thread
Summary
Release the agent panel's
agent.graph-activityminimap layer in its own unmount hook, so a failing teardown step can no longer leave it registered.Before
The layer was disposed as the very last statement of a long
onBeforeUnmounthook. If any earlier teardown step threw, the dispose call was skipped and the id stayed claimed in the module-level registry. The next time the panel mounted, the registry reported a "Minimap decoration layer exists" duplicate error and handed back a no-op layer, so graph activity silently stopped showing on the minimap. Introduced by #17730.After
The layer is released in a dedicated
onBeforeUnmounthook registered right next to the registration, ahead of every other teardown step. An unmount that hits a throwing step still frees the id, and the next mount registers a working layer without reporting a duplicate.Changes
AgentPanelRoot.vueclaims the layer inonMountedand releases it in its ownonBeforeUnmounthook, instead of claiming it insetup()and releasing it as the last statement of the large unmount hook.minimapDecorationRegistry.tshands a contested id to the newest claimant and marks the replaced layer disposed, so the outgoing producer'sdispose()cannot delete its replacement's rows.AgentPanelRoot.test.tscovers a throwing teardown step, a throwing setup, and a replacement panel that mounts before the old one unmounts.minimapDecorationRegistry.test.tscovers the handover directly.browser_tests/tests/agent/agentGraphActivity.spec.tsasserts the minimap's accessible summary reports the same nodes after the panel closes and reopens. Every one of these fails against the code it pins.Review Focus
The registry now hands a contested id to the newest claimant instead of returning a no-op layer. An earlier revision of this PR left that alone; review found the order it does not cover, where a replacement panel finishes mounting while the outgoing one still holds the id, which left the surviving panel unable to paint for the rest of the session. The duplicate is still reported, so a genuine double-registration stays visible. A separate hook beat
onScopeDisposebecause Vue rethrows hook errors in dev builds before the scope is stopped, while a hook registered first always runs.🤖 Generated with Claude Code
https://claude.ai/code/session_01XeSNgXaSJddAL4WmNEqe7j
Generated by Claude Code