Skip to content

[backport cloud/1.54] fix(agent): release minimap graph-activity layer reliably on unmount - #20077

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-20071-to-cloud-1.54
Oct 4, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-20071-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #20071 to cloud/1.54 after the automated cherry-pick conflicted.\n\nConflict resolution preserves the target Agent/billing test surface and adds the original lifecycle regression coverage.\n\nVerification: corepack pnpm vitest src/renderer/extensions/minimap/minimapDecorationRegistry.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --run — 379/379 passed.

…20071)

Backport the lifecycle repair and its unit/browser regression coverage to cloud/1.54. Conflict resolution preserves the target billing and Agent test surface.
@christian-byrne
christian-byrne requested a review from a team as a code owner October 4, 2026 07:04
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Oct 4, 2026
@vercel

vercel Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 4, 2026 7:08am UTC
billing-web-test Ignored Ignored Oct 4, 2026 7:08am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 03799ed0-a2cf-4bf2-8e7d-2491c05783b8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1990 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1969 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/04/2026, 07:10:26 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.1 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 63ms TBT · 104.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.1 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 38ms TBT · 178.3 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 26ms TBT · 174.4 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 11ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 353ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.9 MB
canvas-idle: DOM nodes -137
canvas-idle: event listeners -194
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 24ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 594ms
canvas-mouse-sweep: script duration 103ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.7 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -178
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 256ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 73.3 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 322ms
dom-widget-clipping: script duration 107ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.7 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 369ms
large-graph-idle: script duration 28ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 73.1 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -161
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1132ms
large-graph-pan: script duration 556ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.6 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -191
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 17ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 73
large-graph-zoom: task duration 1178ms
large-graph-zoom: script duration 520ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 80.3 MB
large-graph-zoom: DOM nodes -111
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1287ms
legacy-node-drag: script duration 646ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 80.4 MB
legacy-node-drag: DOM nodes 9
legacy-node-drag: event listeners 185
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 400ms
minimap-idle: script duration 28ms
minimap-idle: TBT 0ms
minimap-idle: heap used 73.1 MB
minimap-idle: DOM nodes -269
minimap-idle: event listeners -162
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 282ms
subgraph-dom-widget-clipping: script duration 93ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 73.1 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 391ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.8 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 25ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 619ms
subgraph-mouse-sweep: script duration 89ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.2 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -225
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 548ms
subgraph-transition-enter: script duration 19ms
subgraph-transition-enter: TBT 63ms
subgraph-transition-enter: heap used 104.8 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 44ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4003ms
viewport-pan-sweep: script duration 1873ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 72.3 MB
viewport-pan-sweep: DOM nodes -273
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11898ms
vue-large-graph-idle: script duration 210ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.1 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 73
vue-large-graph-pan: task duration 13953ms
vue-large-graph-pan: script duration 637ms
vue-large-graph-pan: TBT 38ms
vue-large-graph-pan: heap used 178.3 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14932
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 53ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4328ms
vue-node-resize-workload: script duration 72ms
vue-node-resize-workload: TBT 26ms
vue-node-resize-workload: heap used 174.4 MB
vue-node-resize-workload: DOM nodes -8069
vue-node-resize-workload: event listeners -14940
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5544ms
vue-zoom-out-idle: script duration 77ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 179.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -8
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 16
workflow-execution: task duration 91ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 72.4 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-10-04T07:18:19.244Z",
  "gitSha": "72b2e850a131e341caa2d24c85a1b50312dc6c97",
  "branch": "backport-20071-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2058.0380000000105,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 14.548999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 412.609,
      "heapDeltaBytes": -10591652,
      "heapUsedBytes": 62793648,
      "domNodes": -278,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 10.941,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2029.830000000004,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.768000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 292.84700000000004,
      "heapDeltaBytes": -14346888,
      "heapUsedBytes": 56524556,
      "domNodes": 4,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 5.854000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1739.0990000000102,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.897999999999996,
      "layouts": 14,
      "layoutDurationMs": 3.849,
      "taskDurationMs": 641.598,
      "heapDeltaBytes": 8628564,
      "heapUsedBytes": 79921528,
      "domNodes": -278,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 109.69300000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1703.9530000000127,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 22.581999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.8559999999999994,
      "taskDurationMs": 545.7220000000001,
      "heapDeltaBytes": -2802884,
      "heapUsedBytes": 70548836,
      "domNodes": -278,
      "jsHeapTotalBytes": 4231168,
      "scriptDurationMs": 96.96499999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1671.1439999999698,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.827999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.258,
      "taskDurationMs": 270.048,
      "heapDeltaBytes": 4331300,
      "heapUsedBytes": 75289952,
      "domNodes": 79,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.058,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1671.1870000000317,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.701999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.995,
      "taskDurationMs": 242.097,
      "heapDeltaBytes": 4925136,
      "heapUsedBytes": 78367796,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.141999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 542.7250000000186,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.749000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.704,
      "heapDeltaBytes": -7332272,
      "heapUsedBytes": 66681480,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 113.57899999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 463.6750000000234,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 7.117,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 293.336,
      "heapDeltaBytes": -7161416,
      "heapUsedBytes": 66841256,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 99.52,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2009.3219999999974,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.794000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.302,
      "heapDeltaBytes": -3613072,
      "heapUsedBytes": 76525000,
      "domNodes": -270,
      "jsHeapTotalBytes": -2322432,
      "scriptDurationMs": 29.183,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.5330000000195,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.349000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 339.856,
      "heapDeltaBytes": -3927316,
      "heapUsedBytes": 76830960,
      "domNodes": -263,
      "jsHeapTotalBytes": -4157440,
      "scriptDurationMs": 27.410999999999998,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2400.579999999991,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.7,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1239.7690000000002,
      "heapDeltaBytes": 11582676,
      "heapUsedBytes": 92796920,
      "domNodes": -274,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 599.2539999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2131.8110000000274,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 14.966999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1025.2120000000002,
      "heapDeltaBytes": 3328668,
      "heapUsedBytes": 84711160,
      "domNodes": -278,
      "jsHeapTotalBytes": -1048576,
      "scriptDurationMs": 513.108,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3285.558999999978,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 17.849,
      "layouts": 60,
      "layoutDurationMs": 14.365,
      "taskDurationMs": 1282.4759999999999,
      "heapDeltaBytes": 2594136,
      "heapUsedBytes": 82297856,
      "domNodes": -262,
      "jsHeapTotalBytes": 4354048,
      "scriptDurationMs": 547.963,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3121.442000000002,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 16.358999999999998,
      "layouts": 60,
      "layoutDurationMs": 12.965,
      "taskDurationMs": 1073.542,
      "heapDeltaBytes": 3814624,
      "heapUsedBytes": 86199352,
      "domNodes": 40,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 491.79400000000004,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2471.474999999998,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 7.885,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1389.3559999999998,
      "heapDeltaBytes": 2802740,
      "heapUsedBytes": 70649856,
      "domNodes": 6,
      "jsHeapTotalBytes": 1310720,
      "scriptDurationMs": 696.355,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2180.950999999993,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.269,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1183.995,
      "heapDeltaBytes": 13136344,
      "heapUsedBytes": 97915964,
      "domNodes": 12,
      "jsHeapTotalBytes": 6184960,
      "scriptDurationMs": 595.26,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.3340000000003,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.822,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.854,
      "heapDeltaBytes": -5173052,
      "heapUsedBytes": 76579616,
      "domNodes": -269,
      "jsHeapTotalBytes": -2322432,
      "scriptDurationMs": 29.262999999999998,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2016.9250000000147,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.136000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.05,
      "heapDeltaBytes": -5262716,
      "heapUsedBytes": 76695940,
      "domNodes": -268,
      "jsHeapTotalBytes": -2584576,
      "scriptDurationMs": 27.187,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 481.03200000002744,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.799999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 292.018,
      "heapDeltaBytes": 14871652,
      "heapUsedBytes": 88047244,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 97.157,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 411.06600000000526,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 10.723,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 272.615,
      "heapDeltaBytes": -10647204,
      "heapUsedBytes": 65231172,
      "domNodes": 24,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 89.836,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.961000000037,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.202000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.24600000000004,
      "heapDeltaBytes": -2620944,
      "heapUsedBytes": 70241976,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 16.396,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2013.7260000000197,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.813999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 318.755,
      "heapDeltaBytes": -6114568,
      "heapUsedBytes": 69753580,
      "domNodes": -299,
      "jsHeapTotalBytes": 3969024,
      "scriptDurationMs": 6.759999999999999,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1711.9299999999953,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.308999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.014,
      "taskDurationMs": 657.7689999999999,
      "heapDeltaBytes": -7135356,
      "heapUsedBytes": 66700048,
      "domNodes": -298,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 93.432,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.6440000000393,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 24.566,
      "layouts": 18,
      "layoutDurationMs": 5.093999999999999,
      "taskDurationMs": 579.796,
      "heapDeltaBytes": 7680012,
      "heapUsedBytes": 82536600,
      "domNodes": -297,
      "jsHeapTotalBytes": 3182592,
      "scriptDurationMs": 84.46000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 799.8499999999922,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 21.462999999999997,
      "layouts": 16,
      "layoutDurationMs": 10.212999999999997,
      "taskDurationMs": 547.6990000000002,
      "heapDeltaBytes": 19278048,
      "heapUsedBytes": 109905972,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 18.526,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 63,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8388.26800000004,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 44.937999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4063.714,
      "heapDeltaBytes": -10697072,
      "heapUsedBytes": 66620940,
      "domNodes": -268,
      "jsHeapTotalBytes": -626688,
      "scriptDurationMs": 1908.8149999999998,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8188.329999999951,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 43.715,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3941.912,
      "heapDeltaBytes": 4488080,
      "heapUsedBytes": 85028592,
      "domNodes": -278,
      "jsHeapTotalBytes": -786432,
      "scriptDurationMs": 1837.165,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12364.149999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11590.289999999999,
      "heapDeltaBytes": -59795120,
      "heapUsedBytes": 180244452,
      "domNodes": -8068,
      "jsHeapTotalBytes": -22089728,
      "scriptDurationMs": 194.861,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12755.225999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12204.916000000001,
      "heapDeltaBytes": -34416688,
      "heapUsedBytes": 178486768,
      "domNodes": -8068,
      "jsHeapTotalBytes": -22183936,
      "scriptDurationMs": 225.82799999999997,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13805.615999999987,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.734999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13413.169999999998,
      "heapDeltaBytes": -23049532,
      "heapUsedBytes": 190243744,
      "domNodes": -8068,
      "jsHeapTotalBytes": -21217280,
      "scriptDurationMs": 605.9859999999999,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14919.35000000001,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 15.31200000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14492.369,
      "heapDeltaBytes": -49373840,
      "heapUsedBytes": 183761524,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12484608,
      "scriptDurationMs": 668.4259999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4257.542999999998,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 51.98699999999998,
      "layouts": 20,
      "layoutDurationMs": 20.123,
      "taskDurationMs": 4181.481,
      "heapDeltaBytes": -38377352,
      "heapUsedBytes": 180639808,
      "domNodes": -8069,
      "jsHeapTotalBytes": 13094912,
      "scriptDurationMs": 69.97800000000001,
      "eventListeners": -14949,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 17.773333333333298,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4530.816999999956,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.024000000000015,
      "layouts": 20,
      "layoutDurationMs": 23.354,
      "taskDurationMs": 4475.354,
      "heapDeltaBytes": -38697760,
      "heapUsedBytes": 185037080,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9691136,
      "scriptDurationMs": 73.83899999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 43,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5990.796999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5503.919999999999,
      "heapDeltaBytes": 1089864,
      "heapUsedBytes": 180365712,
      "domNodes": 0,
      "jsHeapTotalBytes": -27525120,
      "scriptDurationMs": 77.47499999999997,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6047.124999999937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5583.528000000001,
      "heapDeltaBytes": 28324552,
      "heapUsedBytes": 196408592,
      "domNodes": 0,
      "jsHeapTotalBytes": -12320768,
      "scriptDurationMs": 77.36500000000002,
      "eventListeners": -6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 433.1940000000145,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 19.142,
      "layouts": 3,
      "layoutDurationMs": 1.302,
      "taskDurationMs": 99.401,
      "heapDeltaBytes": 5111232,
      "heapUsedBytes": 74677648,
      "domNodes": 151,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.339,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 422.5229999999556,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 17.276,
      "layouts": 2,
      "layoutDurationMs": 0.5400000000000001,
      "taskDurationMs": 82.90499999999999,
      "heapDeltaBytes": 4869336,
      "heapUsedBytes": 77074192,
      "domNodes": 121,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.552999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 51065 76439 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1173
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.7% 255
src/scripts/pnginfo.ts 21.4% 221

@datadog-official

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

🔧 Auto-fixes Applied

This PR has been automatically updated to fix linting and formatting issues.

⚠️ Important: Your local branch is now behind. Run git pull before making additional changes to avoid conflicts.

Changes made:

  • ESLint auto-fixes
  • Oxfmt formatting

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 4, 2026
@christian-byrne christian-byrne removed their assignment Oct 4, 2026
@codecov

codecov Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #20077   +/-   ##
=============================================
  Coverage              ?   84.25%           
=============================================
  Files                 ?     2131           
  Lines                 ?   128070           
  Branches              ?    32591           
=============================================
  Hits                  ?   107910           
  Misses                ?    19979           
  Partials              ?      181           
Flag Coverage Δ
e2e 66.85% <ø> (?)
unit 79.55% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/canvas/minimapDecorationRegistry.ts 95.65% <100.00%> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 92.31% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne assigned DrJKL and unassigned ryan-di Oct 4, 2026
@christian-byrne
christian-byrne requested a review from DrJKL October 4, 2026 07:32
@christian-byrne
christian-byrne merged commit 805f7a1 into cloud/1.54 Oct 4, 2026
95 checks passed
@christian-byrne
christian-byrne deleted the backport-20071-to-cloud-1.54 branch October 4, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants