Repository navigation
[backport core/1.55] feat: cancel cloud asset downloads (#19281) - #19858
Conversation
Justification: Alex reviewed exact head b3485a7 and explicitly recorded “ready to approve”; all required exact-head checks are terminal green, every substantive thread is resolved, and the seven-commit main delta has zero file overlap with this PR. Applying the documented selective stale-approval exception; post-merge peer review remains routed to Alex.
Adjudicates the ten Cursor review findings on #19739 against source. All ten are substantiated; nine are fixed here and one is answered on the thread. A pending cancellation had no exit other than a terminal WS message or a successful poll, and `pollSingleDownload` collapsed every `getTask` failure into "retry later" - including a 404, which proves the task row is gone. A purged task therefore re-polled every 10s for the life of the page and stayed `cancellation_pending`, which is not a finished status, so the dialog withheld its only Close control and the toast was pinned open until a reload. A 404 now settles the cancellation, and an unconfirmed one settles after a bounded number of reconciliation attempts. `cancelled` is still replaceable by an authoritative `completed`, so the PM-1302 recovery premise is unchanged. `getTask` narrowed the shared `/tasks` response's `result` to the download-file shape, so an export task carrying `export_name`/`assets_total` failed `safeParse` and returned `ok: false`, making export reconciliation unreachable. `result` goes back to the generated opaque record and is parsed per task type at the call site. Export polling also gains the identity guard its download counterpart has - without it a poll resolving after a dismissal re-inserted the export with `downloadTriggered: false` and downloaded the archive twice - and now reconciles a server-side `cancelled` export instead of polling it forever. The upload wizard stopped watching at `failed` and `cancelled`, both of which the download store deliberately leaves recoverable, so a recovered import read as a failure and skipped `refreshModelCaches()`. It now stops only on `completed`, the one status the store treats as immutable. Two smaller repairs: `cancelTask` no longer interpolates an unbounded response body into an error that reaches a toast and telemetry, and it reports 404 and 409 as distinct outcomes so a refusal reconciles the row's real status instead of being a silent no-op. Reconciling to `cancelled` routes through `handleAssetDownload` rather than mutating in place, which drops the stale error a premature message left attached. Not fixed: cancellation is still only permitted from `created`/`running`. Allowing it from `failed` needs a Cancel affordance on a failed row, which is a product decision rather than a mechanical fix, and is answered on the thread.
Widening `AssetExport.status` to include `cancelled` left the export dialog without a branch for it, so a cancelled export fell through to the final `v-else` and rendered "Pending", and a cancelled-only set produced an "All exports completed" footer. Both now mirror the download dialog's existing cancelled treatment. Found by reviewing the reconciliation fix's own blast radius rather than by a review comment; the new component test is red on the prior component.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2146 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c6098d01eeb0223090c698e2b2a12a97d1b55176
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T12:53:54.036Z",
"gitSha": "73361044856dee0b7ec14a27d31115a95fa68cc7",
"branch": "backport-19281-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.596000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.071000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.89899999999994,
"heapDeltaBytes": 12663612,
"heapUsedBytes": 81059316,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1996.2570000000142,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.617000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.277,
"heapDeltaBytes": -9195396,
"heapUsedBytes": 59624908,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.247,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.436000000031,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.318,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.226,
"heapDeltaBytes": -7450832,
"heapUsedBytes": 61410552,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 164.573,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.7529999999924,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.472999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 773.1170000000001,
"heapDeltaBytes": 5696480,
"heapUsedBytes": 74520412,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 157.893,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.2090000000262,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.417,
"layouts": 6,
"layoutDurationMs": 1.308,
"taskDurationMs": 362.54300000000006,
"heapDeltaBytes": 2952208,
"heapUsedBytes": 71728344,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.866999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.2819999999574,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.379,
"layouts": 6,
"layoutDurationMs": 1.001,
"taskDurationMs": 324.22200000000004,
"heapDeltaBytes": 2946920,
"heapUsedBytes": 71430756,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.866,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 664.1349999999875,
"styleRecalcs": 15,
"styleRecalcDurationMs": 8.850000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.539,
"heapDeltaBytes": 18114220,
"heapUsedBytes": 86605120,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.301,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 628.1950000000052,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.577,
"heapDeltaBytes": 18126272,
"heapUsedBytes": 86534908,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 166.332,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1207.8750000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 911.6740000000001,
"heapDeltaBytes": -18021412,
"heapUsedBytes": 72829308,
"domNodes": -293,
"jsHeapTotalBytes": 18219008,
"scriptDurationMs": 70.306,
"eventListeners": -217,
"totalBlockingTimeMs": 552,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1213.3150000000796,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 905.1340000000001,
"heapDeltaBytes": -18915492,
"heapUsedBytes": 72460792,
"domNodes": -294,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 76.62900000000002,
"eventListeners": -217,
"totalBlockingTimeMs": 553,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.0899999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.5590000000004,
"heapDeltaBytes": 14427960,
"heapUsedBytes": 89906152,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.846,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.1289999999763,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.4900000000003,
"heapDeltaBytes": 14767036,
"heapUsedBytes": 90778436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.682,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9952.780000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9053.717,
"heapDeltaBytes": -1505136,
"heapUsedBytes": 79710656,
"domNodes": -16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7580.355,
"eventListeners": 0,
"totalBlockingTimeMs": 1006,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9270.969000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8448.082999999999,
"heapDeltaBytes": 22420692,
"heapUsedBytes": 97041236,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 7303.406,
"eventListeners": 0,
"totalBlockingTimeMs": 918,
"frameDurationMs": 23.330000000000048,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10599.864999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9713.612000000001,
"heapDeltaBytes": 7536632,
"heapUsedBytes": 86172560,
"domNodes": -264,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 8142.455999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 1283,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9244.91999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8413.937,
"heapDeltaBytes": 4202952,
"heapUsedBytes": 85604476,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6977.868,
"eventListeners": 0,
"totalBlockingTimeMs": 725,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2027.5250000000256,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.030000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.363,
"heapDeltaBytes": -16533332,
"heapUsedBytes": 72449708,
"domNodes": -244,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 33.432,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2039.0790000000152,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.028999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.9300000000001,
"heapDeltaBytes": -16232396,
"heapUsedBytes": 73207280,
"domNodes": -239,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.911,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2279.0180000000078,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1467.898,
"heapDeltaBytes": 315064,
"heapUsedBytes": 64486560,
"domNodes": -248,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 884.967,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2147.89200000007,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.846,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1422.6809999999998,
"heapDeltaBytes": 1112884,
"heapUsedBytes": 65029000,
"domNodes": -243,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 839.9879999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3514.3360000000143,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.077999999999996,
"layouts": 60,
"layoutDurationMs": 13.608,
"taskDurationMs": 1520.3659999999998,
"heapDeltaBytes": -192744,
"heapUsedBytes": 65514816,
"domNodes": 28,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 808.4409999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3561.0000000000355,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.381,
"layouts": 60,
"layoutDurationMs": 12.839,
"taskDurationMs": 1612.8719999999998,
"heapDeltaBytes": 1786492,
"heapUsedBytes": 66656368,
"domNodes": -224,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 803.884,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3074.9360000000365,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.922,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1849.4859999999999,
"heapDeltaBytes": 7903488,
"heapUsedBytes": 73747600,
"domNodes": 0,
"jsHeapTotalBytes": 1241088,
"scriptDurationMs": 1006.203,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2993.9900000000534,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.7319999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1787.526,
"heapDeltaBytes": 5013208,
"heapUsedBytes": 72874004,
"domNodes": 4,
"jsHeapTotalBytes": 454656,
"scriptDurationMs": 981.823,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.599000000018,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.09499999999997,
"heapDeltaBytes": 9775388,
"heapUsedBytes": 74187616,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.589,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.5050000000574,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.7429999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.773,
"heapDeltaBytes": -17005024,
"heapUsedBytes": 73118152,
"domNodes": -244,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 40.63700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.8559999999829,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.42,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.72200000000004,
"heapDeltaBytes": 13802620,
"heapUsedBytes": 83534820,
"domNodes": 23,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.868,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.8230000000003,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.904,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.748,
"heapDeltaBytes": 13200528,
"heapUsedBytes": 83670460,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.731,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2024.2959999999925,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.594999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.539,
"heapDeltaBytes": 864092,
"heapUsedBytes": 71450224,
"domNodes": -273,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.608999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.9700000000612,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.562,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.094,
"heapDeltaBytes": -15131616,
"heapUsedBytes": 55494096,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.007,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1701.154000000031,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.296999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.897,
"heapDeltaBytes": 2536572,
"heapUsedBytes": 73171672,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.086,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.1909999999425,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.311,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 702.998,
"heapDeltaBytes": -4854320,
"heapUsedBytes": 65512320,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 101.82100000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.862999999943,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.807999999999993,
"layouts": 5,
"layoutDurationMs": 13.252,
"taskDurationMs": 874.198,
"heapDeltaBytes": 20329412,
"heapUsedBytes": 103947984,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.224,
"eventListeners": 2383,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8364.725999999962,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.824,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5596.279,
"heapDeltaBytes": -1179912,
"heapUsedBytes": 88111480,
"domNodes": -240,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2818.1070000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8281.395999999972,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.416000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5615.845,
"heapDeltaBytes": 3163916,
"heapUsedBytes": 92484052,
"domNodes": -239,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2807.744,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17417.98200000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16874.203999999998,
"heapDeltaBytes": -35824180,
"heapUsedBytes": 191935832,
"domNodes": -8061,
"jsHeapTotalBytes": -15929344,
"scriptDurationMs": 274.492,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17144.560999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16814.578,
"heapDeltaBytes": -22592280,
"heapUsedBytes": 191747068,
"domNodes": -8062,
"jsHeapTotalBytes": -11595776,
"scriptDurationMs": 276.716,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20461.944000000018,
"styleRecalcs": 163,
"styleRecalcDurationMs": 16.712000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20058.022999999997,
"heapDeltaBytes": -48484360,
"heapUsedBytes": 192219476,
"domNodes": -8061,
"jsHeapTotalBytes": -17833984,
"scriptDurationMs": 900.682,
"eventListeners": -14928,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20675.53799999996,
"styleRecalcs": 155,
"styleRecalcDurationMs": 17.677000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20479.823999999997,
"heapDeltaBytes": -48687840,
"heapUsedBytes": 191943624,
"domNodes": -8061,
"jsHeapTotalBytes": -19668992,
"scriptDurationMs": 909.689,
"eventListeners": -14928,
"totalBlockingTimeMs": 213,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6093.949000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.31100000000002,
"layouts": 20,
"layoutDurationMs": 24.049,
"taskDurationMs": 6006.455,
"heapDeltaBytes": -51369516,
"heapUsedBytes": 176208992,
"domNodes": -8061,
"jsHeapTotalBytes": 12906496,
"scriptDurationMs": 105.43799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 513,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6122.792000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.19100000000002,
"layouts": 20,
"layoutDurationMs": 23.909000000000013,
"taskDurationMs": 6047.868,
"heapDeltaBytes": -52028952,
"heapUsedBytes": 182967832,
"domNodes": -8062,
"jsHeapTotalBytes": 16654336,
"scriptDurationMs": 108.739,
"eventListeners": -14928,
"totalBlockingTimeMs": 406,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6434.322999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6167.28,
"heapDeltaBytes": 1300896,
"heapUsedBytes": 176790252,
"domNodes": 0,
"jsHeapTotalBytes": -29360128,
"scriptDurationMs": 107.19199999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8368.78200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8178.618,
"heapDeltaBytes": -12239028,
"heapUsedBytes": 172056788,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 145.93900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 129.0760000000546,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.165,
"layouts": 4,
"layoutDurationMs": 2.072,
"taskDurationMs": 95.553,
"heapDeltaBytes": 3243676,
"heapUsedBytes": 69897164,
"domNodes": 137,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.939,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 115.8260000000837,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.256,
"layouts": 4,
"layoutDurationMs": 1.604,
"taskDurationMs": 81.199,
"heapDeltaBytes": 3003284,
"heapUsedBytes": 65163204,
"domNodes": 128,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.752999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.55 #19858 +/- ##
=============================================
+ Coverage 84.72% 84.77% +0.04%
=============================================
Files 2323 2323
Lines 132467 132553 +86
Branches 33527 35447 +1920
=============================================
+ Hits 112231 112368 +137
+ Misses 19876 19825 -51
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 5 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
This comment has been minimized.
This comment has been minimized.
… that never held (#19874) (#19900) Test-only port of #19874 to `core/1.55`. **Unblocks the whole `core/1.55` line** — including the release bump — which is currently red on the required `test` context. ## Why `core/1.55` is red #19860 ("preserve seal ordering under reentry") changed `opSender.ts`. Review on `main` then corrected two stale assertions in #19874 (test-only, merged 2026-10-02T06:05:26Z). The `core/1.55` carrier of the **production** half, #19861 → `62f0cc1d9e`, merged at 2026-10-02T03:21:21Z — about 2h45m *before* the companion test correction existed — and it merged with `test=cancelled` / `e2e-status=failure`. So the line took the implementation without its test fix and has been red since: ``` FAIL src/workbench/extensions/agent/crdt/opSender.test.ts > createOpSender > does not rechunk a prefix after serialization aborts and throws FAIL src/workbench/extensions/agent/crdt/opSender.test.ts > createOpSender > resumes a pump requested during workflow-change sealing ``` Ruleset **"Core release branches"** (id 7297873) makes `test` required on every `core/**` ref, so **every** PR targeting `core/1.55` is blocked until this lands — #19858 and #19658 included. `cloud/1.55` has the same breakage from its own carrier #19862; its repair is #19890. **This is the missing `core/1.55` half of that pair.** >⚠️ Related trap, not fixed here: `strict_required_status_checks_policy` is `false` on that ruleset, and #19658 carries a **stale green** `test` computed at `e9e5aadd0b`, which predates `62f0cc1d9e` (`compare/62f0cc1d...e9e5aad` → `diverged`). Do not read that green as branch health. ## What this changes **One file, test-only. Zero production change.** `opSender.ts` is byte-identical to `core/1.55` at `b2743f2f0ae4895f50f8e9becf378507b9720ea0`: ``` $ git diff origin/core/1.55 --name-only src/workbench/extensions/agent/crdt/opSender.test.ts ``` And after this commit `opSender.test.ts` is **byte-identical to `main`** — this is a faithful port, not a variant: ``` $ git diff origin/main --stat -- src/workbench/extensions/agent/crdt/opSender.test.ts (empty) ``` The only production delta between `core/1.55` and `main` in `opSender.ts` is two added `surface: 'agent'` telemetry fields, which do not touch the seal/reentry behaviour these tests exercise — so #19874's corrections apply here unchanged. The cherry-pick applied cleanly with no conflicts. ## These are not loosened-to-green assertions Verified independently **on this branch**, not taken on trust from #19874. Each mutation of `core/1.55`'s own `opSender.ts` kills exactly the test that guards it: | mutation of `opSender.ts` | result | |---|---| | neutralize the `interruptedBeforeProbe` abort short-circuit (`opSender.ts:531`) | `does not rechunk…` **fails** (1 failed \| 86 passed) | | neutralize the `sealing === 0 && pumpRequested` deferral resume (`opSender.ts:614`) | `resumes a pump…` **fails** (1 failed \| 86 passed) | `expect(firstSerializations).toBe(1)` is the only guard on the abort short-circuit branch, so simply deleting the test — the lazy route to green — would have left that branch uncovered. The ported assertions are also *stronger* than the ones they replace: test 1 moves from shape-only checks to an exact settlement list, and test 2 replaces an `onBatchSettled: vi.fn()` that was never asserted on with a real settlement sink plus a wire-addressing assertion (`workflowId === 'wf-new'`). ## Verification on this branch Node 26 (the repo's required version), `NODE_OPTIONS=--no-experimental-webstorage`: | check | before (at `b2743f2f0a`) | after | |---|---|---| | `vitest run opSender.test.ts` | **2 failed** \| 85 passed — `expected 1 to be 2`, `expected 3 to be 1`, identical to CI | **87 passed (87)** | | `vitest run src/workbench/extensions/agent/crdt/` | — | **56 files passed, 776 passed + 2 expected-fail (778)** | | `vitest run --shard="5/8"` | — | **210 files passed, 3025 passed (3025)**, exit 0 | | `typecheck:app` (`vue-tsc --noEmit`) | — | exit 0 | | oxfmt, oxlint `--type-aware`, oxlint audit config, eslint | — | clean (also via pre-commit hooks) | | `.github/scripts/check-ai-co-authors.sh origin/core/1.55 HEAD` | — | `No AI agent Co-authored-by trailers found.` | The two expected-fails in the `crdt/` run are pre-existing `it.fails` cases on this branch, untouched here. ## Provenance Cherry-picked from `b365e2a8478c5d9cc790d620d88a50a2277ae456` (#19874, authored by @huang47 via the Glary-Bot Agent); the `(cherry picked from commit …)` line is preserved in the commit message. The source commit's `Co-authored-by: Glary-Bot` trailer was removed per this repository's AI co-author policy (`.github/scripts/check-ai-co-authors.sh`) — the carrier commit is authored under the same convention as every other `core/1.55` carrier on this line. Landing under Christian's 1.55 release-backport authority. No production behaviour is widened, no test is weakened, and no check was bypassed.
ryan-di
left a comment
There was a problem hiding this comment.
CI remains blocked at head 9dfc992beefefe8e0bbe05f0ee72f3d1c40f45c6. The unit-test job ran 23,966 tests (23,944 passed) and failed two assertions in src/workbench/extensions/agent/crdt/opSender.test.ts:
does not rechunk a prefix after serialization aborts and throws, line 1370: expectedfirstSerializationsto be2, received1.resumes a pump requested during workflow-change sealing, line 1458: expected the first sent node ID to be1, received3.
This is a real test assertion failure, so the infrastructure-only exception does not apply. The job checked out synthetic merge 6d87ebe1c6286d1da3a2b4111991b65c4b1b3f41 of this head into b2743f2f0ae4895f50f8e9becf378507b9720ea0. The tested opSender.test.ts is byte-identical to that tested base's file, establishing that the failing test source is inherited; this does not prove the failure reproduced on the base alone or establish cancellation as its cause.
The currently observed core/1.55 tip is c7892d7749302650f9fabaf45b3572b2f3936abc, while PR metadata reports base 00be58054da44b193f1fa203423e132aa6d59a2d. Please resolve or document the disposition of both assertions and establish passing CI against the current target. Cancellation implementation and source/backport delta review remain pending while this genuine CI gate is unresolved.
|
Updated this backport to the current |
There was a problem hiding this comment.
Verdict: Request changes. The #19281 cherry-pick is faithful, but about 1,000 more lines of behavior changes that are on neither main nor cloud/1.55 ride along with it.
I compared against #19281's merge commit c1d9a51466a16987e802ebb3682f19211ed744b5. Commit cf3cb56 matches it hunk for hunk in all 17 source files, tests included. The only adaptation I accept is d0ec708: it moves surface: 'assets' into tags in ModelImportProgressDialog.vue and its test, because ReportErrorOptions on core/1.55 has no surface field.
The rest of the branch goes beyond the source:
- 9dba073 (bounded cancellation, the opaque task
result, the export identity guard, the upload-wizard watcher) and 79100b5 (the cancelled export row) came in through thecloud/1.55backport #19739. They are not onmain. - 270494d, 7c733a5 and 9dfc992 came after #19739. They are on neither
mainnorcloud/1.55, so this PR also differs fromcloud/1.55inassetDownloadStore.ts,assetExportStore.ts,useUploadModelWizard.ts,ModelImportProgressDialog.vueand their tests.
Together that is roughly +1,080/-145 across 14 files. It includes the new assetExportStore.test.ts and AssetExportProgressDialog.test.ts, and it drops the source's hasPendingCancellation guard on the Close button. Most of these commits answer automated review findings on the backport PRs. Many of them look like real fixes to #19281 itself, for example the getTask result schema that made export reconciliation unreachable, and that is why they belong on main first. As it stands, main keeps those bugs and the three branches each have different cancellation behavior.
I would like this PR to carry #19281 plus the telemetry adaptation, and the follow-up fixes to land on main as their own PR and be backported from there to both release branches. If the release owner decides core/1.55 must match cloud/1.55 now, the branch should at least stop at the #19739 state and describe that as the source. I have commented inline where each extra change starts.
CI at d871d9b is green (lint-and-format, test, e2e-status, typecheck). My concern is scope, not test results.
There was a problem hiding this comment.
Verdict: Approve. At d16c205 this is a faithful backport of #19281. The one adaptation is the telemetry option shape that core/1.55 requires.
I compared against #19281's merge commit c1d9a51466a16987e802ebb3682f19211ed744b5. After c81d10d, the branch's net diff against core/1.55 covers the same 17 files as the source, with identical hunks in 15 of them. The follow-up series I objected to last round is gone: the bounded reconciliation, the export store changes, the opaque task result, the upload-wizard watcher, the cancelled export row and the Close-button change. The source's hasPendingCancellation guard on Close is back.
Adaptation: ModelImportProgressDialog.vue and its test pass tags: { surface: 'assets' } instead of surface: 'assets'. ReportErrorOptions on core/1.55 has no surface field, so the source's call would not typecheck here. This change keeps the same tag.
Checks: the five touched Vitest files pass locally at this head (62 passed, 1 expected failure). vue-tsc --noEmit and pnpm typecheck:browser pass. Hosted CI at d16c205 is fully green, including lint-and-format, test, e2e-status and typecheck.
## Summary - bound cancelled-task reconciliation and validate task statuses/results before restoring state - keep download/export cancellation rendering and close behavior consistent while polling is in flight - stop upload-wizard watchers when their owning scope is disposed - preserve export download URL behavior while adding regression coverage for malformed, mixed-shape, cancelled, and stale task responses This lands the hardening identified during the final review of #19858 (the `core/1.55` backport of #19281) on `main` first so release branches can consume it through normal backports. ## Validation - `pnpm vitest run src/stores/assetDownloadStore.test.ts src/stores/assetExportStore.test.ts src/platform/tasks/services/taskService.test.ts src/platform/assets/components/ModelImportProgressDialog.test.ts src/platform/assets/components/AssetExportProgressDialog.test.ts src/platform/assets/composables/useUploadModelWizard.test.ts` (85 passed, 1 expected failure) - `pnpm typecheck:app` - `pnpm typecheck:browser` - targeted `oxfmt --check` - pre-push `knip` and changed-file `fallow audit`
…0031) (#20044) Backports #20031 to `core/1.55`. This carries the canonical cancellation hardening that followed #19858: bounded and serialized task reconciliation, terminal-state preservation, dismissible unconfirmed cancellations, upload-watcher isolation, and regression coverage. Validation: - focused Vitest suite: 94 passed, 1 expected failure - `pnpm typecheck:app`
Summary
Backports #19281 to
core/1.55, including the release-line compatibility fixes already validated oncloud/1.55.Validation
pnpm typecheck:apppnpm typecheck:browserBackport of #19281.