Repository navigation
[backport core/1.55] fix: harden task cancellation reconciliation (#20031) - #20044
Conversation
## Summary - bound cancelled-task reconciliation and validate task statuses/results before restoring state - keep download/export cancellation rendering and close behavior consistent while polling is in flight - stop upload-wizard watchers when their owning scope is disposed - preserve export download URL behavior while adding regression coverage for malformed, mixed-shape, cancelled, and stale task responses This lands the hardening identified during the final review of #19858 (the `core/1.55` backport of #19281) on `main` first so release branches can consume it through normal backports. ## Validation - `pnpm vitest run src/stores/assetDownloadStore.test.ts src/stores/assetExportStore.test.ts src/platform/tasks/services/taskService.test.ts src/platform/assets/components/ModelImportProgressDialog.test.ts src/platform/assets/components/AssetExportProgressDialog.test.ts src/platform/assets/composables/useUploadModelWizard.test.ts` (85 passed, 1 expected failure) - `pnpm typecheck:app` - `pnpm typecheck:browser` - targeted `oxfmt --check` - pre-push `knip` and changed-file `fallow audit`
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2148 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 69a9b933f36446cebcf53c0278144ac4d58fedb4
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T23:19:24.552Z",
"gitSha": "a36cce1adf17dfaee572ebc591f28f89f3d37ca5",
"branch": "backport-20031-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.2119999999386,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.974,
"heapDeltaBytes": 6338680,
"heapUsedBytes": 74911444,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.133000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.1120000000492,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.839999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.386,
"heapDeltaBytes": -9407604,
"heapUsedBytes": 59484040,
"domNodes": -257,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.5249999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.7099999999537,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.304,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.02,
"heapDeltaBytes": 8206364,
"heapUsedBytes": 77054936,
"domNodes": -255,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.661,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.7969999999941,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.3729999999999,
"heapDeltaBytes": 4555680,
"heapUsedBytes": 73404068,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 113.96299999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.6009999999915,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.297,
"layouts": 6,
"layoutDurationMs": 1.0679999999999998,
"taskDurationMs": 273.962,
"heapDeltaBytes": 2165964,
"heapUsedBytes": 64812196,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.477,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.3170000000737,
"styleRecalcs": 28,
"styleRecalcDurationMs": 11.726,
"layouts": 6,
"layoutDurationMs": 0.957,
"taskDurationMs": 272.584,
"heapDeltaBytes": 3295980,
"heapUsedBytes": 71611804,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.547999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 524.8829999999316,
"styleRecalcs": 16,
"styleRecalcDurationMs": 6.553,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.55199999999996,
"heapDeltaBytes": 18286884,
"heapUsedBytes": 80831584,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 124.50900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 533.8110000000142,
"styleRecalcs": 15,
"styleRecalcDurationMs": 6.670000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.632,
"heapDeltaBytes": 18505604,
"heapUsedBytes": 81136040,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 126.31200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1031.6249999999627,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.448,
"heapDeltaBytes": 38448500,
"heapUsedBytes": 106759784,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 45.833,
"eventListeners": 0,
"totalBlockingTimeMs": 420,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1050.2360000000408,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 685.936,
"heapDeltaBytes": 35681732,
"heapUsedBytes": 103121720,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 47.523999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 442,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 747.8459999999814,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.54899999999975,
"heapDeltaBytes": 14181924,
"heapUsedBytes": 91121320,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.32700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 131,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.8360000000202,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.8019999999998,
"heapDeltaBytes": 14039844,
"heapUsedBytes": 89921492,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 104.88300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 126,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7601.053999999976,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.687000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6732.477,
"heapDeltaBytes": -10013500,
"heapUsedBytes": 68875336,
"domNodes": -270,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 5401.231,
"eventListeners": -174,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6518.056000000001,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.9240000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5724.075,
"heapDeltaBytes": 4225020,
"heapUsedBytes": 83369300,
"domNodes": -258,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 4552.722,
"eventListeners": -174,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6440.446999999949,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.0300000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5660.634,
"heapDeltaBytes": -8722868,
"heapUsedBytes": 72369940,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 4654.14,
"eventListeners": 0,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6688.193000000069,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06300000000000056,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5962.909000000001,
"heapDeltaBytes": 25499448,
"heapUsedBytes": 100655736,
"domNodes": 2,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 4796.411000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2041.2280000000464,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.370000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.46,
"heapDeltaBytes": 3511272,
"heapUsedBytes": 86088140,
"domNodes": -257,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 23.546999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 1995.7460000000538,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.693,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.8139999999999,
"heapDeltaBytes": 9504436,
"heapUsedBytes": 73330596,
"domNodes": -241,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.431999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2141.0560000000487,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.059000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1202.4750000000001,
"heapDeltaBytes": 4932216,
"heapUsedBytes": 88352608,
"domNodes": -247,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 599.969,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.5510000000586,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.122,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1218.1519999999998,
"heapDeltaBytes": -23830088,
"heapUsedBytes": 65683072,
"domNodes": -239,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 619.3340000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3191.3399999999683,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.472999999999999,
"layouts": 60,
"layoutDurationMs": 9.66,
"taskDurationMs": 1316.816,
"heapDeltaBytes": -15477804,
"heapUsedBytes": 69815972,
"domNodes": -235,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 570.546,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3157.4319999999716,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.06,
"layouts": 60,
"layoutDurationMs": 10.129,
"taskDurationMs": 1348.24,
"heapDeltaBytes": -23820392,
"heapUsedBytes": 67949388,
"domNodes": -239,
"jsHeapTotalBytes": 6057984,
"scriptDurationMs": 579.8169999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2216.521000000057,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.874,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1382.8069999999998,
"heapDeltaBytes": 12527320,
"heapUsedBytes": 98969684,
"domNodes": 16,
"jsHeapTotalBytes": 6483968,
"scriptDurationMs": 685.5609999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2253.235000000018,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.881,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1380.332,
"heapDeltaBytes": -18926348,
"heapUsedBytes": 74802480,
"domNodes": 16,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 709.4090000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 10,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2035.0389999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.217000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.2059999999999,
"heapDeltaBytes": -23876380,
"heapUsedBytes": 67321436,
"domNodes": -254,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 21.261000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2016.495999999961,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.529000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.3130000000001,
"heapDeltaBytes": -24458440,
"heapUsedBytes": 67189404,
"domNodes": -253,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 23.057000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.4560000001093,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.465,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.66099999999994,
"heapDeltaBytes": 13234300,
"heapUsedBytes": 83998348,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 105.912,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.0989999999638,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.55,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.538,
"heapDeltaBytes": 13231284,
"heapUsedBytes": 84026292,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 112.44800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.417999999906,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.8839999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.9149999999999,
"heapDeltaBytes": 11533988,
"heapUsedBytes": 81964252,
"domNodes": -274,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 6.581,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2009.0880000000197,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.289000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.94399999999996,
"heapDeltaBytes": 9106944,
"heapUsedBytes": 79647708,
"domNodes": -273,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.062,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.0939999999791,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.749000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.629,
"heapDeltaBytes": 653840,
"heapUsedBytes": 71156996,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 69.324,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.5790000000043,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.07,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.479,
"heapDeltaBytes": -7512816,
"heapUsedBytes": 56609796,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 68.55699999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 899.5879999999943,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.342000000000002,
"layouts": 5,
"layoutDurationMs": 8.885999999999997,
"taskDurationMs": 722.0519999999999,
"heapDeltaBytes": -6284680,
"heapUsedBytes": 81814952,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 19.885,
"eventListeners": 2383,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8123.514999999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.62,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4161.059,
"heapDeltaBytes": -910268,
"heapUsedBytes": 87761436,
"domNodes": -236,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 1985.737,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.567000000006,
"styleRecalcs": 250,
"styleRecalcDurationMs": 23.095000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4260.911,
"heapDeltaBytes": -2795516,
"heapUsedBytes": 80099024,
"domNodes": -257,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 2007.1270000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12118.063000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10919.293,
"heapDeltaBytes": -43696660,
"heapUsedBytes": 183988596,
"domNodes": -8062,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 119.359,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12333.82400000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11152.203,
"heapDeltaBytes": -35365084,
"heapUsedBytes": 198530304,
"domNodes": -8062,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 143.59100000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 13932.856000000014,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.801000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13325.847,
"heapDeltaBytes": -19766988,
"heapUsedBytes": 192520020,
"domNodes": -8062,
"jsHeapTotalBytes": -11862016,
"scriptDurationMs": 581.631,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14159.47200000005,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.44600000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13478.003999999999,
"heapDeltaBytes": -45195148,
"heapUsedBytes": 189834216,
"domNodes": -8062,
"jsHeapTotalBytes": -19329024,
"scriptDurationMs": 640.919,
"eventListeners": -14928,
"totalBlockingTimeMs": 46,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4098.886999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.222,
"layouts": 20,
"layoutDurationMs": 17.410000000000007,
"taskDurationMs": 3944.603,
"heapDeltaBytes": -51252556,
"heapUsedBytes": 182852356,
"domNodes": -8066,
"jsHeapTotalBytes": 17027072,
"scriptDurationMs": 52.830000000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 79,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4272.672000000057,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.43700000000002,
"layouts": 20,
"layoutDurationMs": 18.595,
"taskDurationMs": 4099.791000000001,
"heapDeltaBytes": -58408372,
"heapUsedBytes": 175587576,
"domNodes": -8062,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 62.150999999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 95,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6140.440999999896,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5517.5030000000015,
"heapDeltaBytes": 6974696,
"heapUsedBytes": 183947072,
"domNodes": 0,
"jsHeapTotalBytes": -20709376,
"scriptDurationMs": 67.09100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6186.373999999887,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5642.688999999999,
"heapDeltaBytes": -10056412,
"heapUsedBytes": 190837364,
"domNodes": 0,
"jsHeapTotalBytes": -31719424,
"scriptDurationMs": 88.756,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 442.24899999994705,
"styleRecalcs": 18,
"styleRecalcDurationMs": 15.317,
"layouts": 3,
"layoutDurationMs": 1.394,
"taskDurationMs": 99.488,
"heapDeltaBytes": 5156920,
"heapUsedBytes": 71503256,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.421000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 439.19899999991685,
"styleRecalcs": 20,
"styleRecalcDurationMs": 18.253,
"layouts": 4,
"layoutDurationMs": 1.6090000000000002,
"taskDurationMs": 98.19900000000001,
"heapDeltaBytes": 4999728,
"heapUsedBytes": 71313468,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.349,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 3 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.55 #20044 +/- ##
=============================================
+ Coverage 84.79% 84.87% +0.08%
=============================================
Files 2327 2327
Lines 132670 132798 +128
Branches 33580 33619 +39
=============================================
+ Hits 112496 112715 +219
+ Misses 19814 19721 -93
- Partials 360 362 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #20031, with identical hunks in all 14 files.
I compared against #20031's merge commit d23d7802f5680f647a10d3620b61f63a7800ab01. Each of the 14 files carries the same added and removed lines as the source. That includes the source's tests in assetDownloadStore.test.ts, assetExportStore.test.ts, taskService.test.ts, ModelImportProgressDialog.test.ts, AssetExportProgressDialog.test.ts, useUploadModelWizard.test.ts and modelImportProgressDialog.spec.ts. No adaptation was needed. #19858 had already put #19281 on core/1.55 in main's form, and the tags: { surface } adaptation from that backport is outside #20031's hunks.
Checks: the six touched Vitest files pass locally at this head (94 passed, 1 expected failure). vue-tsc --noEmit and pnpm typecheck:browser pass. Hosted CI at 2fd961f is fully green, including lint-and-format, test and e2e-status.
## Summary Follow-up to #20031 and its release backports. This closes the post-merge review gaps by: - tombstoning dismissed pending downloads so late WebSocket frames cannot reopen the toast, while still refreshing model caches after a hidden completion - settling malformed authoritative completions instead of polling forever - confirming DELETE 404 outcomes without falsely presenting a still-running task as cancelled - bounding task-not-found reconciliation and stopping unconfirmed cancellation polling - preserving late export names, validating export URL schemes, and retrying transient export 404s - preventing async upload watchers from outliving reset/disposal ## Validation - Targeted Vitest: 74 passed, 1 expected failure - App typecheck - Targeted lint: 0 errors - Diff whitespace check Closes the actionable review findings raised on #20044, #20047, #20048, and #20049.
Backports #20031 to
core/1.55.This carries the canonical cancellation hardening that followed #19858: bounded and serialized task reconciliation, terminal-state preservation, dismissible unconfirmed cancellations, upload-watcher isolation, and regression coverage.
Validation:
pnpm typecheck:app