Repository navigation
[backport core/1.54] fix(agent): reconcile a hydrated streaming turn from REST after a refresh - #19848
Conversation
…resh (#18154) - Adds a cloud Playwright regression proving a turn that finishes only in REST history unlocks after a browser refresh. - Preserves locally streamed reply parts when a terminal history row is temporarily empty instead of replacing the visible reply with nothing. - Keeps recovery-map cleanup ownership-safe so an older job cannot evict a successor controller. The broader hydrated-turn recovery now already exists on `main` through [#18152](#18152) (socket-drop recovery) and [#19053](#19053) (panel-remount restoration). This PR was rebuilt on current `main` to retain only the still-additive hardening and black-box refresh coverage. - `useAgentSession.test.ts`: 201 passed, including the new empty-terminal-row regression. - Application and browser TypeScript checks passed. - Changed-file ESLint and Oxlint passed. - The Playwright case is collected as a cloud test. Its local run reached application startup but could not complete with the ad-hoc frontend-only server because the standard ComfyUI devtools backend was absent; hosted browser CI supplies that harness. Fixes the refresh half of [PM-1199](https://linear.app/comfyorg/issue/PM-1199/fix-agent-stream-drops-mid-turn-with-no-refresh-leaving-no-working) (an in-flight agent turn could remain locked after refresh). (cherry picked from commit ea63d4a)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1983 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
|
@coderabbitai review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 1 |
Panel: 8/8 reviewers contributed findings.
(cherry picked from commit 76233a6)
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Addresses review feedback: #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) (cherry picked from commit 9303bd4)
Summary
Backports #18154 so a refreshed or remounted Agent session immediately reconciles a persisted streaming turn instead of waiting for a socket transition. It also preserves locally streamed parts when the terminal persisted row is empty and covers the refresh journey in Playwright.
The automated backport conflicted only with a test file absent from this release branch; that unrelated file remains absent.
Related: PM-1776, PM-1682, PM-1199.
Validation