Repository navigation
[backport core/1.54] feat(telemetry): send client_message_id on the turn POST so the activation funnel joins (#18970) - #19994
Conversation
…ation funnel joins (Comfy-Org#18970) `app:agent_message_sent` already carries a per-send `client_message_id`, but it never left the browser. The doc comment said so outright: > Minted client-side … **The backend does not receive it yet** — the turn POST contract carries no client id — so it dedups within the frontend stream rather than joining to the backend turn; `thread_id` is the join today. That is the reason the activation funnel's **message → turn** step is countable but not attributable. 606 frontend sends against 470 backend turn-starts on 2026-09-25 is a real gap as a count, but no individual message can be tied to the turn it started, so the gap cannot be explained and send latency has no instrument at all. Send the id on the turn POST. The server echoes it onto its own `agent_turn_started` event (Comfy-Org/cloud#10781), which then carries both that id and its `turn_id` — so the two event streams join at the step the funnel actually loses people at. **No new id is minted.** This is the value already reported on the analytics event, passed through to the request body. `AgentPanelRoot` hands the same `meta.clientMessageId` to both sinks. - **`thread_id`** is on the event already, but it is `null` for the first message in a thread — exactly the send that matters most to activation, and ~38% of sends on the current build. - **`turn_id`** cannot be used: the server mints it after the POST arrives, so it can never appear on a send-site event. The analytics event and the request body must carry the **same** value. If they ever diverge the join silently returns zero rows and nothing else fails — no error, no failed send, just an empty funnel. So there is a test that asserts equality across the two sinks in one send, which neither side's own test would catch. - `AgentPostMessageRequest` is widened locally at its one construction site, because the generated type is published from the cloud repo's `openapi.yaml`. One line to delete once the published type carries the field. - `postMessage`'s optional-field copying becomes a single `withoutUndefined()` build rather than a tenth sequential `if (x !== undefined)`. Same wire output — keys whose value is `undefined` are omitted, and `false`/`0` survive, so `current_tab_unbound: false` still sends. This keeps the added field from pushing the function past the repo's complexity gate, and two existing tests pin the omit-absent-optionals behaviour. - The stale doc comment on `AgentMessageSentMetadata.client_message_id` is corrected, since it asserted the opposite of what now happens. ``` pnpm typecheck # clean npx vitest run src/workbench/extensions/agent/ src/platform/telemetry/ pnpm knip && pnpm fallow:audit # clean, no new findings ``` New coverage: `client_message_id` reaches the wire; it is omitted when the caller has none; and the posted value equals the reported one. Additive and independently shippable in either order. An older server ignores the field (ingest proxies the body verbatim; Echo's `Bind` drops unknown keys), and an older client simply sends nothing — which reads as *unknown* for that turn, never as a failed send.
|
@christian-byrne is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1981 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T11:25:29.511Z",
"gitSha": "a8e754f0cf29863014b2bde35de1d33afe5a1058",
"branch": "backport-18970-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2080.929000000026,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.656000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.38000000000005,
"heapDeltaBytes": 9445924,
"heapUsedBytes": 79627056,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.921000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2014.9750000000495,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.883999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.67900000000003,
"heapDeltaBytes": -10044548,
"heapUsedBytes": 60411736,
"domNodes": -281,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.309000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.185000000024,
"styleRecalcs": 75,
"styleRecalcDurationMs": 21.855,
"layouts": 14,
"layoutDurationMs": 3.4490000000000007,
"taskDurationMs": 693.634,
"heapDeltaBytes": -2386088,
"heapUsedBytes": 68055244,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 119.489,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1759.433999999942,
"styleRecalcs": 74,
"styleRecalcDurationMs": 22.740999999999996,
"layouts": 14,
"layoutDurationMs": 3.3859999999999997,
"taskDurationMs": 678.892,
"heapDeltaBytes": 1418268,
"heapUsedBytes": 71947972,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 113.93599999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.3649999999848,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.187000000000001,
"layouts": 6,
"layoutDurationMs": 0.8599999999999999,
"taskDurationMs": 282.14799999999997,
"heapDeltaBytes": 4346168,
"heapUsedBytes": 74165392,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.871999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1656.4270000000079,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.741,
"layouts": 6,
"layoutDurationMs": 0.86,
"taskDurationMs": 282.565,
"heapDeltaBytes": 4314004,
"heapUsedBytes": 74862340,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.858999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 542.6689999999894,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.213,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.823,
"heapDeltaBytes": -7932936,
"heapUsedBytes": 62952424,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 127.173,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 527.667000000065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.478999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.38599999999997,
"heapDeltaBytes": -7856720,
"heapUsedBytes": 63498660,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 125.84400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2027.1900000000187,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.765999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.538,
"heapDeltaBytes": -16362616,
"heapUsedBytes": 87572416,
"domNodes": -266,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 30.887999999999998,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.1399999999176,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.0070000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.4630000000001,
"heapDeltaBytes": 10291880,
"heapUsedBytes": 86781248,
"domNodes": -270,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 30.862000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2118.2469999999967,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1240.164,
"heapDeltaBytes": 22286124,
"heapUsedBytes": 88899312,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 609.119,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2165.0319999999965,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.347999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1376.4820000000002,
"heapDeltaBytes": -9660276,
"heapUsedBytes": 67673756,
"domNodes": -284,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 672.633,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3182.6619999999934,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.254999999999999,
"layouts": 60,
"layoutDurationMs": 11.666,
"taskDurationMs": 1418.724,
"heapDeltaBytes": -4347252,
"heapUsedBytes": 74703552,
"domNodes": -290,
"jsHeapTotalBytes": 2781184,
"scriptDurationMs": 617.2030000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3181.2320000000227,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.383,
"layouts": 60,
"layoutDurationMs": 11.092999999999998,
"taskDurationMs": 1377.045,
"heapDeltaBytes": 8511684,
"heapUsedBytes": 76312000,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 633.0279999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2259.448999999961,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1541.6360000000002,
"heapDeltaBytes": -11515200,
"heapUsedBytes": 73518120,
"domNodes": 10,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 757.3129999999999,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2224.48200000008,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.083000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1530.661,
"heapDeltaBytes": 17599196,
"heapUsedBytes": 86077664,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 759.089,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2003.6360000000286,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.397,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.863,
"heapDeltaBytes": 21799392,
"heapUsedBytes": 88011348,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.823,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.9749999999694,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.328000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.6549999999999,
"heapDeltaBytes": 9611536,
"heapUsedBytes": 87833620,
"domNodes": -272,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 27.709999999999997,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 512.6510000000053,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.726999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.262,
"heapDeltaBytes": 14730828,
"heapUsedBytes": 87981764,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 112.838,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.4010000000826,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.623,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.64899999999994,
"heapDeltaBytes": 14296380,
"heapUsedBytes": 86989872,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 112.81200000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.989999999993,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.952999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.92900000000003,
"heapDeltaBytes": -5603896,
"heapUsedBytes": 67836360,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.076000000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1989.4469999999274,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.695,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.852,
"heapDeltaBytes": 1382288,
"heapUsedBytes": 67394416,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.497999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.3500000000372,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.755999999999997,
"layouts": 18,
"layoutDurationMs": 3.7489999999999997,
"taskDurationMs": 637.208,
"heapDeltaBytes": -7012404,
"heapUsedBytes": 66582976,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 80.599,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.7400000000953,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.097,
"layouts": 18,
"layoutDurationMs": 3.6899999999999995,
"taskDurationMs": 643.363,
"heapDeltaBytes": -2528372,
"heapUsedBytes": 70043288,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 81.259,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 917.2370000000001,
"styleRecalcs": 21,
"styleRecalcDurationMs": 25.944999999999997,
"layouts": 17,
"layoutDurationMs": 12.104999999999999,
"taskDurationMs": 734.094,
"heapDeltaBytes": 22105180,
"heapUsedBytes": 106183904,
"domNodes": 13831,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.686999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 98,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8206.34700000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.47800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4583.814,
"heapDeltaBytes": -17812284,
"heapUsedBytes": 85629180,
"domNodes": -267,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 2105.5899999999997,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8240.611999999943,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.234,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4674.267000000001,
"heapDeltaBytes": 9862312,
"heapUsedBytes": 86055296,
"domNodes": -240,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2227.303,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14542.253000000073,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14006.736999999997,
"heapDeltaBytes": -41914076,
"heapUsedBytes": 177289736,
"domNodes": -8068,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 241.686,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14718.89699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14196.584,
"heapDeltaBytes": -40320872,
"heapUsedBytes": 179712292,
"domNodes": -8068,
"jsHeapTotalBytes": -13688832,
"scriptDurationMs": 214.638,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17166.018000000007,
"styleRecalcs": 138,
"styleRecalcDurationMs": 14.856000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16890.256,
"heapDeltaBytes": -50779512,
"heapUsedBytes": 171815212,
"domNodes": -8068,
"jsHeapTotalBytes": -11849728,
"scriptDurationMs": 729.4280000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17239.245000000097,
"styleRecalcs": 144,
"styleRecalcDurationMs": 14.709,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16928.472999999998,
"heapDeltaBytes": -54068864,
"heapUsedBytes": 179109952,
"domNodes": -8068,
"jsHeapTotalBytes": -21409792,
"scriptDurationMs": 809.644,
"eventListeners": -14931,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5228.093999999942,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.042000000000016,
"layouts": 20,
"layoutDurationMs": 21.733000000000004,
"taskDurationMs": 5148.256000000001,
"heapDeltaBytes": -34983228,
"heapUsedBytes": 182548756,
"domNodes": -8068,
"jsHeapTotalBytes": 12324864,
"scriptDurationMs": 86.858,
"eventListeners": -14933,
"totalBlockingTimeMs": 183,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5223.887000000104,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.644,
"layouts": 20,
"layoutDurationMs": 22.30299999999999,
"taskDurationMs": 5170.093,
"heapDeltaBytes": -35778424,
"heapUsedBytes": 183468900,
"domNodes": -8068,
"jsHeapTotalBytes": 18391040,
"scriptDurationMs": 89.87799999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 272,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7310.000999999943,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7024.716000000001,
"heapDeltaBytes": 16326260,
"heapUsedBytes": 181851080,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 101.99800000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7294.500999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7044.368999999998,
"heapDeltaBytes": 8902292,
"heapUsedBytes": 188072268,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 107.10599999999998,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 80.83199999998669,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.641000000000002,
"layouts": 1,
"layoutDurationMs": 0.623,
"taskDurationMs": 52.98499999999999,
"heapDeltaBytes": 3081996,
"heapUsedBytes": 72217852,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.675000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 448.24500000004264,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.448999999999998,
"layouts": 3,
"layoutDurationMs": 1.167,
"taskDurationMs": 88.617,
"heapDeltaBytes": 4881824,
"heapUsedBytes": 74297240,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.999999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19994 +/- ##
============================================
Coverage 84.35% 84.35%
============================================
Files 2120 2120
Lines 127113 127115 +2
Branches 32329 34213 +1884
============================================
+ Hits 107229 107232 +3
+ Misses 19696 19695 -1
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Review and recorded merge judgment for this carrier. Posting as a COMMENT because GitHub will not
accept an author's approval of their own pull request; the merge authority is the program's standing
Agent 1.54/1.55 backport grant (Christian, 2026-09-16, with the 2026-09-20 "admin merge them once our
own gates are passed" clarification), which permits this without manufacturing an approval record.
Heads
| Head at entry (stale) | fc5f277863b9efd6d069bd6c7d0f8282d6a854f6 |
Live core/1.54 tip |
c095e53675dcc9db86e487c976d72f243707a930 (#19997, merged 08:08:19Z) |
| Merge base of the stale head | 230c214d1604309824c75c19be3cad2539f16c81 |
| Head reviewed and merged | 6660349b6649d7645c927723a52f165e6f69fc49 |
Refreshed with PUT /pulls/19994/update-branch, expected_head_sha=fc5f277863b9…,
update_method=merge — an exact lease, and a merge rather than a rebase so no history is rewritten
and the original cherry-pick keeps its provenance. The merge commit is collapsed by the squash the
Core release branches ruleset mandates. git compare now reports status=ahead, ahead_by=2, behind_by=0, merge_base=c095e53675dc.
gh pr diff is identical before and after the refresh (ignoring blob index lines), so the
zero-overlap expectation is confirmed empirically rather than inferred: #19997 touches 18 files under
src/platform/assets/**, src/composables/graph/**, src/stores/assetExportStore*,
src/schemas/apiSchema.ts, ImagePreview* and src/locales/en/main.json, none of which this carrier
touches.
Review of the carried delta
Source #18970 merged to main at 07:05:13Z as 3b07da0b8d8c. This carrier is +68/−6 over 6 files
where the source was +151/−30 over 7. Every difference is an adaptation to this branch's older shape:
agentRestClient.ts— the source refactored body construction into
withoutUndefined<TurnPostBody>({...})and addedTurnPostBodyto widen the generated
AgentPostMessageRequest, which has noclient_message_id. Oncore/1.54the body is already
const body: Record<string, unknown>(agentRestClient.ts:166), so neither the refactor nor the
widening is needed. Wire behaviour is identical, including omission when the field is absent.useAgentSession.ts— the source threads the id through four signatures. Here the post input is
built by apostTurnclosure nested insidesendMessage, so one parameter (:410) plus one field
(:502) threads it completely. There is exactly onesendMessagecall site in the agent extension
(AgentPanelRoot.vue:1316), so no path can reach the POST without the id.- The same-id invariant holds, which is the entire point of the change:
meta.clientMessageIdis
theuuidv4()minted atuseAgentDraftSubmission.ts:124, reported on telemetry at
AgentPanelRoot.vue:1307and posted at:1321. - The source's
omits client_message_id when the caller has nonecase is not carried because the
equivalent assertion already sits immediately above the insertion point on this branch
(expect(Object.keys(parsed)).toEqual(['content'])). Coverage is not reduced.
browser_tests/ disposition
The source did touch browser_tests/: agentActivationConsent.spec.ts (+7), asserting the posted body
carries content plus a v4-uuid client_message_id. It is deliberately not carried. The PR body's
reason is accurate but narrower than the full picture: that spec file does not exist here, so the hunk
cannot apply mechanically — but this branch does carry the predecessor agentConsent.spec.ts, which has
an adaptable site at agentConsent.spec.ts:728 (await expect.poll(() => postedMessages).toHaveLength(1),
with postedMessages already capturing raw bodies at :706). So this is a real residual black-box gap
on the 1.54 line, about six lines wide, and not an impossibility. It is left open rather than closed
here because adapting it is a content change to the carrier, not a refresh, and it would cost the
carrier its standing as an equivalence-reviewed copy of a merged source.
No fixture contract diverges — the hunk adds no fixture, and audit-fixture-closure.py reports
0 verbatim spec(s) over a diverged fixture closure for origin/core/1.54.
Gate result at 6660349b6649
scripts/check-merge-ready.sh Comfy-Org/ComfyUI_frontend 19994 --target-branch core/1.54 (never the
two-argument default; the carrier was never rebased onto main) refuses on one condition and
nothing else:
NOT MERGE READY: commit statuses are not green at 6660349b6649d7645c927723a52f165e6f69fc49:
Vercel – billing-web-test=failure, Vercel – billing-web=failure
Everything the gate checks before that point passes: target allowlist, PR base matches the target, head
is not stale (c095e53675dc is its merge base and the compare status is ahead), check runs exist and
are all complete, every completed check is green/neutral/skipped, and no passing test receipt is missing
a started_at or predates the base commit. The two conditions after it were verified directly and also
pass: 0 unresolved non-outdated review threads, 0 approvals, 0 latest reviews, nothing truncated.
Check tally at this exact head: 89 latest check runs — 73 success, 16 skipped, 0 failure, 0 cancelled,
0 timed out. The three checks ruleset 7297873 ("Core release branches", active, refs/heads/core/**
and refs/heads/cloud/**) actually requires are all SUCCESS: lint-and-format, test,
e2e-status — alongside 16 Playwright chromium shards, playwright-tests (cloud), typecheck,
typecheck-aux and the ecosystem matrix.
Recorded judgment on the two Vercel statuses
Merging over them, explicitly and on the record:
- Both carry the description
Authorization required to deploy.with avercel.com/git/authorize
target, created2026-10-03T07:31:38Z— six seconds after this PR opened, before any code could be
analysed. This is Vercel's git integration declining to deploy an external-fork head
(christian-byrne/ComfyUI_frontend:backport-18970-to-core-1.54), not a verdict on the diff. - Neither is a required status check on this branch. The ruleset requires exactly the three named
above, and all three are green. - The diff cannot change what those two projects deploy:
website-unitandwebsite-e2eare
skippedat this head by the repository's own change detection. - There is no untested delta to overlap with — the head is
behind_by=0.
A correction to program/release-backport-authority.md for whoever reads this next. Its standing
EXCEPTION (sunset 2026-10-09) says Vercel – billing-web-test is FAILURE at the head of every PR on
core/1.54. That premise is obsolete. At the heads of the four most recently merged core/1.54 PRs —
#19997, #19917, #19905, #19848, all isCrossRepository: false — both Vercel contexts are SUCCESS.
The failure now tracks fork origin, not the branch, which is also why it covers a second context the
exception never named. So this merge does not rest on that waiver; it rests on the judgment above. The
waiver's basis should be re-derived, not re-cited.
This waives those two deploy-authorization statuses and nothing else. No test was weakened, no failing
check was bypassed, no reviewer was contacted, and no approval record was manufactured.
Backports merged #18970 to
core/1.54.Preserves the target send path while carrying the existing per-attempt
client_message_idunchanged into the turn POST. The original browser assertion was omitted because that spec does not exist on this target; equivalent target-supported coverage is provided by the focused unit tests.Validation:
pnpm test:unit src/workbench/extensions/agent/services/agent/agentRestClient.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000 --reporter=dot(315 passed)NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheckJustification: Release backport merged under the standing Agent 1.54/1.55 backport grant (Christian, 2026-09-16 and the 2026-09-20 "admin merge them once our own gates are passed" clarification), which authorizes the carrier owner to review and merge these carriers; GitHub will not record an author's approval of their own PR, so no approval record exists to point at — what limits the risk is that every production line here is covered by @benceruleanlu's human approval of the source change on #18970 (review 5397347386, over commit 458f513; the only post-approval source commit, 4145f95, was tests-only), the carrier adds one optional request field that is omitted when absent, and
lint-and-format/test/e2e-status— the three checks theCore release branchesruleset requires — are green at the exact merged head.