Repository navigation
fix(agent): finalize empty terminal recovery - #19850
Conversation
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 8148f20d57db3bd594684325629d694043dce8e9
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2185 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 10.1 MB gzip 🟢 -79 BDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.89 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.47 MB (baseline 1.47 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 646 kB (baseline 646 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 53.6 kB (baseline 53.6 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 7 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 10 unchanged Data & Services — 4.13 MB (baseline 4.13 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 11 added / 11 removed / 3 unchanged Utilities & Hooks — 586 kB (baseline 586 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.3 MB (baseline 18.3 MB) • 🔴 +72 BBundles that do not match a named category
Status: 84 added / 84 removed / 221 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-02T02:13:16.454Z",
"gitSha": "05b72c747f73a835704a76c37b598b1d9bf263cd",
"branch": "fix/agent-finalize-empty-terminal-recovery",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.8280000000036,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.030999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.15799999999996,
"heapDeltaBytes": 22329856,
"heapUsedBytes": 76171280,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.451,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2017.4430000000712,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.306000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.75100000000003,
"heapDeltaBytes": -266140,
"heapUsedBytes": 64770704,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.315000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1775.0350000000026,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.153000000000002,
"layouts": 12,
"layoutDurationMs": 4.456999999999999,
"taskDurationMs": 784.4219999999999,
"heapDeltaBytes": 19891796,
"heapUsedBytes": 78781020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.267,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1789.6220000000085,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.808999999999997,
"layouts": 12,
"layoutDurationMs": 4.05,
"taskDurationMs": 798.2119999999999,
"heapDeltaBytes": -2868460,
"heapUsedBytes": 64816788,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 168.70200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.8849999999761,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.619,
"layouts": 6,
"layoutDurationMs": 1.11,
"taskDurationMs": 335.41200000000003,
"heapDeltaBytes": 3463856,
"heapUsedBytes": 71211400,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.738000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.2490000000435,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.165000000000001,
"layouts": 6,
"layoutDurationMs": 1.252,
"taskDurationMs": 334.36299999999994,
"heapDeltaBytes": 3465268,
"heapUsedBytes": 70493072,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.886999999999993,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 691.4329999999609,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.060999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.9150000000001,
"heapDeltaBytes": -7962156,
"heapUsedBytes": 58905756,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 166.42100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 730.4710000000796,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.935000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.09200000000004,
"heapDeltaBytes": -32858892,
"heapUsedBytes": 68431028,
"domNodes": -232,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 166.536,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069753,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1173.107000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 831.8570000000001,
"heapDeltaBytes": 13494212,
"heapUsedBytes": 94518396,
"domNodes": 0,
"jsHeapTotalBytes": 8028160,
"scriptDurationMs": 75.68200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 541,
"frameDurationMs": 34.31176470588236,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1141.181999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 774.094,
"heapDeltaBytes": 15227764,
"heapUsedBytes": 83899952,
"domNodes": 0,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 68.97900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.0480000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.61199999999974,
"heapDeltaBytes": 16106468,
"heapUsedBytes": 104391172,
"domNodes": 0,
"jsHeapTotalBytes": 790528,
"scriptDurationMs": 167.621,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.3060000000269,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.2639999999998,
"heapDeltaBytes": 17373800,
"heapUsedBytes": 104326400,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.01900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9907.688000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8920.793,
"heapDeltaBytes": -766376,
"heapUsedBytes": 81039064,
"domNodes": 0,
"jsHeapTotalBytes": -14942208,
"scriptDurationMs": 7217.232,
"eventListeners": 0,
"totalBlockingTimeMs": 913,
"frameDurationMs": 32.78046357615894,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10306.363000000034,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.4399999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9376.127,
"heapDeltaBytes": -528332,
"heapUsedBytes": 82702608,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 7694.463,
"eventListeners": -78,
"totalBlockingTimeMs": 899,
"frameDurationMs": 31.88730650154799,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10361.549000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9476.418000000001,
"heapDeltaBytes": -12956424,
"heapUsedBytes": 67804432,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 7758.639,
"eventListeners": 0,
"totalBlockingTimeMs": 1066,
"frameDurationMs": 31.94320987654321,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9766.901000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8938.568,
"heapDeltaBytes": -3256844,
"heapUsedBytes": 80820240,
"domNodes": -143,
"jsHeapTotalBytes": -6426624,
"scriptDurationMs": 7321.7699999999995,
"eventListeners": -82,
"totalBlockingTimeMs": 882,
"frameDurationMs": 32.283443708609276,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2014.2880000000218,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.922,
"heapDeltaBytes": 2314140,
"heapUsedBytes": 85327052,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 31.251000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.9519999999766,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.493000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.9979999999999,
"heapDeltaBytes": -39708400,
"heapUsedBytes": 82941080,
"domNodes": -328,
"jsHeapTotalBytes": -1933312,
"scriptDurationMs": 34.205,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2489.0480000000252,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.122999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.273,
"heapDeltaBytes": 318148,
"heapUsedBytes": 87200732,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 848.1270000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666891891891897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2399.2019999999457,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.791999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1642.755,
"heapDeltaBytes": 19983936,
"heapUsedBytes": 82963380,
"domNodes": -328,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 832.6320000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.782517482517488,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3589.4329999999854,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.288999999999998,
"layouts": 60,
"layoutDurationMs": 13.597,
"taskDurationMs": 1659.893,
"heapDeltaBytes": 13270940,
"heapUsedBytes": 89199636,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 772.321,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666511627906978,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3572.475999999938,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.77,
"layouts": 60,
"layoutDurationMs": 13.908,
"taskDurationMs": 1667.6190000000001,
"heapDeltaBytes": 15139200,
"heapUsedBytes": 91242756,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 770.781,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3124.58799999996,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.3759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1947.6489999999997,
"heapDeltaBytes": 6707980,
"heapUsedBytes": 94357500,
"domNodes": 0,
"jsHeapTotalBytes": 1503232,
"scriptDurationMs": 981.401,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755376344086017,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2983.9980000000423,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.029000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1764.439,
"heapDeltaBytes": 26644448,
"heapUsedBytes": 94041900,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 977.957,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.759550561797752,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.064000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.820999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.369,
"heapDeltaBytes": -792864,
"heapUsedBytes": 86747140,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 40.96000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.42400000001,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7830000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.2289999999999,
"heapDeltaBytes": -521576,
"heapUsedBytes": 86578368,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 30.950999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.197999999978,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.5920000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.514,
"heapDeltaBytes": -11725432,
"heapUsedBytes": 57105548,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 146.181,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.7269999999171,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.738,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.15000000000003,
"heapDeltaBytes": -11531944,
"heapUsedBytes": 57150392,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 150.742,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.7160000000404,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.632999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.83599999999996,
"heapDeltaBytes": 848360,
"heapUsedBytes": 70251180,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.602999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2026.5939999999318,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.753000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.53700000000003,
"heapDeltaBytes": 22390412,
"heapUsedBytes": 76209364,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.278,
"eventListeners": -206,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.031000000005,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.594,
"layouts": 16,
"layoutDurationMs": 5.948,
"taskDurationMs": 752.862,
"heapDeltaBytes": -6473924,
"heapUsedBytes": 62245760,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.213,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.40200000004,
"styleRecalcs": 79,
"styleRecalcDurationMs": 17.411999999999995,
"layouts": 16,
"layoutDurationMs": 5.458,
"taskDurationMs": 641.4340000000001,
"heapDeltaBytes": -34900780,
"heapUsedBytes": 68961804,
"domNodes": -249,
"jsHeapTotalBytes": -2097152,
"scriptDurationMs": 111.92500000000001,
"eventListeners": -206,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.036999999974,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.63600000000001,
"layouts": 5,
"layoutDurationMs": 13.164000000000001,
"taskDurationMs": 871.9129999999999,
"heapDeltaBytes": 22209404,
"heapUsedBytes": 108037416,
"domNodes": 13747,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 28.438999999999993,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 19.144594594594604,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8609.86600000001,
"styleRecalcs": 251,
"styleRecalcDurationMs": 33.412,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5840.159,
"heapDeltaBytes": -3664068,
"heapUsedBytes": 83005856,
"domNodes": -143,
"jsHeapTotalBytes": -9080832,
"scriptDurationMs": 2792.3140000000003,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73093385214008,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8369.852000000037,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.211999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5733.6,
"heapDeltaBytes": -42705948,
"heapUsedBytes": 79822240,
"domNodes": -328,
"jsHeapTotalBytes": -2265088,
"scriptDurationMs": 2645.1259999999997,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699001996007986,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17077.308000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16384.112999999998,
"heapDeltaBytes": -20049060,
"heapUsedBytes": 188551520,
"domNodes": -3045,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 251.54500000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.525951557093425,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-idle",
"durationMs": 16682.590000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15908.232999999998,
"heapDeltaBytes": -14627012,
"heapUsedBytes": 194210700,
"domNodes": -3045,
"jsHeapTotalBytes": 5001216,
"scriptDurationMs": 253.245,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.468600682593856,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 20360.451000000012,
"styleRecalcs": 163,
"styleRecalcDurationMs": 17.621,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19986.15,
"heapDeltaBytes": -21301928,
"heapUsedBytes": 178243628,
"domNodes": -3045,
"jsHeapTotalBytes": 8658944,
"scriptDurationMs": 850.494,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.468014705882354,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 20678.77599999997,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.62099999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20272.654,
"heapDeltaBytes": -45667428,
"heapUsedBytes": 179627976,
"domNodes": -3045,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 852.9830000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 4,
"frameDurationMs": 38.089502762430946,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6134.611000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.13399999999999,
"layouts": 20,
"layoutDurationMs": 24.435,
"taskDurationMs": 6021.1230000000005,
"heapDeltaBytes": -19286752,
"heapUsedBytes": 205773664,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 108.776,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.388757396449705,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6236.317999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.20800000000003,
"layouts": 20,
"layoutDurationMs": 24.583999999999996,
"taskDurationMs": 6081.209,
"heapDeltaBytes": 875892,
"heapUsedBytes": 207795292,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 111.386,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.61828571428572,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8511.506000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8210.180999999999,
"heapDeltaBytes": -40400396,
"heapUsedBytes": 177040804,
"domNodes": -3045,
"jsHeapTotalBytes": 6115328,
"scriptDurationMs": 128.63599999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.715202702702705,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8577.940000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8134.533999999999,
"heapDeltaBytes": -33401748,
"heapUsedBytes": 182557000,
"domNodes": -3045,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 122.34299999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.84276094276094,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 130.00899999997273,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.011000000000003,
"layouts": 4,
"layoutDurationMs": 2.815,
"taskDurationMs": 94.43399999999998,
"heapDeltaBytes": 3994820,
"heapUsedBytes": 69636556,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.886999999999995,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.43333333333324,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "workflow-execution",
"durationMs": 146.96700000001783,
"styleRecalcs": 11,
"styleRecalcDurationMs": 15.956000000000001,
"layouts": 4,
"layoutDurationMs": 1.8210000000000002,
"taskDurationMs": 115.261,
"heapDeltaBytes": 3948800,
"heapUsedBytes": 57311452,
"domNodes": -113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.304999999999998,
"eventListeners": -122,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 846.8619999999873,
"styleRecalcs": 78,
"styleRecalcDurationMs": 99.652,
"layouts": 76,
"layoutDurationMs": 24.820999999999998,
"taskDurationMs": 821.7280000000001,
"heapDeltaBytes": 17674140,
"heapUsedBytes": 87348128,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 334.7,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352933,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 879.0670000000773,
"styleRecalcs": 78,
"styleRecalcDurationMs": 101.101,
"layouts": 76,
"layoutDurationMs": 24.944000000000003,
"taskDurationMs": 847.9230000000001,
"heapDeltaBytes": 18078860,
"heapUsedBytes": 88535820,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 348.33599999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1378.0530000000226,
"styleRecalcs": 78,
"styleRecalcDurationMs": 255.38,
"layouts": 76,
"layoutDurationMs": 28.365000000000002,
"taskDurationMs": 1361.941,
"heapDeltaBytes": -18920416,
"heapUsedBytes": 109287684,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 454.85600000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.292500000000018,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1385.9800000000178,
"styleRecalcs": 78,
"styleRecalcDurationMs": 254.84699999999998,
"layouts": 76,
"layoutDurationMs": 28.962999999999997,
"taskDurationMs": 1361.773,
"heapDeltaBytes": 8627184,
"heapUsedBytes": 114022024,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 459.852,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.50886075949368,
"p95FrameDurationMs": 33.29999999999927
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (4)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughAgent turn recovery now returns an error notice for empty failed transcripts and preserves the distinction between other empty transcripts. Turn settlement updates locally streamed parts when persisted parts are absent. ChangesAgent turn recovery and settlement
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Empty failed turns now show an error notice, while interrupted turns retain streamed content. No identified issue remains that should prevent merging after normal checks. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR uses bug-fix language in the title and commit subjects:
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19850 +/- ##
==========================================
+ Coverage 84.75% 85.49% +0.73%
==========================================
Files 3411 2401 -1010
Lines 163762 137072 -26690
Branches 44656 35118 -9538
==========================================
- Hits 138796 117184 -21612
+ Misses 23019 19521 -3498
+ Partials 1947 367 -1580
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1049 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 2 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
Addresses review feedback: #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) (cherry picked from commit 9303bd4)
Addresses review feedback: #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) (cherry picked from commit 9303bd4)
Addresses review feedback: #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) (cherry picked from commit 9303bd4)
Addresses review feedback: #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) #19850 (comment) (cherry picked from commit 9303bd4)
Summary
Hardens the REST recovery path added by #18154:
Related: PM-1776, PM-1682, PM-1199.
Validation