Skip to content

FE-3120 feat(billing-web): report the entry link once per tab entry - #19804

Merged
dante01yoon merged 2 commits into
jaewon/fe-3140-move-the-billing-telemetry-event-contract-to-a-sharedfrom
jaewon/fe-3120-billing-web-entry-session-and-return-events
Oct 1, 2026
Merged

dante01yoon merged 2 commits into
jaewon/fe-3140-move-the-billing-telemetry-event-contract-to-a-sharedfrom
jaewon/fe-3120-billing-web-entry-session-and-return-events

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Billing web reports how an entry link arrives, once per tab entry: billing.web_entry.received, .rejected and .bounced (E4 to E6). This is the first of three PRs for FE-3120. Session events (E7 to E9) and the return click (E27) follow in the next two.

Why

Nothing records what reaches billing web. A link that fails to parse, a pricing or plan-less checkout link that sends the customer straight back to the host, and a checkout whose return target was replaced are all invisible. The rollout needs the landing as a countable step that links to the cloud app's handoff, and it must count a customer once, not once per route change.

Root cause

The router guard reads and routes every entry link but reports nothing, and billing web has no way to say "this tab already reported". The guard runs on every navigation, on the sign-in redirect and on every reload, so a naive emit would repeat.

How

  • Contract. webEntryEvent.ts in packages/account-core/src/core/billing/telemetry defines the three events as one WebEntryBillingEvent and adds one line to the BillingTelemetryEvent union. The payload allowlist gains product, has_plan, reason and to. All are bounded enums or a boolean. WebEntryProduct, WebEntryErrorCode and WebEntryBounceTarget mirror the billing-contract types, and type tests in packages/billing-contract fail when they drift.
  • Once per tab. trackOncePerTab sends an event the first time the tab produces its name. It remembers in sessionStorage, which survives a reload and ends with the tab. A tab that refuses storage still reports once per page load.
  • Router. The guard reports received when it admits a link, rejected with the parser's error_code when it cannot use one (including a link whose way back cannot be resolved), and bounced when it sends the customer to the host or replaces a checkout's return_to.
  • Payloads. received carries intent, product, has_plan, the link's payment_intent_source and its correlation_id (the cloud journey id) when present. bounced carries reason (pricing_link, planless_checkout, return_target_rewritten) and to (a return target or pricing_table). No URL, query value, workspace id, promo code or amount is reported.
  • Docs. A short subsection in the billing web README lists the events.
  • User-visible behavior. None. This is telemetry only.

Review Focus

  • Stacked on FE-3140 refactor(billing): move the billing telemetry event contract to a shared package #19798 (FE-3140): the base is its branch until it merges, then the base moves to main. Review only the commits after FE-3140's head c24ff3de75. Next in this stack: the session events (E7 to E9) and the return click (E27).
  • Field name: received sends the link's source as payment_intent_source, not source, the same call E3 made. source already means the resubscribe surface in the allowlist, and every other billing event uses payment_intent_source for this list.
  • Disjoint outcomes: received means admitted, rejected means the error view, bounced means the customer left for the host. A pricing link or plan-less checkout that bounces is not also received. The one overlap is return_target_rewritten, which follows received because the link is still served.
  • outcome is pending on all three. The SSOT says client journey events never claim an operation outcome, so a rejected link is stage: rejected with error_code, not outcome: failure. Dashboards that filter on outcome:failure will not see these.
  • Once per tab is per event name, not per link. A tab that bounces a pricing link and later rewrites a checkout's return target reports only the first bounced. A host that navigates the same tab into billing web twice, instead of opening a new tab, is counted once. Cloud opens a new tab each time.
  • UNKNOWN_RETURN_TARGET can come from a pricing or plan-less link whose return target has no destination in this environment. That link is reported as rejected, not received then bounced.
  • The planless router test file now mocks the telemetry facade, as the sink boundary, so its cold import stays light. On a heavily loaded machine its first test is close to the default 5s limit for module loading. It passed at normal load.
  • Known gap: bounced leaves the page immediately (location.replace). If PostHog has not finished loading when the page leaves, its queued event is lost with the page. Whether RUM flushes on a page exit is part of the FE-3119 check.

AS IS / TO BE

AS IS: AS IS at 9ec8aa2e98: 18 of 18 scenarios off contract. In all 23 tabs run, a valid subscription, checkout and top-up link, 9 rejected links one per error code, a pricing link, a plan-less checkout, two checkouts whose return_to is replaced, and the same links after route changes, a sign-in redirect, a reload and a tab without storage, trackBillingEvent, datadogRum.addAction and posthog.capture are called 0 times, while the router still sends the pricing and plan-less links back to the host and an event that already existed reaches both sinks in the same harness; router.entryTelemetry.test.ts passes 0 of 22, each failing with an empty list where the reported event is expected, apps/billing-web passes 1055 of 1077, account-core src/core/billing 594 of 594, billing-contract 123 of 123

TO BE: TO BE at 7a373ea5e6: 18 of 18 scenarios on contract. A valid link reports one billing.web_entry.received with intent, product and has_plan, plus payment_intent_source and the Cloud correlation_id when the link carries them, each of the 9 rejected links reports one billing.web_entry.rejected with its own error_code, a pricing link and a plan-less checkout report one billing.web_entry.bounced to the return target or pricing_table, and a checkout whose return_to is replaced reports received then bounced as return_target_rewritten to comfyui_credits, the same payload in RUM and PostHog with outcome pending and billing_surface billing_web; route changes, the sign-in redirect, a reload and a tab without storage add no second event of the same name, the 26 payloads in each sink hold only enums, booleans and the journey id with no URL, query value, workspace id, promo code, amount or plan name, and the host redirects are unchanged; router.entryTelemetry.test.ts passes 22 of 22, apps/billing-web 1077 of 1077, account-core src/core/billing 598 of 598, billing-contract 126 of 126

The evidence is the sequence of billing web telemetry events for a valid link, a rejected link, a pricing link, a plan-less checkout and a checkout with a replaced return target, then the same links after a route change and a reload in the same tab, before (no events) and after.

Where this sits in the plan

Linear: FE-3120, part of FE-3105. Plan, event catalog and dependency graph: action items.

Task Ticket What Status
T1 FE-3107 Decide vocabulary and dimensions done, in the SSOT
T2 FE-3108 Decide RUM application and env mapping decided
T3 FE-3109 Billing web telemetry bootstrap (RUM and PostHog) PR 19688, merged
T3+ FE-3156 Opaque RUM user id on billing web PR 19794, in review
T4, F1 FE-3106 SDK-rail ownership PR 19620, merged
T4, F2 FE-3110 Keep operation id and fields in the mapper PR 19623, merged
T4, F3 FE-3111 Stamp billing_surface and billing_client PR 19685, merged
T4, F5 FE-3112 SDK top-up terminals PR 19628, merged
T4, F6 FE-3113 Downgrade reconciliation terminal PR 19622, merged
T4, F7 FE-3114 Legacy personal-rail events, first slice PR 19627, merged
T4, F7+ FE-3131 Legacy personal-rail events, remaining slices PR 19686, merged
T4+ FE-3140 Move the billing event contract to a shared package PR 19798, in review
T5 FE-3115 Cloud entry fidelity and Datadog parity todo
T6 FE-3116 Handoff contract and event PR 19687, merged
T7 FE-3117 Billing web attempt lifecycle PR 19809, PR 19810, PR 19811, in review
T8 FE-3118 Billing web journey and choices todo
T9 FE-3119 Payment friction events todo
T10 FE-3120 Billing web entry, session and return this PR
T11 FE-3121 Portal events todo
T12 FE-3122 Flag coverage check todo
T13 FE-3123 PostHog rollout dashboard todo
T14 FE-3124 Datadog tiles in the Frontend RUM dashboard todo
T15 FE-3125 Verification per flow todo
T16 FE-3126 Rollout plan todo
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T10 stroke-width:3px
Loading

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c4b72980-7e65-408b-99f9-52720c392931

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 08:37:06 PM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c24ff3de75b092e34ddee5d8b16f6dc503979a34

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2183 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2164 / ❌ 0 / ⚠️ 1 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
dom-widget-order-dense-n200-w200-i120: · 34.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 355ms TBT · 83.5 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 45.2 avg FPS · 39.8 P5 FPS ❌ (target: ≥52) · 124ms TBT · 97.9 MB heap
extension-clean-combined-draw: · 44.2 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 14ms TBT · 79.7 MB heap
extension-rgthree-prototype-draw: · 43.6 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 7ms TBT · 70.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
legacy-node-drag: · 59.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
subgraph-transition-enter: · 51.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 90ms TBT · 101.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
vue-large-graph-idle: · 49.7 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 177.7 MB heap
vue-large-graph-pan: · 39.1 avg FPS · 17.2 P5 FPS ❌ (target: ≥52) · 2ms TBT · 177.9 MB heap
vue-node-resize-workload: · 37.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 2ms TBT · 198.5 MB heap
vue-zoom-out-idle: · 49.7 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 163.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.4 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 125.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 311ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 75.0 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 72
canvas-mouse-sweep: task duration 575ms
canvas-mouse-sweep: script duration 110ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.0 MB
canvas-mouse-sweep: DOM nodes 0
canvas-mouse-sweep: event listeners 0
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 10ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 297ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.2 MB
canvas-zoom-sweep: DOM nodes -63
canvas-zoom-sweep: event listeners -65
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 347ms
dom-widget-clipping: script duration 117ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 68.5 MB
dom-widget-clipping: DOM nodes -116
dom-widget-clipping: event listeners -82
dom-widget-order-dense-n200-w200-i120: avg frame time 29ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 595ms
dom-widget-order-dense-n200-w200-i120: script duration 40ms
dom-widget-order-dense-n200-w200-i120: TBT 355ms
dom-widget-order-dense-n200-w200-i120: heap used 83.5 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 22ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 333ms
dom-widget-order-sparse-n1000-w20-i120: script duration 106ms
dom-widget-order-sparse-n1000-w20-i120: TBT 124ms
dom-widget-order-sparse-n1000-w20-i120: heap used 97.9 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 23ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 3
extension-clean-combined-draw: task duration 5159ms
extension-clean-combined-draw: script duration 3891ms
extension-clean-combined-draw: TBT 14ms
extension-clean-combined-draw: heap used 79.7 MB
extension-clean-combined-draw: DOM nodes -72
extension-clean-combined-draw: event listeners -41
extension-rgthree-prototype-draw: avg frame time 23ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 5294ms
extension-rgthree-prototype-draw: script duration 3942ms
extension-rgthree-prototype-draw: TBT 7ms
extension-rgthree-prototype-draw: heap used 70.7 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 437ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.5 MB
large-graph-idle: DOM nodes -328
large-graph-idle: event listeners -164
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1239ms
large-graph-pan: script duration 606ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.8 MB
large-graph-pan: DOM nodes -164
large-graph-pan: event listeners -82
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 16ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1351ms
large-graph-zoom: script duration 580ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 67.5 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1463ms
legacy-node-drag: script duration 713ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 72.2 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 405ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.7 MB
minimap-idle: DOM nodes -164
minimap-idle: event listeners -82
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 314ms
subgraph-dom-widget-clipping: script duration 110ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 57.6 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 315ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 72.1 MB
subgraph-idle: DOM nodes -249
subgraph-idle: event listeners -105
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 588ms
subgraph-mouse-sweep: script duration 88ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 60.2 MB
subgraph-mouse-sweep: DOM nodes 0
subgraph-mouse-sweep: event listeners 0
subgraph-transition-enter: avg frame time 20ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 8ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 687ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 90ms
subgraph-transition-enter: heap used 101.9 MB
subgraph-transition-enter: DOM nodes 13747
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 43ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4288ms
viewport-pan-sweep: script duration 1940ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 79.4 MB
viewport-pan-sweep: DOM nodes -328
viewport-pan-sweep: event listeners -164
vue-large-graph-idle: avg frame time 20ms
vue-large-graph-idle: p95 frame time 33ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11409ms
vue-large-graph-idle: script duration 192ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 177.7 MB
vue-large-graph-idle: DOM nodes -3046
vue-large-graph-idle: event listeners -14915
vue-large-graph-pan: avg frame time 26ms
vue-large-graph-pan: p95 frame time 58ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 77
vue-large-graph-pan: task duration 13921ms
vue-large-graph-pan: script duration 703ms
vue-large-graph-pan: TBT 2ms
vue-large-graph-pan: heap used 177.9 MB
vue-large-graph-pan: DOM nodes -3045
vue-large-graph-pan: event listeners -14915
vue-node-resize-workload: avg frame time 27ms
vue-node-resize-workload: p95 frame time 50ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 58ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4488ms
vue-node-resize-workload: script duration 80ms
vue-node-resize-workload: TBT 2ms
vue-node-resize-workload: heap used 198.5 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 20ms
vue-zoom-out-idle: p95 frame time 33ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5754ms
vue-zoom-out-idle: script duration 97ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 163.7 MB
vue-zoom-out-idle: DOM nodes -3045
vue-zoom-out-idle: event listeners -14915
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 19
workflow-execution: task duration 110ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 56.4 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 65
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 16ms
agent-composer-empty-conversation-typing: style recalc duration 66ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 396ms
agent-composer-empty-conversation-typing: script duration 134ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 69.3 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 20ms
agent-composer-long-conversation-typing: style recalc duration 198ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 865ms
agent-composer-long-conversation-typing: script duration 240ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 125.7 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-10-01T20:46:35.519Z",
  "gitSha": "ee57e6aad17ac7f946222591547ddb2fe8ada5eb",
  "branch": "jaewon/fe-3120-billing-web-entry-session-and-return-events",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2005.316999999991,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.217,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 300.974,
      "heapDeltaBytes": 22270992,
      "heapUsedBytes": 75923408,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.078999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.4419999999932,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.660999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 321.559,
      "heapDeltaBytes": 22447924,
      "heapUsedBytes": 81268384,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.137,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1690.9160000000156,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 13.811,
      "layouts": 12,
      "layoutDurationMs": 3.6770000000000005,
      "taskDurationMs": 552.253,
      "heapDeltaBytes": 19437320,
      "heapUsedBytes": 73161896,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 102.793,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666666,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1694.338000000016,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 16.092000000000002,
      "layouts": 12,
      "layoutDurationMs": 4.888,
      "taskDurationMs": 597.792,
      "heapDeltaBytes": 19524112,
      "heapUsedBytes": 73585456,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 117.26500000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1729.1280000000029,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 9.787,
      "layouts": 6,
      "layoutDurationMs": 1.3010000000000002,
      "taskDurationMs": 300.017,
      "heapDeltaBytes": -22722252,
      "heapUsedBytes": 78805004,
      "domNodes": -178,
      "jsHeapTotalBytes": -2621440,
      "scriptDurationMs": 12.694999999999999,
      "eventListeners": -145,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665048543689316,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1726.4790000000403,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 9.978000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.4029999999999998,
      "taskDurationMs": 294.917,
      "heapDeltaBytes": 3507272,
      "heapUsedBytes": 70511940,
      "domNodes": 53,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 13.578999999999994,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 530.052000000012,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.0889999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 333.90299999999996,
      "heapDeltaBytes": 15337344,
      "heapUsedBytes": 75905224,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 118.087,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665625000000006,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 555.5889999999977,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.720000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 360.96099999999996,
      "heapDeltaBytes": -34193328,
      "heapUsedBytes": 67851680,
      "domNodes": -231,
      "jsHeapTotalBytes": -2359296,
      "scriptDurationMs": 116.82599999999998,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636353,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 988.0919999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 583.572,
      "heapDeltaBytes": 11534992,
      "heapUsedBytes": 90706804,
      "domNodes": 0,
      "jsHeapTotalBytes": 4358144,
      "scriptDurationMs": 37.798,
      "eventListeners": 0,
      "totalBlockingTimeMs": 354,
      "frameDurationMs": 28.920588235294122,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 987.4090000000137,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.2119999999999,
      "heapDeltaBytes": 15432904,
      "heapUsedBytes": 84411024,
      "domNodes": 0,
      "jsHeapTotalBytes": 7766016,
      "scriptDurationMs": 41.431999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 356,
      "frameDurationMs": 28.920588235294122,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 765.655000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.679,
      "heapDeltaBytes": 18683704,
      "heapUsedBytes": 103477728,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 112.41000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 22.549999999999994,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 719.2809999999668,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 304.19099999999986,
      "heapDeltaBytes": 16894292,
      "heapUsedBytes": 101905080,
      "domNodes": 0,
      "jsHeapTotalBytes": 1052672,
      "scriptDurationMs": 99.03999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 107,
      "frameDurationMs": 21.715151515151497,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5815.135999999995,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 1.1689999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5138.487999999999,
      "heapDeltaBytes": 1755128,
      "heapUsedBytes": 85916104,
      "domNodes": -143,
      "jsHeapTotalBytes": -7475200,
      "scriptDurationMs": 3901.6539999999995,
      "eventListeners": -82,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 22.65546875,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5882.5219999999945,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5179.128000000001,
      "heapDeltaBytes": -104488,
      "heapUsedBytes": 81273044,
      "domNodes": 0,
      "jsHeapTotalBytes": -15990784,
      "scriptDurationMs": 3881.258,
      "eventListeners": 0,
      "totalBlockingTimeMs": 25,
      "frameDurationMs": 22.62730769230769,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5809.888000000001,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.4329999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5180.886,
      "heapDeltaBytes": -893156,
      "heapUsedBytes": 80277520,
      "domNodes": 0,
      "jsHeapTotalBytes": -17563648,
      "scriptDurationMs": 3857.704,
      "eventListeners": 0,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 22.744313725490198,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 6076.391999999998,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.24799999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5406.349,
      "heapDeltaBytes": -13037100,
      "heapUsedBytes": 67947132,
      "domNodes": 0,
      "jsHeapTotalBytes": -15728640,
      "scriptDurationMs": 4026.7540000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 23.154198473282445,
      "p95FrameDurationMs": 33.400000000000546
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.3310000000279,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.2060000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.0879999999999,
      "heapDeltaBytes": -40635956,
      "heapUsedBytes": 82829708,
      "domNodes": -328,
      "jsHeapTotalBytes": -3506176,
      "scriptDurationMs": 31.049,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.3729999999687,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.5319999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.638,
      "heapDeltaBytes": -41289784,
      "heapUsedBytes": 81725344,
      "domNodes": -328,
      "jsHeapTotalBytes": -2719744,
      "scriptDurationMs": 28.957000000000004,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666393442622947,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2123.784999999998,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.565,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1264.14,
      "heapDeltaBytes": 22441364,
      "heapUsedBytes": 85839512,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 622.924,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66535433070866,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2113.447000000008,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.887,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1213.9660000000001,
      "heapDeltaBytes": 25289848,
      "heapUsedBytes": 87711672,
      "domNodes": -328,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 588.9300000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666664,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3280.2149999999983,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.696000000000002,
      "layouts": 60,
      "layoutDurationMs": 16.406999999999996,
      "taskDurationMs": 1418.638,
      "heapDeltaBytes": 8315856,
      "heapUsedBytes": 72681888,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 608.1379999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666497461928934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3121.4239999999904,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.044,
      "layouts": 60,
      "layoutDurationMs": 15.456999999999999,
      "taskDurationMs": 1283.026,
      "heapDeltaBytes": 5090968,
      "heapUsedBytes": 68879548,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 551.611,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666310160427805,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2330.1910000000134,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.451999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1493.745,
      "heapDeltaBytes": 11209924,
      "heapUsedBytes": 78338936,
      "domNodes": 0,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 730.2839999999999,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.786231884057973,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2236.481999999967,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.002999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1431.6899999999996,
      "heapDeltaBytes": 8134844,
      "heapUsedBytes": 72990504,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 696.629,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.79097744360902,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.3529999999669,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.0829999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.136,
      "heapDeltaBytes": -341120,
      "heapUsedBytes": 87541612,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 33.765,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.769999999994,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.918999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.7289999999999,
      "heapDeltaBytes": 20705188,
      "heapUsedBytes": 83789892,
      "domNodes": -328,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.651999999999994,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66611570247934,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 499.35500000003685,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 4.995000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.72300000000007,
      "heapDeltaBytes": 9689128,
      "heapUsedBytes": 63561972,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 112.905,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 499.484999999936,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 5.640999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 309.85200000000003,
      "heapDeltaBytes": -11779712,
      "heapUsedBytes": 57222352,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 107.915,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2010.8170000000314,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.5789999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 307.961,
      "heapDeltaBytes": 22335856,
      "heapUsedBytes": 76214688,
      "domNodes": -248,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.450999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2030.6929999999852,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.822,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 322.458,
      "heapDeltaBytes": -29315112,
      "heapUsedBytes": 75042824,
      "domNodes": -250,
      "jsHeapTotalBytes": -2621440,
      "scriptDurationMs": 8.999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1678.056999999967,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 17.08,
      "layouts": 16,
      "layoutDurationMs": 5.61,
      "taskDurationMs": 611.0889999999999,
      "heapDeltaBytes": -6408772,
      "heapUsedBytes": 63616528,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 92.304,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667326732673267,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.5820000000294,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 14.874,
      "layouts": 16,
      "layoutDurationMs": 4.626,
      "taskDurationMs": 565.447,
      "heapDeltaBytes": -6411096,
      "heapUsedBytes": 62630456,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 84.306,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666336633663366,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 900.0130000000013,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 20.934999999999995,
      "layouts": 5,
      "layoutDurationMs": 8.209000000000001,
      "taskDurationMs": 686.701,
      "heapDeltaBytes": 22053268,
      "heapUsedBytes": 106838836,
      "domNodes": 13747,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 22.739999999999995,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 90,
      "frameDurationMs": 19.565217391304348,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8141.01599999998,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 43.588,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4241.536999999999,
      "heapDeltaBytes": -41467056,
      "heapUsedBytes": 82952216,
      "domNodes": -328,
      "jsHeapTotalBytes": -1445888,
      "scriptDurationMs": 1923.265,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665983606557376,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8186.345999999958,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 42.050000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4335.429999999999,
      "heapDeltaBytes": -38993156,
      "heapUsedBytes": 83592552,
      "domNodes": -328,
      "jsHeapTotalBytes": -3543040,
      "scriptDurationMs": 1957.035,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665784114052954,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12099.01000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11449.778000000002,
      "heapDeltaBytes": -27123432,
      "heapUsedBytes": 182557832,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6836224,
      "scriptDurationMs": 189.70399999999998,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.514261460101864,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11791.988999999943,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11368.299,
      "heapDeltaBytes": -18439448,
      "heapUsedBytes": 190112564,
      "domNodes": -3045,
      "jsHeapTotalBytes": 8933376,
      "scriptDurationMs": 194.01700000000002,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.698664440734557,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13934.549000000005,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 14.752999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13306.350999999999,
      "heapDeltaBytes": -16964300,
      "heapUsedBytes": 187323656,
      "domNodes": -3045,
      "jsHeapTotalBytes": 15618048,
      "scriptDurationMs": 680.2470000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 24.515641476274165,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15314.966000000026,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 17.589999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14535.77,
      "heapDeltaBytes": -17003612,
      "heapUsedBytes": 185768648,
      "domNodes": -3045,
      "jsHeapTotalBytes": 13979648,
      "scriptDurationMs": 725.8860000000001,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 26.636695652173913,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4480.773999999997,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 57.836999999999996,
      "layouts": 20,
      "layoutDurationMs": 24.487999999999996,
      "taskDurationMs": 4314.286999999999,
      "heapDeltaBytes": -12535924,
      "heapUsedBytes": 210865112,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 74.867,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 26.064534883720928,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4792.295000000081,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 58.672000000000004,
      "layouts": 20,
      "layoutDurationMs": 26.808,
      "taskDurationMs": 4662.3189999999995,
      "heapDeltaBytes": -6201328,
      "heapUsedBytes": 205330788,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 84.47000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 27.427428571428578,
      "p95FrameDurationMs": 50
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5917.027000000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5661.37,
      "heapDeltaBytes": -53894972,
      "heapUsedBytes": 162674904,
      "domNodes": -3045,
      "jsHeapTotalBytes": 4542464,
      "scriptDurationMs": 90.55399999999997,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 19.600996677740856,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6201.682000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5847.389999999999,
      "heapDeltaBytes": -38924716,
      "heapUsedBytes": 180638172,
      "domNodes": -3045,
      "jsHeapTotalBytes": 6049792,
      "scriptDurationMs": 103.58499999999992,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 20.623745819398,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "workflow-execution",
      "durationMs": 450.02199999998993,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 10.900000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.534,
      "taskDurationMs": 88.919,
      "heapDeltaBytes": 5656736,
      "heapUsedBytes": 59108756,
      "domNodes": 102,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 8.692,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66296296296295,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 474.1840000000366,
      "styleRecalcs": 24,
      "styleRecalcDurationMs": 19.227999999999998,
      "layouts": 4,
      "layoutDurationMs": 2.2910000000000004,
      "taskDurationMs": 130.11100000000002,
      "heapDeltaBytes": 5667828,
      "heapUsedBytes": 59089516,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.386000000000001,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379302,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 448.1949999999415,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 67.453,
      "layouts": 76,
      "layoutDurationMs": 16.037,
      "taskDurationMs": 403.629,
      "heapDeltaBytes": 13149852,
      "heapUsedBytes": 78145052,
      "domNodes": 76,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 134.825,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.662962962962983,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 427.2359999999935,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 64.148,
      "layouts": 76,
      "layoutDurationMs": 15.463,
      "taskDurationMs": 388.392,
      "heapDeltaBytes": -17941976,
      "heapUsedBytes": 67121328,
      "domNodes": 76,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 133.01,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66538461538462,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 940.921000000003,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 202.29,
      "layouts": 76,
      "layoutDurationMs": 22.08,
      "taskDurationMs": 906.7760000000001,
      "heapDeltaBytes": 10932328,
      "heapUsedBytes": 130153276,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 250.768,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66607142857143,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 854.7340000000077,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 194.52800000000002,
      "layouts": 76,
      "layoutDurationMs": 18.454,
      "taskDurationMs": 823.379,
      "heapDeltaBytes": 10352712,
      "heapUsedBytes": 133475880,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 229.442,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66538461538462,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 53470 81853 65.3% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.8% 1165
src/LGraphNode.ts 70.5% 387
src/platform/workspace/stores/billingOperationStore.ts 7.8% 366
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.0% 272
src/core/billing/operationLifecycle.ts 1.1% 262
src/platform/workspace/stores/teamWorkspaceStore.ts 39.2% 258
src/scripts/app.ts 73.1% 253
src/core/webSessionIdentity.ts 3.4% 224
src/scripts/pnginfo.ts 20.7% 222

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/billing-web/src/telemetry/trackOncePerTab.ts 75.00% 3 Missing ⚠️
@@                                           Coverage Diff                                            @@
##           jaewon/fe-3140-move-the-billing-telemetry-event-contract-to-a-shared   #19804      +/-   ##
========================================================================================================
+ Coverage                                                                 84.62%   84.72%   +0.09%     
========================================================================================================
  Files                                                                      3320     3411      +91     
  Lines                                                                    160834   163489    +2655     
  Branches                                                                  43664    44557     +893     
========================================================================================================
+ Hits                                                                     136110   138511    +2401     
- Misses                                                                    22916    23035     +119     
- Partials                                                                   1808     1943     +135     
Flag Coverage Δ
billing-web-unit 91.13% <91.17%> (?)
e2e 65.32% <ø> (-0.03%) ⬇️
unit 82.19% <ø> (-0.01%) ⬇️
website-unit 79.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/billing-web/src/router.ts 98.64% <100.00%> (ø)
...pps/billing-web/src/telemetry/webEntryTelemetry.ts 100.00% <100.00%> (ø)
...rc/core/billing/telemetry/billingTelemetryEvent.ts 100.00% <ø> (ø)
...account-core/src/core/billing/telemetry/payload.ts 100.00% <ø> (ø)
apps/billing-web/src/telemetry/trackOncePerTab.ts 75.00% <75.00%> (ø)

... and 94 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry telemetry slice is sound at this head: the allowlist excludes workspace and payment details, once-per-tab reporting survives reloads, and return-target rewriting remains tab-local.

Full context for agent readers

Reviewed the exact stacked diff and all existing review threads. The 122 successful checks are settled, with 11 expected skips and no failures or pending work.

@dante01yoon
dante01yoon merged commit a7ed781 into jaewon/fe-3140-move-the-billing-telemetry-event-contract-to-a-shared Oct 1, 2026
136 checks passed
@dante01yoon
dante01yoon deleted the jaewon/fe-3120-billing-web-entry-session-and-return-events branch October 1, 2026 21:06
dante01yoon added a commit that referenced this pull request Oct 1, 2026
…sion and the linked operation (#19821)

## Summary

Part 2 of 3, on part 1. Both billing web checkouts pass the payment
form's phases through (`payment_element_ready`,
`payment_element_failed`, `payment_submit_attempted`,
`payment_submit_failed`), report `submitted` on each Pay that goes
ahead, and report `operation_linked` with the operation that Pay issued.

## Why

The embedded checkout had no listener for the form's phases, and the
full page read only the element phases for its own state. The billing
web funnel stopped at the quote. The cloud app reports these steps, so
the two surfaces could not be compared past the preview.

## How

- **Form phases.** The embedded checkout listens to `@payment-phase` on
the confirm. The full page forwards all four phases from
`onPaymentPhase`, including the submit phases it used to ignore. The
shape is the cloud app's, so the same queries read both.
- **Submitted.** The embedded `pay` reports `submitted` right before the
subscribe call. The full page reports it from the page's own
`paySubmitted` event. Both fire after the checkout's own guards, so a
Pay that sends nothing is not `submitted`.
- **Operation linked.** The lifecycle publishes the operation. The first
operation published after a `submitted` is linked, once, and its id
rides on the later events as `billing_op_id`. A new `submitted` clears
it. An operation the checkout recovered on arrival, or one a sibling tab
started, is never linked because no `submitted` preceded it.

## Review Focus

- Stacked on #19819
(FE-3118 part 1, E15 and E16), which sits on
#19798 (FE-3140). The
base is the part 1 branch until it merges. Review only the commits after
part 1's head `f34408a7ff`. Next: the choices (E19 to E21).
- Ordering for a card payment that issues an operation: `entered`,
`preview_ready`, `payment_element_ready`, `payment_submit_attempted`,
`submitted`, `operation_linked`. Part 3 adds `method_selected` before
`submitted`.
- `submitted` also fires for a Pay the server refuses before issuing any
operation. Those attempts have no `operation_linked`. Their business
terminal is FE-3117's (E10 and E11), not this ticket's.
- `error_code` on `payment_element_failed` and `payment_submit_failed`
is the provider's own error code, passed through exactly as the cloud
app does. The type is `string`, not an allowlist, and it is the one
field in this set whose values the contract does not bound.
- The embedded form is keyed by quote revision, so a new revision
remounts it and reports `payment_element_ready` again. That matches what
the cloud app reports for the same form.
- The embedded checkout still reports no phase for a plan change, which
pays on the method on file and mounts no form.
- No user-visible change. Telemetry only.

## AS IS / TO BE

AS IS: placeholder, to be attached by editing this description.

TO BE: placeholder, to be attached by editing this description.

The evidence is the ordered `billing.checkout.*` actions RUM receives
for an embedded and a full-page card payment, with the operation id on
`operation_linked`, before (nothing past the quote) and after.

## Where this sits in the plan

Linear: [FE-3118](https://linear.app/comfyorg/issue/FE-3118), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](#19798), in
review |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](#19815), [PR
19816](#19816), [PR
19817](#19817), [PR
19818](#19818), in
review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](#19809), [PR
19810](#19810), [PR
19811](#19811), in
review |
| T8 | FE-3118 | Billing web journey and choices | this PR |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](#19804), [PR
19806](#19806), [PR
19807](#19807), in
review |
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | todo |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T8 stroke-width:3px
```
dante01yoon added a commit that referenced this pull request Oct 1, 2026
…failed sign-in carries (#19806)

## Summary

Billing web reports the session journey:
`billing.web_session.signin_required`, `.established` and `.failed` (E7
to E9), once per tab entry. A failed sign-in now carries its
`SessionErrorCode`, as `error_code`, on both sign-in modes. This is the
second of three PRs for FE-3120. It builds on the entry events PR.

## Why

The shared web session (`unified_web_session`) exists to remove the
second sign-in a customer meets on billing web after signing in to the
cloud app. Nothing counts that screen, so the rollout cannot show
whether it works, and a session that fails to establish is invisible.
Today the failure code is also lost on the shared-session path: the
sign-in port answers with a boolean.

## Root cause

`SignInPort.establish` resolved a boolean. The session client knew the
refusal's code and the shared session knew the workspace error, but both
were dropped at the port, and a failure to create the shared session
never produced a code at all.

## How

- **Contract.** `webSessionEvent.ts` defines the three events as one
`WebSessionBillingEvent` with one line in the `BillingTelemetryEvent`
union. The payload allowlist gains `mode` and `origin` (`reason` was
added in the entry PR). `failed` sends the existing `SessionErrorCode`
as `error_code`, the same field the entry PR's `rejected` uses, so there
is one error field on both web events.
- **Carry the code.** `SignInPort.establish` now resolves `{ status:
'ok' } | { status: 'error', code }`. The session client port returns the
code of the failed mint. The shared session returns the workspace error
code, or, when creating the session fails, `INVALID_FIREBASE_TOKEN` for
a 401 and `TOKEN_EXCHANGE_FAILED` for anything else. The controller only
reads the status, so the sign-in page behaves as before.
- **Report from the one place that knows.** `billingWebSignInPort()` in
`billingWebAuth.ts` knows the decided mode, the live phase, whether the
customer authenticated on this page, and each attempt's result. Opening
the port reports `signin_required` from the live phase (`signed-out` is
`no_session`, `error` is `refused`, a phase still resolving reports
nothing). Each `establish` reports `established` (`origin` is
`interactive` once the customer signed in on this page, else `restored`)
or `failed` with `error_code`.
- **Once per tab.** All three go through `trackOncePerTab`. `failed` is
reported once per code, so a reload or a retry that fails the same way
adds nothing and a different failure still does.
- **User-visible behavior.** None. This is telemetry only.

## Review Focus

- Stacked on #19798
(FE-3140): the base is its branch until it merges, then the base moves
to main. Part 1 of this stack
(#19804, the entry
events) is already merged into that branch. Review only part 2's own
change, 15 files against the base. Next in this stack: the return click
(E27, #19807).
- `outcome` is `pending` on all three, for the same reason as the entry
events: client journey events never claim an operation outcome. A failed
session is `stage: failed` with `error_code`, not `outcome: failure`.
- A customer with a Cloud session reaches the sign-in page for a moment
and leaves like a restore, because the first route guard runs before the
mode is decided. That restore is what reports `established` with
`origin: restored`. `signin_required` waits for a settled `signed-out`
or `error` phase, so a restore that is still resolving is not counted as
a second sign-in.
- `signin_required` is once per tab, whichever reason comes first. A
refusal that follows an interactive sign-in is not a new sign-in screen,
so it is covered by `failed` and not by a second `signin_required`.
- `refused` and `failed` can describe one incident: a restored session
whose workspace is refused reports `signin_required` with `refused`,
then `failed` with `ACCESS_DENIED`. They answer different questions (who
was sent to sign-in, and why the session failed), so I kept both.
- The mapping for a session that cannot be created is deliberately
coarse. It mirrors the token exchange: a refused credential has its own
code and every other failure is one bucket. It feeds telemetry only. The
sign-in page still reads its failure copy from the port's `failureCode`
ref, which this PR does not change.
- `SignInPort.establish` changing from a boolean to a result touches
`unifiedBillingSession.test.ts` expectations (three assertions). There
are no other callers.
- Known gap: the second sign-in KPI only means something as
`unified_web_session` rolls out. With the flag off, every signed-out
visit is a sign-in on the session client, so the two modes are compared
through `mode` on `established`, not through `signin_required` alone.
- Existing behavior this PR makes visible: in shared-session mode, after
creating the shared session fails (for example a 503), the page's Try
again calls `establish()` with no user, which answers
`NOT_AUTHENTICATED` without any request. The telemetry therefore reports
a second `failed` with `error_code: NOT_AUTHENTICATED` for that retry,
once per code. The retry cannot succeed today; signing in again does
recreate the session. Not changed here; tracked in
[FE-3158](https://linear.app/comfyorg/issue/FE-3158).

## AS IS / TO BE

AS IS: ![AS IS at 7a373ea: 15 of 15 scenarios off contract.
billingWebSignInPort() reports no web_session event on either sign-in
mode, so a Cloud session found on arrival, a sign-in on billing web, a
refused workspace, a session the shared endpoint refuses to create with
503 or 401, a reload and a retry each reach
billingWebTelemetry.trackBillingEvent, datadogRum.addAction and
posthog.capture with only the entry link web_entry.received, and the
port establish() resolves a bare true or false that drops the failure
code, ACCESS_DENIED, TOKEN_EXCHANGE_FAILED and INVALID_FIREBASE_TOKEN
included; the 15 payloads per sink that do arrive hold only bounded
enums and a boolean; with this PR test files copied in, apps/billing-web
passes 1074 of 1084 with webSessionTelemetry.test.ts failing to load,
account-core src/core/billing 600 of
601](https://github.com/user-attachments/assets/64cb5197-1698-42c3-9279-05d67e66f642)

TO BE: ![TO BE at 8dbc5fb: 15 of 15 scenarios on contract.
billingWebSignInPort() reports billing.web_session.signin_required with
reason no_session or refused, established with origin restored or
interactive and mode session-client or web-session, and failed with
error_code, once per tab on both sign-in modes: ACCESS_DENIED for a
refused workspace, TOKEN_EXCHANGE_FAILED for a 503 and
INVALID_FIREBASE_TOKEN for a 401 whether the token mint or the shared
session creation refuses, a reload or a retry that fails the same way
adds nothing while a different code is reported once, and establish()
resolves { status: "ok" } or { status: "error", code }; the 45 payloads
per sink, 30 of them web_session events, hold only bounded enums and a
boolean, with no token, uid, email, workspace id or URL found;
apps/billing-web passes 1092 of 1092, account-core src/core/billing 601
of
601](https://github.com/user-attachments/assets/17a56676-3869-4d1d-acb0-e21ecb074994)

The evidence is the sequence of billing web telemetry events for a Cloud
session found on arrival, a signed-out visitor who signs in on billing
web, a refused workspace, and a session the shared endpoint refuses to
create (503 and 401), on both sign-in modes, before (no events, boolean
result) and after.

## Where this sits in the plan

Linear: [FE-3120](https://linear.app/comfyorg/issue/FE-3120), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](#19798), in
review |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](#19815), [PR
19816](#19816), [PR
19817](#19817), [PR
19818](#19818), in
review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](#19809), [PR
19810](#19810), [PR
19811](#19811), in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](#19819), [PR
19821](#19821), [PR
19822](#19822), in
review |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | this PR |
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | todo |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T10 stroke-width:3px
```
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 2, 2026
…to a shared package (Comfy-Org#19798)

## Summary

Move the typed billing event contract out of the cloud app into
`@comfyorg/account-core/billing`, keep the cloud app on it, and make the
billing web facade take a typed `BillingTelemetryEvent` instead of an
event name plus a raw payload.

## Why

Billing web could not import `BillingTelemetryEvent`, the payload
allowlist or the payload builders because
`src/platform/telemetry/types.ts` imports cloud-only types. Its facade
took a name and a payload the caller had to build correctly, so every
billing web event (FE-3117, FE-3118, FE-3120, FE-3121) would have
skipped the compile-time allowlist and the privacy contract check.

## Root cause

The contract lived in a cloud file that imports `TierKey` and
`BillingCycle` from cloud subscription modules, so no other host could
reach it.

## How

- **Commit 1, the move.** The event types, stage building blocks,
allowlist `BILLING_PAYLOAD_FIELD_HANDLING`, payload builders and the
billing event-name constants moved to
`packages/account-core/src/core/billing/telemetry/`, one module per
operation plus `stages.ts`, `billingTelemetryEvent.ts` (the one union),
`payload.ts` (the one table) and `eventNames.ts`. The code is
content-identical to what was in `types.ts` (`git diff
--color-moved=dimmed-zebra` shows it as moved). `types.ts` re-exported
the names so the cloud app compiled.
- **Commit 2, the journey.** The `billing.checkout.*` journey contract
moved the same way. It is not in the ticket text. It shares its failure
vocabulary with the union and FE-3118 needs it on billing web. It is its
own commit so it can be dropped.
- **Commit 3, the cloud imports.** 24 cloud files (16 source, 8 tests)
now import from `@comfyorg/account-core/billing` and the re-exports are
deleted. No re-export is left behind. `TelemetryEvents` spreads the
shared `BILLING_TELEMETRY_EVENTS`, so its keys and values are unchanged.
- **Commit 4, the builder and the guards.**
`getBillingWebTelemetryEventPayload` builds the allowlisted payload and
stamps `billing_surface: 'billing_web'`, mirroring
`getCloudAppBillingTelemetryEventPayload`. The table is checked against
the exported `BillingPayloadFieldHandling` type, and a test proves a
table that misses an event field does not compile.
- **Commit 5, the facade.** `trackBillingEvent(event:
BillingTelemetryEvent)` derives the name with
`getBillingTelemetryEventName`, builds the payload with the billing web
builder and sends it to RUM and PostHog as before. The whole call stays
inside `attempt`, so it never throws, and telemetry-off still drops
events.
- **Commit 6, one line.** `TelemetryEventName` now includes
`BillingTelemetryEventName`. Without it, every new member of the union
failed the cloud typecheck at `PostHogTelemetryProvider` and
`HostTelemetrySink` until someone added a `TelemetryEvents` constant
(FE-3116 had to). I checked this with a throwaway `web_entry` event: it
failed before and compiled after.
- **Cloud-only types.** The contract imported `TierKey`, `BillingCycle`,
`BillingSource`, `BillingIntent`, `BillingDeclineReason`,
`BillingPresentation`, `SubscribeResponse` and `CreateTopupResponse`.
`AgentRunMode` and `AppMode` are not used by it. `BillingDeclineReason`,
`BillingPresentation` and the two response types are already in the
shared packages. `TierKey` and `BillingCycle` had no shared source, so
account-core now owns `BillingTierKey` and `BillingCycle` and the cloud
`TierKey` and `BillingCycle` are aliases of them. Nothing was widened
and every payload type is identical.
- **Mirrored vocabulary.** `PaymentIntentSource` (15 values) and
`HostedBillingIntent` (7 values) in account-core mirror `BillingSource`
and `BillingIntent` in `@comfyorg/billing-contract`. account-core cannot
depend on billing-contract: its publish-boundary test forbids
unpublished workspace dependencies and billing-contract already
dev-depends on account-core.
`packages/billing-contract/src/eventVocabulary.test.ts` fails typecheck
when the two lists drift. I confirmed it by adding a value.
- **Renames forced by the move.** The shared barrel already exports
`BillingFailure` and `BillingErrorCode` for the transport, so the
telemetry ones are `BillingTelemetryFailure`,
`BillingTelemetryFailureCategory` and `BillingTelemetryErrorCode`.
`ResubscribeClickMetadata['source']` became `ResubscribeSource`.
- **Adding an operation (for FE-3117, FE-3118, FE-3120, FE-3115).** Add
`<operation>Event.ts` next to the others, add one line to the
`BillingTelemetryEvent` union in `billingTelemetryEvent.ts`, and add any
new payload field to `BILLING_PAYLOAD_FIELD_HANDLING` in `payload.ts`
(it fails to compile until you do). Billing web calls
`billingWebTelemetry.trackBillingEvent(event)`. The cloud sinks need no
change.

## Review Focus

- The diff is large because about 500 lines are moved code. New code is
the per-module import headers, `vocabulary.ts`, the barrel `index.ts`,
one 10-line builder, the facade and the tests. The moved blocks differ
from the originals only in the renames above and the allowlist guard
type.
- Package placement. D4 names `@comfyorg/account-core/billing`, and the
SDK-to-event mapper FE-3117 moves there needs the contract in the same
package. The cost is the mirrored `PaymentIntentSource` and
`HostedBillingIntent` lists, guarded by a type test in billing-contract.
The alternative, putting the contract in billing-contract, would make
billing-contract depend on account-core at runtime and put the mapper in
the wrong package.
- The checkout journey is in this PR although the ticket does not list
it. Drop commit `be72e3ef80` and the matching part of commit 3 if you
want it separate. FE-3118 would then have to move it.
- `PaymentIntentSource = BillingSource` stays in
`src/platform/telemetry/types.ts` for its 20 cloud call sites. The
`toBillingTelemetryEvent` mapper stays in `billingSdkTelemetry.ts` for
FE-3117 to move.
- No user-visible change. Cloud payloads are byte-identical (the
existing provider and contract suites pass with import-path edits only).
Billing web has no caller of `trackBillingEvent` yet, so nothing new is
sent from it.
- The facade now drops any field outside the allowlist, so a billing web
caller that passed an extra field before would lose it. There is no such
caller today.
- `UnifiedPricingTable.test.ts` ("prompts free-tier users to subscribe")
fails locally on `origin/main` too (`INTERNAL ASSERTION FAILED: Expected
a class definition`, local Node 24 against engine 26). I re-ran it
against `main`'s versions of every file this PR touches and it fails the
same way. This diff does not touch it.
- Known gap: `subscriptionCheckoutTracker.ts` still keeps its own copy
of the source list, as noted in FE-3116.

## AS IS / TO BE

AS IS: ![AS IS at 8757cd8: 6 of 15 scenarios off contract.
trackBillingEvent with a name and a raw payload forwards whatever the
caller passed, so an email, a client_secret, a return_url carrying its
payment_intent_client_secret query and a free-form error_message each
reach both datadogRum.addAction and posthog.capture next to the
allowlisted fields and billing_surface billing_web, PostHog before_send
then removes only the email and the URL query while RUM beforeSend
leaves the action context alone, and billing web typecheck accepts all
four calls with 0 diagnostics; allowlisted events, a caller-claimed
billing_surface and the 7 cloud sink payloads are on contract;
apps/billing-web src/telemetry passes 49 of 49, account-core
src/core/billing 588 of 588 with no telemetry folder yet, root
src/platform/telemetry 597 of
597](https://github.com/user-attachments/assets/1ac3e87b-beee-4cd4-98ca-ee2d6b670d50)

TO BE: ![TO BE at c24ff3d: 15 of 15 scenarios on contract.
trackBillingEvent with a typed event builds the payload through
getBillingWebTelemetryEventPayload, so the same email, client_secret,
return_url and error_message, passed past the compiler with a cast,
never reach datadogRum.addAction or posthog.capture, which receive only
the 11 allowlisted fields plus billing_surface billing_web, and billing
web typecheck refuses each of the four fields with TS2353 on a throwaway
call; the 7 cloud sink events, 6 billing and 1 checkout journey through
PostHogTelemetryProvider and DatadogRumTelemetryProvider, emit the same
sha256 as at 8757cd8; apps/billing-web src/telemetry passes 53 of 53,
account-core src/core/billing 594 of 594 with 6 of 6 in the new
telemetry folder, root src/platform/telemetry 597 of
597](https://github.com/user-attachments/assets/a321d086-a0db-44c7-8f92-385a9a0cdd31)

The evidence is the RUM action and PostHog capture payload billing web
sends for a typed event that also carries an email, a client secret and
a return URL: before, whatever the caller passed plus `billing_surface`;
after, only the allowlisted fields plus `billing_surface:
'billing_web'`.

## Where this sits in the plan

Linear: [FE-3140](https://linear.app/comfyorg/issue/FE-3140), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
this PR |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815), [PR
19816](Comfy-Org#19816), [PR
19817](Comfy-Org#19817), [PR
19818](Comfy-Org#19818), in
review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811), in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819), [PR
19821](Comfy-Org#19821), [PR
19822](Comfy-Org#19822), in
review |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806), [PR
19807](Comfy-Org#19807), in
review |
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | todo |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style C140 stroke-width:3px
```

---------

Co-authored-by: GitHub Action <action@github.com>
dante01yoon added a commit that referenced this pull request Oct 2, 2026
… and failed stages (#19945)

## Summary

Billing web reports its cancel flow as billing.cancel.intent,
billing.cancel.abandoned and billing.cancel.failed, using the cancel
contract from FE-3115.

## Why

E14 needs the cancel flow on both hosts. The cloud app gets it in
FE-3115. Billing web reported nothing for its cancel flow: a customer
who opened the confirmation and kept the plan, and a cancel the server
refused before any operation existed, were invisible. A refusal before
an operation exists is also invisible to the SDK stream, because the SDK
only reports operations.

## How

createCancelFlowTelemetry in
apps/billing-web/src/telemetry/cancelTelemetry.ts reports intent when
the confirmation opens, abandoned when the customer picks Keep my plan
or the surface unmounts with the confirmation still open, and failed
only when the cancel command returns a refusal (status error),
classified through the shared outcomeOfCommandResult. Once the customer
confirms, the flow is no longer abandoned, and a cancel that issued an
operation ends in the SDK's billing.operation.* events with
operation_type cancel, so this flow adds no terminal of its own. Each
event carries billing_client sdk and the current plan's tier and cycle,
which SubscriptionPanel passes down from the plan catalog.
checkoutTierOf is exported from subscriptionCheckoutTelemetry.ts so both
flows map server tiers the same way. There is no user-visible change.

## Review Focus

- Ownership: failed fires only for status error; an ok result with or
without an operation reports nothing here.
- Abandoned on unmount covers leaving the surface in the app; closing
the tab with the confirmation open is not reported.
- A thrown cancel command (not a returned refusal) reports nothing,
matching the cloud rule that a confirmed flow's end belongs to the
operation.
- Merge note: origin/main's #19811 adds the resubscribe telemetry import
on the same lines of SubscriptionActions.vue. Merging main into this
branch (or into FE-3115) gives a two-line import conflict; keep both
imports.

## AS IS / TO BE

Captured through the real telemetry providers in the component and
composable tests (Datadog RUM action and PostHog event carry identical
payloads, `billing_surface` per host). AS IS = base branch, TO BE = this
branch.

| Path | Host | AS IS | TO BE |
| --- | --- | --- | --- |
| reports opening the confirmation and keeping the plan | billing_web |
nothing | `billing.cancel.intent` (billing_client: sdk, current_tier:
pro, cycle: yearly)<br>`billing.cancel.abandoned` (billing_client: sdk,
current_tier: pro, cycle: yearly) |
| reports leaving the page while the confirmation is open as abandoned |
billing_web | nothing | `billing.cancel.intent` (billing_client: sdk,
current_tier: pro, cycle: yearly)<br>`billing.cancel.abandoned`
(billing_client: sdk, current_tier: pro, cycle: yearly) |
| leaves the end of a cancel the server settled to the operation events
| billing_web | nothing | `billing.cancel.intent` (billing_client: sdk,
current_tier: pro, cycle: yearly) |
| leaves the end of a cancel operation that failed to the operation
events | billing_web | nothing | `billing.cancel.intent`
(billing_client: sdk, current_tier: pro, cycle: yearly) |
| leaves the end of a cancel that already held to the operation events |
billing_web | nothing | `billing.cancel.intent` (billing_client: sdk,
current_tier: pro, cycle: yearly) |
| reports a request that never reached the server as a failed cancel
before any operation exists | billing_web | nothing |
`billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle:
yearly)<br>`billing.cancel.failed` (billing_client: sdk, current_tier:
pro, cycle: yearly, failure_category: network) |
| reports no subscription to cancel as a failed cancel before any
operation exists | billing_web | nothing | `billing.cancel.intent`
(billing_client: sdk, current_tier: pro, cycle:
yearly)<br>`billing.cancel.failed` (billing_client: sdk, current_tier:
pro, cycle: yearly, failure_category: api_rejected) |
| reports an earlier payment still open as a failed cancel before any
operation exists | billing_web | nothing | `billing.cancel.intent`
(billing_client: sdk, current_tier: pro, cycle:
yearly)<br>`billing.cancel.failed` (billing_client: sdk, current_tier:
pro, cycle: yearly, failure_category: api_rejected, error_code:
operation_already_pending) |

Captured RUM actions and PostHog events for eight cancel paths on
billing web show nothing on the FE-3115 base and intent, abandoned or
failed with tier, cycle and failure category on this branch
(evidence-fe3117-web-cancel/).

## Where this sits in the plan

Linear: [FE-3117](https://linear.app/comfyorg/issue/FE-3117), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | this PR |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](#19804), [PR
19806](#19806) and [PR
19807](#19807), merged
in [PR 19798](#19798)
|
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | [PR
19942](#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on
PostHog key scopes |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T7 stroke-width:3px
```

---------

Co-authored-by: GitHub Action <action@github.com>
dante01yoon added a commit that referenced this pull request Oct 3, 2026
…he cloud app and billing web (#19944)

## Summary

The cloud app and billing web report each trip to the Stripe portal as
billing.portal.opened, billing.portal.failed and
billing.portal.returned, with a bounded target of payment_methods,
invoices or manage_subscription.

## Why

Opening the Stripe portal, failing to open it and coming back were not
recorded on either host. A portal failure reached error reporting only,
so the Datadog Billing UI tab and the PostHog rollout dashboard could
not count it. What the customer does inside the portal (add, remove or
set a default card) never reaches the browser, so the trip itself is the
only signal we can have.

## How

A new contract module, portalEvent.ts, defines PortalBillingEvent
(operation portal, stages opened, failed and returned) and
BillingPortalTarget. It adds one line to the BillingTelemetryEvent
union, three names to BILLING_TELEMETRY_EVENTS and target to the payload
allowlist as a required field. On the cloud app,
createBillingPortalReporter reports the open, the failure (blocked tab
as redirect with payment_popup_blocked, other errors through
describeBillingFailure) and the first return to the tab, using the same
return signal as the billing refresh. Personal Manage subscription and
Invoice history call it with billing_client legacy and keep their
existing error toast and error report. Workspace Manage subscription
calls it with billing_client sdk or legacy depending on which rail
served the portal URL. On billing web, a usePaymentPortal composable now
owns opening the portal and the portal=return marker for both the
payment methods panel and the invoices page; it reports opened, failed
(network, api_rejected, or unknown for a malformed URL) and returned
once on landing. The invoices page's return URL now carries
portal=return and strips it on arrival. There is no user-visible change.

## Review Focus

- One return per open on the cloud app: only the latest open waits for a
return, through a module-level stop handle in billingPortalTelemetry.ts.
- Workspace Manage subscription reports billing_client only when it
knows which rail answered; a thrown failure omits it.
- useSubscription now calls accessBillingPortalDirect inside its own
error wrapper so it can classify the failure; the toast and reportError
behavior is unchanged.
- PaymentMethodsPanel and InvoicesView moved their portal logic into
usePaymentPortal; the invoices page now gets the portal=return marker
and strips it.
- Out of scope: the portal used for a plan change in PricingTable (its
operation events already cover it), the payment recovery portal in
useSubscriptionCheckout, and the hosted billing web tab that workspace
Manage subscription opens when hosted billing is on (that is
billing.web_handoff.opened).

## AS IS / TO BE

Captured through the real telemetry providers in the component and
composable tests (Datadog RUM action and PostHog event carry identical
payloads, `billing_surface` per host). AS IS = base branch, TO BE = this
branch.

| Path | Host | AS IS | TO BE |
| --- | --- | --- | --- |
| reports manageSubscription opening the portal and one return |
cloud_app | nothing | `billing.portal.opened` (target:
manage_subscription, billing_client:
legacy)<br>`billing.portal.returned` (target: manage_subscription,
billing_client: legacy) |
| reports handleInvoiceHistory opening the portal and one return |
cloud_app | nothing | `billing.portal.opened` (target: invoices,
billing_client: legacy)<br>`billing.portal.returned` (target: invoices,
billing_client: legacy) |
| reports manageSubscription as a failed open when the tab is blocked |
cloud_app | nothing | `billing.portal.failed` (target:
manage_subscription, billing_client: legacy, failure_category: redirect,
error_code: payment_popup_blocked) |
| reports handleInvoiceHistory as a failed open when the tab is blocked
| cloud_app | nothing | `billing.portal.failed` (target: invoices,
billing_client: legacy, failure_category: redirect, error_code:
payment_popup_blocked) |
| reports a refused portal request as a failed open and still reports
the error | cloud_app | nothing | `billing.portal.failed` (target:
manage_subscription, billing_client: legacy, failure_category:
api_rejected) |
| reports the portal opening from the SDK rail and one return |
cloud_app | nothing | `billing.portal.opened` (target:
manage_subscription, billing_client: sdk)<br>`billing.portal.returned`
(target: manage_subscription, billing_client: sdk) |
| reports the portal opening from the workspace client and one return |
cloud_app | nothing | `billing.portal.opened` (target:
manage_subscription, billing_client:
legacy)<br>`billing.portal.returned` (target: manage_subscription,
billing_client: legacy) |
| reports a blocked portal tab as a failed open | cloud_app | nothing |
`billing.portal.failed` (target: manage_subscription, failure_category:
redirect, error_code: payment_popup_blocked) |
| reports a refused portal request as a failed open | cloud_app |
nothing | `billing.portal.failed` (target: manage_subscription,
failure_category: api_rejected) |
| reports the portal opening on the invoices | billing_web | nothing |
`billing.portal.opened` (target: invoices, billing_client: sdk) |
| reports the portal opening on the payment methods | billing_web |
nothing | `billing.portal.opened` (target: payment_methods,
billing_client: sdk) |
| reports a portal it could not open as a failed open | billing_web |
nothing | `billing.portal.failed` (target: payment_methods,
billing_client: sdk, failure_category: api_rejected) |
| reports the return from the portal once and drops the marker |
billing_web | nothing | `billing.portal.returned` (target: invoices,
billing_client: sdk) |
| reports the return from the portal once | billing_web | nothing |
`billing.portal.returned` (target: payment_methods, billing_client: sdk)
|
| reports a request that never reached the server as a failed portal
open | billing_web | nothing | `billing.portal.failed` (target:
invoices, billing_client: sdk, failure_category: network) |
| reports a refusal from the server as a failed portal open |
billing_web | nothing | `billing.portal.failed` (target: invoices,
billing_client: sdk, failure_category: api_rejected) |
| reports a portal address that fails validation as a failed portal open
| billing_web | nothing | `billing.portal.failed` (target: invoices,
billing_client: sdk, failure_category: unknown) |

Captured RUM actions and PostHog events for each path on both hosts show
nothing on the FE-3115 base and the matching billing.portal.* event with
target, failure category and billing_surface on this branch
(evidence-fe3121/).

## Where this sits in the plan

Linear: [FE-3121](https://linear.app/comfyorg/issue/FE-3121), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](#19809), [PR
19810](#19810), [PR
19811](#19811), merged
|
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](#19804), [PR
19806](#19806) and [PR
19807](#19807), merged
in [PR 19798](#19798)
|
| T11 | FE-3121 | Portal events | this PR |
| T12 | FE-3122 | Flag coverage check | [PR
19942](#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on
PostHog key scopes |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T11 stroke-width:3px
```
dante01yoon added a commit that referenced this pull request Oct 3, 2026
…g screen (#19948)

## Summary

Report an abandoned checkout and the ending screen on the billing web
full-page checkout, and send the abandon to PostHog by beacon (E24,
E25).

## Why

customer_abandoned is the largest failure class on the backend, and the
browser had no event for a customer who closes the tab or goes back with
an unresolved checkout. The ending screen the customer saw was not
reported either, so a funnel could not tell a success screen from a
refusal.

## How

The shared journey contract gains two phases, billing.checkout.abandoned
(last_phase, exit) and billing.checkout.ended (ending_kind,
attribution), as union lines in checkoutJourney.ts with their payload
fields. They carry the journey context, so they join entered and
operation_linked on checkout_journey_id and billing_op_id.
useCheckoutJourney remembers the last progress phase, reports each new
ending kind once, and reports abandoned once, only before any ending.
The full-page checkout reports ended from its existing endingOf screen
and terminal attribution. It reports abandoned with exit page_exit on
pagehide, and with exit back from the Back control. It reports no
abandon when the page handed itself to a hosted step or a method's own
site. The billing web telemetry facade sends abandoned to PostHog with
transport sendBeacon. PostHog drains its queue on its own pagehide
listener, which runs before ours, so a plain capture there would be
queued and lost. There is no user-visible change.

## Review Focus

- Flush check: Datadog RUM 6.33 flushes by sendBeacon on
visibilitychange hidden, freeze and beforeunload. It has no pagehide
listener, but the browser fires visibilitychange after pagehide on
unload, so an action added in pagehide is sent. PostHog 1.402 drains by
beacon on pagehide, so only an event captured inside pagehide needs the
sendBeacon option.
- leftForPayment: a redirect to a hosted step or a non-card method's
site is a redirect_started, not an abandon.
- Existing journey tests now expect billing.checkout.ended after a
preview failure and after a success.
- Known gaps: the embedded billing web CheckoutView reports neither
phase. The cloud app reports no abandoned event, because its journey is
kept in session storage across dialogs and reloads, and whether a dialog
close ends it needs a product decision. A tab closed while already in
the background may not flush its RUM action, because visibilitychange
already fired; the derived count of starts without terminals covers it
(D8).

## AS IS / TO BE

Telemetry change, so the evidence is the captured events instead of a
screenshot: the real SDK lifecycle and the billing web checkout with
only the network edge and the telemetry SDKs (Datadog RUM, posthog-js)
stubbed. AS IS = origin/main, TO BE = this stack.

| Path | AS IS | TO BE |
| --- | --- | --- |
| E24 tab closed at the quote | `entered`, `preview_ready` | adds
`abandoned` (last_phase preview_ready, exit page_exit); PostHog copy
sent with `{transport: 'sendBeacon'}` |
| E24 Back control | `entered`, `preview_ready`, `web_return.clicked` |
adds `abandoned` (exit back), once, even though the page then unloads |
| E24 Alipay Pay leaving for its own site | no abandon | still no
abandon (it is a redirect) |
| E25 own payment succeeds | no ending event | `ended` (ending_kind
success, attribution started); no abandon when the tab closes after it |
| E25 refused workspace | no ending event | `ended` (ending_kind
refused), no attribution |

No payload carries an email, URL, client secret, promo code or provider
id; every new field is a bounded enum.

evidence-fe3119/as-is-billing-web.json shows the tab-close, Back,
success and refusal paths with no abandoned or ended event on main, and
to-be-billing-web.json shows abandoned with last_phase and exit to RUM
and to PostHog with transport sendBeacon, ended with ending_kind and
attribution, and no abandon for an Alipay Pay that left for its own
site.

## Where this sits in the plan

Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](#19809), [PR
19810](#19810), [PR
19811](#19811) merged,
billing web cancel [PR
19945](#19945) in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | this PR |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](#19804), [PR
19806](#19806) and [PR
19807](#19807), merged
in [PR 19798](#19798)
|
| T11 | FE-3121 | Portal events | [PR
19944](#19944), in
review |
| T12 | FE-3122 | Flag coverage check | [PR
19942](#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on
PostHog key scopes |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T9 stroke-width:3px
```
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…w in the cloud journey phases (Comfy-Org#19819)

## Summary

Part 1 of 3. Both billing web checkouts report the first two steps of
the checkout journey in the cloud app's phases:
`billing.checkout.entered`, then `preview_ready` or `preview_failed`.
Every event carries `billing_surface: 'billing_web'` and a `ui_mode` of
`embedded` or `full_page`.

## Why

Billing web sends no checkout funnel today. The cloud app and billing
web cannot be compared per surface, and the rollout cannot see how many
customers open the billing web checkout or how many get a quote. This
part adds the same entry and quote steps on both billing web checkouts,
including the quotes and capability reads that refuse a customer.

## Root cause

The `billing.checkout.<phase>` journey exists only in the cloud app's
emitters. The shared contract has no `full_page` UI mode and no bounded
way to say that a capability, a plan or a quote was refused. The billing
web facade only accepts `BillingTelemetryEvent`.

## How

- **Contract.** In `@comfyorg/account-core/billing`, `CheckoutUiMode`
gains `full_page`. `entered` carries an optional
`payment_intent_source`. `preview_failed` gains a bounded
`denial_reason` (the capability denial) and two checkout codes for
`error_code`, `quote_not_allowed` and `plan_unavailable`. The payload
builder forwards them. The cloud app's persisted-journey allowlist
accepts `full_page` (one line).
- **Facade.** `billingWebTelemetry.trackCheckoutJourneyEvent` sends a
journey phase to RUM and PostHog under its wire name, stamped
`billing_surface: 'billing_web'`. `trackBillingEvent` now shares the
same send path and behaves as before. The journey payload comes from the
contract's explicit builder, so no other field can pass.
- **Journey.** `useCheckoutJourney(uiMode)` owns the identity. The
journey id is the entry link's `correlation_id` and a fresh id only for
a link that carries none. `payment_intent_source` on `entered` is the
link's `source`. `entry_source` maps the link's source into the cloud's
coarse enum. `entry_flow` is the first quote's transition
(`initial_subscription` or `paid_upgrade`) and reads `unknown` on
`entered`. `assignment_status` is `unavailable`.
- **Embedded checkout.** `entered` fires at setup. Each plain quote
reports through `quotePlan`: an allowed quote is `preview_ready`, a
refused quote is `preview_failed` with `quote_not_allowed`, a failed
read is `preview_failed` with a category. Only the newest quote call
reports, so an answer the quote composable abandoned for a newer one
reports nothing.
- **Full-page checkout.** Every page event passes through one observer.
`quoted` is `preview_ready`. A refused capability, an unreadable
capability read, an unreadable quote, a refused quote and an unavailable
plan are `preview_failed`. `unavailable` and `capabilitiesFailed` events
now carry the HTTP status when the server answered.
- **Categories.** `REQUEST_FAILED` is `network` without an HTTP status
and `api_rejected` with one. `NOT_AUTHENTICATED`, `ACCESS_DENIED`,
`NOT_FOUND`, `CONFLICT`, `OPERATION_ALREADY_PENDING` and
`NO_ACTIVE_SUBSCRIPTION` are `api_rejected`. `INVALID_REQUEST` is
`validation`. Anything else is `unknown`.
- **Once per revision.** `preview_ready` fires once per accepted quote
revision (`quote_id:quote_version`), as in the cloud app.

## Review Focus

- FE-3140 (Comfy-Org#19798) is
merged into main (`a8337f39a4`); the base of this PR is main. This PR
carries all three parts of FE-3118: its own (E15 and E16, the entry and
the quote preview), part 2
(Comfy-Org#19821, E17 and E18)
and part 3 (Comfy-Org#19822,
E19 to E21 and the three account-ui components that forward the payment
method type), which were merged into this branch. It is a sibling of the
FE-3117 part 3
(Comfy-Org#19811) and FE-3115
(Comfy-Org#19815) PRs.
- `entry_source` vocabulary: billing web maps the link's 15 sources into
the cloud's coarse 7-value `entry_source` enum. `agent_paywall`,
`deep_link` and `settings_billing_panel` (as `settings_billing`) keep a
name, any other source is `other`, no source is `unknown`.
`payment_intent_source` on `entered` carries the full source, and it is
the field to split by. The cloud reports `pricing` for most
pricing-dialog entries, so cloud and billing web `entry_source` do not
match for the same journey until FE-3115 unifies the source
vocabularies. Widening `CheckoutEntrySource` here instead would break
the cloud's `satisfies Record` allowlist and collide with FE-3115.
- `entry_flow` is `unknown` on `entered`, because the flow is the
quote's and nothing is quoted yet. Join on `checkout_journey_id` to read
the flow of an entry.
- Journey identity is fixed when the view sets up. A reload sends
`entered` again under the same journey id, so count distinct journey
ids. A link change inside a reused checkout view keeps the first id. A
journey id minted for a link without `correlation_id` uses
`crypto.randomUUID()`, which the SDK already requires for its
idempotency keys.
- Likely overlap: the one-line `UI_MODES` change in
`src/platform/workspace/utils/checkoutJourney.ts` sits near the
entry-source work in FE-3115. A code-to-category mapper like
`failureCategoryOf` may also appear in FE-3117 for subscribe failures.
- `checkoutPage.ts` changes only two event types, which gain an optional
`httpStatus`. The reducer is untouched.
- The facade change is small but touches `trackBillingEvent`: its body
now calls the shared `send`. Its existing tests pass unchanged.
- Known gaps: the top-up checkout on billing web reports no journey.
Quotes the promo field requests are left to part 3.
- No user-visible change. Telemetry only.
- `UnifiedPricingTable.test.ts` ("prompts free-tier users to subscribe")
fails locally on `origin/main` too under Node 24. The timing-based tests
in `router.planless.test.ts`, `billingWebAuth.*` and
`operationLifecycle.test.ts` can time out on a loaded machine and pass
alone.
- Merged with the FE-3140 branch after FE-3117 landed there
(`0de5cf4218`). One conflict, in `CheckoutView.vue` `pay()`: the journey
hooks (`method_selected`, `submitted`) now run first and FE-3117's
attempt tracker wraps the `checkout.subscribe` call unchanged.
`CheckoutView.streams.test.ts` runs the embedded checkout over the real
SDK client with only the network and the RUM sink mocked and pins the
order of a successful Pay across the three families: `entered`,
`preview_ready`, `method_selected`, `submitted`, then
`subscription_checkout.intent` and `.started`,
`billing.operation.started`, `operation_linked`,
`billing.operation.succeeded` and `subscription_checkout.succeeded`,
with the four events after the issue sharing one `billing_op_id`.
- Review fixes after CodeRabbit (`192c751f28`, red tests first): a Pay
refused with `OPERATION_ALREADY_PENDING` or `CONFLICT`, or whose command
rejects, no longer lets a later recovered operation be reported as
`operation_linked` (the journey's wait is cleared per press when its
command settles, in both Pay handlers); `preview_failed` takes its
`failure_category` from the attempt's mapper, so one refusal has one
category in the journey and the attempt funnels (`NOT_AUTHENTICATED`
without a status is `network` in both); and the negative tests wait on
positive signals instead of a timer.

## AS IS / TO BE

AS IS: ![AS IS at ce06a6f: 0 of 18 scenarios on contract. Across 63
runs of the real embedded checkout CheckoutView and full-page checkout
FullPageCheckoutView, billing web telemetry receives no checkout journey
event, with RUM addAction 0 calls and PostHog capture 0 calls, for a
quote that loads, a refused quote, a quote read that fails as no answer,
HTTP 503, ACCESS_DENIED, INVALID_REQUEST or MALFORMED_RESPONSE, a
capability denied for each of 7 reasons, a capability read that fails, a
retired plan, a team plan without its stop, a link with and without a
source and a journey id, each of the 15 link sources, and an abandoned
quote; the new tests of this PR run against this commit fail, with
apps/billing-web at 1093 of 1111 passing (18 failing in 3 files,
checkoutJourney.test.ts fails to load) and account-core src/core/billing
at 601 of
603](https://github.com/user-attachments/assets/967f5a49-5411-40d8-a39f-184bd4697e07)

TO BE: ![TO BE at f34408a: 18 of 18 scenarios on contract. The same
63 runs send billing.checkout.entered and then preview_ready or
preview_failed to RUM and PostHog with identical payloads, 250 payloads
and 2460 fields all inside the contract vocabulary: ui_mode embedded or
full_page, billing_surface billing_web, one journey id per run taken
from the link correlation_id or a fresh uuid, entry_source
agent_paywall, deep_link or settings_billing for those 3 of the 15 link
sources with other for the rest and unknown for no source or an unlisted
one while payment_intent_source carries the full source, preview_failed
with failure_category network, api_rejected, validation or unknown by
the read that failed, quote_not_allowed, plan_unavailable for a retired
plan and for a team plan without its stop, and the bounded denial_reason
for all 7 denials; an abandoned quote that answers REQUEST_FAILED after
the checkout moved on, and one that answers SUPERSEDED, report no
preview_failed, and no email, URL, secret or server message planted in
the stubbed answers reaches any payload; apps/billing-web passes 1147 of
1147 and account-core src/core/billing 603 of
603](https://github.com/user-attachments/assets/31b3c5a3-6e40-439e-9139-82bf45db53e0)

The evidence is the `billing.checkout.*` actions RUM receives for an
embedded and a full-page checkout (a quote that loads, a refused quote
and a denied capability), which are absent before and present after.

## Where this sits in the plan

Linear: [FE-3118](https://linear.app/comfyorg/issue/FE-3118), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815), [PR
19816](Comfy-Org#19816), [PR
19817](Comfy-Org#19817), [PR
19818](Comfy-Org#19818), in
review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | parts 1 and 2 merged
([PR 19809](Comfy-Org#19809),
[PR 19810](Comfy-Org#19810), in
[PR 19798](Comfy-Org#19798)),
[PR 19811](Comfy-Org#19811) in
review |
| T8 | FE-3118 | Billing web journey and choices | this PR |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | todo |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T8 stroke-width:3px
```

---------

Co-authored-by: GitHub Action <action@github.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…g#19811)

## Summary

Billing web reports the resubscribe lifecycle from the subscription
screen: `billing.resubscribe.started` before the request and one
`billing.resubscribe.succeeded` or `.failed`, with `source:
'billing_web_subscription'`. This is the third of three stacked branches
for FE-3117 and delivers E13. It reuses the attempt tracker from the
branch that delivers E10 and E11.

## Why

The SDK reports a resubscribe as a plain `subscription` operation, so
the operation stream cannot tell a resubscribe from a new subscription
or a plan change. The cloud app reports `billing.resubscribe.*` from its
callers. Billing web reported nothing, so a resubscribe, a plan that was
already active and a refusal before any operation were all invisible.

## Root cause

The resubscribe button on billing web called `checkout.resubscribe()`
with no emitter, and the `resubscribe` event type had no operation id,
no duration and no billing web source.

## How

- **Events.** `resubscribeTelemetry.ts` builds the events on the same
`createAttemptTelemetry` and result mapping as the checkout. The start
is reported immediately before `checkout.resubscribe()`. The terminal
carries `billing_op_id` once one exists, `duration_ms`, and for a
decline its `decline_reason`. A plan that was already active (the SDK's
already-held answer, which issues nothing) counts as succeeded and has
no operation id. `payment_intent_source` is the entry source when the
customer arrived with one.
- **Wiring.** `SubscriptionActions.vue` wraps its one
`checkout.resubscribe()` call. Cancel is unchanged.
- **Contract.** `ResubscribeBillingEvent` gains `billing_op_id`,
`duration_ms` and `decline_reason` on its failed variant, all optional,
so the cloud's events are unchanged. `ResubscribeSource` gains
`billing_web_subscription`.
- **README.** A short paragraph in the Telemetry section.

## Review Focus

- FE-3140 (Comfy-Org#19798) is
merged into main (`a8337f39a4`), and with it FE-3120's three parts
(Comfy-Org#19804,
Comfy-Org#19806,
Comfy-Org#19807) and FE-3117's
parts 1 and 2 (Comfy-Org#19809,
Comfy-Org#19810). The base of
this PR is main. Review only part 3's own change (E13, the resubscribe
lifecycle, 9 files against main). This branch also carries one automated
formatting commit.
- The new `source` value is `billing_web_subscription`. The catalog says
only "billing web value". The cloud names its two values after its own
screens (`pricing_dialog`, `settings_billing_panel`), so I named this
one after billing web's subscription screen. It is a one-line change in
`vocabulary.ts` if you prefer another name.
- `billing_client: 'sdk'` is stamped, as on the checkout events, because
billing web has no legacy path.
- A resubscribe that needs a hosted payment step redirects this tab, so
the page unloads and no terminal is sent. That start is the abandoned
case of FE-3119. A recovered operation after the return reports only the
SDK stream, never `billing.resubscribe.*`, as the SSOT requires.
- There is no continuation state for resubscribe: the SDK never asks for
the reactivation consent on this command.
- The SDK stream still reports the same resubscribe as
`billing.operation.*` with `operation_type: 'subscription'`. Join the
two by `billing_op_id`. They are two signals of one attempt, not two
attempts.
- E14 (billing web cancel intent, abandoned and failed) is not built.
FE-3115 defines the cancel event contract first, so E14 follows it.
Billing web's cancel today reports only the SDK stream. A test pins that
a cancel emits no `billing.resubscribe.*` event.
- Known gap: billing web rebuilds its return links without `source`, so
a resubscribe that returns from a provider page cannot carry the entry
source. It reports no business event there anyway.
- No user-visible change. Billing web sends new RUM actions and PostHog
events and nothing else changes.
- `UnifiedPricingTable.test.ts` ("prompts free-tier users to subscribe")
fails locally on `origin/main` too under Node 24. This diff does not
touch it.

## AS IS / TO BE

AS IS: ![AS IS at 96c1f28 with this PR's new tests copied in: 6 of 8
scenarios off contract. A resubscribe from the subscription screen
reports only the SDK stream when an operation is issued
(billing.operation.started, then succeeded or failed) and nothing at all
for an already-active plan, a 503, a network failure and an operation
already pending, so no billing.resubscribe event exists; a cancel
already reports only the SDK stream with operation_type cancel, and no
payload holds the planted server text; the new tests fail as expected
(resubscribeTelemetry.test.ts and billingWebClient.test.ts fail to load,
4 SubscriptionView tests red): apps/billing-web passes 1085 of 1089 and
account-core src/core/billing 600 of
600](https://github.com/user-attachments/assets/c0a3a848-c518-41d5-8030-16830933a9a5)

TO BE: ![TO BE at 8abe6fe: 8 of 8 scenarios on contract. A
resubscribe reports billing.resubscribe.started before the request and
then exactly one .succeeded or .failed with source
billing_web_subscription, billing_client sdk and the entry source: a
settled operation and a decline join the SDK stream through the same
billing_op_id (the decline adds provider_decline and card_declined), an
already-active plan counts as succeeded with no operation id and no SDK
events, and a 503, a network failure and an operation already pending
end with api_rejected, network and operation_already_pending; a cancel
emits only the SDK stream with operation_type cancel and no
billing.resubscribe event; the planted server messages, codes, email,
URL and secret appear in none of 36 payloads; apps/billing-web passes
1111 of 1111 and account-core src/core/billing 600 of
600](https://github.com/user-attachments/assets/93bd4c48-5b6b-46ab-b338-80accbda64f9)

The evidence is the RUM actions billing web sends when a customer
resubscribes from the subscription screen and the request settles, is a
plan that was already active, is declined, or is refused before an
operation exists: before, none; after, `billing.resubscribe.started` and
one terminal with `billing_client: 'sdk'` and the billing web source.

## Where this sits in the plan

Linear: [FE-3117](https://linear.app/comfyorg/issue/FE-3117), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815), [PR
19816](Comfy-Org#19816), [PR
19817](Comfy-Org#19817), [PR
19818](Comfy-Org#19818), in
review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | this PR |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819), [PR
19821](Comfy-Org#19821), [PR
19822](Comfy-Org#19822), in
review |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | todo |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T7 stroke-width:3px
```

---------

Co-authored-by: GitHub Action <action@github.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
… events (Comfy-Org#19943)

## Summary

Cloud app checkout journey events (billing.checkout.*) now carry
billing_surface: 'cloud_app' in Datadog RUM and PostHog.

## Why

Decision T1 says every billing event carries billing_surface. On the
cloud app the billing.<operation>.<stage> events already did, but the
checkout journey events did not. Billing web stamps billing_web on the
same journey events, so the Datadog tiles (FE-3124) that group by
@context.billing_surface showed cloud journey traffic with no surface.

## Root cause

getCheckoutJourneyTelemetryEventPayload builds the journey payload with
no surface. The cloud Datadog RUM and PostHog providers sent it as is.
Billing web adds the surface itself inside trackCheckoutJourneyEvent, so
only billing web output had it.

## How

A new getCloudAppCheckoutJourneyTelemetryEventPayload in
packages/account-core/src/core/billing/telemetry/checkoutJourney.ts
wraps the existing builder and adds billing_surface: 'cloud_app'. It
mirrors getCloudAppBillingTelemetryEventPayload. Both cloud sinks that
receive journey events (DatadogRumTelemetryProvider and
PostHogTelemetryProvider) call it in trackCheckoutJourneyEvent. The
shared builder and billing web are untouched.

## Review Focus

- Only one field is added. Event names and every existing field value
are unchanged (see the AS IS vs TO BE diff in the evidence).
- Billing web output does not change. It still stamps billing_web itself
on top of the unstamped shared builder.
- Datadog RUM and PostHog are the only providers that implement
trackCheckoutJourneyEvent, so no other sink needs the stamp.

## AS IS / TO BE

Telemetry payload change, so the evidence is the captured event rather
than a screenshot. One `billing.checkout.entered` sent through the real
cloud Datadog RUM and PostHog providers, origin/main (AS IS) vs this
branch (TO BE):

```diff
23c23,24
<       "payment_intent_source": "subscribe_to_run"
---
>       "payment_intent_source": "subscribe_to_run",
>       "billing_surface": "cloud_app"
37c38,39
<       "payment_intent_source": "subscribe_to_run"
---
>       "payment_intent_source": "subscribe_to_run",
>       "billing_surface": "cloud_app"
```

Captured payloads for one billing.checkout.entered event through the
real cloud Datadog RUM and PostHog providers show billing_surface
missing on origin/main and billing_surface: 'cloud_app' on the branch,
with all other fields identical (evidence-fe3111-journey-surface/).

## Where this sits in the plan

Linear: [FE-3111](https://linear.app/comfyorg/issue/FE-3111), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | this PR
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811), merged
|
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style F3 stroke-width:3px
```
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
Comfy-Org#19941)

## Summary

Billing web: Retry session after the shared session fails to create now
retries the creation. A remembered login whose restore keeps failing no
longer leaves the sign-in screen unsettled.

## Why

In shared-web-session mode a 503 on POST /auth/session left the customer
on a Retry session button that could never succeed. With a remembered
Firebase user and a failing restore, the sign-in screen showed 'Sign-in
is unavailable' with every button disabled, so the customer had no way
forward until the endpoint recovered.

## Root cause

Two gaps in unifiedBillingSession.ts. First, establish() with no user
only re-resolved the workspace. That answers NOT_AUTHENTICATED without a
request when the shared session does not exist. The controller's retry
always calls establish() with no user, so the failed creation was never
retried. Second, settledOf() treated the identity's retry_wait phase as
not settled. A restore that keeps failing loops through retry_wait,
reading and restoring, so settledPhase() never resolved, loadIdentity()
never loaded Firebase, and the sign-in page showed the unavailable
notice.

## How

establish() now picks who to create the session for: the passed user,
or, when there is no signed-in shared session, the user Firebase
currently holds. With such a user it re-mints the ID token and POSTs the
session again, then reboots the identity as the interactive path already
did. With no Firebase user it still answers NOT_AUTHENTICATED without a
request, and the sign-in form stays the way forward. settledOf() maps
retry_wait to signed-out, so the sign-in screen settles and renders the
form while the identity keeps retrying in the background. A later
successful restore still carries the customer off the page.

## Review Focus

- retry_wait now reads as signed-out. The router sends such a visit to
sign-in, and the once-per-tab signin_required event reports reason
no_session for it. A transient GET /auth/session failure on a live
session also shows the form until the next retry succeeds (1s, then
backoff).
- establish() with no user now loads Firebase when the shared session is
not signed in. When it is signed in (a restored session, or a retry
after a workspace refusal) the behavior is unchanged.
- After the fix, billing.web_session.failed with error_code
NOT_AUTHENTICATED stops appearing for the retry path. A failed retry
reports TOKEN_EXCHANGE_FAILED instead.
- In the remembered-login case the screen shows the sign-in form, not a
Retry session button. Signing in again or waiting for the background
retry both recover.

## AS IS / TO BE

**A. Interactive sign-in, POST /auth/session 503, then Retry session**

| AS IS | TO BE |
| --- | --- |
| <img width="420" alt="AS IS: Retry session after 503"
src="https://github.com/user-attachments/assets/b7acf55a-fcd5-4610-a6f9-64c75d6d9606"
/> | <img width="420" alt="TO BE: Retry session after 503"
src="https://github.com/user-attachments/assets/9f8831d3-1cf1-474a-bae3-cdbfbbfaa007"
/> |
| Retry session sends no request; the same error stays. | Retry session
re-mints the token, POST answers 200, the page leaves sign-in. |

Both builds start from the same screen after the 503:
[A1](https://github.com/user-attachments/assets/f163f436-92c7-4cda-9d22-a1371dff9e89).

**B. Remembered user, session restore keeps answering 503**

| AS IS | TO BE |
| --- | --- |
| <img width="420" alt="AS IS: remembered user with failing restore"
src="https://github.com/user-attachments/assets/7379aa7c-bc2e-45bd-b34c-aa114a0ca7da"
/> | <img width="420" alt="TO BE: remembered user with failing restore"
src="https://github.com/user-attachments/assets/05b8bc35-1793-4f68-b9cf-2d192cce36ca"
/> |
| 'Sign-in is unavailable' with every button disabled; the phase never
settles. | The sign-in form renders and works; the restore keeps
retrying in the background. |

Once the endpoint answers 200, both builds restore the session and leave
sign-in.

**C. Control (no outage)**

| AS IS | TO BE |
| --- | --- |
| <img width="420" alt="AS IS: control"
src="https://github.com/user-attachments/assets/9f8831d3-1cf1-474a-bae3-cdbfbbfaa007"
/> | <img width="420" alt="TO BE: control"
src="https://github.com/user-attachments/assets/9f8831d3-1cf1-474a-bae3-cdbfbbfaa007"
/> |
| Sign-in succeeds and leaves sign-in. | Identical. |

Playwright against a local production build with the session endpoint
stubbed to 503 then 200 shows AS IS stuck on Retry session and on a
disabled sign-in screen, and TO BE recovering in both paths
(evidence-fe3158/).

## Where this sits in the plan

Linear: [FE-3158](https://linear.app/comfyorg/issue/FE-3158), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811), merged
|
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
this PR |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
```
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…count-core (Comfy-Org#19940)

## Summary

Move the three billing payload-helper test suites from
src/platform/telemetry into
packages/account-core/src/core/billing/telemetry, next to the code they
test. There is no user-visible change and no source change.

## Why

FE-3140 moved the billing event contract and payload helpers into
@comfyorg/account-core/billing. Three suites stayed in the app folder.
They tested no code in that folder, imported the package through its
public entry, and partly repeated cases the package already had.

## How

billingTelemetryEvent.test.ts (app) splits in two. The late-success type
test becomes account-core billingTelemetryEvent.test.ts. The
getBillingTelemetryEventPayload cases join payload.test.ts.
checkoutJourneyEvent.test.ts joins checkoutJourney.test.ts.
webHandoffEvent.test.ts moves as is. Imports are now package-relative.
es-toolkit pick, which account-core does not depend on, becomes an
own-key filter with the same semantics (an absent key stays absent, so
toStrictEqual still tells absent from undefined). Two cases are dropped
because existing account-core cases already prove them: the cloud-app
surface claim (identical to the cloud app row of the SURFACES table in
payload.test.ts) and 'omits assigned_arm when assignment is unavailable'
(every unavailable row in checkoutJourney.test.ts asserts the whole
payload with toStrictEqual). Every other assertion moved unchanged.

## Review Focus

- The two dropped cases really are covered by payload.test.ts
SURFACES[cloud app] and the checkoutJourney.test.ts strict payload
table.
- The Object.entries filter that replaces es-toolkit pick keeps the
absent versus undefined distinction.
- The late-success expectTypeOf test is still type-checked: account-core
tsconfig includes src/**/*, and typecheck:account-core passed in the
pre-commit hook.

## AS IS / TO BE

Test-only change, so the evidence is the test run instead of a
screenshot.

| Suite | AS IS | TO BE |
| --- | --- | --- |
| src/platform/telemetry billing helper suites (3 files) | 37 | 0
(moved) |
| account-core billing/telemetry | 30 | 65 |
| Total helper tests | 67 | 65 (2 exact duplicates dropped) |
| Remaining src/platform/telemetry | 567 | 567, all pass |

Before, 37 helper tests ran in the app suite and 30 in account-core
(67). After, account-core runs 65 and all pass, the remaining
src/platform/telemetry suite runs 567 and all pass, and the only
difference is the 2 duplicate cases named in how.

## Where this sits in the plan

Linear: [FE-3162](https://linear.app/comfyorg/issue/FE-3162), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811), merged
|
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | todo |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | todo |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | this
PR |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
todo |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
```
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…ads feature flags (Comfy-Org#19942)

## Summary

Billing web sends its billing events to PostHog only after PostHog has
loaded the feature flags, so every event carries the rollout flags the
cohort tiles split on.

## Why

The rollout dashboard splits billing events by $feature/<flag>. PostHog
adds those properties only from the flags it has already loaded on that
origin. Billing web flushed the events it queued at boot right after
init, before the flags request answered, and a first visit to
billing.comfy.org has no cached flags. Its entry, session and first
journey events would reach PostHog without any flag, so the cohort split
and the second sign-in tile by unified_web_session would miss them.

## Root cause

startPostHog marked the sink ready and flushed the waiting queue as soon
as posthog.init returned. Flags load asynchronously after init and are
stored per origin, so the flushed events had no $feature/* properties.

## How

startPostHog now waits for PostHog's first onFeatureFlags callback
before it marks the sink ready and flushes. The wait is bounded at 3
seconds, so a slow or blocked flags request delays events but never
drops them. Events tracked during the wait stay in the existing bounded
queue. The README notes the wait. There is no user-visible change.

## Review Focus

- The 3 second bound: long enough for the flags request, short enough
that a tab closed early still sends.
- Events tracked while waiting use the existing queue of at most 50
events.
- The test fake makes onFeatureFlags call back at once by default, as
posthog-js does when flags are already loaded.

## AS IS / TO BE

AS IS: placeholder, to be attached by editing this description.

TO BE: placeholder, to be attached by editing this description.

PostHog has no billing web events yet because the deployed billing web
builds predate the PostHog sink, so the evidence is the red then green
unit test plus the cloud coverage queries in t12-flag-coverage.md; AS IS
/ TO BE payload capture needs a billing web deploy from this branch.

## Where this sits in the plan

Linear: [FE-3122](https://linear.app/comfyorg/issue/FE-3122), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811), merged
|
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | todo |
| T12 | FE-3122 | Flag coverage check | this PR |
| T13 | FE-3123 | PostHog rollout dashboard | todo |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T12 stroke-width:3px
```
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…nside a billing operation (Comfy-Org#19946)

## Summary

Report 3DS challenges and retryable declines inside one billing
operation, from the SDK lifecycle, on the cloud app and billing web
(E22).

## Why

The backend files most failed subscribes as customer_abandoned or
expected payment failures, and the browser reported none of the friction
behind them. The SDK already tracked the challenge, but the driver's
verdict was thrown away and a retryable decline left no trace until the
operation ended.

## Root cause

usePaymentAttempt and the cloud SDK store call driveEmbeddedChallenge
with void, and the lifecycle only emitted billing.operation.* for start
and terminal. A pending operation could move through a challenge, its
verdict and several declines without one event.

## How

A new contract module checkoutChallengeEvent.ts adds
billing.checkout.challenge_required, challenge_completed and
challenge_failed to the BillingTelemetryEvent union (one line). All
stages stay pending, so they never count as terminals. A pure function
paymentFrictionBetween compares two states of one pending operation, and
the lifecycle runs it on every transition and at adoption.
challenge_required fires once per new client secret. challenge_completed
and challenge_failed fire on this tab's driver verdict. Each new
retryable decline reason fires challenge_failed with decline_reason,
except the server's echo of a challenge this tab already saw fail.
toBillingTelemetryEvent maps the three onto operation checkout. Billing
web forwards them through the existing onTelemetry wiring. The cloud
store forwards them for every operation, including an issued top-up
whose start and terminal the dialog reports. Fields are decline_reason,
presentation, operation_type, billing_op_id and resumed, all already in
the allowlist. There is no user-visible change.

## Review Focus

- paymentFrictionBetween: one required per client secret, no second
required when a failed challenge returns from the hosted page, and the
echo rule for a decline after a failed challenge.
- The cloud reportTelemetry change: friction events skip the top-up and
caller-started filters on purpose.
- challenge_failed carries decline_reason only for a server decline.
Without it, it is this tab's own verdict.
- Known gap: the legacy cloud rail (billingOperationStore and the legacy
subscribe path) reports no friction. Only the SDK rail does.

## AS IS / TO BE

Telemetry change, so the evidence is the captured events instead of a
screenshot: the real SDK lifecycle and the billing web checkout with
only the network edge and the telemetry SDKs (Datadog RUM, posthog-js)
stubbed. AS IS = origin/main, TO BE = this stack.

| Path | AS IS | TO BE |
| --- | --- | --- |
| E22 embedded 3DS challenge completed / failed |
`billing.operation.started` only | adds
`billing.checkout.challenge_required`, then `challenge_completed` or
`challenge_failed` (presentation embedded) |
| E22 retryable declines in one hosted operation |
`billing.operation.started` only | `challenge_failed` with
`decline_reason: card_declined`, then `insufficient_funds` (presentation
hosted) |
| E22 billing web SDK, real client | `billing.operation.started` only |
adds `challenge_failed` with `decline_reason`, to RUM and PostHog,
`billing_surface: billing_web` |

No payload carries an email, URL, client secret, promo code or provider
id; every new field is a bounded enum.

evidence-fe3119/as-is-lifecycle.json and to-be-lifecycle.json show the
same embedded challenge and hosted decline scenarios emitting only
billing.operation.started on main and the challenge events with
presentation and decline_reason on the branch, for both cloud_app and
billing_web payloads, and to-be-billing-web.json shows the billing web
SDK sending challenge_failed with decline_reason to RUM and PostHog.

## Where this sits in the plan

Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811) merged,
billing web cancel [PR
19945](Comfy-Org#19945) in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | this PR |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | [PR
19944](Comfy-Org#19944), in
review |
| T12 | FE-3122 | Flag coverage check | [PR
19942](Comfy-Org#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on
PostHog key scopes |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T9 stroke-width:3px
```
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…p amount and the cancel flow as billing events (Comfy-Org#19815)

## Summary

Cloud entry fidelity and Datadog parity, in five parts reviewed
together: paywall impressions and add-credits clicks as typed billing
entry events that reach Datadog, the entry source carried through
top-up, downgrade and recovered operations with one source vocabulary,
the amount and preset on `billing.topup.started`, and the cancel flow as
`billing.cancel.intent`, `.abandoned` and `.failed` through a
surface-free contract that billing web reuses, and each trip to the
Stripe portal as `billing.portal.opened`, `.failed` and `.returned` on
the cloud app and billing web.

## Why

PostHog, Mixpanel and GTM receive the paywall impression and the
add-credits click. Datadog receives neither, so the Billing UX board
cannot show where a billing attempt started. Three entries emit nothing
anywhere: the inactive-member dialog, the out-of-credits banner and the
credits precondition. Five add-credits entries opened the top-up dialog
with no source, so `billing.entry.add_credits_clicked` and
`billing.topup.started` could not say where the customer came from. The
downgrade events carried no source at all. After a reload the poller and
the SDK lifecycle report a terminal for an operation they did not start,
and the checkout journey keeps only a collapsed `entry_source`, so those
terminals lost the source. Datadog receives top-up starts but not what
was bought. PostHog, Mixpanel and GTM get the amount from the legacy
purchase-click event only. Funnels by amount and by preset need the
amount on the canonical start. The cancel flow stages reach PostHog and
the desktop sink only. Datadog cannot show how many customers open the
cancel flow, how many leave it, or where it breaks. The cancel request
itself is already reported as `billing.operation.*` with
`operation_type: cancel`. Opening the Stripe portal, failing to open it
and coming back were not recorded on either host. A portal failure
reached error reporting only, and what the customer does inside the
portal never reaches the browser, so the trip itself is the only signal.

## Root cause

(1) `DatadogRumTelemetryProvider` implements only the typed
`trackBillingEvent`, and the paywall and add-credits trackers are legacy
methods it never had. There was no typed event for either, and three
entries never called a tracker. (2) `showTopUpCreditsDialog()` was
called without options from the popover, the tile, the settings panel
and the deep link. `useDowngradeToPersonal` had no source parameter. The
checkout journey record stored `entry_source` (`pricing`,
`settings_billing` or `agent_paywall`) and nothing finer, and no emitter
read it back for a recovered operation. (3) `billing.topup.started`
carried only the entry source. The dialogs know the amount and which
preset button was picked, but neither field had a place in the billing
event contract. (4) The legacy `trackSubscriptionCancellation` stages
(`flow_opened`, `abandoned`, `failed`) have no typed counterpart, and
the stage `abandoned` was not part of the billing vocabulary. (5) No
event existed for the portal: `accessBillingPortal` and the billing web
portal views opened Stripe and swallowed or reported the result without
a billing event.

## How

**Part 1, entry events (was Comfy-Org#19815)**

- **Contract.** A new `entryEvent.ts` in
`packages/account-core/src/core/billing/telemetry` defines operation
`entry` with stages `paywall_shown` and `add_credits_clicked`, outcome
`pending`. `paywall_shown` carries `current_tier` (bounded: the five
tier keys plus `team`). Both carry the optional `payment_intent_source`.
One line in the `BillingTelemetryEvent` union, one allowlist field
(`current_tier`), two names in `BILLING_TELEMETRY_EVENTS`.
- **E1.** `useSubscriptionDialog` reports `paywall_shown` for every
pricing dialog variant and for the inactive-member dialog. The source is
the one the dialog already hands to checkout (`paymentIntentSource ??
reason`).
- **E2.** `dialogService.showTopUpCreditsDialog` reports
`add_credits_clicked` on its first line, before the capability read. The
source is `options.source`, or `out_of_credits` when the caller says
`isInsufficientCredits`. This covers every entry that opens the top-up
dialog, including the banner and the credits precondition.
- **Datadog parity.** The provider needed no change: both events go
through `trackBillingEvent`, so Datadog builds the action and payload
from the shared builder and stamps `billing_surface: cloud_app`. PostHog
and the desktop sink receive the same events through the same method.
- **Legacy events.** `trackSubscription('modal_opened')`,
`trackAddApiCreditButtonClicked` and their sinks are untouched. A test
with a legacy provider beside the Datadog provider proves the paywall
legacy event still arrives once.

**Part 2, source fidelity (Comfy-Org#19816, merged here)**

- **Mapping.** `src/platform/telemetry/utils/paymentIntentSource.ts`
holds two tables. The click-time source maps to the list:
`credits_panel` and `settings_billing_panel` to
`settings_billing_panel`, `avatar_menu` to `avatar_menu_plans`,
`deep_link` and `agent_paywall` to themselves. The journey
`entry_source` maps to the list where it names a control: `deep_link`,
`settings_billing` (to `settings_billing_panel`) and `agent_paywall`.
`pricing`, `recovery`, `other` and `unknown` name no source.
`payment_intent_source` is the list itself. An `it.for` table covers all
three.
- **Entries.** The two popovers pass `avatar_menu_plans`, the credits
tile and the settings panel pass `settings_billing_panel`, the deep link
passes `deep_link`. The legacy `trackAddApiCreditButtonClicked` calls
are untouched. `dialogService` now forwards the options to both rails.
The legacy top-up dialog declares `source` and reports it on
`billing.topup.started` and `failed`.
- **Downgrade.** `DowngradeToPersonalBillingEvent` gains
`payment_intent_source`. The subscription checkout passes its source to
`showDowngradeToPersonalDialog`, which hands it to
`useDowngradeToPersonal`. All nine events of an attempt carry it (the
downgrade, the nested subscription checkout and the nested operation),
and so does the metadata the poller adopts for a payment that settles
later.
- **Recovered terminals.** The checkout journey record keeps
`payment_intent_source` next to `entry_source` (stored only; the emitted
journey events and `entry_source` do not change).
`getCheckoutJourneyPaymentIntentSource(opId)` returns it for the journey
bound to that operation, and falls back to the mapped `entry_source` for
a record written before this change. The poller reads it when it adopts
an operation with no metadata, and the SDK store attaches it to the
lifecycle events of an operation bound to a journey.

**Part 3, top-up amount and preset (Comfy-Org#19817, merged here)**

- **Contract.** `topupEvent.ts` gains `TOPUP_AMOUNT_PRESETS_USD` (10,
25, 50, 100), the `TopupAmountPreset` type (the four values as strings,
or `custom`) and `getTopupAmountPreset`. The started stage gains
optional `amount_cents` and `amount_preset`. Both are allowlist fields,
bounded: an integer and a fixed enum, nothing free-form.
- **Emitters.** The workspace dialog and the legacy dialog report both
fields on the start event. The preset is the button the customer picked.
Any typed amount is `custom`, including a typed amount that equals a
preset. The workspace dialog computes the cents once and uses the same
value for the API call.
- **One list of presets.** Both dialogs now read the preset amounts from
`TOPUP_AMOUNT_PRESETS_USD` instead of each keeping its own `[10, 25, 50,
100]`, so the telemetry enum and the buttons cannot drift.
- **Datadog.** A test drives the real dialog through the real registry
and the Datadog provider and checks the `billing.topup.started` action
with the amount, the preset, the source and `billing_surface:
cloud_app`.

**Part 4, cancel flow (Comfy-Org#19818, merged here)**

- **Contract.** `cancelEvent.ts` defines operation `cancel` with stages
`intent` and `failed` (the shared stage types) and the new `abandoned`
(outcome `pending`: the customer left, no operation outcome is claimed).
It carries only `current_tier` and `cycle`, both plan facts that exist
on any surface, and no surface-specific field. One union line and three
names. No new allowlist field.
- **Plan facts.** `toCurrentTier` moved from `useSubscriptionDialog` to
`billingPlanTelemetry.ts` and gained `toBillingCycle`, with a table
test. `createCancelFlowReporter` in
`subscriptionCancellationTelemetry.ts` builds the events for both flows,
so the ownership rule below lives in one place.
- **Ownership.** The reporter emits `intent` where the legacy
`flow_opened` fires. It emits `abandoned` where the legacy `abandoned`
fires, unless the customer already confirmed. When the confirmed cancel
becomes an operation (the workspace rail), its `billing.operation.*`
events own the end of the attempt, so the reporter emits no `failed`
either. `failed` is reported only for a flow that ends with no
operation: the legacy-rail dialog when its cancel fails, and a provider
failure whose native dialog cannot open (category `rendering`).
`useWorkspaceBilling.cancelSubscription` is unchanged.
- **Flows covered.** The provider (Churnkey) flow in
`launchCancellationFlow` and the native
`CancelSubscriptionDialogContent`, which also carries the attempt on
after a provider failure (`flowAlreadyOpened`).
- **Tests.** Table-driven through the real flows with the telemetry sink
recording: each row's expected cancel events are literal, and a Datadog
row shows the billing actions with `billing_surface: cloud_app`.

**Part 5, portal events (Comfy-Org#19944, merged here)**

- **Contract.** `portalEvent.ts` in
`packages/account-core/src/core/billing/telemetry` defines operation
`portal` with stages `opened`, `failed` and `returned`, and
`BillingPortalTarget` (`payment_methods`, `invoices`,
`manage_subscription`). One line in the `BillingTelemetryEvent` union,
three names in `BILLING_TELEMETRY_EVENTS`, and `target` as a required
allowlist field.
- **Cloud app.** `createBillingPortalReporter` reports the open, the
failure (a blocked tab as `redirect` with `payment_popup_blocked`, other
errors through `describeBillingFailure`) and the first return to the
tab, on the same return signal as the billing refresh. Only the latest
open waits for a return. Personal Manage subscription and Invoice
history report `billing_client: legacy`; workspace Manage subscription
reports the rail that answered and omits `billing_client` on a thrown
failure.
- **Billing web.** `usePaymentPortal` holds the portal logic of
`PaymentMethodsPanel` and `InvoicesView`. The invoices page now gets the
`portal=return` marker and strips it.
- **Out of scope.** The plan-change portal in `PricingTable` (its
operation events cover it), the payment recovery portal in
`useSubscriptionCheckout`, and the hosted billing web tab that workspace
Manage subscription opens (that is `billing.web_handoff.opened`).

## Review Focus

- FE-3140 (Comfy-Org#19798) is
merged into main (`a8337f39a4`) and the base of this PR is main. Five
parts in one PR: they were opened as
Comfy-Org#19815,
Comfy-Org#19816,
Comfy-Org#19817,
Comfy-Org#19818 and
Comfy-Org#19944, stacked, and
parts 2 to 5 were merged into this branch after Christian approved each
at its own head; this PR carries all five against main. It is a sibling
of the FE-3117 part 3
(Comfy-Org#19811) and FE-3118
(Comfy-Org#19819) PRs, which
touch shared contract files only by adding separate lines.
- Merged with the moved FE-3140 base (`cbbe1c4568`): the SDK operation
mapper moved to `@comfyorg/account-core/billing` as
`operationLifecycleEvent.ts` while part 2 added an optional
`paymentIntentSource` argument to it. That argument now imports
`PaymentIntentSource` from `./vocabulary.js` (the app-side import did
not resolve inside the package) and a new test covers it, since the old
app-side mapper test went away with the move. No other base test needed
changing.
- Part 1: E2 sends the entry as `payment_intent_source`, not `source`.
The Notion catalog names the field `source`, but every other billing
event uses `payment_intent_source` for this list, and `source` already
means the resubscribe surface in the allowlist.
- Part 1: E2 fires at `showTopUpCreditsDialog`, so it also fires when
the dialog then falls back to the pricing table or the member notice.
The legacy click event is gated in the deep link and the agent paywall
(only when the user can top up); the new event is not. A deep-link
visitor who cannot top up now produces `add_credits_clicked` followed by
`paywall_shown`, both with the same source.
- Part 1: Until part 2 lands, the popover, the credits tile, the
settings panel, the deep link and the banner call the dialog with no
source, so their E2 carries none. Part 2 passes it.
- Part 1: `outcome` is `pending`, as for `web_handoff`: an entry is a
client journey observation and claims no operation outcome.
- Part 1: `current_tier` is bounded where the legacy `current_tier` was
a free lowercase string: `TEAM` becomes `team`, `ENTERPRISE` and an
unknown tier are omitted.
- Part 1: Not covered: the insufficient-credits member notice that
`showTopUpCreditsDialog` opens for a member who cannot top up. The
ticket names the inactive-member dialog only.
- Part 1: PostHog and the desktop host now also receive
`billing.entry.*` next to the legacy names, so a PostHog funnel can use
either.
- Part 1: No user-visible change: the diff adds telemetry calls only. No
dialog, prop or code path changes.
- Part 2: No new source value. `recovery` is not produced: no entry
creates a recovery journey, a recovered operation is already marked
`resumed: true`, and it now carries the source of the journey it is
bound to. The journey `entry_source` is unchanged, so `deep_link` and
`recovery` stay unproduced there. An existing test pins that `deep_link`
leaves the rail default, and the decision says existing payloads do not
change.
- Part 2: The avatar menu's add-credits control maps to
`avatar_menu_plans`, so one value covers the whole avatar menu.
`credits_panel` and `settings_billing_panel` collapse into
`settings_billing_panel`. Say if either should keep its own value; that
needs a new list entry.
- Part 2: No user-visible change is intended, but one code path moves. A
customer who cannot top up but can subscribe lands on the pricing
dialog. Its `reason` was `top_up_blocked` and is now the entry's source.
Only `out_of_credits` changes the dialog copy and none of these entries
uses it. The legacy `modal_opened` event's `reason` and the `source` on
the hosted billing link change the same way for those customers.
- Part 2: The out-of-credits banner is not changed. Its natural source
is `out_of_credits`, and passing that would switch on the out-of-credits
copy in the pricing fallback, a visible change. It still reports
`add_credits_clicked` with no source.
- Part 2: A resumed journey keeps the source of the entry that created
it. The journey intent key does not include the source, so two entries
into the same journey report the first one on a recovered terminal.
- Part 2: Known gaps: a legacy-rail hosted top-up whose success is
inferred on return (credits tile and usage table) still reports no
source, because the pending top-up marker is a bare timestamp. The SDK
lifecycle's own `started` event fires before the journey binds to the
operation, so only its terminals carry the source.
- Part 2: The existing test 'withholds the surface from the legacy rail
content' is replaced: the legacy dialog now takes the source, so
withholding it is no longer the rule.
- Part 3: `amount_preset` is a string enum (`'10'`, `'25'`, `'50'`,
`'100'`, `'custom'`), not a number, so a Datadog facet has one type. The
ticket says 'the existing preset enum'; there was no enum, only the
dialogs' local arrays, so this adds the type and takes the values from
the same list the buttons use.
- Part 3: A typed amount that equals a preset reports `custom`. The
field says which control the customer used, not what the amount happens
to be. `amount_cents` carries the amount either way.
- Part 3: Both new fields are optional on the stage, not required, so a
surface that cannot supply them (billing web later) is not forced to
invent them. The legacy rail is covered: the legacy dialog reports them
too.
- Part 3: The recovered legacy top-up success (credits tile, usage
table) has no start event in that tab and still carries no amount.
- Part 3: The legacy PostHog, Mixpanel and GTM purchase-click event is
untouched.
- Part 3: No user-visible change: the diff adds telemetry fields and
replaces two local constants with the shared list.
- Part 4: The Notion catalog lists `source` and `failure_category` as
E14 key fields. `source` is not in the event: the cloud app only ever
sends `cancel_plan_menu`, billing web has its own entry, and neither
value belongs to the one source list. Add it when billing web needs it.
The legacy `current_tier`, `cycle` and `end_date` are replaced by the
bounded `current_tier` and `cycle`; the end date and the error message
are not sent.
- Part 4: `outcome` for `abandoned` is `pending`, so a dashboard that
counts `outcome: success` and `outcome: failure` is not moved by
customers who leave.
- Part 4: A provider failure that falls back to the native dialog
reports no `failed`: the attempt continues in the dialog and ends there.
Reporting both would give one attempt two endings.
- Part 4: A discount accepted in the provider flow ends with `intent`
and no end event. The customer kept the plan, which is neither an
abandonment nor a cancel, and the legacy event does not report it
either. Say if you want a stage for it.
- Part 4: On the legacy billing rail the cancel completes in the Stripe
portal, so a flow ends in `intent` and nothing else unless the request
fails. There is no operation to wait for.
- Part 4: No user-visible change: the diff adds telemetry calls, a plan
helper and a moved function. No dialog, copy or code path changes.
- Part 4: FE-3117 can emit the billing web side with
`CancelBillingEvent` as it stands.
- `UnifiedPricingTable.test.ts` ("prompts free-tier users to subscribe")
fails locally on `origin/main` too (`INTERNAL ASSERTION FAILED: Expected
a class definition`, local Node 24 against engine 26). This diff does
not touch it.
- Review fixes after CodeRabbit (`e1ba955394`, red tests first): a
fallback dialog opened after the customer confirmed in the provider flow
no longer reports `billing.cancel.abandoned` (the fallback receives
`flowAlreadyConfirmed`), and a native fallback that cannot open after a
confirmed cancel reports `billing.cancel.failed` with `rendering` (the
reporter drops the expectation that an operation follows once the
provider session fails, via `sessionFailed()`). The other cancel
sequences are unchanged.
- Merged with main after Comfy-Org#19921 (`b91f4e77d2`, wait for the workspace
type instead of falling back to legacy billing). Two hunks met part 5
and part 2. `manageSubscription` keeps the portal telemetry and takes
main's rule: a `WORKSPACE_BILLING_REQUIRED` refusal is reported as
`billing.portal.failed` and rethrown for the legacy adapter to recover,
any other failure is reported and not thrown. Invoice history keeps its
error wrapper. The top-up dialog takes main's chooser (only `legacy`
opens the legacy content, `unknown` opens the workspace content) and
keeps part 2's full props, since the legacy content now declares
`source`.

## AS IS / TO BE

**Part 1, entry events**

AS IS: ![AS IS at ce06a6f: 22 of 23 scenarios off contract.
showPricingTable and showTopUpCreditsDialog report no billing.entry
event to Datadog RUM addAction, PostHog capture or the desktop host
sink: 7 of 8 paywall scenarios reach PostHog and the desktop sink with
only the legacy app:subscription_required_modal_opened, the read-only
member dialog reaches nothing, none of the 7 add-credits scenarios
reaches any sink, and of 7 real callers 5 send only the legacy
app:add_api_credit_button_clicked while the agent paywall precondition
and the out-of-credits banner send nothing; this PR's new tests fail as
expected (7 of 19 in dialogService.topUpCredits.test.ts, 7 of 59 in
useSubscriptionDialog.test.ts, 1 of 3 in entryEvent.test.ts); root
changed test files plus src/platform/telemetry pass 661 of 675,
account-core src/core/billing 600 of
601](https://github.com/user-attachments/assets/3f5baa0d-dcef-4178-8e85-e11ca701b3b5)

TO BE: ![TO BE at 91a0b81: 23 of 23 scenarios on contract. The same
paths now report billing.entry.paywall_shown and
billing.entry.add_credits_clicked with one payload to
datadogRum.addAction, posthog.capture and the desktop host sink (the two
cloud providers add billing_surface cloud_app), the legacy modal_opened
and add-credits events still reach PostHog and the desktop sink beside
them, the read-only member dialog emits only the new event, paywall
current_tier is free, standard, creator, founder or team with ENTERPRISE
and an unknown plan omitted where the legacy event sends the raw tier,
the add-credits click carries deep_link, agent_paywall or out_of_credits
and no source for the 6 callers that pass none until part 2, and the 85
billing events recorded across 244 harness tests hold only current_tier,
duration_ms, outcome and payment_intent_source with bounded values, no
email, URL, secret or free-form text; root changed test files plus
src/platform/telemetry pass 675 of 675, account-core src/core/billing
601 of
601](https://github.com/user-attachments/assets/fa4d12e2-32ac-4697-b1f0-9d0eec80049e)

**Part 2, source fidelity**

AS IS: ![AS IS at 91a0b81: 21 of 25 scenarios off contract.
billing.entry.add_credits_clicked carries no source from the 2 avatar
menu popovers, the credits tile, the settings panel and the deep link
(the agent paywall and the banner are unchanged), no
paymentIntentSource.ts exists so the click-time, journey entry_source
and payment_intent_source vocabularies have no mapping, none of the 11
events of the 3 team downgrade scenarios, none of the terminals of a
recovered poller subscription, a recovered poller top-up or a reattached
SDK top-up, and neither billing.topup.started nor failed of the legacy
dialog carries payment_intent_source, and the 5 changed entries land a
customer who cannot top up on the pricing dialog with reason
top_up_blocked, which also fills the legacy modal_opened reason and
paywall_shown payment_intent_source; this PR's new tests fail as
expected (25 failing tests in 14 files, paymentIntentSource.test.ts
fails to load); root changed test files plus src/platform/telemetry pass
1365 of 1390, account-core src/core/billing 601 of
601](https://github.com/user-attachments/assets/e07d4eee-3554-4aca-9888-32b902cf72c2)

TO BE: ![TO BE at 3cfb584: 25 of 25 scenarios on contract. The same
callers now report the source with the legacy click events unchanged
beside it: avatar_menu_plans from both popovers, settings_billing_panel
from the credits tile and the settings panel, deep_link from the deep
link, while the agent paywall (agent_paywall) and the banner (none) are
unchanged; paymentIntentSource.ts maps credits_panel to
settings_billing_panel, avatar_menu to avatar_menu_plans and
settings_billing to settings_billing_panel, keeps deep_link and
agent_paywall, omits pricing, recovery, other and unknown, and adds no
value to the 15 in the list; every event of a completed, a failed and a
pending team downgrade, the terminals of a recovered poller subscription
(upgrade_to_add_credits), a recovered poller top-up and a reattached SDK
top-up (avatar_menu_plans), and the legacy dialog billing.topup.started
and failed (deep_link) carry payment_intent_source; the one behavior
change is that the pricing dialog now opens with the entry's source as
its reason (avatar_menu_plans, settings_billing_panel or deep_link)
instead of top_up_blocked, with the legacy modal_opened reason and
paywall_shown payment_intent_source following, while the agent paywall
(out_of_credits) and the banner (top_up_blocked) stay as they were; the
519 billing events recorded across 582 harness tests hold 17 allowlisted
keys with bounded values, no email, URL, secret or free-form text; root
changed test files plus src/platform/telemetry pass 1402 of 1402,
account-core src/core/billing 601 of
601](https://github.com/user-attachments/assets/fc0bf695-40e6-414e-8cb2-15dc14cc4388)

**Part 3, top-up amount and preset**

AS IS: ![AS IS at 3cfb584: 16 of 16 scenarios off contract. In all 16
purchase sequences, the preselected 50 dollars, the presets 10, 25, 50
and 100, a typed 75 and a typed 100, on both the workspace and the
legacy top-up dialog, billing.topup.started reaches
datadogRum.addAction, posthog.capture and the desktop host sink with
only outcome and the source and no amount_cents or amount_preset, while
the legacy app:api_credit_topup_button_purchase_clicked already sends
credit_amount to PostHog and the desktop sink; this PR's new tests fail
as expected (8 of 19 in TopUpCreditsDialogContentLegacy.test.ts, 5 of 60
in TopUpCreditsDialogContentWorkspace.test.ts, 7 of 7 in
topupEvent.test.ts); root changed test files plus src/platform/telemetry
pass 675 of 688, account-core src/core/billing 601 of
608](https://github.com/user-attachments/assets/19f882c7-7115-4c66-b490-6978659e8875)

TO BE: ![TO BE at 5e5c096: 16 of 16 scenarios on contract.
billing.topup.started now carries amount_cents and amount_preset to
datadogRum.addAction, posthog.capture and the desktop host sink on both
dialogs: 5000 and 50 for the preselected amount, 1000 and 10, 2500 and
25, 5000 and 50, 10000 and 100 for each clicked preset, 7500 and custom
for a typed 75, and 10000 and custom for a typed 100 that equals a
preset, the Datadog action also carries billing_surface cloud_app, the
legacy purchase_clicked event is unchanged beside it and
billing.topup.failed carries no amount; the 193 billing events recorded
across 85 harness tests hold 10 allowlisted keys with amount_cents an
integer and amount_preset one of 10, 25, 50, 100 or custom, no email,
URL, secret or free-form text; root changed test files plus
src/platform/telemetry pass 688 of 688, account-core src/core/billing
608 of
608](https://github.com/user-attachments/assets/cbf0f259-c711-4689-8550-8a35eae10088)

**Part 4, cancel flow**

AS IS: ![AS IS at 5e5c096: 16 of 16 scenarios off contract. The
provider cancel flow and the native cancel dialog report no
billing.cancel.intent, abandoned or failed to datadogRum.addAction,
posthog.capture or the desktop host sink in any of the 14 flow
scenarios: only the legacy app:subscription_cancel_flow_opened,
confirmed, abandoned and failed reach PostHog and the desktop sink (with
end_date and, on failure, error_message) and Datadog receives nothing, a
confirmed workspace cancel shows only its billing.operation.started, and
billing.operation.failed on failure, with no intent before them, so the
dismissed flow, the accepted discount, the provider failure with the
native dialog and with the native dialog failing, and the legacy rail
failure all end without a typed cancel event; this PR's new tests fail
as expected (7 of 32 in launchCancellationFlow.test.ts, 7 of 27 in
CancelSubscriptionDialogContent.test.ts, billingPlanTelemetry.test.ts
fails to load); root changed test files plus src/platform/telemetry pass
654 of 668, account-core src/core/billing 611 of 611 because its
cancelEvent.test.ts only exercises the generic
builders](https://github.com/user-attachments/assets/31de0750-8239-44ff-a4b3-993354b3e3c2)

TO BE: ![TO BE at f1760c9: 16 of 16 scenarios on contract.
billing.cancel.intent reaches datadogRum.addAction, posthog.capture and
the desktop host sink where the legacy flow_opened fires, then a
dismissed flow adds billing.cancel.abandoned, an accepted discount stops
at intent, a confirmed cancel stops at intent on both flows with the
unchanged billing.operation.started and failed events of the workspace
request next to it and no abandoned or failed from the reporter, a
provider failure with the native dialog stops at intent, a provider
failure with the native dialog failing to open adds
billing.cancel.failed with failure_category rendering, and a legacy rail
failure adds billing.cancel.failed with unknown and no
billing.cancel.abandoned after it; the new events carry only outcome,
current_tier, cycle and failure_category while the legacy events keep
end_date and error_message, and the Datadog actions carry
billing_surface cloud_app; the 343 billing events recorded across 325
harness tests hold 17 allowlisted keys with bounded values and ids, no
email, URL, secret or free-form text; root changed test files plus
src/platform/telemetry pass 681 of 681, account-core src/core/billing
611 of
611](https://github.com/user-attachments/assets/fb14feba-c567-4a09-a8b8-1e35ef9b0f79)

**Part 5, portal events**

Captured through the real telemetry providers in the component and
composable tests (Datadog RUM action and PostHog event carry identical
payloads, `billing_surface` per host). AS IS = the FE-3115 branch before
part 5, TO BE = after.

| Path | Host | AS IS | TO BE |
| --- | --- | --- | --- |
| reports manageSubscription opening the portal and one return |
cloud_app | nothing | `billing.portal.opened` (target:
manage_subscription, billing_client:
legacy)<br>`billing.portal.returned` (target: manage_subscription,
billing_client: legacy) |
| reports handleInvoiceHistory opening the portal and one return |
cloud_app | nothing | `billing.portal.opened` (target: invoices,
billing_client: legacy)<br>`billing.portal.returned` (target: invoices,
billing_client: legacy) |
| reports manageSubscription as a failed open when the tab is blocked |
cloud_app | nothing | `billing.portal.failed` (target:
manage_subscription, billing_client: legacy, failure_category: redirect,
error_code: payment_popup_blocked) |
| reports handleInvoiceHistory as a failed open when the tab is blocked
| cloud_app | nothing | `billing.portal.failed` (target: invoices,
billing_client: legacy, failure_category: redirect, error_code:
payment_popup_blocked) |
| reports a refused portal request as a failed open and still reports
the error | cloud_app | nothing | `billing.portal.failed` (target:
manage_subscription, billing_client: legacy, failure_category:
api_rejected) |
| reports the portal opening from the SDK rail and one return |
cloud_app | nothing | `billing.portal.opened` (target:
manage_subscription, billing_client: sdk)<br>`billing.portal.returned`
(target: manage_subscription, billing_client: sdk) |
| reports the portal opening from the workspace client and one return |
cloud_app | nothing | `billing.portal.opened` (target:
manage_subscription, billing_client:
legacy)<br>`billing.portal.returned` (target: manage_subscription,
billing_client: legacy) |
| reports a blocked portal tab as a failed open | cloud_app | nothing |
`billing.portal.failed` (target: manage_subscription, failure_category:
redirect, error_code: payment_popup_blocked) |
| reports a refused portal request as a failed open | cloud_app |
nothing | `billing.portal.failed` (target: manage_subscription,
failure_category: api_rejected) |
| reports the portal opening on the invoices | billing_web | nothing |
`billing.portal.opened` (target: invoices, billing_client: sdk) |
| reports the portal opening on the payment methods | billing_web |
nothing | `billing.portal.opened` (target: payment_methods,
billing_client: sdk) |
| reports a portal it could not open as a failed open | billing_web |
nothing | `billing.portal.failed` (target: payment_methods,
billing_client: sdk, failure_category: api_rejected) |
| reports the return from the portal once and drops the marker |
billing_web | nothing | `billing.portal.returned` (target: invoices,
billing_client: sdk) |
| reports the return from the portal once | billing_web | nothing |
`billing.portal.returned` (target: payment_methods, billing_client: sdk)
|
| reports a request that never reached the server as a failed portal
open | billing_web | nothing | `billing.portal.failed` (target:
invoices, billing_client: sdk, failure_category: network) |
| reports a refusal from the server as a failed portal open |
billing_web | nothing | `billing.portal.failed` (target: invoices,
billing_client: sdk, failure_category: api_rejected) |
| reports a portal address that fails validation as a failed portal open
| billing_web | nothing | `billing.portal.failed` (target: invoices,
billing_client: sdk, failure_category: unknown) |

The evidence has five parts, one per part of the change: the events each
cloud entry, source, top-up, cancel and portal path reports to Datadog
RUM, PostHog and the desktop sink, before and after.

## Where this sits in the plan

Linear: [FE-3115](https://linear.app/comfyorg/issue/FE-3115), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | this PR |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811), merged
|
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | todo |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | [PR
19944](Comfy-Org#19944), merged
into this PR |
| T12 | FE-3122 | Flag coverage check | [PR
19942](Comfy-Org#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on
PostHog key scopes |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T5 stroke-width:3px
```

---------

Co-authored-by: GitHub Action <action@github.com>
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 3, 2026
… it (Comfy-Org#19947)

## Summary

Report a hosted step the customer is sent to and the return from it, on
the cloud app and billing web (E23).

## Why

A hosted redirect unloads the page, so the operation's start stayed open
with nothing to say the customer left for Stripe or the billing app.
Without a start and a return, a customer who never came back looks the
same as one the browser lost.

## How

A new contract module checkoutRedirectEvent.ts adds
billing.checkout.redirect_started and billing.checkout.returned (one
union line). Fields are destination (stripe or billing_web), step
(authentication, payment_method, invoice_payment or checkout, read from
what the server waits on), navigation (redirect or new_tab) and optional
method_kind. destination, step, navigation and method_kind join the
allowlist. The lifecycle gains reportHostedStepOpened(operationId,
navigation, methodKind?). It emits redirect_started. For a redirect it
stores the step in the operation pointer, so the page the customer lands
on reports returned once when it recovers the operation. Rewriting the
pointer drops the marker, so a reload does not count it again. For a new
tab it reports returned on the next wake. usePaymentAttempt reports the
hosted step before it hands the URL to the host, so the event is queued
before the page unloads. It also reports an embedded challenge as a
redirect when the host says the method is not a card, because Stripe
finishes Alipay and similar methods on their own site. The billing web
full-page checkout passes the method of its own Pay. The cloud SDK store
reports a hosted page it opened in a new tab. There is no user-visible
change.

## Review Focus

- The redirect marker in the operation pointer schema, and that adoption
rewrites the pointer without it.
- Reporting before openUrl is deliberate. Datadog RUM flushes on
beforeunload and visibilitychange, and PostHog drains its queue by
beacon on pagehide, so an event queued before location.assign is sent.
- The off-site challenge rule in usePaymentAttempt: a required challenge
plus a non-card method kind is reported as a redirect.
- BillingOperationTelemetryEvent is now a discriminated union, so a
redirect event cannot be built without destination, step and navigation.
- Known gaps: method_kind is only known for a non-card Pay on the
billing web full-page checkout. The legacy cloud subscribe path that
calls window.open directly is not covered. A return after a same-tab
redirect that lands on a page with no pointer storage is not reported.

## AS IS / TO BE

Telemetry change, so the evidence is the captured events instead of a
screenshot: the real SDK lifecycle and the billing web checkout with
only the network edge and the telemetry SDKs (Datadog RUM, posthog-js)
stubbed. AS IS = origin/main, TO BE = this stack.

| Path | AS IS | TO BE |
| --- | --- | --- |
| E23 same-tab redirect | page that left: `started`; page it came back
to: `started`, `succeeded` | left: `redirect_started` (destination
stripe, step payment_method, navigation redirect, method_kind alipay);
came back: `returned` with the same fields, `resumed: true` |
| E23 new tab | `started` only | `redirect_started` then `returned` on
the next wake (navigation new_tab) |

No payload carries an email, URL, client secret, promo code or provider
id; every new field is a bounded enum.

evidence-fe3119/as-is-lifecycle.json shows the redirect and new-tab
scenarios sending only billing.operation.started and succeeded on main,
and to-be-lifecycle.json shows redirect_started on the page that left,
returned with the same step and method on the page it came back to, and
the new-tab pair, for both surfaces.

## Where this sits in the plan

Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811) merged,
billing web cancel [PR
19945](Comfy-Org#19945) in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | this PR |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | [PR
19944](Comfy-Org#19944), in
review |
| T12 | FE-3122 | Flag coverage check | [PR
19942](Comfy-Org#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on
PostHog key scopes |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T9 stroke-width:3px
```
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…ilures and returns (Comfy-Org#19973)

## Summary

The payment recovery portal that checkout opens after a failed or
outstanding payment now reports billing.portal.opened,
billing.portal.failed and billing.portal.returned with the new target
payment_recovery.

## Why

FE-3121 instrumented Manage subscription, Invoice history and the
billing web portal, but left out the portal that useSubscriptionCheckout
opens when a plan change is refused for an unpaid invoice. That trip is
the only way a customer in payment_failed or paused can get unstuck, and
it reached error reporting only on failure and nothing at all on
success. The Datadog Billing UI tab and the PostHog rollout dashboard
could not count it.

## How

recoverOutstandingPayment now uses createBillingPortalReporter, the same
reporter as the other cloud portal entries. readPaymentPortalUrl returns
which client served the URL, so opened, failed and returned carry
billing_client sdk or legacy once that is known. A thrown request
failure omits billing_client, as the workspace Manage subscription path
does. A blocked tab is failed with redirect and payment_popup_blocked.
When the toast's Try again then opens the tab, that click is the open
and waits for one return. A URL that fails the origin check is failed
with unknown. The contract gains one bounded value, payment_recovery, in
BillingPortalTarget. None of the existing values fits: payment_methods
is the voluntary card management panel on billing web, and folding
recovery into it would hide how often checkout blocks on an unpaid
invoice. target is already allowlisted as a required payload field, so
the allowlist needs no new key. There is no user-visible change. Toasts,
the Try again action, the return refresh and the reportError calls are
unchanged.

## Review Focus

- billing_client is set only after the URL came back. A rail error or a
refused workspace request omits it, matching useWorkspaceBilling; a URL
rejected by the origin check keeps it.
- The toast's Try again now checks the window.open result to report
opened or blocked. It still arms the return refresh either way, as
before.
- A stale attempt (isCurrent false) reports nothing, the same way it
shows nothing.
- payment_recovery is a new BillingPortalTarget value. Dashboards that
list portal targets need the fourth value (T13 PostHog, T14 Datadog
tiles).
- Comfy-Org#19921 is untouched: the WORKSPACE_BILLING_REQUIRED rethrow lives in
useSubscription, not in this path.

## AS IS / TO BE

Captured through the real telemetry providers in the component and
composable tests (Datadog RUM action and PostHog event carry identical
payloads, `billing_surface` per host). AS IS = base branch, TO BE = this
branch.

| Path | Host | AS IS | TO BE |
| --- | --- | --- | --- |
| reports the recovery portal opening from the legacy client and one
return | cloud_app | nothing | `billing.portal.opened` (target:
payment_recovery, billing_client: legacy)<br>`billing.portal.returned`
(target: payment_recovery, billing_client: legacy) |
| reports the recovery portal opening from the SDK rail and one return |
cloud_app | nothing | `billing.portal.opened` (target: payment_recovery,
billing_client: sdk)<br>`billing.portal.returned` (target:
payment_recovery, billing_client: sdk) |
| reports the recovery portal opening from the legacy client when the
rail route i… and one return | cloud_app | nothing |
`billing.portal.opened` (target: payment_recovery, billing_client:
legacy)<br>`billing.portal.returned` (target: payment_recovery,
billing_client: legacy) |
| reports a blocked recovery tab as a failed open and the retry as the
open | cloud_app | nothing | `billing.portal.failed` (target:
payment_recovery, billing_client: legacy, failure_category: redirect,
error_code: payment_popup_blocked)<br>`billing.portal.opened` (target:
payment_recovery, billing_client: legacy)<br>`billing.portal.returned`
(target: payment_recovery, billing_client: legacy) |
| reports a refused legacy portal request as a failed open and keeps the
error report | cloud_app | nothing | `billing.portal.failed` (target:
payment_recovery, failure_category: api_rejected) |
| reports a legacy portal request that never reac… as a failed open and
keeps the error report | cloud_app | nothing | `billing.portal.failed`
(target: payment_recovery, failure_category: network) |
| reports a rail portal failure as a failed open and keeps the error
report | cloud_app | nothing | `billing.portal.failed` (target:
payment_recovery, failure_category: api_rejected) |
| reports a portal address that fails validation as a failed open and
keeps the error report | cloud_app | nothing | `billing.portal.failed`
(target: payment_recovery, billing_client: legacy, failure_category:
unknown) |
| reports nothing when the rejection needs no payment recovery |
cloud_app | nothing | nothing |

Captured RUM actions and PostHog events for each recovery path show
nothing on the FE-3115 base and the matching billing.portal.* event with
target payment_recovery, client and failure category on this branch,
with identical reportError calls (evidence-fe3121-recovery/).

## Where this sits in the plan

Linear: [FE-3121](https://linear.app/comfyorg/issue/FE-3121), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811) merged,
billing web cancel [PR
19945](Comfy-Org#19945) in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | [PR
19946](Comfy-Org#19946), [PR
19947](Comfy-Org#19947), [PR
19948](Comfy-Org#19948), in
review |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | this PR |
| T12 | FE-3122 | Flag coverage check | [PR
19942](Comfy-Org#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | [first
cut](https://us.posthog.com/project/204330/dashboard/2164447) created |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T11 stroke-width:3px
```

---------

Co-authored-by: GitHub Action <action@github.com>
theluckystrike pushed a commit to theluckystrike/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…urney with no operation (Comfy-Org#19975)

## Summary

Report where a customer left a cloud app checkout dialog when the
journey has no operation yet (E24, cloud app follow-up).

## Why

Billing web reports billing.checkout.abandoned, but the cloud app did
not. A customer who closed the subscription or top-up dialog, or closed
the tab with it open, left no trace of where they stopped. The abandon
KPI itself is derived on the dashboard from journeys that never link an
operation. This event only says where the customer left.

## How

A new module, checkoutJourneyTelemetry.ts, becomes the one way the cloud
app reports a journey phase. It remembers the last progress phase this
tab reported on the active journey. reportCheckoutJourneyExit reports
billing.checkout.abandoned with last_phase and exit only when the active
journey has no billing_op_id, and only once per stretch of new progress.
A close and a later pagehide therefore report once, and a reopened
journey reports again only after a new phase. useCheckoutJourneyExit
wires it into useSubscriptionCheckout and the top-up dialog: scope
dispose reports exit dialog_close, and pagehide while the dialog is open
reports exit page_exit. A hand-off to the hosted billing web checkout
marks the journey as accounted for, so that close reports nothing. The
shared CheckoutExit enum gains dialog_close. The cloud PostHog provider
sends an abandoned page_exit with transport sendBeacon and
send_instantly, through its existing teardown capture. Everything else
stays batched. billing_surface cloud_app comes from the existing cloud
journey payload. There is no user-visible change.

## Review Focus

- Base: the -3 branch was squash-merged into -2 (8814fe1), so this
branch is cut from -2 and merges origin/main. Its PR targets -2.
- The event is an exit observation with no outcome. Once an operation is
bound, the cloud app reports nothing. The operation events and the
server own the end.
- The last phase is tab-scoped, module-level state. A journey resumed
after a reload with no new phase in this tab reports no exit.
- The three call sites (useSubscriptionCheckout,
SubscriptionAddPaymentPreviewWorkspace,
TopUpCreditsDialogContentWorkspace) now go through
trackCheckoutJourneyPhase. Their existing journey tests pass unchanged.
- Known gaps: the brief says later phase events carry resumed: true, but
cloud journey events have no resumed field, and this branch does not add
one. A tab closed while it was already in the background may not flush
its RUM action. PostHog events captured before it loads are not queued
for page_exit, the same as the agent panel teardown event. The hosted
handoff for the subscription intent (manage plan) is not a checkout
journey and is untouched.

## AS IS / TO BE

Telemetry change, so the evidence is the captured events instead of a
screenshot: the real cloud dialogs and journey module with the Datadog
RUM and PostHog providers, only the network edge and the telemetry SDKs
stubbed. AS IS = origin/main, TO BE = this branch.

| Scenario | AS IS | TO BE |
| --- | --- | --- |
| T1 top-up dialog closed after `entered` | `entered` | adds `abandoned`
(last_phase entered, exit dialog_close) |
| T2 tab closed with the top-up dialog open | `entered` | adds
`abandoned` (exit page_exit); PostHog sends with `{transport:
'sendBeacon', send_instantly: true}` |
| T3 top-up closed after a submit that bound no operation | `entered`,
`submitted` | adds `abandoned` (last_phase submitted, exit dialog_close)
|
| T4 top-up closed, then tab closed, after the operation was bound |
`entered`, `submitted`, `operation_linked` | unchanged, no abandon |
| T5 top-up closed, then tab closed | `entered` | one `abandoned`
(dialog_close), no second report on pagehide |
| T6 top-up closed, reopened (journey resumed), closed | `entered` | one
`abandoned`; the reopen made no new phase, so its close reports nothing
|
| S1 subscription dialog closed at the quote | `entered`,
`preview_ready` | adds `abandoned` (last_phase preview_ready, exit
dialog_close) |
| S2 tab closed at the quote | `entered`, `preview_ready` | adds
`abandoned` (exit page_exit), PostHog by sendBeacon |
| S3 subscription closed after the quote failed | `entered`,
`preview_failed` | adds `abandoned` (last_phase preview_failed) |
| S4 subscription closed, then tab closed, after the operation was bound
| through `operation_linked` | unchanged, no abandon |
| S5 dialog closed because the hosted checkout tab opened | `entered` |
unchanged, no abandon (billing web continues the journey) |
| S6 closed at the quote, reopened idle and closed, tab hidden, reopened
to the quote and closed | 2x `preview_ready` | one `abandoned` per
stretch of new progress: 2, not 4 |

The event is an exit observation (decision D13 in the plan): the
headline abandon count is derived on the dashboard from journeys with no
`operation_linked` within the journey TTL.

evidence-fe3119-cloud-abandon/as-is.json shows no abandoned event on
origin/main for any path, and to-be.json shows abandoned with last_phase
and exit to RUM and PostHog on dialog close at entered, submitted,
preview_ready and preview_failed, sendBeacon on page exit, one report
for close plus pagehide and for reopen without progress, and nothing
after a bound operation or a hosted handoff.

## Where this sits in the plan

Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811) merged,
billing web cancel [PR
19945](Comfy-Org#19945) in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | this PR |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | [PR
19944](Comfy-Org#19944), in
review |
| T12 | FE-3122 | Flag coverage check | [PR
19942](Comfy-Org#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | [first
cut](https://us.posthog.com/project/204330/dashboard/2164447) created |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T9 stroke-width:3px
```
theluckystrike pushed a commit to theluckystrike/ComfyUI_frontend that referenced this pull request Oct 3, 2026
…embedded checkout (Comfy-Org#19974)

## Summary

Report an abandoned checkout and the ending screen on the billing web
embedded checkout, the same way the full-page checkout does (E24, E25).

## Why

The full-page checkout reports billing.checkout.abandoned and
billing.checkout.ended since Comfy-Org#19948, but the embedded CheckoutView
reported neither. A customer who closed the tab or went back from the
embedded checkout left no trace, and its success and refusal screens
could not be told apart in a funnel.

## How

CheckoutView reuses the journey's abandoned and ended methods from
useCheckoutJourney and the beacon transport the facade already applies
to abandoned. No shared composable was extracted, because the two views
share only the journey, which is already shared, and their ending
screens differ. It reports abandoned with exit page_exit on pagehide,
and with exit back or close from those controls. It reports no abandon
after the page handed itself to a hosted step, or while a Pay with a
non-card method is in flight, since that method pays on its own site. It
reports ended with ending_kind success when the success step shows:
attribution started when this page's Pay returned the result, followed
when the page recovered an operation it did not send. It reports ended
when the quote failure screen shows, right after preview_failed: refused
for ACCESS_DENIED, plan_unavailable for the server code INVALID_PLAN,
and load_failed otherwise. The journey keeps its existing rules:
abandoned at most once and never after an ending, and each ending kind
once. There is no user-visible change.

## Review Focus

- quoteFailureEndingOf maps the embedded quote failure screen onto the
full-page ending kinds. The embedded view has no capability read, so
refused comes from ACCESS_DENIED on the quote, not from a denial reason.
- payingOnOwnSite is true only between the Pay press and the command
settling, for a method type other than card. A card Pay in flight when
the tab closes is still an abandon, as on the full page.
- Success attribution reads checkout.result: an ok result means this
page's own Pay, and none means a recovered operation.
- Two existing tests now expect billing.checkout.ended: the full journey
test, and the stream ordering test, where ended lands before
billing.subscription_checkout.succeeded because the success step shows
before the attempt reports its terminal.
- Known gaps: a quote that allows no change (allowed false) shows no
ending screen on the embedded view, so it reports preview_failed and no
ended. A saved non-card method carries no method type, so a redirect
from it would count as an abandon. That matches the full page. The
background-tab flush gap from Comfy-Org#19948 applies here too.

## AS IS / TO BE

Telemetry change, so the evidence is the captured events instead of a
screenshot: the real `CheckoutView` with the billing web telemetry
facade and PostHog started, only the fake billing client and the
telemetry SDKs stubbed. AS IS = origin/main, TO BE = this branch.

| Path | AS IS | TO BE |
| --- | --- | --- |
| Tab closed at the quote | `entered`, `preview_ready` | adds
`abandoned` (last_phase preview_ready, exit page_exit). The PostHog copy
is sent with `{transport: 'sendBeacon'}` |
| Back control, then the page unloads | `entered`, `preview_ready`,
`web_return.clicked` | adds `abandoned` (exit back) once. The later
pagehide adds nothing |
| Close control, then the page unloads | `entered`, `preview_ready`,
`web_return.clicked` | adds `abandoned` (exit close) once |
| Hosted redirect (server offers a continuation) | `entered`,
`preview_ready` | unchanged. No abandon, because the page handed itself
to the hosted step |
| Alipay Pay leaving for its own site | no abandon | unchanged. No
abandon while a non-card Pay is in flight |
| Own payment succeeds, then the tab closes | no ending event | `ended`
(ending_kind success, attribution started, billing_op_id op_9). No
abandon after it |
| Quote refused (ACCESS_DENIED), then Back | `entered`,
`preview_failed`, `web_return.clicked` | adds `ended` (ending_kind
refused), with no attribution. Back after it adds no abandon |

No new field carries an email, URL, client secret, promo code or
provider id; every new field is a bounded enum.

evidence-fe3119-embedded/as-is.json shows no abandoned or ended event on
the embedded checkout on main. to-be.json shows abandoned with
last_phase and exit for tab close, Back and Close, sent to RUM and to
PostHog with transport sendBeacon. It shows no abandon for a hosted
redirect or an Alipay Pay, and ended with ending_kind and attribution
for the success and refusal screens.

## Where this sits in the plan

Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815) (four
parts), in review |
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811) merged,
billing web cancel [PR
19945](Comfy-Org#19945) in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | this PR |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | [PR
19944](Comfy-Org#19944), in
review |
| T12 | FE-3122 | Flag coverage check | [PR
19942](Comfy-Org#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | [first
cut](https://us.posthog.com/project/204330/dashboard/2164447) created |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T9 stroke-width:3px
```
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 4, 2026
…tion switch rewrites the operation pointer (Comfy-Org#20004)

## Summary

Keep the saved hosted redirect when a presentation switch rewrites the
operation pointer, so billing.checkout.returned (E23) is still reported
on the page the customer comes back to.

## Why

CodeRabbit found this on Comfy-Org#19975
(Comfy-Org#19975 (comment)).
A same-tab hosted redirect is only reported as returned if the tab's
operation pointer still carries the redirect when the next page recovers
the operation. A presentation switch after the redirect erased it, so
that return was never reported.

## Root cause

writePointer rebuilds the pointer from the operation state and only
includes redirect when the caller passes one. reportHostedStepOpened
passes it, but switchPresentation rewrites the pointer for the same
operation without it, so the saved redirect is dropped.

## How

A small savedRedirect helper reads the current pointer and returns its
redirect only when its operationId is the operation being written.
switchPresentation passes that to writePointer. The adopt write is
deliberately left unchanged: adoption is where a saved redirect is
turned into billing.checkout.returned, so it must consume the redirect.
Carrying it forward there would report returned again on every reload,
which the existing 'reports the return once' test catches. There is no
user-visible change.

## Review Focus

- The carry-forward lives at the switchPresentation call site, not
inside writePointer. A generic carry-forward in writePointer also hits
the adopt write and breaks the 'reports the return once' contract. This
was checked: that test fails with the generic version.
- The operationId guard matters when two operations are live in one
scope. The new 'reports no return for an operation that never
redirected, though another one did' test fails if the guard is removed.
- leftScope writes a fresh pointer for a newly issued operation through
pointers.write directly. It has no redirect to keep and is unchanged.

## AS IS / TO BE

Telemetry change, so the evidence is the captured lifecycle events
instead of a screenshot. Scenario: embedded 3DS top-up, hosted redirect,
`switchPresentation('op-1', 'hosted')`, unload, then recover on a new
page.

| | Pointer after the rewrite | Events on the page the customer returns
to |
| --- | --- | --- |
| AS IS (main) | `redirect` dropped | `billing.operation.started`,
`billing.operation.succeeded` |
| TO BE | `redirect` kept | adds `billing.checkout.returned` (navigation
redirect, step authentication, method_kind card, presentation hosted,
resumed true) on both the cloud app and billing web payloads |

evidence-fe3119-pointer/as-is.json shows the pointer losing redirect
after the same-operation rewrite and no billing.checkout.returned on the
page returned to, and to-be.json shows redirect kept and
billing.checkout.returned reported to both cloud app and billing web
payloads.

## Where this sits in the plan

Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of
[FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards).
Plan, event catalog and dependency graph: [action
items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89).

| Task | Ticket | What | Status |
| --- | --- | --- | --- |
| T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT |
| T2 | FE-3108 | Decide RUM application and env mapping | decided |
| T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR
19688](Comfy-Org#19688), merged
|
| T3+ | FE-3156 | Opaque RUM user id on billing web | [PR
19794](Comfy-Org#19794), merged
|
| T4, F1 | FE-3106 | SDK-rail ownership | [PR
19620](Comfy-Org#19620), merged
|
| T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR
19623](Comfy-Org#19623), merged
|
| T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR
19685](Comfy-Org#19685), merged
|
| T4, F5 | FE-3112 | SDK top-up terminals | [PR
19628](Comfy-Org#19628), merged
|
| T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR
19622](Comfy-Org#19622), merged
|
| T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR
19627](Comfy-Org#19627), merged
|
| T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices |
[PR 19686](Comfy-Org#19686),
merged |
| T4+ | FE-3140 | Move the billing event contract to a shared package |
[PR 19798](Comfy-Org#19798),
merged |
| T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR
19815](Comfy-Org#19815), merged
|
| T6 | FE-3116 | Handoff contract and event | [PR
19687](Comfy-Org#19687), merged
|
| T7 | FE-3117 | Billing web attempt lifecycle | [PR
19809](Comfy-Org#19809), [PR
19810](Comfy-Org#19810), [PR
19811](Comfy-Org#19811) merged,
billing web cancel [PR
19945](Comfy-Org#19945) in
review |
| T8 | FE-3118 | Billing web journey and choices | [PR
19819](Comfy-Org#19819) (three
parts), merged |
| T9 | FE-3119 | Payment friction events | this PR |
| T10 | FE-3120 | Billing web entry, session and return | [PR
19804](Comfy-Org#19804), [PR
19806](Comfy-Org#19806) and [PR
19807](Comfy-Org#19807), merged
in [PR 19798](Comfy-Org#19798)
|
| T11 | FE-3121 | Portal events | [PR
19944](Comfy-Org#19944), in
review |
| T12 | FE-3122 | Flag coverage check | [PR
19942](Comfy-Org#19942), in
review |
| T13 | FE-3123 | PostHog rollout dashboard | [first
cut](https://us.posthog.com/project/204330/dashboard/2164447) created |
| T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard |
[comfy-infra PR
1597](Comfy-Org/comfy-infra#1597), in review |
| T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR
19940](Comfy-Org#19940), in
review |
| T10+ | FE-3158 | Billing web Try again after session creation fails |
[PR 19941](Comfy-Org#19941), in
review |
| T15 | FE-3125 | Verification per flow | todo |
| T16 | FE-3126 | Rollout plan | todo |

```mermaid
flowchart LR
  subgraph DEC["Decided"]
    T1["FE-3107 T1 vocabulary"]
    T2["FE-3108 T2 RUM app and env"]
  end
  subgraph FIX["Existing events (T4)"]
    F1["FE-3106 F1 SDK-rail ownership"]
    F2["FE-3110 F2 mapper fields"]
    F3["FE-3111 F3 surface and client"]
    F5["FE-3112 F5 top-up terminals"]
    F6["FE-3113 F6 downgrade terminal"]
    F7["FE-3114 F7 legacy personal, first slice"]
    F7B["FE-3131 F7 remaining slices"]
    C140["FE-3140 event contract to shared package"]
  end
  subgraph EMIT["New events"]
    T3["FE-3109 T3 billing web bootstrap"]
    T3b["FE-3156 T3+ opaque RUM user id"]
    T5["FE-3115 T5 cloud entry and parity"]
    T6["FE-3116 T6 handoff contract"]
    T7["FE-3117 T7 attempt lifecycle"]
    T8["FE-3118 T8 journey and choices"]
    T9["FE-3119 T9 friction"]
    T10["FE-3120 T10 entry, session, return"]
    T11["FE-3121 T11 portal"]
    T12["FE-3122 T12 flag coverage"]
  end
  subgraph DASH["Dashboards"]
    T13["FE-3123 T13 PostHog rollout"]
    T14["FE-3124 T14 Frontend RUM tiles"]
  end
  T15["FE-3125 T15 verification"]
  T16["FE-3126 T16 rollout plan"]
  T2 --> T3
  T3 --> T3b
  F3 --> C140
  T3 --> C140
  C140 --> T7
  C140 --> T8
  C140 --> T10
  C140 --> T11
  T1 --> F3
  T1 --> T5
  T1 --> T6
  T1 --> T13
  T1 --> T14
  T2 --> T14
  F2 --> T7
  T3 --> T7
  T3 --> T8
  T3 --> T10
  T3 --> T11
  T3 --> T12
  T5 --> T11
  T6 --> T8
  T6 --> T10
  T7 --> T9
  T8 --> T9
  F1 --> T13
  F3 --> T13
  FIX --> T15
  T5 --> T15
  T9 --> T15
  T10 --> T15
  T11 --> T15
  T12 --> T15
  T13 --> T15
  T14 --> T15
  T13 --> T16
  T15 --> T16
  style T9 stroke-width:3px
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants