Repository navigation
FE-3111 fix(billing): stamp billing_surface on cloud checkout journey events - #19943
Conversation
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 7 days. Promotion and pricing detailsOn-demand reviews are free for the next 7 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 9 minutes for your next included review. Limit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3bd322ea1487c5b0396ee7ca440b9aa67a2edc46
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2190 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.1 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.89 kB (baseline 3.89 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.47 MB (baseline 1.47 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 135 kB (baseline 135 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 646 kB (baseline 646 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 53.6 kB (baseline 53.6 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 184 kB (baseline 184 kB) • ⚪ 0 BReusable component library chunks Status: 18 unchanged Data & Services — 4.15 MB (baseline 4.15 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 14 unchanged Utilities & Hooks — 586 kB (baseline 586 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.3 MB (baseline 18.3 MB) • ⚪ 0 BBundles that do not match a named category Status: 305 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-02T22:15:26.174Z",
"gitSha": "d9cea645038f40b7495aae2f624adb24df305ad9",
"branch": "jaewon/fe-3111-stamp-billing-surface-on-cloud-checkout-journey-events",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.0690000000068,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.018000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.223,
"heapDeltaBytes": 571604,
"heapUsedBytes": 67163996,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.624,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2016.00499999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.229,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.274,
"heapDeltaBytes": 560148,
"heapUsedBytes": 67052944,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.217999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1771.1120000000165,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.801,
"layouts": 12,
"layoutDurationMs": 4.395,
"taskDurationMs": 839.564,
"heapDeltaBytes": 19240312,
"heapUsedBytes": 73044172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.09799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1844.773000000032,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.041999999999998,
"layouts": 12,
"layoutDurationMs": 5.314,
"taskDurationMs": 875.1149999999999,
"heapDeltaBytes": -3106072,
"heapUsedBytes": 64320176,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 177.041,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665765765765762,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5360000000005,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.820000000000002,
"layouts": 6,
"layoutDurationMs": 1.286,
"taskDurationMs": 338.19999999999993,
"heapDeltaBytes": 3369784,
"heapUsedBytes": 69812768,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.328999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846145,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1703.3999999999878,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.502,
"layouts": 6,
"layoutDurationMs": 1.4020000000000004,
"taskDurationMs": 325.1379999999999,
"heapDeltaBytes": 25297600,
"heapUsedBytes": 79547364,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.216000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 754.1870000000017,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.479,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.545,
"heapDeltaBytes": -8163524,
"heapUsedBytes": 59085516,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 177.515,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444435,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 730.0210000000789,
"styleRecalcs": 14,
"styleRecalcDurationMs": 4.307000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.217,
"heapDeltaBytes": 15132472,
"heapUsedBytes": 74954048,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.14499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.0540000000274,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 845.07,
"heapDeltaBytes": 13729968,
"heapUsedBytes": 93222732,
"domNodes": 0,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 66.39699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 567,
"frameDurationMs": 35.294117647058826,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1167.5880000000234,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.1370000000001,
"heapDeltaBytes": 14872480,
"heapUsedBytes": 83391668,
"domNodes": 0,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 72.32600000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 530,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.3670000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.8939999999996,
"heapDeltaBytes": -7516860,
"heapUsedBytes": 91301868,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 172.495,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.488235294117604,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.6369999999497,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.10799999999966,
"heapDeltaBytes": 16497588,
"heapUsedBytes": 103246604,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 168.33500000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10815.373000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9845.372999999998,
"heapDeltaBytes": 3691104,
"heapUsedBytes": 84516476,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 8218.417000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1552,
"frameDurationMs": 34.72540192926044,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10584.236000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9648.611,
"heapDeltaBytes": 14247192,
"heapUsedBytes": 94143816,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 8004.385999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1398,
"frameDurationMs": 33.70350318471338,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9320.402000000002,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7860000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8583.342,
"heapDeltaBytes": 8440576,
"heapUsedBytes": 92830600,
"domNodes": -173,
"jsHeapTotalBytes": -5902336,
"scriptDurationMs": 7027.866999999999,
"eventListeners": -82,
"totalBlockingTimeMs": 644,
"frameDurationMs": 32.91978798586573,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9629.175000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8784.42,
"heapDeltaBytes": 7066792,
"heapUsedBytes": 84990988,
"domNodes": -172,
"jsHeapTotalBytes": -4853760,
"scriptDurationMs": 7276.38,
"eventListeners": -86,
"totalBlockingTimeMs": 957,
"frameDurationMs": 32.3255033557047,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2033.0139999999801,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.658999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.6160000000001,
"heapDeltaBytes": -52315676,
"heapUsedBytes": 72349380,
"domNodes": -328,
"jsHeapTotalBytes": -2457600,
"scriptDurationMs": 34.133,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2053.9179999999533,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0479999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.952,
"heapDeltaBytes": -52769184,
"heapUsedBytes": 72614788,
"domNodes": -328,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 34.769999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2424.149,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.827,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.6739999999998,
"heapDeltaBytes": -61093332,
"heapUsedBytes": 63341356,
"domNodes": -328,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 830.525,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2469.6660000000747,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.867999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1563.9579999999999,
"heapDeltaBytes": 1560664,
"heapUsedBytes": 65121756,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 824.616,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.779054054054054,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3868.118000000038,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.866000000000001,
"layouts": 60,
"layoutDurationMs": 15.271999999999998,
"taskDurationMs": 1755.1570000000002,
"heapDeltaBytes": 1610660,
"heapUsedBytes": 69368512,
"domNodes": 24,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 834.8870000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3643.417999999997,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.888000000000002,
"layouts": 60,
"layoutDurationMs": 13.981,
"taskDurationMs": 1700.31,
"heapDeltaBytes": -37065360,
"heapUsedBytes": 89662200,
"domNodes": -304,
"jsHeapTotalBytes": -4030464,
"scriptDurationMs": 782.3860000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665898617511527,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3099.4739999999865,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.614999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1846.705,
"heapDeltaBytes": 3970920,
"heapUsedBytes": 68354768,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 953.8520000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846739130434784,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3131.711999999993,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.5420000000001,
"heapDeltaBytes": 7640484,
"heapUsedBytes": 72557252,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 971.679,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75508021390374,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.2929999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.875,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.54,
"heapDeltaBytes": -10007044,
"heapUsedBytes": 79266868,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 35.860000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.8629999999393,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0340000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.9000000000001,
"heapDeltaBytes": 10300284,
"heapUsedBytes": 72643356,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.301000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.842000000011,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.1629999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.434,
"heapDeltaBytes": -11635852,
"heapUsedBytes": 57835256,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 145.059,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 655.1570000000311,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.053000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.73900000000003,
"heapDeltaBytes": -41987284,
"heapUsedBytes": 63523504,
"domNodes": -250,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 151.496,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102578,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.1069999999722,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.416999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.18100000000004,
"heapDeltaBytes": 21996516,
"heapUsedBytes": 75429016,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.406,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.4330000000582,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.821999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.779,
"heapDeltaBytes": 610028,
"heapUsedBytes": 70060608,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.029999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.0939999999891,
"styleRecalcs": 59,
"styleRecalcDurationMs": 18.242,
"layouts": 16,
"layoutDurationMs": 5.917000000000001,
"taskDurationMs": 817.693,
"heapDeltaBytes": -35457344,
"heapUsedBytes": 68553988,
"domNodes": -250,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 115.532,
"eventListeners": -206,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.5299999999488,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.503,
"layouts": 16,
"layoutDurationMs": 6.4319999999999995,
"taskDurationMs": 785.629,
"heapDeltaBytes": -6526948,
"heapUsedBytes": 62982340,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 116.88299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.9199999999128,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.305000000000003,
"layouts": 5,
"layoutDurationMs": 13.033,
"taskDurationMs": 860.6050000000002,
"heapDeltaBytes": 23946572,
"heapUsedBytes": 110107628,
"domNodes": 13747,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 29.154000000000014,
"eventListeners": 2383,
"totalBlockingTimeMs": 133,
"frameDurationMs": 19.48169014084508,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8835.594000000016,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.540000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5750.576000000001,
"heapDeltaBytes": 6998412,
"heapUsedBytes": 83322904,
"domNodes": 0,
"jsHeapTotalBytes": 491520,
"scriptDurationMs": 2857.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849056,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8312.97600000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.611999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5420.798000000001,
"heapDeltaBytes": -34751560,
"heapUsedBytes": 90219184,
"domNodes": -328,
"jsHeapTotalBytes": -2527232,
"scriptDurationMs": 2636.868,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699397590361443,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18000.44399999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17189.578,
"heapDeltaBytes": -38521320,
"heapUsedBytes": 171156220,
"domNodes": -3045,
"jsHeapTotalBytes": 7426048,
"scriptDurationMs": 303.966,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.979862306368336,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17186.82000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16454.545,
"heapDeltaBytes": -11988508,
"heapUsedBytes": 188003372,
"domNodes": -3045,
"jsHeapTotalBytes": 6823936,
"scriptDurationMs": 307.08500000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.22210884353742,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 21693.369000000017,
"styleRecalcs": 170,
"styleRecalcDurationMs": 21.542999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21278.142,
"heapDeltaBytes": -18033840,
"heapUsedBytes": 180901588,
"domNodes": -3045,
"jsHeapTotalBytes": 10596352,
"scriptDurationMs": 943.7070000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 51,
"frameDurationMs": 39.02733812949641,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-pan",
"durationMs": 22405.489999999987,
"styleRecalcs": 179,
"styleRecalcDurationMs": 21.950999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21987.022,
"heapDeltaBytes": -15526780,
"heapUsedBytes": 192992756,
"domNodes": -3045,
"jsHeapTotalBytes": 7745536,
"scriptDurationMs": 941.467,
"eventListeners": -14915,
"totalBlockingTimeMs": 40,
"frameDurationMs": 41.40314232902033,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6328.000999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.55099999999999,
"layouts": 20,
"layoutDurationMs": 24.512000000000008,
"taskDurationMs": 6168.101,
"heapDeltaBytes": 7502828,
"heapUsedBytes": 216387632,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 112.58500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.0356725146199,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6284.935000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.92799999999997,
"layouts": 20,
"layoutDurationMs": 25.388999999999996,
"taskDurationMs": 6136.952,
"heapDeltaBytes": 7833524,
"heapUsedBytes": 207680380,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 108.492,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.72335329341317,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8914.023999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8586.74,
"heapDeltaBytes": -37361944,
"heapUsedBytes": 175513252,
"domNodes": -3045,
"jsHeapTotalBytes": 7815168,
"scriptDurationMs": 138.41900000000007,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.965319865319866,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8992.524000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8634.684,
"heapDeltaBytes": -30042628,
"heapUsedBytes": 170555652,
"domNodes": -3045,
"jsHeapTotalBytes": 9445376,
"scriptDurationMs": 143.94000000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.245791245791246,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 497.23900000003596,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.305000000000001,
"layouts": 2,
"layoutDurationMs": 0.464,
"taskDurationMs": 120.67799999999998,
"heapDeltaBytes": 5625856,
"heapUsedBytes": 59327372,
"domNodes": 102,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.052999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.260714285714293,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 462.0200000000523,
"styleRecalcs": 14,
"styleRecalcDurationMs": 12.181,
"layouts": 3,
"layoutDurationMs": 0.9219999999999998,
"taskDurationMs": 102.155,
"heapDeltaBytes": 5482176,
"heapUsedBytes": 64719052,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.723,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1039.9380000000065,
"styleRecalcs": 78,
"styleRecalcDurationMs": 112.593,
"layouts": 76,
"layoutDurationMs": 28.026,
"taskDurationMs": 1013.811,
"heapDeltaBytes": 19378968,
"heapUsedBytes": 90327296,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 427.249,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 855.5290000000468,
"styleRecalcs": 78,
"styleRecalcDurationMs": 102.358,
"layouts": 76,
"layoutDurationMs": 25.206,
"taskDurationMs": 824.002,
"heapDeltaBytes": 17763380,
"heapUsedBytes": 84691884,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 332.75899999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1416.5329999999585,
"styleRecalcs": 78,
"styleRecalcDurationMs": 258.769,
"layouts": 76,
"layoutDurationMs": 29.168,
"taskDurationMs": 1398.016,
"heapDeltaBytes": 8751404,
"heapUsedBytes": 113490264,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 468.603,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.695061728395075,
"p95FrameDurationMs": 33.19999999999891
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1448.9019999999755,
"styleRecalcs": 78,
"styleRecalcDurationMs": 267.54200000000003,
"layouts": 76,
"layoutDurationMs": 29.91,
"taskDurationMs": 1427.286,
"heapDeltaBytes": -19117228,
"heapUsedBytes": 108184192,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 475.827,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.353164556962042,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19943 +/- ##
=========================================
Coverage 84.83% 84.83%
=========================================
Files 3436 3436
Lines 164623 164624 +1
Branches 44956 43025 -1931
=========================================
+ Hits 139654 139655 +1
Misses 23014 23014
Partials 1955 1955
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the exact head. The implementation and focused coverage match the stated contract; CI is settled green and no current review threads remain.
Summary
Cloud app checkout journey events (billing.checkout.*) now carry billing_surface: 'cloud_app' in Datadog RUM and PostHog.
Why
Decision T1 says every billing event carries billing_surface. On the cloud app the billing.. events already did, but the checkout journey events did not. Billing web stamps billing_web on the same journey events, so the Datadog tiles (FE-3124) that group by @context.billing_surface showed cloud journey traffic with no surface.
Root cause
getCheckoutJourneyTelemetryEventPayload builds the journey payload with no surface. The cloud Datadog RUM and PostHog providers sent it as is. Billing web adds the surface itself inside trackCheckoutJourneyEvent, so only billing web output had it.
How
A new getCloudAppCheckoutJourneyTelemetryEventPayload in packages/account-core/src/core/billing/telemetry/checkoutJourney.ts wraps the existing builder and adds billing_surface: 'cloud_app'. It mirrors getCloudAppBillingTelemetryEventPayload. Both cloud sinks that receive journey events (DatadogRumTelemetryProvider and PostHogTelemetryProvider) call it in trackCheckoutJourneyEvent. The shared builder and billing web are untouched.
Review Focus
AS IS / TO BE
Telemetry payload change, so the evidence is the captured event rather than a screenshot. One
billing.checkout.enteredsent through the real cloud Datadog RUM and PostHog providers, origin/main (AS IS) vs this branch (TO BE):Captured payloads for one billing.checkout.entered event through the real cloud Datadog RUM and PostHog providers show billing_surface missing on origin/main and billing_surface: 'cloud_app' on the branch, with all other fields identical (evidence-fe3111-journey-surface/).
Where this sits in the plan
Linear: FE-3111, part of FE-3105. Plan, event catalog and dependency graph: action items.
flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style F3 stroke-width:3px