Repository navigation
FE-3158 fix(billing-web): retry shared session creation after it fails - #19941
dante01yoon merged 2 commits into
Conversation
Reproduces FE-3158: in shared-web-session mode a 503 on session creation leaves Try again answering NOT_AUTHENTICATED without a request, and a remembered login whose restore keeps failing never settles the phase.
Try again after a failed session creation now creates the session for the user Firebase holds instead of answering NOT_AUTHENTICATED without a request. A remembered login whose restore keeps failing settles to the sign-in screen while the identity keeps retrying in the background.
|
Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 7 days. Promotion and pricing detailsOn-demand reviews are free for the next 7 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 13 minutes for your next included review. Limit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3bd322ea1487c5b0396ee7ca440b9aa67a2edc46
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19941 +/- ##
==========================================
+ Coverage 84.83% 85.67% +0.84%
==========================================
Files 3436 2504 -932
Lines 164623 140422 -24201
Branches 44956 38154 -6802
==========================================
- Hits 139654 120307 -19347
+ Misses 23014 19606 -3408
+ Partials 1955 509 -1446
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 932 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the exact head. The implementation and focused coverage match the stated contract; CI is settled green and no current review threads remain.
… and failed stages (#19945) ## Summary Billing web reports its cancel flow as billing.cancel.intent, billing.cancel.abandoned and billing.cancel.failed, using the cancel contract from FE-3115. ## Why E14 needs the cancel flow on both hosts. The cloud app gets it in FE-3115. Billing web reported nothing for its cancel flow: a customer who opened the confirmation and kept the plan, and a cancel the server refused before any operation existed, were invisible. A refusal before an operation exists is also invisible to the SDK stream, because the SDK only reports operations. ## How createCancelFlowTelemetry in apps/billing-web/src/telemetry/cancelTelemetry.ts reports intent when the confirmation opens, abandoned when the customer picks Keep my plan or the surface unmounts with the confirmation still open, and failed only when the cancel command returns a refusal (status error), classified through the shared outcomeOfCommandResult. Once the customer confirms, the flow is no longer abandoned, and a cancel that issued an operation ends in the SDK's billing.operation.* events with operation_type cancel, so this flow adds no terminal of its own. Each event carries billing_client sdk and the current plan's tier and cycle, which SubscriptionPanel passes down from the plan catalog. checkoutTierOf is exported from subscriptionCheckoutTelemetry.ts so both flows map server tiers the same way. There is no user-visible change. ## Review Focus - Ownership: failed fires only for status error; an ok result with or without an operation reports nothing here. - Abandoned on unmount covers leaving the surface in the app; closing the tab with the confirmation open is not reported. - A thrown cancel command (not a returned refusal) reports nothing, matching the cloud rule that a confirmed flow's end belongs to the operation. - Merge note: origin/main's #19811 adds the resubscribe telemetry import on the same lines of SubscriptionActions.vue. Merging main into this branch (or into FE-3115) gives a two-line import conflict; keep both imports. ## AS IS / TO BE Captured through the real telemetry providers in the component and composable tests (Datadog RUM action and PostHog event carry identical payloads, `billing_surface` per host). AS IS = base branch, TO BE = this branch. | Path | Host | AS IS | TO BE | | --- | --- | --- | --- | | reports opening the confirmation and keeping the plan | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly)<br>`billing.cancel.abandoned` (billing_client: sdk, current_tier: pro, cycle: yearly) | | reports leaving the page while the confirmation is open as abandoned | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly)<br>`billing.cancel.abandoned` (billing_client: sdk, current_tier: pro, cycle: yearly) | | leaves the end of a cancel the server settled to the operation events | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly) | | leaves the end of a cancel operation that failed to the operation events | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly) | | leaves the end of a cancel that already held to the operation events | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly) | | reports a request that never reached the server as a failed cancel before any operation exists | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly)<br>`billing.cancel.failed` (billing_client: sdk, current_tier: pro, cycle: yearly, failure_category: network) | | reports no subscription to cancel as a failed cancel before any operation exists | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly)<br>`billing.cancel.failed` (billing_client: sdk, current_tier: pro, cycle: yearly, failure_category: api_rejected) | | reports an earlier payment still open as a failed cancel before any operation exists | billing_web | nothing | `billing.cancel.intent` (billing_client: sdk, current_tier: pro, cycle: yearly)<br>`billing.cancel.failed` (billing_client: sdk, current_tier: pro, cycle: yearly, failure_category: api_rejected, error_code: operation_already_pending) | Captured RUM actions and PostHog events for eight cancel paths on billing web show nothing on the FE-3115 base and intent, abandoned or failed with tier, cycle and failure category on this branch (evidence-fe3117-web-cancel/). ## Where this sits in the plan Linear: [FE-3117](https://linear.app/comfyorg/issue/FE-3117), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | this PR | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | todo | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](#19804), [PR 19806](#19806) and [PR 19807](#19807), merged in [PR 19798](#19798) | | T11 | FE-3121 | Portal events | todo | | T12 | FE-3122 | Flag coverage check | [PR 19942](#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on PostHog key scopes | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T7 stroke-width:3px ``` --------- Co-authored-by: GitHub Action <action@github.com>
…he cloud app and billing web (#19944) ## Summary The cloud app and billing web report each trip to the Stripe portal as billing.portal.opened, billing.portal.failed and billing.portal.returned, with a bounded target of payment_methods, invoices or manage_subscription. ## Why Opening the Stripe portal, failing to open it and coming back were not recorded on either host. A portal failure reached error reporting only, so the Datadog Billing UI tab and the PostHog rollout dashboard could not count it. What the customer does inside the portal (add, remove or set a default card) never reaches the browser, so the trip itself is the only signal we can have. ## How A new contract module, portalEvent.ts, defines PortalBillingEvent (operation portal, stages opened, failed and returned) and BillingPortalTarget. It adds one line to the BillingTelemetryEvent union, three names to BILLING_TELEMETRY_EVENTS and target to the payload allowlist as a required field. On the cloud app, createBillingPortalReporter reports the open, the failure (blocked tab as redirect with payment_popup_blocked, other errors through describeBillingFailure) and the first return to the tab, using the same return signal as the billing refresh. Personal Manage subscription and Invoice history call it with billing_client legacy and keep their existing error toast and error report. Workspace Manage subscription calls it with billing_client sdk or legacy depending on which rail served the portal URL. On billing web, a usePaymentPortal composable now owns opening the portal and the portal=return marker for both the payment methods panel and the invoices page; it reports opened, failed (network, api_rejected, or unknown for a malformed URL) and returned once on landing. The invoices page's return URL now carries portal=return and strips it on arrival. There is no user-visible change. ## Review Focus - One return per open on the cloud app: only the latest open waits for a return, through a module-level stop handle in billingPortalTelemetry.ts. - Workspace Manage subscription reports billing_client only when it knows which rail answered; a thrown failure omits it. - useSubscription now calls accessBillingPortalDirect inside its own error wrapper so it can classify the failure; the toast and reportError behavior is unchanged. - PaymentMethodsPanel and InvoicesView moved their portal logic into usePaymentPortal; the invoices page now gets the portal=return marker and strips it. - Out of scope: the portal used for a plan change in PricingTable (its operation events already cover it), the payment recovery portal in useSubscriptionCheckout, and the hosted billing web tab that workspace Manage subscription opens when hosted billing is on (that is billing.web_handoff.opened). ## AS IS / TO BE Captured through the real telemetry providers in the component and composable tests (Datadog RUM action and PostHog event carry identical payloads, `billing_surface` per host). AS IS = base branch, TO BE = this branch. | Path | Host | AS IS | TO BE | | --- | --- | --- | --- | | reports manageSubscription opening the portal and one return | cloud_app | nothing | `billing.portal.opened` (target: manage_subscription, billing_client: legacy)<br>`billing.portal.returned` (target: manage_subscription, billing_client: legacy) | | reports handleInvoiceHistory opening the portal and one return | cloud_app | nothing | `billing.portal.opened` (target: invoices, billing_client: legacy)<br>`billing.portal.returned` (target: invoices, billing_client: legacy) | | reports manageSubscription as a failed open when the tab is blocked | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, billing_client: legacy, failure_category: redirect, error_code: payment_popup_blocked) | | reports handleInvoiceHistory as a failed open when the tab is blocked | cloud_app | nothing | `billing.portal.failed` (target: invoices, billing_client: legacy, failure_category: redirect, error_code: payment_popup_blocked) | | reports a refused portal request as a failed open and still reports the error | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, billing_client: legacy, failure_category: api_rejected) | | reports the portal opening from the SDK rail and one return | cloud_app | nothing | `billing.portal.opened` (target: manage_subscription, billing_client: sdk)<br>`billing.portal.returned` (target: manage_subscription, billing_client: sdk) | | reports the portal opening from the workspace client and one return | cloud_app | nothing | `billing.portal.opened` (target: manage_subscription, billing_client: legacy)<br>`billing.portal.returned` (target: manage_subscription, billing_client: legacy) | | reports a blocked portal tab as a failed open | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, failure_category: redirect, error_code: payment_popup_blocked) | | reports a refused portal request as a failed open | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, failure_category: api_rejected) | | reports the portal opening on the invoices | billing_web | nothing | `billing.portal.opened` (target: invoices, billing_client: sdk) | | reports the portal opening on the payment methods | billing_web | nothing | `billing.portal.opened` (target: payment_methods, billing_client: sdk) | | reports a portal it could not open as a failed open | billing_web | nothing | `billing.portal.failed` (target: payment_methods, billing_client: sdk, failure_category: api_rejected) | | reports the return from the portal once and drops the marker | billing_web | nothing | `billing.portal.returned` (target: invoices, billing_client: sdk) | | reports the return from the portal once | billing_web | nothing | `billing.portal.returned` (target: payment_methods, billing_client: sdk) | | reports a request that never reached the server as a failed portal open | billing_web | nothing | `billing.portal.failed` (target: invoices, billing_client: sdk, failure_category: network) | | reports a refusal from the server as a failed portal open | billing_web | nothing | `billing.portal.failed` (target: invoices, billing_client: sdk, failure_category: api_rejected) | | reports a portal address that fails validation as a failed portal open | billing_web | nothing | `billing.portal.failed` (target: invoices, billing_client: sdk, failure_category: unknown) | Captured RUM actions and PostHog events for each path on both hosts show nothing on the FE-3115 base and the matching billing.portal.* event with target, failure category and billing_surface on this branch (evidence-fe3121/). ## Where this sits in the plan Linear: [FE-3121](https://linear.app/comfyorg/issue/FE-3121), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](#19809), [PR 19810](#19810), [PR 19811](#19811), merged | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | todo | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](#19804), [PR 19806](#19806) and [PR 19807](#19807), merged in [PR 19798](#19798) | | T11 | FE-3121 | Portal events | this PR | | T12 | FE-3122 | Flag coverage check | [PR 19942](#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on PostHog key scopes | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T11 stroke-width:3px ```
…g screen (#19948) ## Summary Report an abandoned checkout and the ending screen on the billing web full-page checkout, and send the abandon to PostHog by beacon (E24, E25). ## Why customer_abandoned is the largest failure class on the backend, and the browser had no event for a customer who closes the tab or goes back with an unresolved checkout. The ending screen the customer saw was not reported either, so a funnel could not tell a success screen from a refusal. ## How The shared journey contract gains two phases, billing.checkout.abandoned (last_phase, exit) and billing.checkout.ended (ending_kind, attribution), as union lines in checkoutJourney.ts with their payload fields. They carry the journey context, so they join entered and operation_linked on checkout_journey_id and billing_op_id. useCheckoutJourney remembers the last progress phase, reports each new ending kind once, and reports abandoned once, only before any ending. The full-page checkout reports ended from its existing endingOf screen and terminal attribution. It reports abandoned with exit page_exit on pagehide, and with exit back from the Back control. It reports no abandon when the page handed itself to a hosted step or a method's own site. The billing web telemetry facade sends abandoned to PostHog with transport sendBeacon. PostHog drains its queue on its own pagehide listener, which runs before ours, so a plain capture there would be queued and lost. There is no user-visible change. ## Review Focus - Flush check: Datadog RUM 6.33 flushes by sendBeacon on visibilitychange hidden, freeze and beforeunload. It has no pagehide listener, but the browser fires visibilitychange after pagehide on unload, so an action added in pagehide is sent. PostHog 1.402 drains by beacon on pagehide, so only an event captured inside pagehide needs the sendBeacon option. - leftForPayment: a redirect to a hosted step or a non-card method's site is a redirect_started, not an abandon. - Existing journey tests now expect billing.checkout.ended after a preview failure and after a success. - Known gaps: the embedded billing web CheckoutView reports neither phase. The cloud app reports no abandoned event, because its journey is kept in session storage across dialogs and reloads, and whether a dialog close ends it needs a product decision. A tab closed while already in the background may not flush its RUM action, because visibilitychange already fired; the derived count of starts without terminals covers it (D8). ## AS IS / TO BE Telemetry change, so the evidence is the captured events instead of a screenshot: the real SDK lifecycle and the billing web checkout with only the network edge and the telemetry SDKs (Datadog RUM, posthog-js) stubbed. AS IS = origin/main, TO BE = this stack. | Path | AS IS | TO BE | | --- | --- | --- | | E24 tab closed at the quote | `entered`, `preview_ready` | adds `abandoned` (last_phase preview_ready, exit page_exit); PostHog copy sent with `{transport: 'sendBeacon'}` | | E24 Back control | `entered`, `preview_ready`, `web_return.clicked` | adds `abandoned` (exit back), once, even though the page then unloads | | E24 Alipay Pay leaving for its own site | no abandon | still no abandon (it is a redirect) | | E25 own payment succeeds | no ending event | `ended` (ending_kind success, attribution started); no abandon when the tab closes after it | | E25 refused workspace | no ending event | `ended` (ending_kind refused), no attribution | No payload carries an email, URL, client secret, promo code or provider id; every new field is a bounded enum. evidence-fe3119/as-is-billing-web.json shows the tab-close, Back, success and refusal paths with no abandoned or ended event on main, and to-be-billing-web.json shows abandoned with last_phase and exit to RUM and to PostHog with transport sendBeacon, ended with ending_kind and attribution, and no abandon for an Alipay Pay that left for its own site. ## Where this sits in the plan Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](#19809), [PR 19810](#19810), [PR 19811](#19811) merged, billing web cancel [PR 19945](#19945) in review | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | this PR | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](#19804), [PR 19806](#19806) and [PR 19807](#19807), merged in [PR 19798](#19798) | | T11 | FE-3121 | Portal events | [PR 19944](#19944), in review | | T12 | FE-3122 | Flag coverage check | [PR 19942](#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on PostHog key scopes | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T9 stroke-width:3px ```
… events (Comfy-Org#19943) ## Summary Cloud app checkout journey events (billing.checkout.*) now carry billing_surface: 'cloud_app' in Datadog RUM and PostHog. ## Why Decision T1 says every billing event carries billing_surface. On the cloud app the billing.<operation>.<stage> events already did, but the checkout journey events did not. Billing web stamps billing_web on the same journey events, so the Datadog tiles (FE-3124) that group by @context.billing_surface showed cloud journey traffic with no surface. ## Root cause getCheckoutJourneyTelemetryEventPayload builds the journey payload with no surface. The cloud Datadog RUM and PostHog providers sent it as is. Billing web adds the surface itself inside trackCheckoutJourneyEvent, so only billing web output had it. ## How A new getCloudAppCheckoutJourneyTelemetryEventPayload in packages/account-core/src/core/billing/telemetry/checkoutJourney.ts wraps the existing builder and adds billing_surface: 'cloud_app'. It mirrors getCloudAppBillingTelemetryEventPayload. Both cloud sinks that receive journey events (DatadogRumTelemetryProvider and PostHogTelemetryProvider) call it in trackCheckoutJourneyEvent. The shared builder and billing web are untouched. ## Review Focus - Only one field is added. Event names and every existing field value are unchanged (see the AS IS vs TO BE diff in the evidence). - Billing web output does not change. It still stamps billing_web itself on top of the unstamped shared builder. - Datadog RUM and PostHog are the only providers that implement trackCheckoutJourneyEvent, so no other sink needs the stamp. ## AS IS / TO BE Telemetry payload change, so the evidence is the captured event rather than a screenshot. One `billing.checkout.entered` sent through the real cloud Datadog RUM and PostHog providers, origin/main (AS IS) vs this branch (TO BE): ```diff 23c23,24 < "payment_intent_source": "subscribe_to_run" --- > "payment_intent_source": "subscribe_to_run", > "billing_surface": "cloud_app" 37c38,39 < "payment_intent_source": "subscribe_to_run" --- > "payment_intent_source": "subscribe_to_run", > "billing_surface": "cloud_app" ``` Captured payloads for one billing.checkout.entered event through the real cloud Datadog RUM and PostHog providers show billing_surface missing on origin/main and billing_surface: 'cloud_app' on the branch, with all other fields identical (evidence-fe3111-journey-surface/). ## Where this sits in the plan Linear: [FE-3111](https://linear.app/comfyorg/issue/FE-3111), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | this PR | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811), merged | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | todo | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | todo | | T12 | FE-3122 | Flag coverage check | todo | | T13 | FE-3123 | PostHog rollout dashboard | todo | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style F3 stroke-width:3px ```
…ads feature flags (Comfy-Org#19942) ## Summary Billing web sends its billing events to PostHog only after PostHog has loaded the feature flags, so every event carries the rollout flags the cohort tiles split on. ## Why The rollout dashboard splits billing events by $feature/<flag>. PostHog adds those properties only from the flags it has already loaded on that origin. Billing web flushed the events it queued at boot right after init, before the flags request answered, and a first visit to billing.comfy.org has no cached flags. Its entry, session and first journey events would reach PostHog without any flag, so the cohort split and the second sign-in tile by unified_web_session would miss them. ## Root cause startPostHog marked the sink ready and flushed the waiting queue as soon as posthog.init returned. Flags load asynchronously after init and are stored per origin, so the flushed events had no $feature/* properties. ## How startPostHog now waits for PostHog's first onFeatureFlags callback before it marks the sink ready and flushes. The wait is bounded at 3 seconds, so a slow or blocked flags request delays events but never drops them. Events tracked during the wait stay in the existing bounded queue. The README notes the wait. There is no user-visible change. ## Review Focus - The 3 second bound: long enough for the flags request, short enough that a tab closed early still sends. - Events tracked while waiting use the existing queue of at most 50 events. - The test fake makes onFeatureFlags call back at once by default, as posthog-js does when flags are already loaded. ## AS IS / TO BE AS IS: placeholder, to be attached by editing this description. TO BE: placeholder, to be attached by editing this description. PostHog has no billing web events yet because the deployed billing web builds predate the PostHog sink, so the evidence is the red then green unit test plus the cloud coverage queries in t12-flag-coverage.md; AS IS / TO BE payload capture needs a billing web deploy from this branch. ## Where this sits in the plan Linear: [FE-3122](https://linear.app/comfyorg/issue/FE-3122), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811), merged | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | todo | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | todo | | T12 | FE-3122 | Flag coverage check | this PR | | T13 | FE-3123 | PostHog rollout dashboard | todo | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T12 stroke-width:3px ```
…nside a billing operation (Comfy-Org#19946) ## Summary Report 3DS challenges and retryable declines inside one billing operation, from the SDK lifecycle, on the cloud app and billing web (E22). ## Why The backend files most failed subscribes as customer_abandoned or expected payment failures, and the browser reported none of the friction behind them. The SDK already tracked the challenge, but the driver's verdict was thrown away and a retryable decline left no trace until the operation ended. ## Root cause usePaymentAttempt and the cloud SDK store call driveEmbeddedChallenge with void, and the lifecycle only emitted billing.operation.* for start and terminal. A pending operation could move through a challenge, its verdict and several declines without one event. ## How A new contract module checkoutChallengeEvent.ts adds billing.checkout.challenge_required, challenge_completed and challenge_failed to the BillingTelemetryEvent union (one line). All stages stay pending, so they never count as terminals. A pure function paymentFrictionBetween compares two states of one pending operation, and the lifecycle runs it on every transition and at adoption. challenge_required fires once per new client secret. challenge_completed and challenge_failed fire on this tab's driver verdict. Each new retryable decline reason fires challenge_failed with decline_reason, except the server's echo of a challenge this tab already saw fail. toBillingTelemetryEvent maps the three onto operation checkout. Billing web forwards them through the existing onTelemetry wiring. The cloud store forwards them for every operation, including an issued top-up whose start and terminal the dialog reports. Fields are decline_reason, presentation, operation_type, billing_op_id and resumed, all already in the allowlist. There is no user-visible change. ## Review Focus - paymentFrictionBetween: one required per client secret, no second required when a failed challenge returns from the hosted page, and the echo rule for a decline after a failed challenge. - The cloud reportTelemetry change: friction events skip the top-up and caller-started filters on purpose. - challenge_failed carries decline_reason only for a server decline. Without it, it is this tab's own verdict. - Known gap: the legacy cloud rail (billingOperationStore and the legacy subscribe path) reports no friction. Only the SDK rail does. ## AS IS / TO BE Telemetry change, so the evidence is the captured events instead of a screenshot: the real SDK lifecycle and the billing web checkout with only the network edge and the telemetry SDKs (Datadog RUM, posthog-js) stubbed. AS IS = origin/main, TO BE = this stack. | Path | AS IS | TO BE | | --- | --- | --- | | E22 embedded 3DS challenge completed / failed | `billing.operation.started` only | adds `billing.checkout.challenge_required`, then `challenge_completed` or `challenge_failed` (presentation embedded) | | E22 retryable declines in one hosted operation | `billing.operation.started` only | `challenge_failed` with `decline_reason: card_declined`, then `insufficient_funds` (presentation hosted) | | E22 billing web SDK, real client | `billing.operation.started` only | adds `challenge_failed` with `decline_reason`, to RUM and PostHog, `billing_surface: billing_web` | No payload carries an email, URL, client secret, promo code or provider id; every new field is a bounded enum. evidence-fe3119/as-is-lifecycle.json and to-be-lifecycle.json show the same embedded challenge and hosted decline scenarios emitting only billing.operation.started on main and the challenge events with presentation and decline_reason on the branch, for both cloud_app and billing_web payloads, and to-be-billing-web.json shows the billing web SDK sending challenge_failed with decline_reason to RUM and PostHog. ## Where this sits in the plan Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811) merged, billing web cancel [PR 19945](Comfy-Org#19945) in review | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | this PR | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | [PR 19944](Comfy-Org#19944), in review | | T12 | FE-3122 | Flag coverage check | [PR 19942](Comfy-Org#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on PostHog key scopes | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T9 stroke-width:3px ```
…p amount and the cancel flow as billing events (Comfy-Org#19815) ## Summary Cloud entry fidelity and Datadog parity, in five parts reviewed together: paywall impressions and add-credits clicks as typed billing entry events that reach Datadog, the entry source carried through top-up, downgrade and recovered operations with one source vocabulary, the amount and preset on `billing.topup.started`, and the cancel flow as `billing.cancel.intent`, `.abandoned` and `.failed` through a surface-free contract that billing web reuses, and each trip to the Stripe portal as `billing.portal.opened`, `.failed` and `.returned` on the cloud app and billing web. ## Why PostHog, Mixpanel and GTM receive the paywall impression and the add-credits click. Datadog receives neither, so the Billing UX board cannot show where a billing attempt started. Three entries emit nothing anywhere: the inactive-member dialog, the out-of-credits banner and the credits precondition. Five add-credits entries opened the top-up dialog with no source, so `billing.entry.add_credits_clicked` and `billing.topup.started` could not say where the customer came from. The downgrade events carried no source at all. After a reload the poller and the SDK lifecycle report a terminal for an operation they did not start, and the checkout journey keeps only a collapsed `entry_source`, so those terminals lost the source. Datadog receives top-up starts but not what was bought. PostHog, Mixpanel and GTM get the amount from the legacy purchase-click event only. Funnels by amount and by preset need the amount on the canonical start. The cancel flow stages reach PostHog and the desktop sink only. Datadog cannot show how many customers open the cancel flow, how many leave it, or where it breaks. The cancel request itself is already reported as `billing.operation.*` with `operation_type: cancel`. Opening the Stripe portal, failing to open it and coming back were not recorded on either host. A portal failure reached error reporting only, and what the customer does inside the portal never reaches the browser, so the trip itself is the only signal. ## Root cause (1) `DatadogRumTelemetryProvider` implements only the typed `trackBillingEvent`, and the paywall and add-credits trackers are legacy methods it never had. There was no typed event for either, and three entries never called a tracker. (2) `showTopUpCreditsDialog()` was called without options from the popover, the tile, the settings panel and the deep link. `useDowngradeToPersonal` had no source parameter. The checkout journey record stored `entry_source` (`pricing`, `settings_billing` or `agent_paywall`) and nothing finer, and no emitter read it back for a recovered operation. (3) `billing.topup.started` carried only the entry source. The dialogs know the amount and which preset button was picked, but neither field had a place in the billing event contract. (4) The legacy `trackSubscriptionCancellation` stages (`flow_opened`, `abandoned`, `failed`) have no typed counterpart, and the stage `abandoned` was not part of the billing vocabulary. (5) No event existed for the portal: `accessBillingPortal` and the billing web portal views opened Stripe and swallowed or reported the result without a billing event. ## How **Part 1, entry events (was Comfy-Org#19815)** - **Contract.** A new `entryEvent.ts` in `packages/account-core/src/core/billing/telemetry` defines operation `entry` with stages `paywall_shown` and `add_credits_clicked`, outcome `pending`. `paywall_shown` carries `current_tier` (bounded: the five tier keys plus `team`). Both carry the optional `payment_intent_source`. One line in the `BillingTelemetryEvent` union, one allowlist field (`current_tier`), two names in `BILLING_TELEMETRY_EVENTS`. - **E1.** `useSubscriptionDialog` reports `paywall_shown` for every pricing dialog variant and for the inactive-member dialog. The source is the one the dialog already hands to checkout (`paymentIntentSource ?? reason`). - **E2.** `dialogService.showTopUpCreditsDialog` reports `add_credits_clicked` on its first line, before the capability read. The source is `options.source`, or `out_of_credits` when the caller says `isInsufficientCredits`. This covers every entry that opens the top-up dialog, including the banner and the credits precondition. - **Datadog parity.** The provider needed no change: both events go through `trackBillingEvent`, so Datadog builds the action and payload from the shared builder and stamps `billing_surface: cloud_app`. PostHog and the desktop sink receive the same events through the same method. - **Legacy events.** `trackSubscription('modal_opened')`, `trackAddApiCreditButtonClicked` and their sinks are untouched. A test with a legacy provider beside the Datadog provider proves the paywall legacy event still arrives once. **Part 2, source fidelity (Comfy-Org#19816, merged here)** - **Mapping.** `src/platform/telemetry/utils/paymentIntentSource.ts` holds two tables. The click-time source maps to the list: `credits_panel` and `settings_billing_panel` to `settings_billing_panel`, `avatar_menu` to `avatar_menu_plans`, `deep_link` and `agent_paywall` to themselves. The journey `entry_source` maps to the list where it names a control: `deep_link`, `settings_billing` (to `settings_billing_panel`) and `agent_paywall`. `pricing`, `recovery`, `other` and `unknown` name no source. `payment_intent_source` is the list itself. An `it.for` table covers all three. - **Entries.** The two popovers pass `avatar_menu_plans`, the credits tile and the settings panel pass `settings_billing_panel`, the deep link passes `deep_link`. The legacy `trackAddApiCreditButtonClicked` calls are untouched. `dialogService` now forwards the options to both rails. The legacy top-up dialog declares `source` and reports it on `billing.topup.started` and `failed`. - **Downgrade.** `DowngradeToPersonalBillingEvent` gains `payment_intent_source`. The subscription checkout passes its source to `showDowngradeToPersonalDialog`, which hands it to `useDowngradeToPersonal`. All nine events of an attempt carry it (the downgrade, the nested subscription checkout and the nested operation), and so does the metadata the poller adopts for a payment that settles later. - **Recovered terminals.** The checkout journey record keeps `payment_intent_source` next to `entry_source` (stored only; the emitted journey events and `entry_source` do not change). `getCheckoutJourneyPaymentIntentSource(opId)` returns it for the journey bound to that operation, and falls back to the mapped `entry_source` for a record written before this change. The poller reads it when it adopts an operation with no metadata, and the SDK store attaches it to the lifecycle events of an operation bound to a journey. **Part 3, top-up amount and preset (Comfy-Org#19817, merged here)** - **Contract.** `topupEvent.ts` gains `TOPUP_AMOUNT_PRESETS_USD` (10, 25, 50, 100), the `TopupAmountPreset` type (the four values as strings, or `custom`) and `getTopupAmountPreset`. The started stage gains optional `amount_cents` and `amount_preset`. Both are allowlist fields, bounded: an integer and a fixed enum, nothing free-form. - **Emitters.** The workspace dialog and the legacy dialog report both fields on the start event. The preset is the button the customer picked. Any typed amount is `custom`, including a typed amount that equals a preset. The workspace dialog computes the cents once and uses the same value for the API call. - **One list of presets.** Both dialogs now read the preset amounts from `TOPUP_AMOUNT_PRESETS_USD` instead of each keeping its own `[10, 25, 50, 100]`, so the telemetry enum and the buttons cannot drift. - **Datadog.** A test drives the real dialog through the real registry and the Datadog provider and checks the `billing.topup.started` action with the amount, the preset, the source and `billing_surface: cloud_app`. **Part 4, cancel flow (Comfy-Org#19818, merged here)** - **Contract.** `cancelEvent.ts` defines operation `cancel` with stages `intent` and `failed` (the shared stage types) and the new `abandoned` (outcome `pending`: the customer left, no operation outcome is claimed). It carries only `current_tier` and `cycle`, both plan facts that exist on any surface, and no surface-specific field. One union line and three names. No new allowlist field. - **Plan facts.** `toCurrentTier` moved from `useSubscriptionDialog` to `billingPlanTelemetry.ts` and gained `toBillingCycle`, with a table test. `createCancelFlowReporter` in `subscriptionCancellationTelemetry.ts` builds the events for both flows, so the ownership rule below lives in one place. - **Ownership.** The reporter emits `intent` where the legacy `flow_opened` fires. It emits `abandoned` where the legacy `abandoned` fires, unless the customer already confirmed. When the confirmed cancel becomes an operation (the workspace rail), its `billing.operation.*` events own the end of the attempt, so the reporter emits no `failed` either. `failed` is reported only for a flow that ends with no operation: the legacy-rail dialog when its cancel fails, and a provider failure whose native dialog cannot open (category `rendering`). `useWorkspaceBilling.cancelSubscription` is unchanged. - **Flows covered.** The provider (Churnkey) flow in `launchCancellationFlow` and the native `CancelSubscriptionDialogContent`, which also carries the attempt on after a provider failure (`flowAlreadyOpened`). - **Tests.** Table-driven through the real flows with the telemetry sink recording: each row's expected cancel events are literal, and a Datadog row shows the billing actions with `billing_surface: cloud_app`. **Part 5, portal events (Comfy-Org#19944, merged here)** - **Contract.** `portalEvent.ts` in `packages/account-core/src/core/billing/telemetry` defines operation `portal` with stages `opened`, `failed` and `returned`, and `BillingPortalTarget` (`payment_methods`, `invoices`, `manage_subscription`). One line in the `BillingTelemetryEvent` union, three names in `BILLING_TELEMETRY_EVENTS`, and `target` as a required allowlist field. - **Cloud app.** `createBillingPortalReporter` reports the open, the failure (a blocked tab as `redirect` with `payment_popup_blocked`, other errors through `describeBillingFailure`) and the first return to the tab, on the same return signal as the billing refresh. Only the latest open waits for a return. Personal Manage subscription and Invoice history report `billing_client: legacy`; workspace Manage subscription reports the rail that answered and omits `billing_client` on a thrown failure. - **Billing web.** `usePaymentPortal` holds the portal logic of `PaymentMethodsPanel` and `InvoicesView`. The invoices page now gets the `portal=return` marker and strips it. - **Out of scope.** The plan-change portal in `PricingTable` (its operation events cover it), the payment recovery portal in `useSubscriptionCheckout`, and the hosted billing web tab that workspace Manage subscription opens (that is `billing.web_handoff.opened`). ## Review Focus - FE-3140 (Comfy-Org#19798) is merged into main (`a8337f39a4`) and the base of this PR is main. Five parts in one PR: they were opened as Comfy-Org#19815, Comfy-Org#19816, Comfy-Org#19817, Comfy-Org#19818 and Comfy-Org#19944, stacked, and parts 2 to 5 were merged into this branch after Christian approved each at its own head; this PR carries all five against main. It is a sibling of the FE-3117 part 3 (Comfy-Org#19811) and FE-3118 (Comfy-Org#19819) PRs, which touch shared contract files only by adding separate lines. - Merged with the moved FE-3140 base (`cbbe1c4568`): the SDK operation mapper moved to `@comfyorg/account-core/billing` as `operationLifecycleEvent.ts` while part 2 added an optional `paymentIntentSource` argument to it. That argument now imports `PaymentIntentSource` from `./vocabulary.js` (the app-side import did not resolve inside the package) and a new test covers it, since the old app-side mapper test went away with the move. No other base test needed changing. - Part 1: E2 sends the entry as `payment_intent_source`, not `source`. The Notion catalog names the field `source`, but every other billing event uses `payment_intent_source` for this list, and `source` already means the resubscribe surface in the allowlist. - Part 1: E2 fires at `showTopUpCreditsDialog`, so it also fires when the dialog then falls back to the pricing table or the member notice. The legacy click event is gated in the deep link and the agent paywall (only when the user can top up); the new event is not. A deep-link visitor who cannot top up now produces `add_credits_clicked` followed by `paywall_shown`, both with the same source. - Part 1: Until part 2 lands, the popover, the credits tile, the settings panel, the deep link and the banner call the dialog with no source, so their E2 carries none. Part 2 passes it. - Part 1: `outcome` is `pending`, as for `web_handoff`: an entry is a client journey observation and claims no operation outcome. - Part 1: `current_tier` is bounded where the legacy `current_tier` was a free lowercase string: `TEAM` becomes `team`, `ENTERPRISE` and an unknown tier are omitted. - Part 1: Not covered: the insufficient-credits member notice that `showTopUpCreditsDialog` opens for a member who cannot top up. The ticket names the inactive-member dialog only. - Part 1: PostHog and the desktop host now also receive `billing.entry.*` next to the legacy names, so a PostHog funnel can use either. - Part 1: No user-visible change: the diff adds telemetry calls only. No dialog, prop or code path changes. - Part 2: No new source value. `recovery` is not produced: no entry creates a recovery journey, a recovered operation is already marked `resumed: true`, and it now carries the source of the journey it is bound to. The journey `entry_source` is unchanged, so `deep_link` and `recovery` stay unproduced there. An existing test pins that `deep_link` leaves the rail default, and the decision says existing payloads do not change. - Part 2: The avatar menu's add-credits control maps to `avatar_menu_plans`, so one value covers the whole avatar menu. `credits_panel` and `settings_billing_panel` collapse into `settings_billing_panel`. Say if either should keep its own value; that needs a new list entry. - Part 2: No user-visible change is intended, but one code path moves. A customer who cannot top up but can subscribe lands on the pricing dialog. Its `reason` was `top_up_blocked` and is now the entry's source. Only `out_of_credits` changes the dialog copy and none of these entries uses it. The legacy `modal_opened` event's `reason` and the `source` on the hosted billing link change the same way for those customers. - Part 2: The out-of-credits banner is not changed. Its natural source is `out_of_credits`, and passing that would switch on the out-of-credits copy in the pricing fallback, a visible change. It still reports `add_credits_clicked` with no source. - Part 2: A resumed journey keeps the source of the entry that created it. The journey intent key does not include the source, so two entries into the same journey report the first one on a recovered terminal. - Part 2: Known gaps: a legacy-rail hosted top-up whose success is inferred on return (credits tile and usage table) still reports no source, because the pending top-up marker is a bare timestamp. The SDK lifecycle's own `started` event fires before the journey binds to the operation, so only its terminals carry the source. - Part 2: The existing test 'withholds the surface from the legacy rail content' is replaced: the legacy dialog now takes the source, so withholding it is no longer the rule. - Part 3: `amount_preset` is a string enum (`'10'`, `'25'`, `'50'`, `'100'`, `'custom'`), not a number, so a Datadog facet has one type. The ticket says 'the existing preset enum'; there was no enum, only the dialogs' local arrays, so this adds the type and takes the values from the same list the buttons use. - Part 3: A typed amount that equals a preset reports `custom`. The field says which control the customer used, not what the amount happens to be. `amount_cents` carries the amount either way. - Part 3: Both new fields are optional on the stage, not required, so a surface that cannot supply them (billing web later) is not forced to invent them. The legacy rail is covered: the legacy dialog reports them too. - Part 3: The recovered legacy top-up success (credits tile, usage table) has no start event in that tab and still carries no amount. - Part 3: The legacy PostHog, Mixpanel and GTM purchase-click event is untouched. - Part 3: No user-visible change: the diff adds telemetry fields and replaces two local constants with the shared list. - Part 4: The Notion catalog lists `source` and `failure_category` as E14 key fields. `source` is not in the event: the cloud app only ever sends `cancel_plan_menu`, billing web has its own entry, and neither value belongs to the one source list. Add it when billing web needs it. The legacy `current_tier`, `cycle` and `end_date` are replaced by the bounded `current_tier` and `cycle`; the end date and the error message are not sent. - Part 4: `outcome` for `abandoned` is `pending`, so a dashboard that counts `outcome: success` and `outcome: failure` is not moved by customers who leave. - Part 4: A provider failure that falls back to the native dialog reports no `failed`: the attempt continues in the dialog and ends there. Reporting both would give one attempt two endings. - Part 4: A discount accepted in the provider flow ends with `intent` and no end event. The customer kept the plan, which is neither an abandonment nor a cancel, and the legacy event does not report it either. Say if you want a stage for it. - Part 4: On the legacy billing rail the cancel completes in the Stripe portal, so a flow ends in `intent` and nothing else unless the request fails. There is no operation to wait for. - Part 4: No user-visible change: the diff adds telemetry calls, a plan helper and a moved function. No dialog, copy or code path changes. - Part 4: FE-3117 can emit the billing web side with `CancelBillingEvent` as it stands. - `UnifiedPricingTable.test.ts` ("prompts free-tier users to subscribe") fails locally on `origin/main` too (`INTERNAL ASSERTION FAILED: Expected a class definition`, local Node 24 against engine 26). This diff does not touch it. - Review fixes after CodeRabbit (`e1ba955394`, red tests first): a fallback dialog opened after the customer confirmed in the provider flow no longer reports `billing.cancel.abandoned` (the fallback receives `flowAlreadyConfirmed`), and a native fallback that cannot open after a confirmed cancel reports `billing.cancel.failed` with `rendering` (the reporter drops the expectation that an operation follows once the provider session fails, via `sessionFailed()`). The other cancel sequences are unchanged. - Merged with main after Comfy-Org#19921 (`b91f4e77d2`, wait for the workspace type instead of falling back to legacy billing). Two hunks met part 5 and part 2. `manageSubscription` keeps the portal telemetry and takes main's rule: a `WORKSPACE_BILLING_REQUIRED` refusal is reported as `billing.portal.failed` and rethrown for the legacy adapter to recover, any other failure is reported and not thrown. Invoice history keeps its error wrapper. The top-up dialog takes main's chooser (only `legacy` opens the legacy content, `unknown` opens the workspace content) and keeps part 2's full props, since the legacy content now declares `source`. ## AS IS / TO BE **Part 1, entry events** AS IS:  TO BE:  **Part 2, source fidelity** AS IS:  TO BE:  **Part 3, top-up amount and preset** AS IS:  TO BE:  **Part 4, cancel flow** AS IS:  TO BE:  **Part 5, portal events** Captured through the real telemetry providers in the component and composable tests (Datadog RUM action and PostHog event carry identical payloads, `billing_surface` per host). AS IS = the FE-3115 branch before part 5, TO BE = after. | Path | Host | AS IS | TO BE | | --- | --- | --- | --- | | reports manageSubscription opening the portal and one return | cloud_app | nothing | `billing.portal.opened` (target: manage_subscription, billing_client: legacy)<br>`billing.portal.returned` (target: manage_subscription, billing_client: legacy) | | reports handleInvoiceHistory opening the portal and one return | cloud_app | nothing | `billing.portal.opened` (target: invoices, billing_client: legacy)<br>`billing.portal.returned` (target: invoices, billing_client: legacy) | | reports manageSubscription as a failed open when the tab is blocked | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, billing_client: legacy, failure_category: redirect, error_code: payment_popup_blocked) | | reports handleInvoiceHistory as a failed open when the tab is blocked | cloud_app | nothing | `billing.portal.failed` (target: invoices, billing_client: legacy, failure_category: redirect, error_code: payment_popup_blocked) | | reports a refused portal request as a failed open and still reports the error | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, billing_client: legacy, failure_category: api_rejected) | | reports the portal opening from the SDK rail and one return | cloud_app | nothing | `billing.portal.opened` (target: manage_subscription, billing_client: sdk)<br>`billing.portal.returned` (target: manage_subscription, billing_client: sdk) | | reports the portal opening from the workspace client and one return | cloud_app | nothing | `billing.portal.opened` (target: manage_subscription, billing_client: legacy)<br>`billing.portal.returned` (target: manage_subscription, billing_client: legacy) | | reports a blocked portal tab as a failed open | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, failure_category: redirect, error_code: payment_popup_blocked) | | reports a refused portal request as a failed open | cloud_app | nothing | `billing.portal.failed` (target: manage_subscription, failure_category: api_rejected) | | reports the portal opening on the invoices | billing_web | nothing | `billing.portal.opened` (target: invoices, billing_client: sdk) | | reports the portal opening on the payment methods | billing_web | nothing | `billing.portal.opened` (target: payment_methods, billing_client: sdk) | | reports a portal it could not open as a failed open | billing_web | nothing | `billing.portal.failed` (target: payment_methods, billing_client: sdk, failure_category: api_rejected) | | reports the return from the portal once and drops the marker | billing_web | nothing | `billing.portal.returned` (target: invoices, billing_client: sdk) | | reports the return from the portal once | billing_web | nothing | `billing.portal.returned` (target: payment_methods, billing_client: sdk) | | reports a request that never reached the server as a failed portal open | billing_web | nothing | `billing.portal.failed` (target: invoices, billing_client: sdk, failure_category: network) | | reports a refusal from the server as a failed portal open | billing_web | nothing | `billing.portal.failed` (target: invoices, billing_client: sdk, failure_category: api_rejected) | | reports a portal address that fails validation as a failed portal open | billing_web | nothing | `billing.portal.failed` (target: invoices, billing_client: sdk, failure_category: unknown) | The evidence has five parts, one per part of the change: the events each cloud entry, source, top-up, cancel and portal path reports to Datadog RUM, PostHog and the desktop sink, before and after. ## Where this sits in the plan Linear: [FE-3115](https://linear.app/comfyorg/issue/FE-3115), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | this PR | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811), merged | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | todo | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | [PR 19944](Comfy-Org#19944), merged into this PR | | T12 | FE-3122 | Flag coverage check | [PR 19942](Comfy-Org#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on PostHog key scopes | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T5 stroke-width:3px ``` --------- Co-authored-by: GitHub Action <action@github.com>
… it (Comfy-Org#19947) ## Summary Report a hosted step the customer is sent to and the return from it, on the cloud app and billing web (E23). ## Why A hosted redirect unloads the page, so the operation's start stayed open with nothing to say the customer left for Stripe or the billing app. Without a start and a return, a customer who never came back looks the same as one the browser lost. ## How A new contract module checkoutRedirectEvent.ts adds billing.checkout.redirect_started and billing.checkout.returned (one union line). Fields are destination (stripe or billing_web), step (authentication, payment_method, invoice_payment or checkout, read from what the server waits on), navigation (redirect or new_tab) and optional method_kind. destination, step, navigation and method_kind join the allowlist. The lifecycle gains reportHostedStepOpened(operationId, navigation, methodKind?). It emits redirect_started. For a redirect it stores the step in the operation pointer, so the page the customer lands on reports returned once when it recovers the operation. Rewriting the pointer drops the marker, so a reload does not count it again. For a new tab it reports returned on the next wake. usePaymentAttempt reports the hosted step before it hands the URL to the host, so the event is queued before the page unloads. It also reports an embedded challenge as a redirect when the host says the method is not a card, because Stripe finishes Alipay and similar methods on their own site. The billing web full-page checkout passes the method of its own Pay. The cloud SDK store reports a hosted page it opened in a new tab. There is no user-visible change. ## Review Focus - The redirect marker in the operation pointer schema, and that adoption rewrites the pointer without it. - Reporting before openUrl is deliberate. Datadog RUM flushes on beforeunload and visibilitychange, and PostHog drains its queue by beacon on pagehide, so an event queued before location.assign is sent. - The off-site challenge rule in usePaymentAttempt: a required challenge plus a non-card method kind is reported as a redirect. - BillingOperationTelemetryEvent is now a discriminated union, so a redirect event cannot be built without destination, step and navigation. - Known gaps: method_kind is only known for a non-card Pay on the billing web full-page checkout. The legacy cloud subscribe path that calls window.open directly is not covered. A return after a same-tab redirect that lands on a page with no pointer storage is not reported. ## AS IS / TO BE Telemetry change, so the evidence is the captured events instead of a screenshot: the real SDK lifecycle and the billing web checkout with only the network edge and the telemetry SDKs (Datadog RUM, posthog-js) stubbed. AS IS = origin/main, TO BE = this stack. | Path | AS IS | TO BE | | --- | --- | --- | | E23 same-tab redirect | page that left: `started`; page it came back to: `started`, `succeeded` | left: `redirect_started` (destination stripe, step payment_method, navigation redirect, method_kind alipay); came back: `returned` with the same fields, `resumed: true` | | E23 new tab | `started` only | `redirect_started` then `returned` on the next wake (navigation new_tab) | No payload carries an email, URL, client secret, promo code or provider id; every new field is a bounded enum. evidence-fe3119/as-is-lifecycle.json shows the redirect and new-tab scenarios sending only billing.operation.started and succeeded on main, and to-be-lifecycle.json shows redirect_started on the page that left, returned with the same step and method on the page it came back to, and the new-tab pair, for both surfaces. ## Where this sits in the plan Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811) merged, billing web cancel [PR 19945](Comfy-Org#19945) in review | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | this PR | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | [PR 19944](Comfy-Org#19944), in review | | T12 | FE-3122 | Flag coverage check | [PR 19942](Comfy-Org#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | specified, blocked on PostHog key scopes | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T9 stroke-width:3px ```
…ilures and returns (Comfy-Org#19973) ## Summary The payment recovery portal that checkout opens after a failed or outstanding payment now reports billing.portal.opened, billing.portal.failed and billing.portal.returned with the new target payment_recovery. ## Why FE-3121 instrumented Manage subscription, Invoice history and the billing web portal, but left out the portal that useSubscriptionCheckout opens when a plan change is refused for an unpaid invoice. That trip is the only way a customer in payment_failed or paused can get unstuck, and it reached error reporting only on failure and nothing at all on success. The Datadog Billing UI tab and the PostHog rollout dashboard could not count it. ## How recoverOutstandingPayment now uses createBillingPortalReporter, the same reporter as the other cloud portal entries. readPaymentPortalUrl returns which client served the URL, so opened, failed and returned carry billing_client sdk or legacy once that is known. A thrown request failure omits billing_client, as the workspace Manage subscription path does. A blocked tab is failed with redirect and payment_popup_blocked. When the toast's Try again then opens the tab, that click is the open and waits for one return. A URL that fails the origin check is failed with unknown. The contract gains one bounded value, payment_recovery, in BillingPortalTarget. None of the existing values fits: payment_methods is the voluntary card management panel on billing web, and folding recovery into it would hide how often checkout blocks on an unpaid invoice. target is already allowlisted as a required payload field, so the allowlist needs no new key. There is no user-visible change. Toasts, the Try again action, the return refresh and the reportError calls are unchanged. ## Review Focus - billing_client is set only after the URL came back. A rail error or a refused workspace request omits it, matching useWorkspaceBilling; a URL rejected by the origin check keeps it. - The toast's Try again now checks the window.open result to report opened or blocked. It still arms the return refresh either way, as before. - A stale attempt (isCurrent false) reports nothing, the same way it shows nothing. - payment_recovery is a new BillingPortalTarget value. Dashboards that list portal targets need the fourth value (T13 PostHog, T14 Datadog tiles). - Comfy-Org#19921 is untouched: the WORKSPACE_BILLING_REQUIRED rethrow lives in useSubscription, not in this path. ## AS IS / TO BE Captured through the real telemetry providers in the component and composable tests (Datadog RUM action and PostHog event carry identical payloads, `billing_surface` per host). AS IS = base branch, TO BE = this branch. | Path | Host | AS IS | TO BE | | --- | --- | --- | --- | | reports the recovery portal opening from the legacy client and one return | cloud_app | nothing | `billing.portal.opened` (target: payment_recovery, billing_client: legacy)<br>`billing.portal.returned` (target: payment_recovery, billing_client: legacy) | | reports the recovery portal opening from the SDK rail and one return | cloud_app | nothing | `billing.portal.opened` (target: payment_recovery, billing_client: sdk)<br>`billing.portal.returned` (target: payment_recovery, billing_client: sdk) | | reports the recovery portal opening from the legacy client when the rail route i… and one return | cloud_app | nothing | `billing.portal.opened` (target: payment_recovery, billing_client: legacy)<br>`billing.portal.returned` (target: payment_recovery, billing_client: legacy) | | reports a blocked recovery tab as a failed open and the retry as the open | cloud_app | nothing | `billing.portal.failed` (target: payment_recovery, billing_client: legacy, failure_category: redirect, error_code: payment_popup_blocked)<br>`billing.portal.opened` (target: payment_recovery, billing_client: legacy)<br>`billing.portal.returned` (target: payment_recovery, billing_client: legacy) | | reports a refused legacy portal request as a failed open and keeps the error report | cloud_app | nothing | `billing.portal.failed` (target: payment_recovery, failure_category: api_rejected) | | reports a legacy portal request that never reac… as a failed open and keeps the error report | cloud_app | nothing | `billing.portal.failed` (target: payment_recovery, failure_category: network) | | reports a rail portal failure as a failed open and keeps the error report | cloud_app | nothing | `billing.portal.failed` (target: payment_recovery, failure_category: api_rejected) | | reports a portal address that fails validation as a failed open and keeps the error report | cloud_app | nothing | `billing.portal.failed` (target: payment_recovery, billing_client: legacy, failure_category: unknown) | | reports nothing when the rejection needs no payment recovery | cloud_app | nothing | nothing | Captured RUM actions and PostHog events for each recovery path show nothing on the FE-3115 base and the matching billing.portal.* event with target payment_recovery, client and failure category on this branch, with identical reportError calls (evidence-fe3121-recovery/). ## Where this sits in the plan Linear: [FE-3121](https://linear.app/comfyorg/issue/FE-3121), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811) merged, billing web cancel [PR 19945](Comfy-Org#19945) in review | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | [PR 19946](Comfy-Org#19946), [PR 19947](Comfy-Org#19947), [PR 19948](Comfy-Org#19948), in review | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | this PR | | T12 | FE-3122 | Flag coverage check | [PR 19942](Comfy-Org#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | [first cut](https://us.posthog.com/project/204330/dashboard/2164447) created | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T11 stroke-width:3px ``` --------- Co-authored-by: GitHub Action <action@github.com>
…urney with no operation (Comfy-Org#19975) ## Summary Report where a customer left a cloud app checkout dialog when the journey has no operation yet (E24, cloud app follow-up). ## Why Billing web reports billing.checkout.abandoned, but the cloud app did not. A customer who closed the subscription or top-up dialog, or closed the tab with it open, left no trace of where they stopped. The abandon KPI itself is derived on the dashboard from journeys that never link an operation. This event only says where the customer left. ## How A new module, checkoutJourneyTelemetry.ts, becomes the one way the cloud app reports a journey phase. It remembers the last progress phase this tab reported on the active journey. reportCheckoutJourneyExit reports billing.checkout.abandoned with last_phase and exit only when the active journey has no billing_op_id, and only once per stretch of new progress. A close and a later pagehide therefore report once, and a reopened journey reports again only after a new phase. useCheckoutJourneyExit wires it into useSubscriptionCheckout and the top-up dialog: scope dispose reports exit dialog_close, and pagehide while the dialog is open reports exit page_exit. A hand-off to the hosted billing web checkout marks the journey as accounted for, so that close reports nothing. The shared CheckoutExit enum gains dialog_close. The cloud PostHog provider sends an abandoned page_exit with transport sendBeacon and send_instantly, through its existing teardown capture. Everything else stays batched. billing_surface cloud_app comes from the existing cloud journey payload. There is no user-visible change. ## Review Focus - Base: the -3 branch was squash-merged into -2 (8814fe1), so this branch is cut from -2 and merges origin/main. Its PR targets -2. - The event is an exit observation with no outcome. Once an operation is bound, the cloud app reports nothing. The operation events and the server own the end. - The last phase is tab-scoped, module-level state. A journey resumed after a reload with no new phase in this tab reports no exit. - The three call sites (useSubscriptionCheckout, SubscriptionAddPaymentPreviewWorkspace, TopUpCreditsDialogContentWorkspace) now go through trackCheckoutJourneyPhase. Their existing journey tests pass unchanged. - Known gaps: the brief says later phase events carry resumed: true, but cloud journey events have no resumed field, and this branch does not add one. A tab closed while it was already in the background may not flush its RUM action. PostHog events captured before it loads are not queued for page_exit, the same as the agent panel teardown event. The hosted handoff for the subscription intent (manage plan) is not a checkout journey and is untouched. ## AS IS / TO BE Telemetry change, so the evidence is the captured events instead of a screenshot: the real cloud dialogs and journey module with the Datadog RUM and PostHog providers, only the network edge and the telemetry SDKs stubbed. AS IS = origin/main, TO BE = this branch. | Scenario | AS IS | TO BE | | --- | --- | --- | | T1 top-up dialog closed after `entered` | `entered` | adds `abandoned` (last_phase entered, exit dialog_close) | | T2 tab closed with the top-up dialog open | `entered` | adds `abandoned` (exit page_exit); PostHog sends with `{transport: 'sendBeacon', send_instantly: true}` | | T3 top-up closed after a submit that bound no operation | `entered`, `submitted` | adds `abandoned` (last_phase submitted, exit dialog_close) | | T4 top-up closed, then tab closed, after the operation was bound | `entered`, `submitted`, `operation_linked` | unchanged, no abandon | | T5 top-up closed, then tab closed | `entered` | one `abandoned` (dialog_close), no second report on pagehide | | T6 top-up closed, reopened (journey resumed), closed | `entered` | one `abandoned`; the reopen made no new phase, so its close reports nothing | | S1 subscription dialog closed at the quote | `entered`, `preview_ready` | adds `abandoned` (last_phase preview_ready, exit dialog_close) | | S2 tab closed at the quote | `entered`, `preview_ready` | adds `abandoned` (exit page_exit), PostHog by sendBeacon | | S3 subscription closed after the quote failed | `entered`, `preview_failed` | adds `abandoned` (last_phase preview_failed) | | S4 subscription closed, then tab closed, after the operation was bound | through `operation_linked` | unchanged, no abandon | | S5 dialog closed because the hosted checkout tab opened | `entered` | unchanged, no abandon (billing web continues the journey) | | S6 closed at the quote, reopened idle and closed, tab hidden, reopened to the quote and closed | 2x `preview_ready` | one `abandoned` per stretch of new progress: 2, not 4 | The event is an exit observation (decision D13 in the plan): the headline abandon count is derived on the dashboard from journeys with no `operation_linked` within the journey TTL. evidence-fe3119-cloud-abandon/as-is.json shows no abandoned event on origin/main for any path, and to-be.json shows abandoned with last_phase and exit to RUM and PostHog on dialog close at entered, submitted, preview_ready and preview_failed, sendBeacon on page exit, one report for close plus pagehide and for reopen without progress, and nothing after a bound operation or a hosted handoff. ## Where this sits in the plan Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811) merged, billing web cancel [PR 19945](Comfy-Org#19945) in review | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | this PR | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | [PR 19944](Comfy-Org#19944), in review | | T12 | FE-3122 | Flag coverage check | [PR 19942](Comfy-Org#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | [first cut](https://us.posthog.com/project/204330/dashboard/2164447) created | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T9 stroke-width:3px ```
…embedded checkout (Comfy-Org#19974) ## Summary Report an abandoned checkout and the ending screen on the billing web embedded checkout, the same way the full-page checkout does (E24, E25). ## Why The full-page checkout reports billing.checkout.abandoned and billing.checkout.ended since Comfy-Org#19948, but the embedded CheckoutView reported neither. A customer who closed the tab or went back from the embedded checkout left no trace, and its success and refusal screens could not be told apart in a funnel. ## How CheckoutView reuses the journey's abandoned and ended methods from useCheckoutJourney and the beacon transport the facade already applies to abandoned. No shared composable was extracted, because the two views share only the journey, which is already shared, and their ending screens differ. It reports abandoned with exit page_exit on pagehide, and with exit back or close from those controls. It reports no abandon after the page handed itself to a hosted step, or while a Pay with a non-card method is in flight, since that method pays on its own site. It reports ended with ending_kind success when the success step shows: attribution started when this page's Pay returned the result, followed when the page recovered an operation it did not send. It reports ended when the quote failure screen shows, right after preview_failed: refused for ACCESS_DENIED, plan_unavailable for the server code INVALID_PLAN, and load_failed otherwise. The journey keeps its existing rules: abandoned at most once and never after an ending, and each ending kind once. There is no user-visible change. ## Review Focus - quoteFailureEndingOf maps the embedded quote failure screen onto the full-page ending kinds. The embedded view has no capability read, so refused comes from ACCESS_DENIED on the quote, not from a denial reason. - payingOnOwnSite is true only between the Pay press and the command settling, for a method type other than card. A card Pay in flight when the tab closes is still an abandon, as on the full page. - Success attribution reads checkout.result: an ok result means this page's own Pay, and none means a recovered operation. - Two existing tests now expect billing.checkout.ended: the full journey test, and the stream ordering test, where ended lands before billing.subscription_checkout.succeeded because the success step shows before the attempt reports its terminal. - Known gaps: a quote that allows no change (allowed false) shows no ending screen on the embedded view, so it reports preview_failed and no ended. A saved non-card method carries no method type, so a redirect from it would count as an abandon. That matches the full page. The background-tab flush gap from Comfy-Org#19948 applies here too. ## AS IS / TO BE Telemetry change, so the evidence is the captured events instead of a screenshot: the real `CheckoutView` with the billing web telemetry facade and PostHog started, only the fake billing client and the telemetry SDKs stubbed. AS IS = origin/main, TO BE = this branch. | Path | AS IS | TO BE | | --- | --- | --- | | Tab closed at the quote | `entered`, `preview_ready` | adds `abandoned` (last_phase preview_ready, exit page_exit). The PostHog copy is sent with `{transport: 'sendBeacon'}` | | Back control, then the page unloads | `entered`, `preview_ready`, `web_return.clicked` | adds `abandoned` (exit back) once. The later pagehide adds nothing | | Close control, then the page unloads | `entered`, `preview_ready`, `web_return.clicked` | adds `abandoned` (exit close) once | | Hosted redirect (server offers a continuation) | `entered`, `preview_ready` | unchanged. No abandon, because the page handed itself to the hosted step | | Alipay Pay leaving for its own site | no abandon | unchanged. No abandon while a non-card Pay is in flight | | Own payment succeeds, then the tab closes | no ending event | `ended` (ending_kind success, attribution started, billing_op_id op_9). No abandon after it | | Quote refused (ACCESS_DENIED), then Back | `entered`, `preview_failed`, `web_return.clicked` | adds `ended` (ending_kind refused), with no attribution. Back after it adds no abandon | No new field carries an email, URL, client secret, promo code or provider id; every new field is a bounded enum. evidence-fe3119-embedded/as-is.json shows no abandoned or ended event on the embedded checkout on main. to-be.json shows abandoned with last_phase and exit for tab close, Back and Close, sent to RUM and to PostHog with transport sendBeacon. It shows no abandon for a hosted redirect or an Alipay Pay, and ended with ending_kind and attribution for the success and refusal screens. ## Where this sits in the plan Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815) (four parts), in review | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811) merged, billing web cancel [PR 19945](Comfy-Org#19945) in review | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | this PR | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | [PR 19944](Comfy-Org#19944), in review | | T12 | FE-3122 | Flag coverage check | [PR 19942](Comfy-Org#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | [first cut](https://us.posthog.com/project/204330/dashboard/2164447) created | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T9 stroke-width:3px ```
…tion switch rewrites the operation pointer (Comfy-Org#20004) ## Summary Keep the saved hosted redirect when a presentation switch rewrites the operation pointer, so billing.checkout.returned (E23) is still reported on the page the customer comes back to. ## Why CodeRabbit found this on Comfy-Org#19975 (Comfy-Org#19975 (comment)). A same-tab hosted redirect is only reported as returned if the tab's operation pointer still carries the redirect when the next page recovers the operation. A presentation switch after the redirect erased it, so that return was never reported. ## Root cause writePointer rebuilds the pointer from the operation state and only includes redirect when the caller passes one. reportHostedStepOpened passes it, but switchPresentation rewrites the pointer for the same operation without it, so the saved redirect is dropped. ## How A small savedRedirect helper reads the current pointer and returns its redirect only when its operationId is the operation being written. switchPresentation passes that to writePointer. The adopt write is deliberately left unchanged: adoption is where a saved redirect is turned into billing.checkout.returned, so it must consume the redirect. Carrying it forward there would report returned again on every reload, which the existing 'reports the return once' test catches. There is no user-visible change. ## Review Focus - The carry-forward lives at the switchPresentation call site, not inside writePointer. A generic carry-forward in writePointer also hits the adopt write and breaks the 'reports the return once' contract. This was checked: that test fails with the generic version. - The operationId guard matters when two operations are live in one scope. The new 'reports no return for an operation that never redirected, though another one did' test fails if the guard is removed. - leftScope writes a fresh pointer for a newly issued operation through pointers.write directly. It has no redirect to keep and is unchanged. ## AS IS / TO BE Telemetry change, so the evidence is the captured lifecycle events instead of a screenshot. Scenario: embedded 3DS top-up, hosted redirect, `switchPresentation('op-1', 'hosted')`, unload, then recover on a new page. | | Pointer after the rewrite | Events on the page the customer returns to | | --- | --- | --- | | AS IS (main) | `redirect` dropped | `billing.operation.started`, `billing.operation.succeeded` | | TO BE | `redirect` kept | adds `billing.checkout.returned` (navigation redirect, step authentication, method_kind card, presentation hosted, resumed true) on both the cloud app and billing web payloads | evidence-fe3119-pointer/as-is.json shows the pointer losing redirect after the same-operation rewrite and no billing.checkout.returned on the page returned to, and to-be.json shows redirect kept and billing.checkout.returned reported to both cloud app and billing web payloads. ## Where this sits in the plan Linear: [FE-3119](https://linear.app/comfyorg/issue/FE-3119), part of [FE-3105](https://linear.app/comfyorg/issue/FE-3105/billing-web-and-sdk-rollout-telemetry-events-fixes-and-dashboards). Plan, event catalog and dependency graph: [action items](https://app.notion.com/p/3ea6d73d3650814ba248d4d1431b8a89). | Task | Ticket | What | Status | | --- | --- | --- | --- | | T1 | FE-3107 | Decide vocabulary and dimensions | done, in the SSOT | | T2 | FE-3108 | Decide RUM application and env mapping | decided | | T3 | FE-3109 | Billing web telemetry bootstrap (RUM and PostHog) | [PR 19688](Comfy-Org#19688), merged | | T3+ | FE-3156 | Opaque RUM user id on billing web | [PR 19794](Comfy-Org#19794), merged | | T4, F1 | FE-3106 | SDK-rail ownership | [PR 19620](Comfy-Org#19620), merged | | T4, F2 | FE-3110 | Keep operation id and fields in the mapper | [PR 19623](Comfy-Org#19623), merged | | T4, F3 | FE-3111 | Stamp billing_surface and billing_client | [PR 19685](Comfy-Org#19685), merged | | T4, F5 | FE-3112 | SDK top-up terminals | [PR 19628](Comfy-Org#19628), merged | | T4, F6 | FE-3113 | Downgrade reconciliation terminal | [PR 19622](Comfy-Org#19622), merged | | T4, F7 | FE-3114 | Legacy personal-rail events, first slice | [PR 19627](Comfy-Org#19627), merged | | T4, F7+ | FE-3131 | Legacy personal-rail events, remaining slices | [PR 19686](Comfy-Org#19686), merged | | T4+ | FE-3140 | Move the billing event contract to a shared package | [PR 19798](Comfy-Org#19798), merged | | T5 | FE-3115 | Cloud entry fidelity and Datadog parity | [PR 19815](Comfy-Org#19815), merged | | T6 | FE-3116 | Handoff contract and event | [PR 19687](Comfy-Org#19687), merged | | T7 | FE-3117 | Billing web attempt lifecycle | [PR 19809](Comfy-Org#19809), [PR 19810](Comfy-Org#19810), [PR 19811](Comfy-Org#19811) merged, billing web cancel [PR 19945](Comfy-Org#19945) in review | | T8 | FE-3118 | Billing web journey and choices | [PR 19819](Comfy-Org#19819) (three parts), merged | | T9 | FE-3119 | Payment friction events | this PR | | T10 | FE-3120 | Billing web entry, session and return | [PR 19804](Comfy-Org#19804), [PR 19806](Comfy-Org#19806) and [PR 19807](Comfy-Org#19807), merged in [PR 19798](Comfy-Org#19798) | | T11 | FE-3121 | Portal events | [PR 19944](Comfy-Org#19944), in review | | T12 | FE-3122 | Flag coverage check | [PR 19942](Comfy-Org#19942), in review | | T13 | FE-3123 | PostHog rollout dashboard | [first cut](https://us.posthog.com/project/204330/dashboard/2164447) created | | T14 | FE-3124 | Datadog tiles in the Frontend RUM dashboard | [comfy-infra PR 1597](Comfy-Org/comfy-infra#1597), in review | | T4+ | FE-3162 | Move the payload-helper tests to account-core | [PR 19940](Comfy-Org#19940), in review | | T10+ | FE-3158 | Billing web Try again after session creation fails | [PR 19941](Comfy-Org#19941), in review | | T15 | FE-3125 | Verification per flow | todo | | T16 | FE-3126 | Rollout plan | todo | ```mermaid flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16 style T9 stroke-width:3px ```
Summary
Billing web: Retry session after the shared session fails to create now retries the creation. A remembered login whose restore keeps failing no longer leaves the sign-in screen unsettled.
Why
In shared-web-session mode a 503 on POST /auth/session left the customer on a Retry session button that could never succeed. With a remembered Firebase user and a failing restore, the sign-in screen showed 'Sign-in is unavailable' with every button disabled, so the customer had no way forward until the endpoint recovered.
Root cause
Two gaps in unifiedBillingSession.ts. First, establish() with no user only re-resolved the workspace. That answers NOT_AUTHENTICATED without a request when the shared session does not exist. The controller's retry always calls establish() with no user, so the failed creation was never retried. Second, settledOf() treated the identity's retry_wait phase as not settled. A restore that keeps failing loops through retry_wait, reading and restoring, so settledPhase() never resolved, loadIdentity() never loaded Firebase, and the sign-in page showed the unavailable notice.
How
establish() now picks who to create the session for: the passed user, or, when there is no signed-in shared session, the user Firebase currently holds. With such a user it re-mints the ID token and POSTs the session again, then reboots the identity as the interactive path already did. With no Firebase user it still answers NOT_AUTHENTICATED without a request, and the sign-in form stays the way forward. settledOf() maps retry_wait to signed-out, so the sign-in screen settles and renders the form while the identity keeps retrying in the background. A later successful restore still carries the customer off the page.
Review Focus
AS IS / TO BE
A. Interactive sign-in, POST /auth/session 503, then Retry session
Both builds start from the same screen after the 503: A1.
B. Remembered user, session restore keeps answering 503
Once the endpoint answers 200, both builds restore the session and leave sign-in.
C. Control (no outage)
Playwright against a local production build with the session endpoint stubbed to 503 then 200 shows AS IS stuck on Retry session and on a disabled sign-in screen, and TO BE recovering in both paths (evidence-fe3158/).
Where this sits in the plan
Linear: FE-3158, part of FE-3105. Plan, event catalog and dependency graph: action items.
flowchart LR subgraph DEC["Decided"] T1["FE-3107 T1 vocabulary"] T2["FE-3108 T2 RUM app and env"] end subgraph FIX["Existing events (T4)"] F1["FE-3106 F1 SDK-rail ownership"] F2["FE-3110 F2 mapper fields"] F3["FE-3111 F3 surface and client"] F5["FE-3112 F5 top-up terminals"] F6["FE-3113 F6 downgrade terminal"] F7["FE-3114 F7 legacy personal, first slice"] F7B["FE-3131 F7 remaining slices"] C140["FE-3140 event contract to shared package"] end subgraph EMIT["New events"] T3["FE-3109 T3 billing web bootstrap"] T3b["FE-3156 T3+ opaque RUM user id"] T5["FE-3115 T5 cloud entry and parity"] T6["FE-3116 T6 handoff contract"] T7["FE-3117 T7 attempt lifecycle"] T8["FE-3118 T8 journey and choices"] T9["FE-3119 T9 friction"] T10["FE-3120 T10 entry, session, return"] T11["FE-3121 T11 portal"] T12["FE-3122 T12 flag coverage"] end subgraph DASH["Dashboards"] T13["FE-3123 T13 PostHog rollout"] T14["FE-3124 T14 Frontend RUM tiles"] end T15["FE-3125 T15 verification"] T16["FE-3126 T16 rollout plan"] T2 --> T3 T3 --> T3b F3 --> C140 T3 --> C140 C140 --> T7 C140 --> T8 C140 --> T10 C140 --> T11 T1 --> F3 T1 --> T5 T1 --> T6 T1 --> T13 T1 --> T14 T2 --> T14 F2 --> T7 T3 --> T7 T3 --> T8 T3 --> T10 T3 --> T11 T3 --> T12 T5 --> T11 T6 --> T8 T6 --> T10 T7 --> T9 T8 --> T9 F1 --> T13 F3 --> T13 FIX --> T15 T5 --> T15 T9 --> T15 T10 --> T15 T11 --> T15 T12 --> T15 T13 --> T15 T14 --> T15 T13 --> T16 T15 --> T16