Repository navigation
[backport cloud/1.55] feat: cancel cloud asset downloads - #19739
Conversation
Justification: Alex reviewed exact head b3485a7 and explicitly recorded “ready to approve”; all required exact-head checks are terminal green, every substantive thread is resolved, and the seven-commit main delta has zero file overlap with this PR. Applying the documented selective stale-approval exception; post-merge peer review remains routed to Alex.
🎭 Playwright: ✅ 2138 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 26c10985c6cffee40705c14cc03daeec5e013ad6
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T15:13:58.934Z",
"gitSha": "b6d250b2a0a94ffe560405f45d433b9520e3e2b6",
"branch": "backport-19281-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.47499999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.78599999999994,
"heapDeltaBytes": -9615872,
"heapUsedBytes": 58413820,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.383999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.8270000000202,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.299999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.2609999999999,
"heapDeltaBytes": -7620364,
"heapUsedBytes": 60057016,
"domNodes": -258,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.326,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.1269999999618,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.149000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.3720000000001,
"heapDeltaBytes": -8220012,
"heapUsedBytes": 59749136,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 113.23399999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.8399999999383,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.917,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.885,
"heapDeltaBytes": 10349532,
"heapUsedBytes": 78301380,
"domNodes": -259,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 130.478,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.1360000000382,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.681000000000001,
"layouts": 6,
"layoutDurationMs": 1.0510000000000002,
"taskDurationMs": 279.583,
"heapDeltaBytes": 3108920,
"heapUsedBytes": 71072172,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.341,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1700.1599999999826,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.586,
"layouts": 6,
"layoutDurationMs": 1.063,
"taskDurationMs": 306.92600000000004,
"heapDeltaBytes": 3095116,
"heapUsedBytes": 70956776,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.959999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 549.7229999999718,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.5059999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.329,
"heapDeltaBytes": 18886532,
"heapUsedBytes": 86791192,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 131.195,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 549.7040000000197,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.853000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.09099999999995,
"heapDeltaBytes": 18912332,
"heapUsedBytes": 86548424,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.423,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 988.0919999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.566,
"heapDeltaBytes": 38695672,
"heapUsedBytes": 106260468,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 51.282999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 383,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1067.23199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 732.3069999999999,
"heapDeltaBytes": 38827856,
"heapUsedBytes": 105685616,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 51.649,
"eventListeners": 0,
"totalBlockingTimeMs": 451,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.1359999999936,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.93600000000026,
"heapDeltaBytes": 14106076,
"heapUsedBytes": 90318428,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.645,
"eventListeners": 0,
"totalBlockingTimeMs": 159,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 780.8549999999741,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.98900000000015,
"heapDeltaBytes": 14769276,
"heapUsedBytes": 90317080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.83699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7171.643999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6301.3820000000005,
"heapDeltaBytes": 4364292,
"heapUsedBytes": 87000672,
"domNodes": -18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 5193.237999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8380.489000000012,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.10399999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7515.7699999999995,
"heapDeltaBytes": 14506340,
"heapUsedBytes": 96497468,
"domNodes": -16,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 6050.807,
"eventListeners": 0,
"totalBlockingTimeMs": 105,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7285.552999999993,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1889999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6430.747,
"heapDeltaBytes": 20290712,
"heapUsedBytes": 97278728,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5121.401000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 116,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7618.736000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6800.985000000001,
"heapDeltaBytes": -1182276,
"heapUsedBytes": 81372688,
"domNodes": -18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 5346.804,
"eventListeners": 0,
"totalBlockingTimeMs": 43,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2027.8079999999932,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.358000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.86499999999984,
"heapDeltaBytes": -4685204,
"heapUsedBytes": 82911392,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.532000000000007,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.1749999999902,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.574,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.201,
"heapDeltaBytes": -3442488,
"heapUsedBytes": 83678416,
"domNodes": -239,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 31.720000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2168.9660000000117,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.609,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1296.4099999999999,
"heapDeltaBytes": -12939776,
"heapUsedBytes": 75686812,
"domNodes": -242,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 646.703,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2169.9080000000777,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.064999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1369.9889999999998,
"heapDeltaBytes": 16132332,
"heapUsedBytes": 80740460,
"domNodes": -244,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 680.197,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3220.654999999965,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.777000000000001,
"layouts": 60,
"layoutDurationMs": 12.554999999999998,
"taskDurationMs": 1383.286,
"heapDeltaBytes": -16058164,
"heapUsedBytes": 73829324,
"domNodes": -261,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 630.6089999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3238.790999999992,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.041999999999998,
"layouts": 60,
"layoutDurationMs": 13.48,
"taskDurationMs": 1480.3760000000002,
"heapDeltaBytes": 8539284,
"heapUsedBytes": 74356764,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 671.706,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2278.9280000000076,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1545.748,
"heapDeltaBytes": -16800252,
"heapUsedBytes": 74418680,
"domNodes": -216,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 777.663,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2484.195999999997,
"styleRecalcs": 50,
"styleRecalcDurationMs": 12.376000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1695.4989999999998,
"heapDeltaBytes": -19823856,
"heapUsedBytes": 69921092,
"domNodes": -211,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 838.8109999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2034.9219999999946,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.4689999999999,
"heapDeltaBytes": -8133780,
"heapUsedBytes": 81338664,
"domNodes": -240,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 29.481999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2015.2550000000247,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.1109999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.371,
"heapDeltaBytes": 20117112,
"heapUsedBytes": 84566048,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.495,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 515.9160000000043,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.073,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.84400000000005,
"heapDeltaBytes": 14087888,
"heapUsedBytes": 83938116,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 119.06299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.0449999999537,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.474,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.76300000000003,
"heapDeltaBytes": 14100448,
"heapUsedBytes": 84058804,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 118.34100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.3839999999782,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.344999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.594,
"heapDeltaBytes": 10680156,
"heapUsedBytes": 80505968,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.850999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.7839999999624,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.1610000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.847,
"heapDeltaBytes": 11135304,
"heapUsedBytes": 81093944,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.321,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.6730000000134,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.597000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.273,
"heapDeltaBytes": 7307968,
"heapUsedBytes": 77389932,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 79.057,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.8020000000206,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.226,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 687.988,
"heapDeltaBytes": 8709824,
"heapUsedBytes": 78587120,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 93.333,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 920.031999999992,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.73100000000001,
"layouts": 5,
"layoutDurationMs": 9.728,
"taskDurationMs": 711.1959999999999,
"heapDeltaBytes": -6320744,
"heapUsedBytes": 81748560,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 21.45500000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8262.005999999985,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.348,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4650.7300000000005,
"heapDeltaBytes": -6646748,
"heapUsedBytes": 80506608,
"domNodes": -242,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2197.3,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8329.266000000076,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.814,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5004.17,
"heapDeltaBytes": -10661740,
"heapUsedBytes": 76988784,
"domNodes": -214,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2342.4020000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14558.73200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14376.977999999997,
"heapDeltaBytes": -10115992,
"heapUsedBytes": 197713920,
"domNodes": -8065,
"jsHeapTotalBytes": -10207232,
"scriptDurationMs": 232.702,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14771.889999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14635.189,
"heapDeltaBytes": -39123608,
"heapUsedBytes": 200702980,
"domNodes": -8062,
"jsHeapTotalBytes": -10653696,
"scriptDurationMs": 214.187,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17231.23000000004,
"styleRecalcs": 120,
"styleRecalcDurationMs": 16.238000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17162.168,
"heapDeltaBytes": -54889684,
"heapUsedBytes": 178982224,
"domNodes": -8062,
"jsHeapTotalBytes": -12828672,
"scriptDurationMs": 726.275,
"eventListeners": -14928,
"totalBlockingTimeMs": 9,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17110.536000000026,
"styleRecalcs": 114,
"styleRecalcDurationMs": 15.817999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17069.924,
"heapDeltaBytes": -39701116,
"heapUsedBytes": 195101060,
"domNodes": -8066,
"jsHeapTotalBytes": -12431360,
"scriptDurationMs": 736.502,
"eventListeners": -14928,
"totalBlockingTimeMs": 67,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5336.392000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.666,
"layouts": 20,
"layoutDurationMs": 25.502999999999997,
"taskDurationMs": 5316.512,
"heapDeltaBytes": -62748644,
"heapUsedBytes": 177012760,
"domNodes": -8062,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 130.988,
"eventListeners": -14928,
"totalBlockingTimeMs": 310,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5397.658999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.819999999999986,
"layouts": 20,
"layoutDurationMs": 23.149000000000004,
"taskDurationMs": 5372.062000000001,
"heapDeltaBytes": -36799340,
"heapUsedBytes": 184241656,
"domNodes": -8062,
"jsHeapTotalBytes": 15253504,
"scriptDurationMs": 93.27199999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 321,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7343.240000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7295.838,
"heapDeltaBytes": 14756088,
"heapUsedBytes": 184202860,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 106.989,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7245.131999999899,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7219.223,
"heapDeltaBytes": -11698856,
"heapUsedBytes": 173016800,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 104.76299999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 95.8299999999781,
"styleRecalcs": 6,
"styleRecalcDurationMs": 13.961999999999998,
"layouts": 4,
"layoutDurationMs": 1.9560000000000002,
"taskDurationMs": 72.606,
"heapDeltaBytes": 3192884,
"heapUsedBytes": 65287512,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.285,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 93.68500000005042,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.265,
"layouts": 2,
"layoutDurationMs": 0.974,
"taskDurationMs": 61.242999999999995,
"heapDeltaBytes": 2953964,
"heapUsedBytes": 69000704,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.681999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
|
This backport currently fails typecheck because |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.55 #19739 +/- ##
=============================================
Coverage ? 84.76%
=============================================
Files ? 2315
Lines ? 132163
Branches ? 33709
=============================================
Hits ? 112032
Misses ? 19769
Partials ? 362
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 3 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Adjudicates the ten Cursor review findings on #19739 against source. All ten are substantiated; nine are fixed here and one is answered on the thread. A pending cancellation had no exit other than a terminal WS message or a successful poll, and `pollSingleDownload` collapsed every `getTask` failure into "retry later" - including a 404, which proves the task row is gone. A purged task therefore re-polled every 10s for the life of the page and stayed `cancellation_pending`, which is not a finished status, so the dialog withheld its only Close control and the toast was pinned open until a reload. A 404 now settles the cancellation, and an unconfirmed one settles after a bounded number of reconciliation attempts. `cancelled` is still replaceable by an authoritative `completed`, so the PM-1302 recovery premise is unchanged. `getTask` narrowed the shared `/tasks` response's `result` to the download-file shape, so an export task carrying `export_name`/`assets_total` failed `safeParse` and returned `ok: false`, making export reconciliation unreachable. `result` goes back to the generated opaque record and is parsed per task type at the call site. Export polling also gains the identity guard its download counterpart has - without it a poll resolving after a dismissal re-inserted the export with `downloadTriggered: false` and downloaded the archive twice - and now reconciles a server-side `cancelled` export instead of polling it forever. The upload wizard stopped watching at `failed` and `cancelled`, both of which the download store deliberately leaves recoverable, so a recovered import read as a failure and skipped `refreshModelCaches()`. It now stops only on `completed`, the one status the store treats as immutable. Two smaller repairs: `cancelTask` no longer interpolates an unbounded response body into an error that reaches a toast and telemetry, and it reports 404 and 409 as distinct outcomes so a refusal reconciles the row's real status instead of being a silent no-op. Reconciling to `cancelled` routes through `handleAssetDownload` rather than mutating in place, which drops the stale error a premature message left attached. Not fixed: cancellation is still only permitted from `created`/`running`. Allowing it from `failed` needs a Cancel affordance on a failed row, which is a product decision rather than a mechanical fix, and is answered on the thread.
Widening `AssetExport.status` to include `cancelled` left the export dialog without a branch for it, so a cancelled export fell through to the final `v-else` and rendered "Pending", and a cancelled-only set produced an "All exports completed" footer. Both now mirror the download dialog's existing cancelled treatment. Found by reviewing the reconciliation fix's own blast radius rather than by a review comment; the new component test is red on the prior component.
christian-byrne
left a comment
There was a problem hiding this comment.
Approved for cloud/1.55: the backport is green, adapts telemetry to the release contract, bounds cancellation reconciliation, and fixes cancelled export rendering. The remaining proposed failed-state cancellation behavior would widen product semantics and is intentionally excluded from this release carrier.
Backport of #19281 to
cloud/1.55Automatically created by backport workflow.