Skip to content

[backport cloud/1.55] fix: harden task cancellation reconciliation (#20031) - #20047

Merged
christian-byrne merged 2 commits into
cloud/1.55from
backport-20031-cloud-1.55
Oct 4, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.55from
backport-20031-cloud-1.55

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports #20031 to cloud/1.55.

This supersedes the branch's earlier partial cancellation hardening with the canonical main implementation while retaining the branch-specific telemetry API shape. It adds bounded and serialized reconciliation, terminal-state preservation, dismissible unconfirmed cancellations, upload-watcher isolation, and regression coverage.

Validation:

  • focused Vitest suite: 93 passed, 1 expected failure
  • pnpm typecheck:app

- bound cancelled-task reconciliation and validate task statuses/results
before restoring state
- keep download/export cancellation rendering and close behavior
consistent while polling is in flight
- stop upload-wizard watchers when their owning scope is disposed
- preserve export download URL behavior while adding regression coverage
for malformed, mixed-shape, cancelled, and stale task responses

This lands the hardening identified during the final review of #19858
(the `core/1.55` backport of #19281) on `main` first so release branches
can consume it through normal backports.

- `pnpm vitest run src/stores/assetDownloadStore.test.ts
src/stores/assetExportStore.test.ts
src/platform/tasks/services/taskService.test.ts
src/platform/assets/components/ModelImportProgressDialog.test.ts
src/platform/assets/components/AssetExportProgressDialog.test.ts
src/platform/assets/composables/useUploadModelWizard.test.ts` (85
passed, 1 expected failure)
- `pnpm typecheck:app`
- `pnpm typecheck:browser`
- targeted `oxfmt --check`
- pre-push `knip` and changed-file `fallow audit`
@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 6c55a85e-e2cb-491c-beba-12b7d0c7531c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 11:15:55 PM UTC

Links

🎭 Playwright: ✅ 2149 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2128 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 6f09a0eed1b067b97ef2c0724029bb10d448467d

Full docs: ADR-DEVEX-LINT-0015

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 425ms TBT · 95.4 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 160ms TBT · 88.1 MB heap
extension-clean-combined-draw: · 56.2 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 47ms TBT · 74.6 MB heap
extension-rgthree-prototype-draw: · 55.4 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 75ms TBT · 76.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 88ms TBT · 98.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.1 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 4ms TBT · 171.9 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 165ms TBT · 167.4 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 176.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 375ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.1 MB
canvas-idle: DOM nodes -257
canvas-idle: event listeners -174
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 13ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 46
canvas-mouse-sweep: task duration 649ms
canvas-mouse-sweep: script duration 122ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.1 MB
canvas-mouse-sweep: DOM nodes -259
canvas-mouse-sweep: event listeners -152
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 287ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.8 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 16
dom-widget-clipping: task duration 378ms
dom-widget-clipping: script duration 135ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 58.1 MB
dom-widget-clipping: DOM nodes 23
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 686ms
dom-widget-order-dense-n200-w200-i120: script duration 46ms
dom-widget-order-dense-n200-w200-i120: TBT 425ms
dom-widget-order-dense-n200-w200-i120: heap used 95.4 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -145
dom-widget-order-dense-n200-w200-i120: event listeners -109
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 391ms
dom-widget-order-sparse-n1000-w20-i120: script duration 122ms
dom-widget-order-sparse-n1000-w20-i120: TBT 160ms
dom-widget-order-sparse-n1000-w20-i120: heap used 88.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 18ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 1
extension-clean-combined-draw: task duration 6878ms
extension-clean-combined-draw: script duration 5604ms
extension-clean-combined-draw: TBT 47ms
extension-clean-combined-draw: heap used 74.6 MB
extension-clean-combined-draw: DOM nodes -273
extension-clean-combined-draw: event listeners -174
extension-rgthree-prototype-draw: avg frame time 18ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 1ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 6586ms
extension-rgthree-prototype-draw: script duration 5389ms
extension-rgthree-prototype-draw: TBT 75ms
extension-rgthree-prototype-draw: heap used 76.5 MB
extension-rgthree-prototype-draw: DOM nodes -138
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 11
large-graph-idle: task duration 512ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 66.3 MB
large-graph-idle: DOM nodes -242
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1318ms
large-graph-pan: script duration 677ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.7 MB
large-graph-pan: DOM nodes -246
large-graph-pan: event listeners -174
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 71
large-graph-zoom: task duration 1380ms
large-graph-zoom: script duration 658ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 77.1 MB
large-graph-zoom: DOM nodes -92
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1540ms
legacy-node-drag: script duration 813ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 70.5 MB
legacy-node-drag: DOM nodes 13
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 490ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 65.1 MB
minimap-idle: DOM nodes -253
minimap-idle: event listeners -174
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 49
subgraph-dom-widget-clipping: task duration 340ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.0 MB
subgraph-dom-widget-clipping: DOM nodes 23
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 404ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.1 MB
subgraph-idle: DOM nodes -273
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 47
subgraph-mouse-sweep: task duration 624ms
subgraph-mouse-sweep: script duration 87ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.1 MB
subgraph-mouse-sweep: DOM nodes -274
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 705ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 88ms
subgraph-transition-enter: heap used 98.6 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4682ms
viewport-pan-sweep: script duration 2352ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.1 MB
viewport-pan-sweep: DOM nodes -243
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14112ms
vue-large-graph-idle: script duration 215ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 179.1 MB
vue-large-graph-idle: DOM nodes -8062
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 116
vue-large-graph-pan: task duration 16824ms
vue-large-graph-pan: script duration 718ms
vue-large-graph-pan: TBT 4ms
vue-large-graph-pan: heap used 171.9 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 61ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4719ms
vue-node-resize-workload: script duration 103ms
vue-node-resize-workload: TBT 165ms
vue-node-resize-workload: heap used 167.4 MB
vue-node-resize-workload: DOM nodes -8062
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7059ms
vue-zoom-out-idle: script duration 111ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 176.5 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 77ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.3 MB
workflow-execution: DOM nodes 125
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-10-03T23:26:15.167Z",
  "gitSha": "7e75172cf98e16af0cc68ee291ebc4f20b935cb9",
  "branch": "backport-20031-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2017.3100000000659,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.064999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.379,
      "heapDeltaBytes": -2886760,
      "heapUsedBytes": 65894084,
      "domNodes": -258,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.416,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2003.088000000048,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.854,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 382.4160000000001,
      "heapDeltaBytes": -11005764,
      "heapUsedBytes": 58079692,
      "domNodes": -256,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.216999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1708.0409999999802,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 12.707999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 635.952,
      "heapDeltaBytes": -74372,
      "heapUsedBytes": 62698312,
      "domNodes": -258,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 116.65599999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1709.145000000035,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 12.766000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 662.6750000000001,
      "heapDeltaBytes": 9496528,
      "heapUsedBytes": 78003188,
      "domNodes": -259,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 126.51300000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.6640000000225,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.883000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.932,
      "taskDurationMs": 263.168,
      "heapDeltaBytes": 3009976,
      "heapUsedBytes": 72013540,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.613,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1717.1860000000834,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.037999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.024,
      "taskDurationMs": 310.274,
      "heapDeltaBytes": 3250752,
      "heapUsedBytes": 72285836,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.158,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 550.9089999999333,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 7.842000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.99,
      "heapDeltaBytes": -7969892,
      "heapUsedBytes": 61071972,
      "domNodes": 23,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 133.777,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 548.010999999974,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 8.724,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.811,
      "heapDeltaBytes": -8077604,
      "heapUsedBytes": 60818992,
      "domNodes": 22,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 136.299,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 987.5600000000304,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 608.6790000000001,
      "heapDeltaBytes": 35328704,
      "heapUsedBytes": 103436856,
      "domNodes": 0,
      "jsHeapTotalBytes": 20344832,
      "scriptDurationMs": 44.895999999999994,
      "eventListeners": 0,
      "totalBlockingTimeMs": 375,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1101.6230000000178,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 762.605,
      "heapDeltaBytes": 25202324,
      "heapUsedBytes": 96533228,
      "domNodes": -290,
      "jsHeapTotalBytes": 18501632,
      "scriptDurationMs": 47.62,
      "eventListeners": -217,
      "totalBlockingTimeMs": 474,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 767.4379999999701,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.9870000000001,
      "heapDeltaBytes": 15225308,
      "heapUsedBytes": 91999240,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 114.61200000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 157,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 781.8660000000364,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.11300000000017,
      "heapDeltaBytes": 16163264,
      "heapUsedBytes": 92753972,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 129.05799999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 163,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7758.670999999936,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.796999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6874.245,
      "heapDeltaBytes": 2268096,
      "heapUsedBytes": 81005964,
      "domNodes": -273,
      "jsHeapTotalBytes": 1826816,
      "scriptDurationMs": 5609.702,
      "eventListeners": -174,
      "totalBlockingTimeMs": 51,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7685.104999999908,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.8090000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6882.225,
      "heapDeltaBytes": -3896304,
      "heapUsedBytes": 75456444,
      "domNodes": -273,
      "jsHeapTotalBytes": 8642560,
      "scriptDurationMs": 5598.447,
      "eventListeners": -174,
      "totalBlockingTimeMs": 42,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7743.094000000042,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.7489999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6919.991,
      "heapDeltaBytes": 1773116,
      "heapUsedBytes": 83665444,
      "domNodes": -16,
      "jsHeapTotalBytes": 11796480,
      "scriptDurationMs": 5731.307,
      "eventListeners": 0,
      "totalBlockingTimeMs": 120,
      "frameDurationMs": 18.329999999999988,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7051.32500000002,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.074000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6251.296,
      "heapDeltaBytes": -2926116,
      "heapUsedBytes": 76685156,
      "domNodes": -260,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 5047.664,
      "eventListeners": -174,
      "totalBlockingTimeMs": 29,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2056.504999999902,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.536999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.4159999999998,
      "heapDeltaBytes": -23604436,
      "heapUsedBytes": 65761272,
      "domNodes": -249,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 39.968,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.152999999932,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.116,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.9059999999998,
      "heapDeltaBytes": -16283720,
      "heapUsedBytes": 73187512,
      "domNodes": -234,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 32.146,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2153.367000000003,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 16.59,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1249.7319999999997,
      "heapDeltaBytes": -1896628,
      "heapUsedBytes": 88588832,
      "domNodes": -245,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 661.789,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2156.1470000000327,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.599999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1386.372,
      "heapDeltaBytes": -1642452,
      "heapUsedBytes": 89142316,
      "domNodes": -247,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 693.125,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3183.096999999975,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.203,
      "layouts": 60,
      "layoutDurationMs": 12.320999999999998,
      "taskDurationMs": 1302.8600000000001,
      "heapDeltaBytes": 1523876,
      "heapUsedBytes": 66611632,
      "domNodes": -224,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 641.208,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3271.6800000000603,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 17.136,
      "layouts": 60,
      "layoutDurationMs": 13.865,
      "taskDurationMs": 1456.426,
      "heapDeltaBytes": 3148716,
      "heapUsedBytes": 94995460,
      "domNodes": 40,
      "jsHeapTotalBytes": 5541888,
      "scriptDurationMs": 674.028,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2532.060999999999,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.202000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1508.5479999999998,
      "heapDeltaBytes": 7243260,
      "heapUsedBytes": 72871644,
      "domNodes": 12,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 822.379,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2345.634000000018,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.413999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1572.1219999999998,
      "heapDeltaBytes": -18844436,
      "heapUsedBytes": 74908340,
      "domNodes": 14,
      "jsHeapTotalBytes": 6590464,
      "scriptDurationMs": 803.84,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.106999999949,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.827999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.4110000000001,
      "heapDeltaBytes": -23435680,
      "heapUsedBytes": 67787780,
      "domNodes": -254,
      "jsHeapTotalBytes": 3174400,
      "scriptDurationMs": 29.868999999999993,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2052.1130000000767,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.143999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 544.9609999999999,
      "heapDeltaBytes": -22660056,
      "heapUsedBytes": 68795380,
      "domNodes": -251,
      "jsHeapTotalBytes": 3436544,
      "scriptDurationMs": 33.93,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 494.04999999990196,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.934999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.12700000000007,
      "heapDeltaBytes": 13251932,
      "heapUsedBytes": 83913100,
      "domNodes": 22,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 116.475,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 543.5340000000224,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 11.318999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.241,
      "heapDeltaBytes": 12888348,
      "heapUsedBytes": 83769656,
      "domNodes": 24,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 123.826,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1988.5620000000017,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.726000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.70599999999996,
      "heapDeltaBytes": -6865256,
      "heapUsedBytes": 64056432,
      "domNodes": -273,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 6.728999999999999,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.7760000000353,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.434000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.876,
      "heapDeltaBytes": -6465796,
      "heapUsedBytes": 57745016,
      "domNodes": -273,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.742,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1687.8490000000284,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 14.410999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.8870000000001,
      "heapDeltaBytes": -8948140,
      "heapUsedBytes": 61693780,
      "domNodes": -272,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 81.149,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.213999999898,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 14.023000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 654.4440000000001,
      "heapDeltaBytes": -13108884,
      "heapUsedBytes": 58117848,
      "domNodes": -275,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 92.641,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 867.621999999983,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 22.275999999999996,
      "layouts": 5,
      "layoutDurationMs": 9.652000000000001,
      "taskDurationMs": 705.02,
      "heapDeltaBytes": 21663888,
      "heapUsedBytes": 103435540,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 21.449,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 88,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8235.131999999907,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.469,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4526.915,
      "heapDeltaBytes": 3793384,
      "heapUsedBytes": 93637780,
      "domNodes": -237,
      "jsHeapTotalBytes": 778240,
      "scriptDurationMs": 2369.176,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8227.366999999958,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 41.181,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4837.044,
      "heapDeltaBytes": -9003700,
      "heapUsedBytes": 80668600,
      "domNodes": -248,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 2334.4339999999997,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14017.071000000102,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13808.892999999998,
      "heapDeltaBytes": -63351756,
      "heapUsedBytes": 184581376,
      "domNodes": -8062,
      "jsHeapTotalBytes": -19599360,
      "scriptDurationMs": 229.40500000000003,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14489.601999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14415.981000000002,
      "heapDeltaBytes": -30166712,
      "heapUsedBytes": 191072860,
      "domNodes": -8062,
      "jsHeapTotalBytes": -18026496,
      "scriptDurationMs": 200.14,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16826.435999999943,
      "styleRecalcs": 113,
      "styleRecalcDurationMs": 13.595999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16566.172000000002,
      "heapDeltaBytes": -71333116,
      "heapUsedBytes": 170319300,
      "domNodes": -8062,
      "jsHeapTotalBytes": -19337216,
      "scriptDurationMs": 719.075,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17236.049999999977,
      "styleRecalcs": 118,
      "styleRecalcDurationMs": 15.621999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17082.483,
      "heapDeltaBytes": -31113148,
      "heapUsedBytes": 190180244,
      "domNodes": -8062,
      "jsHeapTotalBytes": -21049344,
      "scriptDurationMs": 717.38,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4087.537999999995,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.48099999999998,
      "layouts": 20,
      "layoutDurationMs": 22.599999999999994,
      "taskDurationMs": 4054.131999999999,
      "heapDeltaBytes": -53391160,
      "heapUsedBytes": 180681396,
      "domNodes": -8062,
      "jsHeapTotalBytes": 7745536,
      "scriptDurationMs": 73.014,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 81,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5402.388999999971,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.394000000000034,
      "layouts": 20,
      "layoutDurationMs": 23.483000000000004,
      "taskDurationMs": 5384.187000000001,
      "heapDeltaBytes": -52108756,
      "heapUsedBytes": 170431264,
      "domNodes": -8062,
      "jsHeapTotalBytes": 5668864,
      "scriptDurationMs": 132.336,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 248,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7244.611000000077,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7153.507000000001,
      "heapDeltaBytes": -16680252,
      "heapUsedBytes": 174125508,
      "domNodes": -1,
      "jsHeapTotalBytes": -30408704,
      "scriptDurationMs": 104.27000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7108.994999999936,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6964.374000000002,
      "heapDeltaBytes": 7017652,
      "heapUsedBytes": 196125192,
      "domNodes": 0,
      "jsHeapTotalBytes": -33816576,
      "scriptDurationMs": 118.083,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 438.7140000000045,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 19.442,
      "layouts": 2,
      "layoutDurationMs": 0.5820000000000001,
      "taskDurationMs": 98.51199999999999,
      "heapDeltaBytes": 4922244,
      "heapUsedBytes": 71630096,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.41,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 75.50500000002103,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.836000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.52,
      "taskDurationMs": 55.78499999999999,
      "heapDeltaBytes": 3019248,
      "heapUsedBytes": 69506708,
      "domNodes": 124,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.664,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52788 79860 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1168
src/LGraphNode.ts 70.6% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 73.2% 254
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/pnginfo.ts 20.7% 222

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions
github-actions Bot requested a review from ryan-di October 3, 2026 23:15
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 3, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 3, 2026
@christian-byrne
christian-byrne enabled auto-merge (squash) October 3, 2026 23:32
@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...latform/assets/composables/useUploadModelWizard.ts 76.19% 5 Missing ⚠️
src/stores/assetDownloadStore.ts 96.51% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.55   #20047   +/-   ##
=============================================
  Coverage              ?   84.94%           
=============================================
  Files                 ?     2327           
  Lines                 ?   133346           
  Branches              ?    36026           
=============================================
  Hits                  ?   113276           
  Misses                ?    19708           
  Partials              ?      362           
Flag Coverage Δ
e2e 66.14% <32.45%> (?)
unit 81.04% <96.18%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rm/assets/components/ModelImportProgressDialog.vue 77.22% <100.00%> (ø)
src/stores/assetExportStore.ts 100.00% <100.00%> (ø)
src/stores/assetDownloadStore.ts 97.54% <96.51%> (ø)
...latform/assets/composables/useUploadModelWizard.ts 70.51% <76.19%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: chromium

Recorded test titles:

  • all tests in browser_tests/tests/dialogs/modelImportProgressDialog.spec.ts

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 3
🟡 Medium 7

Panel: 8/8 reviewers contributed findings.

Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetDownloadStore.ts Resolved
Comment thread src/stores/assetExportStore.ts Resolved
Comment thread src/stores/assetExportStore.ts Resolved
Comment thread src/stores/assetExportStore.ts Resolved
@christian-byrne christian-byrne assigned DrJKL and unassigned ryan-di Oct 4, 2026
@christian-byrne
christian-byrne requested review from DrJKL and removed request for ryan-di October 4, 2026 00:05

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This backport brings the files #20031 touches on cloud/1.55 to their content on main after #20031, except for this branch's reportError options.

I compared against #20031's merge commit d23d7802f5680f647a10d3620b61f63a7800ab01. cloud/1.55 already carried #19281 and part of the follow-up hardening through #19739 (ba8eb99f43), so I compared end states rather than raw hunks. At this head, assetDownloadStore.ts, assetExportStore.ts, taskService.ts, useUploadModelWizard.ts, both progress dialogs and all their tests and specs match main after #20031, apart from the items below.

Adaptations, each accounted for by cloud/1.55:

  • ModelImportProgressDialog.vue and its test keep tags: { surface: 'assets' }, because ReportErrorOptions on cloud/1.55 has no surface field.
  • AssetExportWsMessage.status is already TaskStatus on this branch through #19739, so the source's widening in execution/types.ts is already present. The remaining differences in that file (zResultItem.id) and the @/scripts/api mock factory in useUploadModelWizard.test.ts existed before this PR and are not touched by it.
  • Lines that go beyond the source hunks, in assetDownloadStore.ts and the trimmed Close-button assertions in 4e5fe3c, replace #19739's earlier partial implementation with main's.

Checks: the six touched and adjacent Vitest files pass locally at this head (93 passed, 1 expected failure). vue-tsc --noEmit and pnpm typecheck:browser pass. Hosted CI at 4e5fe3c is fully green, including lint-and-format, test and e2e-status.

@christian-byrne
christian-byrne merged commit 660f9d0 into cloud/1.55 Oct 4, 2026
133 checks passed
@DrJKL DrJKL removed their assignment Oct 4, 2026
@christian-byrne
christian-byrne deleted the backport-20031-cloud-1.55 branch October 4, 2026 01:38
christian-byrne added a commit that referenced this pull request Oct 5, 2026
## Summary

Follow-up to #20031 and its release backports. This closes the
post-merge review gaps by:

- tombstoning dismissed pending downloads so late WebSocket frames
cannot reopen the toast, while still refreshing model caches after a
hidden completion
- settling malformed authoritative completions instead of polling
forever
- confirming DELETE 404 outcomes without falsely presenting a
still-running task as cancelled
- bounding task-not-found reconciliation and stopping unconfirmed
cancellation polling
- preserving late export names, validating export URL schemes, and
retrying transient export 404s
- preventing async upload watchers from outliving reset/disposal

## Validation

- Targeted Vitest: 74 passed, 1 expected failure
- App typecheck
- Targeted lint: 0 errors
- Diff whitespace check

Closes the actionable review findings raised on #20044, #20047, #20048,
and #20049.
@christian-byrne

Copy link
Copy Markdown
Contributor Author

For closure: the outstanding findings are addressed by #20166 (hardens cancellation and retry reconciliation) and #20161 (the merged release backport for this branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants