Repository navigation
[backport core/1.55] feat(agent): keep panel open through activation - #19631
Conversation
Keep the Agent panel open after the startup/onboarding decision across cloud and local sessions, while preserving authentication and consent at the first-send boundary. - **What**: Opens the panel from the approved activation flow, allows the pre-consent panel shell to render, and holds the submitted draft while the existing login/consent flow completes. - **What**: Keeps workflow-selection restoration consent-gated and records distinct `activation` / `first_message` telemetry sources. - **Dependencies**: None. Please verify the cloud/local × logged-in/logged-out × consent state matrix and that a first send resumes exactly once after the existing handoff. - `pnpm test:unit src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts src/extensions/core/agentPanel.test.ts src/components/topbar/WorkflowTabs.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts --testTimeout=30000` (454 passed) - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck` - changed-file ESLint and full format check --------- Co-authored-by: GitHub Action <action@github.com>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ⏳ Running...📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T19:07:00.135Z",
"gitSha": "9e08e5288538487d6ade80d1801aa879d2d58d30",
"branch": "backport-19154-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.2869999999998,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.290000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.35100000000006,
"heapDeltaBytes": -1031392,
"heapUsedBytes": 60776868,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.772000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.9079999999767,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.154,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.598,
"heapDeltaBytes": -8674964,
"heapUsedBytes": 58991652,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.5,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.7030000000077,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.845,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 822.955,
"heapDeltaBytes": 6718132,
"heapUsedBytes": 74402424,
"domNodes": -260,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 169.924,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.611999999971,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.341000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.006,
"heapDeltaBytes": 3336952,
"heapUsedBytes": 65035692,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 165.494,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.5359999999769,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.24,
"layouts": 6,
"layoutDurationMs": 1.1179999999999997,
"taskDurationMs": 272.428,
"heapDeltaBytes": 2849476,
"heapUsedBytes": 70540712,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.440000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.7710000000588,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.019,
"layouts": 6,
"layoutDurationMs": 1.05,
"taskDurationMs": 257.46599999999995,
"heapDeltaBytes": 2995716,
"heapUsedBytes": 71047508,
"domNodes": 80,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.332,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 673.3870000000479,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.467999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.476,
"heapDeltaBytes": 18595500,
"heapUsedBytes": 86690760,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 169.137,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 629.568000000063,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.728,
"heapDeltaBytes": 18510696,
"heapUsedBytes": 86569260,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 170.645,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1203.645999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 850.4280000000001,
"heapDeltaBytes": 38286604,
"heapUsedBytes": 106435364,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 83.229,
"eventListeners": 0,
"totalBlockingTimeMs": 584,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1224.4269999999915,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 900.097,
"heapDeltaBytes": -17255120,
"heapUsedBytes": 72676224,
"domNodes": -294,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 72.027,
"eventListeners": -217,
"totalBlockingTimeMs": 552,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.6220000000249,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.20399999999995,
"heapDeltaBytes": 14754040,
"heapUsedBytes": 91551884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.252,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.3450000000894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.4600000000003,
"heapDeltaBytes": 14656512,
"heapUsedBytes": 91028284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.466,
"eventListeners": 0,
"totalBlockingTimeMs": 228,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11197.940000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10296.812000000002,
"heapDeltaBytes": -8709692,
"heapUsedBytes": 74435728,
"domNodes": -20,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 8518.005000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1594,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10584.03300000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9731.310000000001,
"heapDeltaBytes": -11169416,
"heapUsedBytes": 70877656,
"domNodes": -14,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8051.429000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1323,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10207.562999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9261.768,
"heapDeltaBytes": 10100852,
"heapUsedBytes": 91940752,
"domNodes": -12,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 7845.280999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1105,
"frameDurationMs": 20.003333333333284,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10316.197000000102,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9517.877999999999,
"heapDeltaBytes": 18357124,
"heapUsedBytes": 95101480,
"domNodes": -8,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7807.889999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 918,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2032.6469999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.619000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.319,
"heapDeltaBytes": -3266108,
"heapUsedBytes": 83286320,
"domNodes": -241,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 34.309999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2053.1879999999774,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.484,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.778,
"heapDeltaBytes": -3570012,
"heapUsedBytes": 83686568,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.895000000000007,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2226.0390000000143,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.790999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1616.384,
"heapDeltaBytes": 20519140,
"heapUsedBytes": 84688060,
"domNodes": -246,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 830.13,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2224.230999999918,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1483.2849999999999,
"heapDeltaBytes": -12167616,
"heapUsedBytes": 76137500,
"domNodes": -246,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 851.471,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3634.91700000003,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.536000000000003,
"layouts": 60,
"layoutDurationMs": 13.225999999999999,
"taskDurationMs": 1776.7340000000002,
"heapDeltaBytes": -15312484,
"heapUsedBytes": 74137276,
"domNodes": -254,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 799.9569999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3601.1980000000676,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.955999999999998,
"layouts": 60,
"layoutDurationMs": 12.723000000000003,
"taskDurationMs": 1718.676,
"heapDeltaBytes": 8400904,
"heapUsedBytes": 74494396,
"domNodes": -7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 813.849,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3081.343000000004,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.964000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1951.487,
"heapDeltaBytes": 1332724,
"heapUsedBytes": 67083448,
"domNodes": -249,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 997.5489999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3114.1659999999547,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.559000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1901.145,
"heapDeltaBytes": 22769624,
"heapUsedBytes": 89029436,
"domNodes": 6,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 975.1,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2009.1600000000085,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.296000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.66099999999994,
"heapDeltaBytes": -4278092,
"heapUsedBytes": 84185172,
"domNodes": -246,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.318000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2002.8899999999794,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.6940000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.0730000000001,
"heapDeltaBytes": 20170088,
"heapUsedBytes": 84392692,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.47699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.0140000000142,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.519,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.873,
"heapDeltaBytes": 13021524,
"heapUsedBytes": 75353076,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.88899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.2829999999467,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.727000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.004,
"heapDeltaBytes": 14040696,
"heapUsedBytes": 84086136,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.178,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.1040000000035,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.24,
"heapDeltaBytes": -6105484,
"heapUsedBytes": 64222180,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.758000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.7809999999427,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.301,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.793,
"heapDeltaBytes": -5325164,
"heapUsedBytes": 64747644,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.476999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.6089999999913,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 726.207,
"heapDeltaBytes": -7559952,
"heapUsedBytes": 62395892,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 105.47699999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9359999999806,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.792000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.862,
"heapDeltaBytes": 5223360,
"heapUsedBytes": 75239624,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 104.89800000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.4630000000352,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.052000000000007,
"layouts": 5,
"layoutDurationMs": 13.096,
"taskDurationMs": 892.4479999999999,
"heapDeltaBytes": -6266136,
"heapUsedBytes": 82512660,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.248000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8292.752000000008,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.816,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5781.535,
"heapDeltaBytes": -17425672,
"heapUsedBytes": 69440740,
"domNodes": -216,
"jsHeapTotalBytes": 6844416,
"scriptDurationMs": 2753.694,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8398.545000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.10000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5778.4,
"heapDeltaBytes": -6355388,
"heapUsedBytes": 80501000,
"domNodes": -242,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2812.3300000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17707.57500000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17013.469,
"heapDeltaBytes": -58978068,
"heapUsedBytes": 181706808,
"domNodes": -8061,
"jsHeapTotalBytes": -20078592,
"scriptDurationMs": 270.96799999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17081.466999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16595.166999999998,
"heapDeltaBytes": -68723760,
"heapUsedBytes": 171791620,
"domNodes": -8061,
"jsHeapTotalBytes": -17195008,
"scriptDurationMs": 280.095,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21392.765999999996,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.777000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21186.661999999997,
"heapDeltaBytes": -30622852,
"heapUsedBytes": 192889204,
"domNodes": -8061,
"jsHeapTotalBytes": -18903040,
"scriptDurationMs": 910.865,
"eventListeners": -14928,
"totalBlockingTimeMs": 110,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15962.453000000096,
"styleRecalcs": 82,
"styleRecalcDurationMs": 12.641999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15502.601999999999,
"heapDeltaBytes": -40696512,
"heapUsedBytes": 187386524,
"domNodes": -8061,
"jsHeapTotalBytes": -16523264,
"scriptDurationMs": 869.839,
"eventListeners": -14928,
"totalBlockingTimeMs": 19,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6252.372000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.97299999999998,
"layouts": 20,
"layoutDurationMs": 23.264999999999993,
"taskDurationMs": 6187.643,
"heapDeltaBytes": -69344960,
"heapUsedBytes": 168041840,
"domNodes": -8061,
"jsHeapTotalBytes": 5193728,
"scriptDurationMs": 109.23299999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 446,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6211.212000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.12200000000003,
"layouts": 20,
"layoutDurationMs": 23.011000000000003,
"taskDurationMs": 6128.938,
"heapDeltaBytes": -35211572,
"heapUsedBytes": 184617448,
"domNodes": -8061,
"jsHeapTotalBytes": 16506880,
"scriptDurationMs": 107.12,
"eventListeners": -14928,
"totalBlockingTimeMs": 416,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6532.401999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6267.726,
"heapDeltaBytes": 7143180,
"heapUsedBytes": 195881296,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 109.48599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8411.090000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8210.646,
"heapDeltaBytes": 23329136,
"heapUsedBytes": 194426620,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 127.274,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 457.03199999991284,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.348000000000003,
"layouts": 2,
"layoutDurationMs": 0.593,
"taskDurationMs": 116.42000000000003,
"heapDeltaBytes": 4991328,
"heapUsedBytes": 70644208,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.027000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 101.61900000002788,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.411,
"layouts": 3,
"layoutDurationMs": 1.9169999999999998,
"taskDurationMs": 76.895,
"heapDeltaBytes": 3016348,
"heapUsedBytes": 68726612,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.127000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19631 +/- ##
=============================================
- Coverage 84.65% 84.65% -0.01%
=============================================
Files 2314 2314
Lines 131531 131562 +31
Branches 35095 35103 +8
=============================================
+ Hits 111353 111373 +20
- Misses 19820 19831 +11
Partials 358 358
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…nd (#19660) Justification: standing Agent core/1.55 backport authority; Dante approved the substantive carrier, the later delta is one independently reviewed test-only expectation repair, all exact-head required checks are green, no substantive human objection remains, and the two target-tip commits have zero file overlap with this carrier. Backports #19619 to `core/1.55` after prerequisite #19631. Conflict resolution keeps the target branch’s existing #19631 first-session consent behavior and adapts #19619’s consent/onboarding sequencing to the older target infrastructure. No flags, exposure, or other release targets are changed. Verification: - 374 focused unit tests passed - 20/22 scoped Cloud browser tests passed; all #19619 activation-sequencing cases passed, while two broader automatic-offer cases in `agentConsent.spec.ts` did not show the consent dialog within five seconds - `pnpm build:cloud` passed - app and browser typechecks passed - commit hooks (format, oxlint, eslint, knip) passed
Summary
Backports #19154 to
core/1.55so Agent opens after startup across Cloud/local and consent states, while holding the first send until consent completes.Changes
be3e1a1308while preserving the target branch’s newer composer submission/stop lifecycle, starter-prompt telemetry, and operation-minter cleanup.Verification
pnpm build:cloudartifact.pnpm build(including full typecheck) and focused lint passed.Review Focus
Please verify the target-specific
AgentPanelRoot.vueresolution preserves the existing submission lifecycle and starter-prompt telemetry while applying the consent-held first-send behavior.Backport of #19154.